Re: [RFCv3,3/3] soc_camera: initial of code

2014-04-01 Thread Josh Wu
Hi, Ben On 3/31/2014 6:10 PM, Ben Dooks wrote: On 31/03/14 10:28, Josh Wu wrote: Hi, Ben Thanks for the patch, I just test atmel-isi with the your patch, I find the mclk registered in soc-camera driver cannot be find by the soc-camera sensors. See comment in below: Ok, I guess that the

Re: [RFCv3,3/3] soc_camera: initial of code

2014-04-01 Thread Ben Dooks
On 01/04/14 07:39, Josh Wu wrote: Hi, Ben On 3/31/2014 6:10 PM, Ben Dooks wrote: On 31/03/14 10:28, Josh Wu wrote: Hi, Ben Thanks for the patch, I just test atmel-isi with the your patch, I find the mclk registered in soc-camera driver cannot be find by the soc-camera sensors. See comment in

Re: [RFCv3,3/3] soc_camera: initial of code

2014-03-31 Thread Josh Wu
Hi, Ben Thanks for the patch, I just test atmel-isi with the your patch, I find the mclk registered in soc-camera driver cannot be find by the soc-camera sensors. See comment in below: [snip] ... ... +#ifdef CONFIG_OF +static int soc_of_bind(struct soc_camera_host *ici, +

Re: [RFCv3,3/3] soc_camera: initial of code

2014-03-31 Thread Ben Dooks
On 31/03/14 10:28, Josh Wu wrote: Hi, Ben Thanks for the patch, I just test atmel-isi with the your patch, I find the mclk registered in soc-camera driver cannot be find by the soc-camera sensors. See comment in below: Ok, I guess that the driver I have does not need the mclk clock. ...