Re: [media-s3c-camif] question about arguments position

Hello Sylwester, Quoting Sylwester Nawrocki : Hi Gustavo, On 05/04/2017 09:05 PM, Gustavo A. R. Silva wrote: The issue here is that the position of arguments in the call to camif_hw_set_effect() function do not match the order of the parameters:

Re: [media-s3c-camif] question about arguments position

Hi Gustavo, On 05/04/2017 09:05 PM, Gustavo A. R. Silva wrote: > The issue here is that the position of arguments in the call to > camif_hw_set_effect() function do not match the order of the parameters: > > camif->colorfx_cb is passed to cr > camif->colorfx_cr is passed to cb > > This is the

[media-s3c-camif] question about arguments position

Hello everybody, While looking into Coverity ID 1248800 I ran into the following piece of code at drivers/media/platform/s3c-camif/camif-capture.c:67: /* Locking: called with camif->slock spinlock held */ static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp *vp) {