Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-12-01 Thread Sakari Ailus
@vger.kernel.org; tf...@chromium.org; > > mche...@kernel.org; hans.verk...@cisco.com; > > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > > ; Zheng, Jian Xu ; Hu, > > Jerry W ; Toivonen, Tuukka > > ; Qiu, Tian Shu ; Cao, > > Bingbu ; Li, Chao C > > Sub

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-29 Thread Zhi, Yong
h...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu ; Li, Chao C > Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI > > Hi Yong, > > On Fri, N

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-28 Thread Mani, Rajmohan
Hi Hans, > Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI > > On 11/07/18 00:27, Mani, Rajmohan wrote: > > Hi Mauro, > > > > Thanks for the reviews. > > > >> Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI > >>

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-16 Thread Zhi, Yong
.verk...@cisco.com; > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu ; Li, Chao C > Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI > > Hi Yong, > > Thanks fo

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-15 Thread Hans Verkuil
On 10/29/18 23:22, Yong Zhi wrote: > These meta formats are used on Intel IPU3 ImgU video queues > to carry 3A statistics and ISP pipeline parameters. > > V4L2_META_FMT_IPU3_3A > V4L2_META_FMT_IPU3_PARAMS > > Signed-off-by: Yong Zhi > Signed-off-by: Chao C Li > Signed-off-by: Rajmohan Mani >

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-15 Thread Hans Verkuil
On 11/07/18 00:27, Mani, Rajmohan wrote: > Hi Mauro, > > Thanks for the reviews. > >> Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI >> >> Hi Mauro, >> >> On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab >> wrote: >>

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-06 Thread Mani, Rajmohan
Hi Mauro, Thanks for the reviews. > Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI > > Hi Mauro, > > On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab > wrote: > > > > Em Mon, 29 Oct 2018 15:22:57 -0700 > > Yong Z

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-06 Thread Zhi, Yong
ium.org; hans.verk...@cisco.com; > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu ; Li, Chao C > Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI > > Em Mon, 29 Oc

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-02 Thread Tomasz Figa
Hi Mauro, On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab wrote: > > Em Mon, 29 Oct 2018 15:22:57 -0700 > Yong Zhi escreveu: [snip] > > +struct ipu3_uapi_awb_config_s { > > + __u16 rgbs_thr_gr; > > + __u16 rgbs_thr_r; > > + __u16 rgbs_thr_gb; > > + __u16 rgbs_thr_b; > > +

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-02 Thread Mauro Carvalho Chehab
Em Mon, 29 Oct 2018 15:22:57 -0700 Yong Zhi escreveu: > These meta formats are used on Intel IPU3 ImgU video queues > to carry 3A statistics and ISP pipeline parameters. Just minor things. See below. > > V4L2_META_FMT_IPU3_3A > V4L2_META_FMT_IPU3_PARAMS > > Signed-off-by: Yong Zhi >

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-02 Thread Sakari Ailus
Hi Yong, Thanks for the update! I went through this again... a few comments below but I'd say they're mostly pretty minor issues. On Mon, Oct 29, 2018 at 03:22:57PM -0700, Yong Zhi wrote: > These meta formats are used on Intel IPU3 ImgU video queues > to carry 3A statistics and ISP pipeline