Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Simon Horman
Hi Kieran, On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > The rvin_digital_notify_bound() call dereferences the subdev->dev > pointer to obtain the of_node. On some error paths, this dev node can be > set as

Re: [PATCH] dma-buf: avoid scheduling on fence status query

2017-04-26 Thread Christian König
NAK, I'm wondering how often I have to reject that change. We should probably add a comment here. Even with a zero timeout we still need to enable signaling, otherwise some fence will never signal if userspace just polls on them. If a caller is only interested in the fence status without

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

2017-04-26 Thread Christian König
Am 25.04.2017 um 20:20 schrieb Logan Gunthorpe: This patch introduces functions which kmap the pages inside an sgl. These functions replace a common pattern of kmap(sg_page(sg)) that is used in more than 50 places within the kernel. The motivation for this work is to eventually safely support

Re: [PATCH v2 02/21] libiscsi: Add an internal error code

2017-04-26 Thread Christoph Hellwig
On Tue, Apr 25, 2017 at 12:20:49PM -0600, Logan Gunthorpe wrote: > This is a prep patch to add a new error code to libiscsi. We want to > rework some kmap calls to be able to fail. When we do, we'd like to > use this error code. The kmap case in iscsi_tcp_segment_map can already fail. Please add

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Niklas Söderlund
Hi Simon, Thanks for your feedback. On 2017-04-26 09:23:20 +0200, Simon Horman wrote: > Hi Kieran, > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > > From: Kieran Bingham > > > > The rvin_digital_notify_bound() call dereferences

Re: [PATCH] dma-buf: avoid scheduling on fence status query

2017-04-26 Thread Christian König
Am 26.04.2017 um 11:59 schrieb Dave Airlie: On 26 April 2017 at 17:20, Christian König wrote: NAK, I'm wondering how often I have to reject that change. We should probably add a comment here. Even with a zero timeout we still need to enable signaling, otherwise some

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 08:48:25AM +0100, Kieran Bingham wrote: > Hi Simon, > > On 26/04/17 08:23, Simon Horman wrote: > > Hi Kieran, > > > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > >> From: Kieran Bingham > >> > >> The

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

2017-04-26 Thread Roger Pau Monné
On Tue, Apr 25, 2017 at 12:21:02PM -0600, Logan Gunthorpe wrote: > Straightforward conversion to the new helper, except due to the lack > of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in > certain cases in the future. > > Signed-off-by: Logan Gunthorpe

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

2017-04-26 Thread Christoph Hellwig
On Tue, Apr 25, 2017 at 12:20:48PM -0600, Logan Gunthorpe wrote: > This patch introduces functions which kmap the pages inside an sgl. > These functions replace a common pattern of kmap(sg_page(sg)) that is > used in more than 50 places within the kernel. > > The motivation for this work is to

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 11:00:30AM +0200, Niklas Söderlund wrote: > Hi Simon, > > Thanks for your feedback. > > On 2017-04-26 09:23:20 +0200, Simon Horman wrote: > > Hi Kieran, > > > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > > > From: Kieran Bingham

Re: [PATCH] dma-buf: avoid scheduling on fence status query

2017-04-26 Thread Dave Airlie
On 26 April 2017 at 17:20, Christian König wrote: > NAK, I'm wondering how often I have to reject that change. We should > probably add a comment here. > > Even with a zero timeout we still need to enable signaling, otherwise some > fence will never signal if userspace

Re: [PATCH] rc-core: use the full 32 bits for NEC scancodes

2017-04-26 Thread Sean Young
On Tue, Apr 25, 2017 at 07:58:09AM +, David Härdeman wrote: > April 24, 2017 5:58 PM, "Sean Young" wrote: > > On Tue, Apr 18, 2017 at 05:50:27PM +0200, David Härdeman wrote: > >> Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core > >> and the nec decoder

[patch] propagating controls in libv4l2 was Re: support autofocus / autogain in libv4l2

2017-04-26 Thread Pavel Machek
Hi! > > > IMO, the best place for autofocus is at libv4l2. Putting it on a > > > separate "video server" application looks really weird for me. > > > > Well... let me see. libraries are quite limited -- it is hard to open > > files, or use threads/have custom main loop. It may be useful to > >

Re: support autofocus / autogain in libv4l2

2017-04-26 Thread Pavel Machek
On Tue 2017-04-25 12:53:27, Nicolas Dufresne wrote: > Le mardi 25 avril 2017 à 10:05 +0200, Pavel Machek a écrit : > > Well, fd's are hard, because application can do fork() and now > > interesting stuff happens. Threads are tricky, because now you have > > locking etc. > > > > libv4l2 is

Re: [patch] propagating controls in libv4l2 was Re: support autofocus / autogain in libv4l2

2017-04-26 Thread Mauro Carvalho Chehab
Hi Pavel, Em Wed, 26 Apr 2017 12:53:00 +0200 Pavel Machek escreveu: > Hi! > > > > > IMO, the best place for autofocus is at libv4l2. Putting it on a > > > > separate "video server" application looks really weird for me. > > > > > > Well... let me see. libraries are quite

Re: [patch] propagating controls in libv4l2 was Re: support autofocus / autogain in libv4l2

2017-04-26 Thread Mauro Carvalho Chehab
Em Wed, 26 Apr 2017 12:53:00 +0200 Pavel Machek escreveu: > Hi! > > > > > IMO, the best place for autofocus is at libv4l2. Putting it on a > > > > separate "video server" application looks really weird for me. > > > > > > Well... let me see. libraries are quite limited -- it

Re: [PATCH] dma-buf: avoid scheduling on fence status query

2017-04-26 Thread Andres Rodriguez
On 2017-04-26 06:13 AM, Christian König wrote: Am 26.04.2017 um 11:59 schrieb Dave Airlie: On 26 April 2017 at 17:20, Christian König wrote: NAK, I'm wondering how often I have to reject that change. We should probably add a comment here. Even with a zero timeout

[patch] autogain support for bayer10 format (was Re: [patch] propagating controls in libv4l2)

2017-04-26 Thread Pavel Machek
Hi! > > > I don't see why it would be hard to open files or have threads inside > > > a library. There are several libraries that do that already, specially > > > the ones designed to be used on multimidia apps. > > > > Well, This is what the libv4l2 says: > > > >This file implements

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-26 Thread Tobias Jakobi
Hello everyone, Nicolas Dufresne wrote: > Le mercredi 26 avril 2017 à 01:21 +0300, Sakari Ailus a écrit : >> Hi Marek, >> >> On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote: >>> Hi Laurent, >>> >>> On 2017-04-20 12:25, Laurent Pinchart wrote: Hi Marek, (CC'ing

Re: [patch] autogain support for bayer10 format (was Re: [patch] propagating controls in libv4l2)

2017-04-26 Thread Ivaylo Dimitrov
Hi, On 26.04.2017 16:23, Pavel Machek wrote: Hi! I don't see why it would be hard to open files or have threads inside a library. There are several libraries that do that already, specially the ones designed to be used on multimidia apps. Well, This is what the libv4l2 says: This file

[PATCH] dma-buf: avoid scheduling on fence status query v2

2017-04-26 Thread Andres Rodriguez
When a timeout of zero is specified, the caller is only interested in the fence status. In the current implementation, dma_fence_default_wait will always call schedule_timeout() at least once for an unsignaled fence. This adds a significant overhead to a fence status query. Avoid this overhead

Re: [PATCH] dma-buf: avoid scheduling on fence status query v2

2017-04-26 Thread Christian König
Am 26.04.2017 um 16:46 schrieb Andres Rodriguez: When a timeout of zero is specified, the caller is only interested in the fence status. In the current implementation, dma_fence_default_wait will always call schedule_timeout() at least once for an unsignaled fence. This adds a significant

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-26 Thread Nicolas Dufresne
Le mercredi 26 avril 2017 à 01:21 +0300, Sakari Ailus a écrit : > Hi Marek, > > On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote: > > Hi Laurent, > > > > On 2017-04-20 12:25, Laurent Pinchart wrote: > > > Hi Marek, > > > > > > (CC'ing Sakari Ailus) > > > > > > Thank you for the

em28xx debug module parameters

2017-04-26 Thread Frank Schäfer
Hi Mauro, is there a chance that we can clean up the em28xx debug module parameter mess ? There are currently 8 (!) of them. Do we have to maintain them all forever as "stable userspace interface" ? For example: - "reg_debug" is actually used for usb control message debugging - "core_debug" is

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-26 Thread Tobias Jakobi
Hello again, Nicolas Dufresne wrote: > Le mercredi 26 avril 2017 à 01:21 +0300, Sakari Ailus a écrit : >> Hi Marek, >> >> On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote: >>> Hi Laurent, >>> >>> On 2017-04-20 12:25, Laurent Pinchart wrote: Hi Marek, (CC'ing Sakari

Re: [PATCH v2 0/3] r8a7793 Gose video input support

2017-04-26 Thread Laurent Pinchart
Hi Ulrich, On Tuesday 21 Feb 2017 01:42:15 Laurent Pinchart wrote: > On Thursday 20 Oct 2016 10:49:11 Simon Horman wrote: > > On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote: > >> Hi! > >> > >> This is a by-the-datasheet implementation of analog and digital video > >> input on the

Re: [PATCH] [RFC] em28xx: allow setting the eeprom bus at cards struct

2017-04-26 Thread Frank Schäfer
Am 25.04.2017 um 12:06 schrieb Mauro Carvalho Chehab: > Right now, all devices use bus 0 for eeprom. However, > it seems that newer versions of Terratec H6 uses a different > buffer for eeprom. > > So, add support to use a different I2C address for eeprom and > add a new card ID for the board

[PATCH] em28xx: fix+improve the register (usb control message) debugging

2017-04-26 Thread Frank Schäfer
- avoid duplicate debugging messages in em28xx_read_reg_req_len() - do not describe successful usb transfers in em28xx_read_reg_len() as "failed" - report errors in em28xx_write_regs_req(), too - print the usb error numbers, too Signed-off-by: Frank Schäfer ---

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Kieran Bingham
Hi Simon, On 26/04/17 08:23, Simon Horman wrote: > Hi Kieran, > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham >> >> The rvin_digital_notify_bound() call dereferences the subdev->dev >> pointer to obtain the

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-26 Thread Nicolas Dufresne
Le mercredi 26 avril 2017 à 21:31 +0200, Tobias Jakobi a écrit : > I'm pretty sure you have misread Marek's description of the patchset. > The picture processor API should replaced/deprecate the IPP API that is > currently implemented in the Exynos DRM. > > In particular this affects the

Re: [PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-04-26 Thread Jacek Anaszewski
On 04/26/2017 04:54 AM, Alexandre Courbot wrote: > On Wed, Apr 26, 2017 at 4:15 AM, Jacek Anaszewski > wrote: >> Hi Alexandre, >> >> Thanks for the patch. >> >> On 04/25/2017 08:19 AM, Alexandre Courbot wrote: >>> v4l2_m2m_job_finish(), which is called from the

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-26 Thread Tobias Jakobi
Hey, Nicolas Dufresne wrote: > Le mercredi 26 avril 2017 à 18:52 +0200, Tobias Jakobi a écrit : >> Hello again, >> >> >> Nicolas Dufresne wrote: >>> Le mercredi 26 avril 2017 à 01:21 +0300, Sakari Ailus a écrit : Hi Marek, On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

2017-04-26 Thread Logan Gunthorpe
On 26/04/17 01:44 AM, Christoph Hellwig wrote: > I think we'll at least need a draft of those to make sense of these > patches. Otherwise they just look very clumsy. Ok, I'll work up a draft proposal and send it in a couple days. But without a lot of cleanup such as this series it's not going

[bug] omap3isp: missing support for ENUM_FMT

2017-04-26 Thread Pavel Machek
Hi! Currently, ispvideo.c does not support enum_format. This causes problems for example for libv4l2. Now, I'm pretty sure patch below is not the right fix. But it fixes libv4l2 problem for me. Pointer to right solution welcome. Regards,

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-26 Thread Nicolas Dufresne
Le mercredi 26 avril 2017 à 18:52 +0200, Tobias Jakobi a écrit : > Hello again, > > > Nicolas Dufresne wrote: > > Le mercredi 26 avril 2017 à 01:21 +0300, Sakari Ailus a écrit : > > > Hi Marek, > > > > > > On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote: > > > > Hi Laurent, > >

Re: [patch] autogain support for bayer10 format (was Re: [patch] propagating controls in libv4l2)

2017-04-26 Thread Pavel Machek
Hi! > >>There are two separate things here: > >> > >>1) Autofoucs for a device that doesn't use subdev API > >>2) libv4l2 support for devices that require MC and subdev API > > > >Actually there are three: 0) autogain. Unfortunately, I need autogain > >first before autofocus has a chance... > > >

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

2017-04-26 Thread Logan Gunthorpe
On 26/04/17 02:59 AM, wrote: > Good to know that somebody is working on this. Those problems troubled > us as well. Thanks Christian. It's a daunting problem and a there's a lot of work to do before we will ever be where we need to be so any help, even an ack, is greatly appreciated. Logan

cron job: media_tree daily build: ERRORS

2017-04-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Apr 27 05:00:16 CEST 2017 media-tree git hash:3622d3e77ecef090b5111e3c5423313f11711dfa media_build

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-26 Thread Herbert Xu
On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > Very straightforward conversion to the new function in the caam driver > and shash library. > > Signed-off-by: Logan Gunthorpe > Cc: Herbert Xu > Cc: "David S. Miller"

Re: [patch] autogain support for bayer10 format (was Re: [patch] propagating controls in libv4l2)

2017-04-26 Thread Ivaylo Dimitrov
On 27.04.2017 01:51, Pavel Machek wrote: Hi! There are two separate things here: 1) Autofoucs for a device that doesn't use subdev API 2) libv4l2 support for devices that require MC and subdev API Actually there are three: 0) autogain. Unfortunately, I need autogain first before autofocus