Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread David Daney
) { /* * Trick the compiler because we don't want to * handle error conditions. */ return; } . . . i_really_know_what_i_am_doing(dummy); David Daney -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-15 Thread David Daney
On 06/15/2010 04:40 AM, Jean Delvare wrote: Hi David, On Mon, 14 Jun 2010 14:28:57 -0700, David Daney wrote: On 06/14/2010 01:53 PM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning

Re: [PATCH] gpio: removes all usage of gpiochip_remove retval

2014-05-29 Thread David Daney
On 05/29/2014 02:54 PM, abdoulaye berthe wrote: Did you forget a changelog explaining why this is either needed, or even a good idea? I joined the conversation late and don't know why you are doing this. Thanks, David Daney Signed-off-by: abdoulaye berthe berthe...@gmail.com --- arch

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread David Daney
with gpios still requested\n); panic? NACK to the patch for this reason. The strongest thing you should do here is WARN. That said, I am not sure why we need this whole patch set in the first place. David Daney Is this likely to happen? Gr{oetje,eeting}s

Re: [PATCH 1/4] i2c: busses: make i2c_adapter const

2017-08-22 Thread David Daney
On 08/19/2017 03:34 AM, Bhumika Goyal wrote: Make these const as they are only used in a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> i2c-octeon-platdrv.c and i2c-thunderx-pcidrv.c changes: Acked-by: David Daney <david.da...@cavium.com