Re: Handling of large keycodes

2010-08-06 Thread David Härdeman
? -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Handling of large keycodes

2010-08-06 Thread David Härdeman
ok on removing them. The parameters that we'll need for the ir subsystem can be implemented in a different way in the future (with no changes necessary to the input subsystem) so I'm also ok with removing them. -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH 0/3] Proposed ir-core (rc-core) changes

2010-08-24 Thread David Härdeman
the control of rc-core. I was hoping that Jarod would be willing to convert the imon driver to create a separate input device for sending mouse events to userspace :) Comments please... --- David Härdeman (3): merge rc-core remove remaining users of the ir-functions keyhandlers

[PATCH 2/3] remove remaining users of the ir-functions keyhandlers

2010-08-24 Thread David Härdeman
This patch removes the remaining usages of the ir_input_nokey() and ir_input_keydown() functions provided by drivers/media/IR/ir-functions.c by using the corresponding functionality in rc-core directly instead. --- drivers/media/IR/ir-functions.c | 96 ++-

Re: [PATCH 0/3] Proposed ir-core (rc-core) changes

2010-08-27 Thread David Härdeman
On Thu, August 26, 2010 21:14, Jarod Wilson wrote: On Wed, Aug 25, 2010 at 01:01:57AM +0200, David Härdeman wrote: The following series merges the different files that currently make up the ir-core module into a single-file rc-core module. In addition, the ir_input_dev and ir_dev_props

Re: IR code autorepeat issue?

2010-08-31 Thread David Härdeman
complexity). -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/5] rc-core: ir-core to rc-core conversion

2010-09-02 Thread David Härdeman
over to rc-core. Given the changes, these patches touch every single driver. Obviously I haven't tested them all due to a lack of hardware (I have made sure that all drivers compile without any warnings and I have tested the end result on mceusb and winbond-cir hardware). --- David Härdeman (5

[PATCH 2/5] rc-core: remove remaining users of the ir-functions keyhandlers

2010-09-02 Thread David Härdeman
This patch removes the remaining usages of the ir_input_nokey() and ir_input_keydown() functions provided by drivers/media/IR/ir-functions.c by using the corresponding functionality in rc-core directly instead. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/ir-functions.c

[PATCH 3/5] imon: split mouse events to a separate input dev

2010-09-02 Thread David Härdeman
the code wouldn't have worked on a big-endian machine... Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/imon.c | 261 +++ 1 files changed, 150 insertions(+), 111 deletions(-) diff --git a/drivers/media/IR/imon.c b/drivers/media

Re: [PATCH 0/5] rc-core: ir-core to rc-core conversion

2010-09-02 Thread David Härdeman
On Thu, Sep 02, 2010 at 10:29:50PM +0200, David Härdeman wrote: This is my current patch queue, the main change is to make struct rc_dev the primary interface for rc drivers and to abstract away the fact that there's an input device lurking in there somewhere. The first three patches

Re: [PATCH 6/7] IR: extend ir_raw_event and do refactoring

2010-09-02 Thread David Härdeman
; Wouldn't DEFINE_RAW_EVENT(ev); be more in line with the kernel coding style? (cf. DEFINE_MUTEX, DEFINE_SPINLOCK, etc). -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 6/7] IR: extend ir_raw_event and do refactoring

2010-09-02 Thread David Härdeman
style? (cf. DEFINE_MUTEX, DEFINE_SPINLOCK, etc). Of course, nothing against that. DEFINE_RC_RAW_EVENT() is probably better by the way... -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 0/8 V3] Many fixes for in-kernel decoding and for the ENE driver

2010-09-05 Thread David Härdeman
On Sun, Sep 05, 2010 at 02:22:55AM +0300, Maxim Levitsky wrote: Hi, This is next version of my patchset. I addressed the comments from David Härdeman, And in addition to that did a lot of cleanups in the ENE driver. This includes new idle mode support that doesn't need 75

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-05 Thread David Härdeman
, .duration = 0 }; + DEFINE_RC_RAW_EVENT(ev); + ev.reset = true; + ir_raw_event_store(input_dev, ev); ir_raw_event_handle(input_dev); } -- 1.7.0.4 -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [PATCH 0/8 V5] Many fixes for in-kernel decoding and for the ENE driver

2010-09-06 Thread David Härdeman
On Tue, Sep 07, 2010 at 12:26:05AM +0300, Maxim Levitsky wrote: Hi, Here is full overview of my patches: What changed from V4? -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH 0/5] rc-core: ir-core to rc-core conversion (v2)

2010-09-07 Thread David Härdeman
recent streamzap driver changes into account --- David Härdeman (5): rc-code: merge and rename ir-core rc-core: remove remaining users of the ir-functions keyhandlers imon: split mouse events to a separate input dev rc-core: make struct rc_dev the primary interface for rc

[PATCH 2/5] rc-core: remove remaining users of the ir-functions keyhandlers

2010-09-07 Thread David Härdeman
This patch removes the remaining usages of the ir_input_nokey() and ir_input_keydown() functions provided by drivers/media/IR/ir-functions.c by using the corresponding functionality in rc-core directly instead. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/ir-functions.c

[PATCH 3/5] imon: split mouse events to a separate input dev

2010-09-07 Thread David Härdeman
the code wouldn't have worked on a big-endian machine... Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/imon.c | 261 +++ 1 files changed, 150 insertions(+), 111 deletions(-) diff --git a/drivers/media/IR/imon.c b/drivers/media

Re: [PATCH 1/5] rc-code: merge and rename ir-core

2010-09-08 Thread David Härdeman
file, both when I'm new to a subsystem and when I'm used to it. drivers/input/input.c and drivers/input/evdev.c come to mind as good examples. But more importantly, how about focusing on the people actually writing patches for ir-core rather than hypotetical people? -- David Härdeman

Re: [PATCH 4/6] Input: winbond-cir - switch to using new keycode interface

2010-09-08 Thread David Härdeman
ioctls and I have a patch lined up that converts winbond-cir.c to use ir-core which means all of the input related code is removed. -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/2] ir-core: centralize sysfs raw decoder enabling/disabling

2010-09-08 Thread David Härdeman
have the file. -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] rc-code: merge and rename ir-core

2010-09-08 Thread David Härdeman
On Wed, Sep 08, 2010 at 10:42:10AM -0300, Mauro Carvalho Chehab wrote: Em 07-09-2010 18:51, David Härdeman escreveu: This patch merges the files which makes up ir-core and renames the resulting module to rc-core. IMHO this makes it much easier to hack on the core module since all code

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread David Härdeman
On Wed, Sep 08, 2010 at 07:42:04PM -0300, Mauro Carvalho Chehab wrote: Em 06-09-2010 18:26, Maxim Levitsky escreveu: Add new event types for timeout carrier report Move timeout handling from ir_raw_event_store_with_filter to ir-lirc-codec, where it is really needed. Now lirc bridge

Re: [PATCH 4/6] Input: winbond-cir - switch to using new keycode interface

2010-09-08 Thread David Härdeman
On Wed, Sep 08, 2010 at 04:00:04PM -0700, Dmitry Torokhov wrote: On Wed, Sep 08, 2010 at 11:16:17PM +0200, David Härdeman wrote: On Wed, Sep 08, 2010 at 12:42:00AM -0700, Dmitry Torokhov wrote: Switch the code to use new style of getkeycode and setkeycode methods to allow retrieving

Re: [PATCH 5/8] IR: extend MCE keymap.

2010-09-10 Thread David Härdeman
since it already has input plugins (e.g. for using a Nintendo Wii controller, etc). -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] imon: split mouse events to a separate input dev

2010-09-16 Thread David Härdeman
to a bswab64() call, irregardless of the cpu endianness, and I think the code wouldn't have worked on a big-endian machine... Signed-off-by: David Härdeman da...@hardeman.nu - Minor alterations to apply with minimal core IR changes - Use timer for imon keys too, since its entirely possible

Re: [PATCH 2/4] imon: split mouse events to a separate input dev

2010-09-16 Thread David Härdeman
On Thu, September 16, 2010 15:34, Jarod Wilson wrote: On Thu, Sep 16, 2010 at 01:32:07PM +0200, David Härdeman wrote: On Thu, September 16, 2010 07:22, Jarod Wilson wrote: This is a stab at separating the mouse (and front panel/knob) events out to a separate input device. This is necessary

Re: [PATCH 0/3] Remaining patches in my queue for IR

2010-10-20 Thread David Härdeman
subsystem to land (somewhere around 2.6.37-rc1 supposedly) and then resend my patchset based on the media_tree/staging/v2.6.37 tree at that point? -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/3] IR: extend ir_raw_event and do refactoring

2010-10-23 Thread David Härdeman
of ir_raw_event_store_with_filter() though so the patch should still go in. Acked-by: David Härdeman da...@hardeman.nu -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/7] rc-core: ir-core to rc-core conversion

2010-10-29 Thread David Härdeman
merged upstream). Given the changes, these patches touch every single driver. Obviously I haven't tested them all due to a lack of hardware (I have made sure that all drivers compile without any warnings and I have tested the end result on mceusb and winbond-cir hardware). --- David Härdeman (7

[PATCH 1/7] ir-core: dummy patch to base my work on top of Dmitry's large scancode work

2010-10-29 Thread David Härdeman
This patch adds the changes from Dmitry's large scancode work for the input subsystem (the patches to the input core and to rc-core which were accepted upstream). Not to be applied :) Not-signed-off-by: Anyone --- drivers/char/keyboard.c| 31 ++- drivers/input/evdev.c | 100

[PATCH 2/7] ir-core: convert drivers/media/video/cx88 to ir-core

2010-10-29 Thread David Härdeman
for two weeks!) on actual hardware. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/ir-functions.c | 134 --- drivers/media/video/cx88/Kconfig |2 drivers/media/video/cx88/cx88-input.c | 163 +++-- include

[PATCH 3/7] ir-core: remove remaining users of the ir-functions keyhandlers

2010-10-29 Thread David Härdeman
This patch removes the remaining usages of the ir_input_nokey() and ir_input_keydown() functions provided by drivers/media/IR/ir-functions.c by using the corresponding functionality in ir-core instead. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/imon.c

[PATCH 4/7] ir-core: more cleanups of ir-functions.c

2010-10-29 Thread David Härdeman
function exported by ir-functions). Rename VIDEO_IR - IR_LEGACY to give a hint to anyone writing or converting drivers to IR_CORE that they do not want a dependency on IR_LEGACY. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/Kconfig |2 +- drivers/media/IR

Re: [RFC PATCH 0/2] Apple remote support

2010-10-29 Thread David Härdeman
and have a keymap with all the different variations. -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] mceusb: fix up reporting of trailing space

2010-10-29 Thread David Härdeman
simplified by using ir_raw_event_store_with_filter(), right? -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 0/2] Apple remote support

2010-10-29 Thread David Härdeman
On Fri, Oct 29, 2010 at 03:27:33PM -0400, Jarod Wilson wrote: On Fri, Oct 29, 2010 at 09:17:11PM +0200, David Härdeman wrote: On Fri, Oct 29, 2010 at 11:11:41AM -0400, Jarod Wilson wrote: So the Apple remotes do something funky... One of the four bytes is a remote identifier byte, which

[PATCH] drivers/media/IR/ir-keytable.c: fix binary search

2010-10-30 Thread David Härdeman
The input-large-scancode patches changed the binary search in drivers/media/IR/ir-keytable.c to use unsigned integers, but signed integers are actually necessary for the algorithm to work. Signed-off-by: David Härdeman da...@hardeman.nu Cc: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers

Re: [RFC PATCH 0/2] Apple remote support

2010-10-30 Thread David Härdeman
On Fri, Oct 29, 2010 at 04:09:37PM -0400, Jarod Wilson wrote: On Fri, Oct 29, 2010 at 09:59:18PM +0200, David Härdeman wrote: On Fri, Oct 29, 2010 at 03:27:33PM -0400, Jarod Wilson wrote: On Fri, Oct 29, 2010 at 09:17:11PM +0200, David Härdeman wrote: On Fri, Oct 29, 2010 at 11:11:41AM

Re: [RFC PATCH 0/2] Apple remote support

2010-11-01 Thread David Härdeman
On Sat, Oct 30, 2010 at 10:32:14PM -0400, Jarod Wilson wrote: On Sat, Oct 30, 2010 at 7:36 PM, David Härdeman da...@hardeman.nu wrote: In that case, one solution would be: * using the full 32 bit scancode * add a module parameter to squash the ID byte to zero * default the module

Re: [PATCH 0/7] rc-core: ir-core to rc-core conversion

2010-11-01 Thread David Härdeman
On Fri, Oct 29, 2010 at 09:07:52PM +0200, David Härdeman wrote: This is my current patch queue, the main change is to make struct rc_dev the primary interface for rc drivers and to abstract away the fact that there's an input device lurking in there somewhere. The patchset has been updated

[PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-02 Thread David Härdeman
that all drivers compile without any warnings and I have tested the end result on mceusb and winbond-cir hardware, Jarod Wilson has tested nuvoton-cir, imon and several mceusb devices). --- David Härdeman (6): ir-core: convert drivers/media/video/cx88 to ir-core ir-core: remove

[PATCH 1/6] ir-core: convert drivers/media/video/cx88 to ir-core

2010-11-02 Thread David Härdeman
for two weeks!) on actual hardware. Signed-off-by: David Härdeman da...@hardeman.nu Acked-by: Jarod Wilson ja...@redhat.com --- drivers/media/IR/ir-functions.c | 134 --- drivers/media/video/cx88/Kconfig |2 drivers/media/video/cx88/cx88-input.c | 163

[PATCH 2/6] ir-core: remove remaining users of the ir-functions keyhandlers

2010-11-02 Thread David Härdeman
This patch removes the remaining usages of the ir_input_nokey() and ir_input_keydown() functions provided by drivers/media/IR/ir-functions.c by using the corresponding functionality in ir-core instead. Signed-off-by: David Härdeman da...@hardeman.nu Acked-by: Jarod Wilson ja...@redhat.com

[PATCH 3/6] ir-core: more cleanups of ir-functions.c

2010-11-02 Thread David Härdeman
function exported by ir-functions). Rename VIDEO_IR - IR_LEGACY to give a hint to anyone writing or converting drivers to IR_CORE that they do not want a dependency on IR_LEGACY. Signed-off-by: David Härdeman da...@hardeman.nu Acked-by: Jarod Wilson ja...@redhat.com --- drivers/media/IR/Kconfig

Re: [PATCH 2/3] mceusb: fix up reporting of trailing space

2010-11-03 Thread David Härdeman
On Tue, 2 Nov 2010 17:12:14 -0400, Jarod Wilson ja...@redhat.com wrote: On Fri, Oct 29, 2010 at 09:21:21PM +0200, David Härdeman wrote: I think the driver could be further simplified by using ir_raw_event_store_with_filter(), right? And in fact, it is. I've got a new series of patches

Re: [RFC PATCH 0/2] Apple remote support

2010-11-04 Thread David Härdeman
On Tue, 2 Nov 2010 16:42:05 -0400, Jarod Wilson ja...@wilsonet.com wrote: On Mon, Nov 1, 2010 at 5:56 PM, David Härdeman da...@hardeman.nu wrote: On Sat, Oct 30, 2010 at 10:32:14PM -0400, Jarod Wilson wrote: On Sat, Oct 30, 2010 at 7:36 PM, David Härdeman da...@hardeman.nu wrote

Re: [RFC PATCH 0/2] Apple remote support

2010-11-04 Thread David Härdeman
I'm all for using a 32 bit scancode in all cases (and still using a module param to squash the ID byte of apple remotes, defaulting to yes). -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [RFC PATCH 0/2] Apple remote support

2010-11-05 Thread David Härdeman
On Thu, 04 Nov 2010 15:43:33 -0400, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 04-11-2010 15:38, David Härdeman escreveu: On Thu, Nov 04, 2010 at 11:54:25AM -0400, Jarod Wilson wrote: Okay, so we seem to be in agreement for an approach to handling this. I'll toss something together

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-09 Thread David Härdeman
On Tue, 02 Nov 2010 21:17:38 +0100, David Härdeman da...@hardeman.nu wrote: This is my current patch queue, the main change is to make struct rc_dev the primary interface for rc drivers and to abstract away the fact that there's an input device lurking in there somewhere. Mauro, you have

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread David Härdeman
On Tue, 09 Nov 2010 23:50:17 -0200, Mauro Carvalho Chehab mche...@infradead.org wrote: Hi David, Em 02-11-2010 18:26, Jarod Wilson escreveu: On Tue, Nov 2, 2010 at 4:17 PM, David Härdeman da...@hardeman.nu wrote: This is my current patch queue, the main change is to make struct rc_dev

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread David Härdeman
://git.kernel.org/?p=linux/kernel/git/jarod/linux-2.6-ir.git;a=shortlog;h=refs/heads/staging Still does, and it's no wonder it doesn't apply to staging/for_v2.6.38 since it's a franken-branch of 2.6.36 + staging/for_v2.6.37 + some more patches. -- David Härdeman -- To unsubscribe from this list

Re: [PATCH 6/7] ir-core: make struct rc_dev the primary interface

2010-11-10 Thread David Härdeman
On Wed, 10 Nov 2010 02:31:24 -0200, Mauro Carvalho Chehab mche...@infradead.org wrote: Em 29-10-2010 17:08, David Härdeman escreveu: This patch merges the ir_input_dev and ir_dev_props structs into a single struct called rc_dev. The drivers and various functions in rc-core used by the drivers

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread David Härdeman
On Wed, 10 Nov 2010 10:49:10 -0200, Mauro Carvalho Chehab mche...@infradead.org wrote: Em 10-11-2010 07:24, David Härdeman escreveu: Not sure if you used the most recent version of patch 4/6 or not. If you used the most recent, it's based on 2.6.37-rc1 upstream which has both the large-input

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread David Härdeman
On Wed, Nov 10, 2010 at 02:24:16PM -0200, Mauro Carvalho Chehab wrote: Em 10-11-2010 11:06, David Härdeman escreveu: On Wed, 10 Nov 2010 10:49:10 -0200, Mauro Carvalho Chehab mche...@infradead.org wrote: So, I'll try to merge the pending patches from your tree. I'll let you know if I

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread David Härdeman
of the changes I did (see for example drivers/media/dvb/dvb-usb/dib0700_devices.c which had similar requirements to struct IR_i2c). So, I think we should re-think about your patch 6/7. What's your suggestion? Comments? Unsurprisingly, I disagree on the whole re-think part :) -- David Härdeman

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread David Härdeman
On Thu, Nov 11, 2010 at 02:00:38PM -0200, Mauro Carvalho Chehab wrote: Em 11-11-2010 13:19, David Härdeman escreveu: On Thu, 11 Nov 2010 11:54:30 -0200, Mauro Carvalho Chehab mche...@infradead.org wrote: The bad news is that ir-kbd-i2c also needs the stuff that are inside ir.props (e. g

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-12 Thread David Härdeman
On Thu, Nov 11, 2010 at 06:40:42PM -0500, Jarod Wilson wrote: On Thu, Nov 11, 2010 at 3:35 PM, David Härdeman da...@hardeman.nu wrote: On Thu, Nov 11, 2010 at 02:00:38PM -0200, Mauro Carvalho Chehab wrote: I like the idea of having an inlined function (like usb_fill_control_urb), to be sure

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-12 Thread David Härdeman
On Fri, Nov 12, 2010 at 02:00:55AM -0200, Mauro Carvalho Chehab wrote: Em 11-11-2010 21:40, Jarod Wilson escreveu: On Thu, Nov 11, 2010 at 3:35 PM, David Härdeman da...@hardeman.nu wrote: On Thu, Nov 11, 2010 at 02:00:38PM -0200, Mauro Carvalho Chehab wrote: A good exercise would be to port

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-12 Thread David Härdeman
On Fri, Nov 12, 2010 at 10:56:34AM -0200, Mauro Carvalho Chehab wrote: Em 12-11-2010 10:12, David Härdeman escreveu: Shouldn't platform_data be const? And you'll break the refcounting done in rc_allocate_device() and rc_free_device() / rc_unregister_device(). Not to mention the silent bugs

Raw mode for SAA7134_BOARD_ENCORE_ENLTV_FM53?

2010-11-12 Thread David Härdeman
similar to what you committed for SAA7134_BOARD_ASUSTeK_P7131_ANALOG? -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] [media] ir-kbd-i2c: add rc_dev as a parameter to the driver

2010-11-12 Thread David Härdeman
is to create rc_dev inside the drivers, in order to fill other fields, like open(), close(), driver_name, etc. So, a latter patch making it mandatory and changing the caller drivers is welcome. Looks good, no objections. Sorry for misinterpreting your suggested change. -- David Härdeman

Re: Raw mode for SAA7134_BOARD_ENCORE_ENLTV_FM53?

2010-11-12 Thread David Härdeman
On Fri, Nov 12, 2010 at 12:23:56PM -0200, Mauro Carvalho Chehab wrote: Em 12-11-2010 12:14, David Härdeman escreveu: Mauro, as far as I could tell, you wrote the initial support for SAA7134_BOARD_ENCORE_ENLTV_FM53 in drivers/media/video/saa7134/saa7134-input.c, right? It appears

Re: [PATCH 0/3] Remove ir-common module

2010-11-13 Thread David Härdeman
not be easy to find someone with such hardware. Excellent, this was exactly what I was hoping for :) -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [RFC PATCH 0/2] Apple remote support

2010-11-15 Thread David Härdeman
lookup. -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 0/2] Apple remote support

2010-11-16 Thread David Härdeman
(though I still think we should use the new large scancode API to let userspace properly indicate the protocol along with the scancode in the future). -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

media_tree.git weirdness

2010-11-16 Thread David Härdeman
interface), and the cleanups to saa7134 do not seem to be there... -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 0/2] Apple remote support

2010-11-18 Thread David Härdeman
direction. It would make the keytables less flexible while providing no real advantages. -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH 00/10] rc-core: various cleanups

2010-11-19 Thread David Härdeman
Here's a set of smaller patches which performs various cleanups, mostly to the saa7134 and bttv driver. They are based on the media_tree.git repo (2.6.38 branch) on top of Mauro's recent renaming patches. --- David Härdeman (10): saa7134: remove unused module parameter saa7134: use

[PATCH 01/10] saa7134: remove unused module parameter

2010-11-19 Thread David Härdeman
ir_rc5_remote_gap is a leftover from ir-common, remove it. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video

[PATCH 02/10] saa7134: use full keycode for BeholdTV

2010-11-19 Thread David Härdeman
Using the full keycode for BeholdTV hardware makes another module parameter unnecessary. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/keymaps/rc-behold.c| 70 ++- drivers/media/video/saa7134/saa7134-input.c | 19 +-- 2 files changed

[PATCH 03/10] saa7134: some minor cleanups

2010-11-19 Thread David Härdeman
Mostly using appropriate data types and constants (e.g. int - bool). Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c | 49 ++- drivers/media/video/saa7134/saa7134.h |4 +- 2 files changed, 21 insertions(+), 32

[PATCH 04/10] saa7134: merge saa7134_card_ir-timer and saa7134_card_ir-timer_end

2010-11-19 Thread David Härdeman
Both timers are used for a similar purpose. Merging them allows for some minor simplifications. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c | 10 -- drivers/media/video/saa7134/saa7134.h |1 - 2 files changed, 4 insertions

[PATCH 09/10] mceusb: int to bool conversion

2010-11-19 Thread David Härdeman
Convert boolean variables to use the corresponding data type. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/mceusb.c | 62 +++-- 1 files changed, 26 insertions(+), 36 deletions(-) diff --git a/drivers/media/rc/mceusb.c b/drivers

[PATCH 05/10] saa7134: protect the ir user count

2010-11-19 Thread David Härdeman
The use of the saa7134_card_ir-users seems racy, so protect the count with a spinlock. Also use proper data types as arguments to __saa7134_ir_start() and __saa7134_ir_stop() to remove some unnecessary casts. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134

[PATCH 10/10] rc-core: fix some leftovers from the renaming patches

2010-11-19 Thread David Härdeman
Fix some minor comments etc which are leftover from the old naming scheme. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/ir-raw.c |2 +- drivers/media/rc/rc-core-priv.h |6 +++--- drivers/media/rc/rc-main.c |2 +- include/media/rc-core.h

[PATCH 06/10] saa7134: make module parameters boolean

2010-11-19 Thread David Härdeman
int to bool conversion for module parameters which are truely boolean. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/saa7134/saa7134-input.c b

[PATCH 07/10] bttv: rename struct card_ir to bttv_ir

2010-11-19 Thread David Härdeman
bttv_ir is more consistent with all other structs used in the same driver. Also, clean up the struct to remove commented out members and the work_struct which is unused. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/bt8xx/bttv-input.c | 27

Re: [RFC PATCH 0/2] Apple remote support

2010-11-19 Thread David Härdeman
On Thu, Nov 18, 2010 at 06:59:43PM -0200, Mauro Carvalho Chehab wrote: Em 18-11-2010 18:49, Jarod Wilson escreveu: On Thu, Nov 18, 2010 at 09:43:19PM +0100, David Härdeman wrote: On Thu, Nov 18, 2010 at 11:33:04AM -0500, Jarod Wilson wrote: Mauro's suggestion, iirc, was that max scancode size

Re: [PATCH 05/10] saa7134: protect the ir user count

2010-11-22 Thread David Härdeman
On Mon, Nov 22, 2010 at 02:55:42PM -0200, Mauro Carvalho Chehab wrote: Em 19-11-2010 21:43, David Härdeman escreveu: The use of the saa7134_card_ir-users seems racy, so protect the count with a spinlock. Also use proper data types as arguments to __saa7134_ir_start() and __saa7134_ir_stop

Re: [PATCH 06/10] saa7134: make module parameters boolean

2010-11-22 Thread David Härdeman
On Mon, Nov 22, 2010 at 03:40:13PM -0200, Mauro Carvalho Chehab wrote: Em 19-11-2010 21:43, David Härdeman escreveu: int to bool conversion for module parameters which are truely boolean. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c |8

Re: [PATCH 09/10] mceusb: int to bool conversion

2010-11-22 Thread David Härdeman
On Mon, Nov 22, 2010 at 01:40:28PM -0500, Jarod Wilson wrote: On Nov 22, 2010, at 12:42 PM, Mauro Carvalho Chehab wrote: Em 19-11-2010 21:43, David Härdeman escreveu: Convert boolean variables to use the corresponding data type. Signed-off-by: David Härdeman da...@hardeman.nu Waiting

[PATCH] rc-core: add loopback driver

2010-11-25 Thread David Härdeman
receivers). TX data that is sent is fed back as input on the corresponding receiver, which allows for debugging of IR decoders, keymaps, etc. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/Kconfig | 13 ++ drivers/media/rc/Makefile |1 drivers/media/rc/rc

Re: [PATCH 04/14] [media] winbond-cir: Use current logging styles

2011-08-25 Thread David Härdeman
Acked-by: David Härdeman da...@hardeman.nu On Sun, 21 Aug 2011 15:56:47 -0700, Joe Perches j...@perches.com wrote: Add pr_fmt, convert printks to pr_level. Signed-off-by: Joe Perches j...@perches.com --- drivers/media/rc/winbond-cir.c |6 -- 1 files changed, 4 insertions(+), 2

[PATCH] rc-core: fix winbond-cir issues

2011-03-30 Thread David Härdeman
The conversion of winbond-cir to use rc-core seems to have missed a a few bits and pieces which were in my local tree. Kudos to Juan Jesús García de Soria Lucena skanda...@gmail.com for noticing. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/winbond-cir.c | 20

[PATCH] rc-core: set mode and default keymap for winbond-cir

2011-04-05 Thread David Härdeman
Not having the correct mode and a default keymap is not very user-friendly (and rc-core won't allow it). Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/winbond-cir.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/rc/winbond-cir.c b

[PATCH] rc-core: int to bool conversion for winbond-cir

2011-04-05 Thread David Härdeman
Using bool instead of an int helps readability a bit. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/winbond-cir.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c index

[PATCH 00/10] rc-core: my current patchqueue

2011-04-28 Thread David Härdeman
in the combined diffstat (the number of lines changed would probably be in the hundreds rather than thousands if keymaps were excluded). Comments? --- David Härdeman (10): rc-core: int to bool conversion for winbond-cir rc-core: add TX support to the winbond-cir driver rc-core: use

[PATCH 01/10] rc-core: int to bool conversion for winbond-cir

2011-04-28 Thread David Härdeman
Using bool instead of an int helps readability a bit. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/winbond-cir.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c index

[PATCH 03/10] rc-core: use ir_raw_event_store_with_filter in winbond-cir

2011-04-28 Thread David Härdeman
Using ir_raw_event_store_with_filter() saves about 20 lines of code. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/winbond-cir.c | 63 +--- 1 files changed, 21 insertions(+), 42 deletions(-) diff --git a/drivers/media/rc/winbond-cir.c

[PATCH 02/10] rc-core: add TX support to the winbond-cir driver

2011-04-28 Thread David Härdeman
This patch adds preliminary IR TX capabilities to the winbond-cir driver. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/winbond-cir.c | 431 +--- 1 files changed, 356 insertions(+), 75 deletions(-) diff --git a/drivers/media/rc/winbond

[PATCH 04/10] rc-core: add trailing silence in rc-loopback tx

2011-04-28 Thread David Härdeman
of TX data. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/rc-loopback.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/media/rc/rc-loopback.c b/drivers/media/rc/rc-loopback.c index 49cee61..cc846b2 100644 --- a/drivers/media/rc/rc

[PATCH 07/10] rc-core: use the full 32 bits for NEC scancodes

2011-04-28 Thread David Härdeman
Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core and the nec decoder without any loss of functionality. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/dvb/dvb-usb/af9015.c | 22 ++ drivers/media/rc/ir-nec-decoder.c | 28

[PATCH 08/10] rc-core: merge rc5 and streamzap decoders

2011-04-28 Thread David Härdeman
that I've seen with e.g. Sony protocols). Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/Kconfig| 12 -- drivers/media/rc/Makefile |1 drivers/media/rc/ir-rc5-decoder.c | 51 ++ drivers/media/rc/ir-rc5-sz-decoder.c| 153

[PATCH 09/10] rc-core: lirc use unsigned int

2011-04-28 Thread David Härdeman
Durations can never be negative, so it makes sense to consistently use unsigned int for LIRC transmission. Contrary to the initial impression, this shouldn't actually change the userspace API. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/ene_ir.c|4

[PATCH 10/10] rc-core: move timeout and checks to lirc

2011-04-28 Thread David Härdeman
support), it makes sense to move this timeout calculation to the lirc layer instead. At the same time, centralize some of the sanity checks. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/ir-lirc-codec.c | 33 + drivers/media/rc/mceusb.c

Re: [PATCH 00/10] rc-core: my current patchqueue

2011-04-29 Thread David Härdeman
On Thu, 28 Apr 2011 21:13:22 +0100, Malcolm Priestley tvbox...@gmail.com wrote: On Thu, 2011-04-28 at 17:13 +0200, David Härdeman wrote: The following series is what's in my current patch queue for rc-core. It only been lightly tested so far and it's based on the for_v2.6.39 branch, but I

Re: [PATCH 09/10] rc-core: lirc use unsigned int

2011-05-06 Thread David Härdeman
On Wed, 04 May 2011 12:23:03 -0300, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 28-04-2011 12:13, David Härdeman escreveu: Durations can never be negative, so it makes sense to consistently use unsigned int for LIRC transmission. Contrary to the initial impression, this shouldn't

Re: [PATCH 07/10] rc-core: use the full 32 bits for NEC scancodes

2011-05-06 Thread David Härdeman
On Wed, 04 May 2011 12:16:17 -0300, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 28-04-2011 12:13, David Härdeman escreveu: Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core and the nec decoder without any loss of functionality. This seems to be a good strategy

Re: [PATCH 00/10] rc-core: my current patchqueue

2011-05-06 Thread David Härdeman
On Wed, 04 May 2011 12:13:49 -0300, Mauro Carvalho Chehab mauroche...@gmail.com wrote: Em 29-04-2011 05:08, David Härdeman escreveu: diff --git a/drivers/media/rc/keymaps/rc-videomate-s350.c b/drivers/media/rc/keymaps/rc-videomate-s350.c index 26ca260..2f0ec1f 100644 --- a/drivers/media/rc

  1   2   3   4   5   6   >