[PATCH v4] [media] vimc: Virtual Media Controller core, capture and sensor

From: Helen Fornazier First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Fornazier

Re: [PATCH v2] [media] tpg: Export the tpg code from vivid as a module

Hi On 01/04/2016 15:22, Mauro Carvalho Chehab wrote: Hi Helen, This is just a quick look on it. See below. Em Fri, 1 Apr 2016 14:18:13 -0300 Helen Mae Koike Fornazier escreveu: The test pattern generator will be used by other drivers as the virtual media

[GIT PULL] two patches: pipeline validation error code

Hi Mauro, Please pull the following patches correcting the returned error codes and respective docs in the pipeline validation. Regards, Helen The following changes since commit 45c175c4ae9695d6d2f30a45ab7f3866cfac184b: [media] tw686x: avoid going past array (2016-04-26 06:38:53 -0300)

Re: [PATCH v3] [media] vimc: Virtual Media Controller core, capture and sensor

Hi Jeremy, On 24-05-2016 21:00, Jeremy Gebben wrote: Helen, I am more of a v4l2 newb than a reviewer, but I got your driver working on a qemu arm64 system. Using it to play with mediactl -p was a good way to get started. I did have 2 minor include path problems. Maybe they come in implicitly

[PATCH] v4l2-compliance: Improve test readability when fail

In case of failure, print "q.create_bufs(node, 1, ) != EINVAL" instead of "ret != EINVAL" Signed-off-by: Helen Koike <helen.ko...@collabora.co.uk> --- Hello, I was wondering, why the q.create_bufs is expected to should return EINVAL in this test? The heigh

[PATCH] [media] stk1160: Check *nplanes in queue_setup

If *nplanes is not zero, it should use the requested size if valid Signed-off-by: Helen Koike <helen.ko...@collabora.co.uk> --- drivers/media/usb/stk1160/stk1160-v4l.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/stk1160/stk1160-v4l.c b/drivers/media/usb/s

Re: [PATCH v4] [media] vimc: Virtual Media Controller core, capture and sensor

Hi Hans On 01-07-2016 09:39, Hans Verkuil wrote: Hi Helen, Better late than never, but I finally have time for a review, mostly with a eye for V4L2 issues. Thank you for your review, I'll incorporate your suggestions in v5. I am also preparing a patch series that integrates the tpg and have

[PATCH v5] [media] vimc: Virtual Media Controller core, capture and sensor

From: Helen Fornazier <helen.fornaz...@gmail.com> First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike <helen.ko...@coll

Re: [PATCH v5] [media] vimc: Virtual Media Controller core, capture and sensor

:09 AM, Helen Koike wrote: From: Helen Fornazier <helen.fornaz...@gmail.com> First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen

[PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

From: Helen Fornazier <helen.fornaz...@gmail.com> First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike <helen.ko...@coll

[PATCH] [media] MAINTAINERS: add vimc entry

Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0a16a82..43e0eb4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12540,6 +12540,14 @@ W: https://linuxtv.org S: Maintai

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

Hi Laurent, On 2017-01-10 04:54 PM, Laurent Pinchart wrote: Hi Helen, (CC'ing Sakari as there's a question specifically for him) Thank you for the patch, and so sorry for the late review. On Sunday 04 Sep 2016 17:02:18 Helen Koike wrote: From: Helen Fornazier <helen.fornaz...@gmail.

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

Hi Sakari, On 2017-03-26 10:31 AM, Sakari Ailus wrote: Hi Helen, ... +static int vimc_cap_enum_input(struct file *file, void *priv, + struct v4l2_input *i) +{ + /* We only have one input */ + if (i->index > 0) + return -EINVAL; + +

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

Hi Sakari, Thanks for your review, I have some questions below: On 2017-01-25 11:03 AM, Sakari Ailus wrote: Hi Helen, My apologies for the long review time! Please see my comments below. On Sun, Sep 04, 2016 at 05:02:18PM -0300, Helen Koike wrote: From: Helen Fornazier <helen.for

[PATCH RFC 1/2] [media] v4l2: add V4L2_INPUT_TYPE_DEFAULT

Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be used when no inputs are available in the device Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- drivers/media/v4l2-core/v4l2-ioctl.c | 27 +++ include/media/v4l2-ioctl.h

[PATCH 2/2] [media] docs-rst: add V4L2_INPUT_TYPE_DEFAULT

add documentation for V4L2_INPUT_TYPE_DEFAULT Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Documentation/media/uapi/v4l/vidioc-enuminput.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/media/uapi/v4l/vidioc-enuminput.rst b/Documentation/media/ua

[PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Patch based in media/master tree, and ava

[PATCH v8] [media] vimc: Virtual Media Controller core, capture and sensor

First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Patch based in media/master tree, and ava

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

On 2017-03-25 02:11 PM, Helen Koike wrote: First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike <helen.ko...@collabora.

[media] vimc: API proposal, configuring the topology from user space

Hi, Continuing the discussion about the API of the vimc driver, I made some changes based on the previous comments, please see below and let me know your opinion about it. Helen /*** Configfs considerations: / Informal definitions:

Re: [PATCH RFC 1/2] [media] v4l2: add V4L2_INPUT_TYPE_DEFAULT

Hi, On 2017-03-31 06:57 AM, Mauro Carvalho Chehab wrote: Em Fri, 31 Mar 2017 10:29:04 +0200 Hans Verkuil <hverk...@xs4all.nl> escreveu: On 30/03/17 18:02, Helen Koike wrote: Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be used when no inputs are ava

Re: [PATCH RFC 1/2] [media] v4l2: add V4L2_INPUT_TYPE_DEFAULT

Hi Laurent, Thanks for reviewing On 2017-03-30 04:56 PM, Laurent Pinchart wrote: Hi Helen, Thank you for the patch. On Thursday 30 Mar 2017 13:02:17 Helen Koike wrote: Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be used when no inputs are available in the device

Re: please help with uninstall

Hi, On 2017-04-12 08:00 AM, Milan Čížek wrote: How to remove your product from my kernel? I tried make rmmod rminstall but this message stills in my syslog. Sorry for question, I'm linux newbie. [ 15.753993] WARNING: You are using an experimental version of the media stack.

Re: [PATCH v9] [media] vimc: Virtual Media Controller core, capture and sensor

Hi, There are two points below that I'll change in v10. I'll wait for your comments in the rest of the code so I can send all the requested changes in v10 On 2017-04-03 07:16 PM, Helen Koike wrote: First version of the Virtual Media Controller. Add a simple version of the core of the driver

[PATCH] [media] media-entity: only call dev_dbg_obj if mdev is not NULL

Fix kernel Oops NULL pointer deference Call dev_dbg_obj only after checking if gobj->mdev is not NULL Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- drivers/media/media-entity.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/media-e

[PATCH] [media] media-entity: only call dev_dbg_obj if mdev is not NULL

Fix kernel Oops NULL pointer deference Call dev_dbg_obj only after checking if gobj->mdev is not NULL Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- drivers/media/media-entity.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/media-e

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

Hi Hans, On 2017-03-10 10:08 AM, Hans Verkuil wrote: Hi Helen, On 11/01/17 02:30, Helen Koike wrote: > > Thank you for the review, I'll update the patch accordingly and re-submit it. > > Helen Do you know when you have a v7 ready? Thanks for your interest. I don't have the

[PATCH v9] [media] vimc: Virtual Media Controller core, capture and sensor

First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Patch based in media/master tree, and ava

[PATCH v2 6/7] [media] vimc: deb: Add debayer filter

Implement the debayer filter and integrate it with the core Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v2: [media] vimc: deb: Add debayer filter - Using MEDIA_ENT_F_ATV_DECODER in function - remove v4l2_dev and dev from vimc_deb_device

[PATCH v2 5/7] [media] vimc: cap: Support several image formats

Allow user space to change the image format as the frame size, the pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v2: [media] vimc: cap: Support several image f

[PATCH v2 3/7] [media] vimc: Add vimc_pipeline_s_stream in the core

Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-core.c as this core will be reused by other subdevices to activate the stream in their directly connected nodes Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v2: [media] vimc: Add vimc_pipeline_s_

[PATCH v2 1/7] [media] vimc: sen: Integrate the tpg on the sensor

Initialize the test pattern generator on the sensor Generate a colored bar image instead of a grey one Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v2: [media] vimc: sen: Integrate the tpg on the sensor - Fix include location - Select V4L2_TPG in K

[PATCH v2 4/7] [media] vimc: sen: Support several image formats

Allow user space to change the image format as the frame size, the media bus pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v2: [media] vimc: sen: Support several image f

[PATCH v2 2/7] [media] vimc: Add vimc_ent_sd_* helper functions

As all the subdevices in the topology will be initialized in the same way, to avoid code repetition the vimc_ent_sd_{register, unregister} helper functions were created Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v2: [media] vimc: Add vimc_ent_sd_* helper fun

[PATCH v2 7/7] [media] vimc: sca: Add scaler

Implement scaler and integrated with the core Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v2: [media] vimc: sca: Add scaler - Add function MEDIA_ENT_F_IO_V4L - remove v4l2_dev and dev - s/sink_mbus_fmt/sink_fmt - remove BUG_ON,

[PATCH v2 0/7] [media]: vimc: Virtual Media Control VPU's

pad types on create - return EBUSY when trying to set the format while stream is on - remove vsd struct - add IS_SRC and IS_SINK macros - add sca_mult as a parameter of the module - check set_fmt default parameters for quantization, colorspace ... - add more dev_

Re: [PATCH RFC 1/2] [media] v4l2: add V4L2_INPUT_TYPE_DEFAULT

On 2017-03-30 11:39 PM, Helen Koike wrote: Hi Laurent, Thanks for reviewing On 2017-03-30 04:56 PM, Laurent Pinchart wrote: Hi Helen, Thank you for the patch. On Thursday 30 Mar 2017 13:02:17 Helen Koike wrote: Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be used

[PATCH v10] [media] vimc: Virtual Media Controller core, capture and sensor

First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike <helen.ko...@collabora.com> Reviewed-by: Hans Verkuil <hans.verk...@

Re: [PATCH] [media] media-entity: only call dev_dbg_obj if mdev is not NULL

Hi Sakari, On 2017-04-07 04:40 AM, Sakari Ailus wrote: Hi Helen, On Thu, Apr 06, 2017 at 04:32:00PM -0300, Helen Koike wrote: Fix kernel Oops NULL pointer deference Call dev_dbg_obj only after checking if gobj->mdev is not NULL Signed-off-by: Helen Koike <helen.ko...@collabo

Re: [PATCH] [media] vimc: set id_table for platform drivers

; Signed-off-by: Javier Martinez Canillas <javi...@redhat.com> Seems good to me. Reviewed-by: Helen Koike <helen.ko...@collabora.com> --- drivers/media/platform/vimc/vimc-capture.c | 15 --- drivers/media/platform/vimc/vimc-debayer.c | 15 --- drivers/

Re: [RFC PATCH v3 05/11] [media] vimc: common: Add vimc_link_validate

Hi Hans, Thanks for your review, just a question below On 2017-06-12 06:50 AM, Hans Verkuil wrote: On 06/03/2017 04:58 AM, Helen Koike wrote: All links will be checked in the same way. Adding a helper function for that Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- C

Re: [RFC PATCH v3 08/11] [media] vimc: Optimize frame generation through the pipe

Hi Hans, Thank you for your review On 2017-06-12 07:03 AM, Hans Verkuil wrote: On 06/03/2017 04:58 AM, Helen Koike wrote: Add a parameter called vsen_tpg, if true then vimc will work as before: frames will be generated in the sensor nodes then propagated through the pipe and processed by each

Re: [RFC PATCH v3 09/11] [media] vimc: Subdevices as modules

Hi Hans, Thank you for your review. Please check my comments below On 2017-06-12 07:37 AM, Hans Verkuil wrote: On 06/03/2017 04:58 AM, Helen Koike wrote: Change the core structure for adding subdevices in the topology. Instead of calling the specific create function for each subdevice, inject

[PATCH v5 11/12] [media] vimc: sca: Add scaler

Implement scaler and integrated with the core Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: [media] vimc: sca: Add scaler - declare vimc_sca_video_ops as static, remove sparse warning Changes in v4: [media] vimc: sca: Add scaler

[PATCH v5 09/12] [media] vimc: Subdevices as modules

in the system. It also facilitates other implementations of different nodes without touching the core code and remove the need of a header file for each type of node. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: [media] vimc: Subdevices as modules

[PATCH v5 05/12] [media] vimc: common: Add vimc_link_validate

All links will be checked in the same way. Adding a helper function for that Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: None Changes in v4: [media] vimc: common: Add vimc_link_validate - remove vimc_fmt_pix_to_mbus(), re

[PATCH v5 02/12] [media] vimc: Move common code from the core

Remove helper functions from vimc-core and add it in vimc-common to clean up the core. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: None Changes in v4: None Changes in v3: [media] vimc: Move common code from the core - This is a new patch in the

[PATCH v5 08/12] [media] vimc: cap: Support several image formats

Allow user space to change the image format as the frame size, the pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: None Changes in v4: [media] vimc: cap: Support several

[PATCH v5 00/12] [media]: vimc: Virtual Media Control VPU's

g to set the format while stream is on - remove vsd struct - add IS_SRC and IS_SINK macros - add sca_mult as a parameter of the module - check set_fmt default parameters for quantization, colorspace ... - add more dev_dbg Helen Koike (12): [media] vimc: sen:

[PATCH v5 04/12] [media] vimc: common: Add vimc_pipeline_s_stream helper

Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c as this core will be reused by other subdevices to activate the stream in their directly connected nodes Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: None Changes in v4: None Changes

[PATCH v5 07/12] [media] vimc: sen: Support several image formats

Allow user space to change the image format as the frame size, the media bus pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: None Changes in v4: [media] vimc: sen: Support s

[PATCH v5 01/12] [media] vimc: sen: Integrate the tpg on the sensor

Initialize the test pattern generator on the sensor Generate a colored bar image instead of a grey one Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: None Changes in v4: None Changes in v3: [media] vimc: sen: Integrate the tpg on the sensor - D

[PATCH v5 06/12] [media] vimc: common: Add vimc_colorimetry_clamp

Colorimetry value will always be checked in the same way. Adding a helper macro for that Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: None Changes in v4: [media] vimc: common: Add vimc_colorimetry_clamp - this is a new patch in the series Changes

[PATCH v5 10/12] [media] vimc: deb: Add debayer filter

Implement the debayer filter and integrate it with the core Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: [media] vimc: deb: Add debayer filter - delare vimc_deb_video_ops as static, remove sparse warning Changes in v4: [media] vimc: deb: Add debayer

[PATCH v5 03/12] [media] vimc: common: Add vimc_ent_sd_* helper

As all the subdevices in the topology will be initialized in the same way, to avoid code repetition the vimc_ent_sd_{register, unregister} helper functions were created Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: None Changes in v4: None Changes in v3: [media

[PATCH v5 12/12] [media] vimc: sen: Declare vimc_sen_video_ops as static

Declare vimc_sen_video_ops as static, remove warning from sparse tool Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v5: [media] vimc: sen: Declare vimc_sen_video_ops as static - This is a new patch in the series Changes in v4: None Changes in v3: None C

Re: [PATCH v2] [media] v4l2: add V4L2_CAP_IO_MC

Hi Hans, Thanks for reviewing this On 2017-06-19 08:15 AM, Hans Verkuil wrote: On 06/14/2017 06:50 AM, Helen Koike wrote: Add V4L2_CAP_IO_MC to be used in struct v4l2_capability to indicate that input and output are controlled by the Media Controller instead of V4L2 API. When this flag is set

Re: [PATCH v2 5/7] [media] vimc: cap: Support several image formats

Hi Hans, Thank you for your review. I just have a question for this one. On 2017-05-08 08:53 AM, Hans Verkuil wrote: On 04/08/2017 12:37 AM, Helen Koike wrote: Allow user space to change the image format as the frame size, the pixel format, colorspace, quantization, field YCbCr encoding

[RFC PATCH v3 04/11] [media] vimc: common: Add vimc_pipeline_s_stream helper

Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c as this core will be reused by other subdevices to activate the stream in their directly connected nodes Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: Add vimc_pipeline_s_

[RFC PATCH v3 03/11] [media] vimc: common: Add vimc_ent_sd_* helper

As all the subdevices in the topology will be initialized in the same way, to avoid code repetition the vimc_ent_sd_{register, unregister} helper functions were created Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: Add vimc_ent_sd_* helper fun

Re: [media] vimc: API proposal, configuring the topology from user space

ping On 2017-04-10 07:53 PM, Helen Koike wrote: Hi, Continuing the discussion about the API of the vimc driver, I made some changes based on the previous comments, please see below and let me know your opinion about it. Helen /*** Configfs considerations

[RFC PATCH v3 06/11] [media] vimc: sen: Support several image formats

Allow user space to change the image format as the frame size, the media bus pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: sen: Support several image f

[RFC PATCH v3 07/11] [media] vimc: cap: Support several image formats

Allow user space to change the image format as the frame size, the pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: cap: Support several image formats

[RFC PATCH v3 02/11] [media] vimc: Move common code from the core

Remove helper functions from vimc-core and add it in vimc-common to clean up the core. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: Move common code from the core - This is a new patch in the series Changes in v2: None --- drivers

[RFC PATCH v3 01/11] [media] vimc: sen: Integrate the tpg on the sensor

Initialize the test pattern generator on the sensor Generate a colored bar image instead of a grey one Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: sen: Integrate the tpg on the sensor - Declare frame_size as a local variable - S

[RFC PATCH v3 10/11] [media] vimc: deb: Add debayer filter

Implement the debayer filter and integrate it with the core Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: deb: Add debayer filter - Declare frame_size as a local variable - s_stream(sd, 1): return 0 if stream is already e

[RFC PATCH v3 09/11] [media] vimc: Subdevices as modules

in the system. It also facilitates other implementations of different nodes without touching the core code and remove the need of a header file for each type of node. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: Subdevices as modules - This is

[RFC PATCH v3 08/11] [media] vimc: Optimize frame generation through the pipe

the capture node, thus saving intermediate memory buffers and process time, allowing a higher frame rate. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: Optimize frame generation through the pipe - This is a new patch in the series Changes

[RFC PATCH v3 11/11] [media] vimc: sca: Add scaler

Implement scaler and integrated with the core Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: sca: Add scaler - Declare frame_size as a local variable - s_stream(sd, 1): return 0 if stream is already enabled - s_stream

[RFC PATCH v3 05/11] [media] vimc: common: Add vimc_link_validate

All links will be checked in the same way. Adding a helper function for that Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v3: [media] vimc: common: Add vimc_link_validate - this is a new patch in the series Changes in v2: None --- drivers/media/platfor

[RFC PATCH v3 00/11] [media]: vimc: Virtual Media Control VPU's

ers for quantization, colorspace ... - add more dev_dbg Helen Koike (11): [media] vimc: sen: Integrate the tpg on the sensor [media] vimc: Move common code from the core [media] vimc: common: Add vimc_ent_sd_* helper [media] vimc: common: Add vimc_pipeline_s_stream helper [media] vimc

Re: [RFC PATCH] [media] v4l2-subdev: check colorimetry in link validate

Hi On 2017-06-08 08:41 AM, Mauro Carvalho Chehab wrote: Em Tue, 6 Jun 2017 19:15:34 -0300 Helen Koike <helen.ko...@collabora.com> escreveu: Hi Sakari, Thanks for replying On 2017-05-31 03:31 AM, Sakari Ailus wrote: Hi Helen, On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike

[PATCH v2] [media] v4l2-subdev: check colorimetry in link validate

colorspace, ycbcr_enc, quantization and xfer_func must match across the link. Check if they match in v4l2_subdev_link_validate_default unless they are set as _DEFAULT. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Hi, As discussed previously, I added a warn message i

Re: [RFC PATCH v3 08/11] [media] vimc: Optimize frame generation through the pipe

On 2017-06-02 11:58 PM, Helen Koike wrote: Add a parameter called vsen_tpg, if true then vimc will work as before: frames will be generated in the sensor nodes then propagated through the pipe and processed by each node until a capture node is reached. If vsen_tpg is false, then the frame

Re: [RFC PATCH v3 00/11] [media]: vimc: Virtual Media Control VPU's

I forgot to mention that this patch series is also available here https://github.com/helen-fornazier/opw-staging/tree/z/sent/vimc/vpu/v3 On 2017-06-02 11:58 PM, Helen Koike wrote: This patch series improves the current video processing units in vimc (by adding more controls to the sensor

Re: [RFC PATCH] [media] v4l2-subdev: check colorimetry in link validate

Hi Sakari, Thanks for replying On 2017-05-31 03:31 AM, Sakari Ailus wrote: Hi Helen, On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike wrote: colorspace, ycbcr_enc, quantization and xfer_func must match across the link. Check if they match in v4l2_subdev_link_validate_default unless

Re: [RFC PATCH v3 09/11] [media] vimc: Subdevices as modules

Hi Hans, On 2017-06-13 03:49 AM, Hans Verkuil wrote: On 06/12/2017 10:35 PM, Helen Koike wrote: Hi Hans, Thank you for your review. Please check my comments below On 2017-06-12 07:37 AM, Hans Verkuil wrote: On 06/03/2017 04:58 AM, Helen Koike wrote: +static struct component_match

[PATCH v4 10/11] [media] vimc: deb: Add debayer filter

Implement the debayer filter and integrate it with the core Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: [media] vimc: deb: Add debayer filter - Rebase without [media] vimc: Optimize frame generation through pipe - use vimc_colorimetry

[PATCH v4 11/11] [media] vimc: sca: Add scaler

Implement scaler and integrated with the core Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: [media] vimc: sca: Add scaler - use vimc_colorimetry_clamp - replace V4L2_COLORSPACE_SRGB by V4L2_COLORSPACE_DEFAULT in the default format

[PATCH v4 05/11] [media] vimc: common: Add vimc_link_validate

All links will be checked in the same way. Adding a helper function for that Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: [media] vimc: common: Add vimc_link_validate - remove vimc_fmt_pix_to_mbus(), replaced by v4l2_fill_mbus_

[PATCH v4 08/11] [media] vimc: cap: Support several image formats

Allow user space to change the image format as the frame size, the pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: [media] vimc: cap: Support several image formats

[PATCH v4 06/11] [media] vimc: common: Add vimc_colorimetry_clamp

Colorimetry value will always be checked in the same way. Adding a helper macro for that Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: [media] vimc: common: Add vimc_colorimetry_clamp - this is a new patch in the series Changes in v3: None Changes

[PATCH v4 03/11] [media] vimc: common: Add vimc_ent_sd_* helper

As all the subdevices in the topology will be initialized in the same way, to avoid code repetition the vimc_ent_sd_{register, unregister} helper functions were created Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: None Changes in v3: [media] vimc: commo

[PATCH v4 04/11] [media] vimc: common: Add vimc_pipeline_s_stream helper

Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c as this core will be reused by other subdevices to activate the stream in their directly connected nodes Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: None Changes in v3: [media] vim

[PATCH v4 00/11] [media]: vimc: Virtual Media Control VPU's

- add IS_SRC and IS_SINK macros - add sca_mult as a parameter of the module - check set_fmt default parameters for quantization, colorspace ... - add more dev_dbg Helen Koike (11): [media] vimc: sen: Integrate the tpg on the sensor [media] vimc: Move common c

[PATCH v4 09/11] [media] vimc: Subdevices as modules

in the system. It also facilitates other implementations of different nodes without touching the core code and remove the need of a header file for each type of node. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: [media] vimc: Subdevices as modules - Rebase w

[PATCH v4 07/11] [media] vimc: sen: Support several image formats

Allow user space to change the image format as the frame size, the media bus pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: [media] vimc: sen: Support several image f

[PATCH v4 01/11] [media] vimc: sen: Integrate the tpg on the sensor

Initialize the test pattern generator on the sensor Generate a colored bar image instead of a grey one Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: None Changes in v3: [media] vimc: sen: Integrate the tpg on the sensor - Declare frame_size as a

[PATCH v4 02/11] [media] vimc: Move common code from the core

Remove helper functions from vimc-core and add it in vimc-common to clean up the core. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v4: None Changes in v3: [media] vimc: Move common code from the core - This is a new patch in the series Changes in v2

[PATCH v2] [media] v4l2: add V4L2_CAP_IO_MC

-by: Helen Koike <helen.ko...@collabora.com> --- Changes in v2:: - replace the type by capability - erase V4L2_INPUT_TYPE_DEFAULT - also consider output - plug helpers in the ops automatically so drivers doesn't need to set it by hand - updat

[RFC PATCH] [media] v4l2-subdev: check colorimetry in link validate

colorspace, ycbcr_enc, quantization and xfer_func must match across the link. Check if they match in v4l2_subdev_link_validate_default unless they are set as _DEFAULT. Signed-off-by: Helen Koike <helen.ko...@collabora.com> --- Hi, I think we should validate colorimetry as having dif

Re: [PATCH RFC 1/2] [media] v4l2: add V4L2_INPUT_TYPE_DEFAULT

Hi All, Just reviving this discussion On 2017-04-07 06:53 AM, Laurent Pinchart wrote: Hi Hans, On Friday 07 Apr 2017 11:46:48 Hans Verkuil wrote: On 04/04/2017 03:22 PM, Sakari Ailus wrote: On Mon, Apr 03, 2017 at 12:11:54PM -0300, Helen Koike wrote: On 2017-03-31 06:57 AM, Mauro Carvalho

Re: [media] vimc: API proposal, configuring the topology from user space

Hi Hans, Thanks for your review. On 2017-07-28 10:39 AM, Hans Verkuil wrote: > Hi Helen, > > Finally after way too long I found some time to review this. See my comments > below. > > On 04/11/2017 12:53 AM, Helen Koike wrote: >> >> Hi, >> >> Continuin

Re: [PATCH] vimc: add test_pattern and h/vflip controls to the sensor

Hi Hans, Thanks for your patch and sorry for my late reply. Please see my comments and questions below On 2017-07-28 07:23 AM, Hans Verkuil wrote: > Add support for the test_pattern control and the h/vflip controls. > > This makes it possible to switch to more interesting test patterns and to >

Re: [PATCH] [media] vimc: Fix return value check in vimc_add_subdevs()

--i >= 0) > platform_device_unregister(vimc->subdevs[i]); > > - return ERR_PTR(-ENOMEM); > + return match; > } > > component_match_add(>pdev.dev, , vimc_comp_compare, > > > Nice catch, thanks, looks good to me Acked-by: Helen Koike <helen.ko...@collabora.com>

Re: [PATCH] vimc: add test_pattern and h/vflip controls to the sensor

Hi Hans, On 2017-11-06 08:19 AM, Hans Verkuil wrote: > Hi Helen, > > On 09/27/2017 08:30 PM, Helen Koike wrote: >> Hi Hans, >> >> Thanks for your patch and sorry for my late reply. > > Sorry for my late reply to your reply :-) > >> Please see my commen

Question regarding optimizing pipeline in Vimc

Hello, One of the discussions we had when developing Vimc, was regarding optimizing image generation. The ideia was to generate the images directly in the capture instead of propagating through the pipeline (to make things faster). But my question is: if this optimization is on, and if there is a

Re: Question regarding optimizing pipeline in Vimc

On 8/22/18 3:49 AM, Hans Verkuil wrote: > On 08/22/2018 05:35 AM, Helen Koike wrote: >> Hello, >> >> One of the discussions we had when developing Vimc, was regarding >> optimizing image generation. >> The ideia was to generate the images directly in the

Re: [PATCH] v4l2-subdev: without controls return -ENOTTY

ons are also called directly from drivers, so I don't want to change the error code there. Right, I see, thanks for the patch Found with vimc and v4l2-compliance. Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Helen Koike <helen.ko...@collabora.com> --- diff --git

Re: [PATCH] vimc: use correct subdev functions

Hi Hans, On 02/07/2018 03:06 PM, Hans Verkuil wrote: Instead of calling everything a MEDIA_ENT_F_ATV_DECODER, pick the correct functions for these blocks. Nice, thanks for the patch Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Helen Koike <helen.ko...@coll

  1   2   >