Re: make error

. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best regards, Todor Tomov -- To unsubscribe from this list: send the line unsubscribe linux-media

[PATCH v4 1/2] media: i2c/ov5645: add the device tree binding document

Add the document for ov5645 device tree binding. Signed-off-by: Todor Tomov <todor.to...@linaro.org> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/media/i2c/ov5645.txt | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 D

[PATCH v4 2/2] media: Add a driver for the ov5645 camera sensor.

The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/i2c/Kconfig

[PATCH v4 0/2] OV5645 camera sensor driver

external clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor Tomov (2): media: i2c/ov5645: add the device tree binding document media: Add a driver for the ov5645 camera sensor. .../devicetree/bindings/media/i2c/ov5645.txt | 50 + drivers/media/i2c

Re: [PATCH v2 2/2] media: Add a driver for the ov5645 camera sensor.

Hi Stan, Thanks for the review. On 05/20/2016 06:20 PM, Stanimir Varbanov wrote: > Hi Todor, > > Thanks for the patch, few comments below. > > On 05/18/2016 02:50 PM, Todor Tomov wrote: >> The ov5645 sensor from Omnivision supports up to 2592x1944 >> and CSI2 inter

[PATCH v3 2/2] media: Add a driver for the ov5645 camera sensor.

The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/i2c/Kconfig

[PATCH v3 1/2] [media] media: i2c/ov5645: add the device tree binding document

Add the document for ov5645 device tree binding. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../devicetree/bindings/media/i2c/ov5645.txt | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov56

[PATCH v3 0/2] OV5645 camera sensor driver

to dt binding doc patch and driver patch; - changes in power on/off logic - s_power is now not called on open/close; - using assigned-clock-rates in dt for setting camera external clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor Tomov (2): [media] media

Re: [PATCH v2 2/2] media: Add a driver for the ov5645 camera sensor.

Hi Hans, Thanks for the review. On 05/23/2016 01:36 PM, Hans Verkuil wrote: > Hi Todor, > > Thanks for the patch series! I got a few comments: > > On 05/18/2016 01:50 PM, Todor Tomov wrote: >> The ov5645 sensor from Omnivision supports up to 2592x1944 >> and CSI2

Re: [PATCH v2 1/2] [media] media: i2c/ov5645: add the device tree binding document

On 05/20/2016 03:16 AM, Rob Herring wrote: > On Thu, May 19, 2016 at 3:14 AM, Todor Tomov <todor.to...@linaro.org> wrote: >> Hi Rob, >> >> Thank you for your time to review. My responses are below: >> >> On 05/19/2016 02:16 AM, Rob Herring wrote: >>>

Re: [PATCH v2 1/2] [media] media: i2c/ov5645: add the device tree binding document

Hi Rob, Thank you for your time to review. My responses are below: On 05/19/2016 02:16 AM, Rob Herring wrote: > On Wed, May 18, 2016 at 02:50:07PM +0300, Todor Tomov wrote: >> Add the document for ov5645 device tree binding. >> >> Signed-off-by: Todor Tomov &l

[PATCH] media: Add a driver for the ov5645 camera sensor.

The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../devicetree/bindings/media/i2c/

Re: [PATCH] media: Add a driver for the ov5645 camera sensor.

Hi Stan, Thanks for the review. My comments are inline: On 05/15/2016 12:53 PM, Stanimir Varbanov wrote: > Hi Todor, > > On 05/12/2016 05:59 PM, Todor Tomov wrote: >> The ov5645 sensor from Omnivision supports up to 2592x1944 >> and CSI2 interface. >>

Re: [PATCH] media: Add a driver for the ov5645 camera sensor.

Hello Hans, Thank you for your review. Please see my comments below. On 05/13/2016 10:02 AM, Hans Verkuil wrote: > On 05/12/2016 04:59 PM, Todor Tomov wrote: >> The ov5645 sensor from Omnivision supports up to 2592x1944 >> and CSI2 interface. >> >> The driver adds supp

Re: [PATCH] media: Add a driver for the ov5645 camera sensor.

Hi Hans, Laurent, On 05/16/2016 03:13 PM, Laurent Pinchart wrote: > Hi Hans, > > On Monday 16 May 2016 10:38:09 Hans Verkuil wrote: >> On 05/16/2016 10:23 AM, Todor Tomov wrote: >>> On 05/13/2016 10:02 AM, Hans Verkuil wrote: >>>> On 05/12/2016 04:59 PM,

[PATCH v2 1/2] [media] media: i2c/ov5645: add the device tree binding document

Add the document for ov5645 device tree binding. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../devicetree/bindings/media/i2c/ov5645.txt | 56 ++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov56

[PATCH v2 2/2] media: Add a driver for the ov5645 camera sensor.

The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/i2c/Kconfig

[PATCH v2 0/2] OV5645 camera sensor driver

clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor Tomov (2): [media] media: i2c/ov5645: add the device tree binding document media: Add a driver for the ov5645 camera sensor. .../devicetree/bindings/media/i2c/ov5645.txt | 56 + drivers/media

[PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/i2c/Kconfig

[PATCH v5 1/2] media: i2c/ov5645: add the device tree binding document

Add the document for ov5645 device tree binding. Signed-off-by: Todor Tomov <todor.to...@linaro.org> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/media/i2c/ov5645.txt | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 D

[PATCH v5 0/2] OV5645 camera sensor driver

in power on/off logic - s_power is now not called on open/close; - using assigned-clock-rates in dt for setting camera external clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor Tomov (2): media: i2c/ov5645: add the device tree binding document media

Re: [PATCH v7 1/2] media: i2c/ov5645: add the device tree binding document

the same). Best regards, Todor On 11/14/2016 12:24 PM, Todor Tomov wrote: > Add the document for ov5645 device tree binding. > > Signed-off-by: Todor Tomov <todor.to...@linaro.org> > --- > .../devicetree/bindings/media/i2c/ov5645.txt | 54 >

Re: [PATCH v7 2/2] media: Add a driver for the ov5645 camera sensor.

Hi, Just to point it here - there is one more one-line correction needed below: On 11/14/2016 12:24 PM, Todor Tomov wrote: > The ov5645 sensor from Omnivision supports up to 2592x1944 > and CSI2 interface. > > The driver adds support for the following modes: > - 1280x96

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Laurent, Thank you for the detailed review. On 12/05/2016 05:22 PM, Laurent Pinchart wrote: > Hi Todor, > > Thank you for the patch. > > On Friday 25 Nov 2016 16:57:20 Todor Tomov wrote: >> These files handle the video device nodes of the camss driver. > > ca

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

Hi Sakari, Rob, On 08/25/2016 10:18 AM, Sakari Ailus wrote: > Hi Todor, > > On Wed, Aug 24, 2016 at 06:24:31PM +0300, Todor Tomov wrote: >> Hi Sakari, >> >> Thanks a lot for the time spent to review the driver! > > You're welcome! :-) > >> I have a fe

[PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/i2c/Kconfig

[PATCH v6 1/2] media: i2c/ov5645: add the device tree binding document

Add the document for ov5645 device tree binding. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../devicetree/bindings/media/i2c/ov5645.txt | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov56

[PATCH v6 0/2] OV5645 camera sensor driver

include: - patch split to dt binding doc patch and driver patch; - changes in power on/off logic - s_power is now not called on open/close; - using assigned-clock-rates in dt for setting camera external clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

>> Yes, I'll do that. If I follow the code correctly this init_cfg() is called whenever the device is opened, right? This means that the format will be reset to default values every time the userspace opens the device. So I wonder if this is what we really want, or do we want to keep

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

Hi Sakari, Thanks a lot for the time spent to review the driver! I have a few responses bellow. On 08/24/2016 01:17 PM, Sakari Ailus wrote: > Hi Todor, > > Thank you for the patch. Please see my comments below. > > On Fri, Jul 08, 2016 at 05:54:39PM +0300, Todor Tomov wrote

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

Hi, On 10/26/2016 03:48 PM, Ian Arkver wrote: > [snip] >>> +static int ov5645_regulators_enable(struct ov5645 *ov5645) >>> +{ >>> +int ret; >>> + >>> +ret = regulator_enable(ov5645->io_regulator); >>> +if (ret < 0) { >>> +dev_err(ov5645->dev, "set

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

Hi, On 10/26/2016 07:48 PM, Ian Arkver wrote: > On 26/10/16 15:07, Todor Tomov wrote: >> Hi, >> >> On 10/26/2016 03:48 PM, Ian Arkver wrote: >>> [snip] >>>>>>>>> +static int ov5645_regulators_enable(struct ov5645 *ov5645) >>&g

Re: [PATCH v6 1/2] media: i2c/ov5645: add the device tree binding document

Hi Laurent, Thank you for the review. On 09/08/2016 03:22 PM, Laurent Pinchart wrote: > Hi Todor, > > Thank you for the patch. > > On Thursday 08 Sep 2016 12:13:54 Todor Tomov wrote: >> Add the document for ov5645 device tree binding. >> >> Signed-off-by: To

Re: [PATCH v6 1/2] media: i2c/ov5645: add the device tree binding document

Hi Laurent, Thank you for the review. On 10/19/2016 11:49 AM, Laurent Pinchart wrote: > Hi Todor, > > On Friday 14 Oct 2016 15:01:08 Todor Tomov wrote: >> On 09/08/2016 03:22 PM, Laurent Pinchart wrote: >>> On Thursday 08 Sep 2016 12:13:54 Todor Tomov wrote: >>

Re: [PATCH v7 2/2] media: Add a driver for the ov5645 camera sensor.

Hi Laurent, Thank you once again for the review. On 11/14/2016 02:38 PM, Laurent Pinchart wrote: > Hi Todor, > > Thank you for the patch. > > On Monday 14 Nov 2016 12:24:36 Todor Tomov wrote: >> The ov5645 sensor from Omnivision supports up to 2592x1944 >> and CSI2

[PATCH v7 2/2] media: Add a driver for the ov5645 camera sensor.

The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/i2c/Kconfig

[PATCH v7 0/2] OV5645 camera sensor driver

camera external clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor Tomov (2): media: i2c/ov5645: add the device tree binding document media: Add a driver for the ov5645 camera sensor. .../devicetree/bindings/media/i2c/ov5645.txt | 54 + drivers

[PATCH v7 1/2] media: i2c/ov5645: add the device tree binding document

Add the document for ov5645 device tree binding. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../devicetree/bindings/media/i2c/ov5645.txt | 54 ++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov56

[PATCH 01/10] doc: DT: camss: Binding document for Qualcomm Camera subsystem driver

Add DT binding document for Qualcomm Camera subsystem driver. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../devicetree/bindings/media/qcom,camss.txt | 196 + 1 file changed, 196 insertions(+) create mode 100644 Documentation/devicetree/bindings/medi

[PATCH 00/10] Qualcomm 8x16 Camera Subsystem driver

/lists/linux-media/msg104013.html Todor Tomov (10): doc: DT: camss: Binding document for Qualcomm Camera subsystem driver MAINTAINERS: Add Qualcomm Camera subsystem driver doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document media: camss: Add CSIPHY files media: camss: Add

[PATCH 10/10] media: camss: Add Makefiles and Kconfig files

Add Makefiles and Kconfig files to build the camss driver. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/Kconfig | 5 + drivers/media/platform/qcom/Makefile| 1 + drivers/media/platform/qcom/camss-8x16/Makefil

[PATCH 04/10] media: camss: Add CSIPHY files

These files control the CSIPHY modules which are responsible for the physical layer of the CSI2 receivers. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/csiphy.c | 685 drivers/media/platform/qcom/camss-8x16/csiphy.h

[PATCH 02/10] MAINTAINERS: Add Qualcomm Camera subsystem driver

Add an entry for Qualcomm Camera subsystem driver. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 411e3b8..0740aee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9971,6 +9971,1

[PATCH 09/10] media: camms: Add core files

These files implement the platform driver code. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/camss.c | 603 + drivers/media/platform/qcom/camss-8x16/camss.h | 93 2 files changed, 696 insertions(+) creat

[PATCH 05/10] media: camss: Add CSID files

These files control the CSID modules which handle the protocol and application layer of the CSI2 receivers. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/csid.c | 1071 + drivers/media/platform/qcom/camss-8x16/csid.h

[PATCH 06/10] media: camss: Add ISPIF files

These files control the ISPIF module which handles the routing of the data streams from the CSIDs to the inputs of the VFE. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/ispif.c | 1105 drivers/media/platform/qcom

[PATCH 03/10] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

Add a document to describe Qualcomm Camera Subsystem driver. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- Documentation/media/v4l-drivers/index.rst | 1 + Documentation/media/v4l-drivers/qcom_camss.rst | 124 + 2 files changed, 125 insertions(+)

[PATCH 07/10] media: camss: Add VFE files

to memory. RDI interfaces are supported in this version. PIX interface is not supported. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/vfe.c | 1877 ++ drivers/media/platform/qcom/camss-8x16/vfe.h | 112 ++ 2 files changed

[PATCH 08/10] media: camss: Add files which handle the video device nodes

These files handle the video device nodes of the camss driver. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/video.c | 597 + drivers/media/platform/qcom/camss-8x16/video.h | 67 +++ 2 files changed, 664 inse

Re: [PATCH v6 1/2] media: i2c/ov5645: add the device tree binding document

On 10/26/2016 09:53 PM, Rob Herring wrote: > On Wed, Oct 19, 2016 at 4:21 AM, Laurent Pinchart > <laurent.pinch...@ideasonboard.com> wrote: >> Hi Todor, >> >> On Wednesday 19 Oct 2016 12:14:55 Todor Tomov wrote: >>> On 10/19/2016 11:49 AM, Laurent Pinchart

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

And using Mark Brown's correct address... On 10/26/2016 02:15 PM, Todor Tomov wrote: > Hi, > > Adding Mark Brown in --to list. > > My reply on comments below. > The question on regulator bulk API to Mark Brown still holds. > > > On 10/19/2016 11:44 AM, Laurent

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

Hi, Adding Mark Brown in --to list. My reply on comments below. The question on regulator bulk API to Mark Brown still holds. On 10/19/2016 11:44 AM, Laurent Pinchart wrote: > Hi Todor, > > (CC'ing Mark Brown for a question on regulators) > > On Friday 14 Oct 2016 14:57:01 To

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

gt; Thank you for the patch. > > On Thursday 08 Sep 2016 12:13:55 Todor Tomov wrote: >> The ov5645 sensor from Omnivision supports up to 2592x1944 >> and CSI2 interface. >> >> The driver adds support for the following modes: >> - 1280x960 >> - 1920x1080 >

Re: [PATCH 00/10] Qualcomm 8x16 Camera Subsystem driver

the first thing to do - go over the comments received. I'll reply for each of them. Thank you for your notification and the also for the review done! Best regards, Todor > > Regards, > > Hans > > On 11/25/2016 03:56 PM, Todor Tomov wrote: >> This patchset add

Re: [PATCH 01/10] doc: DT: camss: Binding document for Qualcomm Camera subsystem driver

Hi Rob, Happy new year, And thank you for the review. On 12/01/2016 12:03 AM, Rob Herring wrote: > On Fri, Nov 25, 2016 at 04:56:53PM +0200, Todor Tomov wrote: >> Add DT binding document for Qualcomm Camera subsystem driver. >> >> Signed-off-by: Todor Tomov &l

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Hans, Thank you for the extensive review. On 12/05/2016 03:44 PM, Hans Verkuil wrote: > A few comments below: > > On 11/25/2016 03:57 PM, Todor Tomov wrote: >> These files handle the video device nodes of the camss driver. >> >> Signed-off-by: Todor To

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Laurent, Hans, On 12/05/2016 05:25 PM, Laurent Pinchart wrote: > Hi Hans, > > On Monday 05 Dec 2016 16:02:55 Hans Verkuil wrote: >> On 12/05/2016 03:45 PM, Laurent Pinchart wrote: >>> On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: >>>> On 11

[PATCH v8 2/2] media: Add a driver for the ov5645 camera sensor.

The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov <todor.to...@linaro.org> Reviewed-by: Laurent Pinchart <laur

[PATCH v8 0/2] OV5645 camera sensor driver

ting camera external clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor Tomov (2): media: i2c/ov5645: add the device tree binding document media: Add a driver for the ov5645 camera sensor. .../devicetree/bindings/media/i2c/ov5645.txt | 54 + drive

[PATCH v8 1/2] media: i2c/ov5645: add the device tree binding document

Add the document for ov5645 device tree binding. Signed-off-by: Todor Tomov <todor.to...@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- .../devicetree/bindings/media/i2c/ov5645.txt | 54 ++ 1 file changed, 54 insertions(+)

Re: [PATCH v8 1/2] media: i2c/ov5645: add the device tree binding document

Hi Sakari, Thank you for the time to review this again. On 04/04/2017 12:31 PM, Sakari Ailus wrote: > Hi Todor, > > On Mon, Apr 03, 2017 at 05:02:28PM +0300, Todor Tomov wrote: >> Add the document for ov5645 device tree binding. >> >> Signed-off-by: Todor To

[PATCH v9 2/2] media: Add a driver for the ov5645 camera sensor.

The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov <todor.to...@linaro.org> Reviewed-by: Laurent Pinchart <laur

[PATCH v9 1/2] media: i2c/ov5645: add the device tree binding document

Add the document for ov5645 device tree binding. Signed-off-by: Todor Tomov <todor.to...@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> Acked-by: Rob Herring <r...@kernel.org> --- .../d

[PATCH v9 0/2] OV5645 camera sensor driver

gic - s_power is now not called on open/close; - using assigned-clock-rates in dt for setting camera external clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor Tomov (2): media: i2c/ov5645: add the device tree binding document media: Add a driver for the

[PATCH v3 10/23] media: camss: Add VFE files

to memory. RDI interfaces are supported in this version. PIX interface is not supported. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 1913 drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 114 ++ 2 files c

[PATCH v3 14/23] camss: vfe: Format conversion support using PIX interface

Use VFE PIX input interface and do format conversion in VFE. Supported input format is UYVY (single plane YUV 4:2:2) and its different sample order variations. Supported output formats are: - NV12/NV21 (two plane YUV 4:2:0) - NV16/NV61 (two plane YUV 4:2:2) Signed-off-by: Todor Tomov <todor

[PATCH v3 11/23] media: camss: Add files which handle the video device nodes

These files handle the video device nodes of the camss driver. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../media/platform/qcom/camss-8x16/camss-video.c | 627 + .../media/platform/qcom/camss-8x16/camss-video.h | 66 +++ 2 files changed, 693 inse

[PATCH v3 17/23] camss: vfe: Add interface for scaling

Add compose selection ioctls to handle scaling configuration. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 189 - drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 1 + 2 files changed, 188 insertions

[PATCH v3 16/23] camss: vfe: Support for frame padding

Add support for horizontal and vertical frame padding. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 86 +- .../media/platform/qcom/camss-8x16/camss-video.c | 69 - .../media/platform/qcom

[PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total: 46, Succeeded: 46, Failed: 0, Warnings: 0 --- Sakari Ailus (1): v4l: Add packed Bayer raw12 pixel formats Todor Tomov (22

[PATCH v3 03/23] v4l: Add packed Bayer raw12 pixel formats

From: Sakari Ailus These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit variants. The formats added by this patch are V4L2_PIX_FMT_SBGGR12P V4L2_PIX_FMT_SGBRG12P

[PATCH v3 04/23] dt-bindings: media: Binding document for Qualcomm Camera subsystem driver

Add DT binding document for Qualcomm Camera subsystem driver. CC: Rob Herring <robh...@kernel.org> CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../devicetree/bindings/media/qcom,camss.txt | 191 + 1 file changed, 19

[PATCH v3 22/23] camss: Use optimal clock frequency rates

the CSID test generator usage. If VFE is already powered on by another pipeline, check that the current VFE clock rate is high enough for the new pipeline. If not return busy error code as VFE clock rate cannot be changed while VFE is running. Signed-off-by: Todor Tomov <todor.to...@linaro.

[PATCH v3 21/23] doc: media/v4l-drivers: Qualcomm Camera Subsystem - Scale and crop

Update the Qualcomm Camera Subsystem driver document for VFE scale and crop modules support. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- Documentation/media/v4l-drivers/qcom_camss.rst | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Documen

[PATCH v3 23/23] doc: media/v4l-drivers: Qualcomm Camera Subsystem - Media graph

Update the Qualcomm Camera Subsystem driver document with a media controller pipeline graph diagram. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- Documentation/media/v4l-drivers/qcom_camss.rst | 27 ++ .../media/v4l-drivers/qcom_camss_graph.dot

[PATCH v3 19/23] camss: vfe: Add interface for cropping

Extend selection ioctls to handle cropping configuration. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 191 - drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 1 + 2 files changed, 150 insertions(

[PATCH v3 18/23] camss: vfe: Configure scaler module in VFE

Add scaler module configuration support to be able to apply scaling. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 59 +- 1 file changed, 46 insertions(+), 13 deletions(-) diff --git a/drivers/media/platfor

[PATCH v3 20/23] camss: vfe: Configure crop module in VFE

Add crop module configuration support to be able to apply cropping. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 41 +- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/media/platfor

[PATCH v3 13/23] media: camss: Enable building

Add Makefile and update platform/Kconfig and platform/Makefile to enable building of the QCom CAMSS driver. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/Kconfig | 7 +++ drivers/media/platform/Makefile | 2 ++ drivers

[PATCH v3 12/23] media: camms: Add core files

These files implement the platform driver code. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/platform/qcom/camss-8x16/camss.c | 705 + drivers/media/platform/qcom/camss-8x16/camss.h | 97 2 files changed, 802 insertions(+) creat

[PATCH v3 15/23] doc: media/v4l-drivers: Qualcomm Camera Subsystem - PIX Interface

Update Qualcomm Camera Subsystem driver document for the PIX interface and format conversion support. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- Documentation/media/v4l-drivers/qcom_camss.rst | 41 +++--- 1 file changed, 31 insertions(+), 10 deletions(-)

[PATCH v3 08/23] media: camss: Add CSID files

These files control the CSID modules which handle the protocol and application layer of the CSI2 receivers. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../media/platform/qcom/camss-8x16/camss-csid.c| 1073 .../media/platform/qcom/camss-8x16/camss-

[PATCH v3 07/23] media: camss: Add CSIPHY files

These files control the CSIPHY modules which are responsible for the physical layer of the CSI2 receivers. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../media/platform/qcom/camss-8x16/camss-csiphy.c | 816 + .../media/platform/qcom/camss-8x16/camss-cs

[PATCH v3 02/23] [media] v4l2-mediabus: Add helper functions

Add helper functions for mbus to/from mplane pixel format conversion. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- include/media/v4l2-mediabus.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/media/v4l2-mediabus.h b/include/medi

[PATCH v3 06/23] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

Add a document to describe Qualcomm Camera Subsystem driver. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- Documentation/media/v4l-drivers/qcom_camss.rst | 124 + 1 file changed, 124 insertions(+) create mode 100644 Documentation/media/v4l-d

[PATCH v3 05/23] MAINTAINERS: Add Qualcomm Camera subsystem driver

Add an entry for Qualcomm Camera subsystem driver. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5a9f0f6..4cb978a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10887,6 +10

[PATCH v3 01/23] [media] media: Make parameter of media_entity_remote_pad() const

The local pad parameter in media_entity_remote_pad() is not modified. Make that explicit by adding a const modifier. Signed-off-by: Todor Tomov <todor.to...@linaro.org> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> --- drivers/media/media-entity.c | 2 +- include/media/media-

[PATCH v3 09/23] media: camss: Add ISPIF files

These files control the ISPIF module which handles the routing of the data streams from the CSIDs to the inputs of the VFE. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- .../media/platform/qcom/camss-8x16/camss-ispif.c | 1127 .../media/platform/qcom/cams

[PATCH] [media] v4l2-mediabus: Add helper functions

Add helper functions for mbus to/from mplane pixel format conversion. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- include/media/v4l2-mediabus.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/media/v4l2-mediabus.h b/include/medi

[PATCH v2] [media] v4l2-mediabus: Add helper functions

Add helper functions for mbus to/from mplane pixel format conversion. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- include/media/v4l2-mediabus.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/media/v4l2-mediabus.h b/include/medi

Re: [PATCH] [media] v4l2-mediabus: Add helper functions

On 07/07/2017 11:23 AM, Hans Verkuil wrote: > On 07/07/2017 10:18 AM, Todor Tomov wrote: >> Add helper functions for mbus to/from mplane pixel format conversion. >> >> Signed-off-by: Todor Tomov <todor.to...@linaro.org> >> --- >&g

Re: [PATCH v3 22/23] camss: Use optimal clock frequency rates

> https://github.com/0day-ci/linux/commits/Todor-Tomov/Qualcomm-8x16-Camera-Subsystem-driver/20170718-055348 > base: git://linuxtv.org/media_tree.git master > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: >

Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

Hello Hans, On 19.07.2017 13:54, Hans Verkuil wrote: > On 17/07/17 12:33, Todor Tomov wrote: >> This patchset adds basic support for the Qualcomm Camera Subsystem found >> on Qualcomm MSM8916 and APQ8016 processors. >> >> The driver implements V4L2, Media controller

Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

Hello Sakari, Thank you for the review! On 20.07.2017 18:25, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 17, 2017 at 01:33:26PM +0300, Todor Tomov wrote: >> This patchset adds basic support for the Qualcomm Camera Subsystem found >> on Qualcomm MSM8916 a

Re: [PATCH v3 10/23] media: camss: Add VFE files

Hi Sakari, Thank you for the review. On 20.07.2017 17:59, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 17, 2017 at 01:33:36PM +0300, Todor Tomov wrote: >> These files control the VFE module. The VFE has different input interfaces. >> The PIX input interface feeds the i

Re: [PATCH v3 17/23] camss: vfe: Add interface for scaling

Hi Sakari, Thank you for review. On 20.07.2017 18:20, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 17, 2017 at 01:33:43PM +0300, Todor Tomov wrote: >> Add compose selection ioctls to handle scaling configuration. >> >> Signed-off-by: Todor Tomov <todor.to...@

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

Hi Sakari, On 06/30/2017 02:53 AM, Sakari Ailus wrote: > Hi Todor, > > On Thu, Jun 29, 2017 at 07:36:47PM +0300, Todor Tomov wrote: >>>> +/* >>>> + * csiphy_link_setup - Setup CSIPHY connections >>>> + * @entity: Pointer to media entity st

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

Hi Sakari, On 06/29/2017 12:34 AM, Sakari Ailus wrote: > Hi Todor, > > It's been a while --- how do you do? > > Thanks for the patchset! Thank you for the review. I'll focus more on this now, so let's see :) > > On Mon, Jun 19, 2017 at 05:48:24PM +0300, Todor Tomov

[PATCH] [media] media: Make parameter of media_entity_remote_pad() const

The local pad parameter in media_entity_remote_pad() is not modified. Make that explicit by adding a const modifier. Signed-off-by: Todor Tomov <todor.to...@linaro.org> --- drivers/media/media-entity.c | 2 +- include/media/media-entity.h | 2 +- 2 files changed, 2 insertions(+), 2 del

Re: [PATCH v2 09/19] media: camms: Add core files

Hi Sakari, Thank you for the review. On 06/29/2017 09:33 AM, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jun 19, 2017 at 05:48:29PM +0300, Todor Tomov wrote: >> These files implement the platform driver code. >> >> Signed-off-by: Todor Tomov <todor.to...@linaro

  1   2   3   >