Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Daniel Drake
On 31 October 2010 14:42, Ohad Ben-Cohen o...@wizery.com wrote: I guess the error comes from mmc_sdio_init_card() - can you please check out what exactly triggers it inside that function (just put some printk's there..) ? /* * For native busses: set card RCA and quit open

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Ohad Ben-Cohen
On Sun, Oct 31, 2010 at 4:55 PM, Daniel Drake d...@laptop.org wrote:        /*         * For native busses:  set card RCA and quit open drain mode.         */        if (!powered_resume !mmc_host_is_spi(host)) {                err = mmc_send_relative_addr(host, card-rca); This returns -110

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Daniel Drake
On 31 October 2010 15:08, Ohad Ben-Cohen o...@wizery.com wrote: Quick question - how did you manage the power to the sd8686 ? Was it possible to power it down after boot or was it always kept high ? I didn't do anything except boot then try and load the module. Does that answer the question?

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Ohad Ben-Cohen
On Sun, Oct 31, 2010 at 5:10 PM, Daniel Drake d...@laptop.org wrote: On 31 October 2010 15:08, Ohad Ben-Cohen o...@wizery.com wrote: Quick question - how did you manage the power to the sd8686 ? Was it possible to power it down after boot or was it always kept high ? I didn't do anything

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Daniel Drake
On 31 October 2010 15:16, Ohad Ben-Cohen o...@wizery.com wrote: No, I'm asking a more general question about the sd8686 and the XO-1.5. How can one control the power to the sd8686 ? Is it always on and can't be controlled ? Is there a GPIO that controls it ? or any other mean to control its

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Daniel Drake
On 31 October 2010 15:16, Ohad Ben-Cohen o...@wizery.com wrote: No, I'm asking a more general question about the sd8686 and the XO-1.5. How can one control the power to the sd8686 ? Is it always on and can't be controlled ? Is there a GPIO that controls it ? or any other mean to control its

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Ohad Ben-Cohen
On Sun, Oct 31, 2010 at 5:21 PM, Daniel Drake d...@laptop.org wrote: The power can be controlled by the regular SD power pin. There is no GPIO to control it. OK, Good. Can you please tell me the output of the following line (after boot, but before you load the driver): cat

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Daniel Drake
On 31 October 2010 15:27, Ohad Ben-Cohen o...@wizery.com wrote: Can you please tell me the output of the following line (after boot, but before you load the driver): cat /sys/kernel/debug/mmc1/ios clock: 0 Hz vdd:0 (invalid) bus mode: 1 (open drain) chip select:

[PATCH 1/2] MMC Agressive clocking framework v7

2010-10-31 Thread Linus Walleij
This patch modifies the MMC core code to optionally call the set_ios() operation on the driver with the clock frequency set to 0 (gate) after a grace period of at least 8 MCLK cycles, then restore it (ungate) before any new request. This gives the driver the option to shut down the MCI clock to

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Ohad Ben-Cohen
On Sun, Oct 31, 2010 at 5:57 PM, Daniel Drake d...@laptop.org wrote: cat /sys/kernel/debug/mmc1/ios clock:          0 Hz vdd:            0 (invalid) bus mode:       1 (open drain) chip select:    0 (don't care) power mode:     0 (off) bus width:      0 (1 bits) timing spec:    0 (legacy)

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Daniel Drake
On 31 October 2010 16:16, Ohad Ben-Cohen o...@wizery.com wrote: Just to make sure - on an older kernel (that doesn't have SDIO runtime pm), the card is powered on at this stage (this info will help me rule out some corner cases) ? Looks that way. Same test, after reverting your patches:

regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-10-31 Thread Arnd Hannemann
Hi, on todays Linus' git (v2.6.36-9871-g3985c7c) b43 sdio stopped working. It was working on (v2.6.36-6794-g12ba8d1). b43-sdio: probe of mmc0:0001:1 failed with error -16 The error seems to originate from the following code in drivers/mmc/core/sdio_bus.c:sdio_bus_probe() 135 ret =

Re: regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-10-31 Thread Chris Ball
Hi Arnd, On Sun, Oct 31, 2010 at 06:16:04PM +0100, Arnd Hannemann wrote: on todays Linus' git (v2.6.36-9871-g3985c7c) b43 sdio stopped working. It was working on (v2.6.36-6794-g12ba8d1). b43-sdio: probe of mmc0:0001:1 failed with error -16 The error seems to originate from the following

Re: regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-10-31 Thread Arnd Hannemann
Am 31.10.2010 18:16, schrieb Arnd Hannemann: on todays Linus' git (v2.6.36-9871-g3985c7c) b43 sdio stopped working. It was working on (v2.6.36-6794-g12ba8d1). b43-sdio: probe of mmc0:0001:1 failed with error -16 The error seems to originate from the following code in

Re: MMC runtime PM patches break libertas probe

2010-10-31 Thread Ohad Ben-Cohen
On Sun, Oct 31, 2010 at 6:24 PM, Daniel Drake d...@laptop.org wrote: On 31 October 2010 16:16, Ohad Ben-Cohen o...@wizery.com wrote: Just to make sure - on an older kernel (that doesn't have SDIO runtime pm), the card is powered on at this stage (this info will help me rule out some corner

Re: regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-10-31 Thread Ohad Ben-Cohen
Hi Arnd, On Sun, Oct 31, 2010 at 7:16 PM, Arnd Hannemann a...@arndnet.de wrote: b43-sdio: probe of mmc0:0001:1 failed with error -16 It's exactly what Daniel is experiencing with the XO-1.5. In Daniel's scenario, mmc_sdio_init_card() fails because mmc_send_relative_addr() returns -110. Can

Re: regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-10-31 Thread Arnd Hannemann
Hi Ohad, Am 31.10.2010 20:14, schrieb Ohad Ben-Cohen: On Sun, Oct 31, 2010 at 7:16 PM, Arnd Hannemann a...@arndnet.de wrote: b43-sdio: probe of mmc0:0001:1 failed with error -16 It's exactly what Daniel is experiencing with the XO-1.5. In Daniel's scenario, mmc_sdio_init_card() fails

RE: commit mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host

2010-10-31 Thread Maxim Levitsky
On Sat, 2010-10-30 at 16:01 +0200, Maxim Levitsky wrote: On Sat, 2010-10-30 at 05:47 -0700, Philip Rakity wrote: eMMC unlike SD does not have a field to inside the card data to say the bit width of the card. In addition some mmc cards (from Transcend) only support 1 bit mode. The

Re: commit mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host

2010-10-31 Thread Philip Rakity
On Oct 31, 2010, at 6:44 PM, Maxim Levitsky wrote: On Sat, 2010-10-30 at 16:01 +0200, Maxim Levitsky wrote: On Sat, 2010-10-30 at 05:47 -0700, Philip Rakity wrote: eMMC unlike SD does not have a field to inside the card data to say the bit width of the card. In addition some mmc cards

Re: regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-10-31 Thread Ohad Ben-Cohen
On Sun, Oct 31, 2010 at 11:51 PM, Arnd Hannemann a...@arndnet.de wrote: In Daniel's scenario, mmc_sdio_init_card() fails because mmc_send_relative_addr() returns -110. Can you please check out if that's the same thing you have too ? No, it seems to be the pm_runtime_get_sync in