Re: [PATCH] mmc: agressive clocking framework v9

2010-11-07 Thread Ohad Ben-Cohen
On Sat, Nov 6, 2010 at 7:38 PM, Philip Rakity prak...@marvell.com wrote: When clock gating is enabled with SDIO cards we have seen a) Missed Interrupts b) Transactions not completed As David suggested, these issues are probably card-specific. The 128x wlan card, e.g., supports both

Re: MMC runtime PM patches break libertas probe

2010-11-07 Thread Daniel Drake
On 7 November 2010 01:48, Nicolas Pitre n...@fluxnic.net wrote: Couldn't you implement this any other way?  This seems to be a really bad strategy for this IMHO. What's so bad about it? Any suggestions? Daniel -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of

Re: MMC runtime PM patches break libertas probe

2010-11-07 Thread Ohad Ben-Cohen
On Sat, Nov 6, 2010 at 11:19 PM, Daniel Drake d...@laptop.org wrote: Thanks. It solves the problem. Good. Did it also solve the 1st issue you had ? Anyway I'm still interested to reproduce that crash. No reason to get a kernel panic whatsoever. But, what you point out is quite interesting.

Re: MMC runtime PM patches break libertas probe

2010-11-07 Thread Daniel Drake
On 7 November 2010 10:42, Ohad Ben-Cohen o...@wizery.com wrote: Good. Did it also solve the 1st issue you had ? Yes. But, what you point out is quite interesting. We currently have a (not-yet-upstream) rfkill driver for the XO-1.5, which we also put in place for power saving reasons. Can

Re: MMC runtime PM patches break libertas probe

2010-11-07 Thread Ohad Ben-Cohen
On Sun, Nov 7, 2010 at 12:51 PM, Daniel Drake d...@laptop.org wrote: If you take the interface down, the card is still powered up in some way. With SDIO runtime pm support, it shouldn't be. When I asked the hardware guy he said it was entirely controlled by the normal SD power pin, but a

Re: MMC runtime PM patches break libertas probe

2010-11-07 Thread Nicolas Pitre
On Sun, 7 Nov 2010, Daniel Drake wrote: On 7 November 2010 01:48, Nicolas Pitre n...@fluxnic.net wrote: Couldn't you implement this any other way?  This seems to be a really bad strategy for this IMHO. What's so bad about it? Any suggestions? If you want rfkill functionality, then maybe

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-07 Thread Philip Rakity
On Nov 6, 2010, at 6:44 PM, Nicolas Pitre wrote: On Sat, 6 Nov 2010, Philip Rakity wrote: We need a way to specify a) Hardware can support clock gating setting the clock to 0 in the call to set_ios (with hardware clock gating enabled) becomes a no-op so some care is needed which is

Re: PATCH: mmc.c DDR print of card type not correct

2010-11-07 Thread Chris Ball
Hi Philip, On Fri, Oct 29, 2010 at 01:13:38AM -0700, Philip Rakity wrote: we should not call mmc_card_set_ddr_mode if we are in single data mode. This sets DDR and causes the print out in the log to say the card is DDR when it is not. Explicitly set ddr to 0 rather then rely on

Re: [PATCH] mmc: Return proper error code for ushc_probe()

2010-11-07 Thread Chris Ball
Hi, On Thu, Nov 04, 2010 at 10:04:25AM +, David Vrabel wrote: Thanks. Acked-by: David Vrabel david.vra...@csr.com Chris, queue this one up for 2.6.37 please. Pushed and queued for 2.6.37, thanks. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To

Re: [PATCH] SDHCI: Properly enable SDIO IRQ wakeups

2010-11-07 Thread Chris Ball
Hi Daniel, On Thu, Nov 04, 2010 at 10:20:39PM +, Daniel Drake wrote: A little more work was needed for SDIO IRQ wakeups to be functional. Wake-on-WLAN on the SD WiFi adapter in the XO-1.5 laptop is now working. Signed-off-by: Daniel Drake d...@laptop.org Thanks, pushed and queued for

Re: [PATCH v4 0/2] add support for the Marvell Dove SDHCI controller

2010-11-07 Thread Chris Ball
Hi Mike, On Thu, Oct 28, 2010 at 09:23:51PM +0200, Mike Rapoport wrote: These patches add support for the Marvell Dove SDHCI controller. Thanks, I've pushed these to mmc-next for the 2.6.38 merge now. (Applied a minor correction: MMC_SDHCI_DOVE is a bool, not a tristate, so I removed the say Y

Re: [PATCH 1/2] sdhci-esdhc-imx: fix timeout on i.MX's sdhci

2010-11-07 Thread Chris Ball
Hi Eric, On Sat, Oct 23, 2010 at 01:57:21AM +0200, Eric Bénard wrote: this patch fix timeout problems on i.MX's sdhci as suggested by Richard Zhu. Tested on : - i.MX257 : not needed - i.MX357 : needed - i.MX515 : needed more details can be found here :

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-07 Thread Nicolas Pitre
On Sun, 7 Nov 2010, Philip Rakity wrote: On Nov 6, 2010, at 6:44 PM, Nicolas Pitre wrote: On Sat, 6 Nov 2010, Philip Rakity wrote: We need a way to specify a) Hardware can support clock gating setting the clock to 0 in the call to set_ios (with hardware clock gating

Re: [PATCH] sdhci: 8 bit widths - allow new QUIRK for 8 bit and v3 sd controller

2010-11-07 Thread Philip Rakity
On Nov 7, 2010, at 2:04 PM, Wolfram Sang wrote: On Fri, Oct 08, 2010 at 12:31:34PM -0700, Philip Rakity wrote: 8 bit width is a new feature in the sd 3.0 spec. Add checks to ensure HOST_CONTROL register set 8 bit mode only if sd 3.0 add quirk to indicate that board design supports 8