Re: [PATCH 2/2] mmc: mvsdio: delete platform data code path

2015-11-25 Thread Nicolas Pitre
On Wed, 25 Nov 2015, Linus Walleij wrote: > There are no in-kernel users of the MVSDIO platform data method > (instantiating from a board file) so just delete this code and > make this a DT-only driver. We depend on OF and check that we have > an OF node in probe(). > > Cc

Re: [PATCH 2/4] mmc: mvsdio: avoid compiler warning

2014-06-05 Thread Nicolas Pitre
On Thu, 5 Jun 2014, Arnd Bergmann wrote: gcc correctly points out that hw_state can be used uninitially in the mvsd_setup_data() function. This rearranges the function to ensure it always contains a proper value. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Nicolas Pitre n...@fluxnic.net

Re: mvsdio: unhandled interrupt, mmc writes queuing up

2014-03-19 Thread Nicolas Pitre
On Wed, 19 Mar 2014, Bruno Prémont wrote: Hi, Since upgrading my Sheevaplug from 3.7.2 to 3.13.6 (FDT) I'm seeing mvsdio f109.mvsdio: unhandled interrupt status=0x8810 en=0x pio=0 at varied timings. It has been many years since I've looked at the code for this driver. I'm

Re: [PATCH RFC 03/31] mmc: sdio_irq: rework sdio irq handling

2014-02-18 Thread Nicolas Pitre
On Tue, 18 Feb 2014, Russell King wrote: Rather than the SDIO support spawning it's own thread for handling card interrupts, use the generic IRQ infrastructure for this, triggering it from the host interface's interrupt handling directly. This avoids a race between the parent thread waiting

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Nicolas Pitre
On Fri, 17 Jan 2014, Rob Herring wrote: On Thu, Jan 16, 2014 at 9:08 PM, Nicolas Pitre n...@fluxnic.net wrote: On Thu, 16 Jan 2014, Olof Johansson wrote: for SDIO slots is somewhat misleading; nearly all controllers only do one slot/device per controller. The designware controller can do

Re: How to support SDIO wifi/bt in DT

2014-01-16 Thread Nicolas Pitre
On Thu, 16 Jan 2014, Olof Johansson wrote: for SDIO slots is somewhat misleading; nearly all controllers only do one slot/device per controller. The designware controller can do multiple slots, and that adds a bit of driver and binding complexity for something that seemingly not a single

Re: [PATCH 09/27] mmc: mvsdio: Remove redundant suspend and resume callbacks

2013-09-26 Thread Nicolas Pitre
On Thu, 26 Sep 2013, Ulf Hansson wrote: Suspend and resume of cards are handled by the protocol layer and consequently the mmc_suspend|resume_host APIs are marked as deprecated. Having the protocol layer take care of card suspend is perfectly sound. However, what about host controllers?

Re: [PATCH] mmc: core: Add a capability for disabling mmc cards

2013-05-14 Thread Nicolas Pitre
On Tue, 14 May 2013, Chris Ball wrote: Hi, On Tue, May 14 2013, Adam Lee wrote: On Tue, May 14, 2013 at 03:38:17PM +0800, Adam Lee wrote: On some systems we need a way to disable MMC card support in a MMC/SD card slot due to the legal concern. Add support in the core SD/MMC code to

Re: [PATCH v5 0/4] mmc: core: Signal voltage switch procedure for UHS mode

2013-01-08 Thread Nicolas Pitre
On Tue, 8 Jan 2013, Johan Rudholm wrote: This patch series attempts to make the 1.8V signal voltage switch required for UHS mode work according to the SD specification. These patches have been tested with a couple of UHS SD cards, one of which sometimes requires up to five power cycles

Re: [PATCH 1/2] mmc: core: Add a capability for disabling mmc cards

2012-08-22 Thread Nicolas Pitre
On Wed, 22 Aug 2012, Olof Johansson wrote: On Wed, Aug 22, 2012 at 9:00 AM, Philip Rakity prak...@marvell.com wrote: On Aug 22, 2012, at 8:44 AM, Doug Anderson diand...@chromium.org wrote: Thanks for your feedback. In this case I have a card that is an MMC card so mmc_attach_sdio()

Re: [PATCH 2/3] ext4: Context support

2012-06-14 Thread Nicolas Pitre
On Wed, 13 Jun 2012, Ted Ts'o wrote: On Wed, Jun 13, 2012 at 08:43:47PM +, Arnd Bergmann wrote: For SD cards, almost everyone is lying and we cannot trust the information, and for USB flash, there is no way to ask the device. In both of these cases, we probably want to detect the

[PATCH v2] mmc: sdio: avoid spurious calls to interrupt handlers

2012-04-16 Thread Nicolas Pitre
is signaled by the host driver and we know there is no point confirming it. Reported-by: Sujit Reddy Thumma sthu...@codeaurora.org Signed-off-by: Nicolas Pitre n...@linaro.org Cc: sta...@kernel.org --- V2: avoid using mmc_signal_sdio_irq() from mmc_sdio_resume((). diff --git a/drivers/mmc/core

Re: [PATCH] mmc: sdio: avoid spurious calls to interrupt handlers

2012-04-15 Thread Nicolas Pitre
. Let's add a flag to perform the optimization only when a real interrupt is signaled by the host driver and we know there is no point confirming it. Thanks for putting up formal patch. Reported-by: Sujit Reddy Thumma sthu...@codeaurora.org Signed-off-by: Nicolas Pitre n...@linaro.org

Re: [PATCH 2/2] mmc: sdhci: always reset all during resume

2012-02-04 Thread Nicolas Pitre
On Sat, 4 Feb 2012, Chris Ball wrote: Hi, adding Nico for review, On Mon, Jan 30 2012, Adrian Hunter wrote: During suspend the host controller may or may not be powered off. In order to get the same result either way, always perform a software reset all when resuming. Signed-off-by:

Re: [PATCH] mmc: sdio: optimization for process_sdio_pending_irq

2011-12-09 Thread Nicolas Pitre
On Fri, 9 Dec 2011, Sangwook Lee wrote: Skip fillng in mmc_command struct for CCCR_INTx everytime sdio_irq_thread (process_sdio_pending_irqs) calls mmc_io_rw_direct. Signed-off-by: Sangwook Lee sangwook@linaro.org Is there a real advantage doing this? While you might be saving on a

Re: [Query] mmc: core MMC_PM_KEEP_POWER

2011-11-22 Thread Nicolas Pitre
On Tue, 22 Nov 2011, Eliad Peller wrote: hi Ulf, On Tue, Nov 22, 2011 at 3:29 PM, Ulf Hansson ulf.hans...@stericsson.com wrote: In mmc_resume_host we clear the MMC_PM_KEEP_POWER flag from the pm_flags bitfield. This is done by a patch from Eliad Peller a while ago, mmc: clear

Re: Question: kick SDIO irq when resume

2011-10-31 Thread Nicolas Pitre
On Mon, 31 Oct 2011, Jun Nie wrote: Hi Nico, We are debugging fake SDIO irq when 8787 SDIO card resume and found below patch. The issue is that 8787 driver can not handle card irq if neither 8787 nor host trigger resume event in some cases. Do you remember what SDIO card need below

Re: Question: kick SDIO irq when resume

2011-10-31 Thread Nicolas Pitre
On Mon, 31 Oct 2011, Jun Nie wrote: 2011/10/31 Nicolas Pitre nicolas.pi...@linaro.org: On Mon, 31 Oct 2011, Jun Nie wrote: Hi Nico,     We are debugging fake SDIO irq when 8787 SDIO card resume and found below patch. The issue is that 8787 driver can not handle card irq if neither

Re: [PATCH v8 00/12] use nonblock mmc requests to minimize latency

2011-07-03 Thread Nicolas Pitre
On Sun, 3 Jul 2011, Per Forlin wrote: On 2 July 2011 21:37, Arnd Bergmann a...@arndb.de wrote: On Saturday 02 July 2011 14:29:38 Russell King - ARM Linux wrote: One other thing to be considered here is whether this idea should be limited to just MMC or whether it should be extended

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-21 Thread Nicolas Pitre
On Tue, 21 Jun 2011, Per Forlin wrote: On 21 June 2011 21:18, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 21 Jun 2011, Per Forlin wrote: On 21 June 2011 07:41, Kishore Kadiyala kishorek.kadiy...@gmail.com wrote: snip + +static void omap_hsmmc_pre_req(struct

Re: SDIO single IRQ optimization breaks libertas

2011-05-30 Thread Nicolas Pitre
On Mon, 30 May 2011, Per Forlin wrote: Hi Daniel, On 29 May 2011 15:26, Daniel Drake dsd at laptop.org wrote: Hi, The following commit in 2.6.39 causes instant death for libertas_sdio when it receives its first interrupt during initialization: commit

Re: [PATCH 2/2] sdhci-pxa: add call back interface to share sdhci-pxa

2011-05-19 Thread Nicolas Pitre
On Thu, 19 May 2011, zhangfei gao wrote: On Wed, May 18, 2011 at 4:38 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 17 May 2011, zhangfei gao wrote: The code handle several register difference are located at arch/arm/mach-mmp/mmp2.c is for mmp2 arch/arm/mach-mmp/pxa910.c is for

Re: [PATCH] sdio: optimized SDIO IRQ handling for single function

2011-05-04 Thread Nicolas Pitre
On Wed, 4 May 2011, Per Forlin wrote: On 4 May 2011 05:40, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 3 May 2011, Per Forlin wrote: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered, and IRQ:s are supported and currently

Re: [PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Nicolas Pitre
working with multiple functions if only one of them has claimed an interrupt. Other than that: Reviewed-by: Nicolas Pitre nicolas.pi...@linaro.org Nicolas -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Nicolas Pitre
On Wed, 4 May 2011, Per Forlin wrote: 2011/5/4 Michał Mirosław mir...@gmail.com: 2011/5/4 Per Forlin per.for...@linaro.org: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered it is possible to improve performance by directly calling the irq

Re: [PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Nicolas Pitre
On Wed, 4 May 2011, Per Forlin wrote: On 4 May 2011 19:34, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Wed, 4 May 2011, Per Forlin wrote: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered it is possible to improve performance

Re: [PATCH] sdio: optimized SDIO IRQ handling for single function

2011-05-03 Thread Nicolas Pitre
stefan.xk.nils...@stericsson.com Signed-off-by: Per Forlin per.for...@linaro.org Acked-by: Nicolas Pitre nicolas.pi...@linaro.org --- drivers/mmc/core/sdio_irq.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc

Re: [PATCH 1/3] mmc: initialize struct mmc_command at declaration time

2011-04-14 Thread Nicolas Pitre
On Wed, 13 Apr 2011, Chris Ball wrote: Converts from: struct mmc_command cmd; memset(cmd, 0, sizeof(struct mmc_command)); to: struct mmc_command cmd = {0}; because it's shorter, as performant, and easier to work out whether initialization has happened. Did you

Re: [PATCH v1 2/2] sdio: add power_restore support with MMC_PM_KEEP_POWER mode

2011-03-25 Thread Nicolas Pitre
On Sat, 26 Mar 2011, Wilson Loi wrote: Sorry, this is the first time I sent a patch. There are two case for the WLAN SDIO card to do power saving. 1. Totally cut off the power of WLAN network interface. 2. offload the network state to WLAN SDIO firmware. Case #2 is already supported with

Re: [PATCH 1/3] drivers/mmc/host/mvsdio.c: Convert release_resource to release_mem_region

2011-03-22 Thread Nicolas Pitre
-by: Nicolas Pitre n...@fluxnic.net --- drivers/mmc/host/mvsdio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c index a5bf60e..4606087 100644 --- a/drivers/mmc/host/mvsdio.c +++ b/drivers/mmc/host/mvsdio.c

Re: [PATCH] mmc/sdio: remember new card RCA when redetecting card

2011-03-02 Thread Nicolas Pitre
On Wed, 2 Mar 2011, Chris Ball wrote: Hi, On Tue, Mar 01 2011, Linus Walleij wrote: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com During redetection of a SDIO card, a request for a new card RCA was submitted to the card, but was then overwritten by the old RCA. This

Re: [PATCH 01/12] mmc: sdhci: add support for auto CMD23

2011-02-15 Thread Nicolas Pitre
On Tue, 15 Feb 2011, Arindam Nath wrote: Host Controller v3.00 and later support Auto CMD23 in the Transfer Mode register. Since Auto CMD23 can be used with or without DMA, and if used with DMA, it should _only_ be ADMA, we check against SDHCI_USE_SDMA not being set. This flag is reset when

Re: [PATCH 02/12] mmc: sd: add support for signal voltage switch procedure

2011-02-15 Thread Nicolas Pitre
On Tue, 15 Feb 2011, Arindam Nath wrote: @@ -1340,11 +1342,76 @@ out: spin_unlock_irqrestore(host-lock, flags); } +static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc) +{ + struct sdhci_host *host; + u8 pwr; + u16 clk, ctrl; + u32 present_state; +

Re: [PATCH 2/4] arm: configs: update mmp2 defconfig for brownstone and SoC Selection

2011-02-14 Thread Nicolas Pitre
On Sun, 13 Feb 2011, Philip Rakity wrote: took old mmp2_defconfig -- did make menuconfig changed to CPU_MMP2 added brownstone as supported board Signed-off-by: Philip Rakity prak...@marvell.com --- arch/arm/configs/mmp2_defconfig | 1207 ++- 1

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-06 Thread Nicolas Pitre
On Sun, 6 Feb 2011, Philip Rakity wrote: On Feb 6, 2011, at 3:13 AM, Albert Herranz wrote: Hi, On 02/06/2011 02:35 AM, Philip Rakity wrote: proposed solution: I cannot verify this fix until Monday. = CMD52 is a reset for SDIO cards. CMD0 is not sufficient when the

Re: A MMC card transfer issue

2011-01-31 Thread Nicolas Pitre
On Mon, 31 Jan 2011, Philip Rakity wrote: The transcend mmc card does not have the PHYSICAL pins for 4 bit mode; only 1 bit can be supported. Testing the bus width is the recommend way to find out the bus width. The current behavior when the QUIRK is not defined is to default to 4 bit

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Nicolas Pitre
On Mon, 24 Jan 2011, Tony Olech wrote: On Fri, 2011-01-21 at 16:14 -0500, Nicolas Pitre wrote: On Fri, 21 Jan 2011, Tony Olech wrote: There are 5 do not initialise statics errors reported by scripts/checkpatch.pl you probably should fix those. They are due to lines

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-24 Thread Nicolas Pitre
On Sun, 23 Jan 2011, Tardy, Pierre wrote: First case: you want to stop the clock _to_ the _card_ when not talking to it. That has nothing to do with power saving performed within the host controller. This is for reducing power consumption by the _card_ (and possibly by the clock

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-24 Thread Nicolas Pitre
On Sun, 23 Jan 2011, Ohad Ben-Cohen wrote: On Sun, Jan 23, 2011 at 7:20 AM, Nicolas Pitre n...@fluxnic.net wrote: First case:  you want to stop the clock _to_ the _card_ when not talking to it.  That has nothing to do with power saving performed within the host controller

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-24 Thread Nicolas Pitre
On Mon, 24 Jan 2011, Tony Olech wrote: On Mon, 2011-01-24 at 10:55 -0500, Nicolas Pitre wrote: On Mon, 24 Jan 2011, Tony Olech wrote: On Mon, 2011-01-24 at 09:43 -0500, Nicolas Pitre wrote: Uninitialized global scope variables are by definition assigned to the .bss section

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-23 Thread Nicolas Pitre
On Sun, 23 Jan 2011, Wolfram Sang wrote: On Sat, Jan 22, 2011 at 02:07:21PM -0500, Nicolas Pitre wrote: On Sat, 22 Jan 2011, Wolfram Sang wrote: On Fri, Jan 21, 2011 at 04:14:46PM -0500, Nicolas Pitre wrote: On Fri, 21 Jan 2011, Tony Olech wrote: Add a driver for Elan

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-22 Thread Nicolas Pitre
On Sat, 22 Jan 2011, Wolfram Sang wrote: On Fri, Jan 21, 2011 at 04:14:46PM -0500, Nicolas Pitre wrote: On Fri, 21 Jan 2011, Tony Olech wrote: Add a driver for Elan Digital System's VUB300 chip which is a USB connected SDIO/SDmem/MMC host controller. A VUB300 chip enables a USB 2.0

Re: [PATCH] mmc: clear all interrupt in suspend before free_irq

2011-01-21 Thread Nicolas Pitre
On Fri, 21 Jan 2011, zhangfei gao wrote: From b7be39e0bbac3950057078ac66900ebc0871f77e Mon Sep 17 00:00:00 2001 From: Zhangfei Gao zhangfei@marvell.com Date: Fri, 21 Jan 2011 18:02:47 -0500 Subject: [PATCH] mmc: clear all interrupt in suspend before free_irq When debugging wifi

Re: [PATCH V3 3/3 ] mmc: add support for H/W clock gating of SD controller (resend)

2010-12-08 Thread Nicolas Pitre
On Wed, 8 Dec 2010, zhangfei gao wrote: On Tue, Dec 7, 2010 at 9:50 PM, Philip Rakity prak...@marvell.com wrote: On Dec 7, 2010, at 5:49 PM, zhangfei gao wrote: 2. we have to fully verify the hardware clk gating internally before sending the code. code tested under marvell 2.6.32

Re: [PATCH V2 1/3] mmc: add support for H/W clock gating of SD controller

2010-12-07 Thread Nicolas Pitre
than that... Acked-by: Nicolas Pitre nicolas.pi...@linaro.org Nicolas -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: working around a Marvell wifi SDIO bug

2010-12-07 Thread Nicolas Pitre
On Tue, 7 Dec 2010, Philip Rakity wrote: On Dec 5, 2010, at 6:15 AM, Ohad Ben-Cohen wrote: That would obviously work but as you and Nicolas mentioned it's an overkill: we don't really need random users to plug into this hook, and using notifiers will just make the code less readable

Re: working around a Marvell wifi SDIO bug

2010-12-04 Thread Nicolas Pitre
On Sat, 4 Dec 2010, Daniel Drake wrote: According to a confidential Marvell AN, we should be asserting RESET externally after powering up the WLAN card. The Linux driver should assert WLAN_RESETn low for between 1 and 20 uS, about 1 mS after turning on power to the card While other users

Re: [PATCH 1/3 ] mmc: add support for h/w clock gating of sd controller

2010-12-03 Thread Nicolas Pitre
On Fri, 3 Dec 2010, Philip Rakity wrote: This code extends software clock gating in the mmc layer by adding the ability to indicate that controller support hardware clock gating. hardware clock gating is enabled by setting the mmc quirk MMC_CAP_CLOCK_GATING_HW in the sd driver. eg:

Re: [PATCH v2 1/1]mmc: check SDIO card wake up during suspending

2010-11-18 Thread Nicolas Pitre
On Thu, 18 Nov 2010, Jun Nie wrote: From 642b2e88fc4b6344290c88ce506fcda1bcc860a3 Mon Sep 17 00:00:00 2001 From: Jun Nie n...@marvell.com Date: Fri, 12 Nov 2010 19:43:49 +0800 Subject: [PATCH] mmc: check SDIO card wake up during suspending It is possible that SDIO card send card interrupt

Re: MMC runtime PM patches break libertas probe

2010-11-17 Thread Nicolas Pitre
On Wed, 17 Nov 2010, Ohad Ben-Cohen wrote: On Wed, Nov 17, 2010 at 8:46 AM, Mike Rapoport m...@compulab.co.il wrote: On our platforms we just keep it powered on after boot with the reset line held high. (e.g. arch/arm/mach-pxa/cm-x300.c, arch/arm/mach-omap/board-cm-t35.c). We don't

Re: [PATCH 2/5] mmc: do not clear the host-pm_flags when suspend

2010-11-11 Thread Nicolas Pitre
On Wed, 10 Nov 2010, Giuseppe CAVALLARO wrote: HC driver will be able to use the pm_flags to undestand if the system can be woken-up by the driver. So the mmc_suspend_host hasn't to reset this field in the host structure. Signed-off-by: Giuseppe Cavallaro peppe.cavall...@st.com ---

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-08 Thread Nicolas Pitre
On Mon, 8 Nov 2010, Linus Walleij wrote: Ohad Ben-Cohen wrote: So the decision whether to enable clock gating for SDIO should not be static (eventually. I'm not saying this is something Linus should take care of in his patch, it's up to us to make this work). By default, SDIO clock

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-08 Thread Nicolas Pitre
On Mon, 8 Nov 2010, Linus Walleij wrote: Philip Rakity wrote: On Nov 8, 2010, at 1:37 AM, Linus Walleij wrote: - Card (including SDIO device) whitelisting. do not understand the term whitelisting .. please explain. The idea would be to have a database with ID:s for cards that may

Re: MMC runtime PM patches break libertas probe

2010-11-07 Thread Nicolas Pitre
On Sun, 7 Nov 2010, Daniel Drake wrote: On 7 November 2010 01:48, Nicolas Pitre n...@fluxnic.net wrote: Couldn't you implement this any other way?  This seems to be a really bad strategy for this IMHO. What's so bad about it? Any suggestions? If you want rfkill functionality, then maybe

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-07 Thread Nicolas Pitre
On Sun, 7 Nov 2010, Philip Rakity wrote: On Nov 6, 2010, at 6:44 PM, Nicolas Pitre wrote: On Sat, 6 Nov 2010, Philip Rakity wrote: We need a way to specify a) Hardware can support clock gating setting the clock to 0 in the call to set_ios (with hardware clock gating enabled

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-06 Thread Nicolas Pitre
On Sat, 6 Nov 2010, Philip Rakity wrote: We need a way to specify a) Hardware can support clock gating setting the clock to 0 in the call to set_ios (with hardware clock gating enabled) becomes a no-op so some care is needed which is why I suggested another field in the ios structure.

Re: MMC runtime PM patches break libertas probe

2010-11-06 Thread Nicolas Pitre
On Sat, 6 Nov 2010, Daniel Drake wrote: On 1 November 2010 08:27, Ohad Ben-Cohen o...@wizery.com wrote: On such boards, the right thing to do would be to disable runtime PM altogether. The patch below (/attached) should trivially fix the problem - can you please check it out ?

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-04 Thread Nicolas Pitre
On Thu, 4 Nov 2010, Linus Walleij wrote: David Vrabel wrote: Linus Walleij wrote: @@ -148,14 +148,19 @@ static int mmc_runtime_suspend(struct device *dev) { struct mmc_card *card = mmc_dev_to_card(dev); + mmc_gate_clock(card-host); return mmc_power_save_host(card-host);

Re: [PATCH 1/2] MMC Agressive clocking framework v7

2010-11-03 Thread Nicolas Pitre
On Wed, 3 Nov 2010, Ohad Ben-Cohen wrote: On Sun, Oct 31, 2010 at 6:06 PM, Linus Walleij linus.wall...@stericsson.com wrote: This patch modifies the MMC core code to optionally call the set_ios() operation on the driver with the clock frequency set to 0 (gate) after a grace period of at

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-28 Thread Nicolas Pitre
On Thu, 28 Oct 2010, Ohad Ben-Cohen wrote: On Thu, Oct 28, 2010 at 5:39 PM, Kishore Kadiyala kishorek.kadiy...@gmail.com wrote: Wouldn't adapting the host driver just to PM-Runtime will answer the above issues? It's not enough. When the card is runtime suspended, sure, the host

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-27 Thread Nicolas Pitre
On Wed, 27 Oct 2010, Alan Cox wrote: 2. Ideally host-driver driver should not tell the core to shut down the upper layers, instead the core should decide when to disabled clock or cut the power. How will the core know ? Are you saying that MMC core needs to be

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-27 Thread Nicolas Pitre
On Wed, 27 Oct 2010, Ghorai, Sukumar wrote: Hi Chris, Linus, Nicolas, Adrian and all, It has been identified after several discussions [1], [2], that MMC/SD/SDIO driver need to re-work on clock and power management. I am trying to list all the design considerations which are part of this

Re: sdhci: mmc: determining card type and dynamic clocks

2010-10-21 Thread Nicolas Pitre
On Thu, 21 Oct 2010, Philip Rakity wrote: On Oct 21, 2010, at 9:57 AM, Nicolas Pitre wrote: I don't like this. Again we should strive to make the controller driver as simple as possible and let the core code handle this kind of clocking logic as much as possible. The OMAP driver

Re: [PATCH] sdio: fix suspend/resume regression

2010-10-21 Thread Nicolas Pitre
On Fri, 22 Oct 2010, Maxim Levitsky wrote: This reintroduces the bug I fixed. if the CONFIG_MMC_UNSAFE_RESUME isn't set (and that is default unfortunately), the host-bus_ops-resume will be NULL (see core/mmc.c mmc_ops), and therefore card will be removed, that will trigger a block device

Re: [PATCH] mmc: Add ignore mmc pm notify functionality

2010-10-14 Thread Nicolas Pitre
On Thu, 14 Oct 2010, Dmitry Shmidt wrote: On Wed, Oct 13, 2010 at 4:10 PM, Nicolas Pitre n...@fluxnic.net wrote: On Wed, 13 Oct 2010, Dmitry Shmidt wrote: On Tue, Oct 12, 2010 at 5:53 PM, Nicolas Pitre n...@fluxnic.net wrote: Yes, but in this case the suspend methods are inappropriate

Re: [PATCH] sdio: fix suspend/resume regression

2010-10-13 Thread Nicolas Pitre
On Wed, 13 Oct 2010, Vitaly Wool wrote: Hi Ohad, On Wed, Oct 13, 2010 at 9:31 AM, Ohad Ben-Cohen o...@wizery.com wrote: diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index c94565d..515ff39 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@

Re: [PATCH] sdio: fix suspend/resume regression

2010-10-13 Thread Nicolas Pitre
-Cohen o...@wizery.com Cc: Maxim Levitsky maximlevit...@gmail.com Cc: sta...@kernel.org Acked-by: Nicolas Pitre n...@fluxnic.net -- It may still be desired to further clean this area up by using the card removal mechanism in mmc_pm_notify() for SDIO as well. To use mmc_pm_notify's card

Re: [PATCH] mmc: Add ignore mmc pm notify functionality

2010-10-12 Thread Nicolas Pitre
On Tue, 12 Oct 2010, Dmitry Shmidt wrote: MMC_PM_KEEP_POWER is mostly related to mmc host controller - keeping or not keeping power on suspend/resume. It is not mostly related, it is _totally_ related and actually its purpose for existing. MMC_PM_WAKE_SDIO_IRQ is not related to anything

Re: [PATCH] mmc: Add ignore mmc pm notify functionality

2010-10-12 Thread Nicolas Pitre
On Tue, 12 Oct 2010, Dmitry Shmidt wrote: On Tue, Oct 12, 2010 at 10:50 AM, Nicolas Pitre n...@fluxnic.net wrote: Imagine your device is keeping connection during suspend. You got packet - wlan will wake application processor through external irq line and linux starts resume. You can

Re: [PATCH] mmc: Add ignore mmc pm notify functionality

2010-10-12 Thread Nicolas Pitre
On Tue, 12 Oct 2010, Dmitry Shmidt wrote: On Tue, Oct 12, 2010 at 11:13 AM, Nicolas Pitre n...@fluxnic.net wrote: On Tue, 12 Oct 2010, Dmitry Shmidt wrote: On Tue, Oct 12, 2010 at 10:50 AM, Nicolas Pitre n...@fluxnic.net wrote: Imagine your device is keeping connection during suspend

Re: [PATCH] mmc: Add ignore mmc pm notify functionality

2010-10-12 Thread Nicolas Pitre
On Tue, 12 Oct 2010, Dmitry Shmidt wrote: On Tue, Oct 12, 2010 at 12:36 PM, Nicolas Pitre n...@fluxnic.net wrote: On Tue, 12 Oct 2010, Dmitry Shmidt wrote: On Tue, Oct 12, 2010 at 11:13 AM, Nicolas Pitre n...@fluxnic.net wrote: On Tue, 12 Oct 2010, Dmitry Shmidt wrote: On Tue, Oct

Re: [PATCH] mmc: Add ignore mmc pm notify functionality

2010-10-12 Thread Nicolas Pitre
On Tue, 12 Oct 2010, Dmitry Shmidt wrote: Please tell us more about the problem you are trying to solve, and in what ways the current infrastructure is not achieving that goal.  Then we might be in a better position to propose suggestions. But selectively ignoring upper suspend requests

Re: [PATCH] mmc: Add ignore mmc pm notify functionality

2010-10-12 Thread Nicolas Pitre
On Tue, 12 Oct 2010, Dmitry Shmidt wrote: On Tue, Oct 12, 2010 at 2:37 PM, Nicolas Pitre n...@fluxnic.net wrote: On Tue, 12 Oct 2010, Dmitry Shmidt wrote: So you want to go to suspend very aggressively. And you want to keep connectivity. And you want to resume quickly - else it is very

Re: [PATCH] mmc: Add ignore mmc pm notify functionality

2010-10-11 Thread Nicolas Pitre
On Mon, 11 Oct 2010, Dmitry Shmidt wrote: Hi, While working with permanent mmc/sdio devices we may want to skip new suspend/resume functionality. Why ?? commit 4c40080bb1d4f68000b7a4c397c1bc8a623668fa Author: Dmitry Shmidt dimitr...@android.com Date: Mon Oct 11 11:28:54 2010

Re: [PATCH] mmc: Add ignore mmc pm notify functionality

2010-10-11 Thread Nicolas Pitre
On Mon, 11 Oct 2010, Dmitry Shmidt wrote: Hi Nicolas, Because for example some sdio device (like wlan) can be powered after suspend (we are not talking about desktop or laptop) and be a source of wakeup. And we don't want to remove it every time we are going to suspend. See

Re: [PATCH] mmc_rescan: reduce verbosity

2010-10-11 Thread Nicolas Pitre
On Mon, 11 Oct 2010, Eric Bénard wrote: since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan includes a pr_info which prints 4 lines each second for hosts configured with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc. This patch increase log level to debug (but maybe the

Re: [PATCH] mmc_rescan: reduce verbosity

2010-10-11 Thread Nicolas Pitre
On Tue, 12 Oct 2010, Chris Ball wrote: Hi, On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote: On Mon, 11 Oct 2010, Eric Bénard wrote: since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan includes a pr_info which prints 4 lines each second for hosts configured

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-30 Thread Nicolas Pitre
On Thu, 30 Sep 2010, Linus Walleij wrote: 2010/9/30 Kyungmin Park kyungmin.p...@samsung.com: So try to find another method and implemente it at SDHCI drivers. Why? The only difference between this solution and the one that is inside the kernel now is that this will use set_ios() with a

Re: my custom SDIO card can be detected in 2.6.30 but not in 2.6.18

2010-09-06 Thread Nicolas Pitre
On Sun, 5 Sep 2010, hong zhang wrote: Because 2.6.14 is the latest in PXA320 package. Please ask Marvell for help then. We do not support their package here. Nicolas -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2] sdio: skip initialization on powered resume

2010-09-02 Thread Nicolas Pitre
On Wed, 1 Sep 2010, Bing Zhao wrote: Quoted Michal Miroslaw's comment: Simplified SDIO spec v.2.00 (section 6.14 - Bus State Diagram) suggests, that initialization commands (CMD5, CMD3) are not accepted in CMD state. As the card stays in that state on powered suspend (no resetting CMD52

RE: [PATCH v2] sdio: skip initialization on powered resume

2010-09-02 Thread Nicolas Pitre
On Thu, 2 Sep 2010, Bing Zhao wrote: Please look at the if() condition, and at the last argument to mmc_sdio_init_card(), then ponder. You are right. The last argument passed to mmc_sdio_init_card() is zero actually. err = mmc_sdio_init_card(host, host-ocr, host-card,

Re: [PATCH] sdio: add MMC_PM_SKIP_RESUME_PROBE to workaround powered resume

2010-08-27 Thread Nicolas Pitre
On Fri, 27 Aug 2010, Chris Ball wrote: Hi, Any comments on this patch from the list? Looks rather hackish to me. There should be a more elegant way to achieve the same result. I have no time to look at it and propose an alternative solution though. From: Bing Zhao bz...@marvell.com

Re: [PATCH] sdio: add MMC_PM_SKIP_RESUME_PROBE to workaround powered resume

2010-08-27 Thread Nicolas Pitre
On Fri, 27 Aug 2010, Nicolas Pitre wrote: On Fri, 27 Aug 2010, Chris Ball wrote: Hi, Any comments on this patch from the list? Looks rather hackish to me. There should be a more elegant way to achieve the same result. I have no time to look at it and propose an alternative

Re: [PATCH 1/2] mmc: USB SD Host Controller (USHC) driver

2010-08-19 Thread Nicolas Pitre
On Thu, 19 Aug 2010, David Vrabel wrote: Add a driver for USB SD Host Controller devices. These devices are Cypress Astoria chips with firmware compliant with issue 2 of CSR's USHC specification. Signed-off-by: David Vrabel david.vra...@csr.com Looks good from a quick glance. Some nits

Re: [PATCH v2 00/20] native support for wl1271 on ZOOM

2010-07-22 Thread Nicolas Pitre
that haven't been covered. E.g., one thing we plan to look at next is their bahvior together with SDIO Suspend/Resume. Special thanks to Roger Quadros and Nicolas Pitre for their extensive review and helpful suggestions. FYI, I do intend to review those patches, but I'll be flying home

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Nicolas Pitre
On Wed, 7 Jul 2010, Roger Quadros wrote: On 07/06/2010 08:42 PM, ext Nicolas Pitre wrote: On Tue, 6 Jul 2010, Roger Quadros wrote: OK, this is how I see it. - Treat the non-removable card as non-removable. So no need to do card detect emulation. - Treat the GPIO power

RE: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Nicolas Pitre
On Wed, 7 Jul 2010, Madhusudhan wrote: -Original Message- From: Nicolas Pitre [mailto:n...@fluxnic.net] Sent: Wednesday, July 07, 2010 9:03 AM To: Roger Quadros Cc: Hunter Adrian (Nokia-MS/Helsinki); Ohad Ben-Cohen; linux- wirel...@vger.kernel.org; linux-mmc

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Nicolas Pitre
On Wed, 7 Jul 2010, Adrian Hunter wrote: Nicolas Pitre wrote: On Wed, 7 Jul 2010, Roger Quadros wrote: On 07/06/2010 10:51 PM, Hunter Adrian (Nokia-MS/Helsinki) wrote: For eMMC in omap_hsmmc, this is all done via claim_host / release_host which call -enable() / -disable() methods

Re: [PATCH] ARM: fix highmem with VIPT cache and DMA

2010-03-26 Thread Nicolas Pitre
On Fri, 26 Mar 2010, Catalin Marinas wrote: On Thu, 2010-03-25 at 21:02 +, Nicolas Pitre wrote: --- a/arch/arm/include/asm/highmem.h +++ b/arch/arm/include/asm/highmem.h @@ -11,7 +11,11 @@ #define kmap_prot PAGE_KERNEL -#define flush_cache_kmaps

Re: Highmem issues with MMC filesystem

2010-03-22 Thread Nicolas Pitre
On Mon, 22 Mar 2010, Russell King - ARM Linux wrote: On Fri, Mar 19, 2010 at 02:51:39PM -0400, Nicolas Pitre wrote: Nicolas Let's get a fresh set of clear bug reports giving all relevant information. Let's not continue to scatter small little bits of information in multiple emails

Re: Highmem issues with MMC filesystem

2010-03-22 Thread Nicolas Pitre
On Mon, 22 Mar 2010, Hemanth V wrote: On Fri, 19 Mar 2010, Nicolas Pitre wrote: A highmem page can have 2 states: virtually mapped in the pkmap area, or not mapped at all. When it is mapped then page_address() returns a valid virtual address for it. In that case the cache

Re: Highmem issues with MMC filesystem

2010-03-19 Thread Nicolas Pitre
On Fri, 19 Mar 2010, Jamie Lokier wrote: Nicolas Pitre wrote: Data read from a DMA based block device is corrupted in memory and causing all sorts of misbehavior such as segmentation faults in user space, or EXT2 complaining about broken filesystem metadata. I doubt it is related

Re: Highmem issues with MMC filesystem

2010-03-19 Thread Nicolas Pitre
On Fri, 19 Mar 2010, Catalin Marinas wrote: On Fri, Mar 19, 2010 at 02:41:17PM +, Catalin Marinas wrote: On Thu, 2010-03-18 at 13:20 +, Nicolas Pitre wrote: The only way a highmem page can be unmapped is through kunmap_atomic() where an explicit __cpuc_flush_dcache_area

Re: Highmem issues with MMC filesystem

2010-03-19 Thread Nicolas Pitre
On Fri, 19 Mar 2010, Nicolas Pitre wrote: On Fri, 19 Mar 2010, Catalin Marinas wrote: On Fri, Mar 19, 2010 at 02:41:17PM +, Catalin Marinas wrote: On Thu, 2010-03-18 at 13:20 +, Nicolas Pitre wrote: The only way a highmem page can be unmapped is through kunmap_atomic

Re: Highmem issues with MMC filesystem

2010-03-19 Thread Nicolas Pitre
On Fri, 19 Mar 2010, Catalin Marinas wrote: On Fri, 2010-03-19 at 17:59 +, Nicolas Pitre wrote: On Fri, 19 Mar 2010, Russell King - ARM Linux wrote: On Fri, Mar 19, 2010 at 09:17:19AM -0400, Nicolas Pitre wrote: And in this case, the same SATA driver is used on two different

Re: Highmem issues with MMC filesystem

2010-03-19 Thread Nicolas Pitre
On Fri, 19 Mar 2010, Nicolas Pitre wrote: A highmem page can have 2 states: virtually mapped in the pkmap area, or not mapped at all. When it is mapped then page_address() returns a valid virtual address for it. In that case the cache for that mapping can be valid, even dirty. So

Re: Highmem issues with MMC filesystem

2010-03-18 Thread Nicolas Pitre
On Thu, 18 Mar 2010, Russell King - ARM Linux wrote: On Thu, Mar 18, 2010 at 07:00:06PM +0530, Shilimkar, Santosh wrote: Or could it be that there is appropriate cacheflush happening but data gets stuck in CPU writebuffers instead of reaching to main memory. In this case too DMA won't see

Re: Highmem issues with MMC filesystem

2010-03-18 Thread Nicolas Pitre
On Thu, 18 Mar 2010, Russell King - ARM Linux wrote: On Thu, Mar 18, 2010 at 12:17:50PM -0400, Nicolas Pitre wrote: On Thu, 18 Mar 2010, Russell King - ARM Linux wrote: What exactly is the problem that we're discussing? Is it that the data on the block device is becoming corrupted

Re: Highmem issues with MMC filesystem

2010-03-17 Thread Nicolas Pitre
On Wed, 17 Mar 2010, Hemanth V wrote: Hi All, We are trying to enable highmem support for OMAP based boards, while doing so we are unable to boot poky UI if the filesystem is in a MMC card. The poky UI comes up fine if the filesystem is in NAND or NFS, while with MMC it gives errors

Re: + sdio-recognize-io-card-without-powercycle.patch added to -mm tree

2010-03-16 Thread Nicolas Pitre
On Tue, 16 Mar 2010, Pierre Ossman wrote: On Fri, 5 Mar 2010 14:39:49 -0800 Andrew Morton a...@linux-foundation.org wrote: I have a note here to check with Pierre, who said : I had problems with cards already in the idle state crashing when I : sent them a reset. I suggest a big

  1   2   >