Re: [PATCH] mmc: mediatek: Preinitialize delay_phase in get_best_delay()

On 6 November 2015 at 12:22, Geert Uytterhoeven wrote: > drivers/mmc/host/mtk-sd.c: In function ‘get_best_delay’: > drivers/mmc/host/mtk-sd.c:1284: warning: ‘delay_phase.start’ is used > uninitialized in this function > drivers/mmc/host/mtk-sd.c:1284: warning:

Re: [RFC PATCH v2] mmc: remove bondage between REQ_META and reliable write

On 6 November 2015 at 16:12, Luca Porzio (lporzio) wrote: > mmc: remove bondage between REQ_META and reliable write > > Anytime a write operation is performed with Reliable Write flag enabled, > the eMMC device is enforced to bypass the cache and do a write to the > underling

Re: [PATCH] mmc: add ifdef around fault_create_debugfs_attr()

On 6 November 2015 at 13:15, Adrien Schildknecht wrote: > FAIL_MMC_REQUEST can be used without FAULT_INJECTION_DEBUG_FS. > In this case fault_create_debugfs_attr() will always return an error and > lead to the deletion of the whole debugfs directory. > > This patch makes

[PATCH] mmc: core: set regulator not found message as debug

Turn the informative message about no vmmc/vqmmc regulator found in debug one. There is no need to indicate that something optional is missing. Moreover, it can bring confusion, people who doesn't know it is optional may consider these messages as warnings or errors. Signed-off-by: Ludovic

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > When there is a vmmc regulator, only SD Bus Power is set to 1 in the > Power Control Register. It means SD Bus Voltage Select field is set to 0 > that is a reserved value. The SD Host Controller specification says: > 'SD Bus

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On 9 November 2015 at 14:23, Ludovic Desroches wrote: > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: >> When there is a vmmc regulator, only SD Bus Power is set to 1 in the >> Power Control Register. It means SD Bus Voltage Select field is set to

Re: [PATCH 0/4] mmc: mmc: Improve reliability of HS200/HS400 selection

On 6 November 2015 at 13:55, Adrian Hunter wrote: > On 06/11/15 13:03, Ulf Hansson wrote: >> On 28 October 2015 at 13:25, Adrian Hunter wrote: >>> Hi >>> >>> Here are some patches that improve the reliability of selecting >>> eMMC HS200 or HS400

Re: [PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA

On 9 November 2015 at 10:36, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: dma_unmap_sg [drivers/mmc/host/android-goldfish.ko] undefined! > ERROR: dma_alloc_coherent [drivers/mmc/host/android-goldfish.ko] > undefined! > ERROR: dma_map_sg

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 14:23, Ludovic Desroches > wrote: > > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > >> When there is a vmmc regulator, only SD Bus Power is set to 1 in the > >>

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: > [...] > > >> > >> This doesn't seems like a case where a gpio regulator should be used > >> and I am not sure what problem it would solve. Beside to suppress the > >> log warnings (actually those aren't warnings but informations). >

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

On 9 November 2015 at 14:14, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: >> [...] >> >> >> >> >> This doesn't seems like a case where a gpio regulator should be used >> >> and I am not sure what problem it would solve.

Re: [PATCH 1/8] block/genhd.c: Add error handling

On 11/09/2015 08:33 PM, Al Viro wrote: On Fri, Nov 06, 2015 at 05:52:08PM +0530, Vishnu Pratap Singh wrote: Have you even tried to trigger the failure exits you've added? The more you've successfully set up, the _less_ your cleanup code ends up undoing; that simply can't be right. That aside,

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

On 11/06/2015 03:42 AM, Bjorn Andersson wrote: > On Mon, Jul 6, 2015 at 4:53 AM, Ivan T. Ivanov wrote: >> Ensure SDCC is working with maximum clock otherwise card >> detection could be extremely slow, up to 7 seconds. >> >> Signed-off-by: Ivan T. Ivanov

Re: [PATCH 1/4] mmc: Add quirk to disable SDR50 mode

On 15-11-09 02:45 AM, Ulf Hansson wrote: On 7 November 2015 at 00:55, Scott Branden wrote: Hi Ulf, On 15-11-06 12:14 AM, Ulf Hansson wrote: On 5 November 2015 at 23:39, Al Cooper wrote: Add quirk to disable SDR50 mode for controllers/boards

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 15:40, Ludovic Desroches > wrote: > > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > >> On 9 November 2015 at 14:23, Ludovic Desroches > >>

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On 9 November 2015 at 15:40, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: >> On 9 November 2015 at 14:23, Ludovic Desroches >> wrote: >> > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic

Re: [PATCH 12/13] [media] omap3isp: Support for deferred probing when requesting DMA channel

Hi Peter, Thank you for the patch. What happened to this patch series ? It looks like dma_request_slave_channel_compat_reason() isn't in mainline, so I can't apply this patch. I'll mark this patch as deferred in patchwork, please resubmit it if you resubmit the series (and by the look of it

Re: [PATCH 12/13] [media] omap3isp: Support for deferred probing when requesting DMA channel

Hi Laurent, On 11/09/2015 09:50 PM, Laurent Pinchart wrote: > Hi Peter, > > Thank you for the patch. > > What happened to this patch series ? It looks like > dma_request_slave_channel_compat_reason() isn't in mainline, so I can't apply > this patch. > > I'll mark this patch as deferred in

Re: [PATCH 1/8] block/genhd.c: Add error handling

On Fri, Nov 06, 2015 at 05:52:08PM +0530, Vishnu Pratap Singh wrote: Have you even tried to trigger the failure exits you've added? The more you've successfully set up, the _less_ your cleanup code ends up undoing; that simply can't be right. That aside, as soon as we'd done register_disk(),

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

[...] >> >> This doesn't seems like a case where a gpio regulator should be used >> and I am not sure what problem it would solve. Beside to suppress the >> log warnings (actually those aren't warnings but informations). >> >> Isn't sdhci_do_start_signal_voltage_switch() doing what you need here?

[PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA

If NO_DMA=y: ERROR: dma_unmap_sg [drivers/mmc/host/android-goldfish.ko] undefined! ERROR: dma_alloc_coherent [drivers/mmc/host/android-goldfish.ko] undefined! ERROR: dma_map_sg [drivers/mmc/host/android-goldfish.ko] undefined! ERROR: dma_free_coherent

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

On 7 November 2015 at 00:39, Bjorn Andersson wrote: > On Fri 06 Nov 00:10 PST 2015, Ulf Hansson wrote: > >> On 6 November 2015 at 02:42, Bjorn Andersson wrote: >> > On Mon, Jul 6, 2015 at 4:53 AM, Ivan T. Ivanov >> > wrote:

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

On Mon, Nov 09, 2015 at 10:38:03AM +0100, Ulf Hansson wrote: > [...] > > >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case > >> > it is > >> > not really driven by a gpio but by a pio from the sdhci device. In the > >> > binding, > >> > >> What's a "pio"? > >> > >>

Re: [PATCH 1/4] mmc: Add quirk to disable SDR50 mode

On 7 November 2015 at 00:55, Scott Branden wrote: > Hi Ulf, > > On 15-11-06 12:14 AM, Ulf Hansson wrote: >> >> On 5 November 2015 at 23:39, Al Cooper wrote: >>> >>> Add quirk to disable SDR50 mode for controllers/boards that have >>> problems with this

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

[...] >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case it >> > is >> > not really driven by a gpio but by a pio from the sdhci device. In the >> > binding, >> >> What's a "pio"? >> >> What do you mean by the it's driven from the sdhci device? >> > > Sorry I mean