Re: [PATCH] mmc: add ifdef around fault_create_debugfs_attr()

2015-11-10 Thread Adrien Schildknecht
On Mon, 9 Nov 2015 14:33:11 +0100 Ulf Hansson wrote: > On 6 November 2015 at 13:15, Adrien Schildknecht > wrote: > > FAIL_MMC_REQUEST can be used without FAULT_INJECTION_DEBUG_FS. > > In this case fault_create_debugfs_attr() will always return an

[PATCH v2] mmc: kconfig: replace FAULT_INJECTION with FAULT_INJECTION_DEBUG_FS

2015-11-10 Thread Adrien Schildknecht
Fault-injection capability for MMC IO uses debugfs entries to configure the attributes. FAULT_INJECTION_DEBUG_FS must be enabled to use FAIL_MMC_REQUEST. Replace FAULT_INJECTION with FAULT_INJECTION_DEBUG_FS. Also remove 'select DEBUG_FS' since FAULT_INJECTION_DEBUG_FS depends on it.

Re: [PATCH] mmc: add ifdef around fault_create_debugfs_attr()

2015-11-10 Thread Ulf Hansson
On 10 November 2015 at 16:04, Adrien Schildknecht wrote: > On Mon, 9 Nov 2015 14:33:11 +0100 > Ulf Hansson wrote: >> On 6 November 2015 at 13:15, Adrien Schildknecht >> wrote: >> > FAIL_MMC_REQUEST can be used without

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

2015-11-10 Thread Stephen Boyd
On 11/09, Ulf Hansson wrote: > On 7 November 2015 at 00:39, Bjorn Andersson > wrote: > > On Fri 06 Nov 00:10 PST 2015, Ulf Hansson wrote: > > > >> On 6 November 2015 at 02:42, Bjorn Andersson wrote: > >> > On Mon, Jul 6, 2015 at 4:53 AM, Ivan T.

[PATCH v2] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches --- Changes: - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 66 +++- 1 file changed,

[PATCH 1/2] mmc: sdhci-esdhc-imx: move the setting of watermark level out of probe

2015-11-10 Thread Haibo Chen
Currently, we config the watermark_level register only in probe. This will cause the mmc write operation timeout issue after system resume back in LPSR mode. Because in LPSR mode, after system resume back, the watermark_level register(0x44) changes to 0x08000880, which set the write watermark

[PATCH 2/2] mmc: sdhci-esdhc-imx: correct the tuning-step setting

2015-11-10 Thread Haibo Chen
Here we use '|=' to set the tuning-step, but before that, we should clear the tuning-step, otherwise we could got the wrong setting. Signed-off-by: Haibo Chen --- drivers/mmc/host/sdhci-esdhc-imx.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

Re: [PATCH v2] mmc: sdhci at91: add PM support

2015-11-10 Thread Ulf Hansson
On 10 November 2015 at 11:36, Ludovic Desroches wrote: > Add runtime PM support and use runtime_force_suspend|resume() for system > PM. > > Signed-off-by: Ludovic Desroches > --- > > Changes: > - from v1: take a runtime PM centric

Re: [PATCH v3] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
On Tue, Nov 10, 2015 at 03:03:57PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 14:23, Ludovic Desroches > wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-by: Ludovic Desroches

Re: [PATCH v3] mmc: sdhci at91: add PM support

2015-11-10 Thread Ulf Hansson
On 10 November 2015 at 14:23, Ludovic Desroches wrote: > Add runtime PM support and use runtime_force_suspend|resume() for system > PM. > > Signed-off-by: Ludovic Desroches > --- > > Changes: > - from v2: cleanup thanks to Ulf feedback >

Re: [PATCH 1/8] block/genhd.c: Add error handling

2015-11-10 Thread Jeff Moyer
Jens Axboe writes: > On 11/09/2015 08:33 PM, Al Viro wrote: >> On Fri, Nov 06, 2015 at 05:52:08PM +0530, Vishnu Pratap Singh wrote: >> >> Have you even tried to trigger the failure exits you've added? The >> more you've successfully set up, the _less_ your cleanup code ends >>

Re: [PATCH v2] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-by: Ludovic Desroches

[PATCH v3] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches --- Changes: - from v2: cleanup thanks to Ulf feedback - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 67

[PATCH] mmc: change to use kmalloc

2015-11-10 Thread yalin wang
Use kmalloc instead of kzalloc, zero the memory is not needed. Signed-off-by: yalin wang --- drivers/mmc/card/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 23b6c8e..975cd3e 100644