Increase the build testing coverage.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index a565254..1325cae 100644
--- a/drivers/mmc/host
The DT binding example in the documentation is missing the -supply
suffix for the vmmc and vqmmc regulators. Fix it.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
.../devicetree/bindings/mmc/sdhci-msm.txt |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
This patchset contains fixes in the documentation, cleanups
and enables COMPILE_TEST for better testing coverage.
Georgi Djakov (3):
mmc: sdhci-msm: Fix the binding example
mmc: sdhci-msm: Remove unnecessary header file inclusion
mmc: sdhci-msm: Get COMPILE_TEST support
.../devicetree
The header linux/regulator/consumer.h is unused. Remove it.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/sdhci-msm.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 40573a5..1a6661e 100644
for eMMC on apq8074-dragonboard and ifc6540 boards, so:
Tested-by: Georgi Djakov gdja...@mm-sol.com
Acked-by: Georgi Djakov gdja...@mm-sol.com
Thanks,
Georgi
Changes in v2:
Rebased, to get latest version of the mmc_send_tuning() API.
---
drivers/mmc/host/sdhci-msm.c | 50
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
Changes from v1:
- GPIO references are replaced by pinctrl
- DT parsing is done mostly by mmc_of_parse()
- Use of_match_device() for DT matching
- A few minor changes
.../devicetree/bindings/mmc/sdhci-msm.txt | 62 ++
drivers/mmc/host
large timeout values for R1B commands.
Patches are based on v3.11-rc5.
Georgi Djakov (5):
mmc: sdhci: add quirk for R/W Transfer Active EOT
mmc: sdhci: add quirk for slow interrupt clearance
mmc: sdhci: add quirk to ignore CMD CRC err for tuning commands
mmc: sdhci: add quirk for max_discard
: Sahitya Tummala stumm...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/sdhci.c | 20
include/linux/mmc/sdhci.h |2 ++
2 files changed, 22 insertions(+)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index d3c9e59
This patch adds a quirk to ignore data timeout error for R1B commands
as there will be no data associated and the busy timeout value for these
commands could be larger than the maximum timeout value that controller
can handle.
CC: Sahitya Tummala stumm...@codeaurora.org
Signed-off-by: Georgi
kind of operations are very slow.
Add quirk so that the SDHCI host can use the default max_discard value.
CC: Krishna Konda kko...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/sdhci.c |3 ++-
include/linux/mmc/sdhci.h |4
2 files changed, 6
when operating at
initialization frequency(400KHz).
CC: Venkat Gopalakrishnan venk...@codeaurora.org
CC: Asutosh Das asuto...@codeaurora.org
CC: Sahitya Tummala stumm...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/sdhci.c |6 ++
include/linux/mmc
in Software Reset
Register (Bit 2).
CC: Venkat Gopalakrishnan venk...@codeaurora.org
CC: Asutosh Das asuto...@codeaurora.org
CC: Sahitya Tummala stumm...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/sdhci.c |3 +++
include/linux/mmc/sdhci.h |2 ++
2
Hi Ivan,
On 08/15/2013 10:22 AM, Ivan T. Ivanov wrote:
Hi Georgi,
I have several comments below.
snip
Shouldn't we add required clocks here? It looks that some of them
are optional and others mandatory.
Yes, there are various clocks for MMC, SD/SDIO and at least 400mhz must
be
this
function.
Is there a special reason that use the vreg-is_enabled?
Best Regards,
Jaehoon Chung
On 08/13/2013 11:06 PM, Georgi Djakov wrote:
This platform driver adds the support of Secure Digital Host
Controller Interface compliant controller in MSM chipsets.
CC: Asutosh Das asuto
Hi Jaehoon,
On 08/27/2013 11:55 AM, Jaehoon Chung wrote:
Hi Georgi,
I found the sdhci_msm_vreg_reset(). Why do you run enable-disable?
+/*
+ * Reset vreg by ensuring it is off during probe. A call
+ * to enable vreg is needed to balance disable vreg
+ */
+static int
Hi Ivan,
On 08/23/2013 10:34 AM, Ivan T. Ivanov wrote:
Hi Georgi,
On Tue, 2013-08-20 at 19:44 +0300, Georgi Djakov wrote:
This platform driver adds the support of Secure Digital Host
Controller Interface compliant controller in MSM chipsets.
CC: Asutosh Das asuto...@codeaurora.org
CC: Venkat
...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
Changes from v3:
- Allocate memory for all required structs at once
- Added termination entry in sdhci_msm_dt_match[]
- Fixed a missing sdhci_pltfm_free() in probe()
- Removed redundant of_match_ptr
- Removed the unneeded function
...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
Changes from v4:
- Simplified sdhci_msm_vreg_disable() and sdhci_msm_set_vdd_io_vol()
- Use devm_ioremap_resource() instead of devm_ioremap()
- Converted IS_ERR_OR_NULL to IS_ERR
- Disable regulators in sdhci_msm_remove()
- Check
Hi Stan,
Thank you for the detailed review on this patch.
On 09/17/2013 05:55 PM, Stanimir Varbanov wrote:
Hi Georgi,
Thanks for the patch.
I have some commnets below.
On 09/16/2013 05:23 PM, Georgi Djakov wrote:
This platform driver adds the support of Secure Digital Host Controller
This patch adds documentation for Qualcomm SDHCI MSM driver.
It contains the differences between the core properties in mmc.txt and
the properties used by the sdhci-msm driver.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
.../devicetree/bindings/mmc/sdhci-msm.txt | 70
subha...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/Kconfig | 13 +
drivers/mmc/host/Makefile|1 +
drivers/mmc/host/sdhci-msm.c | 644 ++
3 files changed, 658 insertions(+)
create mode 100644 drivers
part in order to use
the power on defaults for regulators and maybe also clocks.
On Fri, Sep 27, 2013 at 9:57 AM, Georgi Djakov gdja...@mm-sol.com wrote:
...
+static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data)
+{
+ struct sdhci_msm_host *msm_host = (struct sdhci_msm_host *)data
- Removed redundant _clk suffix from clock names
- Just return instead of goto where possible
- Minor fixes
Changes from v1:
- GPIO references are replaced by pinctrl
- DT parsing is done mostly by mmc_of_parse()
- Use of_match_device() for DT matching
- A few minor changes
Georgi Djakov (2):
mmc
This platform driver adds the initial support of Secure
Digital Host Controller Interface compliant controller
found in Qualcomm MSM chipsets.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/Kconfig | 13 +
drivers/mmc/host/Makefile|1 +
drivers/mmc/host/sdhci
On 12/05/2013 11:52 AM, Mark Rutland wrote:
Hi,
Apologies for the late reply.
Hi Mark, thanks for the review!
On Wed, Nov 06, 2013 at 03:56:44PM +, Georgi Djakov wrote:
This patch adds documentation for Qualcomm SDHCI MSM driver.
It contains the differences between the core properties
On 12/05/2013 12:27 PM, Mark Rutland wrote:
On Wed, Nov 06, 2013 at 03:56:45PM +, Georgi Djakov wrote:
This platform driver adds the initial support of Secure
Digital Host Controller Interface compliant controller
found in Qualcomm MSM chipsets.
Signed-off-by: Georgi Djakov gdja...@mm
Hi,
Apologies for the delayed reply.
On 12/09/2013 11:38 AM, Mark Rutland wrote:
On Fri, Dec 06, 2013 at 11:59:46AM +, Georgi Djakov wrote:
On 12/05/2013 11:52 AM, Mark Rutland wrote:
[...]
+
+- qcom,{vdd,vdd-io}-lpm-sup - specifies whether the supply can be kept in low
power mode
On 12/09/2013 11:46 AM, Mark Rutland wrote:
[...]
+ /*
+* CORE_SW_RST above may trigger power irq if previous status of PWRCTL
+* was either BUS_ON or IO_HIGH_V. So before we enable the power irq
+* interrupt in GIC (by registering the interrupt handler), we need
Hi,
Apologies for the delayed reply.
On 12/09/2013 07:00 PM, Courtney Cavin wrote:
On Wed, Nov 06, 2013 at 04:56:45PM +0100, Georgi Djakov wrote:
This platform driver adds the initial support of Secure
Digital Host Controller Interface compliant controller
found in Qualcomm MSM chipsets
redundant _clk suffix from clock names
- Just return instead of goto where possible
- Minor fixes
Georgi Djakov (3):
mmc: sdhci-msm: Qualcomm SDHCI binding documentation
mmc: sdhci-msm: Initial support for Qualcomm chipsets
mmc: sdhci-msm: Add platform_execute_tunning implementation
This patch adds implementation for platform specific tuning in order to support
HS200 bus speed mode on Qualcomm SDHCI controller.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/sdhci-msm.c | 417 +-
1 file changed, 412 insertions
This platform driver adds the initial support of Secure
Digital Host Controller Interface compliant controller
found in Qualcomm chipsets.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/Kconfig | 13 ++
drivers/mmc/host/Makefile|1 +
drivers/mmc/host/sdhci
This patch adds the device-tree binding documentation for
Qualcomm SDHCI driver. It contains the differences between
the core properties in mmc.txt and the properties used by
the sdhci-msm driver.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
.../devicetree/bindings/mmc/sdhci-msm.txt
Hi Christopher,
On 02/04/2014 03:19 PM, Christopher Covington wrote:
Hi Georgi,
On 01/30/2014 01:45 PM, Georgi Djakov wrote:
This patchset adds basic support of the Secure Digital Host Controller
Interface compliant controller found in Qualcomm chipsets.
Tested with eMMC and various micro SD
Hi Stephen,
On 02/08/2014 05:23 AM, Stephen Boyd wrote:
On 01/30, Georgi Djakov wrote:
@@ -75,17 +110,389 @@ struct sdhci_msm_host {
};
/* MSM platform specific tuning */
-int sdhci_msm_execute_tuning(struct sdhci_host *host, u32 opcode)
+static inline int msm_dll_poll_ck_out_en(struct
This patch adds implementation for platform specific tuning in order to support
HS200 bus speed mode on Qualcomm SDHCI controller.
Signed-off-by: Asutosh Das asuto...@codeaurora.org
Signed-off-by: Venkat Gopalakrishnan venk...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
This patch adds the device-tree binding documentation for
Qualcomm SDHCI driver. It contains the differences between
the core properties in mmc.txt and the properties used by
the sdhci-msm driver.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
.../devicetree/bindings/mmc/sdhci-msm.txt
data
- Removed unneeded includes
- Removed obsolete and wrapper functions
- Removed error checking where unnecessary
- Removed redundant _clk suffix from clock names
- Just return instead of goto where possible
- Minor fixes
Georgi Djakov (3):
mmc: sdhci-msm: Qualcomm SDHCI binding documentation
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/Kconfig | 13 ++
drivers/mmc/host/Makefile|1 +
drivers/mmc/host/sdhci-msm.c | 528 ++
3 files changed, 542 insertions(+)
create mode 100644 drivers/mmc/host/sdhci-msm.c
diff
On 28.02.14, 18:51, Kumar Gala wrote:
On Feb 28, 2014, at 5:24 AM, Georgi Djakov gdja...@mm-sol.com wrote:
This patch adds implementation for platform specific tuning in order to
support
HS200 bus speed mode on Qualcomm SDHCI controller.
Signed-off-by: Asutosh Das asuto
On 28.02.14, 22:51, Josh Cartwright wrote:
[..]
+sg_init_one(sg, data_buf, sizeof(data_buf));
+memset(data_buf, 0, sizeof(data_buf));
+mmc_wait_for_req(mmc, mrq);
+
+if (!cmd.error !data.error
+!memcmp(data_buf,
On 03/04/2014 05:15 AM, Bjorn Andersson wrote:
On Fri, Feb 28, 2014 at 3:24 AM, Georgi Djakov gdja...@mm-sol.com wrote:
This platform driver adds the initial support of Secure
Digital Host Controller Interface compliant controller
found in Qualcomm chipsets.
Hi Georgi,
Sorry for reposting
This patch adds implementation for platform specific tuning in order to support
HS200 bus speed mode on Qualcomm SDHCI controller.
Signed-off-by: Asutosh Das asuto...@codeaurora.org
Signed-off-by: Venkat Gopalakrishnan venk...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/Kconfig | 13 ++
drivers/mmc/host/Makefile|1 +
drivers/mmc/host/sdhci-msm.c | 427 ++
3 files changed, 441 insertions(+)
create mode 100644 drivers/mmc/host/sdhci-msm.c
diff
This patch adds the device-tree binding documentation for
Qualcomm SDHCI driver. It contains the differences between
the core properties in mmc.txt and the properties used by
the sdhci-msm driver.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
.../devicetree/bindings/mmc/sdhci-msm.txt
for clocks
- Moved voltage regulators data to platform data
- Removed unneeded includes
- Removed obsolete and wrapper functions
- Removed error checking where unnecessary
- Removed redundant _clk suffix from clock names
- Just return instead of goto where possible
- Minor fixes
Georgi Djakov (3
On 03/05/2014 06:25 AM, Ulf Hansson wrote:
On 4 March 2014 20:27, Georgi Djakov gdja...@mm-sol.com wrote:
[..]
+Required properties:
+- compatible: Should contain qcom,sdhci-msm-v4.
+- reg: Base address and length of the register set listed in reg-names.
+- reg-names: Should contain
On 03/05/2014 06:41 AM, Ulf Hansson wrote:
On 4 March 2014 20:27, Georgi Djakov gdja...@mm-sol.com wrote:
[..]
+
+struct sdhci_msm_pltfm_data {
+ u32 caps; /* Supported UHS-I Modes */
+ u32 caps2; /* More capabilities
On 03/05/2014 08:56 AM, Rob Herring wrote:
On Tue, Mar 4, 2014 at 1:27 PM, Georgi Djakov gdja...@mm-sol.com wrote:
[..]
+Required properties:
+- compatible: Should contain qcom,sdhci-msm-v4.
+- reg: Base address and length of the register set listed in reg-names.
+- reg-names: Should contain
Georgi Djakov (3):
mmc: sdhci-msm: Qualcomm SDHCI binding documentation
mmc: sdhci-msm: Initial support for Qualcomm chipsets
mmc: sdhci-msm: Add platform_execute_tuning implementation
.../devicetree/bindings/mmc/sdhci-msm.txt | 55 ++
drivers/mmc/host/Kconfig
This patch adds the device-tree binding documentation for
Qualcomm SDHCI driver. It contains the differences between
the core properties in mmc.txt and the properties used by
the sdhci-msm driver.
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
.../devicetree/bindings/mmc/sdhci-msm.txt
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
---
drivers/mmc/host/Kconfig | 13 +++
drivers/mmc/host/Makefile|1 +
drivers/mmc/host/sdhci-msm.c | 208 ++
3 files changed, 222 insertions(+)
create mode 100644 drivers/mmc/host/sdhci-msm.c
diff
This patch adds implementation for platform specific tuning in order to support
HS200 bus speed mode on Qualcomm SDHCI controller.
Signed-off-by: Asutosh Das asuto...@codeaurora.org
Signed-off-by: Venkat Gopalakrishnan venk...@codeaurora.org
Signed-off-by: Georgi Djakov gdja...@mm-sol.com
On 03/07/2014 04:18 PM, Mike Looijmans wrote:
If vmmc or vqmmc regulators are controlled by an I2C device, the
request for the regulator is likely to fail because the I2C bus has
not been probed yet. The sdhci then incorrectly assumes that the user
never wanted to use a regulator anyway and
Hello Chris, Ulf,
Do you have any comments on the patches?
The arch code that will use this driver is already in mainline. The
regulators support seem to be still on its way, but this driver also
works fine with dummy regulators.
Thanks,
Georgi
On 03/10/2014 05:37 PM, Georgi Djakov wrote
On 27.03.14, 19:47, Mike Looijmans wrote:
On 26-3-2014 16:09, Georgi Djakov wrote:
On 03/07/2014 04:18 PM, Mike Looijmans wrote:
If vmmc or vqmmc regulators are controlled by an I2C device, the
request for the regulator is likely to fail because the I2C bus has
not been probed yet. The sdhci
On 07/31/2013 03:19 AM, Bjorn Andersson wrote:
On Tue, Jul 30, 2013 at 8:22 AM, Georgi Djakov gdja...@mm-sol.com wrote:
This platform driver adds the support of Secure Digital Host
Controller Interface compliant controller in MSM chipsets.
[snip]
+
+ sdhc_1: qcom,sdhc@f9824900
Some versions of this controller do not advertise their 3.0v and
8bit bus-width support capabilities. It is required to explicitly
set these capabilities for the specific controller versions.
Signed-off-by: Georgi Djakov georgi.dja...@linaro.org
---
Tested on msm8916-mtp board.
drivers/mmc/host
Some versions of this controller do not advertise their 3.0v and
8bit bus-width support capabilities. It is required to explicitly
set these capabilities for the specific controller versions.
Signed-off-by: Georgi Djakov georgi.dja...@linaro.org
---
Changes since v1:
* Converted to separate read
Hi Bjorn,
Thanks for taking a look.
On 03/19/2015 05:36 PM, Bjorn Andersson wrote:
On Thu, Mar 19, 2015 at 5:55 AM, Georgi Djakov georgi.dja...@linaro.org
wrote:
[..]
@@ -516,6 +527,22 @@ static int sdhci_msm_probe(struct platform_device *pdev)
host_version, ((host_version
Some versions of this controller do not advertise their 3.0v and
8bit bus-width support capabilities. It is required to explicitly
set these capabilities for the specific controller versions.
Signed-off-by: Georgi Djakov georgi.dja...@linaro.org
---
Changes since v2:
* Use the generic sdhci
On 06/26/2015 02:16 PM, Ivan T. Ivanov wrote:
Ensure SDCC is working with maximum clock otherwise card
detection could be extremely slow, up to 7 seconds.
Signed-off-by: Ivan T. Ivanov ivan.iva...@linaro.org
---
drivers/mmc/host/sdhci-msm.c | 5 +
1 file changed, 5 insertions(+)
-off-by: Ivan T. Ivanov <ivan.iva...@linaro.org>
>> Reviewed-by: Georgi Djakov <georgi.dja...@linaro.org>
>> Acked-by: Stephen Boyd <sb...@codeaurora.org>
>> ---
>>
>> Changes since v0:
>> - s/falied/failed in warning message.
>>
>> driver
63 matches
Mail list logo
