This patch is change to use the sdhci-pltfm.c
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/host/sdhci-s3c.c | 218 ++
1 files changed, 71 insertions(+), 147 deletions(-)
diff
part.
In future, i will work more removing the arch dependency.
This patchset based on mmc-next tree.
Jaehoon Chung (4):
mmc: sdhci-s3c: use the sdhci-pltfm for Samsung-SoC
ARM: SAMSUNG: move the header file to driver directory
mmc: sdhci-s3c: use the sdhci-s3c.h instead of regs-sdhci.h
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin-park kyungmin.p...@samsung.com
---
arch/arm/plat-samsung/include/plat/sdhci.h | 59 +---
include/linux/mmc/sdhci-s3c.h | 84
2 files changed, 85 insertions
EXT_CSD from /dev/mmcblk1
What differ? Anyway..It's great about mmc-utils.
Best Regards,
Jaehoon Chung
Were you doing something to get the card back into idle state first,
perhaps?
Giuseppe, it would be excellent if you could add your ext_csd parsing
code to the extcsd read command
On 02/14/2012 05:07 PM, Johan RUDHOLM wrote:
Jaehoon Chung wrote:
On 02/13/2012 02:03 AM, Chris Ball wrote:
Hi,
I've created a repository for userspace mmc tools now:
git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git
At the moment the only commands supported are Johan
In CLKENA register, can support 16-SD card clocks.
If support correctly, must shift with slot-id.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/host/dw_mmc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions
On 02/14/2012 08:41 PM, Saugata Das wrote:
On 20 January 2012 12:18, Jaehoon Chung jh80.ch...@samsung.com wrote:
Enable eMMC background operations (BKOPS) feature.
If URGENT_BKOPS is set after a response, note that BKOPS
are required. After all I/O requests are finished, run
BKOPS
-ssr.au = 1 (au + 4) is something wrong.
If au is 1, card-ssr.au is 32KB. BUt in spec, defined 16KB.
I think the wrong bit operation. this is more problem.
If my point is right, will send the patch.
Best Regards,
Jaehoon Chung
es = UNSTUFF_BITS(ssr, 408 - 384, 16);
et
In SD spec, AU_SIZE and the value can be selected from 16KB.
But this code should be selected from 32KB.
I think right that shift (au + 3) instead of (au + 4).
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
CC: Hyeonsu Kim hyeonsu
On 02/21/2012 02:43 AM, Chris Ball wrote:
Hi Giuseppe,
On Mon, Feb 20 2012, Giuseppe CAVALLARO wrote:
This patch enhances the debug information reported
for the mmc card by parsing the extended CSD registers
obviously according to all the current specifications.
Thanks, this is great!
On 02/21/2012 11:00 PM, Yaniv Gardi wrote:
Signed-off-by: Yaniv Gardi yga...@codeaurora.org
---
drivers/mmc/card/block.c | 58 ++---
drivers/mmc/card/queue.c | 12 -
include/linux/mmc/card.h |7 +
include/linux/mmc/host.h |1
Hi Konstantin
I didn't see the level-3, but have seen the level-2.
URGENT_BKOPS should be triggered when the levels is either 2 or 3.
So maybe you can see the URGENT_BKOPS with level-2.
Best Regards,
Jaehoon Chung
On 02/21/2012 11:21 PM, Jae hoon Chung wrote:
2012/2/21 Konstantin Dorfman
. And in mmc-next tree, latest your patch is
merged.
(using device-tree). So i rework this patch.
Right. this is the todo list. And need more discussion.
Main goal is to use the sdhci-pltfm.
There are few comments below.
On 14 February 2012 10:33, Jaehoon Chung jh80.ch...@samsung.com wrote:
This patch
On 02/24/2012 06:48 PM, Thomas Abraham wrote:
Dear Mr. Chung,
On 14 February 2012 10:33, Jaehoon Chung jh80.ch...@samsung.com wrote:
The header-file is moved to drivers/mmc/host from plat.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
On 02/24/2012 06:10 PM, Thomas Abraham wrote:
Dear Mr. Chung,
On 14 February 2012 10:33, Jaehoon Chung jh80.ch...@samsung.com wrote:
The header-file is moved to drivers/mmc/host from plat.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
On 02/24/2012 07:36 PM, Thomas Abraham wrote:
On 24 February 2012 16:00, Jaehoon Chung jh80.ch...@samsung.com wrote:
On 02/24/2012 06:10 PM, Thomas Abraham wrote:
Dear Mr. Chung,
On 14 February 2012 10:33, Jaehoon Chung jh80.ch...@samsung.com wrote:
The header-file is moved to drivers/mmc
On 02/26/2012 06:37 PM, Yaniv Gardi wrote:
= -Original Message-
= From: Jaehoon Chung [mailto:jh80.ch...@samsung.com]
= Sent: Wednesday, February 22, 2012 8:09 AM
= To: Yaniv Gardi
= Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org;
= ax...@kernel.dk; open list
(eMMC) didn't initialize?
i think good that use the rootwait at bootloader
Best Regards,
Jaehoon Chung
[1.79] Unable to handle kernel NULL pointer dereference at virtual
address 0004
[1.79] pgd = c0004000
[1.79] [0004] *pgd=
[1.79] Internal
On 02/27/2012 11:20 AM, Daniel Palmer wrote:
On Monday, February 27, 2012 10:48:48 AM Jaehoon Chung wrote:
[1.70] atmel_mci atmel_mci.1: version: 0x410
[1.71] atmel_mci atmel_mci.1: using DMA
[1.71] atmel_mci atmel_mci.1: DMA not available, using PIO
[1.73
part.
In future, i will work more removing the arch dependency.
This patchset based on mmc-next tree.
Changlog V2:
- modified driver/mmc/host/Kconfig
- Add the comments for s3c64xx
- based-on latest mmc-tree.
Jaehoon Chung (4):
mmc: sdhci-s3c: use the sdhci-pltfm
The header-file is moved to drivers/mmc/host from plat.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/mach-exynos/setup-sdhci-gpio.c |1 -
arch/arm/mach-s5pc100/setup-sdhci-gpio.c|1 -
arch/arm/mach
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/plat-samsung/include/plat/sdhci.h | 53 +-
include/linux/mmc/sdhci-s3c.h | 84
2 files changed, 85 insertions
Using the sdhci-s3c.h
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/host/sdhci-s3c.c | 12 +---
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host
This patch is change to use the sdhci-pltfm.c
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/host/Kconfig | 20 ++--
drivers/mmc/host/sdhci-s3c.c | 254 ++
2 files changed
is 2.10a
Hi Dongjin.
It seems like this problem. Can you check this patch?
http://www.spinics.net/lists/linux-mmc/msg09895.html
Best Regards,
Jaehoon Chung
Cheers,
Dongjin.
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 2f7f5ee..05ccee8 100644
--- a/drivers/mmc/host
Hi Dongjin.
This patch is corrupt due to line-wrapping.
Best Regards,
Jaehoon Chung
On 02/28/2012 04:31 PM, Dongjin Kim wrote:
Jaehoon Chung jh80.chung at samsung.com writes:
On 02/28/2012 02:32 PM, Dongjin Kim wrote:
Hello,
I encountered the problem that my hardware is frozen while
On 02/29/2012 03:33 PM, Seungwon Jeon wrote:
Hi Jaehoon,
Thank you for the patch.
Could you check comments below?
Jaehoon Chung jh80.ch...@samsung.com wrote:
This patch is change to use the sdhci-pltfm.c
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park
On 03/02/2012 11:15 AM, Seungwon Jeon wrote:
Jaehoon Chung jh80.ch...@samsung.com wrote:
On 02/29/2012 03:33 PM, Seungwon Jeon wrote:
Hi Jaehoon,
Thank you for the patch.
Could you check comments below?
Jaehoon Chung jh80.ch...@samsung.com wrote:
This patch is change to use the sdhci
be removed. Then it needs not to use SDHCI_QUIRK_NONSTANDARD_CLOCK.
Best Regards,
Jaehoon Chung
Thanks,
Seungwon Jeon.
Best Regards,
Jaehoon Chung
And about quirks..., I think compatibility should be considered.
Thanks,
Seungwon Jeon.
And any comment?
Best Regards,
Jaehoon Chung
Tested on Samsung-SoC
Tested-by: Jaehoon Chung jh80.ch...@samsung.com
On 02/29/2012 04:17 PM, Adrian Hunter wrote:
Most parts of the enable / disable API are no longer used and
can be removed.
Cc: Rajendra Nayak rna...@ti.com
Cc: Venkatraman S svenk...@ti.com
Cc: Kukjin Kim kgene
On 03/03/2012 12:29 AM, Per Förlin wrote:
On 03/02/2012 09:51 AM, Ulf HANSSON wrote:
Hi Jaehoon,
I did not know this. Which host driver are you using? I would very much
appreciate of you could debug and share some result.
Thanks!
BR
Ulf Hansson
On 03/02/2012 09:28 AM, Jaehoon Chung
On 03/05/2012 02:08 PM, Jaehoon Chung wrote:
On 03/03/2012 12:29 AM, Per Förlin wrote:
On 03/02/2012 09:51 AM, Ulf HANSSON wrote:
Hi Jaehoon,
I did not know this. Which host driver are you using? I would very much
appreciate of you could debug and share some result.
Thanks!
BR
Ulf
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 03/03/2012 09:46 AM, Mark Brown wrote:
This matches current best practice as one can have runtime PM enabled
without system sleep and CONFIG_PM is defined for both.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers
Hi Mark,
On 03/03/2012 09:46 AM, Mark Brown wrote:
Since most of the work is already done by the core we just need to add
runtime suspend methods and tell the PM core that runtime PM is enabled
for this device.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
in mmc-driver)
If will move into mmc-driver, we can maintain the efficient more than before.
I want to know your opinion.
Best Regards,
Jaehoon Chung
On 02/27/2012 04:58 PM, Jaehoon Chung wrote:
This patchset is the purpose for using sdhci-pltfm.c and
removing the arch dependency.
The sdhci-s3c
Hi Kukjin.
Is it merged?
Best Regards,
Jaehoon Chung
On 02/24/2012 06:56 PM, Thomas Abraham wrote:
On 23 February 2012 11:18, Jaehoon Chung jh80.ch...@samsung.com wrote:
Thomas Arbrahams's patchset have changed the device name in sdhci-s3c.c
(mmc: sdhci-s3c: Rework platform data and add
Hi.
It seems like my case.
http://www.spinics.net/lists/linux-mmc/msg12130.html
Thanks,
Jaehoon Chung
On 03/06/2012 04:10 AM, Fabio Estevam wrote:
Hi,
On a mx51babbage board running linux-next I get:
sdhci: Secure Digital Host Controller Interface driver
sdhci: Copyright(c) Pierre
for s3c64xx
- based-on latest mmc-tree.
Jaehoon Chung (4):
mmc: sdhci-s3c: use the sdhci-pltfm for Samsung-SoC
ARM: SAMSUNG: move the sdhci header file to driver directory
mmc: sdhci-s3c: use the sdhci-s3c.h instead of regs-sdhci.h
ARM: SAMSUNG: move the mmc platdata header file into linux
This patch is change to use the sdhci-pltfm.c
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/host/Kconfig | 20 ++--
drivers/mmc/host/Makefile|2 +-
drivers/mmc/host/sdhci-s3c.c | 252
The header-file is moved to drivers/mmc/host from plat.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/mach-exynos/setup-sdhci-gpio.c |1 -
arch/arm/mach-s5pc100/setup-sdhci-gpio.c|1 -
arch/arm/mach
Using the sdhci-s3c.h
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/host/sdhci-s3c.c | 12 +---
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/plat-samsung/include/plat/sdhci.h | 53 +-
include/linux/mmc/sdhci-s3c.h | 84
2 files changed, 85 insertions
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 03/05/2012 08:52 PM, Mark Brown wrote:
On Mon, Mar 05, 2012 at 07:48:42PM +0900, Jaehoon Chung wrote:
On 03/03/2012 09:46 AM, Mark Brown wrote:
+ pm_runtime_set_autosuspend_delay(pdev-dev, 50);
Could you explain why use 50ms?
It's
/regs-sdhci.h) also is only used in sdhci-s3c.c.
And the least portion is moved into /linux/mmc/.
Then included linux/mmc/sdhci-s3c.h in plat/sdhci.h.
What's difference?
If you can explain the more detail, i can understand.
But sorry, now i didn't accept your opinion.
Best Regards,
Jaehoon Chung
Hi Ulf.
I tested with patch-v2, i didn't found the other problem.
It looks good.
Tested-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 03/07/2012 01:26 AM, Ulf Hansson wrote:
Hi Jaehoon,
I would be very interested to hear if you still encounter any problems
Hi Mark.
On 03/08/2012 03:48 AM, Mark Brown wrote:
On Wed, Mar 07, 2012 at 12:03:31PM +0900, Jaehoon Chung wrote:
On 03/07/2012 01:30 AM, Mark Brown wrote:
The same IP is present and used with the same driver on other Samsung
SoCs.
I know that used with the same driver on other
On 03/08/2012 08:01 PM, Mark Brown wrote:
On Thu, Mar 08, 2012 at 02:35:53PM +0900, Jaehoon Chung wrote:
So i think no problem that removed #include plat/regs-sdhci.h. is it
wrong?
Just touching the setup-gpio- files is problem?
It should be fine, like I say I didn't really read
Though card didn't support HPI,someone could use the send_hpi_cmd().
Then maybe didn't work fine.
Because card-ext_csd.hpi_cmd didn't set.
So if card didn't support hpi, return the waring message.
And CMD12's flags is MMC_RSP_R1B.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off
Though card didn't support HPI,someone could use the send_hpi_cmd().
Then maybe didn't work fine.
Because card-ext_csd.hpi_cmd didn't set.
So if card didn't support hpi, return the waring message.
And CMD12's flags is MMC_RSP_R1B.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off
On 03/12/2012 01:06 AM, Konstantin Dorfman wrote:
Hello Jaehoon,
On Fri, January 20, 2012 8:48 am, Jaehoon Chung wrote:
...
diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index 4d41fa9..109d0f0 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
Looks fine to me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 03/09/2012 10:44 PM, Marek Szyprowski wrote:
exynos4_sdhci_drv_data structure is not available on non-Exynos builds,
that's why EXYNOS4_SDHCI_DRV_DATA macro has been introduced. This patch
fixes commit 67819656 'mmc: sdhci
BIT(29)
#define SDMMC_CMD_CCS_EXPBIT(23)
#define SDMMC_CMD_CEATA_RD BIT(22)
#define SDMMC_CMD_UPD_CLKBIT(21)
Best Regards,
Jaehoon Chung
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord
Hi Ulf.
Just one question.
mmc_blk_probe() is always returned 0?
Best Regards,
Jaehoon Chung
On 03/22/2012 07:47 PM, Ulf Hansson wrote:
According to the specifications for SD and (e)MMC default
blocksize (named BLOCKLEN in Spec.) must always be 512
bytes. Since we hardcoded to always use
Hi Adrian.
This patch is make sense.
It looks fine to me.
I tested with eMMC4.5 and triggered the secdiscard/discard with ioctl.
(But i didn't have the iNAND.)
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
Best Regards,
Jaehoon Chung
On 04/05/2012 08:45 PM, Adrian Hunter wrote:
Hi
Here
checked in specification ?
Well, i know that timeout value is used the OUT_OF_INTERRUPT_TIME, when
interrupted by HPI.
It's my misunderstanding?
Best Regards,
Jaehoon Chung
Thanks.
Specify the default timeout for the actual sending of HPI
command, and then use OUT_OF_INTERRUPT_TIME to wait
Now, dma_ops is assumed that use the IDMAC.
But if dma_ops is assigned the pdata-dma_ops,
We didn't ensure that callback function is defined.
If anything of callback didn't define, then should be run the PIO mode.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park
On 04/18/2012 05:42 PM, S, Venkatraman wrote:
On Wed, Apr 18, 2012 at 1:53 PM, Namjae Jeon linkinj...@gmail.com wrote:
2012/4/18 S, Venkatraman svenk...@ti.com:
On Wed, Apr 18, 2012 at 10:15 AM, Namjae Jeon linkinj...@gmail.com wrote:
2012/4/18 Jaehoon Chung jh80.ch...@samsung.com:
On 04/18
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 04/18/2012 11:45 PM, Venkatraman S wrote:
mmc_execute_hpi should send the HPI command only
once, only if the card is in PRG state.
According to eMMC spec, the command's completion time is
not dependent on OUT_OF_INTERRUPT_TIME. Only
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 05/02/2012 06:57 AM, Thomas Abraham wrote:
The variable 'dw_mci_card_workqueue' is a global variable shared between
multiple instances of the dw_mmc host controller. Due to this, data
corruption has been noticed when multiple instances
, this register is clock phasing.
In spec, card is enumerated in SDR12 or SDR25 mode, the application must
program the use_hold_reg.
Best Regards,
Jaehoon Chung
+
return cmdr;
}
@@ -787,10 +792,19 @@ static void dw_mci_set_ios(struct mmc_host *mmc,
struct mmc_ios *ios)
regs = mci_readl(slot
On 05/10/2012 07:55 PM, Thomas Abraham wrote:
On 2 May 2012 13:19, Jaehoon Chung jh80.ch...@samsung.com wrote:
On 05/02/2012 04:01 PM, Kyungmin Park wrote:
Hi,
On 5/2/12, Thomas Abraham thomas.abra...@linaro.org wrote:
The instantiation of the Synopsis Designware controller on Exynos5250
waiting for done, it spent 60~80sec.
So Added timeout value. if timeout value is set to 0, send hpi command.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Changelog V8:
- Remove host-lock spin lock reviewed by Adrian
modified to use with __mmc_switch().
As I remember, maybe you mentioned this point. right?
So i tried to use based on your review. it's missing in this patch.
Thank you for your comment. any other comments?
If you have others, let me know, plz.
Best Regards,
Jaehoon Chung
--
To unsubscribe
On 05/11/2012 08:40 PM, S, Venkatraman wrote:
On Thu, May 10, 2012 at 7:07 PM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Enable eMMC background operations (BKOPS) feature.
If URGENT_BKOPS is set after a response, note that BKOPS
are required. After all I/O requests are finished, run
BKOPS
On 05/11/2012 09:39 PM, Subhash Jadavani wrote:
Hi Jaehoon,
Please find comments inline below.
On 5/10/2012 7:07 PM, Jaehoon Chung wrote:
Enable eMMC background operations (BKOPS) feature.
If URGENT_BKOPS is set after a response, note that BKOPS
are required. After all I/O requests
.
Best Regards,
Jaehoon Chung
I will try to this approach.
This means that a predominantly read only disk, which wouldn't need
any BKOPS, wouldn't have any overhead.
Let me know if my assumption is incorrect.
Thanks for reviwe.
Best Regards,
Jaehoon Chung
~Venkat
Hi Subhash,
Thank you, Subhash.
I will refer to them. ASAP, i will send the patch-v9.
Best Regards,
Jaehoon Chung
On 05/14/2012 06:55 PM, Subhash Jadavani wrote:
-Original Message-
From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc-
ow...@vger.kernel.org] On Behalf
Hi Thomas,
On 05/18/2012 12:10 AM, Thomas Abraham wrote:
The instantiation of the Synopsis Designware controller on Exynos5250
include extension for SDR and DDR specific tx/rx phase shift timing
and CIU internal divider. In addition to that, the option to skip the
command hold stage is also
Hi Thomas,
I think that also need to consider for using dw_mci-pci.c.
Best Regards,
Jaehoon chung
On 05/18/2012 12:10 AM, Thomas Abraham wrote:
The 'struct dw_mci' maintains a copy of the pdev-dev instance instead of
maintaining a reference to that 'struct device' instance. Any resource
When mmc_host is not spi mode, mmc/sd is doing mmc_deselect_cards().
mmc_deselect_cards could be returned error.
If returned error, we can know something wrong when enter suspend.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
and start BKOPS in a preventive manner.
* Interrupt ongoing BKOPS before powering off the card.
* How get BKOPS_STATUS value.(periodically send ext_csd command?)
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Signed-off-by: Konstantin
);
+}
/* Cancel a prepared request if it was not started. */
if ((err || start_err) areq)
-mmc_post_req(host, areq-mrq, -EINVAL);
+mmc_post_req(host, areq-mrq, -EINVAL);
Remove this change, it is not related to this patch.
Ok.
Anything else?
Best Regards,
Jaehoon
is not the BUSY signal but the card state. Please correct me if I am
wrong on this point. Of cause, you can have a test with your device.
Right, in spec, CDM6 need R1B response. But i think that Level-0 and Level-1
didn't need waiting for busy signal.
Best Regards,
Jaehoon Chung
Thanks
/2012 10:09 AM, Jaehoon Chung wrote:
Enable eMMC background operations (BKOPS) feature.
If URGENT_BKOPS is set after a response, note that BKOPS
are required. After all I/O requests are finished, run
BKOPS if required. Should read/write operations be requested
during BKOPS, first issue HPI
On 06/13/2012 10:53 PM, S, Venkatraman wrote:
On Fri, Jun 8, 2012 at 10:09 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Enable eMMC background operations (BKOPS) feature.
If URGENT_BKOPS is set after a response, note that BKOPS
are required. After all I/O requests are finished, run
BKOPS
It looks good to me.
Acked-by: Jaehoon Chung jh80.ch...@samsung.com
On 06/15/2012 02:31 AM, Jonathan Kliegman wrote:
host-dma_ops is not valid if host-usa dma is 0 so protect
host-dma_ops reference in dw_mci_resume
Signed-off-by: Jonathan Kliegman kli...@chromium.org
---
drivers/mmc
Hi Daniel,
When enabled MMC_UNSAFE_RESUME, it assumed that card didn't remove
during suspend/resume.
If you need to remove the card during suspend/resume,
why enable MMC_UNSAFE_RESUME?
Best Regards,
Jaehoon Chung
On 07/06/2012 06:06 AM, Daniel Drake wrote:
The Marvell CaFe is now marked
Hi,
On 07/08/2012 07:13 PM, me...@codeaurora.org wrote:
On Fri, July 6, 2012 9:47 am, Chris Ball wrote:
Hi,
On Fri, Jun 08 2012, Jaehoon Chung wrote:
Enable eMMC background operations (BKOPS) feature.
If URGENT_BKOPS is set after a response, note that BKOPS
are required. After all I/O
On 07/09/2012 11:48 AM, Chris Ball wrote:
Hi,
On Sun, Jul 08 2012, Jaehoon Chung wrote:
I think MMC_CAP2_BKOPS should be removed. If the card BKOPs were already
enabled, the host must support BKOPs. Therefore, in mmc_start_bkops we
should check only if card-ext_csd.bkops_en is set
Hi, Adrian,
On 06/14/2012 10:46 PM, Adrian Hunter wrote:
On 08/06/12 07:39, Jaehoon Chung wrote:
Enable eMMC background operations (BKOPS) feature.
If URGENT_BKOPS is set after a response, note that BKOPS
are required. After all I/O requests are finished, run
BKOPS if required. Should read
Thanks for comment.
I will test and send the patch within this week.
Best Regards,
Jaehoon Chung
On 07/12/2012 03:00 PM, Adrian Hunter wrote:
On 12/07/12 08:02, Jaehoon Chung wrote:
Hi, Adrian,
On 06/14/2012 10:46 PM, Adrian Hunter wrote:
On 08/06/12 07:39, Jaehoon Chung wrote:
Enable
during 10 times.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/host/dw_mmc.c | 39 +++
1 files changed, 31 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b
On 07/13/2012 03:49 PM, Girish K S wrote:
On 13 July 2012 09:28, Jaehoon Chung jh80.ch...@samsung.com wrote:
As DesignWare spec, when inform ciu, waiting for clearing start_bit
or HLE is set. In case of HLE, repeat the command.
Before the patch, repeat the below message.
mmc_host mmc0
command?)
* If use periodic bkops, also consider runtime_pm control.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Signed-off-by: Konstantin Dorfman kdorf...@codeaurora.org
Signed-off-by: Maya Erez me...@codeaurora.org
---
Changelog v10
This patch added the method to enable the bkops.
In ext_csd register, BKOPS_EN bit is one-time programable.
So if you want to use the bkops, use the this command.
usage
#mmc bkops enable /dev/mmcblk0
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
Hi Girish,
On 07/16/2012 05:45 PM, Girish K S wrote:
In some Soc'S that integrate Designware mmc host controllers, the
HCON register is broken. The hardware configuration is not
updated. One specific usecase is the IDMAC. In Exysons5 SoC
there exist a internal DMA, but the HCON register's
On 07/17/2012 06:17 PM, Girish K S wrote:
On 17 July 2012 13:16, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi Girish,
On 07/16/2012 05:45 PM, Girish K S wrote:
In some Soc'S that integrate Designware mmc host controllers, the
HCON register is broken. The hardware configuration
,
Jaehoon Chung
On 07/17/2012 06:54 PM, Girish K S wrote:
On 17 July 2012 15:18, Jaehoon Chung jh80.ch...@samsung.com wrote:
On 07/17/2012 06:17 PM, Girish K S wrote:
On 17 July 2012 13:16, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi Girish,
On 07/16/2012 05:45 PM, Girish K S wrote:
In some
On 07/17/2012 09:30 PM, Adrian Hunter wrote:
On 17/07/12 05:44, Jaehoon Chung wrote:
snip
+/**
+ * mmc_start_bkops - start BKOPS for supported cards
+ * @card: MMC card to start BKOPS
+ *
+ * Start background operations whenever requested.
+ * when the urgent BKOPS bit is set
On 07/18/2012 04:34 AM, me...@codeaurora.org wrote:
See my comments below.
+/**
+ * mmc_start_bkops - start BKOPS for supported cards
+ * @card: MMC card to start BKOPS
+ *
+ * Start background operations whenever requested.
+ * when the urgent BKOPS bit is set in a R1 command
.
Future considerations
* Check BKOPS_LEVEL=1 and start BKOPS in a preventive manner.
* Interrupt ongoing BKOPS before powering off the card.
* How get BKOPS_STATUS value.(periodically send ext_csd command?)
* If use periodic bkops, also consider runtime_pm control.
Signed-off-by: Jaehoon
This patch added the method to enable the bkops.
In ext_csd register, BKOPS_EN bit is one-time programable.
So if you want to use the bkops, use the this command.
usage
#mmc bkops enable /dev/mmcblk0
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
dw_mci_probe lacks a __init
annotation or the annotation of dw_mci_init_slot is wrong
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/host/dw_mmc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers
Hi Thomas,
I think not good that added the samsung specific code into dw_mmc-pltfm.c
How about separating to dw-mmc-exynos.c?
Best Regards,
Jaehoon Chung
On 07/12/2012 09:54 PM, Thomas Abraham wrote:
This patch series adds device tree support for Synopsis Designware Mobile
Storage Host
Hi Maya,
On 07/20/2012 08:58 PM, me...@codeaurora.org wrote:
On Thu, July 19, 2012 8:12 am, Jaehoon Chung wrote:
+void mmc_start_bkops(struct mmc_card *card, bool from_exception)
+{
+int err;
+int timeout;
+bool use_busy_signal;
+
+BUG_ON(!card
Hi Seungwon,
On 07/20/2012 08:36 PM, Seungwon Jeon wrote:
Hi Jaehoon,
July 20, 2012, Jaehoon Chung jh80.ch...@samsung.com
Fixed the below message.
WARNING: drivers/mmc/host/built-in.o(.text+0x5ee8): Section mismatch in
reference from the function
dw_mci_probe() to the function
On 07/20/2012 07:47 AM, Kukjin Kim wrote:
Thomas Abraham wrote:
On 19 July 2012 20:58, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi Thomas,
I think not good that added the samsung specific code into dw_mmc-
pltfm.c
How about separating to dw-mmc-exynos.c?
I am not sure
On 07/24/2012 02:02 AM, Doug Anderson wrote:
The documentation for the dw_mmc part says that the low power
mode should normally only be set for MMC and SD memory and should
be turned off for SDIO cards that need interrupts detected.
The best place I could find to do this is when the SDIO
BKOPS in a preventive manner.
* Interrupt ongoing BKOPS before powering off the card.
* How get BKOPS_STATUS value.(periodically send ext_csd command?)
* If use periodic bkops, also consider runtime_pm control.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park
dw_mci_probe lacks a __init
annotation or the annotation of dw_mci_init_slot is wrong
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Changelog v2:
- added __init macro to dw_mmc_pltfm_probe.(reviewed by Seungwon)
drivers/mmc/host
1 - 100 of 1024 matches
Mail list logo
