[PATCH 0/1] sdhci-bcm2835: added quirk and removed udelay in write ops

This patch contains driver cleanup of sdhci-bcm2835. Please note that this has not actually been tested on bcm2835 yet. Testing comes from other devices with the same sdhci controller. This patch is being put out for testing and acceptance on the 2835. Please test and comment. Scott Branden (1

[PATCH 1/1] mmc: sdhci-bcm2835: added quirk and removed udelay in write ops

Added quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 present in controller. Removed udelay in write ops by using shadow registers for 16 bit accesses to 32-bit registers (where necessary). Optimized 32-bit operations when doing 8/16 register accesses. Signed-off-by: Scott Branden sbran...@broadcom.com

Re: [PATCH 1/1] mmc: sdhci-bcm2835: added quirk and removed udelay in write ops

Great review - thanks. On 14-10-17 07:37 PM, Stephen Warren wrote: On 10/15/2014 10:43 AM, Scott Branden wrote: Added quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 present in controller. Removed udelay in write ops by using shadow registers for 16 bit accesses to 32-bit registers (where necessary

[PATCHv2 0/5] sdhci-bcm2835: added quirk and removed udelay in write ops

This patch contains driver cleanup of sdhci-bcm2835. Please note that this has not actually been tested on bcm2835 yet. Testing comes from other devices with the same sdhci controller. This patch is being put out for testing and acceptance on the 2835. Please test and comment. Scott Branden (5

[PATCHv2 5/5] mmc: sdhci-bcm2835: add sdhci quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12

SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this controller. Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/sdhci-bcm2835.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci

[PATCHv2 1/5] mmc: sdhci-bcm2835: group read and write functions to improve readability

Group the read and write functions to improve readability. Now all similar functions are grouped together to evaluate behaviours. Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/sdhci-bcm2835.c | 61 +++--- 1 file changed, 31 insertions

[PATCHv2 3/5] mmc: shdci-bcm2835: add efficient back-to-back write workaround

. Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/sdhci-bcm2835.c | 103 -- 1 file changed, 55 insertions(+), 48 deletions(-) diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c index b6cb365..f8c450a 100644

[PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

Add a verify option to driver to print out an error message if a potential back to back write could cause a clock domain issue. Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/Kconfig |9 + drivers/mmc/host/sdhci-bcm2835.c | 17 + 2

[PATCHv2 2/5] mmc: sdhci-bcm2835: make shift calculations consistent

Make the shift calculations consistent rather than having different implementations to calculate the same thing. Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/sdhci-bcm2835.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git

Re: [PATCHv2 2/5] mmc: sdhci-bcm2835: make shift calculations consistent

On 14-11-04 08:48 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: Make the shift calculations consistent rather than having different implementations to calculate the same thing. diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c

Re: [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

On 14-11-04 08:44 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: Add a verify option to driver to print out an error message if a potential back to back write could cause a clock domain issue. diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci

Re: [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

On 14-11-04 08:59 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: Add a verify option to driver to print out an error message if a potential back to back write could cause a clock domain issue. index f8c450a..11af27f 100644 +#ifdef

Re: [PATCHv2 5/5] mmc: sdhci-bcm2835: add sdhci quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12

On 14-11-04 09:00 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this controller. This seems fine, although any explanation of why this quirk is needed would be useful. I don't know who to talk to at Arasan

Re: [PATCHv2 5/5] mmc: sdhci-bcm2835: add sdhci quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12

On 14-11-05 08:50 PM, Stephen Warren wrote: On 11/05/2014 12:02 AM, Scott Branden wrote: On 14-11-04 09:00 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this controller. This seems fine, although any

Re: [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

On 14-11-05 09:01 PM, Stephen Warren wrote: On 11/05/2014 12:00 AM, Scott Branden wrote: On 14-11-04 08:59 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: Add a verify option to driver to print out an error message if a potential back to back write could cause a clock

[PATCH] mmc: sdhci: add quirk for ACMD23 broken

Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/sdhci.c | 3 ++- include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index ada1a3e..b37331f 100644 --- a/drivers/mmc/host/sdhci.c

[PATCH v2] mmc: sdhci: add quirk for ACMD23 broken

...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/sdhci.c | 3 ++- include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index ada1a3e..b37331f 100644 --- a/drivers/mmc/host

RE: [PATCH] Move MMCI header to amba include dir

Hi Linus, You changes cause the bcmring platform to fail to compile. Can you go through all the ARM platforms and make the necessary adjustments with the change in header files for mmc? Thanks, Scott -Original Message- From: linux-arm-kernel-boun...@lists.infradead.org

Re: [PATCH v2] mmc: sdhci: add quirk for ACMD23 broken

Hi Chris, I have not received any feedback on this patch for the SDHCI controller. Anything I can do to help get this accepted into the codebase? Thanks, Scott On 14-12-04 04:16 PM, Scott Branden wrote: Add quirk to handle broken auto-CMD23. Some controllers do not respond after the first

Re: [PATCH v2] mmc: sdhci: add quirk for ACMD23 broken

Hi Chris, We'll finish off cleaning up our driver that uses this patch for review then. Thanks, Scott On 14-12-17 11:48 AM, Chris Ball wrote: Hi Scott, sorry for the delay, On Fri, Dec 05 2014, Scott Branden wrote: Add quirk to handle broken auto-CMD23. Some controllers do not respond

[PATCH 3/4] mmc: sdhci-iproc: add IPROC SDHCI driver

Add IPROC SDHCI driver for IPROC family of Broadcom devices. Acked-by: Ray Jui r...@broadcom.com Signed-off-by: Corneliu Doban cdo...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/Kconfig | 14 +++ drivers/mmc/host/Makefile | 1 + drivers/mmc

[PATCH 1/4] mmc: sdhci: add quirk for ACMD23 broken

...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/sdhci.c | 3 ++- include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index

[PATCH 4/4] mmc: sdhci-iproc: add device tree bindings

Add device tree binding documentation for IPROC SDHCI driver. Acked-by: Ray Jui r...@broadcom.com Signed-off-by: Corneliu Doban cdo...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- .../devicetree/bindings/mmc/brcm,sdhci-iproc.txt | 23 ++ 1 file

[PATCH 0/4] Add support for IPROC SDHCI controller

This series of patchsets contains the IPROC SDHCI driver used in a series of Broadcom SoCs Quirks are also added to support this controller. Corneliu Doban (1): mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53 Scott Branden (3): mmc: sdhci: add quirk for ACMD23 broken mmc: sdhci

[PATCH 2/4] mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53

From: Corneliu Doban cdo...@broadcom.com For CMD53 in block mode, the host does not need to stop the transfer, as it stops when the block count (present in CMD53) is reached. Signed-off-by: Corneliu Doban cdo...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc

[PATCH] mmc: sdhci: fix card presence logic in sdhci_request function

on the hardware as it is non-removable. Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/sdhci.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 0ad412a..bafc7ac 100644 --- a/drivers/mmc

Re: [PATCH 4/4] mmc: sdhci-iproc: add device tree bindings

Hi Florian, On 15-03-02 03:50 PM, Florian Fainelli wrote: Unless there is a re-spin, I will fix this myself while applying this patch to devicetree/next. Thanks Yes, you can patch the formatting if the driver is being integrated. But I have had no response or feedback on the sdhci driver.

[PATCH RESEND 0/4] Add support for IPROC SDHCI controller

This series of patchsets contains the IPROC SDHCI driver used in a series of Broadcom SoCs Quirks are also added to support this controller. Corneliu Doban (1): mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53 Scott Branden (3): mmc: sdhci: add quirk for ACMD23 broken mmc: sdhci

[PATCH 2/4] mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53

From: Corneliu Doban cdo...@broadcom.com For CMD53 in block mode, the host does not need to stop the transfer, as it stops when the block count (present in CMD53) is reached. Signed-off-by: Corneliu Doban cdo...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc

[PATCH 1/4] mmc: sdhci: add quirk for ACMD23 broken

...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- drivers/mmc/host/sdhci.c | 3 ++- include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index

[PATCH 4/4] mmc: sdhci-iproc: add device tree bindings

Add device tree binding documentation for IPROC SDHCI driver. Acked-by: Ray Jui r...@broadcom.com Signed-off-by: Corneliu Doban cdo...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- .../devicetree/bindings/mmc/brcm,sdhci-iproc.txt | 23 ++ 1 file

Re: [PATCH 0/4] Add support for IPROC SDHCI controller

Hi Chris, I have not heard any more feedback on this patchset. Is it in your queue to review or merge into your tree? Thanks, Scott On 15-02-09 04:06 PM, Scott Branden wrote: This series of patchsets contains the IPROC SDHCI driver used in a series of Broadcom SoCs Quirks are also added

Re: 04e079cf6b24c794 to stable

04e079cf6b24c794bbc52b04b370f84cb728540e Author: Scott Branden sbran...@broadcom.com Date: Tue Mar 10 11:35:10 2015 -0700 mmc: sdhci: fix card presence logic in sdhci_request function The sdhci_request function should consider a non-removable device always present. Call the correct logic already available

Re: [RFC PATCH] mmc: Kconfig: Add dependency on GPIOLIB for Arasan driver

Hi Michal, comment in line On 15-07-24 06:53 AM, Michal Simek wrote: The patch mmc: sdhci-of-arasan: Call OF parsing for MMC (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) introduce new dependency on GPIOLIB which calls mmc_of_parse() - mmc_gpiod_request_cd() (slot-gpio.c) which calls

Re: [PATCH 1/4] mmc: Add quirk to disable SDR50 mode

On 15-11-09 02:45 AM, Ulf Hansson wrote: On 7 November 2015 at 00:55, Scott Branden <sbran...@broadcom.com> wrote: Hi Ulf, On 15-11-06 12:14 AM, Ulf Hansson wrote: On 5 November 2015 at 23:39, Al Cooper <alcoop...@gmail.com> wrote: Add quirk to disable SDR50 mode for contro

Re: [PATCH 1/4] mmc: Add quirk to disable SDR50 mode

Hi Ulf, On 15-11-06 12:14 AM, Ulf Hansson wrote: On 5 November 2015 at 23:39, Al Cooper wrote: Add quirk to disable SDR50 mode for controllers/boards that have problems with this mode. No thanks! No more quirks please! I'm fine with not having this quirk added (I

Re: [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

Hi Stefan, On 15-12-22 07:55 AM, Stefan Wahren wrote: Hi Scott, Am 07.11.2014 um 19:31 schrieb Scott Branden: On 14-11-05 09:01 PM, Stephen Warren wrote: On 11/05/2014 12:00 AM, Scott Branden wrote: On 14-11-04 08:59 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote