Make sure mmc_start_req cancel the prepared job, if the request
was prevented to be started due to the card has been removed.
This bug was introduced in commit:
mmc: allow upper layers to know immediately if card has been removed
Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com
---
drivers
that the card
has been completely powered off, otherwise the card will remain
at the last I/O voltage level that were negotitiated.
Due to the above being taken care of the suspend/resume issues
for UHS-I SD-cards has been fixed.
Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com
---
drivers/mmc/core
Hi Jaehoon,
I did not know this. Which host driver are you using? I would very much
appreciate of you could debug and share some result.
Thanks!
BR
Ulf Hansson
On 03/02/2012 09:28 AM, Jaehoon Chung wrote:
Hi Ulf.
I tested with this patch.
But in my environment, this patch didn't work fine
Hi,
The reason for the RESEND was due to a missed removal of a gerrit
change id. The patch has not change as such.
Br
Ulf Hansson
On 03/01/2012 04:48 PM, Ulf HANSSON wrote:
Even if cards supports 1.8V I/O voltage those should anyway be
initialized at 3.3V I/O according to (e)MMC, SD
Make sure mmc_start_req cancel the prepared job, if the request
was prevented to be started due to the card has been removed.
This bug was introduced in commit:
mmc: allow upper layers to know immediately if card has been removed
Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com
Reviewed
Hi Chris,
Just wondering if you see any issues with proceeding with this patch?
Thanks!
Br
Ulf Hansson
On 02/06/2012 10:42 AM, Ulf HANSSON wrote:
To prevent I/O as soon as possible at card removal, a new
detect work is re-scheduled without a delay to let a rescan
remove the card device
Ulf Hansson
On 03/05/2012 03:52 PM, Ulf HANSSON wrote:
Make sure mmc_start_req cancel the prepared job, if the request
was prevented to be started due to the card has been removed.
This bug was introduced in commit:
mmc: allow upper layers to know immediately if card has been removed
Signed-off
Regards,
Jaehoon Chung
On 03/07/2012 01:26 AM, Ulf Hansson wrote:
Hi Jaehoon,
I would be very interested to hear if you still encounter any problems with
this V2 patch? If you are able to do a test it would be highly appreciated. :-)
Just for reference, I were able to reproduce problems similar
mmc_card_set_removed(c) ((c)-state |= MMC_CARD_REMOVED)
+#define mmc_card_set_sleep(c) ((c)-state |= MMC_STATE_SLEEP)
+#define mmc_card_clr_sleep(c) ((c)-state= ~MMC_STATE_SLEEP)
/*
* Quirk add/remove for MMC products.
*/
Best regards
Ulf Hansson
--
To unsubscribe from this list: send the line
Hi Linus,
Great initiative! Of course you get my Ack.
Acked-by: Ulf Hansson ulf.hans...@stericsson.com
Br
Ulf Hansson
On 03/15/2012 03:30 PM, Linus WALLEIJ wrote:
From: Linus Walleijlinus.wall...@linaro.org
So since this driver is crucial for us (as in ST-Ericsson)
to have actively
= ~MMC_STATE_SLEEP)
/*
* Quirk add/remove for MMC products.
*/
Best regards
Ulf Hansson
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On 03/16/2012 09:53 AM, Russell King wrote:
On Fri, Mar 16, 2012 at 09:48:07AM +0100, Ulf Hansson wrote:
Although, right know I would vote for having a more active maintainer
for MMCI; please no offense Russell, I realize that your are fully
occupied with a lot of other cool stuff. I think
, but until then let's skip this.
Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com
---
drivers/mmc/card/block.c | 27 +--
1 files changed, 1 insertions(+), 26 deletions(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index a7c75d8..ce171c6 100644
to the arg variable?
What about:
unsigned int from, nr, arg = 0;
Yours!
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
is never
updated, as before. Maybe we should look into that, but if a change is
needed I suggest a separate patch for that.
Kind regards
Ulf Hansson
Best Regards,
Jaehoon Chung
On 03/22/2012 07:47 PM, Ulf Hansson wrote:
According to the specifications for SD and (e)MMC default
blocksize (named
*/
+#define MMC_CAP2_POWER_OFF_VCCQ_DURING_SUSPEND (1 10)
mmc_pm_flag_t pm_caps;/* supported pm features */
unsigned intpower_notify_type;
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body
*, pm_message_t);
+ int (*suspend)(struct mmc_card *);
int (*resume)(struct mmc_card *);
};
Otherwise looks good!
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
this it
works just fine.
Signed-off-by: Linus Walleijlinus.wall...@linaro.org
Looks good to me. Acked-by: Ulf Hansson ulf.hans...@stericsson.com
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
, as Ulf Hansson suggested
drivers/mmc/card/block.c |2 +-
drivers/mmc/core/bus.c | 24 ++--
include/linux/mmc/card.h |2 +-
3 files changed, 8 insertions(+), 20 deletions(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index f2020d3..3582c03
, as Ulf Hansson suggested
Changes in v4:
fix the warning when disable CONFIG_PM_RUNTIME
Looks good to me! Acked-by: Ulf Hansson ulf.hans...@stericsson.com
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord
the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
patch
instead, which removes the try_claim_host thing, at least as a first
step. I am on it immediately.
Then we can you can think of a more long term solution, if still needed.
What do you think?
Can we revisit this?
Thanks,
Daniel
Kind regards
Ulf Hansson
--
To unsubscribe from this list
Since SDIO drivers may want to do some SDIO operations
in their suspend callback functions, we must not keep
the host claimed when calling them.
Daniel Drake reported that libertas_sdio encountered
a deadlock in it's suspend function.
Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com
be
patient. :-)
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
features */
unsigned intpower_notify_type;
Hi Ulf,
need your comment on the above.
--
1.7.1
Overall, I like this patch, we are getting close to a final version I think.
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body
like this patch, we are getting close to a final version I think.
Kind regards
Ulf Hansson
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
pm_caps;/* supported pm features */
unsigned intpower_notify_type;
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
not be
causing any issue I think. But, still, according to input from Vitaly
above, this patch is not OK.
I will rework this patch. Thanks for your input.
I've said that before...
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message
From: Ulf Hansson ulf.hans...@linaro.org
For eMMC cards that has been initialized from a bootloader,
the VCC voltage supply must not be cut in an uncontrolled
manner, without first sending SLEEP or POWEROFF_NOTIFY.
The regulator_init_complete late initcall, may cut the VCC
regulator if it's
Hi Girish,
In patch 1/2 you break the compilation of these host drivers. In this
patch 2/2 you fix it again. I would prefer you include these fixes in
the same patch instead of splitting them into two pieces.
Kind regards
Ulf Hansson
On 05/07/2012 03:41 PM, Girish K S wrote:
This patch
have some
additional comments to add soon.
Chris, what do you think?
Kind regards
Ulf Hansson
On 05/11/2012 01:44 PM, Subhash Jadavani wrote:
Hi Girish,
On 5/7/2012 7:11 PM, Girish K S wrote:
This is a rework of the existing POWER OFF NOTIFY patch. The current problem
with the patch comes from
structure?
+#define MMC_HOST_PW_OFF_NOTIFY_NONE 0
+#define MMC_HOST_PW_OFF_NOTIFY_SHORT 1
+#define MMC_HOST_PW_OFF_NOTIFY_LONG 2
#ifdef CONFIG_MMC_CLKGATE
int clk_requests; /* internal reference counter */
Kind regards
Ulf Hansson
Hi Yongd,
From my perspective I don't think this patch is wanted.
A retry mechanism is likely very much hw-SDIO device dependent. Upper
layers (SDIO func driver) is thus the only software that is able to
handle retries correctly.
Kind regards
Ulf Hansson
On 05/14/2012 10:39 AM, yongd
0
+#define MMC_HOST_PW_OFF_NOTIFY_SHORT 1
+#define MMC_HOST_PW_OFF_NOTIFY_LONG 2
#ifdef CONFIG_MMC_CLKGATE
int clk_requests; /* internal reference
counter */
Kind regards
Ulf Hansson
Thanks!
Ulf Hansson
--
To unsubscribe from this list
Hi Yong Ding,
On 05/15/2012 05:14 AM, Yong Ding wrote:
Hi Ulf Hansson, Thanks for your comments.
Such retry mechanism is a simple CMD-level or sdio-core-level retry
which takes advantage of the mmc core internal retry. There is not
any side effect, but with it, even those SDIO function
Hi Girish and Saugata,
This patch looks great to me!
Acked-by: Ulf Hansson ulf.hans...@linaro.org
Kind regards
Ulf Hansson
On 05/22/2012 01:45 PM, Girish K S wrote:
From: Saugata Dassaugata@linaro.org
This is a rework of the existing POWER OFF NOTIFY patch. The current problem
from the host drivers, the mmc_regulator_get_ocrmask function do
no longer have to be an exported function, but instead a static
function on core.c I suppose this can be fixed in separate patch,
where we also add mmc_regulator_get_vmmc for all host drivers?
Kind regards
Ulf Hansson
--
To unsubscribe
this requirement can be removed and fixed in the host driver somehow.
Please get back to me if you need some more assistance around this matter.
Kind regards
Ulf Hansson
On 28 May 2012 21:21, Tony Lindgren t...@atomide.com wrote:
Hi Ulf Chris,
Looks like commit fa550189 (mmc: core: Prevent
More majordomo info at http://vger.kernel.org/majordomo-info.html
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Richard,
On 31 May 2012 18:15, Torne (Richard Coles) to...@google.com wrote:
On 31 May 2012 11:00, Ulf Hansson ulf.hans...@linaro.org wrote:
Hi Richard,
On 29 May 2012 17:02, Torne (Richard Coles) to...@google.com wrote:
From: Torne (Richard Coles) to...@google.com
MMC CSD info can
Hi Jaehoon,
This make sense to me!
Acked-by: Ulf Hansson ulf.hans...@linaro.org
Kind regards
Ulf Hansson
On 31 May 2012 19:31, Jaehoon Chung jh80.ch...@samsung.com wrote:
When mmc_host is not spi mode, mmc/sd is doing mmc_deselect_cards().
mmc_deselect_cards could be returned error
Hi Marc,
Maybe we can have some input from Subhash on this matter. I believe a
revert can be feasible until a working solution exist.
Kind regards
Ulf Hansson
On 06/04/2012 06:35 PM, Marc Dietrich wrote:
Hi,
somehow I hope this would go away by itself, but it didn't :-( I reported
to the card) and one called vccq (io-voltage). Very much depending on
the hw board design, you may use one, two or no regulator at all for
these power(s).
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord
int mmc_card_awake(struct mmc_host *host);
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
mmc_regulator_get_supply(struct mmc_host *mmc)
+{
+ return 0;
+}
#endif
int mmc_card_awake(struct mmc_host *host);
Sorry being a bit picky, I am that mode today :-)
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord
is some cases and in some
cases not (without restoring ios). So using CMD0 as common way of waking
up from suspend should be fine. Unless I missed something of course. :-)
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message
regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Guennadi,
You have my ack on this then!
Acked-by: Ulf Hansson ulf.hans...@linaro.org
Kind regards
Ulf Hansson
On 06/13/2012 03:44 PM, Guennadi Liakhovetski wrote:
On Wed, 13 Jun 2012, Ulf Hansson wrote:
Hi Guennadi,
On 06/13/2012 02:57 PM, Guennadi Liakhovetski wrote:
Add a function
in: http://article.gmane.org/gmane.linux.kernel.mmc/14635,
still being discussed though.
The MMC_CAP2_POWER_OFF_VCCQ_DURING_SUSPEND, can likely soon be removed
as well, when above patch is accepted and host driver is starting to use
the new API.
Kind regards
Ulf Hansson
--
To unsubscribe from
with sdhci (sdhci compatilble host controller)
and dw_mmc (design-ware host controller). and has no side effect due to
this removal.
Tested on : origen-board and smdk-5250 board.
Signed-off-by: Girish K S girish.shivananja...@linaro.org
Cc: Ulf Hansson ulf.hans...@linaro.org
---
drivers/mmc
Hi Saugata,
Sorry for a very late reply, I just came back from vacation.
Anyway, this patch looks good to me. You have my Ack.
Kind regards
Ulf Hansson
On 29 June 2012 11:03, Saugata Das saugata@stericsson.com wrote:
From: Saugata Das saugata@linaro.org
This is a rework
Ulf Hansson
On 24 August 2012 02:23, Jaehoon Chung jh80.ch...@samsung.com wrote:
eMMC card revision have increased more faster than before.
We need to prepare the next eMMC revision(eMMCx.0).
Its revision is 0x7. (eMMC4.5 is 0x6 - can get the information at ext_csd
register)
Jaehoon Chung (2
/majordomo-info.html
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
and known_rev.)
It is just speculations about potential problems with eMMC 5.0. I
think we can leave this to later, if/when we see a need for it.
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More
unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More
From: Ulf Hansson ulf.hans...@linaro.org
This patch fixup the broken suspend sequence for eMMC
with sleep support. Additionally it reworks the eMMC4.5
Power Off Notification feature so it fits together with
the existing sleep feature.
The CMD0 based re-initialization of the eMMC at resume
is re
/resume sequence is fixed for eMMC with sleep support. I also
tested this with MMC_CAP2_POWEROFF_NOTIFY enabled.
Are you able to help out in testing with a eMMC 4.5 device with
POWER_OFF_NOTIFY support?
Kind regards
Ulf Hansson
On 14 September 2012 08:38, Girish K S girish.shivananja...@linaro.org
On 14 September 2012 10:25, Girish K S girish.shivananja...@linaro.org wrote:
On 14 September 2012 12:37, Ulf Hansson ulf.hans...@linaro.org wrote:
Hi Girish,
I should also have stated that this patch has not been tested with an
eMMC 4.5 device, thus the power off notification is not fully
to this later.
Kind regards
Ulf Hansson
On 14 September 2012 09:13, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi Ulf and Chris,
Could you have any opinion?
If you have no more, could you merge the patch for eMMC5.0?
Best Regards,
Jaehoon Chung
On 08/29/2012 08:59 PM, Kyungmin Park wrote:
Hi
0x0002
--
1.7.0.4
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line
Hi Chris,
Just pinging you to see if you have an opinion in merging this without
full testing on eMMC4.5 device?
I am kind of eager to fixup the broken suspend for eMMC with sleep,
which this does. :-)
Kind regards
Ulf Hansson
On 17 September 2012 06:50, Girish K S girish.shivananja
On 20 September 2012 13:33, Kevin Liu keyuan@gmail.com wrote:
Hi, Ulf
2012/9/19 Ulf Hansson ulf.hans...@linaro.org:
Hi Kevin,
On 19 September 2012 05:12, Kevin Liu keyuan@gmail.com wrote:
From: Kevin Liu kl...@marvell.com
If host support asynchronous interrupt and sdio device has
for helping out!
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
SDIO_DRIVE_DTSx_SHIFT)
#define SDIO_DTSx_SET_TYPE_D (3 SDIO_DRIVE_DTSx_SHIFT)
+
+#define SDIO_CCCR_INT_EXT 0x16
+#define SDIO_INT_SAI 0x01
+#define SDIO_INT_EAI 0x02
+
/*
* Function Basic Registers (FBR)
*/
--
1.7.0.4
Reviewed-by: Ulf Hansson ulf.hans
#define SDHCI_SUPPORT_SDR50 0x0001
#define SDHCI_SUPPORT_SDR104 0x0002
--
1.7.0.4
Reviewed-by: Ulf Hansson ulf.hans...@linaro.org
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
(*enable_preset_value)(struct mmc_host *host, bool enable);
--
1.7.10
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
This mean you will retry forever even if the card is not capable of
1.8V. I doubt this really what you want?
goto try_again;
}
}
--
1.7.10
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body
Hi Kevin,
This make sense to me.
Acked-by: Ulf Hansson ulf.hans...@linaro.org
Kind regards
Ulf Hansson
On 24 September 2012 10:15, Kevin Liu keyuan@gmail.com wrote:
From: Kevin Liu kl...@marvell.com
Both of MMC_TIMING_LEGACY and MMC_TIMING_UHS_SDR12 are defined
to 0. And ios-timing
On 20 September 2012 03:35, Chris Ball c...@laptop.org wrote:
Hi,
On Wed, Sep 19 2012, Ulf Hansson wrote:
Just pinging you to see if you have an opinion in merging this without
full testing on eMMC4.5 device?
I am kind of eager to fixup the broken suspend for eMMC with sleep,
which
; /* driver type (A, B, C, D) */
--
1.7.0.4
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 27 September 2012 12:39, Kevin Liu keyuan@gmail.com wrote:
Hi, Ulf
2012/9/27 Ulf Hansson ulf.hans...@linaro.org:
Hi Kevin,
On 26 September 2012 13:38, Kevin Liu keyuan@gmail.com wrote:
From: Kevin Liu kl...@marvell.com
Mmc does NOT have special sequence requirements for 1.8v
Hi Chris,
On 3 October 2012 23:03, Chris Ball c...@laptop.org wrote:
Hi Ulf,
On Thu, Sep 13 2012, Ulf Hansson wrote:
From: Ulf Hansson ulf.hans...@linaro.org
This patch fixup the broken suspend sequence for eMMC
with sleep support. Additionally it reworks the eMMC4.5
Power Off
On 5 October 2012 18:50, Chris Ball c...@laptop.org wrote:
Hi Ulf,
On Thu, Sep 13 2012, Ulf Hansson wrote:
From: Ulf Hansson ulf.hans...@linaro.org
This patch fixup the broken suspend sequence for eMMC
with sleep support. Additionally it reworks the eMMC4.5
Power Off Notification feature
From: Ulf Hansson (address hidden)
For data writes = 8 bytes, HW flow control was disabled but
never re-enabled when the transfer was completed. This meant
that a following read request would give buffer overrun errors.
Signed-off-by: Ulf Hansson ulf.hans...@linaro.org
---
drivers/mmc/host
For writes, HWFC shall be switched off when transfer size = 8
bytes and when MCLK rate is above 50 MHz. For 50MHz and below
it shall be switched off when transfer size 8 bytes.
Signed-off-by: Ulf Hansson ulf.hans...@linaro.org
---
drivers/mmc/host/mmci.c | 12 +++-
1 file changed, 7
On 10/12/2012 01:54 PM, Russell King - ARM Linux wrote:
On Fri, Oct 12, 2012 at 10:13:22AM +0100, Russell King - ARM Linux wrote:
On Wed, Oct 10, 2012 at 06:03:19PM +0200, Ulf Hansson wrote:
From: Ulf Hanssonulf.hans...@linaro.org
For data writes= 8 bytes, HW flow control was disabled
On 12 October 2012 14:35, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Fri, Oct 12, 2012 at 02:24:16PM +0200, Ulf Hansson wrote:
Hi Russell,
Our IT department is slow, too slow. :-)
As an option, would it be possible for you to manually send me a new
password? Another option
From: Ulf Hansson ulf.hans...@linaro.org
For the ux500v2 variant non power of two block sizes are supported.
This will make it possible to decrease data overhead for SDIO
transfers. Although we need to put some constraints to the alignment
of the buffers when enabling this feature.
Buffers must
From: Ulf Hansson ulf.hans...@linaro.org
The cookie is now used to indicate if dma_unmap_sg shall be
done in post_request. At DMA errors, the DMA job is immediately
not only terminated but also unmapped. To indicate that this
has been done the cookie is reset to zero. post_request will
thus only
Hi Linus,
On 12 October 2012 23:32, Linus Walleij linus.wall...@linaro.org wrote:
On Fri, Oct 12, 2012 at 5:33 PM, Ulf Hansson ulf.hans...@stericsson.com
wrote:
From: Ulf Hansson ulf.hans...@linaro.org
The cookie is now used to indicate if dma_unmap_sg shall be
done in post_request
On 16 October 2012 10:17, Linus Walleij linus.wall...@linaro.org wrote:
On Tue, Oct 16, 2012 at 9:16 AM, Ulf Hansson ulf.hans...@linaro.org wrote:
This code has not been tested on a legacy ARM PL180 but only for
ux500 boards. Even if it should affect DMA handling we should test
this properly
. For example MMC_CAP2_DETECT_ON_ERR
which I invented. :-). I think it especially these software support
configuration caps that might be causing this dt issues.
Would be very interesting to hear if someone is sharing my thoughts
around the host caps. Or if I am totally wrong here.
Kind regards
Ulf
Russell King - ARM Linux wrote:
On Tue, Jun 28, 2011 at 09:57:40AM +0200, Linus Walleij wrote:
From: Ulf Hansson ulf.hans...@stericsson.com
The end of a dma|pio data transfer is synced with the
DATAEND irq. This will prevent the mmci driver from ending
the request before the dma|pio job
, the framework must never send any
new commands to the host driver, without first doing a new power up.
This will most likely trigger any host driver to hang.
Moving power off out of detach and instead handle power off
separately when it is actually needed, solves the issue.
Signed-off-by: Ulf
device.
Change-Id: Id31787fcbfeb0b97ba2e8c583e9363a7c08811d2
Signed-off-by: Stefan Nilsson XK stefan.xk.nils...@stericsson.com
Signed-off-by: Ulf HANSSON ulf.hans...@stericsson.com
---
drivers/mmc/core/quirks.c | 11 +++
drivers/mmc/core/sdio_ops.c |7 +--
include/linux/mmc
-off-by: Stefan Nilsson XK stefan.xk.nils...@stericsson.com
Signed-off-by: Ulf HANSSON ulf.hans...@stericsson.com
---
drivers/mmc/core/core.c |8 +++-
drivers/mmc/core/mmc.c |8
drivers/mmc/core/sd.c |2 --
drivers/mmc/core/sdio.c |2 --
4 files changed, 11 insertions
a CMD13 (SEND_STATUS) to make sure the data is written
before issuing the next request.
BR
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
read for small packets
mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant
mmc: mmci: Fix incorrect handling of HW flow control for SDIO
Ulf Hansson (1):
mmc: mmci: Prepare for SDIO before setting up DMA job
drivers/mmc/host/mmci.c | 78
for transfers that fits in the
FIFO of PL18x. Thus it is disabled for write operations = the FIFO size.
Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com
Signed-off-by: Stefan Nilsson XK stefan.xk.nils...@stericsson.com
---
drivers/mmc/host/mmci.c | 42
-by: Ulf Hansson ulf.hans...@stericsson.com
---
drivers/mmc/host/mmci.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 8831b2f..f1d27d9 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -52,6
Move the SDIO preparation to be done before the DMA job is setup.
This makes it possible to do DMA for SDIO transfers as well as the
earlier supported pio mode.
Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com
Signed-off-by: Stefan Nilsson XK stefan.xk.nils...@stericsson.com
---
drivers/mmc
From: Sebastian Rasmussen sebastian.rasmus...@stericsson.com
Use variant data to store hardware controller deviations concerning
power registers to improve readability of the code.
Signed-off-by: Sebastian Rasmussen sebastian.rasmus...@stericsson.com
Signed-off-by: Ulf Hansson ulf.hans
just plain wrong.
This patch is really great, not just for pm_runtime issues!
Acked-by: Ulf Hansson ulf.hans...@stericsson.com
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
we wnat
to do mmc_power_save_host... What do you think?
Best regards
Ulf Hansson
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Stefan NILSSON9 wrote:
Hi Russel,
On 10/01/2011 06:09 PM, Russell King - ARM Linux wrote:
Does this even work? From the MMCI spec, I see no way for the MMCI
peripheral to know the size of the read/write on the APB bus.
The APB bus signals the MMCI uses are:
PCLK - APB bus clock
PRESETn -
Russell King - ARM Linux wrote:
On Tue, Sep 27, 2011 at 09:46:08AM +0200, Ulf Hansson wrote:
From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com
Corrects a bug in pio read when reading packets 4 bytes. These
small packets are only relevant for SDIO transfers.
Does this even work? From
Linus Walleij wrote:
On Sat, Oct 8, 2011 at 11:10 AM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Fri, Oct 07, 2011 at 03:45:48PM +0200, Ulf Hansson wrote:
Well, the patch system says that each one depends on the previous one,
and the first one in the series contains the PIO read
The patch mmc: core: move -request() call from atomic context,
is the reason to why this change is possible. This simplifies the
error handling code execution path quite a lot and potentially also
fixes some error handling hang problems.
Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com
, -EBUSY is returned.
Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com
---
drivers/mmc/core/core.c | 42 +++---
1 files changed, 27 insertions(+), 15 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 61d7730..b900932 100644
Jon Medhurst (Tixy) wrote:
On Thu, 2011-10-13 at 15:29 +0100, Russell King - ARM Linux wrote:
On Tue, Oct 11, 2011 at 04:06:41PM +0200, Ulf Hansson wrote:
The patch mmc: core: move -request() call from atomic context,
is the reason to why this change is possible. This simplifies the
error
1 - 100 of 2208 matches
Mail list logo
