Re: [PATCH 2/2] NLM: Convert lockd to use kthreads

2008-02-07 Thread Christoph Hellwig
On Wed, Feb 06, 2008 at 07:34:28AM -0500, Jeff Layton wrote: Yes. Perhaps we should consider a kthread_stop_with_signal() function that does a kthread_stop and sends a signal before waiting for completion? Most users of kthread_stop won't need it, but it would be nice here. CIFS could also

Re: Wondering about NLM_HOST_MAX ... doesn't anyone understand this code?

2008-02-07 Thread Jeff Layton
On Thu, 7 Feb 2008 14:32:56 +1100 Neil Brown [EMAIL PROTECTED] wrote: Hi, I've been looking at NLM_HOST_MAX in fs/lockd/host.c, as we have a patch in SLES that makes it configurable, and the patch needs to either go upstream or out the window... But the code that uses NLM_HOST_MAX is

Re: [PATCH 2/2] NLM: Convert lockd to use kthreads

2008-02-07 Thread Trond Myklebust
On Thu, 2008-02-07 at 06:37 -0500, Jeff Layton wrote: On Wed, 06 Feb 2008 18:01:16 -0500 Trond Myklebust [EMAIL PROTECTED] wrote: On Wed, 2008-02-06 at 14:09 -0500, Jeff Layton wrote: On Wed, 06 Feb 2008 13:52:34 -0500 Trond Myklebust [EMAIL PROTECTED] wrote: On Wed,

Re: Wondering about NLM_HOST_MAX ... doesn't anyone understand this code?

2008-02-07 Thread Chuck Lever
Hi Neil- I don't have a problem with removing the variant expiry behavior -- in fact, I think it might be better if NLM host garbage collection was done only under memory pressure. But see below. On Feb 6, 2008, at 10:32 PM, Neil Brown wrote: Hi, I've been looking at NLM_HOST_MAX in

Re: [NFS] troubles with nohide -- crossmnt

2008-02-07 Thread Jeff Layton
On Thu, 7 Feb 2008 22:36:05 +0100 Pascal A. Dupuis [EMAIL PROTECTED] wrote: Hello, I'd like to export two filesystems, mounted on one another. The setup is : some partition mounted as /home/user (parent) another oneas /home/user/archive (child) The export file contains:

[NFS] troubles with nohide -- crossmnt

2008-02-07 Thread Pascal A. Dupuis
Hello, I'd like to export two filesystems, mounted on one another. The setup is : some partition mounted as /home/user (parent) another oneas /home/user/archive (child) The export file contains: /home/user/archive 192.168.1.10(rw,subtree_check,fsid=0) /home/user

Re: [NFS] troubles with nohide -- crossmnt

2008-02-07 Thread Trond Myklebust
On Thu, 2008-02-07 at 17:52 -0500, J. Bruce Fields wrote: On Thu, Feb 07, 2008 at 05:38:20PM -0500, Steve Dickson wrote: Pascal A. Dupuis wrote: On Thu, Feb 07, 2008 at 04:41:10PM -0500, Jeff Layton wrote: /home/user/archive 192.168.1.10(rw,subtree_check,fsid=0)

Re: [NFS] troubles with nohide -- crossmnt

2008-02-07 Thread J. Bruce Fields
On Thu, Feb 07, 2008 at 06:13:28PM -0500, Trond Myklebust wrote: On Thu, 2008-02-07 at 17:52 -0500, J. Bruce Fields wrote: On Thu, Feb 07, 2008 at 05:38:20PM -0500, Steve Dickson wrote: Pascal A. Dupuis wrote: On Thu, Feb 07, 2008 at 04:41:10PM -0500, Jeff Layton wrote:

Re: [PATCH 00/10] RFC: NFS-related fs/Kconfig updates

2008-02-07 Thread J. Bruce Fields
On Tue, Feb 05, 2008 at 01:08:28PM -0500, Chuck Lever wrote: Another pass at cleaning up the NFS and NFSD entries in fs/Kconfig. Comments / suggestions? By the way, we've got another config-related nit here: http://bugzilla.linux-nfs.org/show_bug.cgi?id=156 You can build lockd

[PATCH 2/3] SUNRPC: have svc_recv() check kthread_should_stop()

2008-02-07 Thread Jeff Layton
When using kthreads that call into svc_recv, we want to make sure that they do not block there for a long time when we're trying to take down the kthread. This patch changes svc_recv() to check kthread_should_stop() at the same places that it checks to see if it's signalled(). Also check just

Re: [NFS] troubles with nohide -- crossmnt

2008-02-07 Thread Pascal A. Dupuis
On Thu, Feb 07, 2008 at 04:41:10PM -0500, Jeff Layton wrote: /home/user/archive 192.168.1.10(rw,subtree_check,fsid=0) /home/user 192.168.1.10(rw,subtree_check,fsid=0,crossmnt) You shouldn't have 2 exports with the same fsid= option. They should be different. I'd

Re: [PATCH 0/4] NLM: fix lockd hang when client blocking on released lock isn't responding

2008-02-07 Thread J. Bruce Fields
On Wed, Feb 06, 2008 at 11:34:09AM -0500, Jeff Layton wrote: This patchset fixes the problem that Bruce pointed out last week when we were discussing the lockd-kthread patches. The main problem is described in patch #1 and that patch also fixes the DoS. The remaining patches clean up how

Re: (fwd) nfs hang on 2.6.24

2008-02-07 Thread Andrew Dixie
I've already got a fix for this bug against 2.6.24. Could you see if it applies to your kernel too? Thanks for this. My client is 2.6.24 so it obviously applies. I don't believe the bug is in 2.6.18; and 2.6.22 crashes due to other problems before I can reproduce this hang. You didn't

Re: nfs new_cache mechanism and older kernel

2008-02-07 Thread Neil Brown
On Thursday February 7, [EMAIL PROTECTED] wrote: Hi: I am wondering if there is a known issue with using the newer cache mechanism in NFS (by mounting nfsd filesystem on /proc/fs/nfsd) on an older kernel like 2.6.17 built for 64 bit archs. I am observing a peculiar problem. The moment nfs

RE: nfs new_cache mechanism and older kernel

2008-02-07 Thread Anirban Sinha
Hi Neil: -Original Message- From: Neil Brown [mailto:[EMAIL PROTECTED] Sent: Thursday, February 07, 2008 4:46 PM To: Anirban Sinha Cc: linux-nfs@vger.kernel.org Subject: Re: nfs new_cache mechanism and older kernel On Thursday February 7, [EMAIL PROTECTED] wrote: Hi: I am

RE: nfs new_cache mechanism and older kernel

2008-02-07 Thread Neil Brown
On Thursday February 7, [EMAIL PROTECTED] wrote: Yeah, not sure if it would make any difference. I think one of them is the wall clock time (do_gettimeofday) and the xtime is the monotonic time. One can be obtained from other by adding/subtracting an offset value (wall_to_monotonic or

RE: nfs new_cache mechanism and older kernel

2008-02-07 Thread Neil Brown
On Thursday February 7, [EMAIL PROTECTED] wrote: Perfect! That was indeed the problem. Thank you so much. Btw, so when mountd starts, it checks whether or not the new cache mechanism is being used and acts accordingly, right? (I am being lazy by not going through the codebase to find that out

Re: Wondering about NLM_HOST_MAX ... doesn't anyone understand this code?

2008-02-07 Thread Neil Brown
On Thursday February 7, [EMAIL PROTECTED] wrote: Hi Neil- I don't have a problem with removing the variant expiry behavior -- in fact, I think it might be better if NLM host garbage collection was done only under memory pressure. Cool, thanks. - if (++nrhosts NLM_HOST_MAX) -

[PATCH] knfsd: Remove NLM_HOST_MAX and associated logic.

2008-02-07 Thread NeilBrown
Lockd caches information about hosts that have recently held locks it expedite the taking of further locks. It periodically discards this information for hosts that have not been used for a few minutes. lockd currently has a value NLM_HOST_MAX, and changes the 'garbage collection' behaviour

Re: nfs new_cache mechanism and older kernel

2008-02-07 Thread J. Bruce Fields
On Fri, Feb 08, 2008 at 12:10:46PM +1100, Neil Brown wrote: On Thursday February 7, [EMAIL PROTECTED] wrote: Yeah, not sure if it would make any difference. I think one of them is the wall clock time (do_gettimeofday) and the xtime is the monotonic time. One can be obtained from other by

RE: nfs new_cache mechanism and older kernel

2008-02-07 Thread Anirban Sinha
I know nothing about time. I suppose for proc/../flush to be a reasonable user interface the time source used should be something that makes sense to userland? We should not also forget that this timestamp is also used by the kernel (and compared with what is returned from get_seconds())