Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-20 Thread Miklos Szeredi
Please don't introduce a special case for just nfs. All filesystems should control their mount options, so please provide some library helpers for context= handling and move it into all filesystems that can support selinux. Hmm, looks like selinux is not showing it's mount options in

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-20 Thread Stephen Smalley
On Wed, 2008-02-20 at 11:25 +1100, James Morris wrote: On Tue, 19 Feb 2008, Christoph Hellwig wrote: Please don't introduce a special case for just nfs. All filesystems should control their mount options, so please provide some library helpers for context= handling and move it into all

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-20 Thread Stephen Smalley
On Wed, 2008-02-20 at 11:08 +0100, Miklos Szeredi wrote: Please don't introduce a special case for just nfs. All filesystems should control their mount options, so please provide some library helpers for context= handling and move it into all filesystems that can support selinux. Hmm,

[PATCH] NFS: convert nfs4 callback thread to kthread API

2008-02-20 Thread Jeff Layton
There's a general push to convert kernel threads to use the (much cleaner) kthread API. This patch converts the NFSv4 callback kernel thread to the kthread API. In addition to being generally cleaner this also removes the dependency on signals when shutting down the thread. Note that this patch

Re: [PATCH] NFS: flush signals before taking down callback thread

2008-02-20 Thread Jeff Layton
On Tue, 19 Feb 2008 17:43:30 -0500 Trond Myklebust [EMAIL PROTECTED] wrote: On Tue, 2008-02-19 at 17:22 -0500, Christoph Hellwig wrote: Wouldn't it be better to not allow for signals to this thread at all? The code really begs for a similar kthread conversion as the lockd one. I'd

Re: [PATCH] NFS: flush signals before taking down callback thread

2008-02-20 Thread Trond Myklebust
On Wed, 2008-02-20 at 09:01 -0500, Jeff Layton wrote: I did a bit of smoke testing on that patch this morning and just sent it out to the list. The only problem is that that patch depends on a couple of other patches currently in Bruce's tree and that are slated for 2.6.26. It might be

Re: [PATCH] NFS: convert nfs4 callback thread to kthread API

2008-02-20 Thread Trond Myklebust
On Wed, 2008-02-20 at 08:55 -0500, Jeff Layton wrote: There's a general push to convert kernel threads to use the (much cleaner) kthread API. This patch converts the NFSv4 callback kernel thread to the kthread API. In addition to being generally cleaner this also removes the dependency on

Re: [PATCH] sunrpc: GSS integrity and decryption failures should return GARBAGE_ARGS

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 10:56:56AM +1100, Harshula wrote: Hi Bruce, On Tue, 2008-02-19 at 12:44 -0500, J. Bruce Fields wrote: Your mailer seems to be wrapping long lines? This makes the patch not apply. And tabs are getting changed to spaces everywhere too Would it be

Re: [PATCH] NFS: convert nfs4 callback thread to kthread API

2008-02-20 Thread Trond Myklebust
On Wed, 2008-02-20 at 10:15 -0500, J. Bruce Fields wrote: On Wed, Feb 20, 2008 at 10:09:23AM -0500, Trond Myklebust wrote: On Wed, 2008-02-20 at 08:55 -0500, Jeff Layton wrote: There's a general push to convert kernel threads to use the (much cleaner) kthread API. This patch converts

[no subject]

2008-02-20 Thread Sagar Borikar
unsubscribe - To unsubscribe from this list: send the line unsubscribe linux-nfs in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] lockd: fix race in nlm_release()

2008-02-20 Thread J. Bruce Fields
From: J. Bruce Fields [EMAIL PROTECTED] The sm_count is decremented to zero but left on the nsm_handles list. So in the space between decrementing sm_count and acquiring nsm_mutex, it is possible for another task to find this nsm_handle, increment the use count and then enter nsm_release itself.

Re: [Fwd: Re: Linux 2.6.25-rc2]

2008-02-20 Thread J. Bruce Fields
On Tue, Feb 19, 2008 at 07:00:51PM +1100, Greg Banks wrote: Tom Tucker wrote: Bruce: I'll take a look... Tom On Mon, 2008-02-18 at 12:45 -0500, J. Bruce Fields wrote: On Sun, Feb 17, 2008 at 04:02:45PM -0500, Trond Myklebust wrote: Hi Bruce, Here is a question

Re: [PATCH] lockd: fix race in nlm_release()

2008-02-20 Thread Trond Myklebust
On Wed, 2008-02-20 at 14:11 -0500, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] The sm_count is decremented to zero but left on the nsm_handles list. So in the space between decrementing sm_count and acquiring nsm_mutex, it is possible for another task to find this

Re: [PATCH] lockd: fix race in nlm_release()

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 02:24:26PM -0500, Trond Myklebust wrote: On Wed, 2008-02-20 at 14:11 -0500, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] The sm_count is decremented to zero but left on the nsm_handles list. So in the space between decrementing sm_count and

Re: [PATCH] lockd: fix race in nlm_release()

2008-02-20 Thread Trond Myklebust
On Wed, 2008-02-20 at 14:27 -0500, J. Bruce Fields wrote: On Wed, Feb 20, 2008 at 02:24:26PM -0500, Trond Myklebust wrote: On Wed, 2008-02-20 at 14:11 -0500, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] The sm_count is decremented to zero but left on the

Re: [PATCH] lockd: fix race in nlm_release()

2008-02-20 Thread Chuck Lever
On Feb 20, 2008, at 2:48 PM, Trond Myklebust wrote: On Wed, 2008-02-20 at 14:27 -0500, J. Bruce Fields wrote: On Wed, Feb 20, 2008 at 02:24:26PM -0500, Trond Myklebust wrote: On Wed, 2008-02-20 at 14:11 -0500, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] The sm_count is

mountd prevents spindown of non-exported disk

2008-02-20 Thread Timo Reimann
Hi all, I have two disks in my server, one of them (hda) being used for backups solely. To reduce noise level and power consumption, I have been trying to keep it running in standby mode (as opposed to active) most of the time. Although there should be nothing accessing the disk except my custom

Re: [PATCH] lockd: fix race in nlm_release()

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 05:10:24PM -0500, Chuck Lever wrote: On Feb 20, 2008, at 2:48 PM, Trond Myklebust wrote: Just the usual plea to replace the host-h_server flag with 2 separate lists: one list of client nlm_hosts, and one list of server nlm_hosts :-) I have no objection to that, but my

Re: mountd prevents spindown of non-exported disk

2008-02-20 Thread Neil Brown
On Wednesday February 20, [EMAIL PROTECTED] wrote: Hi all, I have two disks in my server, one of them (hda) being used for backups solely. To reduce noise level and power consumption, I have been trying to keep it running in standby mode (as opposed to active) most of the time. Although

Re: Strange lockup during unmount in 2.6.22 - maybe rpciod deadlock?

2008-02-20 Thread Neil Brown
On Tuesday February 19, [EMAIL PROTECTED] wrote: On Tue, 2008-02-19 at 16:34 +1100, Neil Brown wrote: On Thursday January 10, [EMAIL PROTECTED] wrote: On Fri, 2008-01-11 at 08:51 +1100, Neil Brown wrote: I have a report of an unusual NFS deadlock in OpenSuSE 10.3, which is

Re: Strange lockup during unmount in 2.6.22 - maybe rpciod deadlock?

2008-02-20 Thread Neil Brown
On Tuesday February 19, [EMAIL PROTECTED] wrote: How about moving the offending mntput calls off rpciod altogether? That way we can avoid both the deadlock with rpc_shutdown_client() and the deadlock with nfs_put_super(). The other advantage of doing this is that we move all those deadlocky

compound header status

2008-02-20 Thread Halevy, Benny
Trond, we had a discussion today in Austin about the COMPOUND result header status. Looking at fs/nfs/nfs4xdr.c we saw that some decoding routines return an error based on hdr.status after all the compound operations decoding completed successfully. For example: static int