[PATCH] Wrap buffers used for rpc debug printks into RPC_IFDEBUG

2008-02-21 Thread Pavel Emelyanov
Sorry for the noise, but here's the v3 of this compilation fix :) There are some places, which declare the char buf[...] on the stack to push it later into dprintk(). Since the dprintk sometimes (if the CONFIG_SYSCTL=n) becomes an empty do { } while (0) stub, these buffers cause gcc to produce

Re: Strange lockup during unmount in 2.6.22 - maybe rpciod deadlock?

2008-02-21 Thread Jeff Layton
On Thu, 21 Feb 2008 15:58:34 +1100 Neil Brown [EMAIL PROTECTED] wrote: My question is: *why* cannot rpc_shutdown_client complete until all active rpc_tasks complete? The use of reference counting ensure that once they do all complete, the client will be finally released and any relevant

Re: [PATCH] lockd: fix race in nlm_release()

2008-02-21 Thread Peter Staubach
J. Bruce Fields wrote: On Wed, Feb 20, 2008 at 02:48:38PM -0500, Trond Myklebust wrote: On Wed, 2008-02-20 at 14:27 -0500, J. Bruce Fields wrote: On Wed, Feb 20, 2008 at 02:24:26PM -0500, Trond Myklebust wrote: On Wed, 2008-02-20 at 14:11 -0500, J. Bruce Fields wrote:

Re: Strange lockup during unmount in 2.6.22 - maybe rpciod deadlock?

2008-02-21 Thread Trond Myklebust
On Thu, 2008-02-21 at 15:58 +1100, Neil Brown wrote: My question is: *why* cannot rpc_shutdown_client complete until all active rpc_tasks complete? The use of reference counting ensure that once they do all complete, the client will be finally released and any relevant modules will also be

[PATCH 00/19] RFC add kernel support for newer encrytpion types

2008-02-21 Thread Kevin Coffman
Consider this an RFC. These patches add kernel support for triple-DES and AES encryption to the Kerberos gss code. These are currently built on 2.6.25-rc1, but I think they should apply to the latest code as well. The first patch adds a crypto cts wrapper to do the cts mode req'd by AES. This

[PATCH 02/19] rpc: gss: Add oid values to the gss_api mechanism structures

2008-02-21 Thread Kevin Coffman
From: Usha Ketineni [EMAIL PROTECTED] On NFSV4 server side, these are required as part of the security triple(oid,qop,service) information being sent in the response of the SECINFO operation. Signed-off-by: Usha Ketineni [EMAIL PROTECTED] Signed-off-by: J. Bruce Fields [EMAIL PROTECTED] ---

[PATCH 03/19] sunrpc: make token header values less confusing

2008-02-21 Thread Kevin Coffman
g_make_token_header() and g_token_size() add two too many, and therefore their callers pass in (logical_value - 2) rather than logical_value as hard-coded values which causes confusion. This dates back to the original g_make_token_header which took an optional token type (token_id) value and

[PATCH 06/19] Use get_random_bytes() to create confounder

2008-02-21 Thread Kevin Coffman
Instead of using an incementing value for the confounder, use get_random_bytes() which gives us the desired unpredictable value. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- net/sunrpc/auth_gss/gss_krb5_wrap.c | 15 +-- 1 files changed, 1 insertions(+), 14 deletions(-) diff

[PATCH 07/19] Don't expect blocksize to always be 8 when calculating padding

2008-02-21 Thread Kevin Coffman
Allow blocksizes other than 8 when calculating padding Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- net/sunrpc/auth_gss/gss_krb5_wrap.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/net/sunrpc/auth_gss/gss_krb5_wrap.c b/net/sunrpc/auth_gss/gss_krb5_wrap.c

[PATCH 08/19] Remove define for KRB5_CKSUM_LENGTH, which will become enctype-dependent

2008-02-21 Thread Kevin Coffman
cleanup: When adding new encryption types, the checksum length can be different for each enctype. Face the fact that the current code only supports DES which has a checksum length of 8. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/gss_krb5.h |2 --

[PATCH 09/19] gss_krb5: split up functions in preparation of adding new enctypes

2008-02-21 Thread Kevin Coffman
Add encryption type to the krb5 context structure and use it to switch to the correct functions depending on the encryption type. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/gss_krb5.h |1 + net/sunrpc/auth_gss/gss_krb5_mech.c |1 +

[PATCH 11/19] gss_krb5: introduce encryption type framework

2008-02-21 Thread Kevin Coffman
Add enctype framework and change functions to use the generic values from it rather than the values hard-coded for des. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/gss_krb5.h | 29 +++ net/sunrpc/auth_gss/gss_krb5_crypto.c | 16 +++---

[PATCH 12/19] gss_krb5: add ability to have a keyed checksum (hmac)

2008-02-21 Thread Kevin Coffman
Encryption types besides DES may use a keyed checksum (hmac). Modify the make_checksum() function to allow for a key and take care of enctype-specific processing such as truncating the resulting hash. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/gss_krb5.h |

[PATCH 13/19] gss_krb5: import functionality to derive keys into the kernel

2008-02-21 Thread Kevin Coffman
Import the code to derive Kerberos keys from a base key into the kernel. This will allow us to change the format of the context information sent down from gssd to include only a single key. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/gss_krb5.h | 30

[PATCH 15/19] gss_krb5: handle new context format from gssd

2008-02-21 Thread Kevin Coffman
For encryption types other than DES, gssd sends down context information in a new format. This new format includes the information needed to support the new Kerberos GSS-API tokens defined in rfc4121. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/gss_krb5.h | 19

[PATCH 16/19] gss_krb5: add support for triple-des encryption

2008-02-21 Thread Kevin Coffman
Add the final pieces to support the triple-des encryption type. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/gss_krb5.h |4 ++ net/sunrpc/auth_gss/gss_krb5_crypto.c |3 ++ net/sunrpc/auth_gss/gss_krb5_keys.c | 53 +

[PATCH 17/19] xdr: add a new utility function to shift the head data of an xdr buffer

2008-02-21 Thread Kevin Coffman
Add a new xdr helper function that shifts the data in an xdr buffer's head to make room for new data. Also add an export for the helper function write_bytes_to_xdr_buf(). Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/xdr.h |2 ++ net/sunrpc/xdr.c | 29

[PATCH 18/19] gss_krb5: add support for new token formats in rfc4121

2008-02-21 Thread Kevin Coffman
This is a step toward support for AES encryption types which are required to use the new token formats defined in rfc4121. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/gss_krb5.h | 28 net/sunrpc/auth_gss/gss_krb5_crypto.c | 71 +

[PATCH 19/19] gss_krb5: add remaining pieces to enable AES encryption support

2008-02-21 Thread Kevin Coffman
Add the remaining pieces to enable support for Kerberos AES encryption types. Signed-off-by: Kevin Coffman [EMAIL PROTECTED] --- include/linux/sunrpc/gss_krb5.h | 12 + net/sunrpc/auth_gss/gss_krb5_crypto.c | 307 + net/sunrpc/auth_gss/gss_krb5_keys.c

Re: compound header status

2008-02-21 Thread Trond Myklebust
On Thu, 2008-02-21 at 00:18 -0500, Halevy, Benny wrote: Trond, we had a discussion today in Austin about the COMPOUND result header status. Looking at fs/nfs/nfs4xdr.c we saw that some decoding routines return an error based on hdr.status after all the compound operations decoding completed

Re: [PATCH] Wrap buffers used for rpc debug printks into RPC_IFDEBUG

2008-02-21 Thread Trond Myklebust
On Thu, 2008-02-21 at 10:57 +0300, Pavel Emelyanov wrote: Sorry for the noise, but here's the v3 of this compilation fix :) There are some places, which declare the char buf[...] on the stack to push it later into dprintk(). Since the dprintk sometimes (if the CONFIG_SYSCTL=n) becomes an

Re: [PATCH] Wrap buffers used for rpc debug printks into RPC_IFDEBUG

2008-02-21 Thread J. Bruce Fields
On Thu, Feb 21, 2008 at 04:45:22PM -0500, Trond Myklebust wrote: On Thu, 2008-02-21 at 10:57 +0300, Pavel Emelyanov wrote: Sorry for the noise, but here's the v3 of this compilation fix :) There are some places, which declare the char buf[...] on the stack to push it later into

Re: [pnfs] compound header status

2008-02-21 Thread Benny Halevy
On Feb. 21, 2008, 15:15 -0600, Trond Myklebust [EMAIL PROTECTED] wrote: On Thu, 2008-02-21 at 00:18 -0500, Halevy, Benny wrote: Trond, we had a discussion today in Austin about the COMPOUND result header status. Looking at fs/nfs/nfs4xdr.c we saw that some decoding routines return an error

travelling, nfsd patches

2008-02-21 Thread J. Bruce Fields
By the way, I'm travelling for two weeks starting tommorow, so I may be less responsive than usual. I should still be online intermittently, but if a patch is particularly urgent, please make sure that it's marked as such (and that other people are cc'd). Thanks! --b. - To unsubscribe from this

Re: mountd prevents spindown of non-exported disk

2008-02-21 Thread Neil Brown
On Thursday February 21, [EMAIL PROTECTED] wrote: You could always build your own nfs-utils and configure with --without-uuid. Not an ideal solution... What would be the downside of that solution? I suppose NFS would keep on working even if I disabled that switch, but you gave the

Re: Strange lockup during unmount in 2.6.22 - maybe rpciod deadlock?

2008-02-21 Thread Neil Brown
On Thursday February 21, [EMAIL PROTECTED] wrote: On Thu, 2008-02-21 at 15:58 +1100, Neil Brown wrote: My question is: *why* cannot rpc_shutdown_client complete until all active rpc_tasks complete? The use of reference counting ensure that once they do all complete, the client will be

[GIT] Please pull NFS client fixes for 2.6.25-rc2

2008-02-21 Thread Trond Myklebust
Hi Linus, Please pull from the hotfixes branch of the repository at git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git hotfixes This will update the following files through the appended changesets. Cheers, Trond fs/lockd/svc.c|2 +- fs/nfs/callback.c

[NFS] [PATCH] Fix nfsstat --mounted

2008-02-21 Thread Peng Haitao
Execute command nfsstat --mounted will print the error message nfsstat: unrecognized option `--mounted'. Package: nfs-utils Version: 1.1.1 Signed-off-by: Peng Haitao [EMAIL PROTECTED] Index: nfs-utils-1.1.1/utils/nfsstat/nfsstat.c

RE: nfs performance dropped when using 128 MB RAM

2008-02-21 Thread Sagar Borikar
Folks, Ok, I was able to crack the issue but in some odd way. I found that pdflush was not able to flush the buffers in time because of which the next write requests were stalled at the client side. I did following changes to improve the performance. 1. Changed the number of pdflush threads

Re: [PATCH] NFS: convert nfs4 callback thread to kthread API

2008-02-21 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 08:55:30AM -0500, Jeff Layton wrote: There's a general push to convert kernel threads to use the (much cleaner) kthread API. This patch converts the NFSv4 callback kernel thread to the kthread API. In addition to being generally cleaner this also removes the dependency