Re: [PATCH] nilfs2: delete unnecessary condition in load_segment_summary

2010-02-18 Thread Ryusuke Konishi
-by: Jiro SEKIBA j...@unicus.jp Applied, thank you. Ryusuke Konishi --- fs/nilfs2/recovery.c | 41 +++-- 1 files changed, 11 insertions(+), 30 deletions(-) diff --git a/fs/nilfs2/recovery.c b/fs/nilfs2/recovery.c index c9c96c7..017bedc 100644 --- a/fs

Re: [PATCH] nilfs2: add reader's lock for cno in nilfs_ioctl_sync

2010-02-20 Thread Ryusuke Konishi
; + down_read(nilfs-ns_segctor_sem); + cno = nilfs-ns_cno - 1; + up_read(nilfs-ns_segctor_sem); if (copy_to_user(argp, cno, sizeof(cno))) return -EFAULT; } -- 1.5.6.5 Right, this should be applied. Thanks. Ryusuke Konishi

Re: [PATCH] nilfs: fix unprotected super_block flags modification in nilfs_error

2010-03-06 Thread Ryusuke Konishi
a potential for recursive locking since nilfs_error() can be called from within nilfs_remount() that locks ns_super_sem. It seems unfavorable though the above sb-s_flags operation is not protected. I hope we can find a simple and better workaround. Regards, Ryusuke Konishi -- To unsubscribe from

Re: NILFS 2.0.19 and NILFS utils 2.0.16 released

2010-03-13 Thread Ryusuke Konishi
On Sat, 13 Mar 2010 17:04:13 +0900, Jiro SEKIBA wrote: Hi, At Sat, 13 Mar 2010 15:06:12 +0900 (JST), Ryusuke Konishi wrote: Hi, I have released nilfs-2.0.19 and nilfs-utils-2.0.16. I found that COPYING of nilfs-utils is now GPL v3. I've checked older version. Until 2.0.14

Re: NILFS 2.0.19 and NILFS utils 2.0.16 released

2010-03-13 Thread Ryusuke Konishi
2010/3/13 Ryusuke Konishi ryus...@osrg.net: On Sat, 13 Mar 2010 17:04:13 +0900, Jiro SEKIBA wrote: Hi, At Sat, 13 Mar 2010 15:06:12 +0900 (JST), Ryusuke Konishi wrote: Hi, I have released nilfs-2.0.19 and nilfs-utils-2.0.16. I found that COPYING of nilfs-utils is now GPL v3. I've

[PATCH 4/6] nilfs2: fix various typos in comments

2010-03-13 Thread Ryusuke Konishi
This fixes various typos I found in comments of nilfs2. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/alloc.h |2 +- fs/nilfs2/dat.c |2 +- fs/nilfs2/gcinode.c |4 ++-- fs/nilfs2/page.c|4 ++-- fs/nilfs2/segbuf.c |2 +- fs/nilfs2

Re: cleaner: run one cleaning pass based on minimum free space

2010-03-15 Thread Ryusuke Konishi
, David Arendt Thanks, Ryusuke Konishi On 03/14/10 15:28, Ryusuke Konishi wrote: Hi, On Sun, 14 Mar 2010 14:00:19 +0100, ad...@prnet.org wrote: Hi, I will try to implement this myself then. Concerning the nilfs_cleanerd_select segments function I was unclear in my post. In fact I

Re: cleaner: run one cleaning pass based on minimum free space

2010-03-17 Thread Ryusuke Konishi
is limited by a ceiling.) But, I agree that the notation is suited for such threshold parameters. Regards, Ryusuke Konishi For the rest, I think everything should be clear and I should have a patch ready in a few days. Bye, David Arendt On 03/15/10 16:58, Ryusuke Konishi wrote: Hi

Re: nilfs_sufile_do_cancel_free: segment 0 must be clean

2010-03-22 Thread Ryusuke Konishi
as well. Please keep me CCed, I'm not on the list. Andreas Thank you for the detail report! I could reproduce the both problems (i.e. the warnings on nilfs_sufile_do_cancel_free and the hang of cleaner process) by a manual fault injection test. Will look into these issues. Ryusuke

Re: [PATCH 1/2] nilfs2: Combine nilfs_btree_alloc_path() and nilfs_btree_init_path()

2010-04-02 Thread Ryusuke Konishi
On Fri, 2 Apr 2010 21:36:05 +0800, Li Hong lihong...@gmail.com wrote: Hi Ryusuke Konishi, Sorry. The patches passed checkpatch.pl now. Send them again. Thanks, Li Hong Ok, will queue the new ones. Thanks, Ryusuke Konishi From bbb2fd5b906dbae1cee759549cb24678e41f824c Mon Sep 17 00:00

[PATCH 2/2] nilfs2: move out checksum routines to segment buffer code

2010-04-02 Thread Ryusuke Konishi
This moves out checksum routines in log writer to segbuf.c for cleanup. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/segbuf.c | 39 +++ fs/nilfs2/segbuf.h |3 +-- fs/nilfs2/segment.c | 33

[PATCH 1/2] nilfs2: move pointer to super root block into logs

2010-04-02 Thread Ryusuke Konishi
This moves a pointer to buffer storing super root block to each log buffer from nilfs_sc_info struct for simplicity. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/segbuf.c |2 ++ fs/nilfs2/segbuf.h |2 ++ fs/nilfs2/segment.c | 45

Re: Writes doubled by NILFS2

2010-04-20 Thread Ryusuke Konishi
Hi, On Tue, 20 Apr 2010 17:39:13 +0900, Yongkun Wang yong...@tkl.iis.u-tokyo.ac.jp wrote: Hey, guys, We have a database system, the data is stored on the disk formatted with NILFS2 (nilfs-2.0.15, kmod-nilfs-2.0.5-1.2.6.18_92.1.22.el5.x86_64). I have run a trace at the system call level

Re: Segment magic number invalid

2010-05-15 Thread Ryusuke Konishi
. With regards, Ryusuke Konishi From b1a403ed4a7cb6987052729075255d5d893bebdb Mon Sep 17 00:00:00 2001 From: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp Date: Sat, 15 May 2010 12:33:27 +0900 Subject: [PATCH] nilfs2-utils: add test tool to correct log pointer in super block Signed-off-by: Ryusuke

Re: Segment magic number invalid

2010-05-19 Thread Ryusuke Konishi
be implemented by changing spec of the dupsb argument of nilfs_commit_super to other one from both (dupsb). Can you make draft patches? Thanks, Ryusuke Konishi -- To unsubscribe from this list: send the line unsubscribe linux-nilfs in the body of a message to majord...@vger.kernel.org More majordomo

[GIT PULL] nilfs2 updates for 2.6.35

2010-05-21 Thread Ryusuke Konishi
of when critical metadata inconsistency was found. * Enlarged filesystem label. * An extension of log header format in order to ensure that diagnostic tool or fsck obtains checkpoint number from on-disk logs. But no influential change is made. Thanks, Ryusuke Konishi -- The following changes

[PATCH 1/6] nilfs2: add blocksize member to nilfs object

2010-05-24 Thread Ryusuke Konishi
This stores blocksize in nilfs objects for the successive refactoring of recovery logic. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/the_nilfs.c |1 + fs/nilfs2/the_nilfs.h |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/nilfs2

[PATCH 2/6] nilfs2: refactor recovery logic routines

2010-05-24 Thread Ryusuke Konishi
Most functions in recovery code take an argument of a super block instance or a nilfs_sb_info struct for convenience sake. This replaces them aggressively with a nilfs object by applying __bread and __breadahead against routines using sb_bread and sb_breadahead. Signed-off-by: Ryusuke Konishi

[PATCH 6/6] nilfs2: get rid of macros for segment summary information

2010-05-24 Thread Ryusuke Konishi
This removes macros to test segment summary flags and redefines a few relevant macros with inline functions. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/segbuf.h | 24 +--- fs/nilfs2/segment.c |8 2 files changed, 17 insertions

Re: TRIM Support?

2010-05-25 Thread Ryusuke Konishi
) was merged at linux-2.6.34. Cheers, Ryusuke Konishi -- To unsubscribe from this list: send the line unsubscribe linux-nilfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: gentoo amd64 based bootable cd with latest kernel and nilfs2 utils

2010-05-26 Thread Ryusuke Konishi
On Wed, 26 May 2010 08:05:40 +0900, Jiro SEKIBA wrote: Hi, At Tue, 25 May 2010 03:30:32 +0900 (JST), Ryusuke Konishi wrote: Hi, On Mon, 24 May 2010 17:11:51 +0200, David Arendt wrote: Hi, In order to facilate problem solving for the case my system using nilfs2 as root

Re: [PATCH] nilfs2: sync super blokcs in turns

2010-06-02 Thread Ryusuke Konishi
Hi, On Fri, 28 May 2010 11:29:04 +0900, Jiro SEKIBA wrote: At Fri, 28 May 2010 01:59:59 +0900 (JST), Ryusuke Konishi wrote: Hi, On Thu, 27 May 2010 16:27:22 +0900, Jiro SEKIBA wrote: Hi, This is a proposed patch to sync super blocks by turn. It still require recovery action

Re: [PATCH 2/2] nilfs2: sync super blocks in turns

2010-06-07 Thread Ryusuke Konishi
); + } up_write(nilfs-ns_sem); return err; -- 1.5.6.5 Thanks, Ryusuke Konishi -- To unsubscribe from this list: send the line unsubscribe linux-nilfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] nilfs2: asynchronous super block updates

2010-06-08 Thread Ryusuke Konishi
nilfs_write_log_cursor to advance log cursor for one of super blocks. This patch also define a macro that generates inline function to update information both super blocks for convenience. Ahh, this series doesn't apply as is. Could you rebase it onto the for-next branch ? Thanks, Ryusuke Konishi

Re: [PATCH 1/2] nilfs2: introduce nilfs_prepare_super

2010-06-12 Thread Ryusuke Konishi
+ err = -EIO; Ditto. You can use braces for this else clause. Or you can remove the else clause by moving the substitution before calling nilfs_prepare_super. up_write(nilfs-ns_sem); if (err) { -- 1.5.6.5 Thanks, Ryusuke Konishi -- To unsubscribe from this list

Re: [PATCH 2/2] nilfs2: sync super blocks in turns

2010-06-12 Thread Ryusuke Konishi
*); void put_nilfs(struct the_nilfs *); -- 1.5.6.5 Thanks, Ryusuke Konishi -- To unsubscribe from this list: send the line unsubscribe linux-nilfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv3 2/2] nilfs2: sync super blocks in turns

2010-06-20 Thread Ryusuke Konishi
. Will queue them up for the next merge window. Thanks, Ryusuke Konishi --- fs/nilfs2/nilfs.h | 10 fs/nilfs2/segment.c |9 ++- fs/nilfs2/super.c | 128 - fs/nilfs2/the_nilfs.c |8 ++- fs/nilfs2/the_nilfs.h | 17 ++- 5

Re: CentOS 5 support for nilfs

2010-06-26 Thread Ryusuke Konishi
for the CentOS 5 series. Or, do you have any problems for them ? http://www.nilfs.org/pub/centos/5/RPMS/i386/nilfs-utils-2.0.18-3.i386.rpm http://www.nilfs.org/pub/centos/5/RPMS/x86_64/nilfs-utils-2.0.18-3.x86_64.rpm These include the release on April 10. Regards, Ryusuke Konishi -- To unsubscribe

[PATCHv5 1/5] nilfs2: add nilfs_cleanup_super

2010-06-28 Thread Ryusuke Konishi
This function write out filesystem state to super blocks in order to share the same cleanup work. This is a preparation for making super block writeback alternately. Cc: Jiro SEKIBA j...@unicus.jp Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/nilfs.h |1

[PATCHv5 0/5] nilfs2: asynchronous sb update

2010-06-28 Thread Ryusuke Konishi
++--- fs/nilfs2/the_nilfs.c |9 +- fs/nilfs2/the_nilfs.h | 17 ++-- 5 files changed, 183 insertions(+), 82 deletions(-) Regards, Ryusuke Konishi -- To unsubscribe from this list: send the line unsubscribe linux-nilfs in the body of a message

[PATCHv5 3/5] nilfs2: separate function that updates log position

2010-06-28 Thread Ryusuke Konishi
This moves out section that updates information of the recent log position stored in super blocks from nilfs_commit_super to a new routine named nilfs_set_log_cursor. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/nilfs.h |2 ++ fs/nilfs2/super.c | 30

[PATCHv5 2/5] nilfs2: add nilfs_set_error

2010-06-28 Thread Ryusuke Konishi
This function marks error state and write it on super blocks. This is a preparation for making super block writeback alternately. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/super.c | 24 ++-- 1 files changed, 14 insertions(+), 10 deletions

[PATCHv5 4/5] nilfs2: introduce nilfs_prepare_super

2010-06-28 Thread Ryusuke Konishi
...@unicus.jp Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/nilfs.h |1 + fs/nilfs2/segment.c |8 - fs/nilfs2/super.c | 73 +++--- 3 files changed, 58 insertions(+), 24 deletions(-) diff --git a/fs/nilfs2/nilfs.h b

[PATCHv5 5/5] nilfs2: sync super blocks in turns

2010-06-28 Thread Ryusuke Konishi
clean flag to both super blocks if they point to the same checkpoint. To update both of super block information, caller of nilfs_commit_super must set the information on both super blocks. Signed-off-by: Jiro SEKIBA j...@unicus.jp Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs

Re: CentOS 5 support for nilfs

2010-06-29 Thread Ryusuke Konishi
project members. I'll share this issue with him. I was checking this page instead of the actual download site for new updates. Thanks, Nick Thanks, Ryusuke Konishi -- To unsubscribe from this list: send the line unsubscribe linux-nilfs in the body of a message to majord...@vger.kernel.org More

[PATCH] nilfs2: remove BKL uses

2010-07-03 Thread Ryusuke Konishi
Nilfs has BKL uses in its put_super and remount functions, but none of them are necessary, just came from earlier push downs. This eliminates the BKL uses from nilfs. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/ioctl.c |1 - fs/nilfs2/super.c |9

[PATCH 0/5] nilfs2: sanitize mount options and remount checks

2010-07-05 Thread Ryusuke Konishi
proper check of mount options depending on the caller's context (i.e. new mount or remount). Finally, the nilfs2: get rid of nilfs_mount_options struct is just a cleanup which became possible by the previous change. I will queue this series for linux next. Thanks, Ryusuke Konishi -- Ryusuke

[PATCH 3/5] nilfs2: use seq_puts to print mount options without argument

2010-07-05 Thread Ryusuke Konishi
This replaces seq_printf() with seq_puts() in nilfs_show_options for mount options which have no argument. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/super.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/nilfs2/super.c b/fs

[PATCH 5/5] nilfs2: get rid of nilfs_mount_options struct

2010-07-05 Thread Ryusuke Konishi
This removes nilfs_mount_options structure and simplifies restoration of mount options in remount function. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/sb.h|8 fs/nilfs2/super.c |8 +++- 2 files changed, 3 insertions(+), 13 deletions

[PATCH 1/5] nilfs2: add barrier mount option

2010-07-05 Thread Ryusuke Konishi
Nilfs enables write barriers by default and has nobarrier mount option to disable this feature. But it lacks the complementary option and has no way to re-enable the feature on remount. This adds barrier option to resolve this imbalance. Signed-off-by: Ryusuke Konishi konishi.ryus

Re: [PATCH] nilfs2: remove BKL uses

2010-07-05 Thread Ryusuke Konishi
On Mon, 5 Jul 2010 16:53:29 +0200, Frederic Weisbecker wrote: On Mon, Jul 05, 2010 at 04:50:23PM +0200, Arnd Bergmann wrote: On Sunday 04 July 2010, Ryusuke Konishi wrote: Nilfs has BKL uses in its put_super and remount functions, but none of them are necessary, just came from earlier

Re: problem with nilfs_cleanerd

2010-07-07 Thread Ryusuke Konishi
the defect if the oops comes from a range error. I'm now reviewing the btree code to find out root cause of the range error. Thanks, Ryusuke Konishi --- diff --git a/fs/btree.c b/fs/btree.c index beb11fe..9622ff4 100644 --- a/fs/btree.c +++ b/fs/btree.c @@ -2007,6 +2007,15 @@ static void

Re: problem with nilfs_cleanerd

2010-07-07 Thread Ryusuke Konishi
On Wed, 07 Jul 2010 15:02:25 +0900 (JST), Ryusuke Konishi wrote: Hi, On Tue, 06 Jul 2010 11:02:41 +0200, Łukasz_Wójcicki wrote: I'am using kernel 2.6.20 with nilf_utils-2-0-18 and nilfs kernel module 2-0-20 . 1Unable to handle kernel NULL pointer dereference at virtual address

Re: problem with nilfs_cleanerd - part 2

2010-07-07 Thread Ryusuke Konishi
that ? Regards, Ryusuke Konishi N�r��yb�X��ǧv�^�)޺{.n�+{��)_�)w*jg����ݢj/���z�ޖ��2�ޙ�)ߡ�a�����G���h��j:+v���w��٥

[PATCH] nilfs2: add sanity check in nilfs_btree_add_dirty_buffer

2010-07-07 Thread Ryusuke Konishi
bug. This inserts a sanity check to figure out the problem. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/btree.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c index b27a342..3863567 100644

Re: How to turn off checkpoints

2010-07-08 Thread Ryusuke Konishi
(CCed to linux-nilfs) jcicki wrote: Is it possible to disable checkpoints ? Łukasz Wójcicki No, checkpointing is essential for nilfs disk write. Regards, Ryusuke Konishi -- To unsubscribe from this list: send the line unsubscribe linux-nilfs in the body of a message to majord

[PATCH 1/6] nilfs2: get rid of private conversion macros on bmap key and pointer

2010-07-10 Thread Ryusuke Konishi
Will remove nilfs_bmap_key_to_dkey(), nilfs_bmap_dkey_to_key(), nilfs_bmap_ptr_to_dptr(), and nilfs_bmap_dptr_to_ptr() for simplicity. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/bmap.h |5 - fs/nilfs2/btree.c | 34

[PATCH 2/6] nilfs2: remove constant qualifier from argument of bmap propagate

2010-07-10 Thread Ryusuke Konishi
The first argument of bops-bop_propagate operation takes a constant qualifier, and causes compilation error when removed cast to pointer of nilfs_btree structure type. This fixes the issue to prepare for succesive removal of nilfs_btree struct. Signed-off-by: Ryusuke Konishi konishi.ryus

[PATCH 5/6] nilfs2: unify bmap set_target_v operations

2010-07-10 Thread Ryusuke Konishi
This unifies two similar functions nilfs_btree_set_target_v and nilfs_direct_set_target_v into one, nilfs_bmap_set_target_v. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/bmap.h |7 +++ fs/nilfs2/btree.c | 11 ++- fs/nilfs2/direct.c |9

[PATCH 0/6] nilfs2 bmap cleanups

2010-07-10 Thread Ryusuke Konishi
, nilfs_direct, and nilfs_bmap_union. These patches allow removal of nilfs_bmap_union.h file and eliminate pointer casts among these structures. Ryusuke Konishi -- Ryusuke Konishi (6): nilfs2: get rid of private conversion macros on bmap key and pointer nilfs2: remove constant qualifier from

[PATCH 6/6] nilfs2: get rid of nilfs_bmap_union

2010-07-10 Thread Ryusuke Konishi
This removes nilfs_bmap_union and finally unifies three structures and the union in bmap/btree code into one. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/bmap.c |6 -- fs/nilfs2/bmap_union.h | 42 -- fs/nilfs2

[PATCH 4/6] nilfs2: get rid of nilfs_btree uses

2010-07-10 Thread Ryusuke Konishi
This replaces all uses of nilfs_btree struct in implementation of btree mapping with nilfs_bmap struct. Name of local variable btree is kept not to bloat amount of change. And, a part of local variables bmap is renamed to btree to uniform naming rule. Signed-off-by: Ryusuke Konishi konishi.ryus

[PATCH 1/5] nilfs2: remove redundant pointer checks in bmap lookup functions

2010-07-13 Thread Ryusuke Konishi
nilfs_bmap_lookup and its variants are supposed to take a valid pointer argument to return a block address, thus pointer checks in nilfs_btree_lookup and nilfs_direct_lookup are needless. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/btree.c |6 +- fs/nilfs2

[PATCH 0/5] nilfs2 btree tweaks

2010-07-13 Thread Ryusuke Konishi
calculation on maximum number of child nodes, and revise parameter passing in low level routines of the btree code. Other two changes are for cleanups. I'm now reviewing the btree code, and this is a by-product of the work. Ryusuke Konishi -- Ryusuke Konishi (5): nilfs2: remove redundant

[PATCH 4/5] nilfs2: get maximum number of child nodes from bmap object

2010-07-13 Thread Ryusuke Konishi
call. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/bmap.h |2 ++ fs/nilfs2/btree.c |6 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/fs/nilfs2/bmap.h b/fs/nilfs2/bmap.h index fae83cf..a20569b 100644 --- a/fs/nilfs2/bmap.h +++ b/fs

[PATCH 2/5] nilfs2: optimize calculation of min/max number of btree node children

2010-07-13 Thread Ryusuke Konishi
. This unfold these functions depending on context and move them outside loops wherever possible. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/btree.c | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-) diff --git a/fs/nilfs2

[PATCH 3/5] nilfs2: reduce repetitive calculation of max number of child nodes

2010-07-13 Thread Ryusuke Konishi
NILFS_BTREE_ROOT_NCHILDREN_MAX is used for the root node, whereas nilfs_btree_nchildren_per_block() function is used for non-root nodes. If a node could be either root or a non-root node, an output argument of nilfs_btree_get_node() is used to set up ncmax. Signed-off-by: Ryusuke Konishi konishi.ryus

[PATCH] nilfs2: fix buffer head leak in nilfs_btnode_submit_block

2010-07-14 Thread Ryusuke Konishi
nilfs_btnode_submit_block() refers to buffer head just before returning from the function, but it releases the buffer head earlier than that if nilfs_dat_translate() gets an error. This has potential for oops in the erroneous case. This fixes the issue. Signed-off-by: Ryusuke Konishi

[PATCHv2] nilfs2: verify btree node after reading

2010-07-16 Thread Ryusuke Konishi
This is a revised version of the patch that I posted last week. I found the previous patch had a refcount leak on buffer head, and this fixes the leak bug. Ryusuke Konishi -- From: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp nilfs2: verify btree node after reading This inserts sanity checks

[PATCH 0/4] nilfs2 read ahead btree sibling nodes

2010-07-17 Thread Ryusuke Konishi
block addresses. The following measurement results show the effect of this patchset for dd read on a 512 Mega-bytes file: 38.5 MB/s - 67.0 MB/s (a scsi hard drive) 188 MB/s - 200 MB/s (Intel SSD) I will queue up this for the next merge window after some more tune up. Ryusuke Konishi

[PATCH 4/4] nilfs2: apply read-ahead for nilfs_btree_lookup_contig

2010-07-17 Thread Ryusuke Konishi
during read of regular files or directories, receives the benefit. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/btree.c | 50 +- 1 files changed, 33 insertions(+), 17 deletions(-) diff --git a/fs/nilfs2/btree.c b/fs

[PATCH 2/4] nilfs2: add btree get block function with readahead option

2010-07-17 Thread Ryusuke Konishi
the previous nilfs_btree_get_block() implementation with a wrapper function of __nilfs_btree_get_block(). Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/btree.c | 94 ++-- 1 files changed, 68 insertions(+), 26 deletions(-) diff

[PATCH 1/4] nilfs2: add read ahead mode to nilfs_btnode_submit_block

2010-07-17 Thread Ryusuke Konishi
requested block is continous to the previous one on disk. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/btnode.c | 17 ++--- fs/nilfs2/btnode.h |4 ++-- fs/nilfs2/btree.c |3 ++- fs/nilfs2/gcinode.c |6 -- 4 files changed, 22

[PATCH 3/4] nilfs2: introduce check flag to btree node buffer

2010-07-17 Thread Ryusuke Konishi
nilfs_btree_get_block() now may return untested buffer due to read-ahead This adds new flag for buffer heads so that the btree code can check whether the buffer is already verified or not. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/btree.c | 10 +- fs

[PATCH 0/3] nilfs2 add feature flags

2010-07-19 Thread Ryusuke Konishi
compatible. I think this should be added before dropping the experimental flag though it again extends super blocks. Sekiba-san, do you have comment on this? Thanks, Ryusuke Konishi -- Ryusuke Konishi (3): nilfs2: clarify byte offset in super block format nilfs2: add feature set fields

[PATCH 2/3] nilfs2: add feature set fields to super block

2010-07-19 Thread Ryusuke Konishi
are the incompatible feature set; it is used to refuse to mount the filesystem which sets an incompatible feature the kernel doesn't know about. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- include/linux/nilfs2_fs.h | 15 ++- 1 files changed, 14 insertions(+), 1

[PATCH 3/3] nilfs2: reject incompatible filesystem

2010-07-19 Thread Ryusuke Konishi
This forces nilfs to check compatibility of feature flags when it mounts or remounts the filesystem so that it rejects the filesystem with unknown features. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/nilfs.h |2 ++ fs/nilfs2/super.c | 39

[PATCH 1/3] nilfs2: clarify byte offset in super block format

2010-07-19 Thread Ryusuke Konishi
This inserts comments indicating hexadecimal offset in declaration of nilfs_super_block structure so that people can know offset of its fields without counting from the head. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- include/linux/nilfs2_fs.h | 26

[PATCHv2 3/3] nilfs2: reject incompatible filesystem

2010-07-21 Thread Ryusuke Konishi
This forces nilfs to check compatibility of feature flags so as to reject a filesystem with unknown features when it mounts or remounts the filesystem. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/nilfs.h |2 ++ fs/nilfs2/super.c | 39

[PATCHv2 2/3] nilfs2: add feature set fields to super block

2010-07-21 Thread Ryusuke Konishi
are the incompatible feature set; it is used to refuse to mount the filesystem which sets an incompatible feature the kernel doesn't know about. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- include/linux/nilfs2_fs.h | 15 ++- 1 files changed, 14 insertions(+), 1

[PATCHv2 0/3] nilfs2 add feature flags

2010-07-21 Thread Ryusuke Konishi
compatible. * Change from the v1 patchset is as follows: - insert the same test of feature flags also before proceed with recovery for read-only mount. Thanks, Ryusuke Konishi -- fs/nilfs2/nilfs.h |2 ++ fs/nilfs2/super.c | 39 +++ fs/nilfs2

Re: Error while testing (using loop device)

2010-07-22 Thread Ryusuke Konishi
. Regards, Ryusuke Konishi -- To unsubscribe from this list: send the line unsubscribe linux-nilfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 0/3] nilfs2 add feature flags

2010-07-23 Thread Ryusuke Konishi
On Fri, 23 Jul 2010 13:30:05 +0900, Jiro SEKIBA wrote: Hi, At Thu, 22 Jul 2010 03:22:17 +0900, Ryusuke Konishi wrote: This is a revised patchset that introduces feature flags and makes nilfs refuse to mount future incompatibile filesystems. The first patch is just for improving

Re: [PATCH] mount.nilfs2: add uhelper= option

2010-07-23 Thread Ryusuke Konishi
. I took this one and applied to nilfs-utils.git. If you need any additional help for this, please let me know. BTW, I didn't know the role of the struct string_opt_map until now. It looks helpful also for other virtual options. Thanks, Ryusuke Konishi sbin/mount/mount_opts.c |3 ++- 1

Re: Error while testing (using loop device)

2010-07-23 Thread Ryusuke Konishi
Hi, On Fri, 23 Jul 2010 10:47:38 -0500, Rodrigo_E._De_León_Plicet wrote: On Thu, Jul 22, 2010 at 9:31 PM, Ryusuke Konishi ryus...@osrg.net wrote: How about this?  $ sudo mount -t nilfs2 -o ro,cp=3,loop=/dev/loop0 /tmp/test.img /tmp/t2 or  $ sudo mount -t nilfs2 -r -o cp=3,loop=/dev

[PATCH 0/2] nilfs2 fix overflow of directory record size with 64KB block size

2010-07-25 Thread Ryusuke Konishi
on popular architectures. However, I think this is one of issues that must be resolved while we have a chance. Ryusuke Konishi -- Ryusuke Konishi (2): nilfs2: avoid rec_len overflow with 64KB block size nilfs2: reject filesystem with unsupported block size fs/nilfs2/dir.c | 26

[GIT PULL] nilfs2 updates for 2.6.36

2010-08-06 Thread Ryusuke Konishi
handling of filesystem corruption more secure. Thanks! Ryusuke Konishi -- The following changes since commit b37fa16e78d6f9790462b3181602a26b5af36260: Linus Torvalds (1): Linux 2.6.35-rc6 are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/ryusuke

Re: [PATCH] nilfs2-utils: fix volume label size in mkfs

2010-08-06 Thread Ryusuke Konishi
-off-by: Jiro SEKIBA j...@unicus.jp Ahh, I got it. Will apply later. Thank you. Ryusuke Konishi --- sbin/mkfs/mkfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sbin/mkfs/mkfs.c b/sbin/mkfs/mkfs.c index e135059..2d04c59 100644 --- a/sbin/mkfs/mkfs.c +++ b

[PATCH] nilfs2: accept future revisions

2010-08-09 Thread Ryusuke Konishi
NILFS_CURRENT_REV. We don't have to do it soon, but it would be a possible option whenever the need arises. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/the_nilfs.c |4 ++-- include/linux/nilfs2_fs.h |1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff

[PATCH] nilfs2: fix false warning saying one of two super blocks is broken

2010-08-15 Thread Ryusuke Konishi
if it's newer than the primary one. This kills the false warning by suppressing it if another super block is not actually broken. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/the_nilfs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs

Re: FYI: User land tools status

2010-08-20 Thread Ryusuke Konishi
these work will be incorporated in distro packages without incident. These are really useful. Especially, I appreciate this sort of help on userland because my hands are now full with kernel issues. I hope you continue to work with to move things forward. Thanks, Ryusuke Konishi

[PATCH 3/6] nilfs2: keep zero value in i_cno except for gc-inodes

2010-08-22 Thread Ryusuke Konishi
and lets only gc-inodes use it. The purpose of this patch is to allow the successive change use i_cno for inode lookup. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/segment.c | 29 ++--- fs/nilfs2/segment.h |3 ++- include

[PATCH 0/6] nilfs2: remove own inode hash table

2010-08-22 Thread Ryusuke Konishi
://git.kernel.org/pub/scm/linux/kernel/git/ryusuke/nilfs2.git My next goal is to remove own inode allocator used to manage metadata as files, but it still looks to need more effort. I'd like to queue this for the next merge window if there are no objections. Thanks, Ryusuke Konishi -- Ryusuke Konishi

[PATCH 6/6] nilfs2: remove own inode hash used for GC

2010-08-22 Thread Ryusuke Konishi
This uses inode hash function that vfs provides instead of the own hash table for caching gc inodes. This finally removes the own inode hash from nilfs. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/gcinode.c | 140

[GIT PULL] nilfs2 additional fix

2010-08-22 Thread Ryusuke Konishi
Hi Linus, please pull: git://git.kernel.org/pub/scm/linux/kernel/git/ryusuke/nilfs2.git for-linus to grab the following fix, which corrects sync failure of discard in nilfs that Christoph noticed me recently. Thanks! Ryusuke Konishi -- The following changes since commit

Re: [PATCH 0/6] nilfs2: remove own inode hash table

2010-08-24 Thread Ryusuke Konishi
On Tue, 24 Aug 2010 17:42:16 +0100, Al Viro wrote: On Wed, Aug 25, 2010 at 01:20:12AM +0900, Ryusuke Konishi wrote: So, my implementation issue here is how to free dentries and inodes of snapshots like shrink_dcache_for_umount(sb) does for a single namespace. Use d_obtain_alias

[PATCH] nilfs2: fix leak of shadow dat inode in error path of load_nilfs

2010-08-28 Thread Ryusuke Konishi
If load_nilfs() gets an error while doing recovery, it will fail to free the shadow inode of dat (nilfs-ns_gc_dat). This fixes the leak issue. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/the_nilfs.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

Re: [PATCHv2 0/2] nilfs2-utils: userland tools to tune nilfs

2010-09-03 Thread Ryusuke Konishi
it and send me fixes. Thanks! Ryusuke Konishi differences from first patch are following: - fix styles - fix typos and description of manpages - fix a condition of assert at beginning of the nilfs_sb_write - add condition to check sb pointer in the nilfs_sb_write configure.ac

[GIT PULL] nilfs2 fix

2010-09-04 Thread Ryusuke Konishi
Hi Linus, please pull a nilfs2 fix from: git://git.kernel.org/pub/scm/linux/kernel/git/ryusuke/nilfs2.git for-linus This fixes a leak issue that occurs when recovery aborted. Thanks, Ryusuke Konishi -- The following changes since commit 2bfc96a127bc1cc94d26bfaa40159966064f9c8c: Linus

Re: [PATCH] nilfs2-utils: fix bug when opening non-nilfs2 device

2010-09-10 Thread Ryusuke Konishi
Applied, thank you. Ryusuke Konishi --- lib/sb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/sb.c b/lib/sb.c index 201b9ad..b60575d 100644 --- a/lib/sb.c +++ b/lib/sb.c @@ -161,7 +161,7 @@ struct nilfs_super_block *nilfs_sb_read(int devfd

Re: resizing file system

2010-09-11 Thread Ryusuke Konishi
On Sat, 11 Sep 2010 19:31:18 -0400, Matteo Frigo wrote: Ryusuke Konishi ryus...@osrg.net writes: To be precise, you also have to move the secondary superblock, and s_dev_size should be changed, too. Anyway, all that's required for the off-line expansion are these modifications. Ok, I

Re: [PATCH] Compare device number rather than device name for mount check.

2010-09-11 Thread Ryusuke Konishi
\ option to force this operation.\n, total: 0 errors, 2 warnings, 535 lines checked I will adopt your patch with minor amendment. Thank you. Ryusuke Konishi --- configure.ac |3 +- sbin/nilfs-tune/nilfs-tune.c | 69 +++-- 2 files

Re: [PATCH] nilfs2-utils: change the error message of nilfs-tune properly

2010-09-12 Thread Ryusuke Konishi
%s\n, + strerror(errno), device); How about putting the error string behind the primary message? fprintf(stderr, cannot open device %s: %s\n, device, strerror(errno)); Thanks, Ryusuke Konishi ret = EXIT_FAILURE

[PATCH 08/23] nilfs2: split out nilfs_get_root_dentry

2010-09-13 Thread Ryusuke Konishi
This splits the code to allocate root dentry into a separate routine for convenience in successive changes. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/super.c | 54 ++-- 1 files changed, 35 insertions(+), 19

[PATCH 20/23] nilfs2: see state of root dentry for mount check of snapshots

2010-09-13 Thread Ryusuke Konishi
nilfs_checkpoint_is_mounted test whether the root dentry is busy or not. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/cpfile.c| 23 --- fs/nilfs2/inode.c | 10 ++ fs/nilfs2/nilfs.h |3 +++ fs/nilfs2/super.c | 32

[PATCH 22/23] nilfs2: get rid of back pointer to writable sb instance

2010-09-13 Thread Ryusuke Konishi
Nilfs object holds a back pointer to a writable super block instance in nilfs-ns_writer, and this became eliminable since sb is now made per device and all inodes have a valid pointer to it. This deletes the ns_writer pointer and a reader/writer semaphore protecting it. Signed-off-by: Ryusuke

[PATCH 13/23] nilfs2: allow nilfs_clear_inode to clear metadata file inodes

2010-09-13 Thread Ryusuke Konishi
Allows clear inode function (nilfs_clear_inode) to handle metadata files that uses bitmap-based object alloctor. DAT and ifile correspond to this. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/inode.c |4 1 files changed, 4 insertions(+), 0 deletions

[PATCH 21/23] nilfs2: get rid of mi_nilfs back pointer to nilfs object

2010-09-13 Thread Ryusuke Konishi
This removes a back pointer to nilfs object from nilfs_mdt_info structure that is attached to metadata files. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/mdt.c|9 +++-- fs/nilfs2/mdt.h|8 ++-- fs/nilfs2/sufile.c |4 ++-- fs/nilfs2

[PATCH 05/23] nilfs2: move inode count and block count into root object

2010-09-13 Thread Ryusuke Konishi
This moves sbi-s_inodes_count and sbi-s_blocks_count into nilfs_root object. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/inode.c |4 ++-- fs/nilfs2/sb.h |2 -- fs/nilfs2/segment.c |4 ++-- fs/nilfs2/super.c | 11 ++- 4 files changed

[PATCH 02/23] nilfs2: set pointer to root object in inodes

2010-09-13 Thread Ryusuke Konishi
() function. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- fs/nilfs2/inode.c| 27 ++- fs/nilfs2/namei.c|5 +++-- fs/nilfs2/nilfs.h|7 +-- fs/nilfs2/recovery.c | 12 fs/nilfs2/super.c| 37

  1   2   3   4   5   6   >