Re: [PATCH v19 6/8] PM: hibernate: disable when there are active secretmem users

2021-05-18 Thread James Bottomley
On Tue, 2021-05-18 at 18:49 -0700, Dan Williams wrote: > On Tue, May 18, 2021 at 6:33 PM James Bottomley > wrote: > > On Tue, 2021-05-18 at 11:24 +0100, Mark Rutland wrote: > > > On Thu, May 13, 2021 at 09:47:32PM +0300, Mike Rapoport wrote: > > > > From: Mike Rapoport > > > > > > > > It is

Re: [PATCH v19 6/8] PM: hibernate: disable when there are active secretmem users

2021-05-18 Thread Dan Williams
On Tue, May 18, 2021 at 6:33 PM James Bottomley wrote: > > On Tue, 2021-05-18 at 11:24 +0100, Mark Rutland wrote: > > On Thu, May 13, 2021 at 09:47:32PM +0300, Mike Rapoport wrote: > > > From: Mike Rapoport > > > > > > It is unsafe to allow saving of secretmem areas to the hibernation > > >

Re: [PATCH v19 6/8] PM: hibernate: disable when there are active secretmem users

2021-05-18 Thread James Bottomley
On Tue, 2021-05-18 at 11:24 +0100, Mark Rutland wrote: > On Thu, May 13, 2021 at 09:47:32PM +0300, Mike Rapoport wrote: > > From: Mike Rapoport > > > > It is unsafe to allow saving of secretmem areas to the hibernation > > snapshot as they would be visible after the resume and this > >

Re: [PATCH v19 6/8] PM: hibernate: disable when there are active secretmem users

2021-05-18 Thread David Hildenbrand
On 18.05.21 12:24, Mark Rutland wrote: On Thu, May 13, 2021 at 09:47:32PM +0300, Mike Rapoport wrote: From: Mike Rapoport It is unsafe to allow saving of secretmem areas to the hibernation snapshot as they would be visible after the resume and this essentially will defeat the purpose of

Re: [PATCH v19 6/8] PM: hibernate: disable when there are active secretmem users

2021-05-18 Thread Mark Rutland
On Thu, May 13, 2021 at 09:47:32PM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > It is unsafe to allow saving of secretmem areas to the hibernation > snapshot as they would be visible after the resume and this essentially > will defeat the purpose of secret memory mappings. > > Prevent

Re: [PATCH v19 6/8] PM: hibernate: disable when there are active secretmem users

2021-05-14 Thread David Hildenbrand
On 13.05.21 20:47, Mike Rapoport wrote: From: Mike Rapoport It is unsafe to allow saving of secretmem areas to the hibernation snapshot as they would be visible after the resume and this essentially will defeat the purpose of secret memory mappings. Prevent hibernation whenever there are