date:20210511

Re: [PATCH v5 5/7] fsdax: Dedup file range to use a compare function

2021-05-11 Thread Darrick J. Wong

On Tue, May 11, 2021 at 11:09:31AM +0800, Shiyang Ruan wrote: > With dax we cannot deal with readpage() etc. So, we create a dax > comparison funciton which is similar with > vfs_dedupe_file_range_compare(). > And introduce dax_remap_file_range_prep() for filesystem use. > > Signed-off-by:

RE: [PATCH v5 3/7] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero

2021-05-11 Thread ruansy.f...@fujitsu.com

> -Original Message- > From: Darrick J. Wong > Subject: Re: [PATCH v5 3/7] fsdax: Add dax_iomap_cow_copy() for > dax_iomap_zero > > On Tue, May 11, 2021 at 11:09:29AM +0800, Shiyang Ruan wrote: > > Punch hole on a reflinked file needs dax_copy_edge() too. Otherwise, > > data in not

Re: [PATCH v5 7/7] fs/xfs: Add dax dedupe support

2021-05-11 Thread Darrick J. Wong

On Tue, May 11, 2021 at 11:09:33AM +0800, Shiyang Ruan wrote: > Introduce xfs_mmaplock_two_inodes_and_break_dax_layout() for dax files > who are going to be deduped. After that, call compare range function > only when files are both DAX or not. > > Signed-off-by: Shiyang Ruan > --- >

Re: [PATCH v5 2/7] fsdax: Replace mmap entry in case of CoW

2021-05-11 Thread Darrick J. Wong

On Tue, May 11, 2021 at 11:09:28AM +0800, Shiyang Ruan wrote: > We replace the existing entry to the newly allocated one in case of CoW. > Also, we mark the entry as PAGECACHE_TAG_TOWRITE so writeback marks this > entry as writeprotected. This helps us snapshots so new write > pagefaults after

Re: [PATCH v5 3/7] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero

2021-05-11 Thread Darrick J. Wong

On Tue, May 11, 2021 at 11:09:29AM +0800, Shiyang Ruan wrote: > Punch hole on a reflinked file needs dax_copy_edge() too. Otherwise, > data in not aligned area will be not correct. So, add the srcmap to > dax_iomap_zero() and replace memset() as dax_copy_edge(). > > Signed-off-by: Shiyang Ruan

Re: [PATCH v5 6/7] fs/xfs: Handle CoW for fsdax write() path

2021-05-11 Thread Darrick J. Wong

On Tue, May 11, 2021 at 11:09:32AM +0800, Shiyang Ruan wrote: > In fsdax mode, WRITE and ZERO on a shared extent need CoW performed. After > CoW, new allocated extents needs to be remapped to the file. So, add an > iomap_end for dax write ops to do the remapping work. > > Signed-off-by: Shiyang

Re: [PATCH v5 3/7] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero

2021-05-11 Thread Mika Penttilä

Hi, On 11.5.2021 6.09, Shiyang Ruan wrote: Punch hole on a reflinked file needs dax_copy_edge() too. Otherwise, data in not aligned area will be not correct. So, add the srcmap to dax_iomap_zero() and replace memset() as dax_copy_edge(). Signed-off-by: Shiyang Ruan Reviewed-by: Ritesh

Re: [PATCH v5 1/7] fsdax: Introduce dax_iomap_cow_copy()

2021-05-11 Thread Darrick J. Wong

On Tue, May 11, 2021 at 11:09:27AM +0800, Shiyang Ruan wrote: > In the case where the iomap is a write operation and iomap is not equal > to srcmap after iomap_begin, we consider it is a CoW operation. > > The destance extent which iomap indicated is new allocated extent. > So, it is needed to

RE: [PATCH v5 7/7] fs/xfs: Add dax dedupe support

2021-05-11 Thread ruansy.f...@fujitsu.com

> -Original Message- > From: Darrick J. Wong > Subject: Re: [PATCH v5 7/7] fs/xfs: Add dax dedupe support > > On Tue, May 11, 2021 at 11:09:33AM +0800, Shiyang Ruan wrote: > > Introduce xfs_mmaplock_two_inodes_and_break_dax_layout() for dax files > > who are going to be deduped. After