Re: [PATCH v4 3/5] um: track 'parent' device in a local variable

2016-06-22 Thread Dan Williams
On Tue, Jun 21, 2016 at 11:20 PM, Bart Van Assche <bart.vanass...@sandisk.com> wrote: > On 06/21/2016 10:47 PM, Dan Williams wrote: >> >> In preparation for the removal of 'driverfs_dev' from 'struct gendisk' >> use a local variable to track the parented vs un-parented c

[PATCH v4 4/5] block: convert to device_add_disk()

2016-06-21 Thread Dan Williams
onrad Rzeszutek Wilk <konrad.w...@oracle.com> Cc: Martin K. Petersen <martin.peter...@oracle.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- arch/powerpc

[PATCH v4 0/5] Introduce device_add_disk() to kill gendisk.driverfs_dev

2016-06-21 Thread Dan Williams
ld success notification from the kbuild robot across 122 configs. --- Dan Williams (5): block: introduce device_add_disk() mmc: move 'parent' tracking to mmc_blk_data um: track 'parent' device in a local variable block: convert to device_add_disk() block: remove ->driverf

[PATCH v4 1/5] block: introduce device_add_disk()

2016-06-21 Thread Dan Williams
Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- block/genhd.c | 13 +++-- include/linux/genhd.h |8 +++- 2 files changed, 14 insertions(+),

[PATCH v4 2/5] mmc: move 'parent' tracking to mmc_blk_data

2016-06-21 Thread Dan Williams
In preparation for the removal of 'driverfs_dev' from 'struct gendisk', carry this data in mmc_blk_data. It is used for registration of parent disks and partitions. Cc: Ulf Hansson <ulf.hans...@linaro.org> Reported-by: Bart Van Assche <bart.vanass...@sandisk.com> Signed-off-by:

Re: [PATCH v2 1/3] block: add QUEUE_FLAG_DAX for devices to advertise their DAX support

2016-06-23 Thread Dan Williams
>> return count; >>> } >>> >>> +static ssize_t queue_dax_show(struct request_queue *q, char *page) >>> +{ >>> + int bit; >>> + >>> + bit = test_bit(QUEUE_FLAG_DAX, >queue_flags); >>> + >>> +

Re: [PATCH] e820: use module_platform_driver

2016-06-24 Thread Dan Williams
On Fri, Jun 24, 2016 at 3:29 AM, Johannes Thumshirn wrote: > User module_platform_driver macro instead of open-coding it. > > Signed-off-by: Johannes Thumshirn Looks good. ___ Linux-nvdimm mailing list

[PATCH v3 0/3] Introduce device_add_disk() to kill gendisk.driverfs_dev

2016-06-17 Thread Dan Williams
ation from the kbuild robot across 116 configs. The following series implements... --- Dan Williams (3): block: introduce device_add_disk() block: convert to device_add_disk() block: remove ->driverfs_dev arch/powerpc/sysdev/axonram.c |3 +-- arch/um/drive

[PATCH v3 2/3] block: convert to device_add_disk()

2016-06-17 Thread Dan Williams
wisler <ross.zwis...@linux.intel.com> Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Cc: Martin K. Petersen <martin.peter...@oracle.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: Dan Williams <dan.j

[PATCH v3 1/3] block: introduce device_add_disk()

2016-06-17 Thread Dan Williams
Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- block/genhd.c | 13 +++-- include/linux/genhd.h |8 +++- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/block/genhd.c b/block/genhd

Re: [PATCH v2] libnvdimm, nfit: treat volatile virtual CD region as pmem

2016-06-25 Thread Dan Williams
On Sat, Jun 25, 2016 at 5:21 AM, joeyli <j...@suse.com> wrote: > iOn Fri, Jun 24, 2016 at 10:59:56AM -0700, Dan Williams wrote: >> On Fri, Jun 24, 2016 at 12:51 AM, Lee, Chun-Yi <joeyli.ker...@gmail.com> >> wrote: >> > This patch adds logic to treat volatile v

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-06-27 Thread Dan Williams
On Mon, Jun 27, 2016 at 10:40 AM, Linda Knippers <linda.knipp...@hpe.com> wrote: > > On 6/24/2016 1:44 PM, Dan Williams wrote: >> QEMU 2.6 implements nascent support for nvdimm DSMs. Depending on >> configuration it may only implement the function0 dsm to indica

[PATCH v5 3/5] um: track 'parent' device in a local variable

2016-06-27 Thread Dan Williams
com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- arch/um/drivers/ubd_kern.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index ef6b4d960bad..f3540270d096 100644 --- a/arch/um/drivers/ubd_kern

[PATCH v5 0/5] Introduce device_add_disk() to kill gendisk.driverfs_dev

2016-06-27 Thread Dan Williams
build success notification from the kbuild robot. --- Dan Williams (5): block: introduce device_add_disk() mmc: move 'parent' tracking to mmc_blk_data um: track 'parent' device in a local variable block: convert to device_add_disk() block: remove ->driverfs_dev

[ndctl PATCH 5/9] ndctl: add libs dependency to spec file

2016-06-26 Thread Dan Williams
Otherwise ndctl may use an old version of ndctl-libs. The expectation is that installing an updated ndctl also includes all the capabilities of an updated libndctl. Reported-by: Jeff Moyer <jmo...@redhat.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- ndctl.spec.in

Re: [PATCH v2 16/17] x86/insn: remove pcommit

2016-07-22 Thread Dan Williams
On Tue, Jul 12, 2016 at 3:12 PM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Tue, Jul 12, 2016 at 7:57 AM, Peter Zijlstra <pet...@infradead.org> wrote: >> On Sat, Jul 09, 2016 at 08:25:54PM -0700, Dan Williams wrote: >>> The pcommit instruction is being dep

Re: btt ndctl question

2016-07-26 Thread Dan Williams
he btt only >> > shows a sector size. There >> > is no size value exposed by the btt sysfs information, which is >> > probably why it's not in ndctl. >> > >> > I know the size can be gotten from the block device but it looks >> > like an

Re: btt ndctl question

2016-07-26 Thread Dan Williams
On Tue, Jul 26, 2016 at 2:41 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > On 07/26, Dan Williams wrote: >> On Tue, Jul 26, 2016 at 2:24 PM, Verma, Vishal L >> <vishal.l.ve...@intel.com> wrote: >> > On Tue, 2016-07-26 at 14:58 -0600, Vishal Verma wrote:

Re: [PATCH v2 2/3] nfit, libnvdimm: allow an ARS scrub to be triggered on demand

2016-07-21 Thread Dan Williams
On Thu, Jul 21, 2016 at 12:40 PM, Linda Knippers wrote: > On 07/20/2016 09:50 PM, Vishal Verma wrote: >> Normally, an ARS (Address Range Scrub) only happens at >> boot/initialization time. There can however arise situations where a >> bus-wide rescan is needed - notably,

Re: [PATCH] nfit: Get rid of CONFIG_ACPI_NFIT_DEBUG

2016-07-28 Thread Dan Williams
On Thu, Jul 28, 2016 at 2:49 AM, Johannes Thumshirn wrote: > CONFIG_ACPI_NFIT_DEBUG is currently used to dump the buffers used in NFIT _DSM > calls. Within the statements guarded by CONFIG_ACPI_NFIT_DEBUG we use dynamic > debugging as well as print_hex_dump_debug(). Change the

Re: [BUG] kernel NULL pointer dereference observed during pmem btt switch test

2016-07-28 Thread Dan Williams
[ adding linux-block ] On Wed, Jul 27, 2016 at 8:20 PM, Yi Zhang wrote: > Hello everyone > > Could you help check this issue, thanks. > > Steps I used: > 1. Reserve 4*8G of memory for pmem by add kernel parameter "memmap=8G!4G > memmap=8G!12G memmap=8G!20G memmap=8G!28G" > 2.

[PATCH v4 4/4] nfit: do an ARS scrub on hitting a latent media error

2016-07-23 Thread Dan Williams
Verma <vishal.l.ve...@intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit/Makefile |1 drivers/acpi/nfit/core.c| 26 +++-- drivers/acpi/nfit/mce.c | 89 +++ drivers/acpi/nfit/nfit.h|

[PATCH v4 2/4] nfit, libnvdimm: allow an ARS scrub to be triggered on demand

2016-07-23 Thread Dan Williams
re out what other sectors are bad, and thus potentially avoid triggering an mce on them in the future. Also provide a sysfs trigger to start a bus-wide scrub. Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com> Signed-off-by: Dan Wil

[PATCH v5] nfit, libnvdimm: allow an ARS scrub to be triggered on demand

2016-07-24 Thread Dan Williams
re out what other sectors are bad, and thus potentially avoid triggering an mce on them in the future. Also provide a sysfs trigger to start a bus-wide scrub. Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com> Signed-off-by: Dan Wil

Re: [PATCH] libnvdimm-btt: Delete an unnecessary check before the function call "__nd_device_register"

2016-07-24 Thread Dan Williams
On Sun, Jul 24, 2016 at 2:16 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 24 Jul 2016 11:05:34 +0200 > > The __nd_device_register() function tests whether its argument is NULL > and then returns immediately. Thus

[PATCH 1/2] libnvdimm: move ->module to struct nvdimm_bus_descriptor

2016-07-21 Thread Dan Williams
Let the provider module be explicitly passed in rather than implicitly assumed by the module that calls nvdimm_bus_register(). This is in preparation for unifying the nfit and nfit_test driver teardown paths. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/

[PATCH 2/2] nfit, tools/testing/nvdimm/: unify shutdown paths

2016-07-21 Thread Dan Williams
rma <vishal.l.ve...@intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c | 36 ++-- tools/testing/nvdimm/test/nfit.c | 16 ++-- 2 files changed, 24 insertions(+), 28 deletions(-) diff --git

Re: [PATCH] block: remove BLK_DEV_DAX config option

2016-07-29 Thread Dan Williams
commit, removing the dead config option. > > Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> > Cc: Dave Hansen <dave.han...@linux.intel.com> > Cc: Dan Williams <dan.j.willi...@intel.com> Acked-by: Dan Williams <dan.j.willi...@intel.com>

Re: Subtle races between DAX mmap fault and write path

2016-07-29 Thread Dan Williams
On Thu, Jul 28, 2016 at 7:21 PM, Dave Chinner wrote: > On Thu, Jul 28, 2016 at 10:10:33AM +0200, Jan Kara wrote: >> On Thu 28-07-16 08:19:49, Dave Chinner wrote: [..] >> So DAX doesn't need flushing to maintain consistent view of the data but it >> does need flushing to make

Re: Subtle races between DAX mmap fault and write path

2016-07-29 Thread Dan Williams
On Fri, Jul 29, 2016 at 5:12 PM, Dave Chinner <da...@fromorbit.com> wrote: > On Fri, Jul 29, 2016 at 07:44:25AM -0700, Dan Williams wrote: >> On Thu, Jul 28, 2016 at 7:21 PM, Dave Chinner <da...@fromorbit.com> wrote: >> > On Thu, Jul 28, 2016 at 10:10:33AM +0200, Jan

Re: [BUG] kernel NULL pointer dereference observed during pmem btt switch test

2016-07-30 Thread Dan Williams
On Thu, Jul 28, 2016 at 8:50 AM, Dan Williams <dan.j.willi...@intel.com> wrote: > [ adding linux-block ] > > On Wed, Jul 27, 2016 at 8:20 PM, Yi Zhang <yiz...@redhat.com> wrote: >> Hello everyone >> >> Could you help check this issue, thanks. >>

Re: Subtle races between DAX mmap fault and write path

2016-07-31 Thread Dan Williams
On Sun, Jul 31, 2016 at 9:07 PM, Dave Chinner wrote: > On Sun, Jul 31, 2016 at 08:13:23PM -0700, Keith Packard wrote: >> Dave Chinner writes: >> >> > So we'd see that from the point of view of a torn single sector >> > write. Ok, so we better limit DAX

Re: [BUG] kernel NULL pointer dereference observed during pmem btt switch test

2016-07-31 Thread Dan Williams
On Sun, Jul 31, 2016 at 10:19 AM, yizhan <yiz...@redhat.com> wrote: > On 07/30/2016 11:52 PM, Dan Williams wrote: >> >> On Thu, Jul 28, 2016 at 8:50 AM, Dan Williams <dan.j.willi...@intel.com> >> wrote: >>> >>> [ adding linux-block ] >

[PATCH] block: fix bdi vs gendisk lifetime mismatch

2016-07-31 Thread Dan Williams
0xd8/0x100 [] device_create_vargs+0x1c/0x20 [] bdi_register+0x8c/0x180 [] bdi_register_dev+0x27/0x30 [] add_disk+0x175/0x4a0 Cc: <sta...@vger.kernel.org> Reported-by: Yi Zhang <yiz...@redhat.com> Tested-by: Yi Zhang <yiz...@redhat.com> Signed-off-by: Dan Williams <dan.j.willi..

Re: [4.8 hang] xfstests generic/361 hangs on dax enabled filesystems

2016-08-02 Thread Dan Williams
On Tue, Aug 2, 2016 at 5:33 PM, Dave Chinner wrote: > Hi folks, > > Just hit a reproducable hang in generic/361. Essentially this on > a 8GB pmem device: > > mkfs.xfs -f /dev/pmem1 > mount -o dax /dev/pmem1 /mnt/scratch > xfs_io -f -c "truncate 1g" test.img > losetup -f

Re: [4.8 hang] xfstests generic/361 hangs on dax enabled filesystems

2016-08-03 Thread Dan Williams
On Wed, Aug 3, 2016 at 4:16 PM, Dave Chinner wrote: > On Wed, Aug 03, 2016 at 04:37:13PM -0600, Ross Zwisler wrote: >> On Wed, Aug 03, 2016 at 11:11:27AM -0600, Ross Zwisler wrote: >> > On Wed, Aug 03, 2016 at 10:33:54AM +1000, Dave Chinner wrote: >> > > Hi folks, >> > > >> >

[PATCH] tools/testing/nvdimm: fix SIGTERM vs hotplug crash

2016-08-10 Thread Dan Williams
/0x680 [] kthread+0xf3/0x110 [] ret_from_fork+0x1f/0x40 [] ? kthread_create_on_node+0x230/0x230 Cc: <sta...@vger.kernel.org> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- tools/testing/nvdimm/test/nfit.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/te

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-07-20 Thread Dan Williams
On Tue, Jul 19, 2016 at 3:53 PM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Tue, Jul 19, 2016 at 3:46 PM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: >> On Tue, Jul 19, 2016 at 01:01:16PM -0700, Dan Williams wrote: >>> On Tue, Jul 19, 2016 at 11:52

Re: [PATCH v2 1/2] nfit: fix _FIT evaluation memory leak

2016-07-18 Thread Dan Williams
On Sun, Jul 17, 2016 at 10:57 PM, Xiao Guangrong <guangrong.x...@intel.com> wrote: > > > On 07/16/2016 03:32 AM, Dan Williams wrote: >> >> acpi_evaluate_object() allocates memory. Free the buffer allocated >> during acpi_nfit_add(). Also, make it clear t

Re: [PATCH 2/3] nfit, libnvdimm: allow an ARS rescan to be triggered on demand

2016-07-19 Thread Dan Williams
t > media error, we should do a full rescan to figure out what other sectors > are bad, and thus potentially avoid triggering an mce on them in the > future. Also provide a sysfs trigger to start a bus-wide rescan. > > Cc: Dan Williams <dan.j.willi...@intel.com> > Cc: Rafael

Re: [PATCH 3/3] nfit: do an ARS rescan on hitting a latent media error

2016-07-19 Thread Dan Williams
ending > operations on them can be trapped early, avoiding machine checks. > > This is done by registering a callback function with the > x86_mce_decoder_chain and calling the new ars_rescan functionality with > the address in the mce notificatiion. > > Cc: Dan Williams &l

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-07-19 Thread Dan Williams
On Tue, Jul 19, 2016 at 11:50 AM, Linda Knippers <linda.knipp...@hpe.com> wrote: > > > On 7/19/2016 1:11 PM, Jerry Hoemann wrote: >> On Fri, Jun 24, 2016 at 10:44:25AM -0700, Dan Williams wrote: >>> QEMU 2.6 implements nascent support for nvdimm DSMs. Depending on

[ndctl PATCH] ndctl: permit NULL as a parameter to ndctl_cmd_unref

2016-07-19 Thread Dan Williams
Similar to libc free() allow NULL as a valid parameter to this freeing routine. This mirrors the behavior of the other *_unref() routines in the library. Cc: Tiffany Kasanicky <tiffany.j.kasani...@intel.com> Reported-by: Linda Knippers <linda.knipp...@hpe.com> Signed-off-by:

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-07-19 Thread Dan Williams
On Tue, Jul 19, 2016 at 11:52 AM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Tue, Jul 19, 2016 at 11:50 AM, Linda Knippers <linda.knipp...@hpe.com> > wrote: >> On 7/19/2016 1:11 PM, Jerry Hoemann wrote: [..] >>> As nfit_mem->family always equals NVDIMM

[PATCH v3 2/2] nfit: cleanup acpi_nfit_init calling convention

2016-07-19 Thread Dan Williams
Pass the nfit buffer as a parameter rather than hanging it off of acpi_desc. Reviewed-by: "Lee, Chun-Yi" <j...@suse.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Changes since v2: * Only context changes due to v3 of patch1 drivers/acpi/nfit

[PATCH v2 2/2] nfit: cleanup acpi_nfit_init calling convention

2016-07-15 Thread Dan Williams
Pass the nfit buffer as a parameter rather than hanging it off of acpi_desc. Reviewed-by: "Lee, Chun-Yi" <j...@suse.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Changes since v1: * Reflowed based on fixups done to patch1, no other changes.

[PATCH v2] tools/testing/nvdimm: add virtual ramdisk range

2016-07-15 Thread Dan Williams
Test the virtual disk ranges that platform firmware like EDK2/OVMF might emit. Cc: "Lee, Chun-Yi" <j...@suse.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Changes since v1: * Move this test range to nfit_test.1 to not break the spa ordering expected by

[PATCH v2 1/2] nfit: fix _FIT evaluation memory leak

2016-07-15 Thread Dan Williams
ng <guangrong.x...@intel.com> Reported-by: Haozhong Zhang <haozhong.zh...@intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Change since v1: * Fix unitialized use of 'rc' (Haozhong) * Clarify that their is no use-after-free problem in acpi_nfit_notify() (X

[PATCH 2/2] nfit: cleanup acpi_nfit_init calling convention

2016-07-14 Thread Dan Williams
Pass the nfit buffer as a parameter rather than hanging it off of acpi_desc. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c | 56 +- drivers/acpi/nfit.h |3 +- tools/testing/nvdimm/test/

Re: [PATCH 1/2] libnvdimm: add missing macros

2016-07-08 Thread Dan Williams
On Fri, Jul 8, 2016 at 9:29 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > > This can't compile without these macros… Is this header really used by anyone? > Should it be removed, to avoid bit-rot? It's used by ndctl [1].

Re: [PATCH] dax: use devm_add_action_or_reset()

2016-07-06 Thread Dan Williams
Thanks, applied. On Mon, Jul 4, 2016 at 11:59 PM, Johannes Thumshirn wrote: > On Tue, Jul 05, 2016 at 11:20:07AM +0530, Vikas C Sajjan wrote: >> If devm_add_action() fails, we are explicitly calling the cleanup to free >> the resources allocated. Use the helper

Re: [PATCH] nfit: use devm_add_action_or_reset()

2016-07-06 Thread Dan Williams
Thanks, applied. On Mon, Jul 4, 2016 at 12:54 AM, joeyli wrote: > On Mon, Jul 04, 2016 at 10:02:51AM +0530, Vikas C Sajjan wrote: >> If devm_add_action() fails, we are explicitly calling the cleanup to free >> the resources allocated. Lets use the helper devm_add_action_or_reset()

[PATCH v2 03/17] libnvdimm: introduce devm_nvdimm_memremap(), convert nfit_spa_map() users

2016-07-09 Thread Dan Williams
for the nd_blk_region.disable() callback. Note that the removal of nfit_spa_map() and related infrastructure is deferred to a later patch. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c | 14 +++-- drivers/nvdimm/core.c

[PATCH v2 06/17] tools/testing/nvdimm: simulate multiple flush hints per-dimm

2016-07-09 Thread Dan Williams
Sample nfit data to test the kernel's handling of the multiple flush-hint case. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- tools/testing/nvdimm/test/nfit.c | 55 +++--- 1 file changed, 33 insertions(+), 22 deletions(-) diff --git a/tools/t

[PATCH v2 05/17] libnvdimm, nfit: move flush hint mapping to region-device driver-data

2016-07-09 Thread Dan Williams
to communicate more information to the nvdimm core to facilitate this mapping, namely each dimm object now carries an array of flush hint address resources. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c | 21 +++ drivers/acpi/

[PATCH v2 07/17] libnvdimm: keep region data alive over namespace removal

2016-07-09 Thread Dan Williams
nd_region device driver data will be used in the namespace i/o path. Re-order nd_region_remove() to ensure this data stays live across namespace device removal Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/nvdimm/region.c |3 ++- 1 file changed, 2 insertions

[PATCH v2 14/17] pmem: kill wmb_pmem()

2016-07-09 Thread Dan Williams
All users have been replaced with flushing in the pmem driver. Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- arch/x86/include/asm/pmem.h | 36 ++--- include/linux/pmem.h

[PATCH v2 16/17] x86/insn: remove pcommit

2016-07-09 Thread Dan Williams
.shish...@linux.intel.com> Cc: Borislav Petkov <b...@suse.de> Cc: Andy Lutomirski <l...@kernel.org> Cc: Xiao Guangrong <guangrong.x...@linux.intel.com> Cc: Adrian Hunter <adrian.hun...@intel.com> Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-b

[PATCH v2 15/17] Revert "KVM: x86: add pcommit support"

2016-07-09 Thread Dan Williams
linux.intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- arch/x86/include/asm/vmx.h |1 - arch/x86/include/uapi/asm/vmx.h |4 +--- arch/x86/kvm/cpuid.c|2 +- arch/x86/kvm/cpuid.h|8 arch/x86/kvm/v

[PATCH v2 11/17] libnvdimm, pmem: flush posted-write queues on shutdown

2016-07-09 Thread Dan Williams
Commit writes to media on system shutdown or pmem driver unload. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/nvdimm/bus.c | 16 drivers/nvdimm/pmem.c |8 include/linux/nd.h|1 + 3 files changed, 25 insertions(+) diff

Re: HPE SMART data retreival

2016-07-28 Thread Dan Williams
On Thu, Jul 28, 2016 at 11:46 AM, Linda Knippers <linda.knipp...@hpe.com> wrote: > > > On 7/28/2016 2:20 PM, Dan Williams wrote: >> On Thu, Jul 28, 2016 at 10:43 AM, Linda Knippers <linda.knipp...@hpe.com> >> wrote: >>> >>> >>> On 7/28

Re: HPE SMART data retreival

2016-07-28 Thread Dan Williams
On Thu, Jul 28, 2016 at 10:43 AM, Linda Knippers wrote: > > > On 7/28/2016 5:45 AM, Johannes Thumshirn wrote: >> On Wed, Jul 27, 2016 at 02:23:51PM -0400, Linda Knippers wrote: >>> Hi Johannes, >>> >>> I hope Dan and Jerry also reply but I have recently started looking at

[ndctl PATCH 4/4] test: skip 4.7+ tests on older kernels

2016-08-03 Thread Dan Williams
Add ndctl_test_attempt() guards on tests that will fail on 4.6 and older kernels. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- test/dax-errors.sh |9 +++ test/device-dax.sh | 10 +++ test/libndctl.c| 70 -

[ndctl PATCH 3/4] test: skip pmem/blk-ns tests on KVM

2016-08-03 Thread Dan Williams
KVM produces label-less pmem regions causing these tests to fail. Skip these tests when the NFIT does not describe aliased BLK + PMEM. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- test/blk_namespaces.c | 17 + test/pmem_namespaces.c | 18 +++

[ndctl PATCH 2/4] test: ensure create.sh always picks a suitable BTT-host namespace

2016-08-03 Thread Dan Williams
The default namespace picked by create-namespace might not be suitable to host a BTT. Specify this size to guarantee a usable selection. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- test/create.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/cre

Re: [RESEND PATCH] x86/mm: only allow memmap=XX!YY over existing RAM

2016-06-29 Thread Dan Williams
On Tue, Jun 28, 2016 at 10:12 PM, Yigal Korman <yi...@plexistor.com> wrote: > On Wed, Jun 29, 2016 at 4:09 AM, Dan Williams <dan.j.willi...@intel.com> > wrote: >> >> On Tue, Jun 28, 2016 at 10:58 AM, H. Peter Anvin <h...@zytor.com> wrote: >> > On 06/

Re: [PATCH] acpi, nfit: print command names instead of numbers

2016-06-29 Thread Dan Williams
On Wed, Jun 29, 2016 at 4:00 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > For the debug prints in acpi_nfit_ctl(), all the prints except the input > buffer dump printed the command name. Make this also do the same for > better readability. > > Cc: Dan Williams <

Re: test suite errors

2016-06-29 Thread Dan Williams
On Wed, Jun 29, 2016 at 8:31 AM, Johannes Thumshirn <jthumsh...@suse.de> wrote: > On Tue, Jun 28, 2016 at 07:24:17PM -0700, Dan Williams wrote: >> On Tue, Jun 28, 2016 at 7:17 PM, yizhan <yiz...@redhat.com> wrote: >> > On 06/29/2016 12:26 AM, Dan Wil

[PATCH] nfit: fix format interface code byte order

2016-06-29 Thread Dan Williams
e code byte order per ACPI6.1") Fixes: 5ad9a7fde07a ("acpi/nfit: Update nfit driver to comply with ACPI 6.1") Reported-by: Kristin Jacque <kristin.jac...@intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c |6 +++--- drivers/acpi/nfit.

[ndctl PATCH] build: quiet warnings about missing git repository

2016-07-01 Thread Dan Williams
<yi.a.zh...@hotmail.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- git-version |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/git-version b/git-version index 3823ee29afaf..9eb8fd654e38 100755 --- a/git-version +++ b/git-version @@ -38,9 +3

[ndctl PATCH 5/8] test: refactor / export ndctl_get_test_dev()

2016-08-16 Thread Dan Williams
Provide a common C api for tests to locate an "memmap=ss!nn" defined namespace for destructive tests. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- test.h |3 ++- test/dax-dev.c | 42 +++--- 2 files changed, 29 i

[ndctl PATCH 6/8] test, create-namespace: reset global data

2016-08-16 Thread Dan Williams
Before we add unit tests that call cmd_create_namespace() directly, we need to ensure that consecutive calls to cmd_create_namespace() behave the same as consecutive invocations of 'ndctl create-namespace'. I.e. re-initialize global parameter to zero. Signed-off-by: Dan Williams <dan.j.wi

[PATCH 2/7] dax: reorder dax_fops function definitions

2016-08-15 Thread Dan Williams
In order to convert devm_create_dax_dev() to use cdev, it will need access to dax_fops. Move dax_fops and related function definitions before devm_create_dax_dev(). Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/dax/dax.c

[PATCH 1/7] dax: cleanup needlessly global symbol warnings

2016-08-15 Thread Dan Williams
' was not declared. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/dax/dax.c |1 + drivers/dax/pmem.c |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c index 803f3953b341..736c03830fd0 100644 --- a/drivers/dax/dax.c

[PATCH 4/7] dax: embed a struct device in dax_dev

2016-08-15 Thread Dan Williams
The kref in dax_dev can be made redundant if the final put_device() on the device associated with the dax_dev frees the dax_dev. This can be accomplished by embedding a struct device in struct dax_dev, open coding device_create() and specifying a custom release method. Signed-off-by: Dan

[PATCH] acpi, nfit: fix acpi_nfit_flush_probe() crash

2017-02-02 Thread Dan Williams
[] acpi_nfit_flush_probe+0x95/0xc0 [nfit] [] ? nfit_visible+0x40/0x40 [nfit] [] wait_probe_show+0x25/0x60 [] dev_attr_show+0x20/0x50 Fixes: 7ae0fa439faf ("nfit, libnvdimm: async region scrub workqueue") Cc: <sta...@vger.kernel.org> Cc: Vishal Verma <vishal.l.ve...@intel.com&

Re: [PATCH] mm, dax: clear PMD or PUD size flags when in fall through path

2017-02-03 Thread Dan Williams
On Tue, Jan 31, 2017 at 1:33 PM, Dave Jiang wrote: > Ross reported that: > Running xfstests generic/030 with XFS + DAX gives me the following kernel BUG, > which I bisected to this commit: mm,fs,dax: Change ->pmd_fault to ->huge_fault > > [ 370.086205] [ cut

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-03 Thread Dan Williams
On Fri, Feb 3, 2017 at 3:25 PM, Dave Jiang wrote: > On 02/03/2017 03:56 PM, kbuild test robot wrote: >> Hi Dave, >> >> [auto build test ERROR on mmotm/master] >> [cannot apply to linus/master linux/master v4.10-rc6 next-20170203] >> [if your patch is applied to the wrong git

Re: [RFC PATCH 10/17] block: introduce bdev_dax_direct_access()

2017-02-01 Thread Dan Williams
On Wed, Feb 1, 2017 at 12:10 AM, Christoph Hellwig <h...@lst.de> wrote: > On Mon, Jan 30, 2017 at 10:16:29AM -0800, Dan Williams wrote: >> Ok, now that dax_map_atomic() is gone, it's much easier to remove >> struct blk_dax_ctl. >> >> We can also move the partition

Re: [RFC PATCH 13/17] fs: update mount_bdev() to lookup dax infrastructure

2017-02-01 Thread Dan Williams
On Wed, Feb 1, 2017 at 12:08 AM, Christoph Hellwig <h...@lst.de> wrote: > On Mon, Jan 30, 2017 at 10:29:12AM -0800, Dan Williams wrote: >> On Mon, Jan 30, 2017 at 4:26 AM, Christoph Hellwig <h...@lst.de> wrote: >> > On Sat, Jan 28, 2017 at 12:37:

[GIT PULL] libnvdimm fixes for 4.10

2017-02-06 Thread Dan Williams
2017-02-04 14:47:31 -0800) Bhumika Goyal (1): nvdimm: constify device_type structures Dan Williams (3): libnvdimm, namespace: do not delete namespace-id 0 acpi, nfit: fix acpi_nfit_flush_probe() crash libn

[ndctl PATCH 2/2] test: expand device-dax test for all alignments

2017-02-04 Thread Dan Williams
Add 4K and 1G alignment testing in addition to the default 2M. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- test.h|2 + test/dax-pmd.c| 12 --- test/device-dax.c | 86 - 3 files changed, 65 inse

[PATCH] libnvdimm, pfn: fix memmap reservation size versus 4K alignment

2017-02-04 Thread Dan Williams
align' attribute, default to HPAGE_SIZE") Cc: <sta...@vger.kernel.org> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/nvdimm/pfn_devs.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_dev

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-07 Thread Dan Williams
On Tue, Feb 7, 2017 at 12:44 AM, Kirill A. Shutemov <kir...@shutemov.name> wrote: > On Mon, Feb 06, 2017 at 09:30:22AM -0800, Dan Williams wrote: >> On Mon, Feb 6, 2017 at 9:27 AM, Christoph Hellwig <h...@infradead.org> wrote: >> > On Mon, Feb 06, 2017 at 08:24:

Re: [PATCH] acpi, nfit: skip ARS on machine-check-recovery capable platforms

2017-02-08 Thread Dan Williams
On Wed, Feb 8, 2017 at 7:10 AM, Jeff Moyer <jmo...@redhat.com> wrote: > Dan Williams <dan.j.willi...@intel.com> writes: > >> If the platform supports machine-check-recovery then there is little >> reason to kick off opportunistic scrubs to collect a media error list.

[PATCH] acpi, nfit: skip ARS on machine-check-recovery capable platforms

2017-02-07 Thread Dan Williams
.ve...@intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit/core.c |6 -- drivers/acpi/nfit/mce.c |7 +++ drivers/acpi/nfit/nfit.h |5 + 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/nfit/core.c b/drive

Re: [PATCH] acpi, nfit: skip ARS on machine-check-recovery capable platforms

2017-02-08 Thread Dan Williams
On Wed, Feb 8, 2017 at 9:42 AM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Wed, Feb 8, 2017 at 7:10 AM, Jeff Moyer <jmo...@redhat.com> wrote: >> Dan Williams <dan.j.willi...@intel.com> writes: >> >>> If the platform supports machine-check-recove

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-06 Thread Dan Williams
On Mon, Feb 6, 2017 at 6:36 AM, Christoph Hellwig wrote: > On Fri, Feb 03, 2017 at 02:31:22PM -0700, Dave Jiang wrote: >> Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has >> been somewhat painful with getting the flags set and removed at the >> correct

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-06 Thread Dan Williams
On Mon, Feb 6, 2017 at 9:27 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Mon, Feb 06, 2017 at 08:24:48AM -0800, Dan Williams wrote: >> > Also can be use this opportunity >> > to fold ->huge_fault into ->fault? >> >> Hmm, yes, just need a

Re: read failure (was Re: mmap dio write failure)

2017-02-07 Thread Dan Williams
On Tue, Feb 7, 2017 at 7:51 PM, Xiong Zhou wrote: > On Fri, Jan 20, 2017 at 12:40:07PM +0800, Xiong Zhou wrote: >> Hi, >> >> At first, I am not sure whether this is an issue. >> >> mmap a file in a DAX mountpoint, open another file >> in a non-DAX mountpoint with O_DIRECT, write

Re: read failure (was Re: mmap dio write failure)

2017-02-07 Thread Dan Williams
On Tue, Feb 7, 2017 at 8:49 PM, Xiong Zhou <xz...@redhat.com> wrote: > On Tue, Feb 07, 2017 at 08:10:14PM -0800, Dan Williams wrote: >> On Tue, Feb 7, 2017 at 7:51 PM, Xiong Zhou <xz...@redhat.com> wrote: >> > On Fri, Jan 20, 2017 at 12:40:07PM +08

[-mm PATCH] mm: fix get_user_pages() vs device-dax pud mappings

2017-02-07 Thread Dan Williams
pmd() to also account for the pud case. Cc: Dave Jiang <dave.ji...@intel.com> Cc: Matthew Wilcox <mawil...@microsoft.com> Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Cc: Kirill A. Shutemov <kirill.shute...@linux.intel.com> Cc: Nilesh Choudhury <nilesh.choudh...@

Re: [PATCH 00/13] dax, pmem: move cpu cache maintenance to libnvdimm

2017-01-22 Thread Dan Williams
On Sat, Jan 21, 2017 at 9:52 AM, Christoph Hellwig wrote: > On Sat, Jan 21, 2017 at 04:28:52PM +, Matthew Wilcox wrote: >> Of course, there may not be a backing device either! > > s/backing device/block device/ ? If so fully agreed. I like the dax_ops > scheme, but we should go

Re: [PATCH 00/13] dax, pmem: move cpu cache maintenance to libnvdimm

2017-01-22 Thread Dan Williams
On Sun, Jan 22, 2017 at 10:37 PM, Matthew Wilcox wrote: > From: Christoph Hellwig [mailto:h...@lst.de] >> On Sun, Jan 22, 2017 at 06:39:28PM +, Matthew Wilcox wrote: >> > Two guests on the same physical machine (or a guest and a host) have access >> > to the same set

[ndctl PATCH v2] ndctl, create-namespace: add an 'align' option

2017-01-23 Thread Dan Williams
using nfit-test resources. Given the nfit_test resources are backed by vmalloc, the only alignment nfit_test can support is 4K. Based on an earlier patch by Dave Jiang. Cc: Dave Jiang <dave.ji...@intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Changes in v2: *

Re: [PATCH 0/3] 1G transparent hugepage support for device dax

2017-01-24 Thread Dan Williams
On Tue, Jan 24, 2017 at 3:12 AM, Jan Kara wrote: > On Mon 23-01-17 16:47:18, Dave Jiang wrote: >> The following series implements support for 1G trasparent hugepage on >> x86 for device dax. The bulk of the code was written by Mathew Wilcox >> a while back supporting transparent 1G

Re: [RFC PATCH v2 0/2] block: fix backing_dev_info lifetime

2017-01-26 Thread Dan Williams
On Thu, Jan 26, 2017 at 5:17 AM, Christoph Hellwig wrote: > On Thu, Jan 26, 2017 at 11:06:53AM +0100, Jan Kara wrote: >> Yeah, so my patches (and I suspect your as well), have a problem when the >> backing_device_info stays around because blkdev inode still exists, device >> gets

[RFC PATCH 01/17] dax: refactor dax-fs into a generic provider of dax inodes

2017-01-28 Thread Dan Williams
m on top of the base dax inode. Filesystem DAX goes through a block_device for now, but perhaps directly to a dax inode in the future, or for new pmem-only filesystems. [1]: https://lkml.org/lkml/2017/1/19/880 Suggested-by: Christoph Hellwig <h...@lst.de> Signed-off-by: Dan Williams <dan.j.wi

[RFC PATCH 02/17] dax: convert dax_inode locking to srcu

2017-01-28 Thread Dan Williams
In preparation for adding dax_operations that perform ->direct_access() and user copy operations relative to a dax_inode, convert the existing dax_inode locking to srcu. Some dax drivers need to sleep in their ->direct_access() methods and user copying may fault / sleep. Signed-off-b

[RFC PATCH 04/17] dax: introduce dax_operations

2017-01-28 Thread Dan Williams
t each dax-driver and teach fs/dax.c to use ->direct_access() from dax_operations instead of block_device_operations. Suggested-by: Christoph Hellwig <h...@lst.de> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/dax/dax.h|4 +++- drivers/dax/device.c |

  1   2   3   4   5   6   7   8   9   10   >