Re: [PATCH] Add Omnivision OV9640 sensor support.

2008-12-07 Thread Hans Verkuil
Hi Trilok, On Sunday 07 December 2008 10:40:51 Trilok Soni wrote: Hi Hans, On Mon, Dec 1, 2008 at 6:21 PM, Trilok Soni [EMAIL PROTECTED] wrote: Hi Hans, I reviewed this sensor driver and it's fine except for one thing: setting the default registers from outside the driver. This is a

Re: [PATCH 0/2] Omap1 updates for 2.6.29 merge window

2008-12-07 Thread Russell King - ARM Linux
On Thu, Dec 04, 2008 at 06:31:04PM -0800, Tony Lindgren wrote: Here are few omap1 specific updates for review. Ok. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 5/6] ARM: OMAP3: Add basic support for Pandora handheld console

2008-12-07 Thread Russell King - ARM Linux
On Fri, Dec 05, 2008 at 12:06:27PM -0800, Tony Lindgren wrote: +#include linux/clk.h Not required. +#include linux/delay.h Not required. +#include linux/err.h Not required. +#include linux/init.h +#include linux/io.h May not be required. +#include linux/kernel.h +#include

Re: [PATCH 5/6] ARM: OMAP2: drop redundant pending write check for gptimer

2008-12-07 Thread Russell King - ARM Linux
On Thu, Dec 04, 2008 at 06:41:21PM -0800, Tony Lindgren wrote: omap_dm_timer_write_reg() already waits for pending writes to complete, so the extra wait in omap_dm_timer_set_load() is superfluous. Is this right? I mean - do you have to wait for each individual write to each register to

Re: [PATCH] Add stlc45xx, wi-fi driver for stlc4550/4560

2008-12-07 Thread Johannes Berg
On Sat, 2008-12-06 at 19:32 +0200, Kalle Valo wrote: +static const u8 default_cal_channels[] = { + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x6c, 0x09, + 0x00, 0x00, 0xc9, 0xff, 0xd8, 0xff, 0x00,

Re: [PATCH] Add stlc45xx, wi-fi driver for stlc4550/4560

2008-12-07 Thread Kalle Valo
Johannes Berg [EMAIL PROTECTED] writes: On Sat, 2008-12-06 at 19:32 +0200, Kalle Valo wrote: +static const u8 default_cal_channels[] = { +0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, +0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x6c, 0x09, [...] +

RE: [PATCH 5/6] ARM: OMAP2: drop redundant pending write check for gptimer

2008-12-07 Thread Woodruff, Richard
On Thu, Dec 04, 2008 at 06:41:21PM -0800, Tony Lindgren wrote: omap_dm_timer_write_reg() already waits for pending writes to complete, so the extra wait in omap_dm_timer_set_load() is superfluous. Is this right? I mean - do you have to wait for each individual write to each register to

Re: [PATCH 5/6] ARM: OMAP2: drop redundant pending write check for gptimer

2008-12-07 Thread Russell King - ARM Linux
On Sun, Dec 07, 2008 at 08:55:54AM -0600, Woodruff, Richard wrote: Yes, NOHZ is _poor_ today in respect to needless reprogramming. Code can be improved. I have sent Thomas a patch for the same which is in the MM tree for a while now. When I discussed this problem with Thomas, his reaction was

Re: [PATCH 5/6] ARM: OMAP2: drop redundant pending write check for gptimer

2008-12-07 Thread Tony Lindgren
* Russell King - ARM Linux [EMAIL PROTECTED] [081207 09:06]: On Sun, Dec 07, 2008 at 08:55:54AM -0600, Woodruff, Richard wrote: Yes, NOHZ is _poor_ today in respect to needless reprogramming. Code can be improved. I have sent Thomas a patch for the same which is in the MM tree for a while

[PATCH 0/5] Omap MMC init updates and new controller for 2.6.29 merge window

2008-12-07 Thread Tony Lindgren
Hi Pierre Russell, This series contains a better platform init for omap MMC as discussed earlier on the linux-omap mailing list. The last patch in the series adds support for a newer omap MMC controller available on 2430 and 34xx omaps. The first four patches should get merged via Russell. The

[PATCH 1/5] omap mmc: Remove broken MMC init code

2008-12-07 Thread Tony Lindgren
Most of the omap1 MMC boards got broken by an earlier patch 138ab9f8321f67c71984ca43222efa71b0a0a0a9. If you look closely, the MMC init funtions are pretty much just stubs. Remove broken init code to make room for cleaner MMC init code. Cc: Pierre Ossman [EMAIL PROTECTED] Signed-off-by: Tony

[PATCH 2/5] omap mmc: Add better MMC low-level init

2008-12-07 Thread Tony Lindgren
This will simplify the MMC low-level init, and make it more flexible to add support for a newer MMC controller in the following patches. The patch rearranges platform data and gets rid of slot vs controller confusion in the old data structures. Also fix device id numbering in the clock code.

[PATCH 3/5] omap mmc: Add low-level initialization for hsmmc controller

2008-12-07 Thread Tony Lindgren
Add low-level initialization for hsmmc controller. Merged into this patch patch are various improvments and board support by Grazvydas Ignotas and David Brownell. Also change wire4 to be wires, as some newer controllers support 8 data lines. Cc: Pierre Ossman [EMAIL PROTECTED] Signed-off-by:

[PATCH 4/5] omap mmc: force MMC module reset on boot

2008-12-07 Thread Tony Lindgren
From: Kevin Hilman [EMAIL PROTECTED] The bootloader may leave the MMC in a state which prevents hitting retention. Even when MMC is not compiled in, each MMC module needs to be forced into reset. Signed-off-by: Kevin Hilman [EMAIL PROTECTED] --- arch/arm/mach-omap2/devices.c | 85

[PATCH 5/5] omap mmc: Add new omap hsmmc controller for 2430 and 34xx

2008-12-07 Thread Tony Lindgren
From: Madhusudhan Chikkature [EMAIL PROTECTED] Add omap hsmmc controller for 2430 and 34xx. Note that this controller has different registers compared to the earlier omap MMC controller, so sharing code currently is not possible. Various updates and fixes from linux-omap list have been merged

Re: [PATCH 5/6] ARM: OMAP3: Add basic support for Pandora handheld console, v2

2008-12-07 Thread Tony Lindgren
Hi, * Russell King - ARM Linux [EMAIL PROTECTED] [081207 03:35]: On Fri, Dec 05, 2008 at 12:06:27PM -0800, Tony Lindgren wrote: +#include linux/clk.h Not required. +#include linux/delay.h Not required. +#include linux/err.h Not required. +#include linux/init.h +#include

RE: [PATCH] Add Omnivision OV9640 sensor support.

2008-12-07 Thread Hiremath, Vaibhav
Hi Soni, Thanks, Vaibhav Hiremath -Original Message- From: [EMAIL PROTECTED] [mailto:linux-omap- [EMAIL PROTECTED] On Behalf Of Trilok Soni Sent: Sunday, December 07, 2008 3:11 PM To: Hans Verkuil Cc: v4l; linux-omap@vger.kernel.org Mailing List; Sakari Ailus Subject: Re: [PATCH]