Re: [PATCHv2 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Peter Ujfalusi
Hello, Looks good, but I have one comment, you can consider if you like it... ... +static int omap_mcbsp2_st_set_mode(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + u8 value = ucontrol-value.integer.value[0]; + + if (value ==

[PATCH] PM-WIP-OPP: Fixing wrong target level being passed during Core DVFS.

2010-02-18 Thread Thara Gopinath
As per the current implementaion (u8*)target_level is being passed to freq_to_opp in set_opp. This would result in updating just the first 8 bits of a u32 variable. Later target_level is passed to resource_set_opp_level as a u32 parameter. This maens a. Initially target_level was 0xabcdefgh. b.

RE: [PATCHv2 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread ilkka.koskinen
From: Ujfalusi Peter (Nokia-D/Tampere) Sent: 18 February, 2010 10:15 Hello, Looks good, but I have one comment, you can consider if you like it... ... +static int omap_mcbsp2_st_set_mode(struct snd_kcontrol *kcontrol, +struct snd_ctl_elem_value *ucontrol) +{

[PATCH 0/9] omap4 updates for 2.6.34

2010-02-18 Thread Shilimkar, Santosh
This series have few omap4 updates and is based on Tony's 'omap-for-linus' branch. This series patches are part of the below series posted on linux-omap for review earlier this week. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg23939.html From the previous series, I have dropped

[PATCH 3/9] omap4: sdma: Enable the idle modes on omap4

2010-02-18 Thread Santosh Shilimkar
This patch enables smart-idle idlemodes and autoidle for sDMA on OMAP4 Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/plat-omap/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index

[PATCH 8/9] omap4: Use dma line defines from dma-44xx.h

2010-02-18 Thread Santosh Shilimkar
This patch removes all the omap4 specific dma request lines defines from plat/dma.h and includes dma-44xx.h The defines are aligned so no driver should be impacted because of this change. Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/plat-omap/include/plat/dma.h | 86

[PATCH 6/9] omap3/4: Remove overlapping mapping of L4_WKUP io space

2010-02-18 Thread Santosh Shilimkar
This patch removes the L4 wakeup io mapping section for omap3 and omap4. L4 wakeup space is part of 4MB L4 space which is already mapped and hence remove the overlapped mapping. Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/io.c | 12

[PATCH 7/9] omap4: Add auto-generated irq and dma headers

2010-02-18 Thread Santosh Shilimkar
These files are generated along with the HWMOD and will eventually be in the existing header files as soon as all drivers will be migrate to omap_hwmod / omap_device. The dma-44xx.h file should be in 'arch/arm/mach-omap2/include/mach/', but this would need dma.h header also present in the mach

[PATCH 4/9] omap: sdma: Limit the secure reserve channel fix for omap3

2010-02-18 Thread Santosh Shilimkar
The commit 'ba50ea7e' reserves DMA channels 0 and 1 on high security devices, in order to avoid collision between kernel dma transfers and ROM code dma transfers. This fix is applicable only for OMAP3 so add an appropriate check. Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com CC:

[PATCH 9/9] omap4: Use irq line defines from irq-44xx.h

2010-02-18 Thread Santosh Shilimkar
This patch removes all the omap4 specific irq line defines from plat/irqs.h and includes auto-generated irqs-44xx.h All the legacy naming style defines are replaced with the one from irqs-44xx.h Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/devices.c

[PATCH] OMAP: HWMOD: Bug fixes in hwmod structure definitions

2010-02-18 Thread Thara Gopinath
This patch corrects the width of some variables in hwmod structures where the values to be stored in these variables exceed the current field width. Signed-off-by: Thara Gopinath th...@ti.com Cc: Paul Walmsley p...@pwsan.com --- arch/arm/plat-omap/include/plat/omap_hwmod.h |6 +++--- 1 files

Re: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in set/get voltage apis

2010-02-18 Thread Mark Brown
On Thu, Feb 18, 2010 at 12:02:49PM +0530, Nayak, Rajendra wrote: This looks wrong - this code is inside a loop over vsel-voltage mappings, if that mapping is wrong and needs to be ignored (which is what this code is doing) then we shouldn't be looking at it at all. Not sure if I

RE: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in set/get voltage apis

2010-02-18 Thread Nayak, Rajendra
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: Thursday, February 18, 2010 3:18 PM To: Nayak, Rajendra Cc: linux-omap@vger.kernel.org; Liam Girdwood; Samuel Ortiz Subject: Re: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in

Re: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in set/get voltage apis

2010-02-18 Thread Mark Brown
On Thu, Feb 18, 2010 at 03:49:29PM +0530, Nayak, Rajendra wrote: The TWL6030 case should be doing something more like other regulator drivers with straightforward mappings between selector and voltage (most of them) and not using the TWL4030 value table. The code is'nt looking into

[PATCH 7/9 v2] omap4: Add auto-generated irq and dma headers

2010-02-18 Thread Santosh Shilimkar
These files are generated along with the HWMOD and will eventually be in the existing header files as soon as all drivers will be migrate to omap_hwmod / omap_device. The dma-44xx.h file should be in 'arch/arm/mach-omap2/include/mach/', but this would need dma.h header also present in the mach

[RESEND] [PATCH V2 2/3]: Adds support for FIFO

2010-02-18 Thread Hemanth V
Pl also find the patch attached, incase corrupted by mailer Thanks Hemanth From 00ae9791a5461fece3c3a89527cf3e8648352c32 Mon Sep 17 00:00:00 2001 From: Hemanth V heman...@ti.com Date: Wed, 2 Dec 2009 18:13:13 +0530 Subject: [PATCH 2/3] Adds support for FIFO and auto chip select mode DMA and

[RESEND][PATCH V2 3/3] Add support for Slave mode

2010-02-18 Thread Hemanth V
Pl also find the patch attached, incase corrupted by mailer Thanks Hemanth From ae4c6a91bbcfc842f97cf48dd13f6de02baae1d3 Mon Sep 17 00:00:00 2001 From: Hemanth V heman...@ti.com Date: Fri, 27 Nov 2009 14:37:20 +0530 Subject: [PATCH 3/3] Add McSPI slave support. This patch adds support for mcspi

Re: [PATCHv2 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
Hi, On Thu, 18 Feb 2010, ext Tony Lindgren wrote: * Ilkka Koskinen ilkka.koski...@nokia.com [100217 06:41]: From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com This

Re: [PATCHv2 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Mark Brown
On Thu, Feb 18, 2010 at 12:58:55PM +0200, Ilkka Koskinen wrote: Is that easiest way to do that? I mean, I'm afraid that the ALSA tree doesn't have Janusz Krzysztofik's McBSP register cache patches nor does it have your omap3: Replace ARCH_OMAP34XX with ARCH_OMAP3 patch either. Anyway, I'll

RE: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in set/get voltage apis

2010-02-18 Thread Nayak, Rajendra
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: Thursday, February 18, 2010 4:11 PM To: Nayak, Rajendra Cc: linux-omap@vger.kernel.org; Liam Girdwood; Samuel Ortiz Subject: Re: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in set/get

Re: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in set/get voltage apis

2010-02-18 Thread Mark Brown
On Thu, Feb 18, 2010 at 05:09:53PM +0530, Nayak, Rajendra wrote: Mark, I get your point. The table values were derived from what the spec suggests, but I agree that its confusing that in theory the formula suggests there could be more selectors than whats present in the table. I will check

RE: [PATCHv4 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Ameya Palande
Hi Fernando, On Thu, 2010-02-18 at 02:52 +0100, ext Guzman Lugo, Fernando wrote: Hi, -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Wednesday, February 17, 2010 12:06 PM To: linux-omap@vger.kernel.org Cc: felipe.contre...@nokia.com; Menon, Nishanth;

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread David Vrabel
Madhusudhan wrote: My question was more related to the idle path. In a scenario where you start using the SDIO functionality and after some time you leave the SDIO card idle, does the FCLK still remain enabled? Or do you see that sdio_irq_thread exits and disables the FCLK? What do you mean

Re: [PATCH 2/2] twl6030: regulator: Configure STATE register instead of REMAP

2010-02-18 Thread Liam Girdwood
On Wed, 2010-02-17 at 20:54 +0530, Rajendra Nayak wrote: This is no REMAP register on twl6030, instead there is a STATE register to drive a resource to a given state. The state register can be used to specify what state the resource should enter when its associated with a GRP. Register Bit

[PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo Valentin sent to alsa-devel mailing list in October 2009. Channel gain control and enabling the sidetone have been moved to ALSA

[PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Ilkka Koskinen
Add ASoC interface for OMAP McBSP2 and McBSP3 sidetones. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- sound/soc/omap/omap-mcbsp.c | 157 +++ sound/soc/omap/omap-mcbsp.h |2 + 2 files changed, 159 insertions(+), 0 deletions(-) diff --git

[PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/mcbsp.c |2 +

Re: [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Jarkko Nikula
On Wed, 17 Feb 2010 16:45:58 +0200 Ilkka Koskinen ilkka.koski...@nokia.com wrote: The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. Do I have something wrong since I cannot adjust the controls? Both McBSP2 Sidetone Channel

Re: [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Jarkko Nikula
On Thu, 18 Feb 2010 14:37:14 +0200 Ilkka Koskinen ilkka.koski...@nokia.com wrote: static inline void __devexit omap34xx_device_exit(struct omap_mcbsp *mcbsp) { - if (cpu_is_omap34xx()) + if (cpu_is_omap34xx()) { omap_additional_remove(mcbsp-dev); + + if

Re: [alsa-devel] [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Peter Ujfalusi
Hello, On Thursday 18 February 2010 15:24:13 ext Jarkko Nikula wrote: On Thu, 18 Feb 2010 14:37:14 +0200 Ilkka Koskinen ilkka.koski...@nokia.com wrote: static inline void __devexit omap34xx_device_exit(struct omap_mcbsp *mcbsp) { - if (cpu_is_omap34xx()) + if

Re: [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Peter Ujfalusi
On Thursday 18 February 2010 15:06:21 ext Jarkko Nikula wrote: On Wed, 17 Feb 2010 16:45:58 +0200 Ilkka Koskinen ilkka.koski...@nokia.com wrote: The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. Do I have something

Re: [PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Peter Ujfalusi
On Thursday 18 February 2010 14:37:15 Koskinen Ilkka (Nokia-D/Tampere) wrote: ... +static int omap_mcbsp_set_st_channel_vol(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol, + int id, int channel) +{

Re: [PATCHv4 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Felipe Contreras
On Thu, Feb 18, 2010 at 01:15:55PM +0100, Ameya Palande wrote: On Thu, 2010-02-18 at 02:52 +0100, ext Guzman Lugo, Fernando wrote: What do you think about it? Instead of removing DRV_InsertDMMResElement make it an inline function with your code inside: Making DRV_InsertDMMResElement

[PATCHv5 0/4] DSPBRIDGE: Improved reserved and mapped resource cleanup

2010-02-18 Thread Ameya Palande
This patch series splits DMM_RES_OBJECT into DMM_MAP_OBJECT and DMM_RSV_OBJECT which are used independently for mapped and reserved memory resources accounting. This will help in cleanup of reserved memory resources which was not handled properly before. With these patches resource cleanup

[PATCH 2/4] DSPBRIDGE: New reserved memory accounting framework

2010-02-18 Thread Ameya Palande
DSP_RSV_OBJECT is introduced to track reserved memory accounting information. This will allow us to do proper cleanup for memory reserved using PROC_ReserveMemory(). Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/drv.h | 10

[PATCH 1/4] DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT

2010-02-18 Thread Ameya Palande
In its current state DMM_RES_OBJECT is not correctly tracking reserve and unreserve but only map and unmap. So lets rename it to DMM_MAP_OBJECT to clarify what it is really doing! In addition to this, this patch also does some trivial code cleanup. Signed-off-by: Ameya Palande

[PATCH 3/4] DSPBRIDGE: Fix memory corruption in DRV_ProcFreeDMMRes

2010-02-18 Thread Ameya Palande
This patch fixes following issues: 1. pDMMRes was dereferenced and modified when it was already freed by PROC_Ummap(). This results in memory corruption. 2. Instead of passing ulDSPAddr, ulDSPResAddr was passed to PROC_UnMap() which will not retrieve correct DMMRes element. Signed-off-by:

[PATCH 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Ameya Palande
This patch improves current mapped memory cleanup mechanism by using linux native list implementation. As a side effect we also get following benefits: 1. Unnecessary data members in DMM_MAP_OBJECT are removed which results in memory saving. 2. Following functions are removed as they are not

Re: [PATCHv4 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Ameya Palande
Hi Felipe, On Thu, 2010-02-18 at 15:27 +0100, Contreras Felipe (Nokia-D/Helsinki) wrote: On Thu, Feb 18, 2010 at 01:15:55PM +0100, Ameya Palande wrote: On Thu, 2010-02-18 at 02:52 +0100, ext Guzman Lugo, Fernando wrote: What do you think about it? Instead of removing

RE: [PATCHv4 2/4] DSPBRIDGE: New reserved memory accounting framework

2010-02-18 Thread Ameya Palande
Hi Fernando, On Thu, 2010-02-18 at 02:40 +0100, ext Guzman Lugo, Fernando wrote: Hi, -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Wednesday, February 17, 2010 12:06 PM To: linux-omap@vger.kernel.org Cc: felipe.contre...@nokia.com; Menon, Nishanth;

[PATCH v6] OMAP UART: Add omap-serial driver support.

2010-02-18 Thread Govindraj.R
From 81fe9a08684830e84e64bed57c7f90e7461a5375 Mon Sep 17 00:00:00 2001 From: Govindraj R govindraj.r...@ti.com Date: Thu, 18 Feb 2010 19:34:04 +0530 Subject: [PATCH] OMAP UART: Add omap-serial driver support. This patch adds support for OMAP-HIGH SPEED UART Controller. It adds support for the

Re: [PATCH] PM-WIP-OPP: Fixing wrong target level being passed during Core DVFS.

2010-02-18 Thread Menon, Nishanth
Gopinath, Thara said the following on 02/18/2010 10:31 AM: As per the current implementaion (u8*)target_level is being passed to freq_to_opp in set_opp. This would result in updating just the first 8 bits of a u32 variable. Later target_level is passed to resource_set_opp_level as a u32

Re: [alsa-devel] [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Jarkko Nikula
On Thu, 18 Feb 2010 15:56:03 +0200 Peter Ujfalusi peter.ujfal...@nokia.com wrote: Are you sure about these ids? Same comment to the patch 2 as well. Worth to check. They are correct. mcbsp-id is 1 based (1 - McBSP1, 2 - McBSP2, etc) While the exported functions expect the id to be 0

Re: PATCH[V2 1/3]: Update Platform files for SPI

2010-02-18 Thread Grant Likely
On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren t...@atomide.com wrote: * Hemanth V heman...@ti.com [100203 02:19]: From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001 From: Hemanth V heman...@ti.com Date: Fri, 27 Nov 2009 14:22:30 +0530 Subject: [PATCH] Update platform files

Problem specifying which gpio_126 to use on omap353x

2010-02-18 Thread Peter Barada
On my board I have an isp1760 hooked up using gpio_126 (pin P27 - MMC1_DAT4/SIM_IO/GPIO_126). From the schematics (and TRM), there is a 2nd gpio_126 on pin D25 (CAM_STROBE/GPIO_126). I tried to use: #define ISP1760_IRQ 126 omap_mux_init_gpio(ISP1760_IRQ, OMAP_PIN_INPUT_PULLUP); if

RE: [PATCH 0/3] mmc: omap_hsmmc: support SDIO cards

2010-02-18 Thread Madhusudhan
snip Also, keep in mind that the buffers for transfers must begin and end on a word boundary. The OMAP's DMA controller can only transfer whole words to the MMC FIFO. I've slightly modified your patch mmc: omap_hsmmc: use packet sync'd DMA and it seems to work now, at least with SD

[PATCH] twl6030: add base addr for ID0, ID1, ID2

2010-02-18 Thread balajitk
From: Balaji T K balaj...@ti.com Add base address for generic slave ID0, ID1, ID2 and introduced one more entry to align RTC module number between twl4030 and twl6030 Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mfd/twl-core.c |7 +-- include/linux/i2c/twl.h |5 + 2

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Madhusudhan
-Original Message- From: David Vrabel [mailto:david.vra...@csr.com] Sent: Thursday, February 18, 2010 6:16 AM To: Madhusudhan Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org Subject: Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts Madhusudhan wrote: My

RE: [PATCH] twl6030: add base addr for ID0, ID1, ID2

2010-02-18 Thread Krishnamoorthy, Balaji T
Sending this as a separate patch which was earlier combined with the series http://marc.info/?l=linux-omapm=126633460408606w=2 -Original Message- From: Krishnamoorthy, Balaji T Sent: Thursday, February 18, 2010 10:30 PM To: linux-omap@vger.kernel.org; sa...@linux.intel.com Cc:

Re: PATCH[V2 1/3]: Update Platform files for SPI

2010-02-18 Thread Tony Lindgren
* Grant Likely grant.lik...@secretlab.ca [100218 08:26]: On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren t...@atomide.com wrote: * Hemanth V heman...@ti.com [100203 02:19]: From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001 From: Hemanth V heman...@ti.com Date: Fri, 27

Re: [PATCHv2 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Tony Lindgren
* Ilkka Koskinen ikosk...@nokia.com [100218 02:54]: Hi, On Thu, 18 Feb 2010, ext Tony Lindgren wrote: * Ilkka Koskinen ilkka.koski...@nokia.com [100217 06:41]: From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices.

Re: [alsa-devel] [PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Ilkka Koskinen
On Thu, 18 Feb 2010, Ujfalusi Peter (Nokia-D/Tampere) wrote: On Thursday 18 February 2010 14:37:15 Koskinen Ilkka (Nokia-D/Tampere) wrote: ... +static int omap_mcbsp_set_st_channel_vol(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol,

Re: [PATCHv2 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Tony Lindgren
* Mark Brown broo...@opensource.wolfsonmicro.com [100218 02:58]: On Thu, Feb 18, 2010 at 12:58:55PM +0200, Ilkka Koskinen wrote: Is that easiest way to do that? I mean, I'm afraid that the ALSA tree doesn't have Janusz Krzysztofik's McBSP register cache patches nor does it have your

Re: [PATCH 7/9] omap4: Add auto-generated irq and dma headers

2010-02-18 Thread Paul Walmsley
Hello Santosh, thanks for sending these in. One minor comment: On Thu, 18 Feb 2010, Santosh Shilimkar wrote: These files are generated along with the HWMOD and will eventually be in the existing header files as soon as all drivers will be migrate to omap_hwmod / omap_device. The

Re: PATCH[V2 1/3]: Update Platform files for SPI

2010-02-18 Thread Grant Likely
On Thu, Feb 18, 2010 at 10:09 AM, Tony Lindgren t...@atomide.com wrote: * Grant Likely grant.lik...@secretlab.ca [100218 08:26]: On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren t...@atomide.com wrote: * Hemanth V heman...@ti.com [100203 02:19]: From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon

RE: [PATCH 7/9] omap4: Add auto-generated irq and dma headers

2010-02-18 Thread Shilimkar, Santosh
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Thursday, February 18, 2010 10:53 PM To: Shilimkar, Santosh Cc: t...@atomide.com; linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Cousson, Benoit Subject: Re: [PATCH 7/9] omap4: Add

Re: [PATCH 0/9] omap4 updates for 2.6.34

2010-02-18 Thread Paul Walmsley
Hi Santosh, On Thu, 18 Feb 2010, Shilimkar, Santosh wrote: This series have few omap4 updates and is based on Tony's 'omap-for-linus' branch. This series patches are part of the below series posted on linux-omap for review earlier this week.

RE: [PATCH 0/9] omap4 updates for 2.6.34

2010-02-18 Thread Shilimkar, Santosh
Thanks Paul !! -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Thursday, February 18, 2010 11:06 PM To: Shilimkar, Santosh Cc: Tony Lindgren; linux-omap@vger.kernel.org; linux-arm-kernel Subject: Re: [PATCH 0/9] omap4 updates for 2.6.34 Hi Santosh, On Thu,

Re: Problem specifying which gpio_126 to use on omap353x

2010-02-18 Thread Tony Lindgren
* Peter Barada peter.bar...@gmail.com [100218 08:36]: On my board I have an isp1760 hooked up using gpio_126 (pin P27 - MMC1_DAT4/SIM_IO/GPIO_126). From the schematics (and TRM), there is a 2nd gpio_126 on pin D25 (CAM_STROBE/GPIO_126). I tried to use: #define ISP1760_IRQ 126

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Paul Walmsley
On Thu, 18 Feb 2010, David Vrabel wrote: Paul Walmsley wrote: Perhaps I'm misunderstanding what you're referring to, but it seems there is some confusion as to what target smart-idle mode does. The TI OMAP 34xx TRM is the one of the most obtuse document I've had to read. An even

Re: [PATCHv5 0/4] DSPBRIDGE: Improved reserved and mapped resource cleanup

2010-02-18 Thread Felipe Contreras
On Thu, Feb 18, 2010 at 03:40:49PM +0100, Ameya Palande wrote: This patch series splits DMM_RES_OBJECT into DMM_MAP_OBJECT and DMM_RSV_OBJECT which are used independently for mapped and reserved memory resources accounting. This will help in cleanup of reserved memory resources which was not

Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-18 Thread Omar Ramirez Luna
On 2/17/2010 10:09 AM, Menon, Nishanth wrote: Hi, From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Friday, February 12, 2010 12:21 AM To: Chitriki Rudramuni, Deepak Cc: linux-omap; Ramirez Luna, Omar; Menon, Nishanth Subject: Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Madhusudhan
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Thursday, February 18, 2010 11:44 AM To: David Vrabel Cc: Madhusudhan; linux-...@vger.kernel.org; linux-omap@vger.kernel.org Subject: Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts On Thu, 18 Feb

[PATCHv4 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 60 +

[PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo Valentin sent to alsa-devel mailing list in October 2009. Channel gain control and enabling the sidetone have been moved to ALSA

[PATCHv4 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Ilkka Koskinen
Add ASoC interface for OMAP McBSP2 and McBSP3 sidetones. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- sound/soc/omap/omap-mcbsp.c | 138 +++ sound/soc/omap/omap-mcbsp.h |2 + 2 files changed, 140 insertions(+), 0 deletions(-) diff --git

Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Hebbar, Shivananda
These patches remove excessive u32 type and replaces it with the Normal C types. Shivananda Hebbar (2) DSPBRIDGE: Excessive u32 Cleanup (u32-short int) DSPBRIDGE: Excessive u32 Cleanup (u32-int) arch/arm/plat-omap/include/dspbridge/_chnl_sm.h | 10

Patch [1/2] DSPBRIDGE: Execessive u32 Cleanup(u32-short int)

2010-02-18 Thread Hebbar, Shivananda
From 9c472382f598ed86fa2fe3f83dd064323918ff5e Mon Sep 17 00:00:00 2001 From: Shivananda Hebbar x0heb...@ti.com Date: Thu, 28 Jan 2010 18:22:56 -0600 Subject: [PATCH] DSPBRIDGE: Execessive u32 Cleanup(u32-short int) This patch removes execessive u32's used in bridge. As part of this, u32 types is

Patch [2/2]: DSPBRIDGE: Execessive u32 Cleanup(u32-int)

2010-02-18 Thread Hebbar, Shivananda
From 8884e6d372daa1ab2e5d3822ec6aa450ebcd0c47 Mon Sep 17 00:00:00 2001 From: Shivananda Hebbar x0heb...@ti.com Date: Mon, 1 Feb 2010 15:27:42 -0600 Subject: [PATCH] DSPBRIDGE: Execessive u32 Cleanup(u32-int) This patch removes execessive u32 types and replaces it with normal int type.

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Nicolas Pitre
On Thu, 18 Feb 2010, Madhusudhan wrote: If I look in the mainline kernel today there is only one SDIO card driver sdio_uart.c. And at least I don't see a way I can test any of these features myself. There are many other SDIO drivers in the kernel today: - The libertas wireless driver

RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Hebbar, Shivananda Sent: Thursday, February 18, 2010 9:24 PM To: linux-omap Subject: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup These patches remove excessive u32

RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Hebbar, Shivananda
Hi, -Original Message- From: Menon, Nishanth Sent: Thursday, February 18, 2010 1:47 PM To: Hebbar, Shivananda; linux-omap Subject: RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-

Re: [PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Jarkko Nikula
On Thu, 18 Feb 2010 20:42:27 +0200 Ilkka Koskinen ilkka.koski...@nokia.com wrote: The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo Valentin sent to alsa-devel mailing list in

Re: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Andy Shevchenko
On Thu, Feb 18, 2010 at 10:10 PM, Hebbar, Shivananda x0heb...@ti.com wrote: What is the motivation of this change? Sometime back ,there was comment on excessive u32ypes used in bridge. http://marc.info/?l=linux-omapm=123998339213416w=2 I respect Artem for his work, but his personal hate of u*

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Madhusudhan
-Original Message- From: Nicolas Pitre [mailto:n...@fluxnic.net] Sent: Thursday, February 18, 2010 1:27 PM To: Madhusudhan Cc: 'Paul Walmsley'; 'David Vrabel'; linux-...@vger.kernel.org; linux- o...@vger.kernel.org Subject: RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Paul Walmsley
Hi, (cc'ing Steve, Richard, Anand) On Thu, 18 Feb 2010, Madhusudhan wrote: Not to add further confusion but as far as I understand SDIO should be able to asynchronously wakeup OMAP regardless of MMC clocks being OFF . As per the SDIO spec DAT1 line is used for signaling the card interrupt

RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Menon, Nishanth
-Original Message- From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] Sent: Thursday, February 18, 2010 10:18 PM To: Hebbar, Shivananda Cc: Menon, Nishanth; linux-omap Subject: Re: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup On Thu, Feb 18, 2010 at 10:10 PM, Hebbar,

[GIT PULL] omap fix for 2.6.33-rc8

2010-02-18 Thread Tony Lindgren
Hi Linus, Please pull one more omap fix from: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus Regards, Tony The following changes since commit 724e6d3fe8003c3f60bf404bf22e4e331327c596: Linus Torvalds (1): Linux 2.6.33-rc8 are available

RE: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-18 Thread Menon, Nishanth
-Original Message- From: Ramirez Luna, Omar Sent: Thursday, February 18, 2010 8:27 PM To: Menon, Nishanth Cc: Ameya Palande; Chitriki Rudramuni, Deepak; linux-omap; Guzman Lugo, Fernando Subject: Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking On 2/17/2010

Re: [PATCH] OMAP: HWMOD: Bug fixes in hwmod structure definitions

2010-02-18 Thread Paul Walmsley
Hello Thara, some comments. On Thu, 18 Feb 2010, Thara Gopinath wrote: This patch corrects the width of some variables in hwmod structures where the values to be stored in these variables exceed the current field width. Signed-off-by: Thara Gopinath th...@ti.com Cc: Paul Walmsley

[PATCH 0/5] Mailbox: Fix issues for OMAP4

2010-02-18 Thread Anna, Suman
From f2e895f74544876572adbe3328aa27d20aa1aec4 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Thu, 18 Feb 2010 14:34:39 -0600 Subject: [PATCH 0/5] Mailbox: Fix issues for OMAP4 This patchset has fixes for OMAP4 mailbox SYSCONFIG register. Also included are patches for improving

[PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-18 Thread Anna, Suman
From 78d00b562548e1d95ad12a4d8121be67950daf68 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Mon, 25 Jan 2010 18:27:21 -0600 Subject: [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning Remove a compiler warning in device-specific mailbox module. Signed-off-by: Suman Anna

[PATCH 3/5] omap: mailbox: correct OMAP4 SIDLEMODE logic

2010-02-18 Thread Anna, Suman
From 18beb1784db07e4eb2b9d10783a309b5caccb979 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Fri, 5 Feb 2010 17:20:26 -0600 Subject: [PATCH 3/5] omap: mailbox: correct OMAP4 SIDLEMODE logic OMAP4 mailbox has a different MAILBOX_SYSCONFIG register. There is now no AutoIdle. The

[PATCH 2/5] omap: mailbox: correct OMAP4 reset logic

2010-02-18 Thread Anna, Suman
From 2488815a9facca29e2da3ddd279de441a5de6a58 Mon Sep 17 00:00:00 2001 From: Suman Anna s-a...@ti.com Date: Tue, 26 Jan 2010 16:55:29 -0600 Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic OMAP4 mailbox has a different register set. There is no MAILBOX_SYSSTATUS register. The reset

[PATCH 4/5] omap2/3/4: mailbox: use dedicated work queue for handling mailbox rx interrupt

2010-02-18 Thread Anna, Suman
From 7410bf2d5c569c83a594b99a62d03b939e4f10b8 Mon Sep 17 00:00:00 2001 From: Rob Clark r...@ti.com Date: Mon, 4 Jan 2010 19:22:03 +0530 Subject: [PATCH 4/5] omap2/3/4: mailbox: use dedicated work queue for handling mailbox rx interrupt keventd_wq is a shared work-queue, and should not be used

[PATCH 5/5] omap2/3/4: mailbox: retries in case of FIFO full

2010-02-18 Thread Anna, Suman
From f2e895f74544876572adbe3328aa27d20aa1aec4 Mon Sep 17 00:00:00 2001 From: Hari Kanigeri h-kanige...@ti.com Date: Fri, 4 Dec 2009 15:52:42 -0600 Subject: [PATCH 5/5] omap2/3/4: mailbox: retries in case of FIFO full This patch enables check for the mailbox fifo full Without this check in some

[PATCH 11/12] DSPBRIDGE: Remove debug header files

2010-02-18 Thread Omar Ramirez Luna
This patch removes header files used in bridge debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbc.h |2 - arch/arm/plat-omap/include/dspbridge/dbg.h | 24 -- arch/arm/plat-omap/include/dspbridge/gt.h |

[PATCH 00/12] Custom debug removal

2010-02-18 Thread Omar Ramirez Luna
Step 2 to remove custom debug tracing. This set of patches gets rid of GT_* and DBG_* functionality, and replaces them to use dev_dbg instead. This is meant to be a follow up of previous debug removal patches. More info on dynamic_debug: http://lwn.net/Articles/286191/ Omar Ramirez Luna (12):

[PATCH 01/12] DSPBRIDGE: global bridge device

2010-02-18 Thread Omar Ramirez Luna
This patch declares and externs a pointer to a bridge device to be used with dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/host_os.h |1 + drivers/dsp/bridge/rmgr/drv_interface.c|4 2 files changed, 5 insertions(+), 0

[PATCH 07/12] DSPBRIDGE: Remove GT_trace variables for wmd

2010-02-18 Thread Omar Ramirez Luna
This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/io_sm.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git

[PATCH 06/12] DSPBRIDGE: Remove GT_trace variables for rmgr

2010-02-18 Thread Omar Ramirez Luna
This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c |2 -- drivers/dsp/bridge/rmgr/disp.c | 10 --

[PATCH 05/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in services

2010-02-18 Thread Omar Ramirez Luna
Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/services/cfg.c|3 +-- drivers/dsp/bridge/services/clk.c|5 ++--- drivers/dsp/bridge/services/regsup.c | 21 + 3 files

[PATCH 04/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in pmgr

2010-02-18 Thread Omar Ramirez Luna
Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/cmm.c |9 +++--- drivers/dsp/bridge/pmgr/cod.c |5 +-- drivers/dsp/bridge/pmgr/dbll.c | 59 +++-

[PATCH 10/12] DSPBRIDGE: Remove custom debugging implementation

2010-02-18 Thread Omar Ramirez Luna
Replace custom debug implementation with a friendly set of pr_err, pr_info and dev_dbg messages. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbg.h | 65 -- arch/arm/plat-omap/include/dspbridge/gt.h | 271 --

[PATCH 02/12] DSPBRIDGE: Change custom GT_trace for dev_dbg

2010-02-18 Thread Omar Ramirez Luna
Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c | 29 - drivers/dsp/bridge/rmgr/disp.c | 58 ++ drivers/dsp/bridge/rmgr/drv.c | 91

[PATCH 12/12] DSPBRIDGE: Remove unused instances of CONFIG_BRIDGE_DEBUG

2010-02-18 Thread Omar Ramirez Luna
Remove unused instances of CONFIG_BRIDGE_DEBUG. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/drv_interface.c |2 -- drivers/dsp/bridge/rmgr/nldr.c |2 -- drivers/dsp/bridge/rmgr/node.c | 10 -- drivers/dsp/bridge/rmgr/proc.c

[PATCH 09/12] DSPBRIDGE: Remove GT_trace variables for services

2010-02-18 Thread Omar Ramirez Luna
This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/services/cfg.c |6 -- drivers/dsp/bridge/services/clk.c |6 --

[PATCH 08/12] DSPBRIDGE: Remove GT_trace variables for pmgr

2010-02-18 Thread Omar Ramirez Luna
This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/chnl.c | 10 -- drivers/dsp/bridge/pmgr/cmm.c |9 - drivers/dsp/bridge/pmgr/cod.c |9

[PATCH 03/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in wmd

2010-02-18 Thread Omar Ramirez Luna
Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/chnl_sm.c|4 +- drivers/dsp/bridge/wmd/io_sm.c | 106 +++-- drivers/dsp/bridge/wmd/mmu_fault.c |9 +-

[PATCH 2/2] DSPBRIDGE: check pointer before dereference

2010-02-18 Thread Omar Ramirez Luna
Change the check for valid handle to detect a possible error, and now use it before dereferencing the pointer. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/msg.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

  1   2   >