Re: I2C Touchscreen OMAP OOPS

2011-01-04 Thread Hemanth V
- Original Message - From: David Lynch Jr. dh...@dlasys.net To: Linux OMAP Mailing List linux-omap@vger.kernel.org Cc: linux-in...@vger.kernel.org; linux-...@vger.kernel.org Sent: Tuesday, January 04, 2011 12:26 PM Subject: I2C Touchscreen OMAP OOPS I am trying to get a vendor

RE: [PATCH v7 4/7] omap3: nand: prefetch in irq mode support

2011-01-04 Thread Ghorai, Sukumar
[..snip...] + if (info-buf_len (info-buf_len bytes)) Meant to use logical AND here? [Ghorai] thanks, you are right. [..snip..] + init_completion(info-comp); You can use INIT_COMPLETION to reset the completion variable. Same change can be done in write below. [..snip..]

Re: [PATCH v1 09/10] OMAP: McBSP: use omap_device APIs to modify SYSCONFIG

2011-01-04 Thread ABRAHAM, KISHON VIJAY
On Tue, Jan 4, 2011 at 1:05 PM, Peter Ujfalusi peter.ujfal...@nokia.com wrote: Hi, On 12/21/10 09:40, ext Kishon Vijay Abraham I wrote: McBSP2/3 in OMAP3 has sidetone feature which requires autoidle to be disabled before starting the sidetone. Also SYSCONFIG register has to be set with

[PATCH 0/2] IRQ-related changes

2011-01-04 Thread Felipe Balbi
Hi, The following two patches are enabling SPARSE_IRQ numbering scheme on OMAP. I lightly tested on a pandaboard and seems to be working fine so far: # cat /proc/interrupts CPU0 CPU1 39: 1 0 GIC TWL6030-PIH 44: 1758 0 GIC DMA

[PATCH 1/2] arm: omap: gpio: don't access irq_desc array directly

2011-01-04 Thread Felipe Balbi
Instead of accessing the irq_desc array directly we can use irq_to_desc(irq). That will allow us to, if wanted, select SPARSE_IRQ and irq_descs will be added to a radix tree, instead of a array. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/plat-omap/gpio.c | 10 +++--- 1 files

[PATCH 2/2] arm: omap: select HAVE_SPARSE_IRQ

2011-01-04 Thread Felipe Balbi
select HAVE_SPARSE_IRQ and irq_descs can be added to a radix tree instead of an array. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/Kconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index d56d21c0..c4ffe2e 100644 ---

Re: [PATCH v1 09/10] OMAP: McBSP: use omap_device APIs to modify SYSCONFIG

2011-01-04 Thread Peter Ujfalusi
On 01/04/11 11:26, ext ABRAHAM, KISHON VIJAY wrote: 1. How we select the WAKE events from McBSP? We need XRDYEN, and RRDYEN bits for wake (in WAKEUPEN register), Ahh.. Ok. This setting still need to be present. Will add it in my next patch version. Thanks. Thanks.

Re: [PATCH 2/2] arm: omap: select HAVE_SPARSE_IRQ

2011-01-04 Thread Russell King - ARM Linux
On Tue, Jan 04, 2011 at 11:39:26AM +0200, Felipe Balbi wrote: select HAVE_SPARSE_IRQ and irq_descs can be added to a radix tree instead of an array. Please move HAVE_GENERIC_HARDIRQS to the config ARM entry, and remove these: config GENERIC_HARDIRQS bool default y config

Re: [PATCH 2/2] arm: omap: select HAVE_SPARSE_IRQ

2011-01-04 Thread Russell King - ARM Linux
On Tue, Jan 04, 2011 at 09:54:10AM +, Russell King - ARM Linux wrote: On Tue, Jan 04, 2011 at 11:39:26AM +0200, Felipe Balbi wrote: select HAVE_SPARSE_IRQ and irq_descs can be added to a radix tree instead of an array. Please move HAVE_GENERIC_HARDIRQS to the config ARM entry, and

[PATCH 0/3] perf, tools: new power trace API

2011-01-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Provides: . calls to machine_suspend trace point, . OMAP support, . API Documentation Applies on top of Thomas's 8 latest power trace API patches, cf. http://marc.info/?l=linux-kernelm=129130827309354w=2 Jean Pihet (3): perf: add calls to suspend trace point

[PATCH 1/3] perf: add calls to suspend trace point

2011-01-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Uses the machine_suspend trace point, called from the generic kernel suspend_enter function. Signed-off-by: Jean Pihet j-pi...@ti.com CC: Thomas Renninger tr...@suse.de --- kernel/power/suspend.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

[PATCH 2/3] perf: add OMAP support for the new power events

2011-01-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The patch adds the new power management trace points for the OMAP architecture. The trace points are for: - default idle handler. Since the cpuidle framework is instrumented in the generic way there is no need to add trace points in the OMAP specific cpuidle

[PATCH 3/3] tools, perf: Documentation for the power events API

2011-01-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Provides documentation for the following: - the new power trace API, - the old (legacy) power trace API, - the DEPRECATED Kconfig option usage. Signed-off-by: Jean Pihet j-pi...@ti.com --- Documentation/trace/events-power.txt | 90

Re: [PATCH 2/2] arm: omap: select HAVE_SPARSE_IRQ

2011-01-04 Thread Felipe Balbi
Hi, On Tue, Jan 04, 2011 at 09:54:10AM +, Russell King - ARM Linux wrote: On Tue, Jan 04, 2011 at 11:39:26AM +0200, Felipe Balbi wrote: select HAVE_SPARSE_IRQ and irq_descs can be added to a radix tree instead of an array. Please move HAVE_GENERIC_HARDIRQS to the config ARM entry, and

Re: [PATCH 1/3] perf: add calls to suspend trace point

2011-01-04 Thread Ingo Molnar
* jean.pi...@newoldbits.com jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Uses the machine_suspend trace point, called from the generic kernel suspend_enter function. Signed-off-by: Jean Pihet j-pi...@ti.com CC: Thomas Renninger tr...@suse.de ---

Re: [PATCH 1/3] perf: add calls to suspend trace point

2011-01-04 Thread Pavel Machek
Hi! Uses the machine_suspend trace point, called from the generic kernel suspend_enter function. Signed-off-by: Jean Pihet j-pi...@ti.com CC: Thomas Renninger tr...@suse.de --- kernel/power/suspend.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH 1/4] arm: omap: gpio: don't access irq_desc array directly

2011-01-04 Thread Felipe Balbi
Instead of accessing the irq_desc array directly we can use irq_to_desc(irq). That will allow us to, if wanted, select SPARSE_IRQ and irq_descs will be added to a radix tree, instead of a array. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/plat-omap/gpio.c | 10 +++--- 1 files

Re: [PATCH v3 0/4] Introduce hardware spinlock framework

2011-01-04 Thread Ohad Ben-Cohen
Hi Andrew, On Sat, Dec 18, 2010 at 2:53 AM, Tony Lindgren t...@atomide.com wrote: * Ohad Ben-Cohen o...@wizery.com [101216 13:34]: Tony, Andrew, can you please have a look ? Any comment or suggestion is appreciated. Looks sane to me from omap point of view and it seems the locks are now

Re: [PATCH v3 07/17] OMAP2,3: DSS2: Build omap_device for each DSS HWIP

2011-01-04 Thread Semwal, Sumit
Hi Tony, On Tue, Jan 4, 2011 at 7:26 AM, Tony Lindgren t...@atomide.com wrote: * Guruswamy Senthilvadivu svad...@ti.com [110103 04:51]: +     char *omap2_oh_name[] = { dss_dss, dss_dispc, dss_rfbi, +                             dss_venc }; +     char *omap3_oh_name[] = { dss_dss, dss_dispc,

Re: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support

2011-01-04 Thread Sergei Shtylyov
Hello. On 03-01-2011 23:44, Felipe Balbi wrote: Moreover, even Felipe also seems to move other musb DMAs (Inventra, CPPI3.0, TUSB) to drivers/dma. Frankly speaking, I doubt that drivers/dma/ will have place for the purely MUSB specific DMA engines such as the named ones (there's no TUSB

[PATCH v8 2/7] omap3: nand: configurable transfer type per board

2011-01-04 Thread Sukumar Ghorai
nand transfer type (sDMA, Polled, prefetch) can be select from board file, enabling all transfer type in driver, by default. this helps in multi-omap build and to select different transfer type for different board. Signed-off-by: Sukumar Ghorai s-gho...@ti.com ---

[PATCH v8 1/7] omap3630: nand: fix device size to work in polled mode

2011-01-04 Thread Sukumar Ghorai
zoom3 and 3630-sdp having the x16 nand device. This patch configure gpmc as x16 and select the currect function in driver for polled mode (without prefetch enable) transfer. Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/board-3430sdp.c |2 +-

[PATCH v8 4/7] omap3: nand: prefetch in irq mode support

2011-01-04 Thread Sukumar Ghorai
This patch enable prefetch-irq mode for nand transfer(read, write) Signed-off-by: Vimal Singh vimalsi...@ti.com Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/board-flash.c |2 + arch/arm/plat-omap/include/plat/nand.h |4 +- drivers/mtd/nand/omap2.c

[PATCH v8 6/7] omap3: nand: ecc layout select from board file

2011-01-04 Thread Sukumar Ghorai
This patch makes it possible to select sw or hw (different layout options) ecc scheme supported by omap nand driver. Signed-off-by: Vimal Singh vimalsi...@ti.com Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/board-flash.c |1 +

[PATCH v8 7/7] omap3: nand: making ecc layout as compatible with romcode ecc

2011-01-04 Thread Sukumar Ghorai
This patch overrides nand ecc layout and bad block descriptor (for 8-bit device) to support hw ecc in romcode layout. So as to have in sync with ecc layout throughout; i.e. x-loader, u-boot and kernel. This enables to flash x-loader, u-boot, kernel, FS images from kernel itself and compatiable

[PATCH v8 3/7] omap: gpmc: enable irq mode in gpmc

2011-01-04 Thread Sukumar Ghorai
add support the irq mode in GPMC. gpmc_init() function move after omap_init_irq() as it has dependecy on irq. Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/board-2430sdp.c|1 + arch/arm/mach-omap2/board-3430sdp.c|1 +

[PATCH v8 5/7] omap3: nand: configurable fifo threshold to gain the throughput

2011-01-04 Thread Sukumar Ghorai
Configure the FIFO THREASHOLD value different for read and write to keep busy both filling and to drain out of FIFO at reading and writing. Signed-off-by: Vimal Singh vimalsi...@ti.com Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/gpmc.c | 11 +++

[PATCH] arm: omap4: panda: remove usb_nop_xceiv_register

2011-01-04 Thread tom . leiming
From: Ming Lei tom.leim...@gmail.com Panda uses twl6030 otg phy instead of internal phy, so removes usb_nop_xceiv_register to make musb working. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Ming Lei tom.leim...@gmail.com --- arch/arm/mach-omap2/board-omap4panda.c |2 -- 1 files changed, 0

Re: [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry

2011-01-04 Thread Uwe Kleine-König
On Tue, Jan 04, 2011 at 02:02:55PM +0200, Felipe Balbi wrote: GENERIC_HARDIRQS is defined under kernel/irq/Kconfig, so it's safe to drop the duplicated entry and simply select HAVE_GENERIC_HARDIRQS. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/Kconfig |8 +--- 1 files

Re: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support

2011-01-04 Thread Felipe Balbi
Hi, (using personal email, left the office) On Tue, 2011-01-04 at 16:06 +0300, Sergei Shtylyov wrote: I think we will get more clarity once we start on this activity. I agree, but I personally don't see that many limiting factors. dmaengine is just a generic API for doing DMA transfers.

Re: [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry

2011-01-04 Thread Felipe Balbi
On Tue, 2011-01-04 at 15:00 +0100, Uwe Kleine-König wrote: On Tue, Jan 04, 2011 at 02:02:55PM +0200, Felipe Balbi wrote: GENERIC_HARDIRQS is defined under kernel/irq/Kconfig, so it's safe to drop the duplicated entry and simply select HAVE_GENERIC_HARDIRQS. Signed-off-by: Felipe Balbi

Re: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support

2011-01-04 Thread Ming Lei
Hi, 2011/1/4 Felipe Balbi m...@felipebalbi.com: The end goal is just to drop all these ad-hoc APIs for accessing DMA on musb code. If this kind of DMA controllers are only used by MUSB, seems not necessary to convert to dmaengine API. Any benefit we can get from the convert? MUSB is

Re: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support

2011-01-04 Thread Felipe Balbi
Hi, On Tue, 2011-01-04 at 22:40 +0800, Ming Lei wrote: The end goal is just to drop all these ad-hoc APIs for accessing DMA on musb code. If this kind of DMA controllers are only used by MUSB, seems not necessary to convert to dmaengine API. Any benefit we can get from the convert?

Re: [PATCH 1/3] perf: add calls to suspend trace point

2011-01-04 Thread Jean Pihet
Hi, On Tue, Jan 4, 2011 at 12:29 PM, Pavel Machek pa...@ucw.cz wrote: Hi! Uses the machine_suspend trace point, called from the generic kernel suspend_enter function. Signed-off-by: Jean Pihet j-pi...@ti.com CC: Thomas Renninger tr...@suse.de ---  kernel/power/suspend.c |    3 +++  1

Re: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support

2011-01-04 Thread Ming Lei
Hi, 2011/1/4 Felipe Balbi m...@felipebalbi.com: Hi, On Tue, 2011-01-04 at 22:40 +0800, Ming Lei wrote: The end goal is just to drop all these ad-hoc APIs for accessing DMA on musb code. If this kind of DMA controllers are only used by MUSB, seems not necessary to convert to dmaengine

Re: I2C Touchscreen OMAP OOPS

2011-01-04 Thread David Lynch Jr.
Thank you; That makes sense. For reference the mcs5000 driver as well as an st1232 driver that was in the linux input patch stream perform I2C xfers in an interrupt context. On Tue, 2011-01-04 at 14:00 +0530, Hemanth V wrote: - Original Message - From: David Lynch

Re: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support

2011-01-04 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: I think we will get more clarity once we start on this activity. I agree, but I personally don't see that many limiting factors. dmaengine is just a generic API for doing DMA transfers. If it's not enough for us currently, we extend it. Putting MUSB DMA

Re: I2C Touchscreen OMAP OOPS

2011-01-04 Thread Aaro Koskinen
Hi, On Tue, 4 Jan 2011, David Lynch Jr. wrote: For reference the mcs5000 driver as well as an st1232 driver that was in the linux input patch stream perform I2C xfers in an interrupt context. They are using threaded IRQ handlers, which might be the solution you are looking for. A. --

Re: [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry

2011-01-04 Thread Russell King - ARM Linux
On Tue, Jan 04, 2011 at 03:00:31PM +0100, Uwe Kleine-König wrote: On Tue, Jan 04, 2011 at 02:02:55PM +0200, Felipe Balbi wrote: GENERIC_HARDIRQS is defined under kernel/irq/Kconfig, so it's safe to drop the duplicated entry and simply select HAVE_GENERIC_HARDIRQS. Signed-off-by: Felipe

RE: [PATCH v3 1/4] TI816X: Update common omap platform files

2011-01-04 Thread Pedanekar, Hemant
Tony Lindgren wrote on Tuesday, January 04, 2011 7:20 AM: * Paul Walmsley p...@pwsan.com [110103 15:06]: Hello Hemant On Mon, 3 Jan 2011, Hemant Pedanekar wrote: This patch updates the common platform files with TI816X support. Also adds new files for TI816X modules base addresseses and

Re: [PATCH 2/3] perf: add OMAP support for the new power events

2011-01-04 Thread Nishanth Menon
jean.pi...@newoldbits.com had written, on 01/04/2011 04:17 AM, the following: [..] diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index 0ec8a04..0ee0b0e 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -29,6 +29,7 @@ #include

Re: [PATCH] omap: boards w/ wl12xx should select REGULATOR_FIXED_VOLTAGE

2011-01-04 Thread Ohad Ben-Cohen
On Wed, Nov 24, 2010 at 12:04 PM, Ohad Ben-Cohen o...@wizery.com wrote: Power to the wl12xx wlan device is controlled by a fixed regulator. Boards that have the wl12xx should select REGULATOR_FIXED_VOLTAGE so users will not be baffled. Signed-off-by: Ohad Ben-Cohen o...@wizery.com --- Hi

[PATCH 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask

2011-01-04 Thread Santosh Shilimkar
struct clockdomain member clktrctrl_mask is available for only for OMAP2 and OMAP3 architectures. Technially it is also used only for these archs but this breaks the build with custom OMAP4 configuration. CC arch/arm/mach-omap2/clockdomain.o arch/arm/mach-omap2/clockdomain.c: In function

[PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement'

2011-01-04 Thread Santosh Shilimkar
Fix below build warnings CC arch/arm/mach-omap2/common.o CC arch/arm/mach-omap2/gpio.o In file included from arch/arm/plat-omap/include/plat/omap_hwmod.h:38, from arch/arm/mach-omap2/gpio.c:25: arch/arm/plat-omap/include/plat/voltage.h: In function

[PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference'

2011-01-04 Thread Santosh Shilimkar
LD init/built-in.o LD .tmp_vmlinux1 arch/arm/mach-omap2/built-in.o: In function `omap2_set_init_voltage': arch/arm/mach-omap2/pm.c:181: undefined reference to `omap_voltage_domain_lookup' arch/arm/mach-omap2/built-in.o: In function `omap4_twl_init': arch/arm/mach-omap2/omap_twl.c:244:

[PATCH 5/5] omap2plus: voltage: Trivial linking fix for 'EINVAL' undeclared

2011-01-04 Thread Santosh Shilimkar
CC arch/arm/mach-omap2/omap_hwmod_common_data.o In file included from arch/arm/plat-omap/include/plat/omap_hwmod.h:38, from arch/arm/mach-omap2/omap_hwmod_common_data.c:20: arch/arm/plat-omap/include/plat/voltage.h: In function 'omap_voltage_late_init':

Re: [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement'

2011-01-04 Thread Nishanth Menon
Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the following: [..] diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat-omap/include/plat/voltage.h index 0ff1233..710f4ea 100644 --- a/arch/arm/plat-omap/include/plat/voltage.h +++

RE: [PATCH 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg'

2011-01-04 Thread Santosh Shilimkar
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, January 05, 2011 12:11 AM To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org; khil...@ti.com; t...@atomide.com; linux-arm-ker...@lists.infradead.org Subject: Re: [PATCH 2/5] omap2plus: prm: Trvial

RE: [PATCH 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask

2011-01-04 Thread Santosh Shilimkar
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, January 05, 2011 12:13 AM To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org; khil...@ti.com; t...@atomide.com; linux-arm-ker...@lists.infradead.org Subject: Re: [PATCH 1/5] omap2plus: clockdomain:

Re: [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference'

2011-01-04 Thread Nishanth Menon
Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the following: [..] diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat-omap/include/plat/voltage.h index 710f4ea..c095351 100644 --- a/arch/arm/plat-omap/include/plat/voltage.h +++

RE: [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference'

2011-01-04 Thread Santosh Shilimkar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Nishanth Menon Sent: Wednesday, January 05, 2011 12:16 AM To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org; khil...@ti.com; t...@atomide.com;

Re: [PATCH 2/3] perf: add OMAP support for the new power events

2011-01-04 Thread Paul Walmsley
Hello Jean, On Tue, 4 Jan 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com The patch adds the new power management trace points for the OMAP architecture. The trace points are for: - default idle handler. Since the cpuidle framework is instrumented in the

Re: [PATCH 5/5] omap2plus: voltage: Trivial linking fix for 'EINVAL' undeclared

2011-01-04 Thread Nishanth Menon
Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the following: CC arch/arm/mach-omap2/omap_hwmod_common_data.o In file included from arch/arm/plat-omap/include/plat/omap_hwmod.h:38, from arch/arm/mach-omap2/omap_hwmod_common_data.c:20:

RE: [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference'

2011-01-04 Thread Santosh Shilimkar
-Original Message- From: Santosh Shilimkar [mailto:santosh.shilim...@ti.com] Sent: Wednesday, January 05, 2011 12:18 AM To: Nishanth Menon Cc: linux-omap@vger.kernel.org; Kevin Hilman; t...@atomide.com; linux-arm-ker...@lists.infradead.org; Thara Gopinath; Kevin Hilman Subject: RE:

RE: [PATCH 5/5] omap2plus: voltage: Trivial linking fix for 'EINVAL' undeclared

2011-01-04 Thread Santosh Shilimkar
-Original Message- From: Nishanth Menon [mailto:n...@ti.com] Sent: Wednesday, January 05, 2011 12:19 AM To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org; khil...@ti.com; t...@atomide.com; linux-arm-ker...@lists.infradead.org; Thara Gopinath; Kevin Hilman Subject: Re: [PATCH 5/5]

Re: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support

2011-01-04 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: On Tue, Jan 04, 2011 at 11:41:05PM +0800, Ming Lei wrote: OMAP GPIOs have many usages or use cases, so we can use gpiolib to simplify access to GPIOs. If GPIOs has only one usage or use case, it is not necessary to access GPIOs by gpiolib. Now this kind of DMA

Re: [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference'

2011-01-04 Thread Nishanth Menon
Santosh Shilimkar had written, on 01/04/2011 12:50 PM, the following: [..] +static inline struct voltagedomain *omap_voltage_domain_lookup(char *name) +{ + return NULL; the omap_voltage_domain_lookup uses ERR_PTR() for all return values which are handled by the callers with IS_ERR()

Re: [PATCH 5/5] omap2plus: voltage: Trivial linking fix for 'EINVAL' undeclared

2011-01-04 Thread Nishanth Menon
Santosh Shilimkar had written, on 01/04/2011 12:51 PM, the following: -Original Message- From: Nishanth Menon [mailto:n...@ti.com] Sent: Wednesday, January 05, 2011 12:19 AM To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org; khil...@ti.com; t...@atomide.com;

Re: [RFT/PATCH 05/10] cbus: retu: move to threaded IRQ and GENIRQ

2011-01-04 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [110103 23:47]: On Tue, Jan 04, 2011 at 09:46:15AM +0200, Felipe Balbi wrote: @@ -593,6 +594,14 @@ static struct twl4030_platform_data sdp3430_twldata = { .vpll2 = sdp3430_vpll2, }; +static void __init sdp3430_twl_init(void) +{ + int

Re: [PATCH] omap: boards w/ wl12xx should select REGULATOR_FIXED_VOLTAGE

2011-01-04 Thread Tony Lindgren
* Ohad Ben-Cohen o...@wizery.com [110104 10:04]: On Wed, Nov 24, 2010 at 12:04 PM, Ohad Ben-Cohen o...@wizery.com wrote: Power to the wl12xx wlan device is controlled by a fixed regulator. Boards that have the wl12xx should select REGULATOR_FIXED_VOLTAGE so users will not be baffled.

Re: [PATCH] omap: boards w/ wl12xx should select REGULATOR_FIXED_VOLTAGE

2011-01-04 Thread Ohad Ben-Cohen
On Tue, Jan 4, 2011 at 9:17 PM, Tony Lindgren t...@atomide.com wrote: * Ohad Ben-Cohen o...@wizery.com [110104 10:04]: On Wed, Nov 24, 2010 at 12:04 PM, Ohad Ben-Cohen o...@wizery.com wrote: Power to the wl12xx wlan device is controlled by a fixed regulator. Boards that have the wl12xx

[PATCH 1/5] omap3|4: mux: make local structures static

2011-01-04 Thread Nishanth Menon
Mux data is passed by pointers to mux.c from the SoC specific mux file, these variables dont really need to be global scope. This fixes the following sparse warnings: arch/arm/mach-omap2/mux44xx.c:547:29: warning: symbol 'omap4_core_cbl_ball' was not declared. Should it be static?

[PATCH 4/5] omap2+: wdt: trivial sparse fixes

2011-01-04 Thread Nishanth Menon
omap2_wd_timer_disable is declared in wdtimer.h and used by hwmod function pointers for usage, the header inclusion is necessary to ensure that the prototype and function remains consistent. omap_wdt_latency is passed as a pointer and does not need global scope Fixes sparse warnings:

[PATCH 5/5] omap2+: pm_bus: make functions used as pointers as static

2011-01-04 Thread Nishanth Menon
omap_pm_runtime_suspend and omap_pm_runtime_resume are used as function pointers and does not really need to be exposed to the world. Fixes sparse warnings: arch/arm/mach-omap2/pm_bus.c:23:5: warning: symbol 'omap_pm_runtime_suspend' was not declared. Should it be static?

[PATCH 0/5] OMAP2+: trivial sparse fixes

2011-01-04 Thread Nishanth Menon
Source: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git branch: omap-for-linus (dc69d1a omap2: Make OMAP2PLUS select OMAP_DM_TIMER) Building for sparse warnings result in the following warnings: http://pastebin.mozilla.org/907954 This is series 2 of the sparse fixes

Re: [PATCH v3 0/4] Introduce hardware spinlock framework

2011-01-04 Thread Andrew Morton
On Tue, 4 Jan 2011 14:23:20 +0200 Ohad Ben-Cohen o...@wizery.com wrote: Hi Andrew, On Sat, Dec 18, 2010 at 2:53 AM, Tony Lindgren t...@atomide.com wrote: * Ohad Ben-Cohen o...@wizery.com [101216 13:34]: Tony, Andrew, can you please have a look ? Any comment or suggestion is

Re: [PATCH 0/2] OMAP: TWL: sparse fixes

2011-01-04 Thread Nishanth Menon
Nishanth Menon had written, on 01/03/2011 04:39 PM, the following: Russell King - ARM Linux had written, on 01/03/2011 04:36 PM, the following: On Mon, Jan 03, 2011 at 12:58:28PM -0600, Nishanth Menon wrote: Source: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git

Re: [PATCH v3 0/4] Introduce hardware spinlock framework

2011-01-04 Thread Ohad Ben-Cohen
On Tue, Jan 4, 2011 at 10:19 PM, Andrew Morton a...@linux-foundation.org wrote: Acked-by: Tony Lindgren t...@atomide.com Can you please have a look at this patch set (see link no. [1] below) ? I looked - it looks reasonable.  This is exactly the wrong time to be looking at large new

Re: [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry

2011-01-04 Thread Uwe Kleine-König
Hi Russell, On Tue, Jan 04, 2011 at 05:33:01PM +, Russell King - ARM Linux wrote: On Tue, Jan 04, 2011 at 03:00:31PM +0100, Uwe Kleine-König wrote: On Tue, Jan 04, 2011 at 02:02:55PM +0200, Felipe Balbi wrote: @@ -171,9 +168,6 @@ config FIQ config ARCH_MTD_XIP bool

Re: [PATCH 0/2] OMAP: TWL: sparse fixes

2011-01-04 Thread Kevin Hilman
On Tue, 2011-01-04 at 10:00 -0800, Kevin Hilman wrote: Nishanth Menon n...@ti.com writes: Source: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git branch: omap-for-linus Doing a rm arch/arm/mach-omap2/*.o;make C=1 arch/arm/mach-omap2/ resulted in the following

Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+

2011-01-04 Thread Kevin Hilman
On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote: Mika Westerberg ext-mika.1.westerb...@nokia.com writes: In case on OMAP2+ we call set_24xx_gpio_triggering() instead of updating reg and l values. However, at the end of the function we perform a write: __raw_writel(l, reg);

Re: [PATCH] OMAP3: PM: Adding T2 enabling of smartreflex

2011-01-04 Thread Kevin Hilman
Thara Gopinath th...@ti.com writes: The smartreflex bit on twl4030 needs to be enabled by default irrespective of whether smartreflex module is enabled on the OMAP side or not. This is because without this bit enabled the voltage scaling through vp forceupdate does not function properly on

Re: [PATCH 1/3] perf: add calls to suspend trace point

2011-01-04 Thread Rafael J. Wysocki
On Tuesday, January 04, 2011, Jean Pihet wrote: Hi, On Tue, Jan 4, 2011 at 12:29 PM, Pavel Machek pa...@ucw.cz wrote: Hi! Uses the machine_suspend trace point, called from the generic kernel suspend_enter function. Signed-off-by: Jean Pihet j-pi...@ti.com CC: Thomas Renninger

Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+

2011-01-04 Thread Tony Lindgren
* Kevin Hilman khil...@ti.com [110104 14:45]: On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote: Mika Westerberg ext-mika.1.westerb...@nokia.com writes: In case on OMAP2+ we call set_24xx_gpio_triggering() instead of updating reg and l values. However, at the end of the function we

Re: [PATCH v3 1/4] TI816X: Update common omap platform files

2011-01-04 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [110104 09:48]: On Tue, 4 Jan 2011, Pedanekar, Hemant wrote: Looking at above, it seems another config option like CONFIG_SOC_OMAP3XXX is also needed in addition to CONFIG_SOC_OMAPTI816X. We already have CONFIG_ARCH_OMAP3430, CONFIG_ARCH_OMAP2430, and

[PATCH] omap: Start using CONFIG_SOC_OMAP (Re: [PATCH v3 1/4] TI816X: Update common omap platform files)

2011-01-04 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [110104 15:25]: * Paul Walmsley p...@pwsan.com [110104 09:48]: On Tue, 4 Jan 2011, Pedanekar, Hemant wrote: Looking at above, it seems another config option like CONFIG_SOC_OMAP3XXX is also needed in addition to CONFIG_SOC_OMAPTI816X. We already

Re: [PATCH v3 06/17] OMAP2,3 DSS2 Move DSS driver register from board file to devices.c

2011-01-04 Thread Kevin Hilman
Guruswamy Senthilvadivu svad...@ti.com writes: From: Senthilvadivu Guruswamy svad...@ti.com omap_display_init function is introduced in devices.c to do the DSS driver registration. So replace platform_device_register or platform_add_devices of DSS with omap_display_init(). Signed-off-by:

Re: [PATCH v3 08/17] OMAP2,3: DSS2: Create platform_driver for each DSS HW IP

2011-01-04 Thread Kevin Hilman
Guruswamy Senthilvadivu svad...@ti.com writes: From: Senthilvadivu Guruswamy svad...@ti.com Hwmod adaptation design requires each of the DSS HW IP to be a platform driver. Platform driver of dsshw has to be registered before of dispc, rfbi, dsi1, venc and omapdisplay driver should be

Re: [PATCH 1/4] arm: omap: gpio: don't access irq_desc array directly

2011-01-04 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Instead of accessing the irq_desc array directly we can use irq_to_desc(irq). That will allow us to, if wanted, select SPARSE_IRQ and irq_descs will be added to a radix tree, instead of a array. Signed-off-by: Felipe Balbi ba...@ti.com Can you refresh this

Re: [PATCH 0/2] OMAP: TWL: sparse fixes

2011-01-04 Thread Russell King - ARM Linux
On Tue, Jan 04, 2011 at 02:37:23PM -0600, Nishanth Menon wrote: hmm.. minor nit (with codesourcery 2010.09-50 - 4.5.1): rm arch/arm/mach-omap2/*.o;make C=1 arch/arm/mach-omap2/ 2Kerr;make C=2 arch/arm/mach-omap2/ 2Kerr1;diff Kerr Kerr1 [..] 1,4d0 arch/arm/mach-omap2/mux.c: In function

Re: [PATCH] arm: omap4: panda: remove usb_nop_xceiv_register

2011-01-04 Thread Kevin Hilman
tom.leim...@gmail.com writes: From: Ming Lei tom.leim...@gmail.com Panda uses twl6030 otg phy instead of internal phy, so removes usb_nop_xceiv_register to make musb working. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Ming Lei tom.leim...@gmail.com Please Cc the linux-arm-kernel list

Re: [PATCH 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg'

2011-01-04 Thread Kevin Hilman
Santosh Shilimkar santosh.shilim...@ti.com writes: -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, January 05, 2011 12:11 AM To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org; khil...@ti.com; t...@atomide.com; linux-arm-ker...@lists.infradead.org

Re: [PATCH 0/5] omap2plus: Trivial build break fixes

2011-01-04 Thread Kevin Hilman
Santosh Shilimkar santosh.shilim...@ti.com writes: These are trivial build fixes which I found while doing some testing 'omap-for-linus' branch. The series is generated against the linux-omap 'omap-for-linus' branch and boot tested on OMAP4430 SDP and OMAP3630 ZOOM. Minor nit in your

Re: [PATCH 5/5] omap2+: pm_bus: make functions used as pointers as static

2011-01-04 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: omap_pm_runtime_suspend and omap_pm_runtime_resume are used as function pointers and does not really need to be exposed to the world. Fixes sparse warnings: arch/arm/mach-omap2/pm_bus.c:23:5: warning: symbol 'omap_pm_runtime_suspend' was not declared.

Re: [PATCH v3 08/17] OMAP2,3: DSS2: Create platform_driver for each DSS HW IP

2011-01-04 Thread Semwal, Sumit
Hi Kevin, On Wed, Jan 5, 2011 at 5:37 AM, Kevin Hilman khil...@ti.com wrote: Guruswamy Senthilvadivu svad...@ti.com writes: From: Senthilvadivu Guruswamy svad...@ti.com Hwmod adaptation design requires each of the DSS HW IP to be a platform driver. Platform driver of dsshw has to be

[PATCH] staging: tidspbridge - configure full L1 MMU range

2011-01-04 Thread Fernando Guzman Lugo
Otherwise a virtual address beyond of the L1 size is used, the MMU hardware will look into a memory that does not belong to L1 translation tables. IOW; the MMU would allow to access any memory, configured or not. Reported-by: Felipe Contreras felipe.contre...@nokia.com Signed-off-by: Fernando

Re: [RFT/PATCH 05/10] cbus: retu: move to threaded IRQ and GENIRQ

2011-01-04 Thread Felipe Balbi
Hi, On Tue, Jan 04, 2011 at 11:14:00AM -0800, Tony Lindgren wrote: I think there's been some patches related to this to get rid of NR_IRQS? Might be worth taking a look at those first as it's a generic solution. Yeah, one way would be to use Sparse IRQ numbering scheme and define different

Re: [PATCH 1/4] arm: omap: gpio: don't access irq_desc array directly

2011-01-04 Thread Felipe Balbi
On Tue, Jan 04, 2011 at 04:24:58PM -0800, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Instead of accessing the irq_desc array directly we can use irq_to_desc(irq). That will allow us to, if wanted, select SPARSE_IRQ and irq_descs will be added to a radix tree, instead of a

Re: [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry

2011-01-04 Thread Felipe Balbi
Hi, On Tue, Jan 04, 2011 at 09:54:45PM +0100, Uwe Kleine-König wrote: If you look at kernel/irq/Kconfig (as I did with the original patch) you'd notice kernel/irq/Kconfig defines both of these symbols being removed when HAVE_GENERIC_HARDIRQS is enabled. If you read the discussion in

Re: [PATCH] arm: omap4: panda: remove usb_nop_xceiv_register

2011-01-04 Thread Felipe Balbi
On Tue, Jan 04, 2011 at 04:29:04PM -0800, Kevin Hilman wrote: tom.leim...@gmail.com writes: From: Ming Lei tom.leim...@gmail.com Panda uses twl6030 otg phy instead of internal phy, This is wrong, it uses both. TWL6030 handles VBUS and ID pin and the internal PHY handles Data Lines. I