[PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields

2011-07-27 Thread Archit Taneja
Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The Latest TRM mentions the correct fields in the register. Signed-off-by: Archit Taneja arc...@ti.com --- .../include/mach/ctrl_module_pad_core_44xx.h |8 1 files changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields

2011-07-27 Thread Santosh Shilimkar
+ Benoit On 7/27/2011 11:50 AM, Archit Taneja wrote: Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The Latest TRM mentions the correct fields in the register. You can mention the TRM version instead of 'latest' Latest is very much relative :) Signed-off-by: Archit

[PATCH 1/2] rtc: twl: Use threaded IRQ, remove IRQ enable in interrupt handler

2011-07-27 Thread Todd Poynor
IRQs disabled on entry to twl_rtc_interrupt is not a consequence of LOCKDEP; both twl6030 and twl4030 explicitly disable IRQs before calling the module IRQ handlers. The ISR should not be enabling IRQs; use a threaded IRQ handler instead. Also fixes warnings: WARNING: at

[PATCH 2/2] rtc: twl: Fix registration vs. init order

2011-07-27 Thread Todd Poynor
Only register as an RTC device after the hardware has been successfully initialized. The RTC class driver will call back to this driver to read a pending alarm, and other drivers watching for new devices on the RTC class may read the RTC time upon registration. Such access might occur while the

Re: [PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields

2011-07-27 Thread Cousson, Benoit
On 7/27/2011 8:21 AM, Shilimkar, Santosh wrote: + Benoit Thanks Santosh, Archit, Could you please send your patch to all the authors of the file, including the maintainers? Without Santosh, I would have missed that one, that seems to highlight a bug in the HW description DB. So it is quite

Re: [linux-pm] [RFC/PATCH v2] PM / Runtime: allow _put_sync() from interrupts-disabled context

2011-07-27 Thread Rafael J. Wysocki
On Wednesday, July 27, 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: On Friday, July 22, 2011, Kevin Hilman wrote: Currently the use of pm_runtime_put_sync() is not safe from interrupts-disabled context because rpm_idle() will release the spinlock and enable

Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()

2011-07-27 Thread Samuel Ortiz
Hi Keshava, On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com usbhs_disable function was invoking clk_enable() instead of clk_disable(), thus only increasing the clock usage counter and preventing this particular clock from

[PATCH v2] OMAP: ctrl: Fix CONTROL_DSIPHY register fields

2011-07-27 Thread Archit Taneja
Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The OMAP4430 Public TRM vV has these fields mentioned correctly. Signed-off-by: Archit Taneja arc...@ti.com Acked-by: Benoit Cousson b-cous...@ti.com --- v2: - Improve commit description. - Define fields in decreasing order of

Re: [PATCH v2] OMAP: ctrl: Fix CONTROL_DSIPHY register fields

2011-07-27 Thread Santosh Shilimkar
On 7/27/2011 4:03 PM, Archit Taneja wrote: Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The OMAP4430 Public TRM vV has these fields mentioned correctly. Signed-off-by: Archit Tanejaarc...@ti.com Acked-by: Benoit Coussonb-cous...@ti.com --- v2: - Improve commit

Re: [PATCHv2] mfd: twl4030: Fix mismatch in mutex lock-unlock

2011-07-27 Thread Samuel Ortiz
Hi Premi, On Mon, Jul 11, 2011 at 08:50:31PM +0530, Sanjeev Premi wrote: A mutex is locked on entry into twl4030_madc_conversion(). Immediate return on some error conditions leaves the mutex locked. This patch ensures that mutex is always unlocked before leaving the function. Patch

Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()

2011-07-27 Thread Munegowda, Keshava
Thanks samuel regards keshava On Wed, Jul 27, 2011 at 3:23 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Keshava, On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com usbhs_disable function was invoking clk_enable() instead of

Re: [PATCH v4] usb: musb: Enable DMA mode1 RX for USB-Mass-Storage

2011-07-27 Thread Felipe Balbi
Hi, On Wed, Jul 27, 2011 at 09:20:02AM +0530, Jassi Brar wrote: On Tue, Jul 26, 2011 at 8:36 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Jul 20, 2011 at 09:48:53AM -0700, Pandita, Vikram wrote: This *today happens to be only UMS* is my exact point here. Can you guarantee no

RE: [PATCH v4 REPOST 18/20] gpio/omap: use pm-runtime framework

2011-07-27 Thread DebBarma, Tarun Kanti
Todd, [...] + /* Initialize the gpio bank registers to init time value */ + omap_gpio_mod_init(bank); omap_gpio_mod_init calls mpuio_init calls platform_driver_register which can't be called in an IRQs off and spinlocked atomic context, for example, device_private_init

Re: [linux-pm] calling runtime PM from system PM methods

2011-07-27 Thread Mark Brown
On Sat, Jun 11, 2011 at 10:56:36PM +0200, Rafael J. Wysocki wrote: On Saturday, June 11, 2011, Mark Brown wrote: that's a very large proportion of the embedded space. It really feels like we could be doing a better job for drivers using these buses, there's a lot of similarities in what

Re: [RFC/PATCH 0/7] decouple platform_device from omap_device

2011-07-27 Thread G, Manjunath Kondaiah
Kevin, On Thu, Jul 21, 2011 at 04:52:10PM -0700, Kevin Hilman wrote: Here's a first whack, proof-of-concept on how we could start to decouple the platform_device from an omap_device. The main RFC is in the last patch, and everything leading up to it are misc. omap_device cleanups that make

Re: [RFC/PATCH 0/7] decouple platform_device from omap_device

2011-07-27 Thread Hilman, Kevin
Hi Manjunath, On Wed, Jul 27, 2011 at 7:04 AM, G, Manjunath Kondaiah manj...@ti.com wrote: Kevin, On Thu, Jul 21, 2011 at 04:52:10PM -0700, Kevin Hilman wrote: Here's a first whack, proof-of-concept on how we could start to decouple the platform_device from an omap_device. The main RFC is

Re: [RFC/PATCH 0/7] decouple platform_device from omap_device

2011-07-27 Thread G, Manjunath Kondaiah
On Wed, Jul 27, 2011 at 02:45:33PM -0700, Hilman, Kevin wrote: Hi Manjunath, On Wed, Jul 27, 2011 at 7:04 AM, G, Manjunath Kondaiah manj...@ti.com wrote: Kevin, On Thu, Jul 21, 2011 at 04:52:10PM -0700, Kevin Hilman wrote: Here's a first whack, proof-of-concept on how we could start to

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-27 Thread Nishanth Menon
On 11:57-20110722, Felipe Balbi wrote: [...] /* Custom OPP enabled for all xM versions */ if (cpu_is_omap3630()) { - struct omap_hwmod *mh = omap_hwmod_lookup(mpu); - struct omap_hwmod *dh = omap_hwmod_lookup(iva); - struct device *dev; +