Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-12 Thread Shubhrajyoti
On Wednesday 12 September 2012 08:51 AM, Mark Brown wrote: On Tue, Sep 11, 2012 at 12:13:20PM +0530, Shubhrajyoti D wrote: Currently in omap2_mcspi_txrx_dma the tx and the rx support is interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma

Re: [PATCHv7 20/23] i2c: omap: switch to threaded IRQ support

2012-09-12 Thread Shubhrajyoti
On Wednesday 12 September 2012 03:21 AM, Wolfram Sang wrote: -omap_i2c_isr(int this_irq, void *dev_id) +omap_i2c_isr(int irq, void *dev_id) { struct omap_i2c_dev *dev = dev_id; + irqreturn_t ret = IRQ_HANDLED; Shouldn't that be IRQ_NONE? Actually we are processing it so I thought it

Re: [PATCH v4 00/21] OMAP UART Patches

2012-09-12 Thread Felipe Balbi
Hi, On Tue, Sep 11, 2012 at 10:02:48PM +, Paul Walmsley wrote: Hi Felipe Just tested these OMAP serial changes at commit e36851d0fa94b0f7802b3cc80406dbd3ef4f2f16 (serial: omap: fix compile breakage). There's good news and bad news... The good news is that after applying this

Re: [PATCH v2] arm: omap: hwmod: make *phy_48m* as the main_clk of ocp2scp

2012-09-12 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 12, 2012 at 3:58 AM, Paul Walmsley p...@pwsan.com wrote: Hi Kishon, BenoƮt, On Fri, 7 Sep 2012, Kishon Vijay Abraham I wrote: Made *ocp2scp_usb_phy_phy_48m* as the main_clk for ocp2scp. Since this ocp2scp module does not have any fck but does have a single opt_clock, it is

Re: [PATCH 07/17] Input: omap-keypad: Remove dependencies to mach includes

2012-09-12 Thread Poddar, Sourav
Hi, On Tue, Sep 11, 2012 at 11:26 PM, Tony Lindgren t...@atomide.com wrote: * Tony Lindgren t...@atomide.com [120910 23:17]: * Felipe Balbi ba...@ti.com [120910 23:02]: static int __devinit omap_kp_probe(struct platform_device *pdev) { - struct omap_kp *omap_kp; I don't see

Re: [PATCHv7 19/23] i2c: omap: always return IRQ_HANDLED

2012-09-12 Thread Shubhrajyoti
On Wednesday 12 September 2012 03:23 AM, Wolfram Sang wrote: Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Can't we just drop this patch since the code gets removed soon anyhow? Or is patch 20/23 changing something I don't see yet? yes it is dropped will update. -- To unsubscribe from this

Re: [PATCHv7 18/23] i2c: omap: remove redundant status read

2012-09-12 Thread Shubhrajyoti
On Wednesday 12 September 2012 03:24 AM, Wolfram Sang wrote: On Tue, Sep 11, 2012 at 03:12:13PM +0530, Shubhrajyoti D wrote: Remove the redundant read of the status register. Commit message is just repeating the subject. Why was the read there and why can it be removed now? It is read and it

[PATCH V2] ARM: OMAP2+: Round of the carve out memory requested to section_size

2012-09-12 Thread R Sricharan
memblock_steal tries to reserve physical memory during boot. When the requested size is not aligned on the section size then, the remaining memory available for lowmem becomes unaligned on the section boundary. There is a issue with this, which is discussed in the thread below.

[PATCH V2] ARM: OMAP: counter: add locking to read_persistent_clock

2012-09-12 Thread R Sricharan
From: Colin Cross ccr...@android.com read_persistent_clock uses a global variable, use a spinlock to ensure non-atomic updates to the variable don't overlap and cause time to move backwards. Signed-off-by: Colin Cross ccr...@android.com Signed-off-by: R Sricharan r.sricha...@ti.com --- [V2]

Re: [PATCH 13/16] ARM: omap: move platform_data definitions

2012-09-12 Thread Pihet-XID, Jean
Hi Arnd, On Tue, Sep 11, 2012 at 2:59 PM, Arnd Bergmann a...@arndb.de wrote: Platform data for device drivers should be defined in include/linux/platform_data/*.h, not in the architecture and platform specific directories. This moves such data out of the omap include directories

Re: [PATCH] CPUFreq: OMAP: remove unnecessary plat/ includes

2012-09-12 Thread Shilimkar, Santosh
On Wed, Sep 12, 2012 at 6:02 AM, Paul Walmsley p...@pwsan.com wrote: Remove some unnecessary plat/ includes that are interfering with multi-subarch ARM kernels. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com Cc: Rafael J. Wysocki r...@sisk.pl Acked-by: Kevin

RE: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread Hebbar, Gururaja
On Tue, Sep 04, 2012 at 18:39:11, Hebbar, Gururaja wrote: HSMMC IP on AM33xx need a special setting to handle High-speed cards. Other platforms like TI81xx, OMAP4 may need this as-well. This depends on the HSMMC IP timing closure done for the high speed cards. From AM335x TRM (SPRUH73F -

RE: [PATCH] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-12 Thread Hebbar, Gururaja
On Tue, Sep 11, 2012 at 11:13:26, S, Venkatraman wrote: On Tue, Sep 4, 2012 at 6:38 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: From: Vaibhav Bedia vaibhav.be...@ti.com In some cases mmc_suspend_host() is not able to claim the host and proceed with the suspend process. The core

Re: [PATCH 1/4] staging: omap-thermal: Correct checkpatch.pl warnings

2012-09-12 Thread Dan Carpenter
On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote: From: J Keerthy j-keer...@ti.com Removes checkpatch warnings on omap-bandgap.c. Which checkpatch.pl warnings? + omap_bandgap_writel(bg_ptr, +

[balbi-usb:merge-result-for-greg 66/99] drivers/usb/core/hub.c:2654 usb_get_hub_port_power_state() error: doing dma on the stack ((null))

2012-09-12 Thread Fengguang Wu
Hi Felipe, FYI, there are new smatch warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git merge-result-for-greg head: 23953bde3e4d6aa8780dc054f6ad9882ac63f4f4 commit: e918fa161f510136fce45a524e934fe20e62c8b1 [66/99] Merge tag 'gadget-for-v3.7' into

Re: [PATCH 1/4] staging: omap-thermal: Correct checkpatch.pl warnings

2012-09-12 Thread Dan Carpenter
On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote: On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote: From: J Keerthy j-keer...@ti.com Removes checkpatch warnings on omap-bandgap.c. Which checkpatch.pl warnings? +

RE: [PATCH] ARM: OMAP2+: TEMP: Round of the carve out memory requested to section_size

2012-09-12 Thread Sricharan R
[..] memblock_steal tries to reserve physical memory during boot. When the requested size is not aligned on the section size then, the remaining memory available for lowmem becomes unaligned on the section boundary. There is a issue with this, which is discussed in the thread below.

Re: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread S, Venkatraman
On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: HSMMC IP on AM33xx need a special setting to handle High-speed cards. Other platforms like TI81xx, OMAP4 may need this as-well. This depends on the HSMMC IP timing closure done for the high speed cards. From AM335x

Re: [balbi-usb:merge-result-for-greg 66/99] drivers/usb/core/hub.c:2654 usb_get_hub_port_power_state() error: doing dma on the stack ((null))

2012-09-12 Thread Dan Carpenter
On Wed, Sep 12, 2012 at 04:26:22PM +0800, Fengguang Wu wrote: Hi Felipe, FYI, there are new smatch warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git merge-result-for-greg head: 23953bde3e4d6aa8780dc054f6ad9882ac63f4f4 commit:

Re: [PATCH] rpmsg: use right device paramter when calling dma_free_coherent function

2012-09-12 Thread Ohad Ben-Cohen
Hi Fernando, On Thu, Aug 30, 2012 at 3:24 AM, Fernando Guzman Lugo fernando.l...@ti.com wrote: dma_alloc/free_coherent APIs requires the platform specific remoteproc device as the device parameter. We are passing vdev-dev.parent to the dma_free_coherent function which is the generic rproc

[GIT PULL] ARM: OMAP2+: some Makefile cleanup for 3.7

2012-09-12 Thread Paul Walmsley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Tony, The following changes since commit 55d512e245bc7699a8800e23df1a24195dd08217: Linux 3.6-rc5 (2012-09-08 16:43:45 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending.git

Re: [PATCH 1/4] staging: omap-thermal: Correct checkpatch.pl warnings

2012-09-12 Thread Valentin, Eduardo
Hello Dan, On Wed, Sep 12, 2012 at 11:26 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote: On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote: From: J Keerthy j-keer...@ti.com Removes checkpatch warnings on

Re: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread T Krishnamoorthy, Balaji
On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: HSMMC IP on AM33xx need a special setting to handle High-speed cards. Other platforms like TI81xx, OMAP4 may need this as-well. This depends on the HSMMC IP timing closure done for the high speed cards. From AM335x

RE: [PATCH v3 10/10] mtd: nand: omap2: use gpmc provided irqs

2012-09-12 Thread Mohammed, Afzal
On Tue, Sep 11, 2012 at 23:51:07, Tony Lindgren wrote: Ah thanks, that's a copy paste UTF-8 issue. I'll just fold in the fixes and push them out to a new devel-gpmc-fixed branch. Thanks Tony Regards Afzal

RE: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation

2012-09-12 Thread Mohammed, Afzal
Hi Tony, On Wed, Sep 12, 2012 at 00:16:06, Tony Lindgren wrote: Here are the timing changes with and without this patch from my n800. You can just diff the two files to see some differences. Hmm.. that was pretty close, OneNAND async,sync as well as tusb sync values were same. But some of

[PATCH v6 0/7] ARM: OMAP2+: PM: introduce the power domains functional states

2012-09-12 Thread Jean Pihet
Here is a re-spin after some comments and suggestions after review and discussions. Implement the functional states for the power domains: - unify the API to use the functional states. The new API consists of the pwrdm_set*_fpwrst and pwrdm_read*_fpwrst functions and is the API to use to

[PATCH 1/7] ARM: OMAP2+: PM: introduce power domains functional states

2012-09-12 Thread Jean Pihet
Introduce the functional states for power domains, which include the power states and the logic states. This patch provides the API functions to set and read the power domains functional state and internal functions to convert between the functional (i.e. logical) and the internal (or registers)

[PATCH 2/7] ARM: OMAP2+: PM: add a lock to protect the powerdomains next state

2012-09-12 Thread Jean Pihet
pwrdm_set_fpwrst, pwrdm_set_next_fpwrst and pwrdm_read_next_fpwrst are intented to be the only API to program and request the next state of a power domain. This patch protects the power domain next state settings and structs from concurrent accesses by the use of a lock. A spinlock is used since

[PATCH 4/7] ARM: OMAP2+: PM: use power domain functional state in stats counters

2012-09-12 Thread Jean Pihet
The PM code uses some counters to keep track of the power domains transitions, in order to provide the information to drivers (in pwrdm_get_context_loss_count) and to expose the information to sysfs for debug purpose. This patch provides the information for each functional state. Signed-off-by:

[PATCH 5/7] ARM: OMAP2+: PM debug: trace the functional power domains states

2012-09-12 Thread Jean Pihet
Trace the power domain transitions using the functional power states, which include the power and logic states. While at it, fix the trace in the case a power domain did not hit the desired state, as reported by Paul Walmsley. Reported-by: Paul Walmsley p...@pwsan.com Signed-off-by: Jean Pihet

[PATCH 3/7] ARM: OMAP2+: PM: use the functional power states API

2012-09-12 Thread Jean Pihet
Use the functional power states as the API to control power domains: - use the PWRDM_FUNC_PWRST_* and PWRDM_LOGIC_MEM_PWRST_* macros for the power states and logic settings, - the function pwrdm_set_next_fpwrst, which controls the power domains next power and logic settings, shall be used

[PATCH 6/7] ARM: OMAP2+: powerdomain: add error logs

2012-09-12 Thread Jean Pihet
From: Nishanth Menon n...@ti.com Silent failure makes debug hard. So, provide rate limited error messages in functional and oft-used code to prevent spam when something goes wrong. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/powerdomain.c | 177

[PATCH 7/7] ARM: OMAP2+: PM: reorganize the powerdomain API in public and private parts

2012-09-12 Thread Jean Pihet
The newly added code for functional power states re-defines the API to query and control the power domains settings. The API is now split in the following parts in powerdomain.h: - the public or external API, to be used by external PM components: cpuidle, suspend, pm, clock* etc. - the

Re: [PATCHv7 00/23]I2C big cleanup

2012-09-12 Thread Shubhrajyoti
On Wednesday 12 September 2012 03:30 AM, Wolfram Sang wrote: Changes since v6: - Fix comments on setting the pdev to NULL. - Trivial changelog update Looks mostly good, thanks. Only a few comments. Oh, and I still get reports about a section mismatch ;) I am using

Re: [PATCHv7 00/23]I2C big cleanup

2012-09-12 Thread Wolfram Sang
I donot see the warning. Am I missing something? I deleted my logfiles already. Ignore it for now, if it comes up again with your new series, I will give a more detailed pointer. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial

[PATCHv8 11/22] i2c: omap: switch to platform_get_irq()

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com that's a nice helper from drivers core which will give us the exact IRQ number, instead of a pointer to an IRQ resource. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c | 12

[PATCHv8 15/22] i2c: omap: simplify IRQ exit path

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com instead of having multiple return points, use a goto statement to make that clearer. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c | 20 1 files changed, 8

[PATCHv8 02/22] i2c: omap: simplify num_bytes handling

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com trivial patch, no functional changes If the fifo is disabled or fifo_size is 0 the num_bytes is set to 1. Else it is set to fifo_size or in case of a draining interrupt the remaining bytes in the buff stat. So the zero check is redundant and can be safely

[PATCHv8 05/22] i2c: omap: simplify omap_i2c_ack_stat()

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com stat BIT(1) is the same as BIT(1), so let's simplify things a bit by removing stat from all omap_i2c_ack_stat() calls. Code snippet (extremely simplified): if (stat NACK) { ... omap_i2c_ack_stat(dev, stat NACK); } if (stat RDR) { ...

[PATCHv8 03/22] i2c: omap: decrease indentation level on data handling

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com The patch intends to decrease the indentation level on the data handling by using the fact that else of if (dev-buf_len) is same as if (!dev-buf_len) if (dev-buf_len) { aaa; } else { bbb; break; } to if (!dev-buf_len) { bbb;

[PATCHv8 17/22] i2c: omap: get rid of the complete label

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com we can ack stat and complete the command from the errata handling itself. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c | 16 +--- 1 files changed, 13 insertions(+), 3

[PATCHv8 07/22] i2c: omap: improve i462 errata handling

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com Make it not depend on ISR's local variables in order to make it easier to re-factor the transmit data loop. Also since we are waiting for XUDF(Transmitter underflow) just before writing data lets not flag the underflow. This is anyways going to go once we write the

[PATCHv8 01/22] i2c: omap: switch to devm_* API

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com that helps deleting some boiler plate code and lets driver-core manage our resources for us. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c | 41

[PATCHv8 04/22] i2c: omap: add blank lines

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com trivial patch to aid readability. No functional changes. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[PATCHv8 18/22] i2c: omap: remove redundant status read

2012-09-12 Thread Shubhrajyoti D
Currently omap_i2c_ack_stat doesn't use the stat variable. After the read of the I2C_STAT_REG it is not used. Remove the redundant read of the status register. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c |2 -- 1 files changed, 0 insertions(+), 2

[PATCHv8 06/22] i2c: omap: split out [XR]DR and [XR]RDY

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com While they do pretty much the same thing, there are a few peculiarities. Specially WRT erratas, it's best to split those out and re-factor the read/write loop to another function which both cases call. This last part will be done on another patch. While at that,

[PATCHv8 10/22] i2c: omap: ack IRQ in parts

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com According to flow diagrams on OMAP TRMs, we should ACK the IRQ as they happen. Signed-off-by: Felipe Balbi ba...@ti.com [Ack the stat OMAP_I2C_STAT_AL in case of arbitration lost] Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c

[PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Shubhrajyoti D
Changes since v1: - removed tabification on patch 6/17 - removed dev_err() which was introduced on patch 09/17 Changes since v2: - do not set full fifo depth in the RDR interrupt. - some changelog updates. - rebase to the Wolfram's tree. Changes since v3:

[PATCHv8 20/22] i2c: omap: remove unnecessary pm_runtime_suspended check

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com before starting any messages we call pm_runtime_get_sync() which will make sure that by the time we program a transfer and our IRQ handler gets called, we're not suspended anymore. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D

[PATCHv8 21/22] i2c: omap: switch over to autosuspend API

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com this helps us reduce unnecessary pm transitions in case we have another i2c message starting soon. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c | 12 ++-- 1 files changed,

[PATCHv8 16/22] i2c: omap: resize fifos before each message

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com This patch will try to avoid the usage of draining feature by reconfiguring the FIFO the start condition of each message based on the message's size. By doing that, we will be better utilizing the FIFO when doing big transfers. While at that also drop the now

[PATCHv8 13/22] i2c: omap: simplify errata check

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com omap_i2c_dev is allocated with kzalloc(), so we need not initialize b_hw to zero. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c |4 +--- 1 files changed, 1 insertions(+), 3

[PATCHv8 12/22] i2c: omap: bus: add a receiver flag

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com that way we can ignore TX IRQs while in receiver mode and ignore RX IRQs while in transmitter mode. Signed-off-by: Felipe Balbi ba...@ti.com [Remove unnecessary braces] Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c |8

[PATCHv8 14/22] i2c: omap: always return IRQ_HANDLED

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com Always return IRQ_HANDLED otherwise we could get our IRQ line disabled due to many spurious IRQs. Signed-off-by: Felipe Balbi ba...@ti.com [Trivial changes to commitlogs] Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c |2

[PATCHv8 19/22] i2c: omap: switch to threaded IRQ support

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com for OMAP2, we can easily switch over to threaded IRQs on the I2C driver. This will allow us to spend less time in hardirq context. Signed-off-by: Felipe Balbi ba...@ti.com [Trivial formating changes] Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---

[PATCHv8 08/22] i2c: omap: re-factor receive/transmit data loop

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com re-factor the common parts to a separate function, so that code is easier to read and understand. No functional changes. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c | 204

[PATCHv8 22/22] i2c: omap: sanitize exit path

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com move the goto out label one line down, so that it can be used when stat is read as zero. All other exits, can be done with a break statement. While at that, also break out as soon as we complete draining IRQ, since at that time we know we transferred everything

[PATCHv8 09/22] i2c: omap: switch over to do {} while loop

2012-09-12 Thread Shubhrajyoti D
From: Felipe Balbi ba...@ti.com this will make sure that we execute at least once. No functional changes otherwise. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/i2c/busses/i2c-omap.c | 20 ++-- 1 files changed, 14

RE: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread Hebbar, Gururaja
On Wed, Sep 12, 2012 at 14:51:34, Krishnamoorthy, Balaji T wrote: On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: HSMMC IP on AM33xx need a special setting to handle High-speed cards. Other platforms like TI81xx, OMAP4 may need this as-well. This depends on

[PATCH 00/11] ASoC: OMAP: Convert to use dmaengine

2012-09-12 Thread Peter Ujfalusi
Hello, This series will switch the OMAP audio to use dmaengine. The final patch which does the switch was based on Russell King's earlier patch. The first 10 patch is to prepare the OMAP audio drivers for a smooth change to dmaengine: - sDMA FRAME sync mode is removed and replaced with PACKET

[PATCH 08/11] ASoC: OMAP: mcbsp, mcpdm, dmic: Let omap-pcm to pick the dma_type

2012-09-12 Thread Peter Ujfalusi
omap-pcm can figure out the correct dma_type based on the stream's format. In this way we can get rid of the plat/dma.h include from these drivers. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- sound/soc/omap/omap-dmic.c | 2 -- sound/soc/omap/omap-mcbsp.c | 3 ---

[PATCH 10/11] ASoC: OMAP: mcbsp, mcpdm, dmic, hdmi: Set dma_data at startup time

2012-09-12 Thread Peter Ujfalusi
Set the dma_data for the stream (snd_soc_dai_set_dma_data) at dai_startup time so omap-pcm will have access to the needed information regarding to the DMA channel earlier. This is needed for the clean dmaengine support. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com ---

[PATCH 11/11] ASoC: omap-pcm: Convert to use dmaengine

2012-09-12 Thread Peter Ujfalusi
Original author: Russell King rmk+ker...@arm.linux.org.uk Switch the omap-pcm to use dmaengine. Certain features are not supported by after dmaengine conversion: 1. No period wakeup mode DMA engine has no way to communicate this information through standard channels. 2. Pause/Resume

[PATCH 07/11] ASoC: omap-mcpdm: Use platform_get_resource_* to get resources

2012-09-12 Thread Peter Ujfalusi
Get the needed resources in a correct way and avoid using defines for them. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- sound/soc/omap/omap-mcpdm.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/sound/soc/omap/omap-mcpdm.c

[PATCH 09/11] ASoC: omap-pcm, omap-hdmi: Change the use of omap_pcm_dma_data-data_type

2012-09-12 Thread Peter Ujfalusi
Instead of the OMAP DMA data type definition the data_type will be used to specify the number of bits the DMA word should be configured or 0 in case when based on the stream's format the omap-pcm can decide the needed DMA word size. This feature is needed for the omap-hdmi where the sDMA need to

[PATCH 01/11] dmaengine: omap: Support for element mode in cyclic DMA

2012-09-12 Thread Peter Ujfalusi
When src_maxburst/dst_maxburst is set to 0 by the users of cyclic DMA (mostly audio) indicates that we should configure the omap DMA to element sync mode instead of packet mode. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 5 - 1 file changed, 4

[PATCH 04/11] ASoC: OMAP: Remove sync_mode from omap_pcm_dma_data struct

2012-09-12 Thread Peter Ujfalusi
The omap-pcm platform driver no longer needs this parameter to select between ELEMENT and PACKET mode. The selection is based on the configured packet_size. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- sound/soc/omap/omap-dmic.c | 1 - sound/soc/omap/omap-hdmi.c | 1 -

[PATCH 06/11] ARM: OMAP4: hwmod_data: Add resource names to McPDM memory ranges

2012-09-12 Thread Peter Ujfalusi
To help the driver to get the correct memory range to access McPDM registers. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c

[PATCH 05/11] ASoC: omap-pcm: Prepare to configure the DMA data_type based on stream properties

2012-09-12 Thread Peter Ujfalusi
Based on the format of the stream the omap-pcm can decide alone what data type should be used with by the sDMA. Keep the possibility for OMAP dai drivers to tell omap-pcm if they want to use different data type. This is needed for the omap-hdmi for example which needs 32bit data type even if the

[PATCH 03/11] ASoC: omap-pcm: Select sDMA synchronization based on packet_size

2012-09-12 Thread Peter Ujfalusi
Since we only have element or packet synchronization we can use the dma_data-packet_size to select the desired mode: if packet_size is 0 we use ELEMENT mode if packet_size is not 0 we use PACKET mode for sDMA synchronization. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com ---

[PATCH 02/11] ASoC: omap-mcbsp: Use sDMA packet mode instead of frame mode

2012-09-12 Thread Peter Ujfalusi
When McBSP is configured in threshold mode we can use sDMA packet mode in all cases. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- sound/soc/omap/omap-mcbsp.c | 47 - 1 file changed, 17 insertions(+), 30 deletions(-) diff --git

[PATCH] perf: Use raw_smp_processor_id insted of smp_processor_id

2012-09-12 Thread Roger Quadros
gets rid of below messages with CONFIG_DEBUG_PREEMPT enabled [ 28.832916] debug_smp_processor_id: 18 callbacks suppressed [ 28.832946] BUG: using smp_processor_id() in preemptible [] code: modprobe/1763 [ 28.841491] caller is pwrdm_set_next_pwrst+0x54/0x120 Tested with perf on

Re: [PATCHv7 20/23] i2c: omap: switch to threaded IRQ support

2012-09-12 Thread Wolfram Sang
On Wed, Sep 12, 2012 at 11:55:39AM +0530, Shubhrajyoti wrote: On Wednesday 12 September 2012 03:21 AM, Wolfram Sang wrote: -omap_i2c_isr(int this_irq, void *dev_id) +omap_i2c_isr(int irq, void *dev_id) { struct omap_i2c_dev *dev = dev_id; +irqreturn_t ret =

Re: [PATCH 11/11] ASoC: omap-pcm: Convert to use dmaengine

2012-09-12 Thread Russell King - ARM Linux
On Wed, Sep 12, 2012 at 02:47:07PM +0300, Peter Ujfalusi wrote: 2. Pause/Resume OMAP DMA engine backend does not support pausing and resuming an in-progress transfer. It is unclear from the specs what effect clearing the enable bit has on the DMA position of a destination

RE: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread Hebbar, Gururaja
On Wed, Sep 12, 2012 at 14:19:51, S, Venkatraman wrote: On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: HSMMC IP on AM33xx need a special setting to handle High-speed cards. Other platforms like TI81xx, OMAP4 may need this as-well. This depends on the HSMMC

Re: [PATCH] perf: Use raw_smp_processor_id insted of smp_processor_id

2012-09-12 Thread Russell King - ARM Linux
On Wed, Sep 12, 2012 at 02:50:10PM +0300, Roger Quadros wrote: gets rid of below messages with CONFIG_DEBUG_PREEMPT enabled [ 28.832916] debug_smp_processor_id: 18 callbacks suppressed [ 28.832946] BUG: using smp_processor_id() in preemptible [] code: modprobe/1763 [

Re: [balbi-usb:merge-result-for-greg 66/99] drivers/usb/core/hub.c:2654 usb_get_hub_port_power_state() error: doing dma on the stack ((null))

2012-09-12 Thread Felipe Balbi
Hi, On Wed, Sep 12, 2012 at 11:50:57AM +0300, Dan Carpenter wrote: On Wed, Sep 12, 2012 at 04:26:22PM +0800, Fengguang Wu wrote: Hi Felipe, FYI, there are new smatch warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git merge-result-for-greg

Re: [balbi-usb:merge-result-for-greg 66/99] drivers/usb/core/hub.c:2654 usb_get_hub_port_power_state() error: doing dma on the stack ((null))

2012-09-12 Thread Fengguang Wu
On Wed, Sep 12, 2012 at 03:02:13PM +0300, Felipe Balbi wrote: Hi, On Wed, Sep 12, 2012 at 11:50:57AM +0300, Dan Carpenter wrote: On Wed, Sep 12, 2012 at 04:26:22PM +0800, Fengguang Wu wrote: Hi Felipe, FYI, there are new smatch warnings show up in tree:

Re: [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T

2012-09-12 Thread Cyril Chemparathy
On 9/12/2012 1:50 AM, R Sricharan wrote: Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected. Adding a string description in the Kconfig resolves this. But not sure if this is the right way to fix this. Shouldn't you be selecting this in your

RE: [PATCH 4/4] can: c_can: Add d_can suspend resume support

2012-09-12 Thread AnilKumar, Chimata
Hi Marc, On Tue, Sep 04, 2012 at 12:57:18, Marc Kleine-Budde wrote: On 09/04/2012 08:14 AM, AnilKumar, Chimata wrote: Marc, Thanks for the comments, On Tue, Sep 04, 2012 at 01:31:35, Marc Kleine-Budde wrote: On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Adds suspend resume support

Re: [PATCH 11/11] ASoC: omap-pcm: Convert to use dmaengine

2012-09-12 Thread Peter Ujfalusi
On 09/12/2012 03:00 PM, Russell King - ARM Linux wrote: On Wed, Sep 12, 2012 at 02:47:07PM +0300, Peter Ujfalusi wrote: 2. Pause/Resume OMAP DMA engine backend does not support pausing and resuming an in-progress transfer. It is unclear from the specs what effect clearing the enable

Re: [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T

2012-09-12 Thread Catalin Marinas
On Wed, Sep 12, 2012 at 01:46:18PM +0100, Cyril Chemparathy wrote: On 9/12/2012 1:50 AM, R Sricharan wrote: Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected. Adding a string description in the Kconfig resolves this. But not sure if this is

Re: [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T

2012-09-12 Thread Shilimkar, Santosh
On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy cy...@ti.com wrote: On 9/12/2012 1:50 AM, R Sricharan wrote: Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected. Adding a string description in the Kconfig resolves this. But not sure if this

Re: [PATCH 4/4] can: c_can: Add d_can suspend resume support

2012-09-12 Thread Marc Kleine-Budde
On 09/12/2012 02:48 PM, AnilKumar, Chimata wrote: Hi Marc, On Tue, Sep 04, 2012 at 12:57:18, Marc Kleine-Budde wrote: On 09/04/2012 08:14 AM, AnilKumar, Chimata wrote: Marc, Thanks for the comments, On Tue, Sep 04, 2012 at 01:31:35, Marc Kleine-Budde wrote: On 09/03/2012 01:52 PM,

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Wolfram Sang
On Wed, Sep 12, 2012 at 04:27:54PM +0530, Shubhrajyoti D wrote: Changes since v1: - removed tabification on patch 6/17 - removed dev_err() which was introduced on patch 09/17 Changes since v2: - do not set full fifo depth in the RDR interrupt. - some changelog

Re: [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T

2012-09-12 Thread Catalin Marinas
On Wed, Sep 12, 2012 at 01:57:26PM +0100, Shilimkar, Santosh wrote: On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy cy...@ti.com wrote: On 9/12/2012 1:50 AM, R Sricharan wrote: Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected. Adding

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Shubhrajyoti
On Wednesday 12 September 2012 06:46 PM, Wolfram Sang wrote: Tested on omap4sdp and 3430sdp. The following changes since commit 55d512e245bc7699a8800e23df1a24195dd08217: Linux 3.6-rc5 (2012-09-08 16:43:45 -0700) are available in the git repository at:

Re: [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T

2012-09-12 Thread R, Sricharan
Hi, On Wed, Sep 12, 2012 at 6:55 PM, Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Wed, Sep 12, 2012 at 6:49 PM, Catalin Marinas catalin.mari...@arm.com wrote: On Wed, Sep 12, 2012 at 01:57:26PM +0100, Shilimkar, Santosh wrote: On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy

Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-12 Thread Felipe Balbi
On Tue, Sep 11, 2012 at 12:13:20PM +0530, Shubhrajyoti D wrote: Currently in omap2_mcspi_txrx_dma the tx and the rx support is interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma and call the functions. While at it remove the braces in the

Re: [PATCHv7 00/23]I2C big cleanup

2012-09-12 Thread Wolfram Sang
On Wed, Sep 12, 2012 at 12:18:50PM +0200, Wolfram Sang wrote: I donot see the warning. Am I missing something? I deleted my logfiles already. Ignore it for now, if it comes up again with your new series, I will give a more detailed pointer. Sorry, the section mismatch was not related to

Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-12 Thread Shubhrajyoti
On Wednesday 12 September 2012 07:09 PM, Felipe Balbi wrote: seems to be working fine (at least from my quick tests) Tested-by: Felipe Balbi ba...@ti.com Thanks Felipe. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-12 Thread Mark Brown
On Tue, Sep 11, 2012 at 12:13:20PM +0530, Shubhrajyoti D wrote: Currently in omap2_mcspi_txrx_dma the tx and the rx support is interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma and call the functions. Applied, thanks. -- To unsubscribe from

Re: [PATCH] omap-i2c: fix incorrect log message when using a device tree

2012-09-12 Thread Wolfram Sang
On Fri, Aug 31, 2012 at 01:02:55PM +0200, Florian Vaussard wrote: When booting using a device tree, the adapter number is dynamically assigned after the log message is sent. This patch modifies the log message to get a correct adapter id. Applies on 3.6-rc3. Tested on OMAP3 (Gumstix Overo).

Re: [PATCH] CPUFreq: OMAP: remove unnecessary plat/ includes

2012-09-12 Thread Kevin Hilman
Shilimkar, Santosh santosh.shilim...@ti.com writes: On Wed, Sep 12, 2012 at 6:02 AM, Paul Walmsley p...@pwsan.com wrote: Remove some unnecessary plat/ includes that are interfering with multi-subarch ARM kernels. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com

Re: [alsa-devel] [PATCH 11/11] ASoC: omap-pcm: Convert to use dmaengine

2012-09-12 Thread Takashi Iwai
At Wed, 12 Sep 2012 13:00:28 +0100, Russell King - ARM Linux wrote: On Wed, Sep 12, 2012 at 02:47:07PM +0300, Peter Ujfalusi wrote: 2. Pause/Resume OMAP DMA engine backend does not support pausing and resuming an in-progress transfer. It is unclear from the specs what effect

Re: [PATCH 1/4] staging: omap-thermal: Correct checkpatch.pl warnings

2012-09-12 Thread Dan Carpenter
On Wed, Sep 12, 2012 at 12:19:00PM +0300, Valentin, Eduardo wrote: Hello Dan, On Wed, Sep 12, 2012 at 11:26 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote: On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote:

Re: [PATCH 11/11] ASoC: omap-pcm: Convert to use dmaengine

2012-09-12 Thread Peter Ujfalusi
On 09/12/2012 03:53 PM, Peter Ujfalusi wrote: I need to look at this, but at first look we do wait for the drain in omap_stop_dma(). We used to use omap_stop_dma/omap_start_dma for pause/resume operations. But sDMA also have a bit: CDPi: PAUSE_LINK_LIST which should do what we are looking

[PATCH] ARM: OMAP: rx51: Fix a section mismatch warn

2012-09-12 Thread Shubhrajyoti D
rx51_si4713_dev is referenced only from rx51_init_si4713. So the memory for rx51_si4713_dev can be safely freed after init. Also it references rx51_si4713_board_info which is __initdata_or_module. fixes the below warning. WARNING: vmlinux.o(.data+0x30958): Section mismatch in reference from the

Re: [PATCHv7 00/23]I2C big cleanup

2012-09-12 Thread Shubhrajyoti Datta
On Wed, Sep 12, 2012 at 7:14 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Wed, Sep 12, 2012 at 12:18:50PM +0200, Wolfram Sang wrote: I donot see the warning. Am I missing something? I deleted my logfiles already. Ignore it for now, if it comes up again with your new series, I will give

Re: [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T

2012-09-12 Thread Russell King - ARM Linux
On Wed, Sep 12, 2012 at 06:50:00PM +0530, R, Sricharan wrote: Hi, On Wed, Sep 12, 2012 at 6:27 PM, Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy cy...@ti.com wrote: On 9/12/2012 1:50 AM, R Sricharan wrote: Even if

  1   2   >