Re: [PATCH 3/4] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Mugunthan V N
On Thursday 22 August 2013 05:07 PM, Daniel Mack wrote: The cpsw currently lacks code to properly set up the hardware interface mode on AM33xx. Other platforms might be equally affected. Usually, the bootloader will configure the control module register, so probably that's why such support

Re: [PATCH 1/3] misc: Add crossbar driver

2013-08-23 Thread Sricharan R
Hi, On Friday 23 August 2013 10:17 AM, Rajendra Nayak wrote: On Thursday 22 August 2013 05:03 PM, Sricharan R wrote: maps crossbar number- to interrupt number and calls request_irq(int_no, crossbar_handler,..) So will this mapping happen based on some data passed from DT or just based on

Re: [PATCH 3/4] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Mugunthan V N
On Friday 23 August 2013 11:00 AM, Sekhar Nori wrote: @@ -728,6 +736,44 @@ static void _cpsw_adjust_link(struct cpsw_slave *slave, u32 mac_control = 0; u32 slave_port; + if (priv-gmii_sel_reg of_machine_is_compatible(ti,am33xx)) { This

Re: [PATCH 1/3] misc: Add crossbar driver

2013-08-23 Thread Rajendra Nayak
On Friday 23 August 2013 11:41 AM, Sricharan R wrote: Hi, On Friday 23 August 2013 10:17 AM, Rajendra Nayak wrote: On Thursday 22 August 2013 05:03 PM, Sricharan R wrote: maps crossbar number- to interrupt number and calls request_irq(int_no, crossbar_handler,..) So will this mapping

Re: [PATCH v2] ARM: OMAP2: use 'int' instead of 'unsigned' for variable 'gpmc_irq_start'

2013-08-23 Thread Chen Gang
On 08/23/2013 01:48 PM, Tony Lindgren wrote: * Chen Gang F T chen.gang.flying.transfor...@gmail.com [130822 02:08]: Hmm... I guess: for our case, what your meaning is fixes-none-urgent, not fixes-none-critical, is it correct ? :-) Right, that naming might be actually better :) Tony

Re: [PATCH 1/3] misc: Add crossbar driver

2013-08-23 Thread Sekhar Nori
On Friday 23 August 2013 11:41 AM, Sricharan R wrote: Hi, On Friday 23 August 2013 10:17 AM, Rajendra Nayak wrote: On Thursday 22 August 2013 05:03 PM, Sricharan R wrote: maps crossbar number- to interrupt number and calls request_irq(int_no, crossbar_handler,..) So will this mapping

Re: [PATCH 1/3] misc: Add crossbar driver

2013-08-23 Thread Sricharan R
On Friday 23 August 2013 12:06 PM, Sekhar Nori wrote: On Friday 23 August 2013 11:41 AM, Sricharan R wrote: Hi, On Friday 23 August 2013 10:17 AM, Rajendra Nayak wrote: On Thursday 22 August 2013 05:03 PM, Sricharan R wrote: maps crossbar number- to interrupt number and calls

Re: [PATCH] ARM: VExpress: Kconfig: avoid arm6 compatible for ARCH_VEXPRESS

2013-08-23 Thread Chen Gang
On 08/23/2013 01:51 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130822 20:20]: The related error: /tmp/ccOMIprI.s: Assembler messages: /tmp/ccOMIprI.s:507: Error: selected processor does not support ARM mode `isb ' /tmp/ccOMIprI.s:513: Error: selected processor does

Re: [PATCH] ARM: VExpress: Kconfig: avoid arm6 compatible for ARCH_VEXPRESS

2013-08-23 Thread Chen Gang
On 08/23/2013 03:02 PM, Chen Gang wrote: On 08/23/2013 01:51 PM, Tony Lindgren wrote: * Chen Gang gang.c...@asianux.com [130822 20:20]: The related error: /tmp/ccOMIprI.s: Assembler messages: /tmp/ccOMIprI.s:507: Error: selected processor does not support ARM mode `isb '

Re: [PATCH v2] ARM: VExpress: Makefile: add armv7 flags for inline assmembly code compiling

2013-08-23 Thread Chen Gang
On 08/23/2013 04:02 PM, Chen Gang wrote: When vexpress kernel is compiled for v6, it still can support armv7 instructions (hardware still support), so need let compiler know about it for related inline assembly code, or compiling will fail. Hmm... need change compiled for v6, it still can to

Re: [PATCH 3/4] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Daniel Mack
On 23.08.2013 08:14, Mugunthan V N wrote: On Friday 23 August 2013 11:00 AM, Sekhar Nori wrote: @@ -728,6 +736,44 @@ static void _cpsw_adjust_link(struct cpsw_slave *slave, u32 mac_control = 0; u32 slave_port; + if (priv-gmii_sel_reg

Re: [PATCH 1/3] misc: Add crossbar driver

2013-08-23 Thread Sekhar Nori
On Friday 23 August 2013 12:23 PM, Sricharan R wrote: On Friday 23 August 2013 12:06 PM, Sekhar Nori wrote: On Friday 23 August 2013 11:41 AM, Sricharan R wrote: Hi, On Friday 23 August 2013 10:17 AM, Rajendra Nayak wrote: On Thursday 22 August 2013 05:03 PM, Sricharan R wrote: maps

[PATCH v2] ARM: VExpress: Makefile: add armv7 flags for inline assmembly code compiling

2013-08-23 Thread Chen Gang
When vexpress kernel is compiled for v6, it still can support armv7 instructions (hardware still support), so need let compiler know about it for related inline assembly code, or compiling will fail. The related failure command: arm-linux-gnueabi-gcc -Wp,-MD,arch/arm/mach-vexpress/.dcscb.o.d

[PATCH v2 0/5] cpsw: support for control module register

2013-08-23 Thread Daniel Mack
v1 - v2: * combine devm_request_mem_region() and devm_ioremap() and use devm_ioremap_resource() (reported by Sergei Shtylyov) * fix multi-line comment style (reported by Sergei Shtylyov) * fix ti,rmii-clock-ext property name (reported by Sekhar) * rebased

[PATCH v2 5/5] ARM: dts: am33xx: adopt to cpsw changes

2013-08-23 Thread Daniel Mack
This third memory region just denotes one single register in the CONTROL module block. The driver uses that in order to set the correct physical ethernet interface modes. Also update the compatible string to make use of the am335x specific features of the cpsw driver. Signed-off-by: Daniel Mack

[PATCH v2 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Daniel Mack
In order to support features that are specific to the AM335x IP, we have to add hardware types and another compatible string. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/net/cpsw.txt | 3 ++- drivers/net/ethernet/ti/cpsw.c | 32

[PATCH v2 1/5] net: ethernet: cpsw: switch to devres allocations

2013-08-23 Thread Daniel Mack
This patch cleans up the allocation and error unwind paths, which allows us to carry less information in struct cpsw_priv and reduce the amount of jump labels in the probe functions. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/net/ethernet/ti/cpsw.c | 145

[PATCH v2 4/5] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Daniel Mack
The cpsw currently lacks code to properly set up the hardware interface mode on AM33xx. Other platforms might be equally affected. Usually, the bootloader will configure the control module register, so probably that's why such support wasn't needed in the past. In suspend mode though, this

[PATCH v2 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Daniel Mack
At least the AM33xx SoC has a control module register to configure details such as the hardware ethernet interface mode. I'm not sure whether all SoCs which feature the cpsw block have such a register, so that third memory region is considered optional for now. Signed-off-by: Daniel Mack

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-23 Thread Wolfram Sang
On Thu, Aug 22, 2013 at 06:00:14PM +0200, Wolfram Sang wrote: I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and the core, and so we can finally register child

Re: [PATCH v3 1/2] rtc: omap: update of_device_id to reflect latest ip revisions

2013-08-23 Thread Sekhar Nori
Hi Benoit, Did you get a chance to think about this, I have provided some replies below. On Friday 16 August 2013 10:03 PM, Benoit Cousson wrote: Hi Sekhar, On 16/08/2013 17:41, Sekhar Nori wrote: On 8/16/2013 7:45 PM, Benoit Cousson wrote: Hi Gururaja, On 16/08/2013 13:36, Hebbar,

Re: [PATCH v2 5/5] ARM: dts: am33xx: adopt to cpsw changes

2013-08-23 Thread Sekhar Nori
On Friday 23 August 2013 02:13 PM, Daniel Mack wrote: This third memory region just denotes one single register in the CONTROL module block. The driver uses that in order to set the correct physical ethernet interface modes. Also update the compatible string to make use of the am335x

Re: [PATCH v2 5/5] ARM: dts: am33xx: adopt to cpsw changes

2013-08-23 Thread Daniel Mack
On 23.08.2013 11:28, Sekhar Nori wrote: On Friday 23 August 2013 02:13 PM, Daniel Mack wrote: This third memory region just denotes one single register in the CONTROL module block. The driver uses that in order to set the correct physical ethernet interface modes. Also update the compatible

Re: [PATCH v2 5/5] ARM: dts: am33xx: adopt to cpsw changes

2013-08-23 Thread Sekhar Nori
On Friday 23 August 2013 03:04 PM, Daniel Mack wrote: On 23.08.2013 11:28, Sekhar Nori wrote: On Friday 23 August 2013 02:13 PM, Daniel Mack wrote: This third memory region just denotes one single register in the CONTROL module block. The driver uses that in order to set the correct physical

Re: [PATCH v4] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

2013-08-23 Thread Kishon Vijay Abraham I
Hi, On Friday 23 August 2013 02:20 AM, Stephen Warren wrote: On 08/22/2013 02:31 AM, Kishon Vijay Abraham I wrote: The Palmas device contains only a USB VBUS-ID detector, so added a compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible types for backward compatibility.

Re: [PATCH v2 5/5] ARM: dts: am33xx: adopt to cpsw changes

2013-08-23 Thread Daniel Mack
On 23.08.2013 11:40, Sekhar Nori wrote: On Friday 23 August 2013 03:04 PM, Daniel Mack wrote: On 23.08.2013 11:28, Sekhar Nori wrote: Ok, thanks. Given that this last patch will be merged through another tree, can I just resend it separately, while David takes the rest as it is? Ideally

[PATCH v3 0/5] cpsw: support for control module register

2013-08-23 Thread Daniel Mack
v2 - v3: * swap ti,am3352-cpsw and ti,cpsw to work around a matching bug (reported by Sekhar) v1 - v2: * combine devm_request_mem_region() and devm_ioremap() and use devm_ioremap_resource() (reported by Sergei Shtylyov) * fix multi-line comment style

[PATCH v3 5/5] ARM: dts: am33xx: adopt to cpsw changes

2013-08-23 Thread Daniel Mack
This third memory region just denotes one single register in the CONTROL module block. The driver uses that in order to set the correct physical ethernet interface modes. Also update the compatible string to make use of the am335x specific features of the cpsw driver. Signed-off-by: Daniel Mack

[PATCH v3 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Daniel Mack
In order to support features that are specific to the AM335x IP, we have to add hardware types and another compatible string. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/net/cpsw.txt | 3 ++- drivers/net/ethernet/ti/cpsw.c | 32

[PATCH v3 4/5] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Daniel Mack
The cpsw currently lacks code to properly set up the hardware interface mode on AM33xx. Other platforms might be equally affected. Usually, the bootloader will configure the control module register, so probably that's why such support wasn't needed in the past. In suspend mode though, this

[PATCH v3 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Daniel Mack
At least the AM33xx SoC has a control module register to configure details such as the hardware ethernet interface mode. I'm not sure whether all SoCs which feature the cpsw block have such a register, so that third memory region is considered optional for now. Signed-off-by: Daniel Mack

[PATCH v3 1/5] net: ethernet: cpsw: switch to devres allocations

2013-08-23 Thread Daniel Mack
This patch cleans up the allocation and error unwind paths, which allows us to carry less information in struct cpsw_priv and reduce the amount of jump labels in the probe functions. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/net/ethernet/ti/cpsw.c | 145

Re: [PATCH v2] Add support for Newflow NanoBone board

2013-08-23 Thread Mark Jackson
On 11/08/13 14:25, Mark Jackson wrote: NanoBone Specification: --- CPU: TI AM335x Memory: 256MB DDR3 128MB NOR flash 128KB FRAM Ethernet: 2 x 10/100 connected to SMSC LAN8710 PHY USB: 1 x USB2.0 Type A I2C: 2Kbit EEPROM (Microchip 24AA02)

Re: [PATCH 1/3] misc: Add crossbar driver

2013-08-23 Thread Santosh Shilimkar
On Friday 23 August 2013 04:14 AM, Sekhar Nori wrote: On Friday 23 August 2013 12:23 PM, Sricharan R wrote: On Friday 23 August 2013 12:06 PM, Sekhar Nori wrote: On Friday 23 August 2013 11:41 AM, Sricharan R wrote: Hi, On Friday 23 August 2013 10:17 AM, Rajendra Nayak wrote: On Thursday 22

Re: [PATCH 2/3] ARM: OMAP2+: HSI: Introduce OMAP SSI driver

2013-08-23 Thread Linus Walleij
On Sun, Aug 11, 2013 at 6:17 PM, Sebastian Reichel s...@debian.org wrote: From: Sebastian Reichel s...@ring0.de This patch adds an OMAP SSI driver to the HSI framework. The Synchronous Serial Interface (SSI) is a legacy version of HSI. As in the case of HSI, it is mainly used to connect

Re: [PATCH 3/3] ARM: OMAP2+: Add SSI driver configuration

2013-08-23 Thread Linus Walleij
On Mon, Aug 12, 2013 at 10:30 AM, Tony Lindgren t...@atomide.com wrote: * Sebastian Reichel s...@debian.org [130811 09:25]: From: Sebastian Reichel s...@ring0.de This patch configures and activates the OMAP SSI driver on the RX-51. Hmm, I'd rather see this be DT only driver at this point.

Re: [PATCH v2 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Sergei Shtylyov
Hello. On 23-08-2013 12:43, Daniel Mack wrote: At least the AM33xx SoC has a control module register to configure details such as the hardware ethernet interface mode. I'm not sure whether all SoCs which feature the cpsw block have such a register, so that third memory region is considered

Re: [PATCH v2 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Daniel Mack
On 23.08.2013 16:03, Sergei Shtylyov wrote: On 23-08-2013 12:43, Daniel Mack wrote: +dev_err(priv-dev, unable to map control i/o region\n); devm_ioremap_resource() prints out the error messages itself, so you don't have to. Right. Thanks. Will send a v4. Best, Daniel

[PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Daniel Mack
In order to support features that are specific to the AM335x IP, we have to add hardware types and another compatible string. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/net/cpsw.txt | 3 ++- drivers/net/ethernet/ti/cpsw.c | 32

[PATCH v4 0/5] cpsw: support for control module register

2013-08-23 Thread Daniel Mack
v3 - v4: * use IS_ERR() to check for failed devm_ioremap_resource() calls (reported by Sergei Shtylyov) v2 - v3: * swap ti,am3352-cpsw and ti,cpsw to work around a matching bug (reported by Sekhar) v1 - v2: * combine devm_request_mem_region() and

[PATCH v4 4/5] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Daniel Mack
The cpsw currently lacks code to properly set up the hardware interface mode on AM33xx. Other platforms might be equally affected. Usually, the bootloader will configure the control module register, so probably that's why such support wasn't needed in the past. In suspend mode though, this

[PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Daniel Mack
At least the AM33xx SoC has a control module register to configure details such as the hardware ethernet interface mode. I'm not sure whether all SoCs which feature the cpsw block have such a register, so that third memory region is considered optional for now. Signed-off-by: Daniel Mack

[PATCH v4 1/5] net: ethernet: cpsw: switch to devres allocations

2013-08-23 Thread Daniel Mack
This patch cleans up the allocation and error unwind paths, which allows us to carry less information in struct cpsw_priv and reduce the amount of jump labels in the probe functions. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/net/ethernet/ti/cpsw.c | 147

[PATCH v4 5/5] ARM: dts: am33xx: adopt to cpsw changes

2013-08-23 Thread Daniel Mack
This third memory region just denotes one single register in the CONTROL module block. The driver uses that in order to set the correct physical ethernet interface modes. Also update the compatible string to make use of the am335x specific features of the cpsw driver. Signed-off-by: Daniel Mack

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Santosh Shilimkar
On Friday 23 August 2013 10:16 AM, Daniel Mack wrote: In order to support features that are specific to the AM335x IP, we have to add hardware types and another compatible string. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/net/cpsw.txt | 3 ++-

Re: [PATCHv3 8/9] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-08-23 Thread Dave Gerlach
On 08/20/2013 05:48 PM, Paul Walmsley wrote: Hi folks, catching up on this thread. On 08/06/2013 12:49 PM, Dave Gerlach wrote: + +static int am33xx_pm_suspend(void) +{ + int i, j, ret = 0; + + int status = 0; + struct platform_device *pdev; + struct omap_device *od; + +

Re: [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Sergei Shtylyov
On 23-08-2013 18:16, Daniel Mack wrote: At least the AM33xx SoC has a control module register to configure details such as the hardware ethernet interface mode. I'm not sure whether all SoCs which feature the cpsw block have such a register, so that third memory region is considered optional

Re: [PATCH v3 1/2] rtc: omap: update of_device_id to reflect latest ip revisions

2013-08-23 Thread Benoit Cousson
Hi Sekhar, On 23/08/2013 10:50, Sekhar Nori wrote: Hi Benoit, Did you get a chance to think about this, I have provided some replies below. On Friday 16 August 2013 10:03 PM, Benoit Cousson wrote: Hi Sekhar, On 16/08/2013 17:41, Sekhar Nori wrote: On 8/16/2013 7:45 PM, Benoit Cousson

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Benoit Cousson
Hi Santosh, [...] +static const struct of_device_id cpsw_of_mtable[] = { + { + .compatible = ti,am3352-cpsw, I didn't notice this earlier, but can't you use the IP version as a compatible instead of using a SOC name. Whats really SOC specific on this IP ? Sorry i have

Re: [PATCH v2] DMA: add help function to check whether dma controller registered

2013-08-23 Thread Stephen Warren
On 08/22/2013 07:17 PM, Richard Zhao wrote: On Fri, Aug 23, 2013 at 04:36:53AM +0800, Stephen Warren wrote: On 08/22/2013 12:43 AM, Richard Zhao wrote: DMA client device driver usually needs to know at probe time whether dma controller has been registered to deffer probe. So add a help

Re: [PATCH] DMA: let filter functions of of_dma_simple_xlate possible check of_node

2013-08-23 Thread Stephen Warren
On 08/22/2013 07:29 PM, Richard Zhao wrote: On Fri, Aug 23, 2013 at 04:18:27AM +0800, Stephen Warren wrote: On 08/21/2013 11:19 PM, Richard Zhao wrote: On Fri, Aug 02, 2013 at 10:00:00AM +0800, Richard Zhao wrote: pass of_phandle_args dma_spec to dma_request_channel in of_dma_simple_xlate,

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Santosh Shilimkar
On Friday 23 August 2013 11:22 AM, Benoit Cousson wrote: Hi Santosh, [...] +static const struct of_device_id cpsw_of_mtable[] = { +{ +.compatible= ti,am3352-cpsw, I didn't notice this earlier, but can't you use the IP version as a compatible instead of using a SOC name.

Re: [PATCH v3 1/2] rtc: omap: update of_device_id to reflect latest ip revisions

2013-08-23 Thread Sekhar Nori
On 8/23/2013 8:40 PM, Benoit Cousson wrote: There is no assumption about the lost of functionality by using the generic version of the driver. How the user is supposed to know the amount of functionality he will lose, and if this is acceptable to him. I suppose the generic driver would

Re: [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Daniel Mack
On 23.08.2013 16:59, Sergei Shtylyov wrote: On 23-08-2013 18:16, Daniel Mack wrote: +priv-gmii_sel_reg = devm_ioremap_resource(pdev-dev, res); +if (IS_ERR(priv-gmii_sel_reg)) { +dev_err(priv-dev, unable to map control i/o region\n); You didn't actually seem to heed

Re: [PATCH 1/3] misc: Add crossbar driver

2013-08-23 Thread Sekhar Nori
On 8/23/2013 7:08 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 04:14 AM, Sekhar Nori wrote: On Friday 23 August 2013 12:23 PM, Sricharan R wrote: On Friday 23 August 2013 12:06 PM, Sekhar Nori wrote: On Friday 23 August 2013 11:41 AM, Sricharan R wrote: Hi, On Friday 23 August 2013

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Daniel Mack
On 23.08.2013 16:23, Santosh Shilimkar wrote: On Friday 23 August 2013 10:16 AM, Daniel Mack wrote: +static const struct of_device_id cpsw_of_mtable[] = { +{ +.compatible = ti,am3352-cpsw, I didn't notice this earlier, but can't you use the IP version as a compatible

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Sekhar Nori
On 8/23/2013 7:53 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 10:16 AM, Daniel Mack wrote: In order to support features that are specific to the AM335x IP, we have to add hardware types and another compatible string. Signed-off-by: Daniel Mack zon...@gmail.com ---

Re: [PATCH v2 4/5] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Mugunthan V N
On Friday 23 August 2013 02:13 PM, Daniel Mack wrote: The cpsw currently lacks code to properly set up the hardware interface mode on AM33xx. Other platforms might be equally affected. Usually, the bootloader will configure the control module register, so probably that's why such support

Re: [PATCH] mailbox: remove unnecessary platform_set_drvdata()

2013-08-23 Thread Suman Anna
+ OMAP mailing list Tony, Can you pick up this minor cleanup patch? regards Suman On 08/21/2013 09:10 PM, Jingoo Han wrote: The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Mugunthan V N
On Friday 23 August 2013 07:53 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 10:16 AM, Daniel Mack wrote: In order to support features that are specific to the AM335x IP, we have to add hardware types and another compatible string. Signed-off-by: Daniel Mack zon...@gmail.com ---

Re: [PATCH v4 4/5] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Mugunthan V N
On Friday 23 August 2013 07:46 PM, Daniel Mack wrote: The cpsw currently lacks code to properly set up the hardware interface mode on AM33xx. Other platforms might be equally affected. Usually, the bootloader will configure the control module register, so probably that's why such support

Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information

2013-08-23 Thread Joel Fernandes
On 08/22/2013 04:24 PM, Mark A. Greer wrote: On Thu, Aug 22, 2013 at 10:34:06AM +0200, Benoit Cousson wrote: Hi Lokesh, On 22/08/2013 05:50, Lokesh Vutla wrote: Hi Benoit, On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote: Hi Mark, In fact I cannot even apply these patches since

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Santosh Shilimkar
On Friday 23 August 2013 12:30 PM, Daniel Mack wrote: On 23.08.2013 16:23, Santosh Shilimkar wrote: On Friday 23 August 2013 10:16 AM, Daniel Mack wrote: +static const struct of_device_id cpsw_of_mtable[] = { + { + .compatible = ti,am3352-cpsw, I didn't notice this

Re: [PATCHv3 0/8] omap mailbox dt

2013-08-23 Thread Suman Anna
Tony, Benoit, This is an updated series for adding the device tree support to the OMAP mailbox driver. The series is based on 3.11-rc4 and now includes the support for AM335 WkupM3 mailbox. The support for WkupM3 mailbox is essential for achieving the PM Suspend on AM335 devices, and this

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Santosh Shilimkar
On Friday 23 August 2013 12:45 PM, Mugunthan V N wrote: On Friday 23 August 2013 07:53 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 10:16 AM, Daniel Mack wrote: In order to support features that are specific to the AM335x IP, we have to add hardware types and another compatible

Re: [PATCH] ARM: Update SMP_ON_UP code to detect A9MPCore with 1 CPU devices

2013-08-23 Thread Sekhar Nori
On 8/13/2013 7:01 PM, Santosh Shilimkar wrote: On Tuesday 13 August 2013 07:19 AM, Will Deacon wrote: On Mon, Aug 12, 2013 at 07:34:13PM +0100, Santosh Shilimkar wrote: On Friday 02 August 2013 11:48 AM, Will Deacon wrote: I think this an A9-specific register, which reads as 0 on UP A9 and

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Sekhar Nori
On 8/23/2013 10:26 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 12:30 PM, Daniel Mack wrote: On 23.08.2013 16:23, Santosh Shilimkar wrote: On Friday 23 August 2013 10:16 AM, Daniel Mack wrote: +static const struct of_device_id cpsw_of_mtable[] = { + { + .compatible

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Daniel Mack
On 23.08.2013 19:09, Sekhar Nori wrote: On 8/23/2013 10:26 PM, Santosh Shilimkar wrote: So just stick the IP version or call it cpsw-v1... cpsw-v2 etc. If this could be handled using IP version then the right way would be to just read the IP version from hardware and use it. No need of DT

Re: [PATCH] ARM: Update SMP_ON_UP code to detect A9MPCore with 1 CPU devices

2013-08-23 Thread Santosh Shilimkar
On Friday 23 August 2013 01:08 PM, Sekhar Nori wrote: On 8/13/2013 7:01 PM, Santosh Shilimkar wrote: On Tuesday 13 August 2013 07:19 AM, Will Deacon wrote: On Mon, Aug 12, 2013 at 07:34:13PM +0100, Santosh Shilimkar wrote: On Friday 02 August 2013 11:48 AM, Will Deacon wrote: I think this an

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Mugunthan V N
On Friday 23 August 2013 10:26 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 12:30 PM, Daniel Mack wrote: On 23.08.2013 16:23, Santosh Shilimkar wrote: On Friday 23 August 2013 10:16 AM, Daniel Mack wrote: +static const struct of_device_id cpsw_of_mtable[] = { + { +

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Daniel Mack
On 23.08.2013 19:19, Santosh Shilimkar wrote: On Friday 23 August 2013 01:09 PM, Sekhar Nori wrote: On 8/23/2013 10:26 PM, Santosh Shilimkar wrote: So just stick the IP version or call it cpsw-v1... cpsw-v2 etc. If this could be handled using IP version then the right way would be to just

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Santosh Shilimkar
On Friday 23 August 2013 01:09 PM, Sekhar Nori wrote: On 8/23/2013 10:26 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 12:30 PM, Daniel Mack wrote: On 23.08.2013 16:23, Santosh Shilimkar wrote: On Friday 23 August 2013 10:16 AM, Daniel Mack wrote: +static const struct

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Santosh Shilimkar
On Friday 23 August 2013 01:24 PM, Daniel Mack wrote: On 23.08.2013 19:19, Santosh Shilimkar wrote: On Friday 23 August 2013 01:09 PM, Sekhar Nori wrote: On 8/23/2013 10:26 PM, Santosh Shilimkar wrote: So just stick the IP version or call it cpsw-v1... cpsw-v2 etc. If this could be handled

Re: [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Sergei Shtylyov
On 08/23/2013 08:21 PM, Daniel Mack wrote: + priv-gmii_sel_reg = devm_ioremap_resource(pdev-dev, res); + if (IS_ERR(priv-gmii_sel_reg)) { + dev_err(priv-dev, unable to map control i/o region\n); You didn't actually seem to heed my words about error message.

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Sekhar Nori
On 8/23/2013 10:58 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 01:24 PM, Daniel Mack wrote: On 23.08.2013 19:19, Santosh Shilimkar wrote: On Friday 23 August 2013 01:09 PM, Sekhar Nori wrote: On 8/23/2013 10:26 PM, Santosh Shilimkar wrote: So just stick the IP version or call it

Re: [PATCH] ARM: Update SMP_ON_UP code to detect A9MPCore with 1 CPU devices

2013-08-23 Thread Sekhar Nori
On 8/23/2013 10:47 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 01:08 PM, Sekhar Nori wrote: On 8/13/2013 7:01 PM, Santosh Shilimkar wrote: On Tuesday 13 August 2013 07:19 AM, Will Deacon wrote: On Mon, Aug 12, 2013 at 07:34:13PM +0100, Santosh Shilimkar wrote: On Friday 02 August

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Santosh Shilimkar
On Friday 23 August 2013 01:39 PM, Sekhar Nori wrote: On 8/23/2013 10:58 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 01:24 PM, Daniel Mack wrote: On 23.08.2013 19:19, Santosh Shilimkar wrote: On Friday 23 August 2013 01:09 PM, Sekhar Nori wrote: On 8/23/2013 10:26 PM, Santosh

Re: [PATCH 2/3] ARM: OMAP2+: HSI: Introduce OMAP SSI driver

2013-08-23 Thread Sebastian Reichel
Hi, On Fri, Aug 23, 2013 at 03:57:05PM +0200, Linus Walleij wrote: The HSI subsystem is lacking an active maintainer, interested? Given that you can apparently test the OMAP HSI driver you're one of the few applicable candidates. I don't think I'm a good candidate for that. At least not yet.

Re: [PATCH 3/3] ARM: OMAP2+: Add SSI driver configuration

2013-08-23 Thread Sebastian Reichel
On Fri, Aug 23, 2013 at 03:58:30PM +0200, Linus Walleij wrote: On Mon, Aug 12, 2013 at 10:30 AM, Tony Lindgren t...@atomide.com wrote: * Sebastian Reichel s...@debian.org [130811 09:25]: From: Sebastian Reichel s...@ring0.de This patch configures and activates the OMAP SSI driver on the

Re: [PATCH 1/3] ARM: OMAP2+: hwmod-data: Add SSI information

2013-08-23 Thread Sebastian Reichel
Hi Paul, On Wed, Aug 21, 2013 at 01:22:09AM +, Paul Walmsley wrote: From: Sebastian Reichel s...@ring0.de This patch adds Synchronous Serial Interface (SSI) hwmod support for OMAP34xx SoCs. a few comments: - please add your Signed-off-by: to the patch description, per

Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Mugunthan V N
On Friday 23 August 2013 11:40 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 01:39 PM, Sekhar Nori wrote: On 8/23/2013 10:58 PM, Santosh Shilimkar wrote: On Friday 23 August 2013 01:24 PM, Daniel Mack wrote: On 23.08.2013 19:19, Santosh Shilimkar wrote: On Friday 23 August 2013 01:09

Re: [GIT PULL] ARM: OMAP: Device Tree for 3.12

2013-08-23 Thread Kevin Hilman
Benoit Cousson bcous...@baylibre.com writes: Hi Kevin Olof, I've just updated the branch with the few USB3 patches I missed from Felipe. So here is a new pull-request. Thanks, Benoit Add the minimal DTS support for

Re: [PATCH v4 1/5] net: ethernet: cpsw: switch to devres allocations

2013-08-23 Thread Daniel Mack
On 23.08.2013 20:10, Sergei Shtylyov wrote: On 08/23/2013 06:16 PM, Daniel Mack wrote: priv-coal_intvl = 0; priv-bus_freq_mhz = clk_get_rate(priv-clk) / 100; -priv-cpsw_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); -if (!priv-cpsw_res) { +ss_res =

Re: [PATCH v4 1/5] net: ethernet: cpsw: switch to devres allocations

2013-08-23 Thread Sergei Shtylyov
On 08/23/2013 06:16 PM, Daniel Mack wrote: This patch cleans up the allocation and error unwind paths, which allows us to carry less information in struct cpsw_priv and reduce the amount of jump labels in the probe functions. Signed-off-by: Daniel Mack zon...@gmail.com ---

[PATCH v5 1/5] net: ethernet: cpsw: switch to devres allocations

2013-08-23 Thread Daniel Mack
This patch cleans up the allocation and error unwind paths, which allows us to carry less information in struct cpsw_priv and reduce the amount of jump labels in the probe functions. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/net/ethernet/ti/cpsw.c | 153

Re: [PATCH 1/3] ARM: OMAP2+: hwmod-data: Add SSI information

2013-08-23 Thread Paul Walmsley
Hi On Fri, 23 Aug 2013, Sebastian Reichel wrote: On Wed, Aug 21, 2013 at 01:22:09AM +, Paul Walmsley wrote: From: Sebastian Reichel s...@ring0.de This patch adds Synchronous Serial Interface (SSI) hwmod support for OMAP34xx SoCs. a few comments: - please add your

[PATCH v5 4/5] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Daniel Mack
The cpsw currently lacks code to properly set up the hardware interface mode on AM33xx. Other platforms might be equally affected. Usually, the bootloader will configure the control module register, so probably that's why such support wasn't needed in the past. In suspend mode though, this

[PATCH v5 5/5] ARM: dts: am33xx: adopt to cpsw changes

2013-08-23 Thread Daniel Mack
This third memory region just denotes one single register in the CONTROL module block. The driver uses that in order to set the correct physical ethernet interface modes. Also update the compatible string to make use of the am335x specific features of the cpsw driver. Signed-off-by: Daniel Mack

[PATCH v5 0/5] cpsw: support for control module register

2013-08-23 Thread Daniel Mack
Hi, this is the 5th version of my patch set, the version history is below. Note that for personal reasons, I won't be able to work on that patch set for two weeks, starting from a few hours from now. If there are any more objections or comments, I'll catch up after that period. Or if anyone

[PATCH v5 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

2013-08-23 Thread Daniel Mack
In order to support features that are specific to the AM335x IP, we have to add hardware types and another compatible string. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/net/cpsw.txt | 3 ++- drivers/net/ethernet/ti/cpsw.c | 32

[PATCH v5 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Daniel Mack
At least the AM33xx SoC has a control module register to configure details such as the hardware ethernet interface mode. I'm not sure whether all SoCs which feature the cpsw block have such a register, so that third memory region is considered optional for now. Signed-off-by: Daniel Mack

Re: [PATCH 1/3] misc: Add crossbar driver

2013-08-23 Thread Linus Walleij
On Fri, Aug 23, 2013 at 6:28 PM, Sekhar Nori nsek...@ti.com wrote: On 8/23/2013 7:08 PM, Santosh Shilimkar wrote: The whole point we are moving to domain is not have any default mapping(connection done) at DT level. Rather DT only specifies the peripherals and their cross-bar connection

[PATCH] ARM: dts: add AM33XX EDMA support

2013-08-23 Thread Sebastian Andrzej Siewior
From: Matt Porter m...@ti.com Adds AM33XX EDMA support to the am33xx.dtsi as documented in Documentation/devicetree/bindings/dma/ti-edma.txt Joel: Drop DT entries that are non-hardware-description for now as discussed in [1] [1] https://patchwork.kernel.org/patch/2226761/ Signed-off-by: Matt

[GIT PULL] ARM: OMAP: DRA7xx PRCM/hwmod support

2013-08-23 Thread Paul Walmsley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Tony The following changes since commit cf470a1b1a741bca00080ebc70968b4f22d9b1ea: Merge tag 'dra7-core-support-minus-dt' of git://github.com/rrnayak/linux into omap-for-v3.12/soc (2013-08-14 01:01:41 -0700) are available in the git repository

Re: [PATCH v5 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Sergei Shtylyov
Hello. On 08/23/2013 10:53 PM, Daniel Mack wrote: At least the AM33xx SoC has a control module register to configure details such as the hardware ethernet interface mode. I'm not sure whether all SoCs which feature the cpsw block have such a register, so that third memory region is

Re: [PATCH v5 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

2013-08-23 Thread Daniel Mack
On 23.08.2013 21:10, Sergei Shtylyov wrote: Hello. On 08/23/2013 10:53 PM, Daniel Mack wrote: At least the AM33xx SoC has a control module register to configure details such as the hardware ethernet interface mode. I'm not sure whether all SoCs which feature the cpsw block have such a

Re: [PATCH v5 0/5] cpsw: support for control module register

2013-08-23 Thread Mugunthan V N
On Saturday 24 August 2013 12:23 AM, Daniel Mack wrote: Note that for personal reasons, I won't be able to work on that patch set for two weeks, starting from a few hours from now. If there are any more objections or comments, I'll catch up after that period. Or if anyone wants to make minor

Re: [PATCH v4] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

2013-08-23 Thread Stephen Warren
On 08/23/2013 05:28 AM, Kishon Vijay Abraham I wrote: Hi, On Friday 23 August 2013 02:20 AM, Stephen Warren wrote: On 08/22/2013 02:31 AM, Kishon Vijay Abraham I wrote: The Palmas device contains only a USB VBUS-ID detector, so added a compatible type *ti,palmas-usb-vid*. Didn't remove the

Re: [PATCH v5 4/5] net: ethernet: cpsw: add support for hardware interface mode config

2013-08-23 Thread Sergei Shtylyov
On 08/23/2013 10:53 PM, Daniel Mack wrote: The cpsw currently lacks code to properly set up the hardware interface mode on AM33xx. Other platforms might be equally affected. Usually, the bootloader will configure the control module register, so probably that's why such support wasn't needed

[PATCH v6 1/5] net: ethernet: cpsw: switch to devres allocations

2013-08-23 Thread Daniel Mack
This patch cleans up the allocation and error unwind paths, which allows us to carry less information in struct cpsw_priv and reduce the amount of jump labels in the probe functions. Signed-off-by: Daniel Mack zon...@gmail.com Acked-by: Mugunthan V N mugunthan...@ti.com ---

  1   2   >