Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Quentin Lambert
Sorry let me do that properly. On 05/02/2015 16:45, Quentin Lambert wrote: On 05/02/2015 00:26, Stephen Boyd wrote: If you want me to I can enlarge the search to other directories. Yes please do. And if you could share the coccinelle patch that would be great. Thanks. structclk.cocci is

am335x: USB DMA IRQ issue

2015-02-05 Thread Yegor Yefremov
I have a problem with my am335x based board and USB. Kernel: Linux version 3.18.1 (YegorYefremov@development1) (gcc version 4.9.2 (Buildroot 2015.02-git-00797-gf1b07c0) ) #1 SMP Thu Jan 15 15:31:27 CET 2015 I took two devices and equipped them with USB WLAN cards: Bus 001 Device 003: ID

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Quentin Lambert
On 05/02/2015 00:26, Stephen Boyd wrote: If you want me to I can enlarge the search to other directories. Yes please do. And if you could share the coccinelle patch that would be great. Thanks. structclk.cocci is the coccinelle patch structclk-arm.patch is the result I got when applying it

Re: [PATCH 1/2] usb: musb: Fix use for of_property_read_bool for disabled multipoint

2015-02-05 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [150205 10:12]: On Thu, Feb 05, 2015 at 08:35:12AM -0800, Tony Lindgren wrote: The value for the multipoint dts property is ignored when parsing with of_property_read_bool, so we currently have multipoint always set as 1 even if value 0 is specified in the dts

Re: [PATCH v3 0/2] couple of generic remoteproc enhancements

2015-02-05 Thread Ohad Ben-Cohen
Hi Suman, On Tue, Feb 3, 2015 at 10:55 PM, Suman Anna s-a...@ti.com wrote: On 01/09/2015 03:21 PM, Suman Anna wrote: Hi Ohad, The following is an updated patchset addressing the previous pending comments from v1 v2, and are rebased onto the latest 3.19-rc3 (are rc independent

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Stephen Boyd
On 02/05/15 12:07, Stephen Boyd wrote: On 02/05/15 11:44, Sylwester Nawrocki wrote: Hi Tomeu, On 23/01/15 12:03, Tomeu Vizoso wrote: int __clk_get(struct clk *clk) { - if (clk) { - if (!try_module_get(clk-owner)) + struct clk_core *core = !clk ? NULL : clk-core; + + if

Re: [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock

2015-02-05 Thread Bjorn Andersson
On Mon, Feb 2, 2015 at 1:07 PM, Suman Anna s-a...@ti.com wrote: On 02/01/2015 11:55 AM, Bjorn Andersson wrote: On Fri, Jan 30, 2015 at 9:41 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Sat, Jan 31, 2015 at 1:29 AM, Bjorn Andersson bj...@kryo.se wrote: In a system where you have two hwlock

Re: [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock

2015-02-05 Thread Suman Anna
Hi Bjorn, On 02/05/2015 05:01 PM, Bjorn Andersson wrote: On Mon, Feb 2, 2015 at 1:07 PM, Suman Anna s-a...@ti.com wrote: On 02/01/2015 11:55 AM, Bjorn Andersson wrote: On Fri, Jan 30, 2015 at 9:41 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Sat, Jan 31, 2015 at 1:29 AM, Bjorn Andersson

Re: [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock

2015-02-05 Thread Bjorn Andersson
On Thu, Feb 5, 2015 at 4:11 PM, Suman Anna s-a...@ti.com wrote: Hi Bjorn, On 02/05/2015 05:01 PM, Bjorn Andersson wrote: [..] Will you send out a new revision of the binding? I would love to get this integrated so I can move on with the dependents. Yep, will do as soon as I hear from Ohad

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Russell King - ARM Linux
On Thu, Feb 05, 2015 at 02:14:01PM -0800, Stephen Boyd wrote: Actually we can bury the __clk_create_clk() inside __of_clk_get_from_provider(). We should also move __clk_get() into there because right now we have a hole where whoever calls of_clk_get_from_provider() never calls __clk_get() on

[PATCH] ARM: dts: Fix USB dts configuration for dm816x

2015-02-05 Thread Tony Lindgren
Commit 7800064ba507 (ARM: dts: Add basic dm816x device tree configuration) added basic devices for dm816x, but I was not able to test the USB completely because of a unconfigure USB phy, and I only tested it to make sure the Mentor chips are detected and clocked without a phy. After testing the

[PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-05 Thread Tony Lindgren
We still have a combination of legacy phys and generic phys in use so we need to support both types of phy for musb_dsps.c. Cc: Brian Hutchinson b.hutch...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/usb/musb/musb_dsps.c | 17 + 1 file changed, 17

[PATCH 0/2] MUSB fix for disabled multipoint and generic phy

2015-02-05 Thread Tony Lindgren
Hi, Here are two fixes, the first one probably should be Cc stable. Regards, Tony Tony Lindgren (2): usb: musb: Fix use for of_property_read_bool for disabled multipoint usb: musb: Fix getting a generic phy for musb_dsps drivers/usb/musb/musb_dsps.c | 24 ++--

[PATCH 1/2] usb: musb: Fix use for of_property_read_bool for disabled multipoint

2015-02-05 Thread Tony Lindgren
The value for the multipoint dts property is ignored when parsing with of_property_read_bool, so we currently have multipoint always set as 1 even if value 0 is specified in the dts file. Let's fix this to read the value too instead of just the property like the binding documentation says as

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Stephen Boyd
On 02/05/15 16:42, Russell King - ARM Linux wrote: On Thu, Feb 05, 2015 at 02:14:01PM -0800, Stephen Boyd wrote: Actually we can bury the __clk_create_clk() inside __of_clk_get_from_provider(). We should also move __clk_get() into there because right now we have a hole where whoever calls

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Stephen Boyd
On 02/05/15 08:02, Quentin Lambert wrote: Sorry let me do that properly. On 05/02/2015 16:45, Quentin Lambert wrote: On 05/02/2015 00:26, Stephen Boyd wrote: If you want me to I can enlarge the search to other directories. Yes please do. And if you could share the coccinelle patch that

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Stephen Boyd
On 02/05/15 07:45, Quentin Lambert wrote: On 05/02/2015 00:26, Stephen Boyd wrote: If you want me to I can enlarge the search to other directories. Yes please do. And if you could share the coccinelle patch that would be great. Thanks. structclk.cocci is the coccinelle patch

[RFC/PATCH 2/2] of: allow for boolean flags to have value

2015-02-05 Thread Felipe Balbi
allowing values to boolean flags lets us setup defaults on DTSI which can get disabled later at board DTS if, for whatever reason, board can't use that default. One such example is DM81xx EVM where we can't use MUSB's multipoint feature even though SoC supports it. Something at the board level

[RFC/PATCH 1/2] of: move of_property_read_bool further down

2015-02-05 Thread Felipe Balbi
A follow-up patch will make use of of_property_read_u32() to allow for boolean properties to have a value, this is just in preparation for that patch in order to make review easier. Signed-off-by: Felipe Balbi ba...@ti.com --- include/linux/of.h | 32 1 file

Re: [PATCH 1/2] usb: musb: Fix use for of_property_read_bool for disabled multipoint

2015-02-05 Thread Felipe Balbi
On Thu, Feb 05, 2015 at 08:35:12AM -0800, Tony Lindgren wrote: The value for the multipoint dts property is ignored when parsing with of_property_read_bool, so we currently have multipoint always set as 1 even if value 0 is specified in the dts file. Let's fix this to read the value too

Re: [RFC/PATCH 2/2] of: allow for boolean flags to have value

2015-02-05 Thread Tony Lindgren
* Mark Rutland mark.rutl...@arm.com [150205 10:26]: On Thu, Feb 05, 2015 at 06:01:06PM +, Felipe Balbi wrote: allowing values to boolean flags lets us setup defaults on DTSI which can get disabled later at board DTS if, for whatever reason, board can't use that default. One such

Re: [RFC/PATCH 2/2] of: allow for boolean flags to have value

2015-02-05 Thread Uwe Kleine-König
On Thu, Feb 05, 2015 at 12:01:06PM -0600, Felipe Balbi wrote: allowing values to boolean flags lets us setup defaults on DTSI which can get disabled later at board DTS if, for whatever reason, board can't use that default. One such example is DM81xx EVM where we can't use MUSB's multipoint

Re: [RFC/PATCH 2/2] of: allow for boolean flags to have value

2015-02-05 Thread Arnd Bergmann
On Thursday 05 February 2015 12:01:06 Felipe Balbi wrote: + /* +* if property doesn't have a value, or prop-length == 0 and +* we overflow, treat it as simple value-less flag. +*/ + if (rc == -ENODATA || rc == -EOVERFLOW) + return true; +

Re: [RFC/PATCH 2/2] of: allow for boolean flags to have value

2015-02-05 Thread Mark Rutland
On Thu, Feb 05, 2015 at 06:01:06PM +, Felipe Balbi wrote: allowing values to boolean flags lets us setup defaults on DTSI which can get disabled later at board DTS if, for whatever reason, board can't use that default. One such example is DM81xx EVM where we can't use MUSB's multipoint

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Sylwester Nawrocki
Hi Tomeu, On 23/01/15 12:03, Tomeu Vizoso wrote: int __clk_get(struct clk *clk) { - if (clk) { - if (!try_module_get(clk-owner)) + struct clk_core *core = !clk ? NULL : clk-core; + + if (core) { + if (!try_module_get(core-owner))

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Stephen Boyd
On 02/05/15 11:44, Sylwester Nawrocki wrote: Hi Tomeu, On 23/01/15 12:03, Tomeu Vizoso wrote: int __clk_get(struct clk *clk) { -if (clk) { -if (!try_module_get(clk-owner)) +struct clk_core *core = !clk ? NULL : clk-core; + +if (core) { +if

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-05 Thread Sylwester Nawrocki
On 05/02/15 20:44, Sylwester Nawrocki wrote: +void __clk_put(struct clk *clk) +{ + if (!clk || WARN_ON_ONCE(IS_ERR(clk))) + return; + + clk_core_put(clk-core); + kfree(clk); Why do we have kfree() here? clk_get() doesn't allocate the data structure being freed here.