The temporary string holding the directory name to be created should
be released.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/voltage.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2
Eliminates the following sparse warning:
arch/arm/plat-omap/dma.c:137:5: warning: symbol 'omap_dma_in_1510_mode'
was not declared. Should it be static?
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
arch/arm/plat-omap/dma.c |2 +-
1 files changed, 1 insertions(+), 1
Hi,
On Fri, 14 Jan 2011, Tony Lindgren wrote:
Before I update out master branch, let's try to summarize the
open issues after the merge window. Here's a list of issues
in omap-fixes-for-linus that I'm aware of:
- NFS root oopses while mounting root
- omap4430 es1.0 hangs if L2X0 cache is
Hi,
On Mon, 17 Jan 2011, Santosh Shilimkar wrote:
Amstrad E3 fails during the boot. Bisection points to:
commit 211baa7016894c02fc18693e21ca479cd08ac0c0
Author: Russell King rmk+ker...@arm.linux.org.uk
Date: Tue Jan 11 16:23:04 2011 +
ARM:
Eliminates the following sparse warning:
arch/arm/mach-omap1/board-h2.c:205:27: warning: symbol
'h2_nand_platdata' was not declared. Should it be static?
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
arch/arm/mach-omap1/board-h2.c |2 +-
1 files changed, 1 insertions(+), 1
Here's some trivial omap1 sparse warning fixes.
Aaro Koskinen (7):
arm: plat-omap: dma: make omap_dma_in_1510_mode() static
arm: mach-omap1: board-h2: make h2_nand_platdata static
arm: mach-omap1: board-innovator: make innovator_mmc_init() static
arm: mach-omap1: board-htcherald: make
?
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
arch/arm/mach-omap1/board-htcherald.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap1/board-htcherald.c
b/arch/arm/mach-omap1/board-htcherald.c
index f2c5c58..ba05a51 100644
--- a/arch/arm/mach-omap1
it be static?
arch/arm/mach-omap1/board-voiceblue.c:269:6: warning: symbol
'voiceblue_wdt_ping' was not declared. Should it be static?
arch/arm/mach-omap1/board-voiceblue.c:278:6: warning: symbol
'voiceblue_reset' was not declared. Should it be static?
Signed-off-by: Aaro Koskinen
Eliminates the following sparse warning:
arch/arm/mach-omap1/board-innovator.c:368:13: warning: symbol
'innovator_mmc_init' was not declared. Should it be static?
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
arch/arm/mach-omap1/board-innovator.c |2 +-
1 files changed, 1
Move voiceblue definitions into the board-specific header.
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
arch/arm/plat-omap/include/plat/board-voiceblue.h |6 ++
arch/arm/plat-omap/include/plat/system.h |7 +--
2 files changed, 7 insertions(+), 6 deletions
Eliminates the following sparse warning:
arch/arm/mach-omap1/board-h3.c:207:27: warning: symbol 'nand_platdata'
was not declared. Should it be static?
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
arch/arm/mach-omap1/board-h3.c |2 +-
1 files changed, 1 insertions(+), 1
Hi,
On Fri, 7 Jan 2011, Nishanth Menon wrote:
From: Koen Kooi k...@beagleboard.org
EHCI enable power pin is inverted (active high) in comparison
to vanilla beagle which is active low. Handle this case conditionally.
Without this fix, Beagle XM 4 port EHCI will not function and no
networking
Hi,
On Fri, 7 Jan 2011, Nishanth Menon wrote:
From: Koen Kooi k...@beagleboard.org
TFP410 DVI chip is used to provide display out.
This chip is controlled by 2 lines:
LDO which supplies the power is controlled over gpio + 2
and the enable of the chip itself is done over gpio + 1
NOTE: the LDO
memcpy() copies 8 bytes too much (omap_mux_entry vs. omap_mux). Correct
by replacing memcpy() with struct assignment, which is safer.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/mux.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch
Hi,
On Tue, 4 Jan 2011, David Lynch Jr. wrote:
For reference the mcs5000 driver as well as an st1232 driver that was
in the linux input patch stream perform I2C xfers in an interrupt
context.
They are using threaded IRQ handlers, which might be the solution you
are looking for.
A.
--
Make !CONFIG_SUSPEND init declarations identical on all OMAPs and
eliminate some ifdefs.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/pm.h |4
arch/arm/mach-omap2/pm24xx.c | 16
arch/arm/mach-omap2/pm34xx.c | 16
Hi,
On Wed, 22 Dec 2010, Tony Lindgren wrote:
* Thomas Petazzoni thomas.petazz...@free-electrons.com [101221 14:00]:
On Tue, 21 Dec 2010 11:27:35 -0800
Tony Lindgren t...@atomide.com wrote:
Therefore, we introduce an infrastructure that allows to put code
and data into specific sections,
.
Created against linux-2.6.37-rc5.
Tested on Amstrad Delta.
Compile tested with omap1_defconfig and omap2plus_defconfig shrinked to
board-h4.
Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl
Reviewed-by: Aaro Koskinen aaro.koski...@nokia.com
---
v2 - v3 changes:
- update all board's keymap
Hello,
On Sat, 18 Dec 2010, Janusz Krzysztofik wrote:
Most keypad drivers make use of the linux/input/matrix_keypad.h
defined macros, structures and inline functions.
Convert omap-keypad driver to use those as well, as suggested by a
compile time warning, hardcoded into the OMAP palt/keypad.h.
Hi,
On Wed, 15 Dec 2010, Tony Lindgren wrote:
* Aaro Koskinen aaro.koski...@nokia.com [101215 04:48]:
It's not possible to compile a kernel for this board without I2C,
MFD_SUPPORT and TWL4030_CORE, so those should be selected. This will
prevent build errors when trying out different
There is no MFD config option, MFD_SUPPORT should be selected instead.
This will prevent build errors when trying out different configurations.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/Kconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
It's not possible to compile a kernel for this board without I2C,
MFD_SUPPORT and TWL4030_CORE, so those should be selected. This will
prevent build errors when trying out different configurations.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/Kconfig |4
to compile.
These are based on top of linux-omap/master
(92f446c47b18827e61483787668b0bb5f7a033b6).
...
Aaro Koskinen (8):
arm: omap: rename board-rx51-sdram.c to sdram-nokia.c
arm: omap: add sdram-nokia.h
arm: omap: sdram-nokia: prepare for new memory timings
arm: omap: sdram-nokia: use
Add a header file for Nokia SDRAM functions. Based on patches by Juha
Keski-Saari.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/board-rx51.c |2 +-
arch/arm/mach-omap2/sdram-nokia.c |1 +
arch/arm/mach-omap2/sdram-nokia.h | 12
3 files
Rename the file and functions so that it can be reused by future Nokia
boards. Based on patches by Juha Keski-Saari.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/Makefile |2 +-
arch/arm/mach-omap2/board-rx51.c |4
Rename the current timings to indicate they're for 166 MHz. Based on
patches by Eduardo Valentin and Juha Keski-Saari.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Cc: Eduardo Valentin eduardo.valen...@nokia.com
---
arch/arm/mach-omap2/sdram-nokia.c | 11 ++-
1 files changed, 6
Use an array to make it easier to add new values.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/sdram-nokia.c | 21 +++--
1 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-omap2/sdram-nokia.c
b/arch/arm/mach-omap2
Actually check for errors: print an error log and return NULL.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/sdram-nokia.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/sdram-nokia.c
b/arch/arm/mach-omap2/sdram
41.5 MHz SDRAM clock is not usable.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/sdram-nokia.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/sdram-nokia.c
b/arch/arm/mach-omap2/sdram-nokia.c
index 863586b..baf83ec
Introduce 97.6/195.2 MHz memory timing data. Based on patches by Eduardo
Valentin, Igor Dmitriev and Juha Keski-Saari.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Cc: Eduardo Valentin eduardo.valen...@nokia.com
Cc: Igor Dmitriev ext-dmitriev.i...@nokia.com
---
arch/arm/mach-omap2/sdram
Add minimal support for Nokia RM-680 board.
Tested with omap2plus_defconfig.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/Kconfig |6 +
arch/arm/mach-omap2/Makefile |3 +
arch/arm/mach-omap2/board-rm680.c| 187
If CONFIG_OMAP_MUX is not enabled, we can define board_mux in the header
file instead of forcing every single board to define it.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
v2: Use a static variable to avoid namespace pollution.
arch/arm/mach-omap2/board-2430sdp.c|2
Hi,
On Thu, 2 Dec 2010, Felipe Balbi wrote:
On Thu, Dec 02, 2010 at 11:53:42AM +0200, Aaro Koskinen wrote:
diff --git a/arch/arm/mach-omap2/mux.h b/arch/arm/mach-omap2/mux.h
index 350c04f..e224ab5 100644
--- a/arch/arm/mach-omap2/mux.h
+++ b/arch/arm/mach-omap2/mux.h
@@ -133,6 +133,8 @@ static
If CONFIG_OMAP_MUX is not enabled, we can define board_mux in the header
file instead of forcing every single board to define it.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
v3: Use __maybe_unused instead of compiler-specific attribute.
v2: Use a static variable to avoid namespace
When OneNAND support is disabled, the platform code defines NULL
board_onenand_data and empty init function for us. By utilizing this we
can avoid cluttering board files with dummy definitions/wrappers.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/board-n8x0.c
When OneNAND support is disabled, the platform code defines NULL
board_onenand_data and empty init function for us. By utilizing this we
can avoid cluttering board files with dummy definitions/wrappers.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/board-rx51
If CONFIG_OMAP_MUX is not enabled, we can define board_mux in the header
file instead of forcing every single board to define it.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/board-2430sdp.c|2 --
arch/arm/mach-omap2/board-3430sdp.c|2
clk_get() return value should be checked with IS_ERR().
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/io.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
index 40562dd..a1939b1 100644
it be static?
arch/arm/plat-omap/dma.c:177:5: warning: symbol 'omap_dma_in_1510_mode'
was not declared. Should it be static?
arch/arm/plat-omap/sram.c:273:12: warning: symbol 'omap1_sram_init' was
not declared. Should it be static?
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Delete unused variable from probe().
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap1/mailbox.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap1/mailbox.c b/arch/arm/mach-omap1/mailbox.c
index 12d6880..c0e1f48 100644
it be static?
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap1/mailbox.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap1/mailbox.c b/arch/arm/mach-omap1/mailbox.c
index 1a85a42..12d6880 100644
--- a/arch/arm/mach-omap1/mailbox.c
Delete a redundant local variable.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/timer-gp.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/timer-gp.c b/arch/arm/mach-omap2/timer-gp.c
index e13c29e..f9052e1 100644
/mach-omap1/board-ams-delta.c:319:36:got void *noident
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap1/board-ams-delta.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c
b/arch/arm/mach-omap1/board-ams
Some small OMAP cleanups to eliminate noise from compilation/sparse
checks:
Aaro Koskinen (6):
arm: omap1: add missing includes
arm: omap1: make some functions static
arm: omap1: mbox: make variables static
arm: omap1: mbox: delete unused variable
arm: omap1: board-ams-delta: fix cast
it be static?
arch/arm/mach-omap1/serial.c:190:6: warning: symbol
'omap_serial_wake_trigger' was not declared. Should it be static?
arch/arm/mach-omap1/time.c:252:18: warning: symbol 'omap_timer' was not
declared. Should it be static?
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Hi,
balaj...@ti.com wrote:
From: Balaji T K balaj...@ti.com
Errata ID: i535 - I2C1 to 3 SCL low period is shorter in FS mode
Due to IO cell influence, I2C1 to 3 SCL low period can be shorter than
expected.
As a result, I2C AC timing (SCL minimum low period) in FS mode may not meet
the
Enable TSC2005 touchscreen driver on the RX-51 board.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/configs/rx51_defconfig |1 +
arch/arm/mach-omap2/board-rx51-peripherals.c | 57 ++
2 files changed, 58 insertions(+), 0 deletions
, Hiroshi DOYU, Ari Kauppi,
Tony Lindgren, Jarkko Nikula, Eero Nurkkala and Roman Tereshonkov.
Signed-off-by: Lauri Leukkunen lauri.leukku...@nokia.com
[aaro.koski...@nokia.com: patch description, rebasing cleanup]
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Cc: David Brownell dbrown
, Hiroshi DOYU, Ari Kauppi,
Tony Lindgren, Jarkko Nikula, Eero Nurkkala and Roman Tereshonkov.
Signed-off-by: Lauri Leukkunen lauri.leukku...@nokia.com
[aaro.koski...@nokia.com: patch description, rebasing cleanup]
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Cc: David Brownell dbrown
Enable TSC2005 touchscreen driver on the RX-51 board.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/configs/rx51_defconfig |1 +
arch/arm/mach-omap2/board-rx51-peripherals.c | 57 ++
2 files changed, 58 insertions(+), 0 deletions
Hi,
Manjunatha GK wrote:
Under certain rare conditions, I2C_STAT[13].RDR bit may be set
and the corresponding interrupt fire, even there is no data in
the receive FIFO, or the I2C data transfer is still ongoing.
These spurious RDR events must be ignored by the software.
This patch handles
Hi,
Alexander Shishkin wrote:
The errata 1.153 workaround is busy waiting on XUDF bit in interrupt
context, which may lead to kernel hangs. The problem can be reproduced
by running the bus with wrong (too high) speed.
Signed-off-by: Alexander Shishkin virtu...@slind.org
Acked-by: Tony
returned 0
after 0 usecs
[ 508.697967] calling omap_init_devices+0x0/0x38 @ 1
[ 508.698425] initcall omap_init_devices+0x0/0x38 returned 0 after 0
usecs
This will confuse tools such as scripts/bootgraph.pl.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Acked-by: Kevin
They are not needed and add over 512 bytes to kernel data.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/plat-omap/common.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c
index 01cbb48
returned 0
after 0 usecs
[ 508.697967] calling omap_init_devices+0x0/0x38 @ 1
[ 508.698425] initcall omap_init_devices+0x0/0x38 returned 0 after 0
usecs
This will confuse tools such as scripts/bootgraph.pl.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
See also
Enable TSC2005 touchscreen driver on the RX-51 board.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/configs/rx51_defconfig |1 +
arch/arm/mach-omap2/board-rx51-peripherals.c | 57 ++
2 files changed, 58 insertions(+), 0 deletions
, Hiroshi DOYU, Ari Kauppi,
Tony Lindgren, Jarkko Nikula, Eero Nurkkala and Roman Tereshonkov.
Signed-off-by: Lauri Leukkunen lauri.leukku...@nokia.com
[aaro.koski...@nokia.com: patch description, rebasing cleanup]
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Cc: David Brownell dbrown
be modified by the userspace).
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
v2: Refreshed against the current omap-for-linus branch
(b610ec502376d915b76a62e22576c5d0462cc9c9).
arch/arm/mach-omap2/prcm.c |4 ++--
arch/arm/plat-omap/include/plat/prcm.h |2 +-
arch/arm
be modified by the userspace).
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/prcm.c |4 ++--
arch/arm/plat-omap/include/plat/prcm.h |2 +-
arch/arm/plat-omap/include/plat/system.h |6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff
Hi,
On Wed, 10 Feb 2010, Tony Lindgren wrote:
* Aaro Koskinen aaro.koski...@nokia.com [100208 04:29]:
The platform data allocated with kmalloc() will become unreachable once
the init is complete, so it should be freed. The problem was discovered
by kmemleak.
Looks like this is safe to do
The platform data allocated with kmalloc() will become unreachable once
the init is complete, so it should be freed. The problem was discovered
by kmemleak.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/hsmmc.c |7 ++-
1 files changed, 6 insertions(+), 1
send the patch to ben-li...@fluff.org with
linux-omap and linux-...@vger.kernel.org in CC.
Tested-by: Aaro Koskinen aaro.koski...@nokia.com
drivers/i2c/busses/i2c-omap.c | 21 +
1 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b
Hi,
ext Kalle Valo wrote:
Aaro Koskinen aaro.koski...@nokia.com writes:
Enable tsc2005 touchscreen driver on the RX-51 board.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
The patch is for 2.6.32-rc6.
[...]
+static struct spi_board_info rx51_peripherals_spi_board_info
Enable tsc2005 touchscreen driver on the RX-51 board.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
The patch is for 2.6.32-rc6.
arch/arm/configs/rx51_defconfig |1 +
arch/arm/mach-omap2/board-rx51-peripherals.c | 66 ++
2 files changed, 67
.
Signed-off-by: Lauri Leukkunen lauri.leukku...@nokia.com
[aaro.koski...@nokia.com: patch description, rebasing cleanup]
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
CC: David Brownell dbrown...@users.sourceforge.net
CC: Phil Carmody ext-phil.2.carm...@nokia.com
CC: Imre Deak imre.d
Hello,
Govindraj.R wrote:
This patch adds support for OMAP3430-HIGH SPEED UART Controller.
Signed-off-by: Govindraj R govindraj.r...@ti.com
Could you fix these checkpatch errors:
ERROR: need consistent spacing around '|' (ctx:VxW)
#477: FILE: drivers/serial/omap-serial.c:238:
+ }
-by: Aaro Koskinen aaro.koski...@nokia.com
---
drivers/i2c/busses/i2c-omap.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 827da08..34ea9ed 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses
From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
Include wake up events for receiver overflow and transmitter
underflow in OMAP_I2C_WE_REG configuration. Also fix a small
typo.
Signed-off-by: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
Signed-off-by: Aaro Koskinen aaro.koski
The I2C-1 bus frequency on RX-51 should be 2.2 MHz.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/board-rx51-peripherals.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c
b/arch/arm/mach-omap2
The I2C-1 bus frequency on RX-51 should be 2.2 MHz. The speed is limited
by TWL5030/GAIA; a higher speed could lead to errors on the interface. The
maximum speed depends on the system clock for GAIA: 2.2 MHz (if 19.2 MHz),
2.4 MHz (26 MHz) or 2.9 MHz (38.4 MHz).
Signed-off-by: Aaro Koskinen
Hello,
Kalle Jokiniemi wrote:
On Wed, 2009-09-30 at 19:36 +0300, Kevin Hilman wrote:
Seems like the latency value should also be (optionally) passed in
pdata so this can be experimented with per-platform.
Well, it kind of is already, since we pass the function that sets the
latency from
chip select.
ext Kevin Hilman wrote:
From: Hemanth V heman...@ti.com
This patch adds context save/restore feature to McSPI driver.
This includes fixes by Aaro Koskinen
Signed-off-by: Hemanth V heman...@ti.com
Reviewed-by: Aaro Koskinen aaro.koski...@nokia.com
Signed-off-by: Kevin Hilman khil
Hello,
Kevin Hilman wrote:
From: Rajendra Nayak rna...@ti.com
Because of OMAP off-mode, powerdomain can go off when I2C is idle.
Save enough state, and do a re-init for each transfer.
Additional save/restore state added by Jagadeesh Bhaskar Pakaravoor
(SYSC_REG) and Aaro Koskinen (wakeup
:
From: Hemanth V heman...@ti.com
This patch adds context save/restore feature to McSPI driver.
This includes fixes by Aaro Koskinen
Signed-off-by: Hemanth V heman...@ti.com
Reviewed-by: Aaro Koskinen aaro.koski...@nokia.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
---
drivers/spi
Hello,
ext Hemanth V wrote:
From: Aaro Koskinen aaro.koski...@nokia.com
From: Eero Nurkkala ext-eero.nurkk...@nokia.com
When data is read through DMA, the last element must be read separately
through the RX register. It cannot be transferred by the DMA. For further
details see e.g. OMAP3430
while keeping the idea.]
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
drivers/spi/omap2_mcspi.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index d6d0c5d..0f640b0 100644
--- a/drivers
Use longer noise filter period for fast and standard mode. Based on an
earlier patch by Eero Nurkkala.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
drivers/i2c/busses/i2c-omap.c | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses
ns 60 ns
1700320 ns 120 ns
and for F/S:
speed tLowtHigh
400 1300 ns 600 ns
100 4700 ns 4000 ns
By using duty cycles 33/66 (HS, F) and 50/50 (S) we stay above these
minimum values.
Signed-off-by: Aaro
Clear DMA channel states so that users can assume a known initial state.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/plat-omap/dma.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index
Hello,
Paul Walmsley wrote:
It seems to work: under constant I2C load, no spurious IRQ messages
showed up after several hours of testing. (Without these patches,
spurious IRQs usually show up in a few minutes.) Some of the code has
also been cleaned up.
Any feedback on how this series works
Save and restore I2C wakeup sources.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
drivers/i2c/busses/i2c-omap.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 50f3285..5ce055c 100644
Wrong index was used for ILR.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/irq.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
index 6cc5757..f813916 100644
--- a/arch/arm/mach
Hello,
Woodruff, Richard wrote:
Recently one custom board was having some I2C issues. In looking at it a couple
things stood out.
I've attached a patches for l-o and l-z for anyone to comment on which cares.
I hope these fixes are not ignored. Maybe they should be resent as they
are missing
Hello,
ext Nishanth Menon wrote:
Oops.. copy-paste typo.. :(
tLow = (scll+3) * iclk
tHigh = (sclh+9) * iclk
Vs:
TRM:
tHigh = ( sclh +5 )*iclk period
tLow = ( scll +7 )*iclk period
But my question is this: why are we trying to a different equation
here compared to the equation in the TRM?
Hello,
ext Nishanth Menon wrote:
Aaro Koskinen said the following on 02/24/2009 11:09 AM:
TRM:
tHigh = ( sclh +5 )*iclk period
tLow = ( scll +7 )*iclk period
But my question is this: why are we trying to a different equation
here compared to the equation in the TRM?
The problem with TRM
Hello,
Two fixes for twl4030-madc:
- The first one converts the ioctl to unlocked one.
- The second one should return the conversion status to user quicker,
both in OK and timeout cases. There's also fix for the timeout case
(currently the request remains active) and some cleanup.
A.
--
To
No need to wait before the first read, as the operation is likely
completed already. For timeout 50 milliseconds is an overkill, poll the
register for the duration of 5 milliseconds at maximum.
Also, clear the active flag in case of timeout.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Use unlocked ioctl instead of taking the BKL for an operation that can
take some milliseconds. The driver mutex is now taken before the active
status check, so that the concurrent users of this ioctl won't start
seeing EBUSY (previously guaranteed by the BKL).
Signed-off-by: Aaro Koskinen
Fixes a linker error when OMAP I2C bus driver is compiled as a module:
ERROR: i2c_register_board_info [arch/arm/plat-omap/i2c.ko] undefined!
The I2C utility functions used for board initialization should be always
built-in.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm
-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/plat-omap/common.c | 14 +-
1 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c
index 8c53125..2866612 100644
--- a/arch/arm/plat-omap/common.c
+++ b/arch
Hello,
ext Jarkko Nikula wrote:
Jarkko Nikula jhnik...@gmail.com wrote:
Tony's version does not fix the issue since obj-$(CONFIG_I2C_OMAP)
below still tries to compile arch/arm/plat-omap/i2c.c as a module.
-obj-$(CONFIG_I2C_OMAP) += i2c.o
+
+ifneq ($(CONFIG_I2C_OMAP),)
+
Hello,
ext Nayak, Rajendra wrote:
From: Hemanth V heman...@ti.com
This patch adds context save/restore feature to McSPI driver.
This includes fixes by Aaro Koskinen
Signed-off-by: Hemanth V heman...@ti.com
For some reason git-am does not take this to my tree, but when applied
with patch
Hello,
Here's two fixes for the recent save/restore change (OMAP3 McSPI: Adds
context save/restore), which does not seem to work with chip select.
Jouni Hogander already sent one patch, but it does not solve all the
problems. This patch updates the shadow value on every write, and uses
it
Fix context save/restore to work with chip select. Also update the shadow
CHCONF0 register on every write and eliminate register reads.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
drivers/spi/omap2_mcspi.c | 51 +---
1 files changed, 29
spin_unlock_irq() not called on failure path
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
drivers/spi/omap2_mcspi.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index 4d09777..56e91a4 100644
Hello,
ext Pakaravoor, Jagadeesh wrote:
From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
Save and restore should include OMAP_I2C_SYSC_REG.
Signed-off-by: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
CC: Jouni Hogander jouni.hogan...@nokia.com
---
Index:
to
clockevent code trying to program the timer with zero ticks).
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
---
arch/arm/mach-omap2/timer-gp.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/timer-gp.c b/arch/arm/mach-omap2/timer-gp.c
index
Hello,
Woodruff, Richard wrote:
clockevent_delta2ns(3, clockevent_gpt);
min_delta_ns stops the frame work from trying to program an expiry time
which may not be achievable due to timer costs.
A write to the timer when it has a 32KHz F-Clock can take ~3 32Khz clock
cycles to
clockevent_delta2ns() used to initialize min_delta_ns rounds the value
down, so the result can be too small. When clockevents_program_event()
is using too small value it will try to program the timer with zero
ticks stalling the timer queue.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
401 - 499 of 499 matches
Mail list logo
