Madhusudhan Chikkature wrote:
This version should apply fine on the latest kernel. I did a sanity test of
MMC/SD cards on OMAP4 SDP.
This /looks/ okay to me, but I can't test it.
From 08b77fd388f19f5df3758a2c59dcdec280f373c8 Mon Sep 17 00:00:00 2001
From: David Vrabel david.vra...@csr.com
On 27/08/2010 20:22, Chris Ball wrote:
Hi David,
On Mon, Feb 22, 2010 at 02:24:17PM +, David Vrabel wrote:
These patches add support for SDIO cards to the omap_hsmmc driver.
Power management changes to prevent SDIO cards from being turned off
and losing all state, and card interrupts
the completion/giveback work item. This avoids
having to a) allocate memory on completion; b) create a second queue
structure.
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http
I think so anyway).
David Vrabel (2):
mmc: omap_hsmmc: don't turn SDIO cards off when idle
mmc: omap_hsmmc: enable SDIO card interrupts
drivers/mmc/host/omap_hsmmc.c | 114 -
1 files changed, 79 insertions(+), 35 deletions(-)
--
To unsubscribe from
Don't turn SDIO cards off to save power. Doing so will lose all
internal state in the card.
Signed-off-by: David Vrabel david.vra...@csr.com
---
drivers/mmc/host/omap_hsmmc.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b
when the CORE
power domain is OFF) as wake-up sources in the PRCM.
The writes to STAT and ISE when starting a command are unnecessary and
have been removed.
Signed-off-by: David Vrabel david.vra...@csr.com
---
drivers/mmc/host/omap_hsmmc.c | 102
1 files
;
status = OMAP_HSMMC_READ(host-base, STAT);
This line is the real problem. We re-read MMCi_STAT after acknowledging
(clearing) it.
Please see the version #2 of the patchset.
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44
Felipe Contreras wrote:
On Mon, Feb 22, 2010 at 4:24 PM, David Vrabel david.vra...@csr.com wrote:
These patches add support for SDIO cards to the omap_hsmmc driver.
Power management changes to prevent SDIO cards from being turned off
and losing all state, and card interrupts.
I've been
by leave the SDIO card idle?
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
Member of the CSR plc group of companies. CSR plc registered
Madhusudhan wrote:
-Original Message-
From: David Vrabel [mailto:david.vra...@csr.com]
Sent: Wednesday, February 10, 2010 5:52 AM
To: linux-...@vger.kernel.org
Cc: David Vrabel; linux-omap@vger.kernel.org; madhu...@ti.com
Subject: [PATCH 1/3] mmc: omap_hsmmc: use packet sync'd DMA
David Vrabel wrote:
+static void omap_hsmmc_enable_sdio_irq(struct mmc_host *mmc, int enable)
+{
+ struct omap_hsmmc_host *host = mmc_priv(mmc);
+ u32 ie, con;
+ unsigned long flags;
+
+ spin_lock_irqsave(host-irq_lock, flags);
+
+ /*
+ * When interrupts
Madhusudhan wrote:
-Original Message-
From: David Vrabel [mailto:david.vra...@csr.com]
Sent: Wednesday, February 10, 2010 5:52 AM
To: linux-...@vger.kernel.org
Cc: David Vrabel; linux-omap@vger.kernel.org; madhu...@ti.com
Subject: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card
Mike Rapoport wrote:
Hi David,
David Vrabel wrote:
These patches add support for SDIO cards to the omap_hsmmc driver. Less
restrictions on the sizes of transfers, power management changes to
prevent SDIO cards from being turned off and losing all state, and card
interrupts.
I've been
, keep in mind that the buffers for transfers must begin and end on
a word boundary. The OMAP's DMA controller can only transfer whole
words to the MMC FIFO.
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road
for
testing and the N900 support in mainline is incomplete.
David Vrabel (3):
mmc: omap_hsmmc: use packet sync'd DMA
mmc: omap_hsmmc: don't turn SDIO cards off when idle
mmc: omap_hsmmc: enable SDIO card interrupts
drivers/mmc/host/omap_hsmmc.c | 123
Use packet sync'd DMA in the omap_hsmmc driver to avoid the
restriction that transfers must be a multiple of the block size. This
is required for byte-mode transfers to SDIO cards.
Signed-off-by: David Vrabel david.vra...@csr.com
---
drivers/mmc/host/omap_hsmmc.c | 17 +
1
Don't turn SDIO cards off to save power. Doing so will lose all
internal state in the card.
Signed-off-by: David Vrabel david.vra...@csr.com
---
drivers/mmc/host/omap_hsmmc.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b
a command are unnecessary and
have been removed.
Signed-off-by: David Vrabel david.vra...@csr.com
---
As noted in the FIXME comment, I think the correct thing to do is to
always leave FCLK enabled. The clock/clockdomain subsystems should be
configuring smart-idle mode making explicit calls to disable
18 matches
Mail list logo
