From: Evgeny Kuznetsov ext-eugeny.kuznet...@nokia.com
Value of isr_reg pointer is depend on configuration and GPIO method.
Potentially it may have NULL value and it is dereferenced later
in code. Warning and exit from function are added in this case.
Signed-off-by: Evgeny Kuznetsov ext
On Wed, 2010-10-13 at 16:09 +0400, Evgeny Kuznetsov wrote:
On Wed, 2010-10-13 at 17:20 +0530, ext Varadarajan, Charulatha wrote:
snip
From: Evgeny Kuznetsov ext-eugeny.kuznet...@nokia.com
Value of isr_reg pointer is depend on configuration and GPIO method
.
And added WARN_ON() macro and exit from function if pointer isr_reg is NULL.
Also compilation check is added for correct architecture
configuration.
Thanks,
Evgeny
Evgeny Kuznetsov (1):
omap: Ptr isr_reg tracked as NULL was dereferenced
arch/arm/plat-omap/gpio.c | 18 ++
1 files
From: Evgeny Kuznetsov ext-eugeny.kuznet...@nokia.com
Value of isr_reg pointer is depend on configuration and GPIO method.
Potentially it may have NULL value and it is dereferenced later
in code. If pointer is NULL there is some kernel issue.
Warning and exit from function are added in this case
On Wed, 2010-10-13 at 16:25 +0530, ext Varadarajan, Charulatha wrote:
-Original Message-
From: Evgeny Kuznetsov [mailto:ext-eugeny.kuznet...@nokia.com]
Sent: Wednesday, October 13, 2010 3:35 PM
To: t...@atomide.com
Cc: linux-omap@vger.kernel.org; linux-ker...@vger.kernel.org
On Wed, 2010-10-13 at 17:20 +0530, ext Varadarajan, Charulatha wrote:
snip
From: Evgeny Kuznetsov ext-eugeny.kuznet...@nokia.com
Value of isr_reg pointer is depend on configuration and GPIO method.
Potentially it may have NULL value and it is dereferenced later
in code
On Wed, 2010-10-06 at 10:33 +0400, Evgeny Kuznetsov wrote:
On Tue, 2010-10-05 at 08:01 -0700, ext Kevin Hilman wrote:
Felipe Balbi ba...@ti.com writes:
Hi,
On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
+ if (!isr_reg) {
+ printk(KERN_ERR FATAL
On Tue, 2010-10-05 at 08:01 -0700, ext Kevin Hilman wrote:
Felipe Balbi ba...@ti.com writes:
Hi,
On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
+ if (!isr_reg) {
+ printk(KERN_ERR FATAL: Incorrect GPIO method %i\n,
+ bank-method
Hi,
Here is patch which fixes bug in /arch/arm/plat-omap/gpio.c file.
Pointer which may have NULL value in some cases (depend on kernel
configuration and GPIO method) is dereferenced later in code.
If pointer is NULL it mean some kernel bug.
Thanks,
Best Regards,
Evgeny
Evgeny Kuznetsov (1
From: Evgeny Kuznetsov ext-eugeny.kuznet...@nokia.com
Value of isr_reg pointer is depend on configuration and GPIO method.
Potentially it may have NULL value and it is dereferenced later
in code. If pointer is NULL there is some kernel bug.
Log line and 'BUG' macro are added to halt code
Hi,
Yes, but no log in that case.
Regards,
Evgeny
On Tue, 2010-10-05 at 12:32 +0300, ext Felipe Balbi wrote:
Hi,
On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
+if (!isr_reg) {
+printk(KERN_ERR FATAL: Incorrect GPIO method %i\n
11 matches
Mail list logo
