Re: [RFC PATCH 1/3] of/device: manage resources similar to platform_device_add

2015-03-20 Thread Grant Likely
On Thu, 22 Jan 2015 15:49:59 -0600 , Suman Anna s-a...@ti.com wrote: Hi Grant, On 01/13/2015 05:04 PM, Suman Anna wrote: On 01/13/2015 04:00 PM, Rob Herring wrote: On Tue, Jan 13, 2015 at 3:25 PM, Suman Anna s-a...@ti.com wrote: Hi Rob, On 01/13/2015 02:38 PM, Rob Herring wrote:

Re: [RFC PATCH v2 1/4] regulator: Add helper function to get poweroff-source property

2014-10-11 Thread Grant Likely
On Fri, Oct 10, 2014 at 1:29 PM, PERIER Romain romain.per...@gmail.com wrote: What I'm more concerned about is the semantics of the property. What do the generic code paths gain by standardizing this property? Is it expected that We really need to come up with a standard property for this

Re: [RFC PATCH v2 1/4] regulator: Add helper function to get poweroff-source property

2014-10-10 Thread Grant Likely
On Tue, Oct 7, 2014 at 8:43 PM, PERIER Romain romain.per...@gmail.com wrote: This is not the final location, I have no idea exactly where I might put this helper function. This is why I ask you your opinion (and also, this is why that's a proposal) 2014-10-07 21:45 GMT+02:00 Romain Perier

Re: [RFC PATCH 2/2] of/clk: use clkops-clocks to specify clocks handled by clock_ops domain

2014-07-28 Thread Grant Likely
On Thu, 12 Jun 2014 19:53:43 +0300, Grygorii Strashko grygorii.stras...@ti.com wrote: Use clkops-clocks property to specify clocks handled by clock_ops domain PM domain. Only clocks defined in clkops-clocks set of clocks will be handled by Runtime PM through clock_ops Pm domain.

Re: [RFC PATCH 2/2] of/clk: use clkops-clocks to specify clocks handled by clock_ops domain

2014-07-28 Thread Grant Likely
On Mon, Jul 28, 2014 at 11:47 AM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hi Grant. On 07/28/2014 05:05 PM, Grant Likely wrote: On Thu, 12 Jun 2014 19:53:43 +0300, Grygorii Strashko grygorii.stras...@ti.com wrote: Use clkops-clocks property to specify clocks handled by clock_ops

Re: Unifying cape overlays into boot .dtb for BeagleBoard.org boards

2014-06-17 Thread Grant Likely
On Tue, 17 Jun 2014 10:09:31 +0100, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Jun 16, 2014 at 09:22:50AM -0400, Jason Kridner wrote: Adding devicetree and linux-arm-kernel lists based on feedback on IRC... On Tue, Jun 10, 2014 at 12:46 PM, Jason Kridner

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

2014-05-01 Thread Grant Likely
On Wed, 30 Apr 2014 23:54:37 +0200, Geert Uytterhoeven ge...@linux-m68k.org wrote: Hi Grant, On Tue, Apr 29, 2014 at 3:16 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, 25 Apr 2014 16:44:58 -0700, Kevin Hilman khil...@linaro.org wrote: Geert Uytterhoeven geert+rene

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

2014-05-01 Thread Grant Likely
On Thu, May 1, 2014 at 2:41 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: Hi Grant, On Thu, May 1, 2014 at 10:03 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, 30 Apr 2014 23:54:37 +0200, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Tue, Apr 29, 2014 at 3:16 PM, Grant

Re: [PATCH 51/97] ARM: l2c: remove platforms/SoCs setting early BRESP

2014-05-01 Thread Grant Likely
On Tue, 29 Apr 2014 01:21:41 +0100, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Apr 29, 2014 at 09:02:27AM +0900, Simon Horman wrote: On Mon, Apr 28, 2014 at 08:30:32PM +0100, Russell King wrote: Since we now automatically enable early BRESP in core L2C-310 code when

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

2014-04-29 Thread Grant Likely
On Fri, 25 Apr 2014 16:44:58 -0700, Kevin Hilman khil...@linaro.org wrote: Geert Uytterhoeven geert+rene...@glider.be writes: When adding a device from DT, check if its clocks are suitable for Runtime PM, and register them with the PM core. If Runtime PM is disabled, just enable the

Re: pandaboard boot crash with linux-next

2014-03-19 Thread Grant Likely
, and dropped __of_populate() hunks] Signed-off-by: Grant Likely grant.lik...@linaro.org Can you try this? It should fix it (plus it should be in -next soon) Thanks, that fixes the issue (tested on omap4 panda). Tomi Yeah I know; my beaglebone hangs as well without it :) Hi Tomi

Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support

2013-10-30 Thread Grant Likely
On Sun, 27 Oct 2013 12:47:53 +0100, Pavel Machek pa...@ucw.cz wrote: +#if IS_ENABLED(CONFIG_OF) I'm probably missing something here, but why not #ifdef CONFIG_OF? I have been told for other drivers, that IS_ENABLED() is the prefered way to check for configuration these days.

Re: [PATCH] twl4030_charger: add devicetree support.

2013-10-24 Thread Grant Likely
+ interrupt handler) - interrupts 9 and 2. + +Optional properties: +- bb-uvolt: microvolts for charging the backup battery. +- bb-uamp: microamps for charging the backup battery. prop should have vendor prefix. ti,bb-uvolt, ti,bb-uamp Agreed. Otherwise: Acked-by: Grant Likely

Re: [PATCH v2] serial: omap: Add support for optional wake-up

2013-10-24 Thread Grant Likely
On Tue, 22 Oct 2013 06:49:48 -0700, Tony Lindgren t...@atomide.com wrote: With the recent pinctrl-single changes, omaps can treat wake-up events from deeper idle states as interrupts. There's a separate io chain controller on most omaps that stays enabled when the device hits off-idle and

Re: [PATCH 22/51] DMA-API: amba: get rid of separate dma_mask

2013-09-22 Thread Grant Likely
/of/platform.c portion: Acked-by: Grant Likely grant.lik...@linaro.org g. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-18 Thread Grant Likely
On Thu, 12 Sep 2013 17:57:00 +0200, Alexander Holler hol...@ahsoftware.de wrote: Am 12.09.2013 17:19, schrieb Stephen Warren: IRQs, DMA channels, and GPIOs are all different things. Their bindings are defined independently. While it's good to define new types of bindings consistently

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-28 Thread Grant Likely
s.nawro...@samsung.com Signed-off-by: Wolfram Sang w...@the-dreams.de Acked-by: Grant Likely grant.lik...@linaro.org --- V2-V3: Was trying to be too smart by only fixing includes needed. Took a more general approach this time, converting of_i2c.h to i2c.h in case i2c.h

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-07-29 Thread Grant Likely
On Mon, Jul 29, 2013 at 6:36 AM, Linus Walleij linus.wall...@linaro.org wrote: To solve this dilemma, perform an interrupt consistency check when adding a GPIO chip: if the chip is both gpio-controller and interrupt-controller, walk all children of the device tree, check if these in turn

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-24 Thread Grant Likely
On Mon, 22 Jul 2013 16:16:07 -0500, Rob Herring robherri...@gmail.com wrote: On 07/21/2013 06:44 PM, Grant Likely wrote: On Sun, Jul 21, 2013 at 9:48 PM, Rob Herring robherri...@gmail.com wrote: On 07/21/2013 09:42 AM, Rob Herring wrote: On 07/19/2013 01:14 PM, Sebastian Andrzej Siewior

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-21 Thread Grant Likely
On Sun, Jul 21, 2013 at 9:48 PM, Rob Herring robherri...@gmail.com wrote: On 07/21/2013 09:42 AM, Rob Herring wrote: On 07/19/2013 01:14 PM, Sebastian Andrzej Siewior wrote: So I called of_platform_populate() on a device to get each child device probed and on rmmod and I need to reverse its

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-01 Thread Grant Likely
On Mon, Jul 1, 2013 at 9:04 AM, Linus Walleij linus.wall...@linaro.org wrote: On Sun, Jun 30, 2013 at 2:25 AM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: Yes, It doesn't apply cleanly to your next branch cleanly because this patch-set depends on the following bugfix patch

Re: [PATCH v3 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-06-28 Thread Grant Likely
a GPIO as input and enabling the GPIO bank. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Acked-by: Grant Likely grant.lik...@linaro.org --- Changes since v2: - Unconditionally do the IRQ setup in the .map() function and only call irq_create_mapping() in the gpio

Re: [PATCH v3 2/2] gpio/omap: auto request GPIO as input if used as IRQ via DT

2013-06-28 Thread Grant Likely
...@collabora.co.uk Acked-by: Grant Likely grant.lik...@linaro.org --- Changes since v2: - Only make the call to gpio_request_one() conditional in the DT case as suggested by Grant Likely. Changes since v1: - Split the irq domain mapping function handler and the GPIO request in two

[GIT PULL] GPIO regression fix for omap1 for v3.10-rc

2013-06-26 Thread Grant Likely
Hi Linus, It took a while to work out the correct solution to this regression. It is sorted now. This branch was constructed and tested by Tony. I've verified that it builds and signed the tag. Please pull into v3.10. g. The following changes since commit

Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression

2013-06-25 Thread Grant Likely
On Tue, Jun 25, 2013 at 8:04 AM, Tony Lindgren t...@atomide.com wrote: * Grant Likely grant.lik...@secretlab.ca [130624 09:00]: On Mon, Jun 24, 2013 at 8:21 AM, Tony Lindgren t...@atomide.com wrote: * Javier Martinez Canillas martinez.jav...@gmail.com [130623 18:08]: On Mon, Jun 24, 2013

Re: [PATCH v2 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-06-24 Thread Grant Likely
On Sat, 22 Jun 2013 00:50:53 +0200, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: When a GPIO is defined as an interrupt line using Device Tree, a call to irq_create_of_mapping() is made that calls irq_create_mapping(). So, is not necessary to do the mapping on the OMAP GPIO

Re: [PATCH v2 2/2] gpio/omap: auto request GPIO as input if used as IRQ via DT

2013-06-24 Thread Grant Likely
On Sat, 22 Jun 2013 00:50:54 +0200, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: When an OMAP GPIO is used as an IRQ line, a call to gpio_request() has to be made to initialize the OMAP GPIO bank before a driver request the IRQ. Otherwise the call to request_irq() fails.

Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression

2013-06-24 Thread Grant Likely
On Mon, Jun 24, 2013 at 8:21 AM, Tony Lindgren t...@atomide.com wrote: * Javier Martinez Canillas martinez.jav...@gmail.com [130623 18:08]: On Mon, Jun 24, 2013 at 1:43 AM, Aaro Koskinen aaro.koski...@iki.fi wrote: Hi, On Mon, Jun 24, 2013 at 01:06:37AM +0200, Javier Martinez Canillas

Re: [PATCH RFC 1/3] clk: omap: introduce clock driver

2013-06-14 Thread Grant Likely
On Mon, 3 Jun 2013 23:39:16 -0700, Mike Turquette mturque...@linaro.org wrote: Parses OMAP clock data from DT and registers those clocks with the clock framework. dt_omap_clk_init must be called early during boot for timer initialization so it is exported and called from the existing clock

Re: [PATCH 1/3] ARM: dts: Add headers with constants for MTD partitions

2013-06-12 Thread Grant Likely
___ devicetree-discuss mailing list devicetree-disc...@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 3/3] ARM: dts: OMAP3: Use MTD constants for OMAP3 boards

2013-06-12 Thread Grant Likely
On Tue, 11 Jun 2013 17:29:43 +0200, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: On 06/11/2013 04:48 PM, Florian Vaussard wrote: Use the MTD constants for NAND and OneNAND nodes used in OMAP3 DTS. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch ---

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-06-11 Thread Grant Likely
On Fri, 26 Apr 2013 16:31:24 -0500, Jon Hunter jon-hun...@ti.com wrote: On 04/26/2013 02:31 AM, Linus Walleij wrote: On Wed, Apr 17, 2013 at 2:41 AM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: So: +static int omap_gpio_irq_domain_xlate(struct irq_domain *d, +

Re: [PATCH] ARM: dts: omap3-devkit8000: fix NAND memory binding

2013-06-11 Thread Grant Likely
fax: +41 21 693 78 07 http://lsro.epfl.ch ___ devicetree-discuss mailing list devicetree-disc...@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe

Re: [PATCH] ARM: dts: Protect pinctrl headers against multiple inclusions

2013-06-11 Thread Grant Likely
...@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression

2013-06-05 Thread Grant Likely
, irq_base, + 0, irq_domain_simple_ops, NULL); if (bank-regs-set_dataout bank-regs-clr_dataout) bank-set_dataout = _set_gpio_dataout_reg; -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send

Re: [PATCH 1/1] of/irq: store IRQ trigger/level in struct resource flags

2013-06-05 Thread Grant Likely
On Tue, 09 Apr 2013 00:44:05 +0200, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: On 04/09/2013 12:05 AM, Rob Herring wrote: On 04/05/2013 02:48 AM, Javier Martinez Canillas wrote: This means that drivers that need the IRQ type/level flags defined in the DT won't be able

Re: [PATCH 1/1] of/irq: store IRQ trigger/level in struct resource flags

2013-06-05 Thread Grant Likely
On Fri, 5 Apr 2013 09:48:08 +0200, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: [...] irq_of_parse_and_map() calls to irq_create_of_mapping() which calls to the correct xlate function handler according to #interrupt-cells (irq_domain_xlate_onecell or

Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-04-19 Thread Grant Likely
On Tue, 16 Apr 2013 15:48:07 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: On Tuesday 16 April 2013 01:20 AM, Grant Likely wrote: On Mon, 15 Apr 2013 17:56:10 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: On Monday 15 April 2013 05:04 PM, Grant Likely wrote: On Wed, 20 Mar

Re: [PATCH] Documentation: dt: update properties in TI GPMC NAND example

2013-04-16 Thread Grant Likely
. Signed-off-by: Jon Hunter jon-hun...@ti.com Acked-by: Grant Likely grant.lik...@secretlab.ca --- .../devicetree/bindings/mtd/gpmc-nand.txt | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt

Re: [PATCH v3 0/6] Generic PHY Framework

2013-04-15 Thread Grant Likely
On Wed, 20 Mar 2013 14:41:59 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference

Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-04-15 Thread Grant Likely
On Wed, 20 Mar 2013 14:42:00 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY

Re: [PATCH v3 0/6] Generic PHY Framework

2013-04-15 Thread Grant Likely
On Mon, 15 Apr 2013 16:06:37 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Monday 15 April 2013 03:50 PM, Grant Likely wrote: On Wed, 20 Mar 2013 14:41:59 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: Added a generic PHY framework that provides a set of APIs

Re: [PATCH V4 10/18] ARM: OMAP2+: Add function to read GPMC settings from device-tree

2013-04-15 Thread Grant Likely
On Tue, 19 Mar 2013 11:35:48 -0500, Jon Hunter jon-hun...@ti.com wrote: Adds a function to read the various GPMC chip-select settings from device-tree and store them in the gpmc_settings structure. Update the GPMC device-tree binding documentation to describe these options. Signed-off-by:

Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-04-15 Thread Grant Likely
On Mon, 15 Apr 2013 17:56:10 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Monday 15 April 2013 05:04 PM, Grant Likely wrote: On Wed, 20 Mar 2013 14:42:00 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: The PHY framework provides a set of APIs for the PHY drivers

Re: [PATCH 2/5] capemgr: Add beaglebone's cape driver bindings

2013-03-26 Thread Grant Likely
; + manufacturer = Texas Instruments; + part-number = BB-BONE-FOO-01; + }; + }; + +}; + -- 1.7.12 -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH 1/5] capemgr: Beaglebone DT overlay based cape manager

2013-03-26 Thread Grant Likely
On Tue, 8 Jan 2013 12:10:20 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Lee, On Jan 8, 2013, at 12:00 PM, Lee Jones wrote: At the end of the line, some kind of hardware glue is going to be needed. I just feel that drawing from a sample size of 1 (maybe 2 if I

Re: [PATCH 3/6] OF: Export all DT proc update functions

2013-03-19 Thread Grant Likely
On Tue, 19 Mar 2013 13:42:32 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Grant, The 3rd patch is in preparation for some patches I have in WIP that would allow drivers to set notifications for properties that are changed in runtime. Okay, submit it with that series

Re: [PATCH 5/6] OF: Introduce Device Tree resolve support.

2013-03-19 Thread Grant Likely
On Tue, 19 Mar 2013 13:51:01 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Grant, On Mar 16, 2013, at 11:24 AM, Grant Likely wrote: On Wed, 23 Jan 2013 12:58:02 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi David, On Jan 23, 2013, at 6:40 AM

Re: [PATCH 5/6] OF: Introduce Device Tree resolve support.

2013-03-16 Thread Grant Likely
On Wed, 23 Jan 2013 12:58:02 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi David, On Jan 23, 2013, at 6:40 AM, David Gibson wrote: Ok. Nonetheless it's not hard to avoid a recursive approach here. How can I find the maximum phandle value of a subtree without using

Re: [PATCH 3/6] OF: Export all DT proc update functions

2013-03-16 Thread Grant Likely
On Fri, 4 Jan 2013 21:31:07 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: There are other users for the proc DT functions. Export them. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Actually, I cannot find the user of this patch. Why is it needed? g. -- To

Re: [PATCH 3/6] OF: Export all DT proc update functions

2013-03-16 Thread Grant Likely
On Fri, 4 Jan 2013 21:31:07 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: There are other users for the proc DT functions. Export them. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Hi Pantelis. Patches 1 2 look good. No comments there. This patch

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-03-03 Thread Grant Likely
On Tue, 26 Feb 2013 17:01:22 -0600, Jon Hunter jon-hun...@ti.com wrote: On 02/26/2013 04:44 PM, Stephen Warren wrote: On 02/26/2013 03:40 PM, Jon Hunter wrote: On 02/26/2013 04:01 AM, Javier Martinez Canillas wrote: Are you requesting the gpio anywhere? If not then this is not going to

Re: [PATCH 1/2] gpio/omap: convert gpio irq domain to linear mapping

2013-03-03 Thread Grant Likely
On Fri, 1 Mar 2013 11:22:47 -0600, Jon Hunter jon-hun...@ti.com wrote: Currently the OMAP GPIO driver uses a legacy mapping for the GPIO IRQ domain. This is not necessary because we do not need to assign a specific interrupt number to the GPIO IRQ domain. Therefore, convert the OMAP GPIO

Re: [PATCH 2/2] gpio/omap: warn if bank is not enabled on setting irq type

2013-03-03 Thread Grant Likely
On Fri, 1 Mar 2013 11:22:48 -0600, Jon Hunter jon-hun...@ti.com wrote: For OMAP devices, if a gpio is being used as an interrupt source but has not been requested by calling gpio_request(), a call to request_irq() may cause the kernel hang because the gpio bank may be disabled and hence the

Re: [PATCH RFC 1/7] platform: add a device node

2013-02-18 Thread Grant Likely
DT nodes to it sounds like the wrong thing to be doing. Right; I'd expect your platform device creation to go through the of_platform_populate() route. What is your use-case? g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line

Re: [PATCH RFC 1/7] platform: add a device node

2013-02-18 Thread Grant Likely
On Sun, Feb 10, 2013 at 11:35 AM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: On Sun, Feb 10, 2013 at 10:37 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Sun, Feb 10, 2013 at 02:49:21AM +0100, Javier Martinez Canillas wrote: I knew this would be controversial and

Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data

2013-02-09 Thread Grant Likely
On Thu, 10 Jan 2013 14:09:35 +0100, Peter Ujfalusi peter.ujfal...@ti.com wrote: Hi Linus, On 01/10/2013 11:41 AM, Linus Walleij wrote: On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: Use more coherent locking in the driver. Use bitfield to store the

Re: [PATCH v2] drivers/gpio: using common order: let 'static const' instead of 'const static'

2013-02-09 Thread Grant Likely
On Wed, 6 Feb 2013 16:17:24 +0530, Santosh Shilimkar santosh.shilim...@ti.com wrote: On Wednesday 06 February 2013 04:14 PM, Chen Gang wrote: 'const static ' is not a common order, better to use 'static const' instead. building: make EXTRA_CFLAGS=-W ARCH=arm

Re: [PATCH] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

2013-02-08 Thread Grant Likely
= gpio3 28 0; + ti,non-removable; + bus-width = 4; + vmmc-supply = ldo2_reg; + vmmc_aux-supply = vmmc; + }; Binding looks reasonable. Reviewed-by: Grant Likely grant.lik...@secretlab.ca -- To unsubscribe from this list: send the line

Re: [PATCH v2 3/3] gpio: twl4030: TODO comment to remove the PWMA/B (LEDA/B) handling

2012-12-20 Thread Grant Likely
On Thu, Dec 20, 2012 at 9:23 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: On 12/19/2012 06:07 PM, Grant Likely wrote: On Thu, 6 Dec 2012 11:52:07 +0100, Peter Ujfalusi peter.ujfal...@ti.com wrote: This GPIO driver should not configure anything else then GPIOs. Signed-off-by: Peter

Re: [PATCH v2 2/3] gpio: twl4030: Cache the direction and output states in private data

2012-12-19 Thread Grant Likely
); -- 1.8.0 -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] gpio: twl4030: TODO comment to remove the PWMA/B (LEDA/B) handling

2012-12-19 Thread Grant Likely
an -- 1.8.0 -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] gpio: twl4030: Introduce private structure to store variables needed runtime

2012-12-19 Thread Grant Likely
-gpio_chip); if (status 0) return status; -- 1.8.0 -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 2/3] gpio: twl4030: Cache the direction and output states in private data

2012-12-19 Thread Grant Likely
On Wed, 19 Dec 2012 21:53:23 +0100, Michael Trimarchi mich...@amarulasolutions.com wrote: Hi Grant Likely grant.lik...@secretlab.ca wrote: On Thu, 6 Dec 2012 11:52:06 +0100, Peter Ujfalusi peter.ujfal...@ti.com wrote: Use more coherent locking in the driver. Use bitfield to store

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-12-19 Thread Grant Likely
On Fri, 14 Dec 2012 18:05:53 +1100, NeilBrown ne...@suse.de wrote: On Mon, 10 Sep 2012 10:57:07 -0700 Kevin Hilman khil...@deeprootsystems.com wrote: OK thanks, I'll queue this up for v3.6-rc as this should qualify as a regression. I don't think this did actually get queued. At least

Re: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-16 Thread Grant Likely
the generic GPMC timing parameters and some documentation with examples on how to use them. Successfully tested on an AM33xx board. Signed-off-by: Daniel Mack zon...@gmail.com For all patches in this series: Acked-by: Grant Likely grant.lik...@secretlab.ca -- To unsubscribe from this list

Re: [PATCH 2/2] spi: devicetree: add support for loopback mode

2012-12-16 Thread Grant Likely
On Sat, 15 Dec 2012 16:55:46 +0200, Felipe Balbi ba...@ti.com wrote: On Sat, Dec 15, 2012 at 12:32:24AM +, Grant Likely wrote: On Wed, 12 Dec 2012 10:46:00 +0200, Felipe Balbi ba...@ti.com wrote: there are a few spi master drivers which make use of that flag but there is no way

Re: [PATCH 1/2] spi: omap2: disable DMA requests before complete()

2012-12-14 Thread Grant Likely
); + + complete(mcspi_dma-dma_tx_completion); } static void omap2_mcspi_tx_dma(struct spi_device *spi, -- 1.8.1.rc1.5.g7e0651a -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-14 Thread Grant Likely
On Wed, 12 Dec 2012 17:02:10 -0600, Jon Hunter jon-hun...@ti.com wrote: So looking at this today, here is what I see when comparing the registers ... omap2430 != omap2420 omap3430 != omap2430 omap3630 == omap3430 omap4430 != omap3430 omap4460 == omap4430 omap543x == omap4430 am335x !=

Re: [PATCH 2/2] spi: devicetree: add support for loopback mode

2012-12-14 Thread Grant Likely
; + if (of_find_property(nc, spi-loopback, NULL)) + spi-mode |= SPI_LOOP; /* Device speed */ prop = of_get_property(nc, spi-max-frequency, len); -- 1.8.1.rc1.5.g7e0651a -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd

Re: [PATCH v2 0/3] gpio: twl4030: Correct status reporting for outputs

2012-12-12 Thread Grant Likely
On Wed, Dec 12, 2012 at 11:12 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: Hi Grant, On 12/07/2012 09:09 AM, Linus Walleij wrote: On Thu, Dec 6, 2012 at 11:52 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: As Grant commneted on the first version: https://lkml.org/lkml/2012/12/5/53

Re: [PATCH v3 1/5] rtc: OMAP: Add system pm_power_off to rtc driver

2012-12-11 Thread Grant Likely
properties: +- ti,system-power-controller: Telling whether or not rtc is controlling + the system power. + Acked-by: Grant Likely grant.lik...@secretlab.ca Example: rtc@1c23000 { @@ -14,4 +18,5 @@ rtc@1c23000 { interrupts = 19 19; interrupt-parent = intc

Re: [PATCH v3 2/3] mtd: devices: elm: Add support for ELM error correction

2012-12-11 Thread Grant Likely
On Thu, 29 Nov 2012 17:16:33 +0530, Philip, Avinash avinashphi...@ti.com wrote: The ELM hardware module can be used to speedup BCH 4/8/16 ECC scheme error correction. For now only 4 8 bit support is added Signed-off-by: Philip, Avinash avinashphi...@ti.com Cc: Grant Likely grant.lik

Re: [PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-05 Thread Grant Likely
), }, }; -- 1.7.11.7 -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gpio: twl4030: Correct status reporting when the GPIO is used as output

2012-12-05 Thread Grant Likely
On Wed, 5 Dec 2012 10:49:45 +0100, Peter Ujfalusi peter.ujfal...@ti.com wrote: When the GPIO is configured as output we need to read the GPIODATAOUT* register to get correct information. When the GPIO is output the GPIODATAIN* registers report 0 all the time (no feedback from output path).

Re: [PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-05 Thread Grant Likely
On Wed, 5 Dec 2012 16:33:48 -0600, Jon Hunter jon-hun...@ti.com wrote: Hi Grant, On 12/05/2012 04:22 PM, Grant Likely wrote: On Wed, 5 Dec 2012 20:09:31 +0100, Daniel Mack zon...@gmail.com wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instantiated

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-30 Thread Grant Likely
On Fri, 30 Nov 2012 07:47:52 +0100, Thierry Reding thierry.red...@avionic-design.de wrote: On Thu, Nov 29, 2012 at 04:10:24PM +, Grant Likely wrote: On Wed, 28 Nov 2012 09:54:57 +0100, Peter Ujfalusi peter.ujfal...@ti.com wrote: Hi Grant, Lars, Thierry, On 11/26/2012 04:46 PM

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-30 Thread Grant Likely
On Fri, Nov 30, 2012 at 11:04 AM, Thierry Reding thierry.red...@avionic-design.de wrote: One other problem is that some PWM devices cannot be setup to achieve a 0% or 100% duty-cycle but instead will toggle for at least one period. This would be another argument in favour of moving the

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-29 Thread Grant Likely
On Wed, 28 Nov 2012 09:54:57 +0100, Peter Ujfalusi peter.ujfal...@ti.com wrote: Hi Grant, Lars, Thierry, On 11/26/2012 04:46 PM, Grant Likely wrote: You're effectively asking the pwm layer to behave like a gpio (which is completely reasonable). Having a completely separate translation

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-26 Thread Grant Likely
On Fri, 23 Nov 2012 10:44:36 +0100, Peter Ujfalusi peter.ujfal...@ti.com wrote: Hi Grant, On 11/23/2012 10:13 AM, Peter Ujfalusi wrote: Hi Grant, On 11/23/2012 08:55 AM, Grant Likely wrote: Ugh. and this is why I wanted the PWM and GPIO subsystems to use the same namespace

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-23 Thread Grant Likely
node itself and the translation code should be in either the pwm or the gpio core. I don't think it should look like a separate device. g. -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-20 Thread Grant Likely
On Sat, 17 Nov 2012 23:27:18 +0100, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On 16:23 Fri 09 Nov , Stephen Warren wrote: On 11/09/2012 09:28 AM, Grant Likely wrote: However, I think the process for an end-user needs to be as simple as drop this .dts/.dtb file

Re: [PATCH] arm-dt: Enable DT proc updates.

2012-11-15 Thread Grant Likely
On Wed, 31 Oct 2012 21:04:24 -0500, Rob Herring robherri...@gmail.com wrote: On 10/31/2012 10:57 AM, Pantelis Antoniou wrote: This simple patch enables dynamic changes of the DT tree on runtime to be visible to the device-tree proc interface. Signed-off-by: Pantelis Antoniou

Re: [PATCH] spi: Export OF interfaces.

2012-11-15 Thread Grant Likely
On Wed, 31 Oct 2012 17:57:33 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Export an interface that other in-kernel users can utilize. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com I'm not going to apply this before an in-kernel user exists for this. I know

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-13 Thread Grant Likely
On Tue, Nov 13, 2012 at 8:09 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: On Nov 13, 2012, at 9:25 AM, David Gibson wrote: Not good to rely on userspace kicking off dtc and compiling from source. Some capes/expansion boards might have your root fs device, for example there is an

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-12 Thread Grant Likely
On Mon, Nov 12, 2012 at 11:34 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Grant, On Nov 9, 2012, at 10:33 PM, Grant Likely wrote: On Wed, Nov 7, 2012 at 11:02 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: On Nov 7, 2012, at 11:19 AM, Benoit Cousson wrote

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Mon, Nov 5, 2012 at 11:22 PM, Tony Lindgren t...@atomide.com wrote: Hi, * Tabi Timur-B04825 b04...@freescale.com [121105 13:42]: On Mon, Nov 5, 2012 at 2:40 PM, Grant Likely grant.lik...@secretlab.ca wrote: Jane is building custom BeagleBone expansion boards called 'capes'. She can

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Tue, Nov 6, 2012 at 10:37 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 11/05/2012 01:40 PM, Grant Likely wrote: Hey folks, As promised, here is my early draft to try and capture what device tree overlays need to do and how to get there. Comments and suggestions greatly appreciated

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Wed, Nov 7, 2012 at 12:54 AM, Mitch Bradley w...@firmworks.com wrote: On 11/6/2012 12:37 PM, Stephen Warren wrote: This proposal is very oriented at an overlay-based approach. I'm not totally convinced that a pure overlay approach (as in how dtc does overlayed DT nodes) will be flexible

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Wed, Nov 7, 2012 at 8:06 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Grant, On Nov 6, 2012, at 9:45 PM, Grant Likely wrote: Yes, the locking does need to be sorted out. Perhaps come up with a dt-stress test tool/boot time validator? I would like that. I've started

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Wed, Nov 7, 2012 at 11:02 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: On Nov 7, 2012, at 11:19 AM, Benoit Cousson wrote: Maybe some extra version match table can just be passed during the board machine_init of_platform_populate(NULL, omap_dt_match_table, NULL, NULL,

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Fri, Nov 9, 2012 at 2:26 AM, David Gibson da...@gibson.dropbear.id.au wrote: Summary points: - Create an FDT overlay data format and usage model - SHALL reliable resolve or validate of phandles between base and overlay trees So, I'm not at all clear on what this proposed phandle

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Fri, Nov 9, 2012 at 5:32 AM, Joel A Fernandes agnel.j...@gmail.com wrote: Hi Pantelis, I hope I'm not too late to reply as I'm traveling. On Nov 6, 2012, at 5:30 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Joanne has purchased one of Jane's capes and packaged it into a

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Fri, Nov 9, 2012 at 2:26 AM, David Gibson da...@gibson.dropbear.id.au wrote: (3) Resolving phandle references from the subtree to the main tree. So, I think this can actually be avoided, at least in cases where what physical connections are available to the expansion module is well

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Fri, Nov 9, 2012 at 10:57 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 11/08/2012 07:26 PM, David Gibson wrote: ... I also think graft will handle most of your use cases, although as I said I don't fully understand the implications of some of them, so I could be wrong. So, the

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Fri, Nov 9, 2012 at 11:06 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 11/05/2012 01:40 PM, Grant Likely wrote: As promised, here is my early draft to try and capture what device tree overlays need to do and how to get there. Comments and suggestions greatly appreciated. Here's one

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread Grant Likely
On Fri, Nov 9, 2012 at 11:23 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 11/09/2012 09:28 AM, Grant Likely wrote: On Tue, Nov 6, 2012 at 10:37 PM, Stephen Warren swar...@wwwdotorg.org wrote: ... I do rather suspect this use-case is quite common. NVIDIA certainly has a bunch

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-06 Thread Grant Likely
On Tue, Nov 6, 2012 at 10:30 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Grant, On Nov 5, 2012, at 9:40 PM, Grant Likely wrote: Hey folks, As promised, here is my early draft to try and capture what device tree overlays need to do and how to get there. Comments

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-11-06 Thread Grant Likely
On Tue, Nov 6, 2012 at 8:14 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: On Nov 6, 2012, at 4:06 AM, Joel A Fernandes wrote: Sure, so if we add data type supplementary properties to the tree to indicate the data type as indirect phandle, then kernel could refer to the index in

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-06 Thread Grant Likely
On Tue, Nov 6, 2012 at 7:34 PM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: On Nov 6, 2012, at 12:14 PM, Grant Likely wrote: On Tue, Nov 6, 2012 at 10:30 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: For hot-plugging, you need it. Whether kernel code can deal

  1   2   3   4   >