Re: [PATCH V2] hwmon: (tmp102) Force wait for conversion time for the first valid data

2015-12-01 Thread Guenter Roeck
On Tue, Dec 01, 2015 at 10:10:21AM -0600, Nishanth Menon wrote: > TMP102 works based on conversions done periodically. However, as per > the TMP102 data sheet[1] the first conversion is triggered immediately > after we program the configuration register. The temperature data > registers do not

Re: [PATCH] hwmon: (tmp102) Force wait for conversion time for the first valid data

2015-12-01 Thread Guenter Roeck
On 12/01/2015 06:21 AM, Nishanth Menon wrote: [ ... ] Hint about how the patch will look like: Looks ok (and better). Guenter diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c index 65482624ea2c..5289aa0980a8 100644 --- a/drivers/hwmon/tmp102.c +++ b/drivers/hwmon/tmp102.c @@

Re: [PATCH] hwmon: (tmp102) Force wait for conversion time for the first valid data

2015-11-30 Thread Guenter Roeck
On 11/30/2015 08:25 PM, Nishanth Menon wrote: TMP102 works based on conversions done periodically. However, as per the TMP102 data sheet[1] the first conversion is triggered immediately after we program the configuration register. The temperature data registers do not reflect proper data until

Re: [PATCH] watchdog: omap_wdt: fix null pointer dereference

2015-11-01 Thread Guenter Roeck
) from [] (ret_fast_syscall+0x0/0x3c) [ 3569.577413] Code: e12fff1e e52de004 e8bd4000 e5903060 (e5933088) [ 3569.584089] ---[ end trace cec3039bd3ae610a ]--- Cc: <sta...@vger.kernel.org> # v4.2+ Cc: Guenter Roeck <li...@roeck-us.net> Cc: Lars Poeschel <poesc...@lemonage.de> Si

Re: null pointer dereference in omap_wdt

2015-11-01 Thread Guenter Roeck
On 11/01/2015 03:11 PM, Peter Robinson wrote: Hi Lars, I'm seeing the following crash in omap_wdt in omap_wdt_get_timeleft when I just run wdctl on a couple of different TI devices, the beaglebone black/green or panda ES. I'm seeing it on both 4.2.3 and 4.3rc7, looking at git it looks like you

Re: [PATCH] ARM: multi_v7_defconfig: Enable PBIAS regulator

2015-09-08 Thread Guenter Roeck
On Sun, Sep 06, 2015 at 04:41:10PM -0700, Guenter Roeck wrote: > On Thu, Sep 03, 2015 at 03:25:11PM +0530, Kishon Vijay Abraham I wrote: > > PBIAS regulator is required for MMC module in OMAP2, OMAP3, OMAP4, > > OMAP5 and DRA7 SoCs. Enable it here. > > > > Signed-off

Re: [PATCH] ARM: multi_v7_defconfig: Enable PBIAS regulator

2015-09-06 Thread Guenter Roeck
On Thu, Sep 03, 2015 at 03:25:11PM +0530, Kishon Vijay Abraham I wrote: > PBIAS regulator is required for MMC module in OMAP2, OMAP3, OMAP4, > OMAP5 and DRA7 SoCs. Enable it here. > > Signed-off-by: Kishon Vijay Abraham I <kis...@ti.com> Tested-by: Guenter Roeck &

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Guenter Roeck
On 08/26/2015 10:04 AM, Tony Lindgren wrote: Hi, * Guenter Roeck li...@roeck-us.net [150817 13:48]: Commit 0b50dc4fc971 (Convert smsc911x to use ACPI as well as DT) makes the call to smsc911x_probe_config() unconditional, and no longer fails if there is no device node. device_get_phy_mode

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Guenter Roeck
Hi Tony, On 08/26/2015 10:04 AM, Tony Lindgren wrote: Hi, * Guenter Roeck li...@roeck-us.net [150817 13:48]: Commit 0b50dc4fc971 (Convert smsc911x to use ACPI as well as DT) makes the call to smsc911x_probe_config() unconditional, and no longer fails if there is no device node

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Guenter Roeck
Hi Tony, On 08/26/2015 01:16 PM, Tony Lindgren wrote: [ ... ] We may need two separate patches, one to fix up device_property_read_u32() to return -ENXIO, and one to fix smsc911x_probe_config() to ignore the error from device_get_phy_mode(), and to bail out if device_property_read_u32()

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-24 Thread Guenter Roeck
On 07/24/2015 03:11 PM, Pavel Machek wrote: On Fri 2015-07-24 06:59:26, Guenter Roeck wrote: On 07/23/2015 11:29 PM, Sascha Hauer wrote: On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: The thermal code uses int, long and unsigned

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-24 Thread Guenter Roeck
On 07/23/2015 11:29 PM, Sascha Hauer wrote: On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework

[PATCH -next] usb: dwc3: Remove unprintable characters from Kconfig

2015-06-14 Thread Guenter Roeck
Fix: drivers/usb/dwc3/Kconfig:16:warning: ignoring unsupported character '�' drivers/usb/dwc3/Kconfig:16:warning: ignoring unsupported character '�' Fixes: 88bc9d194ff6 (usb: dwc3: add ULPI interface support) Cc: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Guenter Roeck li

Re: [PATCH 1a/3] watchdog: omap: clearify device tree documentation

2015-04-26 Thread Guenter Roeck
On 04/24/2015 07:10 PM, Felipe Balbi wrote: On Fri, Apr 24, 2015 at 10:20:50PM +0200, Uwe Kleine-König wrote: ti,hwmods doesn't belong into the compatible section but is a property on it's own. Also reformat the section of required properties to match the usual style of dt binding documents.

Re: [PATCH 1a/3] watchdog: omap: clearify device tree documentation

2015-04-26 Thread Guenter Roeck
On 04/26/2015 12:12 PM, Uwe Kleine-König wrote: On Sun, Apr 26, 2015 at 08:29:20AM -0700, Guenter Roeck wrote: On 04/24/2015 07:10 PM, Felipe Balbi wrote: On Fri, Apr 24, 2015 at 10:20:50PM +0200, Uwe Kleine-König wrote: ti,hwmods doesn't belong into the compatible section but is a property

Re: [PATCH] (gpio-fan): Move the thermal registration after registration is complete

2015-04-08 Thread Guenter Roeck
On 04/08/2015 04:23 PM, Nishanth Menon wrote: Thermal framework may already be ready and cooling policies might already be functional when we are attempting to register gpio fan as a cooling device. This can be reproduced by changing probe order in which registration of various modules are done

Re: Clock Regression in next-20150130 caused by cb75a8fcd14e

2015-01-30 Thread Guenter Roeck
On Fri, Jan 30, 2015 at 05:04:44PM -0800, Tony Lindgren wrote: Hi all, Looks like commit cb75a8fcd14e (clk: Add rate constraints to clocks) causes a regression on at least omaps where the serial console either does not show anything, or just prints garbage. Reverting cb75a8fcd14e makes

Re: N900 v3.19-rc5 errors

2015-01-23 Thread Guenter Roeck
On Fri, Jan 23, 2015 at 02:15:56PM +0100, Pali Rohár wrote: Hello, I'm getting these two errors when booting DT linux v3.19-rc5 in n900 qemu: Hello Pali, can you send me the kernel confguration and qemu command line you are using ? Thanks, Guenter -- To unsubscribe from this list: send the

Re: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor

2015-01-18 Thread Guenter Roeck
On 01/18/2015 12:33 PM, Pavel Machek wrote: Pavel, can you look into the omap4 thermal driver to see if it can be used ? After some fixes... yes, it seems to be same hardware. So this should be the way to go, but then we have others claim that it should not be done because the OMAP3

Re: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor

2015-01-07 Thread Guenter Roeck
On Sat, Jan 03, 2015 at 10:18:58AM +0100, Pavel Machek wrote: On Mon 2014-12-29 11:04:48, Guenter Roeck wrote: On Mon, Dec 29, 2014 at 07:15:56PM +0100, Pavel Machek wrote: On Mon 2014-12-29 12:01:03, Nishanth Menon wrote: On Mon, Dec 29, 2014 at 11:52 AM, Grazvydas Ignotas nota

Re: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor

2014-12-29 Thread Guenter Roeck
On Mon, Dec 29, 2014 at 07:15:56PM +0100, Pavel Machek wrote: On Mon 2014-12-29 12:01:03, Nishanth Menon wrote: On Mon, Dec 29, 2014 at 11:52 AM, Grazvydas Ignotas nota...@gmail.com wrote: On Fri, Dec 26, 2014 at 2:34 PM, Sebastian Reichel s...@kernel.org wrote: OMAP34xx and

Re: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor

2014-12-28 Thread Guenter Roeck
On Sat, Dec 27, 2014 at 11:35:16PM +0100, Pavel Machek wrote: On Sat 2014-12-27 20:58:25, Pavel Machek wrote: On Fri 2014-12-26 13:34:53, Sebastian Reichel wrote: OMAP34xx and OMAP36xx processors contain a register in the syscon area, which can be used to determine the SoCs temperature.

Re: [PATCH] hwmon: (gpio-fan) Add a shutdown handler to poweroff the fans

2014-12-04 Thread Guenter Roeck
On Thu, Dec 04, 2014 at 10:58:56AM -0600, Nishanth Menon wrote: Poweroff the fans when shutting down the system. Else, echo '1' /sys/class/hwmon/hwmon0/fan1_target; poweroff leaves the fan running if the System power off does not drive the gpio expander which might control the fan power

Re: [PATCH] hwmon: (gpio-fan) Allow usage of gpio operations that may sleep

2014-12-04 Thread Guenter Roeck
On Thu, Dec 04, 2014 at 10:58:47AM -0600, Nishanth Menon wrote: Certain I2C based GPIO expanders could be used in sleepable context, this results in: [ 115.890569] [ cut here ] [ 115.895422] WARNING: CPU: 0 PID: 1115 at drivers/gpio/gpiolib.c:1370

Re: [PATCH] hwmon: (gpio-fan) Allow usage of gpio operations that may sleep

2014-12-04 Thread Guenter Roeck
On Thu, Dec 04, 2014 at 01:46:15PM -0600, Nishanth Menon wrote: On 11:05-20141204, Guenter Roeck wrote: On Thu, Dec 04, 2014 at 10:58:47AM -0600, Nishanth Menon wrote: Certain I2C based GPIO expanders could be used in sleepable context, this results in: [ 115.890569] [ cut

Re: [PATCH v5 18/48] mfd: twl4030-power: Register with kernel power-off handler

2014-11-10 Thread Guenter Roeck
On 11/10/2014 12:46 AM, Pavel Machek wrote: Hi! @@ -611,7 +611,7 @@ twl4030_power_configure_resources(const struct twl4030_power_data *pdata) * After a successful execution, TWL shuts down the power to the SoC * and all peripherals connected to it. */ -void twl4030_power_off(void)

Re: [PATCH v5 18/48] mfd: twl4030-power: Register with kernel power-off handler

2014-11-10 Thread Guenter Roeck
On 11/10/2014 06:09 AM, Guenter Roeck wrote: On 11/10/2014 12:46 AM, Pavel Machek wrote: Hi! @@ -611,7 +611,7 @@ twl4030_power_configure_resources(const struct twl4030_power_data *pdata) * After a successful execution, TWL shuts down the power to the SoC * and all peripherals connected

[PATCH v6 09/48] mfd: palmas: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v6: - This patch: No change. Global: Replaced priority defines with enum. v5: - Rebase to v3.18-rc3 v4: - Do not use notifiers but internal functions and data structures to manage the list of power-off

[PATCH v6 18/48] mfd: twl4030-power: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
as it is no longer needed. Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Cc: linux-omap@vger.kernel.org Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v6: - This patch: No change. Global: Replaced priority defines with enum

[PATCH v6 14/48] mfd: tps80031: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v6: - This patch: No change. Global: Replaced priority defines with enum. v5: - Rebase to v3.18-rc3 v4: - Do not use notifiers but internal functions and data structures to manage the list of power-off

[PATCH v6 35/48] arm: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
the fallback priority to indicate that the power-off handler is one of last resort. If the power-off handler powers off the system, select the default priority. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Guenter Roeck li...@roeck-us.net --- v6: - This patch: No change. Global: Replaced

[PATCH v6 17/48] mfd: tps65910: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v6: - This patch: No change. Global: Replaced priority defines with enum. v5: - Rebase to v3.18-rc3 v4: - Do not use notifiers but internal functions and data structures to manage the list of power-off

[PATCH v6 16/48] mfd: tps6586x: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v6: - This patch: No change. Global: Replaced priority defines with enum. v5: - Rebase to v3.18-rc3 v4: - Do not use notifiers but internal functions and data structures to manage the list of power-off

[PATCH v5 09/48] mfd: palmas: Register with kernel power-off handler

2014-11-06 Thread Guenter Roeck
Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v5: - Rebase to v3.18-rc3 v4: - Do not use notifiers but internal functions and data structures to manage the list of power-off handlers. Drop unused parameters from callbacks, and make the power-off

[PATCH v5 35/48] arm: Register with kernel power-off handler

2014-11-06 Thread Guenter Roeck
the fallback priority to indicate that the power-off handler is one of last resort. If the power-off handler powers off the system, select the default priority. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Guenter Roeck li...@roeck-us.net --- v5: - Rebase to v3.18-rc3 v4: - No change v3

[PATCH v5 18/48] mfd: twl4030-power: Register with kernel power-off handler

2014-11-06 Thread Guenter Roeck
as it is no longer needed. Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Cc: linux-omap@vger.kernel.org Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v5: - Rebase to v3.18-rc3 v4: - Do not use notifiers but internal functions

[PATCH v5 14/48] mfd: tps80031: Register with kernel power-off handler

2014-11-06 Thread Guenter Roeck
Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v5: - Rebase to v3.18-rc3 v4: - Do not use notifiers but internal functions and data structures to manage the list of power-off handlers. Drop unused parameters from callbacks, and make the power-off

[PATCH v5 17/48] mfd: tps65910: Register with kernel power-off handler

2014-11-06 Thread Guenter Roeck
Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v5: - Rebase to v3.18-rc3 v4: - Do not use notifiers but internal functions and data structures to manage the list of power-off handlers. Drop unused parameters from callbacks, and make the power-off

[PATCH v5 16/48] mfd: tps6586x: Register with kernel power-off handler

2014-11-06 Thread Guenter Roeck
Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- v5: - Rebase to v3.18-rc3 v4: - Do not use notifiers but internal functions and data structures to manage the list of power-off handlers. Drop unused parameters from callbacks, and make the power-off

Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's

2014-11-03 Thread Guenter Roeck
On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: From: George Cherian george.cher...@ti.com Convert the driver to use gpiod_* API's. Reviewed-by: Roger Quadros rog...@ti.com Signed-off-by: George Cherian george.cher...@ti.com Signed-off-by: Sekhar Nori nsek...@ti.com

Re: [PATCH v3 00/47] kernel: Add support for power-off handler call chain

2014-11-03 Thread Guenter Roeck
On Mon, Nov 03, 2014 at 11:59:35AM -0600, Felipe Balbi wrote: Hi, On Mon, Oct 27, 2014 at 08:55:07AM -0700, Guenter Roeck wrote: Various drivers implement architecture and/or device specific means to remove power from the system. For the most part, those drivers set the global variable

Re: [PATCH v3 09/47] mfd: palmas: Register with kernel power-off handler

2014-11-03 Thread Guenter Roeck
On Mon, Nov 03, 2014 at 11:59:54AM -0600, Felipe Balbi wrote: On Mon, Nov 03, 2014 at 05:56:45PM +, Lee Jones wrote: On Mon, 27 Oct 2014, Guenter Roeck wrote: Register with kernel power-off handler instead of setting pm_power_off directly. Register with low priority to reflect

Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's

2014-11-03 Thread Guenter Roeck
On Mon, Nov 03, 2014 at 12:06:02PM -0600, Felipe Balbi wrote: On Mon, Nov 03, 2014 at 10:01:50AM -0800, Guenter Roeck wrote: On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: From: George Cherian george.cher...@ti.com Convert the driver to use gpiod_* API's

Re: [PATCH v3 09/47] mfd: palmas: Register with kernel power-off handler

2014-11-03 Thread Guenter Roeck
On Mon, Nov 03, 2014 at 12:43:12PM -0600, Felipe Balbi wrote: On Mon, Nov 03, 2014 at 10:36:53AM -0800, Guenter Roeck wrote: On Mon, Nov 03, 2014 at 11:59:54AM -0600, Felipe Balbi wrote: On Mon, Nov 03, 2014 at 05:56:45PM +, Lee Jones wrote: On Mon, 27 Oct 2014, Guenter Roeck wrote

Re: [PATCH v3 00/47] kernel: Add support for power-off handler call chain

2014-11-03 Thread Guenter Roeck
On Mon, Nov 03, 2014 at 12:28:29PM -0600, Felipe Balbi wrote: Hi, On Mon, Nov 03, 2014 at 10:22:13AM -0800, Guenter Roeck wrote: On Mon, Nov 03, 2014 at 11:59:35AM -0600, Felipe Balbi wrote: Hi, On Mon, Oct 27, 2014 at 08:55:07AM -0700, Guenter Roeck wrote: Various drivers

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Guenter Roeck
On 10/29/2014 05:34 AM, Johan Hovold wrote: On Tue, Oct 28, 2014 at 03:16:10PM +, Russell King - ARM Linux wrote: On Tue, Oct 28, 2014 at 02:12:57PM +0100, Johan Hovold wrote: That's not what I was trying to refer to. But the patch set explicitly allows for multiple, prioritised power-off

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Guenter Roeck
On Wed, Oct 29, 2014 at 02:22:44PM +0100, Johan Hovold wrote: On Wed, Oct 29, 2014 at 01:10:20PM +, Russell King - ARM Linux wrote: On Wed, Oct 29, 2014 at 01:34:18PM +0100, Johan Hovold wrote: On Tue, Oct 28, 2014 at 03:16:10PM +, Russell King - ARM Linux wrote: And how is that

Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature

2014-10-29 Thread Guenter Roeck
On Wed, Oct 29, 2014 at 02:35:26PM +0100, Johan Hovold wrote: On Wed, Oct 29, 2014 at 06:20:40AM -0700, Guenter Roeck wrote: On 10/29/2014 05:34 AM, Johan Hovold wrote: On Tue, Oct 28, 2014 at 03:16:10PM +, Russell King - ARM Linux wrote: On Tue, Oct 28, 2014 at 02:12:57PM +0100

[PATCH v3 35/47] arm: Register with kernel power-off handler

2014-10-27 Thread Guenter Roeck
the fallback priority to indicate that the power-off handler is one of last resort. If the power-off handler powers off the system, select the default priority. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Guenter Roeck li...@roeck-us.net --- v3: - Replace poweroff in all newly introduced

[PATCH v2 35/47] arm: Register with kernel poweroff handler

2014-10-20 Thread Guenter Roeck
the fallback priority to indicate that the poweroff handler is one of last resort. If the poweroff handler powers off the system, select the default priority. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Guenter Roeck li...@roeck-us.net --- - Use defines to specify poweroff handler priorities

Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit

2014-10-14 Thread Guenter Roeck
On Tue, Oct 14, 2014 at 12:25:19PM -0700, Tony Lindgren wrote: This allows testing the watchdog easily with distros just by doing pkill -9 watchdog. Reported-by: Thomas Dziedzic gos...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com Good catch. Reviewed-by: Guenter Roeck li

Re: [RFC 02/23] watchdog: omap_wdt: raw read and write endian fix

2013-11-15 Thread Guenter Roeck
...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org Acked-by: Guenter Roeck li...@roeck-us.net -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH] arm: Select NOP_USB_XCEIV if MACH_OMAP3EVM is enabled

2013-10-02 Thread Guenter Roeck
usb_nop_xceiv_register(), which is built with NOP_USB_XCEIV, which in turn can be configured as module. This results in the observed build failure. Fix the problem once and for all by selecting NOP_USB_XCEIV if MACH_OMAP3EVM is enabled. Signed-off-by: Guenter Roeck li...@roeck-us.net --- arch/arm/mach-omap2

Re: Build error in torvalds kernel 3.11 for omap2plus

2013-09-09 Thread Guenter Roeck
On 09/09/2013 03:55 AM, Anil Kumar wrote: Hi Guenter, On Sun, Sep 8, 2013 at 10:46 PM, Guenter Roeck li...@roeck-us.net wrote: On 09/08/2013 02:02 AM, Russell King - ARM Linux wrote: On Sun, Sep 08, 2013 at 11:34:10AM +0530, Anil Kumar wrote: scripts/kconfig/conf --silentoldconfig Kconfig

Re: Build error in torvalds kernel 3.11 for omap2plus

2013-09-09 Thread Guenter Roeck
On 09/09/2013 03:51 AM, Russell King - ARM Linux wrote: On Sun, Sep 08, 2013 at 10:16:14AM -0700, Guenter Roeck wrote: Since we are at it: Build reference: v3.11-7887-gb409624 Building arm:defconfig ... passed Building arm:allmodconfig ... failed -- Error log: arch/arm/mach

Re: Build error in torvalds kernel 3.11 for omap2plus

2013-09-09 Thread Guenter Roeck
On Mon, Sep 09, 2013 at 10:24:42AM -0400, Nicolas Pitre wrote: On Mon, 9 Sep 2013, Guenter Roeck wrote: On 09/09/2013 03:51 AM, Russell King - ARM Linux wrote: On Sun, Sep 08, 2013 at 10:16:14AM -0700, Guenter Roeck wrote: Since we are at it: Build reference: v3.11-7887

Re: Build error in torvalds kernel 3.11 for omap2plus

2013-09-09 Thread Guenter Roeck
On Mon, Sep 09, 2013 at 09:31:41PM +0100, Russell King - ARM Linux wrote: On Mon, Sep 09, 2013 at 09:03:48AM -0700, Guenter Roeck wrote: Unfortunately, there are more problems. arch/arm/kernel/built-in.o: In function `ret_fast_syscall': /home/groeck/src/linux-stable/arch/arm/kernel/entry

Re: Build error in torvalds kernel 3.11 for omap2plus

2013-09-08 Thread Guenter Roeck
On 09/08/2013 02:02 AM, Russell King - ARM Linux wrote: On Sun, Sep 08, 2013 at 11:34:10AM +0530, Anil Kumar wrote: scripts/kconfig/conf --silentoldconfig Kconfig CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h make[1]:

[PATCH] arm/omap2: Fix build failures

2013-02-28 Thread Guenter Roeck
-emac.c:66:6: error: too many arguments to function 'omap_device_build' arch/arm/mach-omap2/omap_device.h:74:25: note: declared here Signed-off-by: Guenter Roeck li...@roeck-us.net --- arch/arm/mach-omap2/am35xx-emac.c |3 +-- arch/arm/mach-omap2/devices.c |2 +- arch/arm/mach-omap2

Re: [PATCH] Documentation: dt: hwmon: Update for tmp102

2012-08-14 Thread Guenter Roeck
On Tue, Aug 14, 2012 at 09:53:32PM +0530, Sourav Poddar wrote: Add Documentation for tmp102 temperature sensor. Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: Sourav Poddar sourav.pod...@ti.com ---

Re: [PATCH] hwmon: OMAP4460+: On die temperature sensor driver

2011-09-22 Thread Guenter Roeck
Cc: Jean Delvare kh...@linux-fr.org Cc: Guenter Roeck guenter.ro...@ericsson.com Cc: lm-sens...@lm-sensors.org --- Documentation/hwmon/omap_temp_sensor | 25 +++ drivers/hwmon/Kconfig| 11 ++ drivers/hwmon/Makefile |1 + drivers/hwmon

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-09-06 Thread Guenter Roeck
On Tue, 2011-09-06 at 14:02 -0400, J, KEERTHY wrote: On Thu, Sep 1, 2011 at 10:10 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Sep 01, 2011 at 12:09:14AM -0400, Paul Walmsley wrote: On Wed, 31 Aug 2011, Guenter Roeck wrote: On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Guenter Roeck
On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote: Hi Some comments. On Wed, 31 Aug 2011, Keerthy wrote: [ ... ] +} + +/* Sysfs hook functions */ These should be conditionally compiled out if sysfs isn't compiled in. The whole point of the hwmon subsystem is to

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Guenter Roeck
is allowed to configure the temperature thresholds vis sysfs nodes exposed using hwmon interface. Signed-off-by: Keerthy j-keer...@ti.com Cc: Jean Delvare kh...@linux-fr.org Cc: Guenter Roeck guenter.ro...@ericsson.com Cc: lm-sens...@lm-sensors.org --- Documentation/hwmon/omap_temp_sensor

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Guenter Roeck
On Thu, Sep 01, 2011 at 12:09:14AM -0400, Paul Walmsley wrote: On Wed, 31 Aug 2011, Guenter Roeck wrote: On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote: Hi Some comments. On Wed, 31 Aug 2011, Keerthy wrote: [ ... ] +} + +/* Sysfs hook

Re: [lm-sensors] [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-26 Thread Guenter Roeck
On Fri, 2011-08-26 at 07:17 -0400, J, KEERTHY wrote: On Thu, Aug 25, 2011 at 9:26 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, 2011-08-25 at 10:06 -0400, Guenter Roeck wrote: On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: On Wed, Aug 24, 2011 at 10:46 PM

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, 2011-08-25 at 03:24 -0400, Todd Poynor wrote: On Wed, Aug 24, 2011 at 08:07:12PM +0530, Keerthy wrote: ... + temp_sensor-phy_base = ioremap(mem-start, resource_size(mem)); Check NULL return. temp_sensor-phy_base is never iounmapped in error paths or _remove function. ...

Re: [lm-sensors] [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, 2011-08-25 at 10:06 -0400, Guenter Roeck wrote: On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy wrote: On chip temperature sensor

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, 2011-08-25 at 12:04 -0400, J, KEERTHY wrote: On Thu, Aug 25, 2011 at 7:36 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Wed, Aug

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, 2011-08-25 at 12:39 -0400, J, KEERTHY wrote: On Thu, Aug 25, 2011 at 9:49 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, 2011-08-25 at 12:04 -0400, J, KEERTHY wrote: On Thu, Aug 25, 2011 at 7:36 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Aug 25

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-24 Thread Guenter Roeck
is allowed to configure the temperature thresholds vis sysfs nodes exposed using hwmon interface. Signed-off-by: Keerthy j-keer...@ti.com Cc: Jean Delvare kh...@linux-fr.org Cc: Guenter Roeck guenter.ro...@ericsson.com Cc: lm-sens...@lm-sensors.org Partial review only. Too many concerns

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-19 Thread Guenter Roeck
On Fri, Aug 19, 2011 at 02:04:58AM -0400, J, KEERTHY wrote: On Fri, Aug 19, 2011 at 7:43 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Aug 18, 2011 at 06:52:15AM -0400, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-19 Thread Guenter Roeck
On Fri, Aug 19, 2011 at 09:01:53AM -0400, J, KEERTHY wrote: On Fri, Aug 19, 2011 at 11:47 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Fri, Aug 19, 2011 at 02:04:58AM -0400, J, KEERTHY wrote: On Fri, Aug 19, 2011 at 7:43 AM, Guenter Roeck guenter.ro...@ericsson.com wrote

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-18 Thread Guenter Roeck
is allowed to configure the temperature thresholds vis sysfs nodes exposed using hwmon interface. Signed-off-by: Keerthy j-keer...@ti.com Cc: Jean Delvare kh...@linux-fr.org Cc: Guenter Roeck guenter.ro...@ericsson.com Cc: lm-sens...@lm-sensors.org High level review: - too much and too

Re: [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver

2011-08-17 Thread Guenter Roeck
On Wed, Aug 17, 2011 at 06:37:10AM -0400, J, KEERTHY wrote: [ ... ] Hi Guenter, Any inputs on the driver? Hi Keerthy. I think there was so much feedback that I would just add noise at this time, and stumble over the same issues. I'll look into it after the feedback has been applied.

Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver

2011-08-11 Thread Guenter Roeck
On Thu, 2011-08-11 at 09:00 -0400, J, KEERTHY wrote: On Thu, Aug 11, 2011 at 4:06 PM, Felipe Balbi ba...@ti.com wrote: [ ... ] + temp = omap_temp_sensor_readl(temp_sensor, + temp_sensor-registers-bgap_counter); + temp = (temp

Re: [lm-sensors] Query: Omap temperature sensor driver design

2011-04-01 Thread Guenter Roeck
On Fri, Apr 01, 2011 at 08:39:43AM -0400, J, KEERTHY wrote: Hello All, I am trying to implement a driver for the OMAP temperature sensor. It is an on chip sensor. The sensor is responsible for reporting the temperature. The sensor has configurable thresholds. The user can configure the

Re: [PATCH 2/2 v5] hwmon: twl4030: Hwmon Driver for TWL4030 MADC

2011-03-01 Thread Guenter Roeck
is represented by celcius and mA respectively. Signed-off-by: Keerthy j-keer...@ti.com Acked-by: Guenter Roeck guenter.ro...@ericsson.com Thanks, Guenter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/2 v3] hwmon: twl4030: Hwmon Driver for TWL4030 MADC

2011-02-28 Thread Guenter Roeck
Hi, On Mon, Feb 28, 2011 at 01:05:41AM -0500, Keerthy wrote: This driver exposes the sysfs nodes of the TWL4030 MADC module. All the voltage channel values are expressed in terms of mV. Channel 13 and channel 14 are reserved. There are channels which represent temperature and current the

Re: [PATCH 2/2 v4] mfd: twl4030: Driver for twl4030 madc module

2011-02-28 Thread Guenter Roeck
On Mon, Feb 28, 2011 at 04:48:12AM -0500, Keerthy wrote: Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring ADC. This driver monitors the real time conversion of analog signals like battery temperature, battery cuurent etc. Signed-off-by: Keerthy j-keer...@ti.com

Re: [PATCH 2/2 v2] hwmon: twl4030: Hwmon Driver for TWL4030 MADC

2011-02-27 Thread Guenter Roeck
On Sun, Feb 27, 2011 at 08:03:07PM -0500, Samuel Ortiz wrote: Hi Keerthy, On Thu, Feb 24, 2011 at 08:48:50PM +0530, Keerthy wrote: This driver exposes the sysfs nodes of the TWL4030 MADC module. All the voltage channel values are expressed in terms of mV. Channel 13 and channel 14 are

Re: [PATCH 2/2] hwmon: twl4030: Hwmon Driver for TWL4030 MADC

2011-02-16 Thread Guenter Roeck
On Wed, Feb 16, 2011 at 07:56:57AM -0500, Keerthy wrote: This driver exposes the sysfs nodes of the TWL4030 MADC module. All the channel values are expressed in terms of mV. Channel 13 and channel 14 are reserved. There are channels which represent temperature and current. Even they output raw

Re: [PATCH 2/2] hwmon: twl4030: Hwmon Driver for TWL4030 MADC

2011-02-16 Thread Guenter Roeck
On Wed, Feb 16, 2011 at 12:59:52PM -0500, J, KEERTHY wrote: Hello Guenter, On Wed, Feb 16, 2011 at 9:39 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Wed, Feb 16, 2011 at 07:56:57AM -0500, Keerthy wrote: This driver exposes the sysfs nodes of the TWL4030 MADC module. All

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-07 Thread Guenter Roeck
On Fri, Jan 07, 2011 at 07:12:13AM -0500, J, KEERTHY wrote: On Fri, Jan 7, 2011 at 3:25 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, 2011-01-06 at 15:21 -0500, Mark Brown wrote: On Thu, Jan 06, 2011 at 07:04:30AM -0800, Guenter Roeck wrote: On Thu, Jan 06, 2011 at 07:07

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-06 Thread Guenter Roeck
On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Brown wrote: On Wed, Jan 05, 2011 at 09:33:28PM -0800, Guenter Roeck wrote: [...] +EXPORT_SYMBOL_GPL(twl4030_madc_conversion); [...] +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion); No symbol export from hwmon drivers. Other parts

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-06 Thread Guenter Roeck
On Thu, 2011-01-06 at 15:21 -0500, Mark Brown wrote: On Thu, Jan 06, 2011 at 07:04:30AM -0800, Guenter Roeck wrote: On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Brown wrote: Why? It's not like hwmon has an unreasonably large core or similar. Because it creates an unnecessary

Re: [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-05 Thread Guenter Roeck
On Wed, Jan 05, 2011 at 11:17:37PM -0500, Keerthy wrote: Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring ADC. This driver monitors the real time conversion of analog signals like battery temperature, battery type, battery level etc. User can also ask for the

Re: [PATCH V2] hwmon: twl4030: Driver for twl4030 madc module

2010-11-10 Thread Guenter Roeck
On Tue, Nov 09, 2010 at 04:20:57AM -0500, Keerthy wrote: Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring ADC. This driver monitors the real time conversion of analog signals like battery temperature, battery type, battery level etc. User can also ask for the

Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-20 Thread Guenter Roeck
Hi, On Mon, Sep 20, 2010 at 06:34:24AM -0400, J, KEERTHY wrote: -Original Message- From: Guenter Roeck [mailto:guenter.ro...@ericsson.com] Sent: Thursday, September 16, 2010 8:48 PM To: J, KEERTHY Cc: linux-omap@vger.kernel.org; lm-sens...@lm-sensors.org; Krishnamoorthy

Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-20 Thread Guenter Roeck
On Mon, Sep 20, 2010 at 10:09:05AM -0400, Guenter Roeck wrote: Hi, On Mon, Sep 20, 2010 at 06:34:24AM -0400, J, KEERTHY wrote: -Original Message- From: Guenter Roeck [mailto:guenter.ro...@ericsson.com] Sent: Thursday, September 16, 2010 8:48 PM To: J, KEERTHY Cc

Re: [lm-sensors] [PATCH 2/2] Makefile and Kconfig changes for twl4030-madc driver

2010-09-16 Thread Guenter Roeck
On Thu, Sep 16, 2010 at 06:23:32AM -0400, Keerthy wrote: Makefile amd Kconfig Changes for twl4030-madc driver inclusion. Signed-off-by: Keerthy j-keer...@ti.com --- arch/arm/mach-omap2/Kconfig |4 drivers/hwmon/Kconfig |4 drivers/hwmon/Makefile |1 + 3

Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-16 Thread Guenter Roeck
On Thu, Sep 16, 2010 at 06:23:24AM -0400, Keerthy wrote: MADC driver is added under hwmon drivers. This driver monitors the real time conversion of analog signals like battery temperature, battery type, battery level etc. User can also ask for the conversion on a particular channel using the