Re: [PATCH] rtc-twl: Switch to using threaded irq

2011-05-18 Thread Ilkka Koskinen
would be the appropriate path for this patch? I'd probably push it through omap maintainer path, as its hardware specific and can be better tested there. thanks -john On Apr 13, 2011 Krishnamoorthy, Balaji T wrote: On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen ilkka.koski

[PATCH 1/2] omap: Remove unnecessary twl4030_codec_audio settings from board files

2011-03-02 Thread Ilkka Koskinen
twl4030_codec_audio and twl4030_codec_vibra_data has unused field. In order to remove it, corresponding settings needs to be removed from board files. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- arch/arm/mach-omap2/board-3430sdp.c |4 +--- arch/arm/mach-omap2/board

[PATCH 2/2] mfd: twl4030_codec: Remove unused and duplicate audio_mclk fields

2011-03-02 Thread Ilkka Koskinen
audio_mclk can be queried from mfd driver. Therefore, it is not needed in twl4030_codec_audio_data or in twl4030_codec_vibra_data anymore. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- include/linux/i2c/twl.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git

[PATCH 0/2] twl4030_codec cleanup

2011-03-02 Thread Ilkka Koskinen
This series of patches removes duplicate audio_mclk fields from twl4030_codec driver. The patches have been compiled on sound-2.6/for-2.6.39 branch. I haven't tested them on any target board though. Ilkka Koskinen (2): omap: Remove unnecessary twl4030_codec_audio settings from board files

[PATCH] omap: rx51: Add support for vibra

2011-02-25 Thread Ilkka Koskinen
Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- arch/arm/mach-omap2/board-rx51-peripherals.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index e75e240

[PATCH] spi/omap2_mcspi: Verify TX reg is empty after TX only xfer with DMA

2010-10-19 Thread Ilkka Koskinen
-by: Ilkka Koskinen ilkka.koski...@nokia.com Tested-by: Tuomas Katila ext-tuomas.2.kat...@nokia.com --- drivers/spi/omap2_mcspi.c | 39 ++- 1 files changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c index

[PATCH] mfd: twl5031: Rename sih modules

2010-05-20 Thread Ilkka Koskinen
Fix the names of twl5031 specific sih modules to match the documentation. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- drivers/mfd/twl4030-irq.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c

[PATCHv5 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-22 Thread Ilkka Koskinen
Add ASoC interface for OMAP McBSP2 and McBSP3 sidetones. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- sound/soc/omap/omap-mcbsp.c | 138 +++ sound/soc/omap/omap-mcbsp.h |2 + 2 files changed, 140 insertions(+), 0 deletions(-) diff --git

[PATCHv5 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-22 Thread Ilkka Koskinen
From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 60 + arch/arm

[PATCHv5 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-22 Thread Ilkka Koskinen
Ilkka Koskinen (1): ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 60 + arch/arm/plat-omap/mcbsp.c | 402 ++- sound/soc/omap/omap-mcbsp.c

Re: [PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-19 Thread Ilkka Koskinen
On Thu, 18 Feb 2010, ext Jarkko Nikula wrote: On Thu, 18 Feb 2010 20:42:27 +0200 Ilkka Koskinen ilkka.koski...@nokia.com wrote: The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo

RE: [PATCHv4 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-19 Thread Ilkka Koskinen
On Fri, 19 Feb 2010, Nurkkala Eero.An (EXT-Offcode/Oulu) wrote: + +static const struct snd_kcontrol_new omap_mcbsp2_st_controls[] = { + SOC_SINGLE_EXT(McBSP2 Sidetone Switch, 1, 0, 1, 0, + omap_mcbsp_st_get_mode, omap_mcbsp_st_put_mode), +

Re: [PATCHv2 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
Hi, On Thu, 18 Feb 2010, ext Tony Lindgren wrote: * Ilkka Koskinen ilkka.koski...@nokia.com [100217 06:41]: From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com

[PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
by Peter Ujfalusi. Eero Nurkkala (1): McBSP: OMAP3: Add sidetone feature Ilkka Koskinen (1): ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 63 + arch/arm/plat-omap/mcbsp.c

[PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Ilkka Koskinen
Add ASoC interface for OMAP McBSP2 and McBSP3 sidetones. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- sound/soc/omap/omap-mcbsp.c | 157 +++ sound/soc/omap/omap-mcbsp.h |2 + 2 files changed, 159 insertions(+), 0 deletions(-) diff --git

[PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap

Re: [alsa-devel] [PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Ilkka Koskinen
On Thu, 18 Feb 2010, Ujfalusi Peter (Nokia-D/Tampere) wrote: On Thursday 18 February 2010 14:37:15 Koskinen Ilkka (Nokia-D/Tampere) wrote: ... +static int omap_mcbsp_set_st_channel_vol(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol,

[PATCHv4 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 60 + arch/arm

[PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
a comment to ASoC part explaining McBSP port number vs. index values used in OMAP McBSP implementation. Eero Nurkkala (1): McBSP: OMAP3: Add sidetone feature Ilkka Koskinen (1): ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat

[PATCHv4 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Ilkka Koskinen
Add ASoC interface for OMAP McBSP2 and McBSP3 sidetones. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- sound/soc/omap/omap-mcbsp.c | 138 +++ sound/soc/omap/omap-mcbsp.h |2 + 2 files changed, 140 insertions(+), 0 deletions(-) diff --git

[PATCHv2 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-17 Thread Ilkka Koskinen
From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 63 + arch/arm

Re: [PATCH 0/2] McBSP: OMAP3: Add sidetone feature

2010-01-29 Thread Ilkka Koskinen
Hi, On Thu, 28 Jan 2010, ext Jarkko Nikula wrote: On Thu, 28 Jan 2010 17:46:25 +0200 Ilkka Koskinen ilkka.koski...@nokia.com wrote: The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch

[PATCH 0/2] McBSP: OMAP3: Add sidetone feature

2010-01-28 Thread Ilkka Koskinen
interface as suggested in comments. Eero Nurkkala (1): McBSP: OMAP3: Add sidetone feature Ilkka Koskinen (1): ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 63 + arch/arm/plat-omap/mcbsp.c

[PATCH 1/2] McBSP: OMAP3: Add sidetone feature

2010-01-28 Thread Ilkka Koskinen
From: Eero Nurkkala ext-eero.nurkk...@nokia.com Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 63 + arch/arm

[PATCH 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-01-28 Thread Ilkka Koskinen
Add ASoC interface for OMAP McBSP2 and McBSP3 sidetones. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- sound/soc/omap/omap-mcbsp.c | 187 +++ sound/soc/omap/omap-mcbsp.h |2 + 2 files changed, 189 insertions(+), 0 deletions(-) diff --git

[PATCH v3] mfd: Initial support for twl5031

2009-11-10 Thread Ilkka Koskinen
TWL5031 introduces two new interrupts in PIH. Moreover, BCI has changed remarkably and, thus, it's disabled when TWL5031 is in use. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- drivers/mfd/twl4030-core.c | 13 - drivers/mfd/twl4030-irq.c | 131

Re: [PATCH v2] TWL4030: Initial support for TWL5031

2009-11-03 Thread Ilkka Koskinen
Hi Samuel, On Fri, 16 Oct 2009, Koskinen Ilkka (Nokia-D/Tampere) wrote: TWL5031 introduces two new interrupts in PIH. Moreover, BCI has changed remarkably and, thus, it's disabled when TWL5031 is in use. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- drivers/mfd/twl4030-core.c

Re: [Resend PATCH 2/2] twl4030: Enable low-power mode to 32kHz oscillator

2009-10-22 Thread Ilkka Koskinen
Hi Samuel, On Thu, 22 Oct 2009, ext Samuel Ortiz wrote: On Tue, Oct 20, 2009 at 04:22:53PM +0300, Ilkka Koskinen wrote: +struct twl4030_clock_init_data { + int ck32k_lowpwr_enable; I guess you could use a bool here ? Good point. I'll change it. Cheers, Ilkka +}; + struct

[PATCH v2] twl4030: Enable low-power mode to 32kHz oscillator

2009-10-22 Thread Ilkka Koskinen
Allows TWL's 32kHz oscillator to go in low-power mode when main battery voltage is running low. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- drivers/mfd/twl4030-core.c |9 +++-- include/linux/i2c/twl4030.h |5 + 2 files changed, 12 insertions(+), 2 deletions

[PATCH 1/2] twl4030: Do not dereference null pointer in error path

2009-09-30 Thread Ilkka Koskinen
Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- drivers/mfd/twl4030-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c index e424cf6..8cf0a02 100644 --- a/drivers/mfd/twl4030-core.c +++ b/drivers/mfd

[PATCH 2/2] twl4030: Enable low-power mode to 32KHz oscillator

2009-09-30 Thread Ilkka Koskinen
Allows TWL's 32KHz oscillator to go in low-power mode when main battery voltage is running low. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- drivers/mfd/twl4030-core.c |9 +++-- include/linux/i2c/twl4030.h |5 + 2 files changed, 12 insertions(+), 2 deletions