[PATCH v2 1/2] OMAP: DSS2: omap_dss_probe() conditional compilation cleanup

From: Jani Nikula ext-jani.1.nik...@nokia.com Move a number of #ifdefs from code into dss.h and elsewhere, and conditionally define no-op static inline functions, cleaning up the code. This style is according to Documentation/SubmittingPatches. Signed-off-by: Jani Nikula ext-jani.1.nik

[PATCH v2 2/2] OMAP: DSS2: Fix omap_dss_probe() error path

From: Jani Nikula ext-jani.1.nik...@nokia.com Perform graceful cleanup on errors instead of just bailing out. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/dss/core.c | 54 ++- 1 files changed, 41 insertions(+), 13 deletions

[PATCH v2 0/2] OMAP: DSS2: Fix DSS core init fail path

Hi - These patches fix the broken DSS omap_dss_probe() fail path, reported by Kevin Hilman [1]. v2: - rebased against [2] [1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27112.html [2] git://gitorious.org/linux-omap-dss2/linux.git BR, Jani. Jani Nikula (2): OMAP: DSS2

Re: [PATCH 2/2] OMAP: DSS2: Fix omap_dss_probe() error path

On Thu, 6 May 2010, ext Kevin Hilman wrote: Tested on my n900, and with failed init, clocks are turned off and doesn't prevent suspend. Many thanks for testing this, Kevin! BR, Jani. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to

[PATCH 0/2] OMAP: DSS2: Fix DSS core init fail path

Hi - These patches fix the broken DSS omap_dss_probe() fail path, reported by Kevin Hilman [1]. Kevin, could you please check this with your setup too? It would be much appreciated. [1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27112.html BR, Jani. Jani Nikula (2): OMAP

[PATCH 1/2] OMAP: DSS2: omap_dss_probe() conditional compilation cleanup

From: Jani Nikula ext-jani.1.nik...@nokia.com Move a number of #ifdefs from code into dss.h and elsewhere, and conditionally define no-op static inline functions, cleaning up the code. This style is according to Documentation/SubmittingPatches. Signed-off-by: Jani Nikula ext-jani.1.nik

[PATCH 2/2] OMAP: DSS2: Fix omap_dss_probe() error path

From: Jani Nikula ext-jani.1.nik...@nokia.com Perform graceful cleanup on errors instead of just bailing out. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/dss/core.c | 54 ++- 1 files changed, 41 insertions(+), 13 deletions

[PATCH v3 03/21] OMAP: DSS2: Taal: Add locks to protect taal data access

From: Jani Nikula ext-jani.1.nik...@nokia.com Avoid potential race conditions in sysfs access to taal data. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git

[PATCH v3 02/21] OMAP: DSS2: Taal: add locks to taal_bl_update_status

From: Valkeinen Tomi (Nokia-D/Helsinki) tomi.valkei...@nokia.com From: Tomi Valkeinen tomi.valkei...@nokia.com taal_bl_update_status was missing locks to protect taal_data. This caused a kernel crash randomly, as the code attempted to set the brightness while the OMAP's DSI block was actually

[PATCH v3 00/21] OMAP: DSS2: Taal panel driver updates

missing commit messages (thanks Tony for your feedback!) [1] git://gitorious.org/linux-omap-dss2/linux.git BR, Jani. Jani Nikula (20): OMAP: DSS2: Taal: Add panel hardware reset OMAP: DSS2: Taal: Add locks to protect taal data access OMAP: DSS2: Taal: Cosmetic improvement to backlight

[PATCH v3 01/21] OMAP: DSS2: Taal: Add panel hardware reset

From: Jani Nikula ext-jani.1.nik...@nokia.com Issue a proper reset pulse on the reset line instead of just doing power on/off. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 44 ++-- 1 files changed, 40 insertions

[PATCH v3 09/21] OMAP: DSS2: Taal: Ensure panel is enabled in enable_te() and run_test()

From: Jani Nikula ext-jani.1.nik...@nokia.com Bail out from taal_enable_te() and taal_run_test() if panel is not enabled. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 31 +--- 1 files changed, 23 insertions

[PATCH v3 04/21] OMAP: DSS2: Taal: Cosmetic improvement to backlight properties initialization

From: Jani Nikula ext-jani.1.nik...@nokia.com Let the compiler worry about the type for us. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/omap2/displays

[PATCH v3 12/21] OMAP: DSS2: Taal: Change ESD work management

From: Jani Nikula ext-jani.1.nik...@nokia.com Move ESD work queuing and cancelling out of taal_power_on/off() to avoid problems related to taal_esd_work() calling the power on/off functions. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c

[PATCH v3 13/21] OMAP: DSS2: Taal: Change probe error handling labels

From: Jani Nikula ext-jani.1.nik...@nokia.com Switch from numbered to named labels to make it easier to add new labels for error handling. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 24 1 files changed, 12

[PATCH v3 06/21] OMAP: DSS2: Taal: Fix request_irq() error handling

From: Jani Nikula ext-jani.1.nik...@nokia.com Separate gpio_request() and request_irq() error handling. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v3 05/21] OMAP: DSS2: Taal: Remove platform enable/disable

From: Jani Nikula ext-jani.1.nik...@nokia.com After the addition of proper hardware reset, taal_hw_reset(), there's no need for an additional platform enable/disable. Remove them. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 11

[PATCH v3 17/21] OMAP: DSS2: Taal: Configure ESD check in DSI panel data

From: Jani Nikula ext-jani.1.nik...@nokia.com Make ESD check usage configurable in DSI panel data, as opposed to a Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH v3 19/21] OMAP: DSS2: Taal: Print panel name in addition to revision

From: Jani Nikula ext-jani.1.nik...@nokia.com The driver will support other panels in addition to Taal, print also the name. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v3 20/21] OMAP: DSS2: Taal: Add regulator configuration support

From: Jani Nikula ext-jani.1.nik...@nokia.com Add support for configuring regulators in the panel specific configuration data. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 83 + 1 files changed, 83

[PATCH v3 16/21] OMAP: DSS2: Taal: Use Nokia DSI panel data

From: Jani Nikula ext-jani.1.nik...@nokia.com Get board specific information from the Nokia DSI panel data structure instead of the DSS. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 59 ++-- 1 files changed, 38

[PATCH v3 07/21] OMAP: DSS2: Taal: Remove ESD work cancel from driver probe error handling

From: Jani Nikula ext-jani.1.nik...@nokia.com ESD work is never queued in probe, no need to cancel it on probe error. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[PATCH v3 14/21] OMAP: DSS2: Taal: Add proper external TE support

From: Jani Nikula ext-jani.1.nik...@nokia.com Add gpio irq based external TE support with timeout. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 93 +++-- 1 files changed, 75 insertions(+), 18 deletions(-) diff

[PATCH v3 21/21] OMAP: DSS2: Taal: CABC workaround is Taal specific

From: Jani Nikula ext-jani.1.nik...@nokia.com Prepare for supporting panels other than Taal in this driver. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v3 15/21] OMAP: DSS2: Add Nokia DSI command mode panel configuration struct

From: Jani Nikula ext-jani.1.nik...@nokia.com Introduce a configuration struct for platform/board specific information of Nokia DSI command mode panels, to be used in addition to struct omap_dss_device (passed via the 'void *data' member). Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com

[PATCH v3 18/21] OMAP: DSS2: Taal: Add panel specific configuration structure

From: Jani Nikula ext-jani.1.nik...@nokia.com Add a structure for panel specific configration to be able to support more than one panel in the future. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 108 +++-- 1

[PATCH v3 11/21] OMAP: DSS2: Taal: Check taal_power_on() return value in taal_resume()

From: Jani Nikula ext-jani.1.nik...@nokia.com Change state only if power on was succesful. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/video/omap2

[PATCH v3 10/21] OMAP: DSS2: Taal: Change DSI bus locking to avoid deadlock in ESD work

From: Jani Nikula ext-jani.1.nik...@nokia.com Move dsi_bus_lock/unlock() out of taal_power_on/off() to avoid deadlock in taal_esd_work(). Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 29 +++-- 1 files changed

[PATCH v3 08/21] OMAP: DSS2: Taal: Improve taal_power_on() error handling

From: Jani Nikula ext-jani.1.nik...@nokia.com Check return values and bail out on errors. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 30 ++-- 1 files changed, 23 insertions(+), 7 deletions(-) diff --git

[PATCH v2 01/21] OMAP: DSS2: Taal: Add panel hardware reset

From: Jani Nikula ext-jani.1.nik...@nokia.com Issue a proper reset pulse on the reset line instead of just doing power on/off. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 44 ++-- 1 files changed, 40 insertions

[PATCH v2 02/21] OMAP: DSS2: Taal: add locks to taal_bl_update_status

From: Valkeinen Tomi (Nokia-D/Helsinki) tomi.valkei...@nokia.com From: Tomi Valkeinen tomi.valkei...@nokia.com taal_bl_update_status was missing locks to protect taal_data. This caused a kernel crash randomly, as the code attempted to set the brightness while the OMAP's DSI block was actually

[PATCH v2 03/21] OMAP: DSS2: Taal: Add locks to protect taal data access

From: Jani Nikula ext-jani.1.nik...@nokia.com Avoid potential race conditions in sysfs access to taal data. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git

[PATCH v2 00/21] OMAP: DSS2: Taal panel driver updates

command mode panels in the same driver (18-21). v2: No functional changes since v1, just filled in some missing commit messages (thanks Tony for your feedback!) [1] git://gitorious.org/linux-omap-dss2/linux.git BR, Jani. Jani Nikula (20): OMAP: DSS2: Taal: Add panel hardware reset OMAP: DSS2

[PATCH v2 06/21] OMAP: DSS2: Taal: Fix request_irq() error handling

From: Jani Nikula ext-jani.1.nik...@nokia.com Separate gpio_request() and request_irq() error handling. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v2 14/21] OMAP: DSS2: Taal: Add proper external TE support

From: Jani Nikula ext-jani.1.nik...@nokia.com Add gpio irq based external TE support with timeout. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 94 +++-- 1 files changed, 76 insertions(+), 18 deletions(-) diff

[PATCH v2 11/21] OMAP: DSS2: Taal: Check taal_power_on() return value in taal_resume()

From: Jani Nikula ext-jani.1.nik...@nokia.com Change state only if power on was succesful. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/video/omap2

[PATCH v2 07/21] OMAP: DSS2: Taal: Remove ESD work cancel from driver probe error handling

From: Jani Nikula ext-jani.1.nik...@nokia.com ESD work is never queued in probe, no need to cancel it on probe error. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[PATCH v2 04/21] OMAP: DSS2: Taal: Cosmetic improvement to backlight properties initialization

From: Jani Nikula ext-jani.1.nik...@nokia.com Let the compiler worry about the type for us. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/omap2/displays

[PATCH v2 12/21] OMAP: DSS2: Taal: Change ESD work management

From: Jani Nikula ext-jani.1.nik...@nokia.com Move ESD work queuing and cancelling out of taal_power_on/off() to avoid problems related to taal_esd_work() calling the power on/off functions. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c

[PATCH v2 09/21] OMAP: DSS2: Taal: Bail out from taal_run_test() if panel is not enabled

From: Jani Nikula ext-jani.1.nik...@nokia.com Avoid problems if panel was disabled while waiting for the mutex. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff

[PATCH v2 13/21] OMAP: DSS2: Taal: Change probe error handling labels

From: Jani Nikula ext-jani.1.nik...@nokia.com Switch from numbered to named labels to make it easier to add new labels for error handling. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 24 1 files changed, 12

[PATCH v2 10/21] OMAP: DSS2: Taal: Change DSI bus locking to avoid deadlock in ESD work

From: Jani Nikula ext-jani.1.nik...@nokia.com Move dsi_bus_lock/unlock() out of taal_power_on/off() to avoid deadlock in taal_esd_work(). Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 29 +++-- 1 files changed

[PATCH v2 05/21] OMAP: DSS2: Taal: Remove platform enable/disable

From: Jani Nikula ext-jani.1.nik...@nokia.com After the addition of proper hardware reset, taal_hw_reset(), there's no need for an additional platform enable/disable. Remove them. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 11

[PATCH v2 08/21] OMAP: DSS2: Taal: Improve taal_power_on() error handling

From: Jani Nikula ext-jani.1.nik...@nokia.com Check return values and bail out on errors. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 30 ++-- 1 files changed, 23 insertions(+), 7 deletions(-) diff --git

[PATCH v2 15/21] OMAP: DSS2: Add Nokia DSI command mode panel configuration struct

From: Jani Nikula ext-jani.1.nik...@nokia.com Introduce a configuration struct for platform/board specific information of Nokia DSI command mode panels, to be used in addition to struct omap_dss_device (passed via the 'void *data' member). Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com

[PATCH v2 21/21] OMAP: DSS2: Taal: CABC workaround is Taal specific

From: Jani Nikula ext-jani.1.nik...@nokia.com Prepare for supporting panels other than Taal in this driver. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 18/21] OMAP: DSS2: Taal: Add panel specific configuration structure

From: Jani Nikula ext-jani.1.nik...@nokia.com Add a structure for panel specific configration to be able to support more than one panel in the future. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 107 +++-- 1

[PATCH v2 17/21] OMAP: DSS2: Taal: Configure ESD check in DSI panel data

From: Jani Nikula ext-jani.1.nik...@nokia.com Make ESD check usage configurable in DSI panel data, as opposed to a Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH v2 20/21] OMAP: DSS2: Taal: Add regulator configuration support

From: Jani Nikula ext-jani.1.nik...@nokia.com Add support for configuring regulators in the panel specific configuration data. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 83 + 1 files changed, 83

[PATCH v2 16/21] OMAP: DSS2: Taal: Use Nokia DSI panel data

From: Jani Nikula ext-jani.1.nik...@nokia.com Get board specific information from the Nokia DSI panel data structure instead of the DSS. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c | 59 ++-- 1 files changed, 38

[PATCH v2 19/21] OMAP: DSS2: Taal: Print panel name in addition to revision

From: Jani Nikula ext-jani.1.nik...@nokia.com The driver will support other panels in addition to Taal, print also the name. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- drivers/video/omap2/displays/panel-taal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [RFC/PATCHv2 2/4] arm: omap: gpio: implement set_debounce method

On Thu, Apr 1, 2010 at 12:32, Felipe Balbi felipe.ba...@nokia.com wrote: On Thu, Apr 01, 2010 at 11:29:16AM +0200, ext Grazvydas Ignotas wrote: There is also an issue if somebody calls _set_gpio_debounce(bank, 1, 310) and _set_gpio_debounce(bank, 2, 620), the second call will override

[PATCH v2 0/2] new input keycodes, gpio-keys for RX-51

of board-rx51.c as suggested by Tony. * Merge rx51_defconfig change into patch 2/2 as suggested by Tony. Jani Nikula (2): Input: add new keycodes useful in mobile devices ARM OMAP3: RX-51 board: add initialization of gpio keys arch/arm/configs/rx51_defconfig |2 +- arch/arm

[PATCH v2 1/2] Input: add new keycodes useful in mobile devices

From: Jani Nikula ext-jani.1.nik...@nokia.com Add new codes for camera focus key, and camera lens cover, keypad slide, front proximity switches. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- include/linux/input.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff

[PATCH v2 2/2] ARM OMAP3: RX-51 board: add initialization of gpio keys

From: Jani Nikula ext-jani.1.nik...@nokia.com Initialize some of the RX-51 input GPIO lines as gpio keys. Enable gpio keys as a module in rx51_defconfig. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- arch/arm/configs/rx51_defconfig |2 +- arch/arm/mach-omap2/board

[PATCH 0/3] new input keycodes, gpio-keys for RX-51

. And I know of at least one game that uses the said proximity sensor as fire button. Anyway, in the end it's your call, and I can change it if necessary. These have been tested with RX-51, vanilla linux-omap, minimal console and evtest. BR, Jani. Jani Nikula (3): Input: add new keycodes

[PATCH 3/3] ARM OMAP3: rx51_defconfig: enable support for gpio keys

From: Jani Nikula ext-jani.1.nik...@nokia.com Compile gpio_keys driver a module. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- arch/arm/configs/rx51_defconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/configs/rx51_defconfig b/arch/arm

[PATCH 1/3] Input: add new keycodes useful in mobile devices

From: Jani Nikula ext-jani.1.nik...@nokia.com Add new codes for camera focus key, and camera lense cover, keypad slide, front proximity switches. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- include/linux/input.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff

[PATCH 2/3] ARM OMAP3: RX-51 board: add initialization of gpio keys

From: Jani Nikula ext-jani.1.nik...@nokia.com Initialize some of the RX-51 input GPIO lines as gpio keys. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- arch/arm/mach-omap2/board-rx51.c | 84 ++ 1 files changed, 84 insertions(+), 0 deletions

Re: [PATCH] ARM: OMAP: Fix GPIO switch initial output state handling

On Tue, 2009-03-10 at 15:25 +0100, ext Kainan Cha wrote: Jani, Please see my comments below. On Tue, Mar 10, 2009 at 4:26 AM, Jani Nikula ext-jani.1.nik...@nokia.com wrote: The switchover to cross-platform GPIO interface unexpectedly caused all output GPIO switches to be set to high

[PATCH v2] ARM: OMAP: Fix GPIO switch initial output state handling

of the switch. Also store the state of output switches directly into the switch struct instead of trying to read an output GPIO. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- arch/arm/plat-omap/gpio-switch.c | 13 + arch/arm/plat-omap/include/mach/gpio-switch.h

GPIO switch framework (was: Re: [PATCH] ARM: OMAP: Add support for dynamic GPIO switch update)

On Tue, 2008-12-16 at 11:35 +0530, ext Trilok Soni wrote: OK, I found other guys (android ??) using such home brew frameworks. Time to write a switch framework. To start a discussion on what such a GPIO switch framework should be like if someone were to write it, here's a list of the kind of

Re: GPIO switch framework (was: Re: [PATCH] ARM: OMAP: Add support for dynamic GPIO switch update)

On Thu, 2008-12-18 at 18:30 +0530, ext Trilok Soni wrote: Why limit to GPIO based switches only? GPIOs should be client of switch framework I think, and how h/w implements that switch should be hidden by client specific driver. You're quite right, it's better not to make such unnecessary

Re: [PATCH] ARM: OMAP: Add support for dynamic GPIO switch update

On Mon, 2008-12-15 at 15:40 +0200, ext Juha Yrjölä wrote: On Mon, Dec 15, 2008 at 02:08:16PM +0200, Jani Nikula wrote: Add new function omap_update_gpio_switch() to support dynamically changing the GPIO switch notify callback functions and debounce timeouts. Why do they need

Re: [PATCH] ARM: OMAP: Add support for dynamic GPIO switch update

On Mon, 2008-12-15 at 17:29 +0200, ext Juha Yrjölä wrote: On Mon, Dec 15, 2008 at 04:52:32PM +0200, Jani Nikula wrote: The switches themselves don't change (nor does this patch support changing them), but different kinds of external devices may be connected to the GPIO swiches. It would

[PATCH] ARM: OMAP: Add support for dynamic GPIO switch update

Add new function omap_update_gpio_switch() to support dynamically changing the GPIO switch notify callback functions and debounce timeouts. Signed-off-by: Jani Nikula ext-jani.1.nik...@nokia.com --- arch/arm/plat-omap/gpio-switch.c | 39 +++- arch/arm/plat-omap

Re: [PATCH] ARM: OMAP: Add support for dynamic GPIO switch update

On Mon, 2008-12-15 at 15:22 +0200, Felipe Balbi wrote: Hi, one comment below On Mon, Dec 15, 2008 at 02:08:16PM +0200, ext Jani Nikula wrote: +int omap_update_gpio_switch(const struct omap_gpio_switch *cfg) +{ + unsigned long flags; + struct gpio_switch *sw = find_switch(cfg