Use the normal return values for bool functions
Signed-off-by: Joe Perches j...@perches.com
---
arch/arm/include/asm/dma-mapping.h | 8
arch/arm/include/asm/kvm_emulate.h | 2 +-
arch/arm/mach-omap2/powerdomain.c | 14 +++---
3 files changed, 12 insertions(+), 12 deletions
Joe Perches (25):
arm: Use bool function return values of true/false not 1/0
arm64: Use bool function return values of true/false not 1/0
hexagon: Use bool function return values of true/false not 1/0
ia64: Use bool function return values of true/false not 1/0
mips: Use bool function
On Mon, 2015-03-30 at 17:07 -0700, Casey Schaufler wrote:
On 3/30/2015 4:45 PM, Joe Perches wrote:
Joe Perches (25):
arm: Use bool function return values of true/false not 1/0
[etc...]
Why, and why these in particular?
bool functions are probably better returning
bool values instead
As far as I can tell, there's no value indirecting
the cpu passed to this function via a void *.
Update all the callers and called functions from within
clockevents_notify.
Miscellanea:
Add pr_fmt and convert one printk(KERN_ERR to pr_err
Signed-off-by: Joe Perches j...@perches.com
---
arch
pr_warn is used about 3:1 over pr_warning and is mixed use
in arch/arm. Standardize on pr_warn.
Joe Perches (8):
arm: Convert pr_warning to pr_warn
arm: mach-davinci: Convert pr_warning to pr_warn
arm: mach-ep93xx: Convert pr_warning to pr_warn
arm: mach-imx: Convert pr_warning
Use the more common pr_warn.
Other miscellanea:
o Realign arguments
Signed-off-by: Joe Perches j...@perches.com
---
arch/arm/mach-omap2/display.c| 2 +-
arch/arm/mach-omap2/hdq1w.c | 4 ++--
arch/arm/mach-omap2/i2c.c| 2 +-
arch/arm/mach-omap2/msdi.c
On Thu, 2014-07-24 at 17:46 +0200, Fabian Frederick wrote:
On 24 July 2014 at 13:37 Oliver Neukum oneu...@suse.de wrote:
On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote:
Small patchset addressing break redundancy on drivers/usb branch
(suggested by Joe Perches
On Thu, 2014-07-24 at 21:58 +0400, mat...@sai.msu.ru wrote:
The format change is to fix the following compilation issue:
Just a trivial note:
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c
b/drivers/gpu/drm/omapdrm/omap_gem.c
[]
@@ -791,7 +791,7 @@ int omap_gem_get_paddr(struct
On Fri, 2014-06-13 at 11:01 -0400, Jason Cooper wrote:
Please format the subject lines like so:
irqchip: crossbar: Set cb pointer ...
^
|
\-- note the capitalization
I suggest you don't make this a rule and focus
on more
On Fri, 2014-06-13 at 12:37 -0400, Jason Cooper wrote:
On Fri, Jun 13, 2014 at 09:14:34AM -0700, Joe Perches wrote:
On Fri, 2014-06-13 at 11:01 -0400, Jason Cooper wrote:
Please format the subject lines like so:
irqchip: crossbar: Set cb pointer
On Fri, 2014-06-13 at 22:38 +0200, Thomas Gleixner wrote:
On Fri, 13 Jun 2014, Jason Cooper wrote:
On Fri, Jun 13, 2014 at 09:48:24AM -0700, Joe Perches wrote:
On Fri, 2014-06-13 at 12:37 -0400, Jason Cooper wrote:
On Fri, Jun 13, 2014 at 09:14:34AM -0700, Joe Perches wrote:
On Fri
On Thu, 2014-06-12 at 19:05 +0530, Sricharan R wrote:
On Thursday 12 June 2014 06:40 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote:
diff --git a/drivers/irqchip/irq-crossbar.c
b/drivers/irqchip/irq-crossbar.c
[]
@@ -34,7 +34,8 @@ struct
On Thu, 2014-06-12 at 11:32 -0400, Jason Cooper wrote:
Hi Jason.
But bugfix backports haven't been much of an issue in
other subsystems with fairly active whitespace/style
changes.
Most of the mvebu fixes we've had that failed to apply were generally
due to a large whitespace change
On Mon, 2013-12-16 at 18:08 -0600, Felipe Balbi wrote:
That macro just helps removing some extra line of code and hides ffs()
calls.
While at that, also fix a variable shadowing bug where 'int irq' was
being redeclared inside inner loop while it was also argument to
interrupt handler.
On Wed, 2013-09-18 at 22:05 +0200, Pali Rohár wrote:
This driver provides kernel-side support for the Random Number
Generator hardware found on OMAP34xx processors.
[]
diff --git a/drivers/char/hw_random/omap3-rom-rng.c
b/drivers/char/hw_random/omap3-rom-rng.c
trivial note:
It produces
On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote:
When DEBUG is enabled, these macros can be used to print variables
in integer and hex format, and clearly display which registers,
offsets and values are being read/written , including printing the
names of the offsets and their values.
On Wed, 2013-08-14 at 18:40 -0500, Joel Fernandes wrote:
On 08/14/2013 06:29 PM, Joe Perches wrote:
On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote:
When DEBUG is enabled, these macros can be used to print variables
in integer and hex format, and clearly display which registers
On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
Replace a comma between expression statements by a semicolon.
[]
I can't tell if the assignment to ct-regs.mask is really intended to be
under the if. The proposed patch preserves the current
On Mon, 2013-07-22 at 05:03 +, Paul Walmsley wrote:
On Sun, 21 Jul 2013, Joe Perches wrote:
commit 498153995b9 (ARM: OMAP2+: powerdomain/PRM: move the
low-level powerdomain) renamed the files, update the patterns.
Signed-off-by: Joe Perches j...@perches.com
cc: Paul Walmsley p
On Thu, 2013-07-18 at 22:13 +0530, Sricharan R wrote:
Some socs have a large number of interrupts/dma requests to service
the needs of its many peripherals and subsystems. All of the
requests lines from the subsystems are not needed at the same
time, so they have to be muxed to the controllers
On Fri, 2013-02-15 at 15:05 -0500, David Miller wrote:
From: Mugunthan V N mugunthan...@ti.com
Date: Thu, 14 Feb 2013 23:56:46 +0530
+enum {
+ CPDMA_EOI_RX_THRESH = 0,
+ CPDMA_EOI_RX,
+ CPDMA_EOI_TX,
+ CPDMA_EOI_MISC,
+};
Do not use enumerations for hardware
On Wed, 2012-09-26 at 20:31 +0530, Kishon Vijay Abraham I wrote:
The PHY framework provides a set of API's for the PHY drivers to
create/destroy a PHY and API's
Just some trivial notes.
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
[]
@@ -0,0 +1,445 @@
[]
+static void
On Thu, 2012-07-05 at 10:44 +0800, Andy Green wrote:
From: Andy Green a...@warmcat.com
This introduces a small helper in net/ethernet, which registers a network
notifier at core_initcall time, and accepts registrations mapping expected
asynchronously-probed network device paths (like,
On Thu, 2012-07-05 at 11:20 +0800, Andy Green wrote:
On 05/07/12 11:12, the mail apparently from Joe Perches included:
[]
diff --git a/net/ethernet/mac-platform.c b/net/ethernet/mac-platform.c
[]
+static int mac_platform_netdev_event(struct notifier_block
On Mon, 2012-07-02 at 12:35 -0400, Steven Rostedt wrote:
On Mon, 2012-07-02 at 16:12 +, Arnd Bergmann wrote:
include/net/mac-la-ap.h | 28
net/Kconfig | 14
net/ethernet/Makefile|2 +
net/ethernet/mac-la-ap.c | 165
On Mon, 2012-01-30 at 22:29 +0300, Dan Carpenter wrote:
On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote:
+ pr_info(%s:%d handle(s) still opened\n,
__func__,
+ atomic_read(bridge_cref));
I remember the rule was to
On Mon, 2012-01-30 at 21:33 +0100, Víctor M. Jáquez L. wrote:
On Mon, Jan 30, 2012 at 11:53:00AM -0800, Joe Perches wrote:
I've done a patch here to tidspbridge that standardizes
printk output.
Basically, the patch adds
#define pr_fmt(fmt) KBUILD_MODNAME %s: , __func__
to prefix
tidspbridge when built as a module is named bridgedriver.
bridgedriver is not a particularly good module name.
tidspbridge is what the source is named. That seems
a more appropriate module name too as it describes
the hardware function better.
Signed-off-by: Joe Perches j...@perches.com
Joe Perches (4):
mmc: Update logging style
wbsd: Use current logging
mmc: Logging neatening
mmc: Add mmc_host_level logging
drivers/mmc/card/block.c|4 +-
drivers/mmc/card/mmc_test.c | 77 ++-
drivers/mmc/card/queue.c|6 +-
drivers/mmc/card
Convert pr_warning to pr_warn.
Coalesce format strings.
Align arguments.
Add missing \n.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/mmc/card/block.c |4 +-
drivers/mmc/card/queue.c |6 +---
drivers/mmc/card/sdio_uart.c | 10
drivers/mmc/core/bus.c
On Wed, 2011-11-16 at 09:52 +0900, NamJae Jeon wrote:
2011/11/16 Joe Perches j...@perches.com:
Centralize the pr_level uses of mmc_hostname into specific
mmc_host_level calls to allow a flexible presentation style
and shorten the code a bit.
I don't know why pr_info should be surely
On Wed, 2011-11-16 at 10:14 +0900, NamJae Jeon wrote:
2011/11/16 Joe Perches j...@perches.com:
On Wed, 2011-11-16 at 09:52 +0900, NamJae Jeon wrote:
2011/11/16 Joe Perches j...@perches.com:
Centralize the pr_level uses of mmc_hostname into specific
mmc_host_level calls to allow
On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote:
[123K of untrimmed reply]
If you wrote something, I didn't find it.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Wed, 2011-11-16 at 10:55 +0900, NamJae Jeon wrote:
2011/11/16 Joe Perches j...@perches.com:
On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote:
[123K of untrimmed reply]
If you wrote something, I didn't find it.
- dev_info(pdev-dev, DW MMC controller at irq %d
On Fri, 2011-10-07 at 10:22 +0100, Russell King - ARM Linux wrote:
On Fri, Oct 07, 2011 at 10:50:16AM +0200, Víctor Manuel Jáquez Leal wrote:
Convert a printk(KERN_ERR) message in the driver to pr_err().
...
@@ -111,7 +111,7 @@ static void omap_dm_timer_wait_for_reset(struct
omap_dm_timer
On Fri, 2011-10-07 at 20:18 +0100, Russell King - ARM Linux wrote:
On Fri, Oct 07, 2011 at 10:40:39AM -0700, Joe Perches wrote:
At some point in the next couple of years, I want
to convert all of, or as many as possible of, the
remaining printk uses to pr_level.
If the idea is also to get
On Fri, 2011-10-07 at 20:57 +0100, Russell King - ARM Linux wrote:
On Fri, Oct 07, 2011 at 12:48:21PM -0700, Joe Perches wrote:
I think it needs to be done subsystem by subsystem,
arch by arch, as maintainers accept.
Agreed - but doing one instance here, maybe another instance somewhere
On Thu, 2011-10-06 at 12:48 +0200, Víctor Manuel Jáquez Leal wrote:
Convert all the printk(level) messages in the driver to pr_level().
[]
diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
[]
@@ -397,8 +397,7 @@ struct omap_dm_timer *omap_dm_timer_request_specific(int
On Sat, 2011-09-17 at 11:34 +0200, Martin Hostettler wrote:
Adds board support for an MT9M032 based camera to omap3evm.
All of the logging messages could be
prefixed by the printk subsystem if you
add #define pr_fmt before any #include
diff --git a/arch/arm/mach-omap2/board-omap3evm-camera.c
On Mon, 2011-09-12 at 19:47 +0300, Ohad Ben-Cohen wrote:
Update MAINTAINERS with entries for hwspinlock/core and hwspinlock/omap
files.
trivial:
diff --git a/MAINTAINERS b/MAINTAINERS
[]
@@ -2953,6 +2953,14 @@ F: Documentation/hw_random.txt
[]
+HARDWARE SPINLOCK CORE
+M: Ohad
output
Remove any KERN_level from WARN uses
Coalesce formats
Align WARN arguments
Add some missing newlines to WARN uses
Add some missing first test argument (1, fmt, args) to WARN uses
Joe Perches (39):
include/asm-generic/bug.h: Update WARN macros
arch/alpha: Update WARN uses
arch/arm: Update
Add missing initial argument.
Coalesce long formats.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/video/omap2/dss/core.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
index 8e89f60..2a98237
Coalesce long formats.
Align arguments.
Add missing newlines.
Signed-off-by: Joe Perches j...@perches.com
---
arch/arm/mach-davinci/clock.c |4 +-
arch/arm/mach-davinci/da830.c |2 +-
arch/arm/mach-davinci/da850.c | 12 -
arch/arm/mach-omap2/clkt_clksel.c | 12
On Tue, 2010-01-19 at 22:17 +0100, Wim Van Sebroeck wrote:
-static struct watchdog_info at32_wdt_info = {
+static const struct watchdog_info at32_wdt_info = {
It'd be good to use a consistent structure name:
static const struct watchdog_info ident = {
etc...
}
$ grep -Poh
On Tue, 2010-01-19 at 22:16 +, Mark Brown wrote:
On Tue, Jan 19, 2010 at 01:42:31PM -0800, Joe Perches wrote:
Maybe a standard #define WATCHDOG_NAME foo
.identity = WATCHGOD_NAME
I don't really see that the indrection via the #define would buy us
anything?
Maybe not, just
Resend for Andrew Morton
On Fri, 2009-08-07 at 11:01 +0300, Tony Lindgren wrote:
* Joe Perches j...@perches.com [090806 19:35]:
Perhaps it's useful for OMAP patches and bug reports
to CC entries to the primary and secondary ARM lists.
Added a pattern entry for OMAP USB as well.
... I
On Fri, 2009-08-07 at 11:01 +0300, Tony Lindgren wrote:
* Joe Perches j...@perches.com [090806 19:35]:
Perhaps it's useful for OMAP patches and bug reports
to CC entries to the primary and secondary ARM lists.
Added a pattern entry for OMAP USB as well.
... I think let's not add
Perhaps it's useful for OMAP patches and bug reports
to CC entries to the primary and secondary ARM lists.
Added a pattern entry for OMAP USB as well.
Signed-off-by: Joe Perches
diff --git a/MAINTAINERS b/MAINTAINERS
index b1114cf..f237765 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3662,6
48 matches
Mail list logo
