Re: [RFC PATCH V2 2/8] irqdomain: Don't set type when mapping an IRQ

2015-12-22 Thread Jon Hunter
On 22/12/15 11:18, Grygorii Strashko wrote: > On 12/17/2015 12:48 PM, Jon Hunter wrote: >> Some IRQ chips, such as GPIO controllers or secondary level interrupt >> controllers, may require require additional runtime power management >> control to ensure they are accessibl

Re: [BISECTED] v4.3-rc5: OMAP1 boot hang

2015-11-13 Thread Jon Hunter
On 13/11/15 00:57, Russell King - ARM Linux wrote: > On Wed, Nov 11, 2015 at 11:44:44PM +0200, Aaro Koskinen wrote: >> Hi, >> >> Any suggestions how to debug this further? This happens also with v4.3 >> final. Is the CPU_SW_DOMAIN_PAN supposed to work with this CPU? >> >> I tried to disable

Re: [PATCH v2 1/2] clk: change clk_ops' -round_rate() prototype

2015-06-08 Thread Jon Hunter
Hi Boris, On 05/06/15 12:39, Boris Brezillon wrote: Hi Jon, On Fri, 5 Jun 2015 09:46:09 +0100 Jon Hunter jonath...@nvidia.com wrote: On 05/06/15 00:02, Paul Walmsley wrote: Hi folks just a brief comment on this one: On Thu, 30 Apr 2015, Boris Brezillon wrote: Clock rates

Re: [PATCH v2 1/2] clk: change clk_ops' -round_rate() prototype

2015-06-05 Thread Jon Hunter
On 05/06/15 00:02, Paul Walmsley wrote: Hi folks just a brief comment on this one: On Thu, 30 Apr 2015, Boris Brezillon wrote: Clock rates are stored in an unsigned long field, but -round_rate() (which returns a rounded rate from a requested one) returns a long value (errors are

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-12 Thread Jon Hunter
On 02/11/2015 09:14 PM, Tony Lindgren wrote: * Paul Walmsley p...@pwsan.com [150211 13:03]: On Wed, 11 Feb 2015, Tony Lindgren wrote: * Paul Walmsley p...@pwsan.com [150210 18:28]: On Tue, 10 Feb 2015, Jon Hunter wrote: On 07/02/2015 00:23, Paul Walmsley wrote: Unfortunately

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-12 Thread Jon Hunter
On 02/12/2015 11:26 AM, Jon Hunter wrote: On 02/11/2015 09:14 PM, Tony Lindgren wrote: * Paul Walmsley p...@pwsan.com [150211 13:03]: On Wed, 11 Feb 2015, Tony Lindgren wrote: * Paul Walmsley p...@pwsan.com [150210 18:28]: On Tue, 10 Feb 2015, Jon Hunter wrote: On 07/02/2015 00:23, Paul

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-11 Thread Jon Hunter
Hi Paul, On 02/11/2015 02:25 AM, Paul Walmsley wrote: Hi John, thanks for the review, On Tue, 10 Feb 2015, Jon Hunter wrote: [snip] Subject: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs Building an OMAP1510-only Kconfig generates the following warnings

Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs

2015-02-10 Thread Jon Hunter
built with both CONFIG_OMAP_DM_TIMER=y and CONFIG_OMAP_32K_TIMER=y. While here, clean up a few printk()s and unnecessary #ifdefs. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Jon Hunter jonath...@nvidia.com Cc: Aaro Koskinen aaro.koski...@iki.fi Cc: Tuukka Tikkanen tuukka.tikka

Re: [PATCH v2 11/14] Documentation: dt: binding: omap: am43x timer

2013-05-29 Thread Jon Hunter
On 28/05/13 23:05, Stephen Warren wrote: On 05/28/2013 03:25 PM, Jon Hunter wrote: On 27/05/13 15:37, Afzal Mohammed wrote: AM43x timer bindings. Signed-off-by: Afzal Mohammed af...@ti.com --- Documentation/devicetree/bindings/arm/omap/timer.txt | 2 ++ 1 file changed, 2 insertions

Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression

2013-05-29 Thread Jon Hunter
On 29/05/13 19:55, Aaro Koskinen wrote: Hi, On Tue, May 28, 2013 at 07:42:41PM +0100, Jon Hunter wrote: Care to share the log? Below are three logs from 3.10-rc3 / Nokia 770. I did not even compile Retu this time, as it has nothing to do with GPIO IRQs being broken on OMAP1. That's

Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression

2013-05-29 Thread Jon Hunter
On 29/05/13 22:29, Jon Hunter wrote: On 29/05/13 19:55, Aaro Koskinen wrote: Hi, On Tue, May 28, 2013 at 07:42:41PM +0100, Jon Hunter wrote: Care to share the log? Below are three logs from 3.10-rc3 / Nokia 770. I did not even compile Retu this time, as it has nothing to do with GPIO

Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression

2013-05-28 Thread Jon Hunter
On 23/05/13 21:13, Aaro Koskinen wrote: On Thu, May 23, 2013 at 08:02:05PM +0100, Jon Hunter wrote: On 22/05/13 22:20, Aaro Koskinen wrote: On Tue, May 21, 2013 at 08:37:16PM +0100, Jon Hunter wrote: On 21/05/13 18:39, Aaro Koskinen wrote: On Mon, May 20, 2013 at 10:46:21AM -0700, Tony

Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression

2013-05-28 Thread Jon Hunter
On 26/05/13 20:07, Aaro Koskinen wrote: On Thu, May 23, 2013 at 08:02:05PM +0100, Jon Hunter wrote: On 22/05/13 22:20, Aaro Koskinen wrote: On Tue, May 21, 2013 at 08:37:16PM +0100, Jon Hunter wrote: On 21/05/13 18:39, Aaro Koskinen wrote: On Mon, May 20, 2013 at 10:46:21AM -0700, Tony

Re: [PATCH] ARM: OMAP2+: timer: initialize before using oh_name

2013-05-28 Thread Jon Hunter
, int posted) { char name[10]; /* 10 = sizeof(gptXX_Xck0) */ - const char *oh_name; + const char *oh_name = NULL; struct device_node *np; struct omap_hwmod *oh; struct resource irq, mem; Thanks! Acked-by: Jon Hunter jgchun...@gmail.com

Re: [PATCH v2 12/14] Documentation: dt: binding: omap: am43x counter

2013-05-28 Thread Jon Hunter
On 27/05/13 15:37, Afzal Mohammed wrote: AM43x 32K counter binding. Signed-off-by: Afzal Mohammed af...@ti.com --- Documentation/devicetree/bindings/arm/omap/counter.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/omap/counter.txt

Re: [PATCH v2 11/14] Documentation: dt: binding: omap: am43x timer

2013-05-28 Thread Jon Hunter
On 27/05/13 15:37, Afzal Mohammed wrote: AM43x timer bindings. Signed-off-by: Afzal Mohammed af...@ti.com --- Documentation/devicetree/bindings/arm/omap/timer.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/omap/timer.txt

Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression

2013-05-23 Thread Jon Hunter
On 22/05/13 22:20, Aaro Koskinen wrote: On Tue, May 21, 2013 at 08:37:16PM +0100, Jon Hunter wrote: On 21/05/13 18:39, Aaro Koskinen wrote: On Mon, May 20, 2013 at 10:46:21AM -0700, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [130516 14:50]: * Aaro Koskinen aaro.koski...@iki.fi

Re: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression

2013-05-21 Thread Jon Hunter
from regmap code. According to git bisect, it is caused by: commit ede4d7a5b9835510fd1f724367f68d2fa4128453 Author: Jon Hunter jon-hun...@ti.com Date: Fri Mar 1 11:22:47 2013 -0600 gpio/omap: convert gpio irq domain to linear mapping The commit does not anymore revert cleanly, and I

[GIT PULL] ARM: OMAP2+: GPMC fixes for v3.10

2013-04-30 Thread Jon Hunter
. Javier Martinez Canillas (3): Documentation: dt: update TI GPMC ethernet binding properties ARM: OMAP2+: only search for GPMC DT child nodes on probe ARM: OMAP2+: only WARN if a GPMC child probe function fail Jon Hunter (1): Documentation: dt: update properties in TI

[PATCH] ARM: dts: OMAP2+: Simplify NAND support

2013-04-30 Thread Jon Hunter
the property gpmc,device-nand as a required property and also updated the example. However, this property is redundant and not needed because the GPMC child device node for NAND is called nand. Therefore, remove this property. Signed-off-by: Jon Hunter jon-hun...@ti.com --- Documentation/devicetree

Re: [PATCH v3] gpio/omap: implement irq mask/disable with proper semantic.

2013-04-26 Thread Jon Hunter
On 04/22/2013 03:54 AM, Andreas Fenkart wrote: When a gpio interrupt is masked, the gpio event will still be latched in the interrupt status register so when you unmask it later you may get an interrupt straight away. However, if the interrupt is disabled then gpio events occurring will not

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-26 Thread Jon Hunter
On 04/26/2013 02:27 AM, Linus Walleij wrote: On Wed, Apr 17, 2013 at 5:41 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 04/16/2013 05:14 PM, Jon Hunter wrote: c) I have the feeling that hooking the of_xlate function for this is a bit of an abuse of the function. I was wondering about

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-26 Thread Jon Hunter
On 04/26/2013 02:31 AM, Linus Walleij wrote: On Wed, Apr 17, 2013 at 2:41 AM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: So: +static int omap_gpio_irq_domain_xlate(struct irq_domain *d, + struct device_node *ctrlr, +

Re: [PATCH v3] gpio/omap: implement irq mask/disable with proper semantic.

2013-04-25 Thread Jon Hunter
On 04/22/2013 03:54 AM, Andreas Fenkart wrote: When a gpio interrupt is masked, the gpio event will still be latched in the interrupt status register so when you unmask it later you may get an interrupt straight away. However, if the interrupt is disabled then gpio events occurring will not

Re: [PATCH v3] gpio/omap: implement irq mask/disable with proper semantic.

2013-04-25 Thread Jon Hunter
On 04/22/2013 03:54 AM, Andreas Fenkart wrote: When a gpio interrupt is masked, the gpio event will still be latched in the interrupt status register so when you unmask it later you may get an interrupt straight away. However, if the interrupt is disabled then gpio events occurring will not

Re: ARM: dts: omap3: NAND support - how?

2013-04-19 Thread Jon Hunter
On 04/19/2013 04:01 AM, Christoph Fritz wrote: On Thu, 2013-04-18 at 18:26 -0500, Jon Hunter wrote: On 04/18/2013 06:24 PM, Jon Hunter wrote: To get the values right for dt-GPMC-NAND-Config, here are the GPMC config registers for chip-select 0, they are taken from u-boot by doing md

Re: ARM: dts: omap3: NAND support - how?

2013-04-19 Thread Jon Hunter
On 04/19/2013 07:02 AM, Christoph Fritz wrote: On Fri, 2013-04-19 at 11:01 +0200, Christoph Fritz wrote: This is how u-boot GPMC config differs from final kernel configuration: u-boot: GPMC_CONFIG1: 0x6e60: 0x1800 kernel: 0x1800

Re: ARM: dts: omap3: NAND support - how?

2013-04-19 Thread Jon Hunter
On 04/19/2013 09:53 AM, Christoph Fritz wrote: On Fri, 2013-04-19 at 09:00 -0500, Jon Hunter wrote: On 04/19/2013 07:02 AM, Christoph Fritz wrote: so I hacked the missing values to omap2_nand_gpmc_retime(): From 8868823925441a824fe0d3143614482f25fb379b Mon Sep 17 00:00:00 2001 From

Re: ARM: dts: omap3: NAND support - how?

2013-04-19 Thread Jon Hunter
On 04/19/2013 10:48 AM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130419 08:41]: On 04/19/2013 09:53 AM, Christoph Fritz wrote: -static int omap2_nand_gpmc_retime( - struct omap_nand_platform_data *gpmc_nand_data, - struct

Re: [PATCH] gpio/omap: ensure gpio context is initialised

2013-04-18 Thread Jon Hunter
On 04/18/2013 03:22 AM, Santosh Shilimkar wrote: On Thursday 18 April 2013 02:01 AM, Jon Hunter wrote: Commit a2797be (gpio/omap: force restore if context loss is not detectable) broke gpio support for OMAP when booting with device-tree because a restore of the gpio context being performed

Re: [PATCH 2/2] ARM: OMAP4+: Add a timer attribute for timers that can interrupt IPU

2013-04-18 Thread Jon Hunter
On 04/18/2013 01:21 PM, Anna, Suman wrote: Jon, On 04/17/2013 07:04 PM, Jon Hunter wrote: On 04/17/2013 06:23 PM, Suman Anna wrote: Some instances of the DMTIMER peripheral on OMAP4+ devices have the ability to interrupt the on-chip image processor unit (IPU) subsystem (a common name

Re: ARM: dts: omap3: NAND support - how?

2013-04-18 Thread Jon Hunter
On 04/18/2013 02:03 PM, Christoph Fritz wrote: Hi I'm trying to setup nand support for an omap3 board for linux-next (next-20130417). This is my approach so far: +gpmc { + ranges = 0 0 0x3000 0x100; + nand@0,0 { + reg = 0 0 0xff; /* - ? not

Re: ARM: dts: omap3: NAND support - how?

2013-04-18 Thread Jon Hunter
On 04/18/2013 03:23 PM, Christoph Fritz wrote: Hi Jon On Thu, 2013-04-18 at 14:39 -0500, Jon Hunter wrote: On 04/18/2013 02:03 PM, Christoph Fritz wrote: I had put the complete size in here so ... + reg = 0 0 0x100; Thanks. + nand-bus-width = 16

Re: [PATCH] gpio/omap: ensure gpio context is initialised

2013-04-18 Thread Jon Hunter
Hi Kevin, On 04/18/2013 04:34 PM, Kevin Hilman wrote: Hi Jon, Jon Hunter jon-hun...@ti.com writes: Commit a2797be (gpio/omap: force restore if context loss is not detectable) broke gpio support for OMAP when booting with device-tree because a restore of the gpio context being performed

Re: ARM: dts: omap3: NAND support - how?

2013-04-18 Thread Jon Hunter
On 04/18/2013 05:48 PM, Christoph Fritz wrote: On Thu, 2013-04-18 at 17:28 -0500, Jon Hunter wrote: On 04/18/2013 03:23 PM, Christoph Fritz wrote: OMAP3_EVM # md 0x6E60 7 6e60: 1800 00141400 00141400 0f010f01 6e70: 010c1414 1f0f0a80 0870

Re: ARM: dts: omap3: NAND support - how?

2013-04-18 Thread Jon Hunter
On 04/18/2013 06:24 PM, Jon Hunter wrote: On 04/18/2013 05:48 PM, Christoph Fritz wrote: On Thu, 2013-04-18 at 17:28 -0500, Jon Hunter wrote: On 04/18/2013 03:23 PM, Christoph Fritz wrote: OMAP3_EVM # md 0x6E60 7 6e60: 1800 00141400 00141400 0f010f01

Re: [PATCH] gpio/omap: ensure gpio context is initialised

2013-04-18 Thread Jon Hunter
On 04/18/2013 06:10 PM, Jon Hunter wrote: On 04/18/2013 04:34 PM, Kevin Hilman wrote: ... Why not just init context right here if bank-loses_context !bank-context_valid? I really like this idea a lot. It can really clean-up the code and really make it much more readable. Before we were

Re: [PATCH] gpio/omap: ensure gpio context is initialised

2013-04-18 Thread Jon Hunter
On 04/18/2013 07:34 PM, Jon Hunter wrote: On 04/18/2013 06:10 PM, Jon Hunter wrote: On 04/18/2013 04:34 PM, Kevin Hilman wrote: ... Why not just init context right here if bank-loses_context !bank-context_valid? I really like this idea a lot. It can really clean-up the code

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-17 Thread Jon Hunter
On 04/17/2013 02:55 AM, Javier Martinez Canillas wrote: ... There are so many patches flying around in this thread that I missed it :-) Sorry about that... No problem. I was trying to see if we could find a common solution that everyone could use as it seems that ideally we should all

Re: [PATCH v3 3/3] ARM: OMAP2+: Add GPMC DT support for Ethernet child nodes

2013-04-17 Thread Jon Hunter
On 04/17/2013 07:05 AM, Javier Martinez Canillas wrote: ... Yes, in fact I just realized that for_each_node_by_name() expand to: #define for_each_node_by_name(dn, name) \ for (dn = of_find_node_by_name(NULL, name); dn; \ dn = of_find_node_by_name(dn, name)) which

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-17 Thread Jon Hunter
On 04/17/2013 08:42 AM, Javier Martinez Canillas wrote: On Wed, Apr 17, 2013 at 3:25 PM, Jon Hunter jon-hun...@ti.com wrote: On 04/17/2013 02:55 AM, Javier Martinez Canillas wrote: ... There are so many patches flying around in this thread that I missed it :-) Sorry about

Re: [PATCH v3 3/3] ARM: OMAP2+: Add GPMC DT support for Ethernet child nodes

2013-04-17 Thread Jon Hunter
On 04/17/2013 09:07 AM, Javier Martinez Canillas wrote: On 04/17/2013 03:48 PM, Jon Hunter wrote: On 04/17/2013 07:05 AM, Javier Martinez Canillas wrote: ... Yes, in fact I just realized that for_each_node_by_name() expand to: #define for_each_node_by_name(dn, name) \ for (dn

Re: [PATCH] ARM: OMAP2+: only search for GPMC DT child nodes on probe

2013-04-17 Thread Jon Hunter
On 04/17/2013 11:37 AM, Javier Martinez Canillas wrote: The GPMC DT probe function use for_each_node_by_name() to search child device nodes of the GPMC controller. But this function does not use the GPMC device node as the root of the search and instead search across the complete Device Tree.

Re: [PATCH] ARM: dts: omap4-panda: Add LED support into the panda DTS files

2013-04-17 Thread Jon Hunter
On 04/17/2013 02:09 PM, Dan Murphy wrote: The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different. Abstract away the pinmux and the LED definitions for the two boards. Just a heads-up but you should base this upon Benoit's for_3.10 branch [1] as there is now a

[PATCH] gpio/omap: ensure gpio context is initialised

2013-04-17 Thread Jon Hunter
for gpio banks that could lose their state regardless of whether we are booting with device-tree or not. Reported-by: Tony Lindgren t...@atomide.com Signed-off-by: Jon Hunter jon-hun...@ti.com Tested-by: Tony Lindgren t...@atomide.com --- drivers/gpio/gpio-omap.c | 53

Re: [PATCH v2 1/2] ARM: OMAP2+: only search for GPMC DT child nodes on probe

2013-04-17 Thread Jon Hunter
will be restricted to its children. Reported-by: Lars Poeschel poesc...@lemonage.de Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v1 (suggested by Jon Hunter): - Split the search for GPMC child nodes and only warn if a child probe fails

Re: [PATCH v2 1/2] ARM: OMAP2+: only search for GPMC DT child nodes on probe

2013-04-17 Thread Jon Hunter
On 04/17/2013 05:10 PM, Javier Martinez Canillas wrote: On 04/17/2013 11:27 PM, Jon Hunter wrote: On 04/17/2013 03:34 PM, Javier Martinez Canillas wrote: The GPMC DT probe function use for_each_node_by_name() to search child device nodes of the GPMC controller. But this function does

Re: [PATCH 1/2] ARM: dts: OMAP5: add PWM capability to timer nodes missing it

2013-04-17 Thread Jon Hunter
; + ti,timer-pwm; }; timer11: timer@48088000 { Make sure you copy the linux-arm and device-tree mailing lists. Acked-by: Jon Hunter jon-hun...@ti.com Thanks! Jon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH 2/2] ARM: OMAP4+: Add a timer attribute for timers that can interrupt IPU

2013-04-17 Thread Jon Hunter
On 04/17/2013 06:23 PM, Suman Anna wrote: Some instances of the DMTIMER peripheral on OMAP4+ devices have the ability to interrupt the on-chip image processor unit (IPU) subsystem (a common name for the dual Cortex-M3 subsystem on OMAP4 or the dual Cortex-M4 subsystem on OMAP5) in addition to

Re: [PATCH 2/2] ARM: OMAP4+: Add a timer attribute for timers that can interrupt IPU

2013-04-17 Thread Jon Hunter
On 04/17/2013 07:04 PM, Jon Hunter wrote: On 04/17/2013 06:23 PM, Suman Anna wrote: Some instances of the DMTIMER peripheral on OMAP4+ devices have the ability to interrupt the on-chip image processor unit (IPU) subsystem (a common name for the dual Cortex-M3 subsystem on OMAP4 or the dual

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-16 Thread Jon Hunter
On 04/15/2013 04:27 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130415 11:15]: ... From 56598ba51a75481b050433bb38b7ae31a5ed4ae8 Mon Sep 17 00:00:00 2001 From: Jon Hunter jon-hun...@ti.com Date: Mon, 15 Apr 2013 13:06:54 -0500 Subject: [PATCH] gpio/omap: ensure gpio context

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-16 Thread Jon Hunter
On 04/16/2013 01:06 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130416 10:19]: On 04/15/2013 04:27 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130415 11:15]: ... From 56598ba51a75481b050433bb38b7ae31a5ed4ae8 Mon Sep 17 00:00:00 2001 From: Jon Hunter jon-hun

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Jon Hunter
On 04/16/2013 01:40 PM, Stephen Warren wrote: On 04/15/2013 05:04 PM, Jon Hunter wrote: On 04/15/2013 05:16 PM, Stephen Warren wrote: On 04/15/2013 03:40 PM, Jon Hunter wrote: ... mmc { label = pandaboard::status2; gpios = gpio1 8 0; ... }; But that's a gpio-leds instance

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Jon Hunter
On 04/16/2013 02:27 PM, Jon Hunter wrote: ... Right. In the DT case though, if someone does provide the IRQ and GPIO IDs then at least they would use a different xlate function. Another option to consider would be defining the #interrupt-cells = 3 where we would have ... cell-#1 -- IRQ

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Jon Hunter
On 04/16/2013 05:11 PM, Stephen Warren wrote: On 04/16/2013 01:27 PM, Jon Hunter wrote: On 04/16/2013 01:40 PM, Stephen Warren wrote: On 04/15/2013 05:04 PM, Jon Hunter wrote: ... If some driver is calling gpio_request() directly, then they will most likely just call gpio_to_irq() when

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Jon Hunter
On 04/16/2013 07:41 PM, Javier Martinez Canillas wrote: On Wed, Apr 17, 2013 at 1:14 AM, Jon Hunter jon-hun...@ti.com wrote: On 04/16/2013 05:11 PM, Stephen Warren wrote: On 04/16/2013 01:27 PM, Jon Hunter wrote: On 04/16/2013 01:40 PM, Stephen Warren wrote: On 04/15/2013 05:04 PM, Jon

Re: [PATCH V4 10/18] ARM: OMAP2+: Add function to read GPMC settings from device-tree

2013-04-15 Thread Jon Hunter
On 04/15/2013 08:27 AM, Grant Likely wrote: On Tue, 19 Mar 2013 11:35:48 -0500, Jon Hunter jon-hun...@ti.com wrote: Adds a function to read the various GPMC chip-select settings from device-tree and store them in the gpmc_settings structure. Update the GPMC device-tree binding documentation

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-15 Thread Jon Hunter
On 04/13/2013 11:50 AM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130412 19:22]: On 04/12/2013 07:06 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [130410 15:32]: * Jon Hunter jon-hun...@ti.com [130410 15:30]: Are you saying that you want to use the version

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-15 Thread Jon Hunter
On 04/15/2013 11:57 AM, Jon Hunter wrote: On 04/13/2013 11:50 AM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130412 19:22]: On 04/12/2013 07:06 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [130410 15:32]: * Jon Hunter jon-hun...@ti.com [130410 15:30]: Are you

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-15 Thread Jon Hunter
On 04/15/2013 11:53 AM, Stephen Warren wrote: On 04/13/2013 07:35 PM, Javier Martinez Canillas wrote: ... Is the following inlined patch [1] what you were thinking that would be the right approach? ... diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c ... +static int

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-15 Thread Jon Hunter
On 04/15/2013 11:58 AM, Stephen Warren wrote: On 04/14/2013 02:53 PM, Linus Walleij wrote: On Sun, Apr 14, 2013 at 3:35 AM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: Is the following inlined patch [1] what you were thinking that would be the right approach? This looks sort

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-15 Thread Jon Hunter
On 04/15/2013 04:40 PM, Jon Hunter wrote: On 04/15/2013 11:58 AM, Stephen Warren wrote: On 04/14/2013 02:53 PM, Linus Walleij wrote: On Sun, Apr 14, 2013 at 3:35 AM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: Is the following inlined patch [1] what you were thinking

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-15 Thread Jon Hunter
On 04/15/2013 05:16 PM, Stephen Warren wrote: On 04/15/2013 03:40 PM, Jon Hunter wrote: On 04/15/2013 11:58 AM, Stephen Warren wrote: On 04/14/2013 02:53 PM, Linus Walleij wrote: On Sun, Apr 14, 2013 at 3:35 AM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: Is the following

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-12 Thread Jon Hunter
On 04/12/2013 07:06 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [130410 15:32]: * Jon Hunter jon-hun...@ti.com [130410 15:30]: Are you saying that you want to use the version with that is using the pre-processor definitions? I was thinking that may be we could do

Re: gpio/omap v2: map irq_enable/disable to mask/unmask.

2013-04-11 Thread Jon Hunter
On 04/11/2013 10:54 AM, Santosh Shilimkar wrote: On Thursday 11 April 2013 06:48 PM, Andreas Fenkart wrote: Hi Santosh, I submitted the following patch a while back. https://patchwork.kernel.org/patch/1886421/ As already said, the patch is straight forward, but without it, we probably

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-10 Thread Jon Hunter
/gmane.linux.ports.arm.omap/92192 From ed3e66bcd4c0cb3df4cb70e75c45fa4462f70565 Mon Sep 17 00:00:00 2001 From: Jon Hunter jon-hun...@ti.com Date: Wed, 10 Apr 2013 11:44:44 -0500 Subject: [PATCH] ARM: dts: OMAP4: Fix ethernet IRQ for OMAP4 boards Commit ff5c9059 (ARM: dts: OMAP3+: Correct gpio #interrupts-cells property

Re: [PATCH 4/5] gpio/omap: force restore if context loss is not detectable

2013-04-10 Thread Jon Hunter
On 04/10/2013 02:39 PM, Linus Walleij wrote: On Thu, Apr 4, 2013 at 10:16 PM, Jon Hunter jon-hun...@ti.com wrote: When booting with device-tree the function pointer for detecting context loss is not populated. Ideally, the pm_runtime framework should be enhanced to allow a means

Re: [PATCH 1/5] gpio/omap: free irq domain in probe() failure paths

2013-04-10 Thread Jon Hunter
On 04/10/2013 02:33 PM, Linus Walleij wrote: On Thu, Apr 4, 2013 at 10:16 PM, Jon Hunter jon-hun...@ti.com wrote: Currently the IRQ domain is not freed once allocated, in the case where omap_gpio_probe() fails. Therefore, ensure we free the domain if the probe does fail. Furthermore

Re: [PATCH 4/5] gpio/omap: force restore if context loss is not detectable

2013-04-10 Thread Jon Hunter
On 04/10/2013 02:44 PM, Linus Walleij wrote: On Wed, Apr 10, 2013 at 9:41 PM, Jon Hunter jon-hun...@ti.com wrote: On 04/10/2013 02:39 PM, Linus Walleij wrote: On Thu, Apr 4, 2013 at 10:16 PM, Jon Hunter jon-hun...@ti.com wrote: When booting with device-tree the function pointer for detecting

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-10 Thread Jon Hunter
On 04/10/2013 01:20 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130410 10:35]: Hi Tony, On 04/09/2013 04:23 PM, Tony Lindgren wrote: Hi Jon, Looks like at least 4430sdp nfsroot got broken with commit ff5c9059 (ARM: dts: OMAP3+: Correct gpio #interrupts-cells property

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-10 Thread Jon Hunter
On 04/10/2013 03:54 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130410 13:47]: On 04/10/2013 01:20 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130410 10:35]: Hi Tony, On 04/09/2013 04:23 PM, Tony Lindgren wrote: Hi Jon, Looks like at least 4430sdp nfsroot got

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-10 Thread Jon Hunter
On 04/10/2013 06:58 PM, Javier Martinez Canillas wrote: On Wed, Apr 10, 2013 at 7:31 PM, Jon Hunter jon-hun...@ti.com wrote: Hi Tony, On 04/09/2013 04:23 PM, Tony Lindgren wrote: Hi Jon, Looks like at least 4430sdp nfsroot got broken with commit ff5c9059 (ARM: dts: OMAP3+: Correct gpio

Re: [PATCH v2 11/11] ARM: OMAP2+: omap_hwmod: Don't call _init_mpu_rt_base if no sysc

2013-04-10 Thread Jon Hunter
On 03/19/2013 08:30 AM, Santosh Shilimkar wrote: OMAP hwmod layer does the reset of the IPs in early code so that we have SOC in sane state. To do the soft-reset, it needs to ioremap() the ip address space to be able to write to sysconfig registers. But there are few hwmod which doesn't

Re: [PATCH 1/1] Documentation: dt: update TI GPMC ethernet binding properties

2013-04-09 Thread Jon Hunter
; gpmc,cycle2cycle-diffcsen; Acked-by: Jon Hunter jon-hun...@ti.com Cheers Jon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Documentation: dt: update properties in TI GPMC NAND example

2013-04-09 Thread Jon Hunter
The GPMC timing properties for device-tree have been updated by adding a -ns or -ps suffix to indicate the units of time the property represents. Therefore, update the timing property names for TI GPMC NAND example. Signed-off-by: Jon Hunter jon-hun...@ti.com --- .../devicetree/bindings/mtd/gpmc

[PATCH 3/3] ARM: dts: Add OMAP3430 SDP NOR flash memory binding

2013-04-07 Thread Jon Hunter
Add device-tree node for the 128MB NOR on the OMAP3423-SDP board. Signed-off-by: Jon Hunter jon-hun...@ti.com --- arch/arm/boot/dts/omap3430-sdp.dts | 51 +++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3430-sdp.dts b

[PATCH 2/3] ARM: dts: Add NOR flash bindings for OMAP2420 H4

2013-04-07 Thread Jon Hunter
Add device-tree node for the 64MB NOR on the OMAP2420-H4 board. Signed-off-by: Jon Hunter jon-hun...@ti.com --- arch/arm/boot/dts/omap2420-h4.dts | 46 + 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/omap2420-h4.dts b/arch/arm/boot/dts

[PATCH 1/3] ARM: dts: Update OMAP3430 SDP NAND and ONENAND properties

2013-04-07 Thread Jon Hunter
The GPMC timing properties for device-tree have been updated by adding a -ns or -ps suffix to indicate the units of time the property represents (as suggested by Rob Herring). Therefore, update the timing property names for the OMAP3430 SDP NAND and ONENAND devices. Signed-off-by: Jon Hunter jon

Re: [PATCH 3/3] ARM: dts: Add OMAP3430 SDP NOR flash memory binding

2013-04-07 Thread Jon Hunter
On 04/07/2013 08:17 PM, Jon Hunter wrote: Add device-tree node for the 128MB NOR on the OMAP3423-SDP board. Bugger ... it seems I have invented and new board. OMAP3423 SDP does not exist. Fixed below. Jon From 4f486b5dddc5d960d786504b4e3e97a28b63c1c0 Mon Sep 17 00:00:00 2001 From: Jon Hunter

Re: [PATCH 0/5] gpio/omap: 2nd batch of updates for v3.10

2013-04-05 Thread Jon Hunter
On 04/05/2013 01:35 AM, Santosh Shilimkar wrote: On Friday 05 April 2013 01:46 AM, Jon Hunter wrote: Main change is ensuring that the state of a gpio bank is restored when booting with device-tree. The rest of the patches are clean-ups and one optimisation. The patch modifying the *.dtsi

[PATCH] ARM: dts: OMAP4+: Correct L3 interrupts

2013-04-04 Thread Jon Hunter
by substracting 32. Cc: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: Jon Hunter jon-hun...@ti.com --- Please note that this problem is observed in Benoit's for_3.10/dts branch [1]. [1] http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git arch/arm/boot/dts/omap4.dtsi |4

[PATCH 0/5] gpio/omap: 2nd batch of updates for v3.10

2013-04-04 Thread Jon Hunter
correctly as these boards use a GPIO with the ethernet chips. Also checked /proc/interrupts to ensure GPIO interrupt counts are incrementing as expected. [1] http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git Jon Hunter (4): gpio/omap: free irq domain in probe() failure paths

[PATCH 1/5] gpio/omap: free irq domain in probe() failure paths

2013-04-04 Thread Jon Hunter
Currently the IRQ domain is not freed once allocated, in the case where omap_gpio_probe() fails. Therefore, ensure we free the domain if the probe does fail. Furthermore, the local variable ret is not needed and so remove this. Signed-off-by: Jon Hunter jon-hun...@ti.com --- drivers/gpio/gpio

[PATCH 2/5] gpio/omap: remove extra context restores in *_runtime_resume()

2013-04-04 Thread Jon Hunter
configured as level-triggered since only edge-triggered gpios can generate wakeup events. Therefore, the old context restores of the same registers present later in the code is not needed any more. Remove them. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Signed-off-by: Jon Hunter jon-hun

[PATCH 4/5] gpio/omap: force restore if context loss is not detectable

2013-04-04 Thread Jon Hunter
state. Signed-off-by: Jon Hunter jon-hun...@ti.com --- .../devicetree/bindings/gpio/gpio-omap.txt |7 -- drivers/gpio/gpio-omap.c | 25 +--- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH 3/5] gpio/omap: optimise interrupt service routine

2013-04-04 Thread Jon Hunter
of the first set bit, to find all the set bits. This optimisation was suggested-by and developed in collaboration with Felipe Balbi. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Jon Hunter jon-hun...@ti.com --- drivers/gpio/gpio-omap.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH 5/5] ARM: dts: OMAP2+: Identify GPIO banks that are always powered

2013-04-04 Thread Jon Hunter
Add the ti,gpio-always-on property to the appropriate GPIO banks to indicate which banks are always powered and will never lose logic state. Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Jon Hunter jon-hun...@ti.com --- arch/arm/boot/dts/omap2420.dtsi |4 arch/arm/boot/dts/omap2430

Re: [PATCH 5/5] ARM: dts: OMAP2+: Identify GPIO banks that are always powered

2013-04-04 Thread Jon Hunter
On 04/04/2013 03:35 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130404 13:21]: Add the ti,gpio-always-on property to the appropriate GPIO banks to indicate which banks are always powered and will never lose logic state. This patch should be queued by Benoit as this will likely

Re: [GIT PULL] ARM: OMAP2+: GPMC updates

2013-04-03 Thread Jon Hunter
On 04/03/2013 04:40 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130402 10:00]: The following changes since commit dca3a783400a18e2bf4503b1d4a85c4d0ca1a7e4: Merge commit '31d9adca82ce65e5c99d045b5fd917c702b6fce3' into tmp (2013-04-01 14:33:50 -0500) are available in the git

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-04-02 Thread Jon Hunter
On 04/02/2013 10:55 AM, Christoph Fritz wrote: On Mon, 2013-04-01 at 22:05 +0200, Javier Martinez Canillas wrote: As a quick-fix (hack) I wrote directly to the registers in gpio_probe() to enable GPIO banks. I now geht this: [0.214630] omap_gpio_probe, 1133, CM_CLKSEL_PER 0x48005040:

[GIT PULL] ARM: OMAP2+: GPMC updates

2013-04-02 Thread Jon Hunter
creation fails ARM: OMAP2+: rename gpmc_probe_nor_child() to gpmc_probe_generic_child() ARM: OMAP2+: Add GPMC DT support for Ethernet child nodes Jon Hunter (17): ARM: OMAP2+: Simplify code configuring ONENAND devices ARM: OMAP2+: Add variable to store number of GPMC waitpins

Re: [PATCH V3 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-04-01 Thread Jon Hunter
Vinod, On 03/20/2013 11:36 AM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130319 09:08]: Vinod, Tony, Benoit, On 02/26/2013 12:27 PM, Jon Hunter wrote: If the device-tree blob is present during boot, then register the SDMA controller with the device-tree DMA driver so that we can

[GIT PULL] ARM: OMAP2+: System timer updates

2013-04-01 Thread Jon Hunter
) from RMK's clean-up branch and commit 6bb27d7 (ARM: delete struct sys_timer) Jon Hunter (7): ARM: OMAP2+: Display correct system timer name ARM: OMAP2+: Remove hard-coded test on timer ID ARM: OMAP2+: Simplify system

Re: OK to use commit 71856843 as base for further omap clean up?

2013-03-25 Thread Jon Hunter
Hi Russell, On 03/19/2013 12:59 PM, Tony Lindgren wrote: Hi Russell, Can we use your commit 71856843 (ARM: OMAP: use consistent error checking) as an immutable base for further omap dmtimer and gpmc work? I saw that you updated your clean-up branch. Ok to use the below commit [1] as a base

Re: [PATCH] mach_omap2: use PTR_RET instead of IS_ERR + PTR_ERR

2013-03-22 Thread Jon Hunter
On 03/22/2013 11:36 AM, Russell King - ARM Linux wrote: On Wed, Mar 20, 2013 at 01:28:47PM -0500, Jon Hunter wrote: Sorry I am now not sure I follow you here. Someone just pointed out to me that PTR_RET() is defined as ... static inline int __must_check PTR_RET(const void *ptr

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-03-22 Thread Jon Hunter
On 03/22/2013 10:33 AM, Stephen Warren wrote: On 03/22/2013 02:10 AM, Linus Walleij wrote: On Fri, Mar 15, 2013 at 12:21 PM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 159f5c5..f5feb43 100644 ---

Re: [PATCH] drivers: video: omap2: dss: Use PTR_RET function

2013-03-20 Thread Jon Hunter
On 03/20/2013 06:56 AM, Tomi Valkeinen wrote: On 2013-03-19 10:03, Alexandru Gheorghiu wrote: Use PTR_RET function instead of IS_ERR and PTR_ERR. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu gheorghiuan...@gmail.com --- drivers/video/omap2/dss/core.c |5 + 1

Re: [PATCH] drivers: video: omap2: dss: Use PTR_RET function

2013-03-20 Thread Jon Hunter
On 03/20/2013 11:59 AM, Tomi Valkeinen wrote: On 2013-03-20 17:44, Jon Hunter wrote: On 03/20/2013 06:56 AM, Tomi Valkeinen wrote: On 2013-03-19 10:03, Alexandru Gheorghiu wrote: Use PTR_RET function instead of IS_ERR and PTR_ERR. Patch found using coccinelle. Signed-off-by: Alexandru

Re: [PATCH] drivers: video: omap2: dss: Use PTR_RET function

2013-03-20 Thread Jon Hunter
On 03/20/2013 01:02 PM, Jon Hunter wrote: On 03/20/2013 11:59 AM, Tomi Valkeinen wrote: On 2013-03-20 17:44, Jon Hunter wrote: On 03/20/2013 06:56 AM, Tomi Valkeinen wrote: On 2013-03-19 10:03, Alexandru Gheorghiu wrote: Use PTR_RET function instead of IS_ERR and PTR_ERR. Patch found

Re: [PATCH] mach_omap2: use PTR_RET instead of IS_ERR + PTR_ERR

2013-03-20 Thread Jon Hunter
On 03/12/2013 06:05 AM, Russell King - ARM Linux wrote: On Tue, Mar 12, 2013 at 09:58:29AM +0200, Silviu-Mihai Popescu wrote: This uses PTR_RET instead of IS_ERR and PTR_ERR in order to increase readability. Signed-off-by: Silviu-Mihai Popescu silviupopescu1...@gmail.com ---

  1   2   3   4   5   6   7   8   9   10   >