Re: [PATCH 01/13] Revert ARM: OMAP: Mask interrupts when disabling interrupts, v2

2009-05-22 Thread Kim Kyuwon
On Fri, May 22, 2009 at 11:54 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Kim Kyuwon q1@samsung.com writes: Kevin Hilman wrote: This reverts commit 5461af5af5c6a7fee78978aafe720541bf3a2f55. Adding a disable hook to the irq_chip is not the way to fix the problem being addressed

Re: [PATCH 01/13] Revert ARM: OMAP: Mask interrupts when disabling interrupts, v2

2009-05-22 Thread Kim Kyuwon
On Sat, May 23, 2009 at 3:16 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Kim Kyuwon chamm...@gmail.com writes: On Fri, May 22, 2009 at 11:54 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Kim Kyuwon q1@samsung.com writes: Kevin Hilman wrote: This reverts commit

Re: [PATCH 01/13] Revert ARM: OMAP: Mask interrupts when disabling interrupts, v2

2009-05-22 Thread Kim Kyuwon
On Sat, May 23, 2009 at 8:22 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, May 22, 2009 at 07:54:32AM -0700, Kevin Hilman wrote: But the implemenation of that should not hold up this revert because this patch breaks *all* wakeups since the PRCM interrupt itself is disabled

Re: [PATCH 01/13] Revert ARM: OMAP: Mask interrupts when disabling interrupts, v2

2009-05-21 Thread Kim Kyuwon
Kevin Hilman wrote: This reverts commit 5461af5af5c6a7fee78978aafe720541bf3a2f55. Adding a disable hook to the irq_chip is not the way to fix the problem being addressed by this patch. Instead, we need to fix support for [enable|disable]_irq_wake(). Agree with you if we can use

[PATCH] OMAP: UART: don't initialize membase and mapbase when its port is not enabled

2009-05-14 Thread Kim Kyuwon
88fc1f0872fd2c6ac42501027e5bf69156cce37f Mon Sep 17 00:00:00 2001 From: Kim Kyuwon q1@samsung.com Date: Thu, 14 May 2009 17:05:35 +0900 Subject: [PATCH] OMAP: UART: don't initialize membase and mapbase when its port is not enabled If membase and mapbase are zero, its uart port which is registered to serial8250(i.e

Re: OMAP3: PM: Add the wakeup source driver, v4

2009-05-14 Thread Kim Kyuwon
Kevin Hilman writes: Kim Kyuwon chamm...@gmail.com writes: Hi Kevin, Could you please review this fourth version of OMAP wakeup source driver? Yes. I'm working through my backlog of PM branch submissions this week. I've been focusing on getting some of the PM branch reworked and rebased

Re: OMAP3: PM: Add the wakeup source driver, v4

2009-05-13 Thread Kim Kyuwon
Hi Kevin, Could you please review this fourth version of OMAP wakeup source driver? Regards, Kyuwon. On Tue, May 5, 2009 at 6:13 PM, Kim Kyuwon q1@samsung.com wrote: Sometimes, it is necessary to find out what does wake up my board from suspend?. Notifying wake-up source feature may

Re: PM: 4 Problems in OMAP3430 DVFS (SmartReflex, Cpufreq)

2009-05-07 Thread Kim Kyuwon
Hi Kevin, Tony, Paul and other experts. Woodruff, Richard wrote: From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Thursday, April 23, 2009 3:53 AM To: Woodruff, Richard 4. Current PM code didn't enable the maximum clock (i.e. CPU: 600Mhz) according to the comment as below: /* Avoid

[PATCH] rtc: rtc-twl4030 don't mask alarm interrupts on suspend

2009-05-06 Thread Kim Kyuwon
Hi All, This patch was originally sent to linux-omap mailing list. (Please refer to http://markmail.org/thread/o643d7w224zo3i7n) David Brownell said, if I've tested this: Acked-by: David Brownell dbrown...@users.sourceforge.net Of course, I've tested. Regards, Kyuwon -- From: Kim Kyuwon q1

Re: [PATCH] Fix the size of twl4030 script

2009-05-06 Thread Kim Kyuwon
Hi All, I sent this patch about 1 month ago. Can anybody check I'm sending correct patch? Thanks you! Kyuwon. 2009/4/10 Kim Kyuwon chamm...@gmail.com: The array size of wrst_seq is ARRAY_SIZE(wrst_seq) Signed-off-by: Kim Kyuwon q1@samsung.com --- arch/arm/mach-omap2/board-3430sdp.c

Re: [PATCH] PM: suspend_device_irqs(): don't disable wakeup IRQs

2009-05-06 Thread Kim Kyuwon
2009/5/7 Arve Hjønnevåg a...@android.com: 2009/5/6 Kim Kyuwon chamm...@gmail.com: 2009/5/7 Arve Hjønnevåg a...@android.com: On Wed, May 6, 2009 at 5:16 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Rafael J. Wysocki r...@sisk.pl writes: On Wednesday 06 May 2009, Kevin Hilman wrote

OMAP3: PM: Add the wakeup source driver, v4

2009-05-05 Thread Kim Kyuwon
System type-TI OMAP implementations menu. Signed-off-by: Kim Kyuwon q1@samsung.com --- arch/arm/mach-omap2/Makefile |1 + arch/arm/mach-omap2/irq.c | 21 ++- arch/arm/mach-omap2/omapdev-common.h |3 + arch/arm/mach-omap2/omapdev3xxx.h | 63

Re: [PATCH] OMAP3: PM: Add the wakeup source driver, v3

2009-05-05 Thread Kim Kyuwon
On Thu, Apr 30, 2009 at 11:21 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Also, I still think the WKST register reading should be done in the PRCM interrupt handler. In your previous attempt, you were seeing a bunch of non-device wakeup related interrupts. Can you try again with the

Re: [PATCH] OMAP3: PM: Add the wakeup source driver, v3

2009-04-30 Thread Kim Kyuwon
Hi Kevin, Thank you for showing steady interest in this driver. On Tue, Apr 21, 2009 at 9:15 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Hi Kyuwon, While I still like the concept of this driver, I'm still not quite happy about how it is implemented for various reasons. Most of which

Question about OABI_COMPAT feature in do_signal() function

2009-04-28 Thread Kim Kyuwon
Hello Russell, It's an honor to mail you. I'm writing this mail to ask you about the OABI_COMPAT feature in do_signal() function. After freezing and thawing user processes for Suspend-To-Ram, I found that some user processes(e.g. daemon processes) make prefetch abort continuously. And finally, I

PM: 4 Problems in OMAP3430 DVFS (SmartReflex, Cpufreq)

2009-04-22 Thread Kim Kyuwon
Hi Kevin, Rajendra, and other OMAP experts, Lately I'm digging up OMAP3430-DVFS and I found 4 problems on top of PM branch. 1. Setting CPUFreq Governor to 'ondemand' turns off display system. I think the following codes in set_opp() of rescource34xx.c makes this problem. /*

Re: [PATCH] OMAP3: PM: Add the wakeup source driver, v3

2009-04-13 Thread Kim Kyuwon
Hi Kevin, Have you had chance to review this new version of wakeup driver? :) Regards, Kyuwon On Fri, Apr 3, 2009 at 7:43 PM, Kim Kyuwon chamm...@gmail.com wrote: Sometimes, it is necessary to find out what does wake up my board from suspend?. Notifying wake-up source feature may be used

Re: [PATCH] OMAP3: PM: Add the wakeup source driver, v2

2009-04-05 Thread Kim Kyuwon
On Sun, Apr 5, 2009 at 5:22 AM, Paul Walmsley p...@pwsan.com wrote: On Sat, 4 Apr 2009, Kim Kyuwon wrote: No, I haven't configured GPTIMER12. And actually OMAP3430_ST_GPT12_MASK bit is reserved on OMAP3430 ES.1. This is another problem that I have to fix. Please see the OMAP34xx

Re: [PATCH] OMAP3: PM: Add the wakeup source driver, v2

2009-04-03 Thread Kim Kyuwon
Eletronics + * + * Author: Kim Kyuwon q1@samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + */ + +#ifndef _WAKE_H_ +#define

Re: [PATCH] OMAP3: PM: Add the wakeup source driver, v2

2009-04-03 Thread Kim Kyuwon
Hi Kevin, Thanks for your prompt answer. On Sat, Apr 4, 2009 at 1:12 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Kim Kyuwon chamm...@gmail.com writes: + +void omap3_get_wakeup_status(struct pm_wakeup_status **pm_wkst) +{ +     *pm_wkst = omap3_pm_wkst; +} + Can you rename

Re: [PATCH] OMAP3: PM: Add the wakeup source driver, v2

2009-04-03 Thread Kim Kyuwon
On Sat, Apr 4, 2009 at 9:20 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Kim Kyuwon chamm...@gmail.com writes: Hi Kevin, Thanks for your prompt answer. On Sat, Apr 4, 2009 at 1:12 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Kim Kyuwon chamm...@gmail.com writes: + +void

Re: [PATCH] OMAP3 clock: Access only available clock bits

2009-03-22 Thread Kim Kyuwon
Hi Paul, On Sat, Mar 21, 2009 at 6:48 AM, Paul Walmsley p...@pwsan.com wrote: Hello Kyuwon, On Fri, 20 Mar 2009, Kim Kyuwon wrote: I found a problem on PM Branch with OMAP3430 ES3.1 Board when enabling OMAP_RESET_CLOCKS feature. In clk_disable_unsed() function, as soon as sad2d_ick

[PATCH 0/2] OMAP3: PM: two fixes on PM branch

2009-03-20 Thread Kim Kyuwon
, Kim Kyuwon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] OMAP3: PM: Fix compile error with 'CONFIG_OMAP_PM_SRF=y'

2009-03-20 Thread Kim Kyuwon
1 Signed-off-by: Kim Kyuwon q1@samsung.com --- arch/arm/mach-omap2/pm.c |1 + arch/arm/mach-omap2/resource34xx.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index e64a80e..c0f1ae8 100644 --- a/arch

[PATCH] OMAP3 clock: Access only available clock bits

2009-03-19 Thread Kim Kyuwon
() function. Especially, this patch prevents using the sad2d_ick which doesn't exist in OMAP3430 ES2+. Signed-off-by: Kim Kyuwon q1@samsung.com --- arch/arm/mach-omap2/clock34xx.h |2 +- arch/arm/plat-omap/clock.c | 10 ++ 2 files changed, 11 insertions(+), 1 deletions

Re: [PATCH 1/1] OMAP3: PM: Add the wakeup source driver

2009-03-18 Thread Kim Kyuwon
On Wed, Mar 18, 2009 at 6:47 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Kim Kyuwon chamm...@gmail.com writes: Sometimes, it is necessary to find out what does wake up my board?. Notifying wake-up source feature may be used to blame unexpected wake-up events which increase power

[PATCH] OMAP3: PM: Add the wakeup source driver, v2

2009-03-18 Thread Kim Kyuwon
, .dev= { .platform_data = boardname_wake_data, }, }; The patch adds Kconfig options OMAP34xx wakeup source support under System type-TI OMAP implementations menu. Signed-off-by: Kim Kyuwon q1@samsung.com --- arch/arm/mach-omap2/Makefile

[PATCH 0/3] OMAP3: PM: three fixes for OMAP3 CPU IDLE in PM branch

2009-03-17 Thread Kim Kyuwon
Hi, all I'm sending three small patches for OMAP3 CPU IDLE arch/arm/mach-omap2/cpuidle34xx.c |6 -- arch/arm/mach-omap2/pm34xx.c |5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) Your comments appreciated. Regards, Kim Kyuwon -- To unsubscribe from this list: send

[PATCH 1/3] OMAP3: PM: include 'mach/irqs.h'

2009-03-17 Thread Kim Kyuwon
-omap/include/mach/irqs.h' Signed-off-by: Kim Kyuwon q1@samsung.com --- arch/arm/mach-omap2/cpuidle34xx.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c index 62fbb2e..5e50c46 100644 --- a/arch/arm

[PATCH 2/3] OMAP3: PM: Remove double assignments of mpu_pd, core_pd

2009-03-17 Thread Kim Kyuwon
mpu_pd, core_pd is already assigned at the beginning of the omap3_idle_init() function. Signed-off-by: Kim Kyuwon q1@samsung.com --- arch/arm/mach-omap2/cpuidle34xx.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach

[PATCH 3/3] OMAP3: PM: invoke omap_sram_idle() only when sleep_while_idle is enabled

2009-03-17 Thread Kim Kyuwon
-off-by: Kim Kyuwon q1@samsung.com --- arch/arm/mach-omap2/cpuidle34xx.c |3 +++ arch/arm/mach-omap2/pm34xx.c |5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c index 630108c..1623c2f 100644

Re: [PATCH 3/3] OMAP3: PM: invoke omap_sram_idle() only when sleep_while_idle is enabled

2009-03-17 Thread Kim Kyuwon
On Tue, Mar 17, 2009 at 11:53 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Kim Kyuwon chamm...@gmail.com writes: If MPU goes to WFI in the idle thread, execution time becomes a bit slow and the JTAG Debugger doesn't work. This patch is needed for urgent works(e.g. booting and launching

Re: About two patches that I sent recently.

2009-03-15 Thread Kim Kyuwon
Hi, Kevin On Tue, Mar 10, 2009 at 2:21 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Kim Kyuwon chamm...@gmail.com writes: Hi, Kevin Hilman. I'm sending this mail to tell you a few things about two recent fetches that I sent. 1. [OMAP: GPIO: Remove enable_irq_wake

Re: Setting individual GPIO registers

2009-03-04 Thread Kim Kyuwon
Hi, On Thu, Mar 5, 2009 at 12:41 AM, Premi, Sanjeev pr...@ti.com wrote: I am trying to get the wakeup event from touchscreen on omap3evm to bring the EVM out of suspend state. For my private testing, I have been updating individual registers bits in the GPIO registers from function

[PATCH 0/1] Regarding enable_irq_wake() and disable_irq_wake() functions

2009-03-02 Thread Kim Kyuwon
Hi, The following patch was made to remove waning message below. [ 755.708251] WARNING: at kernel/irq/manage.c:304 set_irq_wake+0x80/0xe4() [ 755.708251] Unbalanced IRQ 29 wake disable [ 755.708251] Modules linked in: [ 755.708282] [c002efec] (dump_stack+0x0/0x14) from [c0057718]

[PATCH 1/1] OMAP: GPIO: Remove enable_irq_wake() and disable_irq_wake() in _set_gpio_wakeup() function

2009-03-02 Thread Kim Kyuwon
wakeup can be done by enable_irq() and disable_irq(). Signed-off-by: Kim Kyuwon q1@samsung.com --- arch/arm/plat-omap/gpio.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c index f856a90..798a8cd 100644

Re: [PATCH 0/1] Regarding enable_irq_wake() and disable_irq_wake() functions

2009-03-02 Thread Kim Kyuwon
On Tue, Mar 3, 2009 at 11:02 AM, Kim Kyuwon chamm...@gmail.com wrote: Hi, But this was not the real problem. Current enable_irq_wake and disable_irq_wake isn't working correctly since the set_wake field of omap_irq_chip is NULL. Of course, thanks to Tony Lindgren's works, GPIO wake-up

[RESEND][PATCH 1/2] usb: musb: fix the possible panic while resuming

2009-02-26 Thread Kim Kyuwon
While waking up, musb can cause a kernel panic. This patch is fixing it by enabling the clock in the resume_early method. Signed-off-by: Kim Kyuwon q1@samsung.com --- drivers/usb/musb/musb_core.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/musb

[PATCH 0/2] MUSB and TWL4030-USB fixes

2009-02-25 Thread Kim Kyuwon
Hi, These fixes are the replacement of [ARM: OMAP: Disable USB interrupt in the musb_resume() function] and trying to following David Brownell's recommendation. Thanks, especially David. -- Kyuwon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

[PATCH 1/2] usb: musb: fix the possible panic while resuming

2009-02-25 Thread Kim Kyuwon
From: Kim Kyuwon chamm...@gmail.com While waking up, musb can cause a kernel panic. This patch is fixing it by enabling the clock in the resume_early method. Signed-off-by: Kim Kyuwon chamm...@gmail.com --- drivers/usb/musb/musb_core.c | 21 +++-- 1 files changed, 7 insertions

[PATCH 2/2] twl: usb: Add the resume() and suspend() methods to twl4030-usb.c

2009-02-25 Thread Kim Kyuwon
the feature that a board specific file can determines that TWL4030 supplies the USB power or not in the low power mode. Disabling the USB power may save the power consumption. Signed-off-by: Minkyu Kang mk7.k...@samsung.com Signed-off-by: Kim Kyuwon chamm...@gmail.com --- drivers/usb/otg/twl4030-usb.c

Re: [PATCH 1/2] usb: musb: fix the possible panic while resuming

2009-02-25 Thread Kim Kyuwon
On Thu, Feb 26, 2009 at 9:13 AM, Felipe Balbi m...@felipebalbi.com wrote: On Wed, Feb 25, 2009 at 08:53:00PM +0900, Kim Kyuwon wrote: From: Kim Kyuwon chamm...@gmail.com While waking up, musb can cause a kernel panic. This patch is fixing it by enabling the clock in the resume_early method

Re: [PATCH 1/2] usb: musb: fix the possible panic while resuming

2009-02-25 Thread Kim Kyuwon
Hi, On Thu, Feb 26, 2009 at 3:37 PM, Gadiyar, Anand gadi...@ti.com wrote: snip Now I know that, in addition to HSUSB_MC_NINT disabled by the previous patch [ARM: OMAP: Disable USB interrupt in the musb_resume() function], USBTLL_SWAKEUP and USBHOST_SWAKEUP can be also wake-up source events

Re: [PATCH] ARM: OMAP: Disable USB interrupt in the musb_resume() function

2009-02-22 Thread Kim Kyuwon
Hi, On Sat, Feb 21, 2009 at 11:30 AM, David Brownell davi...@pacbell.net wrote: On Tuesday 03 February 2009, Kim Kyuwon wrote: USB should be suspended with interrupt disabled[1]. That text means that the sysdev.suspend() method is called with IRQs disabled ... just like suspend_late

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-22 Thread Kim Kyuwon
Hi, On Sat, Feb 21, 2009 at 6:11 AM, David Brownell davi...@pacbell.net wrote: On Friday 20 February 2009, Kim Kyuwon wrote: +static void omap_hsmmc_init(struct mmc_omap_host *host) +{ + u32 hctl, capa, value; + + /* Only MMC1 supports 3.0V */ + if (host-id

[PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-20 Thread Kim Kyuwon
*/ + ret = mmc_resume_host(host-mmc); + if (ret == 0) + host-suspended = 0; + return ret; clk_en_err: -- 1.5.2.5 -- Kim Kyuwon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes

2009-02-09 Thread Kim Kyuwon
, AF5_34XX_GPIO142, -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Kim Kyuwon -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] ARM: OMAP: Disable USB interrupt in the musb_resume() function

2009-02-03 Thread Kim Kyuwon
On Wed, Feb 4, 2009 at 7:28 AM, Felipe Balbi m...@felipebalbi.com wrote: On Tue, Feb 03, 2009 at 12:42:36PM -0800, Tony Lindgren wrote: * Kim Kyuwon chamm...@gmail.com [090131 00:22]: USB should be suspended with interrupt disabled[1]. If USB is suspended with interrupt enabled

[PATCH] ARM: OMAP: Disable USB interrupt in the musb_resume() function

2009-02-03 Thread Kim Kyuwon
, even though USB controller is still not resumed! All devices are resumed after the device_resume() is called. [1] /Documentation/power/devices.txt: 412 line Signed-off-by: Kim Kyuwon chamm...@gmail.com --- drivers/usb/musb/musb_core.c |4 1 files changed, 4 insertions(+), 0 deletions

[PATCH] ARM: OMAP: Disable USB interrupt in the musb_resume() function

2009-01-31 Thread Kim Kyuwon
, even though USB controller is still not resumed! All devices are resumed after the device_resume() is called. [1] /Documentation/power/devices.txt: 412 line Signed-off-by: Kim Kyuwon chamm...@gmail.com --- drivers/usb/musb/musb_core.c |4 1 files changed, 4 insertions(+), 0 deletions

Fwd: Questions about masking interrupts when disabling interrupts

2009-01-07 Thread Kim Kyuwon
My Gmail account has some problems I send again. -- Forwarded message -- From: Kim Kyuwon chamm...@gmail.com Date: 2009/1/8 Subject: Re: Questions about masking interrupts when disabling interrupts To: Tony Lindgren t...@atomide.com Cc: linux-omap@vger.kernel.org, 박경민 kyungmin.p