On 10/20/2015 05:18 PM, Marc Kleine-Budde wrote:
> On 10/20/2015 05:09 PM, Anton.Glukhov wrote:
>>>> It's OMAP3 based arch, but HECC is implemented only in AM3505 and AM3517
>>>> SoCs.
>>>> So, I'm confused about what's "name" should I
do you mean available? I know only that HECC appear in AM3505 and
> AM3517. Nowhere else.
Available on the market. Which one was produced first or was soldered
first to some PCB?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions|
On 10/20/2015 04:57 PM, Anton.Glukhov wrote:
> Hello Marc, Heiko!
> I'm sorry for the delay!
>
> On 19.10.2015 10:31, Marc Kleine-Budde wrote:
>> On 10/19/2015 09:27 AM, Heiko Schocher wrote:
>>>>> .../devicetree/bindings/net/can/ti_hecc-can.txt| 20 +++
ruct net_device *ndev = (struct net_device *)0;
> struct ti_hecc_priv *priv;
> - struct ti_hecc_platform_data *pdata;
> + const struct ti_hecc_platform_data *pdata;
> struct resource *mem, *irq;
> void __iomem *addr;
> int err = -ENODEV;
>
> - pdata =
ti,hecc_ram_offset = <0x3000>;
>>> + ti,hecc_mbx_offset = <0x2000>;
>>> + ti,hecc_int_line = <0>;
>>> + ti,hecc_version = <1>;
>>
>> Versioning in the OF world is done via the compatible. Are the offsets a
>
On 07/09/2015 08:34 PM, Marc Kleine-Budde wrote:
On 07/07/2015 04:27 PM, Roger Quadros wrote:
Driver core sets default pinmux on on probe and CAN driver
sets sleep pinmux during register. This causes a small window
where the CAN pins are in default state with the DCAN module
being disabled
this glitch is
avoided. Add a new active state that is used by the driver
when CAN is actually active.
Who is taking care of this patch? I'm applying 1/2 (v2) to linux-can,
should I take this patch, too?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux
= pinctrl_get_select(priv-device, active);
+if (!IS_ERR(p))
+pinctrl_put(p);
+else
+pinctrl_pm_select_default_state(priv-device);
+
Thanks. This part looks good to me now.
Is this an Acked-by?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde
with the DTS change in patch 2.
Of course.
Maybe if Tony can Ack the second patch then both should be applicable
on v4.0+ for stable.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West
))
+ pinctrl_select_state(priv-device-pins-p, s);
+ else
+ pinctrl_pm_select_default_state(dev-dev.parent);
+ }
+#endif
return 0;
}
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions
thoughts
device-pins are not defined if CONFIG_PINCTRL is not set.
so we can't remove the #ifdef.
Too bad :(
okay - should I add stable@v.k.o on Cc?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924
of DONE bit to later when we set the START bit.
There we are sure that START bit is changed from 0 to 1 so the write of
1 to already set DONE bit will happen.
Signed-off-by: Roger Quadros rog...@ti.com
Applied to linux-can.
Thanks, Marc
--
Pengutronix e.K. | Marc Kleine-Budde
. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
:
Acked-by: Marc Kleine-Budde m...@pengutronix.de
I've send a pull request with the CAN driver changes to David Miller
yesterday, the code is supposed to hit mainline in v3.19.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone
On 11/17/2014 12:17 PM, Roger Quadros wrote:
I'll send an updated series.
Looks better. Thanks.
Can you make a quick test with the new series on real hardware.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49
*/ },
};
MODULE_DEVICE_TABLE(of, c_can_of_table);
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http
On 11/17/2014 03:19 PM, Roger Quadros wrote:
On 11/17/2014 02:31 PM, Roger Quadros wrote:
On 11/17/2014 02:12 PM, Marc Kleine-Budde wrote:
On 11/17/2014 01:09 PM, Roger Quadros wrote:
AM4372 SoC has 2 DCAN modules. Add compatible id and
raminit driver data for it. The driver data is same
For the whole series or just this patch?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http
. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
,
+ .raminit_done_bits = dra7_raminit_done_bits,
+ .raminit_pulse = true,
+};
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht
':
drivers/net/can/c_can/c_can_platform.c:115:7: warning: 'ctrl' is used
uninitialized in this function [-Wuninitialized]
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund
an updated series.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de
Picking up Roger's work:
Changes since v7:
- combined raminit start and done bit into a struct (3/8, 7/8, 8/8)
- constified struct c_can_driver_data (2/8, 7/8, 8/8)
- silenced compiler warning in c_can_hw_raminit_{wait,}_syscon (4/8)
- use platform_get_device_id in probe() instead of open coding
an error message.
Signed-off-by: Roger Quadros rog...@ti.com
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
drivers/net/can/c_can/c_can_platform.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/can/c_can/c_can_platform.c
b/drivers/net/can
From: Roger Quadros rog...@ti.com
Some SoCs e.g. (TI DRA7xx) need a START pulse to start the
RAMINIT sequence i.e. START bit must be set and cleared before
checking for the DONE bit status.
Signed-off-by: Roger Quadros rog...@ti.com
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
From: Roger Quadros rog...@ti.com
AM3352 SoC has 2 DCAN modules. Add compatible id and
raminit driver data for am3352 DCAN.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Wolfram Sang w...@the-dreams.de
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
Documentation/devicetree
-by: Roger Quadros rog...@ti.com
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
drivers/net/can/c_can/c_can.h | 4 +++
drivers/net/can/c_can/c_can_platform.c | 52 +++---
2 files changed, 33 insertions(+), 23 deletions(-)
diff --git a/drivers/net/can
to specify the RAMINIT
register location and START/DONE bit position and use the
syscon/regmap framework to access the register.
Signed-off-by: Roger Quadros rog...@ti.com
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
.../devicetree/bindings/net/can/c_can.txt | 3 +
drivers/net/can
on probe and use the DEFAULT pin state on CAN up and back to the
SLEEP pin state on CAN down.
Signed-off-by: Roger Quadros rog...@ti.com
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
drivers/net/can/c_can/c_can.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/net
From: Roger Quadros rog...@ti.com
Some platforms (e.g. TI) need special RAMINIT register handling.
Provide a way to store RAMINIT register description in driver data.
Signed-off-by: Roger Quadros rog...@ti.com
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
drivers/net/can/c_can
From: Roger Quadros rog...@ti.com
DRA7 SoC has 2 CAN IPs. Provide compatible IDs and RAMINIT
register data for both.
Signed-off-by: Roger Quadros rog...@ti.com
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
Documentation/devicetree/bindings/net/can/c_can.txt | 1 +
drivers/net/can
) {
+ drvdata = (struct c_can_driver_data *)
+pdev-id_entry-driver_data;
^^
I've changes this to platform_get_device_id() while aplying.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial
/c_can_platform.c
+++ b/drivers/net/can/c_can/c_can_platform.c
@@ -250,6 +250,7 @@ static int c_can_plat_probe(struct platform_device *pdev)
}
priv = netdev_priv(dev);
+
Dropped this hunk while applying.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde
in the platform driver an use the new ones.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http
-dev,
+ couldn't get syscon regmap for
RAMINIT\n);
+ goto exit_free_device;
+ }
...and maybe remove this error message completely.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde
)
}
priv = netdev_priv(dev);
+ priv-pinctrl = pinctrl;
switch (drvdata-id) {
case BOSCH_C_CAN:
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund
then (I'll give your email to $CUSTOMERS complaining ;) ), this
whole series will go into 3.19.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917
IRQ_TYPE_LEVEL_HIGH;
+ status = disabled;
+ };
};
};
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917
On 11/13/2014 03:40 PM, Roger Quadros wrote:
On 11/13/2014 04:07 PM, Marc Kleine-Budde wrote:
On 11/13/2014 01:22 PM, Roger Quadros wrote:
The SoC contains 2 DCAN modules. Add them.
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/am4372.dtsi | 22 ++
1
On 11/13/2014 03:49 PM, Roger Quadros wrote:
On 11/13/2014 04:44 PM, Marc Kleine-Budde wrote:
On 11/13/2014 03:40 PM, Roger Quadros wrote:
On 11/13/2014 04:07 PM, Marc Kleine-Budde wrote:
On 11/13/2014 01:22 PM, Roger Quadros wrote:
The SoC contains 2 DCAN modules. Add them.
Signed-off
dlc[C_CAN_MSG_OBJ_TX_NUM];
+ struct pinctrl *pinctrl;
};
struct net_device *alloc_c_can_dev(void);
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax
function.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
is used like this:
c_can_pinctrl_select_state(priv, PINCTRL_STATE_DEFAULT)
Otherwise looks god.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917
},
+ { .compatible = ti,dra7-d_can2, .data = dra7_dcan2_drvdata },
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, c_can_of_table);
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund
On 11/05/2014 02:36 PM, Roger Quadros wrote:
On 11/05/2014 03:30 PM, Marc Kleine-Budde wrote:
On 11/04/2014 11:21 AM, Roger Quadros wrote:
DRA7 SoC has 2 CAN IPs. Provide compatible IDs and RAMINIT
register data for both.
My understanding of the discussion with Wolfram was:
- We should put
On 10/01/2014 10:45 AM, Roger Quadros wrote:
On 09/30/2014 07:04 PM, Marc Kleine-Budde wrote:
On 09/30/2014 05:25 PM, Wolfram Sang wrote:
Yes, but syscon_regmap_lookup_by_phandle() doesn't need any support for
additional parameters. Have a look at:
drivers/net/ethernet/stmicro/stmmac/dwmac
On 10/01/2014 11:06 AM, Roger Quadros wrote:
On 10/01/2014 11:47 AM, Marc Kleine-Budde wrote:
On 10/01/2014 10:45 AM, Roger Quadros wrote:
On 09/30/2014 07:04 PM, Marc Kleine-Budde wrote:
On 09/30/2014 05:25 PM, Wolfram Sang wrote:
Yes, but syscon_regmap_lookup_by_phandle() doesn't need any
On 10/01/2014 12:12 PM, Roger Quadros wrote:
On 10/01/2014 01:01 PM, Marc Kleine-Budde wrote:
On 10/01/2014 11:06 AM, Roger Quadros wrote:
On 10/01/2014 11:47 AM, Marc Kleine-Budde wrote:
On 10/01/2014 10:45 AM, Roger Quadros wrote:
On 09/30/2014 07:04 PM, Marc Kleine-Budde wrote:
On 09/30
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description
On 10/01/2014 12:43 PM, Wolfram Sang wrote:
compatible = commodore,c64ultra, bosch,d_can;
\o/
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917
e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital
On 09/30/2014 04:02 PM, Roger Quadros wrote:
On 09/30/2014 04:45 PM, Marc Kleine-Budde wrote:
On 09/30/2014 03:26 PM, Wolfram Sang wrote:
On Tue, Sep 09, 2014 at 05:31:09PM +0300, Roger Quadros wrote:
Some TI SoCs like DRA7 have a RAMINIT register specification
different from the other AMxx
extensions later or something...
What do you think about putting the bit information in the
syscon-raminit phandle as additional arguments?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund
On 09/30/2014 04:49 PM, Wolfram Sang wrote:
On Tue, Sep 30, 2014 at 04:22:08PM +0200, Marc Kleine-Budde wrote:
On 09/30/2014 04:19 PM, Wolfram Sang wrote:
As just TI is using this out of band RAMINIT mechanism, should it be
ti,syscon or just syscon?
Yes, only TI uses this out-of-band
practice, is it? So I want to avoid this when switching
to syscon.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA
On 09/09/2014 04:39 PM, Roger Quadros wrote:
On 09/09/2014 05:34 PM, Marc Kleine-Budde wrote:
On 09/09/2014 04:31 PM, Roger Quadros wrote:
Pass the correct 'mask' and 'value' bits to c_can_hw_raminit_wait_ti().
They seem to have been swapped in the usage instances.
Can you split this fix
that
implements the raminit outside of the register space. So a ti, prefix
seems appropriate.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-
after the START bit is set. So add a timeout mechanism to
c_can_hw_raminit_wait_ti().
What should happen if the timeout occurs?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund
;
+ interrupts = GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH;
+ clocks = sys_clkin1;
+ status = disabled;
+ };
};
};
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924
On 09/09/2014 05:04 PM, Marc Kleine-Budde wrote:
On 09/09/2014 04:55 PM, Roger Quadros wrote:
The SoC supports 2 DCAN nodes. Add them.
I think you should put the device-tree ml for DT related patches on Cc.
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/dra7.dtsi | 30
this is not true anymore, is it?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http
+ 0x44e10644 0x4;
+ interrupts = GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH;
+ status = disabled;
+ };
};
};
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826
:)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
will bail out with -EPROBE_DEFER.
Is there a platform which fills out pdata.needs_vcc and
pdata.needs_reset? IMHO it makes no sense to add features for the non DT
case, if there isn't any user for it.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions
On 03/12/2013 03:12 PM, Roger Quadros wrote:
On 03/12/2013 01:54 PM, Marc Kleine-Budde wrote:
On 03/12/2013 12:24 PM, Roger Quadros wrote:
Add clk_rate parameter to platform data. If supplied, the
NOP phy driver will program the clock to that rate during probe.
Also add 2 flags, needs_vcc
On 03/12/2013 03:28 PM, Roger Quadros wrote:
On 03/12/2013 04:17 PM, Marc Kleine-Budde wrote:
On 03/12/2013 03:12 PM, Roger Quadros wrote:
On 03/12/2013 01:54 PM, Marc Kleine-Budde wrote:
On 03/12/2013 12:24 PM, Roger Quadros wrote:
Add clk_rate parameter to platform data. If supplied
On 03/12/2013 04:20 PM, Roger Quadros wrote:
On 03/12/2013 04:42 PM, Marc Kleine-Budde wrote:
On 03/12/2013 03:28 PM, Roger Quadros wrote:
On 03/12/2013 04:17 PM, Marc Kleine-Budde wrote:
On 03/12/2013 03:12 PM, Roger Quadros wrote:
On 03/12/2013 01:54 PM, Marc Kleine-Budde wrote:
On 03/12
data structure at all?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de
On 03/11/2013 09:40 AM, Roger Quadros wrote:
On 03/08/2013 05:45 PM, Marc Kleine-Budde wrote:
On 03/08/2013 11:46 AM, Marc Kleine-Budde wrote:
On 02/04/2013 04:58 PM, Roger Quadros wrote:
The PHY clock, clock rate, VCC regulator and RESET regulator
can now be provided via device tree
) of this patch you've
put both needs_* into the private data struct and the pdata, but it's
only used inside the probe function.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West
here? You should use
clk_get_rate() to get the frequency from the clock tree.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht
On 03/08/2013 11:46 AM, Marc Kleine-Budde wrote:
On 02/04/2013 04:58 PM, Roger Quadros wrote:
The PHY clock, clock rate, VCC regulator and RESET regulator
can now be provided via device tree.
Signed-off-by: Roger Quadros rog...@ti.com
---
.../devicetree/bindings/usb/usb-nop-xceiv.txt
.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
,
+ const char *phy_dev_name)
+{
+ return NULL;
The return value looks bogus.
Marc
+}
#endif
static inline int
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund
functions and add missing
module_put.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http
-by: AnilKumar Ch anilku...@ti.com
Acked-by: Marc Kleine-Budde m...@pengutronix.de
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht
On 11/21/2012 06:45 AM, AnilKumar, Chimata wrote:
On Tue, Nov 20, 2012 at 15:56:32, Marc Kleine-Budde wrote:
On 11/20/2012 11:23 AM, AnilKumar, Chimata wrote:
On Tue, Nov 20, 2012 at 15:43:04, Marc Kleine-Budde wrote:
On 11/14/2012 07:08 PM, AnilKumar Ch wrote:
Add a new address space/memory
, priv-raminit_ctrlreg);
I can add the changes while applying the patch.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim
;
+ }
+ priv-ram_init = c_can_hw_raminit;
break;
default:
ret = -EINVAL;
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917
under CPLD profile#1.
Signed-off-by: AnilKumar Ch anilku...@ti.com
[mkl: fix instance for non DT in probe, cleaned up raminit]
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
Hello,
compile time tested only - please test on real HW.
changes since v2
- rename member in c_can_priv
On 11/21/2012 11:07 AM, AnilKumar, Chimata wrote:
On Wed, Nov 21, 2012 at 15:01:22, Marc Kleine-Budde wrote:
From: AnilKumar Ch anilku...@ti.com
Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM,
which holds all the message objects during transmission or
receiving of data
memory resource to d_can node
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de
On 11/20/2012 11:23 AM, AnilKumar, Chimata wrote:
On Tue, Nov 20, 2012 at 15:43:04, Marc Kleine-Budde wrote:
On 11/14/2012 07:08 PM, AnilKumar Ch wrote:
Add a new address space/memory resource to d_can device tree node. D_CAN
RAM initialization is achieved through RAMINIT register which
;
break;
default:
ret = -EINVAL;
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht
nodes present in aliases node.
Signed-off-by: AnilKumar Ch anilku...@ti.com
Acked-by: Marc Kleine-Budde m...@pengutronix.de
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP
On 09/26/2012 11:20 AM, ABRAHAM, KISHON VIJAY wrote:
Hi,
On Mon, Sep 17, 2012 at 3:03 PM, Marc Kleine-Budde m...@pengutronix.de
wrote:
On 09/14/2012 03:06 PM, ABRAHAM, KISHON VIJAY wrote:
[...]
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
new file mode 100644
index
is **, perhaps sizeof(struct phy) is clearer.
But incorrect.
A proper struct will make the code more readable here, too.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax
should create the PHY by passing phy_descriptor that has
describes the PHY (label, type etc..) and ops like init, exit, suspend,
resume,
poweron, shutdown.
Cc: Felipe Balbi ba...@ti.com
Cc: Marc Kleine-Budde m...@pengutronix.de
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
I suggest
on beagle bone (AM335X), which has 2 phy's of same type.
Or is the plan to use generic phy framework instead ?
Yes, Kishon's patches look more generic than mine.
Marc
[2] https://patchwork.kernel.org/patch/1457801/
--
Pengutronix e.K. | Marc Kleine-Budde
,
+ u32 data)
+{
+ __raw_writel(data, addr + offset);
+}
+
#endif /* __DRIVERS_OMAP_USB_H */
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924
that you can use that
optional clock.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http
On 09/19/2012 04:42 PM, Felipe Balbi wrote:
On Wed, Sep 19, 2012 at 04:45:01PM +0200, Marc Kleine-Budde wrote:
On 09/19/2012 01:56 PM, Felipe Balbi wrote:
On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote:
usb_otg_ss_refclk960m is needed by usb2 phy present in omap5
);
+
+ return phy;
+}
+EXPORT_SYMBOL_GPL(devm_of_phy_get);
+
[...]
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht
)
+{
+ if (phy-desc-ops-shutdown)
+ phy-desc-ops-shutdown(phy-desc);
+}
+#endif /* __DRIVERS_PHY_H */
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49
, resource_size(mem));
- pm_runtime_disable(pdev-dev);
clk_put(priv-priv);
return 0;
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121
On 09/13/2012 09:24 AM, AnilKumar, Chimata wrote:
Marc,
On Wed, Sep 12, 2012 at 18:32:53, Marc Kleine-Budde wrote:
On 09/12/2012 02:48 PM, AnilKumar, Chimata wrote:
Hi Marc,
On Tue, Sep 04, 2012 at 12:57:18, Marc Kleine-Budde wrote:
On 09/04/2012 08:14 AM, AnilKumar, Chimata wrote:
Marc
. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
On 09/12/2012 02:48 PM, AnilKumar, Chimata wrote:
Hi Marc,
On Tue, Sep 04, 2012 at 12:57:18, Marc Kleine-Budde wrote:
On 09/04/2012 08:14 AM, AnilKumar, Chimata wrote:
Marc,
Thanks for the comments,
On Tue, Sep 04, 2012 at 01:31:35, Marc Kleine-Budde wrote:
On 09/03/2012 01:52 PM
On 09/06/2012 08:09 AM, AnilKumar, Chimata wrote:
On Thu, Sep 06, 2012 at 04:56:10, Tony Lindgren wrote:
* Marc Kleine-Budde m...@pengutronix.de [120905 06:55]:
On 09/05/2012 01:54 PM, Marc Kleine-Budde wrote:
On 09/05/2012 01:12 PM, AnilKumar Ch wrote:
Adds suspend/resume functionality
1 - 100 of 125 matches
Mail list logo
