[PATCH v4 1/2] backlight: Add TPS65217 WLED driver

2012-09-24 Thread Matthias Kaehlcke
with LCD3 cape This patch is based on the mfd branch (20120924) Changes since v3: * split in two patches, one for the driver another for adding the mfd subdevice * renamed variable on to is_enabled and changed type to boolean Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers

[PATCH v4 2/2] mfd: Add backlight as subdevice to the tps65217

2012-09-24 Thread Matthias Kaehlcke
mfd: Add backlight as subdevice to the tps65217 Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/mfd/tps65217.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c index a95e942..3fb32e6 100644 --- a/drivers/mfd/tps65217.c

Re: [PATCH v2] backlight: Add TPS65217 WLED driver

2012-09-18 Thread Matthias Kaehlcke
Hi Samuel, El Mon, Sep 17, 2012 at 01:09:36AM +0200 Samuel Ortiz ha dit: On Thu, Aug 09, 2012 at 10:42:31PM +0200, Matthias Kaehlcke wrote: The TPS65217 chip contains a boost converter and current sinks which can be used to drive LEDs for use as backlights. Expose this functionality via

Re: [PATCH v3] backlight: Add TPS65217 WLED driver

2012-08-23 Thread Matthias Kaehlcke
; + struct backlight_device *bl; + int on; Can you use Boolean here? Change the name as well, something like bool is_enabled? ok + pdata-fdim = TPS65217_BL_FDIM_200HZ; Why 200 by default? it's the default value in the register after reset best regards -- Matthias Kaehlcke Embedded

[PATCH v3] backlight: Add TPS65217 WLED driver

2012-08-22 Thread Matthias Kaehlcke
since v2: * adapted to the latest version of the tps65217 mfd driver * register backlight as mfd subdevice * allocate struct tps65217_bl after validation of the device tree/platform data Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/mfd/tps65217.c|3

Re: [PATCH] mfd/regulator: tps65217: Move regulator plat data handling to regulator

2012-08-13 Thread Matthias Kaehlcke
around which contains the subdevice specific ones best regards -- Matthias Kaehlcke Embedded Linux Developer Amsterdam If you pay peanuts, you get monkeys (James Goldsmith) .''`. using

Re: [PATCH] mfd/regulator: tps65217: Move regulator plat data handling to regulator

2012-08-13 Thread Matthias Kaehlcke
regards -- Matthias Kaehlcke Embedded Linux Developer Amsterdam Yo soy como soy y tú eres como eres, construyamos un mundo donde yo pueda ser sin dejar de ser yo, donde tú puedas ser sin dejar de ser tú, y donde ni yo ni tú obliguemos al otro a ser como yo o como tú

[PATCH v2] backlight: Add TPS65217 WLED driver

2012-08-09 Thread Matthias Kaehlcke
(20120809) Changes since v1: * addressed review comments * moved device tree parsing to the backlight driver Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/mfd/tps65217.c| 32 +++ drivers/video/backlight/Kconfig |7 + drivers/video/backlight

Re: [PATCH] backlight: Add TPS65217 WLED driver

2012-08-08 Thread Matthias Kaehlcke
= TPS65217_BL_FDIM_100HZ; break; case 200: ... default: /* error handling */ } or the initial solution, which is slightly shorter, but i think you prefer the switch construct regards -- Matthias Kaehlcke Embedded Linux Developer Amsterdam Programming is not just

[PATCH] mfd: Fix allocation size of tps65217 platform data

2012-08-08 Thread Matthias Kaehlcke
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/mfd/tps65217.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c index 61c097a..cf908ac 100644 --- a/drivers/mfd/tps65217.c +++ b/drivers/mfd/tps65217.c @@ -162,7

Re: [PATCH] backlight: Add TPS65217 WLED driver

2012-08-07 Thread Matthias Kaehlcke
Hi AnilKumar, thanks for your comments El Tue, Aug 07, 2012 at 08:59:17AM + AnilKumar, Chimata ha dit: Can you re-submit the patch based on linux-next tree? will do Comments inline On Wed, Aug 01, 2012 at 01:18:38, Matthias Kaehlcke wrote: The TPS65217 chip contains a boost

[PATCH] backlight: Add TPS65217 WLED driver

2012-07-31 Thread Matthias Kaehlcke
The TPS65217 chip contains a boost converter and current sinks which can be used to drive LEDs for use as backlights. Expose this functionality via the backlight API. Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/mfd/tps65217.c| 71 + drivers/video

Re: [PATCH] OMAP34xx: Add padconfig offsets for GPIOs 126-129

2011-04-03 Thread Matthias Kaehlcke
Hi Felipe, El Sun, Apr 03, 2011 at 02:06:31PM +0300 Felipe Balbi ha dit: On Fri, Apr 01, 2011 at 10:23:30PM +0200, Matthias Kaehlcke wrote: Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129 Signed-off-by: Matthias Kaehlcke matth...@tomtom.com --- arch/arm/mach

[PATCH] OMAP34xx: Add padconfig offsets for GPIOs 126-129

2011-04-01 Thread Matthias Kaehlcke
Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129 Signed-off-by: Matthias Kaehlcke matth...@tomtom.com --- arch/arm/mach-omap2/mux34xx.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/mux34xx.h b/arch/arm/mach-omap2/mux34xx.h

[PATCH] twl4030-usb: Report correct vbus value for accessory charger adapters1

2011-04-01 Thread Matthias Kaehlcke
Signed-off-by: Matthias Kaehlcke matthias.kaehl...@tomtom.com --- drivers/usb/otg/twl4030-usb.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c index e01b073..efeb4d1 100644 --- a/drivers/usb/otg/twl4030

Re: Regulator question regarding I2C devices

2011-01-29 Thread Matthias Kaehlcke
as a reference Best regards -- Matthias Kaehlcke Embedded Linux Developer Amsterdam You can't separate peace from freedom because no one can be at peace unless he has his freedom (Malcolm X

[PATCH] USB ehci-omap: Remove second kfree() call on the same object

2010-10-25 Thread Matthias Kaehlcke
Remove second kfree() call on the same object in the error path of ehci_hcd_omap_probe() Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/usb/host/ehci-omap.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb