Re: [RFC 6/9] clk: ti: add support for omap4 module clocks

2016-01-04 Thread Russell King - ARM Linux
On Mon, Jan 04, 2016 at 03:27:57PM +0200, Tero Kristo wrote: > On 01/04/2016 12:21 PM, Geert Uytterhoeven wrote: > >FWIW, there are small loops with just a cpu_relax() in various clock drivers > >under drivers/clk/shmobile/. > > Just did a quick profiling round, and the clk_enable/disable delay

Re: [PATCH 1/3] ARM: ATAGS: move atags.h to include/asm so it can be included by files outside kernel/

2015-12-24 Thread Russell King - ARM Linux
On Thu, Dec 24, 2015 at 04:00:56PM +0200, Ivaylo Dimitrov wrote: > This is needed by a follow-up patch that saves atags on RX51 device > > Signed-off-by: Ivaylo Dimitrov > --- > arch/arm/include/asm/atags.h | 20 > arch/arm/kernel/atags.h

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

2015-12-15 Thread Russell King - ARM Linux
On Tue, Dec 15, 2015 at 10:33:25AM +0100, Pali Rohár wrote: > So am I understand correctly that solution would be to hack > arch/arm/mm/mmu.c to not overwrite page at PHYS_OFFSET? That's completely unnecessary: there are enough platform hooks to cope with whatever the platform requires. If you

Re: [PATCH v2] clk: ti: Add support for dm814x ADPLL

2015-12-11 Thread Russell King - ARM Linux
On Fri, Dec 11, 2015 at 07:48:54AM -0800, Tony Lindgren wrote: > There's a problem with MAX_CON_ID 16 hardcoded allocated name length. Absolutely right... > In this case I have 13 instances of plls with 3 - 4 outputs each and I'd > like to use "481c5040.adpll.clkout" style naming starting with

Re: [PATCH v2] clk: ti: Add support for dm814x ADPLL

2015-12-11 Thread Russell King - ARM Linux
On Thu, Dec 10, 2015 at 06:26:32PM -0800, Tony Lindgren wrote: > + /* Released with kfree() by clkdev_drop() */ > + cl = kzalloc(sizeof(*cl), GFP_KERNEL); > + if (!cl) > + return -ENOMEM; > + > + /* Use clkdev_add, clk_register_clkdev limits length to MAX_CON_ID */ > +

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

2015-11-29 Thread Russell King - ARM Linux
On Sun, Nov 29, 2015 at 07:19:18PM +0100, Pali Rohár wrote: > On Sunday 29 November 2015 19:09:39 Russell King - ARM Linux wrote: > > On Sat, Nov 28, 2015 at 12:34:23PM -0500, Nicolas Pitre wrote: > > > Good. And Arnd likes the idea too. So we might be converging at > >

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

2015-11-29 Thread Russell King - ARM Linux
On Sat, Nov 28, 2015 at 12:34:23PM -0500, Nicolas Pitre wrote: > Good. And Arnd likes the idea too. So we might be converging at last > which is a good thing. I disagree with the idea that there is convergence. There might be convergence towards an idea, but... Here's a mail extract, from July

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

2015-11-28 Thread Russell King - ARM Linux
On Fri, Nov 27, 2015 at 06:28:50PM -0500, Nicolas Pitre wrote: > On Fri, 27 Nov 2015, Arnd Bergmann wrote: > > > I don't mind creating the /proc/atags compatibility hack from the kernel > > for a DT based N700 kernel, as long as we limit it as much as we can > > to the machines that need it.

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

2015-11-28 Thread Russell King - ARM Linux
On Sat, Nov 28, 2015 at 01:27:07PM +0100, Arnd Bergmann wrote: > On Friday 27 November 2015 18:28:50 Nicolas Pitre wrote: > > On Fri, 27 Nov 2015, Arnd Bergmann wrote: > > > > > I don't mind creating the /proc/atags compatibility hack from the kernel > > > for a DT based N700 kernel, as long as

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

2015-11-27 Thread Russell King - ARM Linux
On Fri, Nov 27, 2015 at 01:27:23PM +, Russell King - ARM Linux wrote: > It is possible to redirect any program to open any other file. You can > do it via a LD preload, and intercepting the open(), and possibly the > read() calls if you want to do something more fancy. The

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

2015-11-27 Thread Russell King - ARM Linux
On Thu, Nov 26, 2015 at 10:07:39AM +0100, Pali Rohár wrote: > On Wednesday 25 November 2015 20:19:21 Frank Rowand wrote: > > > Or populate /proc/atags only for the ones that need it from machine > > > specific init_early? > > > > This is circling back to the first comment from Russell King where

Re: [BISECTED] v4.3-rc5: OMAP1 boot hang

2015-11-12 Thread Russell King - ARM Linux
On Wed, Nov 11, 2015 at 11:44:44PM +0200, Aaro Koskinen wrote: > Hi, > > Any suggestions how to debug this further? This happens also with v4.3 > final. Is the CPU_SW_DOMAIN_PAN supposed to work with this CPU? > > I tried to disable various drivers (e.g. NAND, USB) and it still > hangs... And it

Re: [PATCH RFC RFT 2/3] clk: clk_put WARNs if user has not disabled clk

2015-10-21 Thread Russell King - ARM Linux
On Wed, Oct 21, 2015 at 11:50:07AM +0200, Geert Uytterhoeven wrote: > Hi Mike, Russell, > > On Tue, Oct 20, 2015 at 2:40 PM, Michael Turquette > wrote: > > Why not keep the reference to the struct clk after get'ing it the first > > time? > > And store it where? Not my

Re: [BISECTED] Nokia 770 framebuffer breakage

2015-10-20 Thread Russell King - ARM Linux
On Tue, Oct 20, 2015 at 11:50:03AM +0300, Aaro Koskinen wrote: > On Mon, Oct 19, 2015 at 11:50:33PM +0100, Russell King - ARM Linux wrote: > > It shouldn't (I've been through the resulting assembly code.) I wonder > > if this is fixing the problem, but it's now failing el

Re: [PATCH RFC RFT 2/3] clk: clk_put WARNs if user has not disabled clk

2015-10-20 Thread Russell King - ARM Linux
On Tue, Oct 20, 2015 at 05:40:00AM -0700, Michael Turquette wrote: > Why not keep the reference to the struct clk after get'ing it the first > time? Yes, that's exactly what you're supposed to do in this case. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to

Re: [BISECTED] Nokia 770 framebuffer breakage

2015-10-20 Thread Russell King - ARM Linux
On Tue, Oct 20, 2015 at 10:07:00AM +0100, Russell King - ARM Linux wrote: > On Tue, Oct 20, 2015 at 11:50:03AM +0300, Aaro Koskinen wrote: > > On Mon, Oct 19, 2015 at 11:50:33PM +0100, Russell King - ARM Linux wrote: > > > It shouldn't (I've been through the resulting assembl

Re: [BISECTED] Nokia 770 framebuffer breakage

2015-10-20 Thread Russell King - ARM Linux
On Tue, Oct 20, 2015 at 07:14:28PM +0300, Aaro Koskinen wrote: > Hi, > > On Tue, Oct 20, 2015 at 05:05:24PM +0100, Russell King - ARM Linux wrote: > > On Tue, Oct 20, 2015 at 10:07:00AM +0100, Russell King - ARM Linux wrote: > > > On Tue, Oct 20, 2015 at 11:50:03AM +0

Re: [BISECTED] Nokia 770 framebuffer breakage

2015-10-19 Thread Russell King - ARM Linux
On Mon, Oct 19, 2015 at 10:37:59PM +0300, Aaro Koskinen wrote: > Hi, > > Somewhere between 4.1 .. 4.3-rc6 framebuffer on Nokia 770 stopped working. > > Bisection points to: > > commit 2568999835d7797afce3dcc3a3f368051ffcaf1f > Author: Russell King > Date: Mon Mar

Re: [BISECTED] Nokia 770 framebuffer breakage

2015-10-19 Thread Russell King - ARM Linux
On Tue, Oct 20, 2015 at 01:24:13AM +0300, Aaro Koskinen wrote: > On Mon, Oct 19, 2015 at 09:05:22PM +0100, Russell King - ARM Linux wrote: > > On Mon, Oct 19, 2015 at 10:37:59PM +0300, Aaro Koskinen wrote: > > > Hi, > > > > > > Somewhere between 4.1 .. 4.3-

Re: [PATCH 1/4] ARM: catch pending imprecise abort on unmask

2015-10-15 Thread Russell King - ARM Linux
On Wed, Oct 14, 2015 at 04:48:30PM +0200, Lucas Stach wrote: > Install a non-faulting handler just before unmasking imprecise aborts > and switch back to the regular one after unmasking is done. > > This catches any pending imprecise abort that the firmware/bootloader > may have left behind that

Re: [PATCH v2 1/3] ARM: catch pending imprecise abort on unmask

2015-10-15 Thread Russell King - ARM Linux
On Thu, Oct 15, 2015 at 12:32:20PM +0200, Lucas Stach wrote: > Install a non-faulting handler just before unmasking imprecise aborts > and switch back to the regular one after unmasking is done. > > This catches any pending imprecise abort that the firmware/bootloader > may have left behind that

Re: [PATCH v2 1/3] ARM: catch pending imprecise abort on unmask

2015-10-15 Thread Russell King - ARM Linux
On Thu, Oct 15, 2015 at 08:39:15AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux <li...@arm.linux.org.uk> [151015 08:37]: > > On Thu, Oct 15, 2015 at 12:32:20PM +0200, Lucas Stach wrote: > > > Install a non-faulting handler just before unmasking imprecise abor

Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-10-13 Thread Russell King - ARM Linux
On Tue, Oct 13, 2015 at 12:10:45PM +, Woodruff, Richard wrote: > > From: Lucas Stach [mailto:l.st...@pengutronix.de] > > Sent: Tuesday, October 13, 2015 5:01 AM > > > So please help me to get this straight: > > > > Errata I688 only affects OMAP4 which is consequently the only user of > >

Re: [PATCH] sched_clock: add data pointer argument to read callback

2015-10-10 Thread Russell King - ARM Linux
On Sat, Oct 10, 2015 at 01:42:47AM +0100, Måns Rullgård wrote: > Russell King - ARM Linux <li...@arm.linux.org.uk> writes: > > > On Sat, Oct 10, 2015 at 12:48:22AM +0100, Måns Rullgård wrote: > >> Russell King - ARM Linux <li...@arm.linux.org.uk> writes: > >

Re: [PATCH] sched_clock: add data pointer argument to read callback

2015-10-09 Thread Russell King - ARM Linux
On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote: > This passes a data pointer specified in the sched_clock_register() > call to the read callback allowing simpler implementations thereof. > > In this patch, existing uses of this interface are simply updated > with a null pointer.

Re: [PATCH] sched_clock: add data pointer argument to read callback

2015-10-09 Thread Russell King - ARM Linux
On Sat, Oct 10, 2015 at 12:48:22AM +0100, Måns Rullgård wrote: > Russell King - ARM Linux <li...@arm.linux.org.uk> writes: > > > On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote: > >> This passes a data pointer specified in the sched_clock_register() >

Re: All OMAP platforms: MMC is broken

2015-10-08 Thread Russell King - ARM Linux
On Thu, Oct 08, 2015 at 01:40:21AM -0700, Tony Lindgren wrote: > Well the way distros deal with issues like this is have everything > possible as loadable modules. We should get the regulator_pbiaa > loaded automatically in that case as long as it's in the dts.. And > as long as we have the

Re: All OMAP platforms: MMC is broken

2015-10-08 Thread Russell King - ARM Linux
On Thu, Oct 08, 2015 at 02:56:36AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux <li...@arm.linux.org.uk> [151008 02:40]: > > On Thu, Oct 08, 2015 at 01:40:21AM -0700, Tony Lindgren wrote: > > > Well the way distros deal with issues like this is have e

Re: All OMAP platforms: MMC is broken

2015-10-07 Thread Russell King - ARM Linux
On Tue, Oct 06, 2015 at 08:37:11AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux <li...@arm.linux.org.uk> [151006 08:04]: > > On Tue, Oct 06, 2015 at 02:44:25AM -0700, Tony Lindgren wrote: > > > > > > Hmm DT-based boot finds the MMC card for LDP, d

Re: All OMAP platforms: MMC is broken

2015-10-07 Thread Russell King - ARM Linux
On Wed, Oct 07, 2015 at 03:41:46PM +0200, Ulf Hansson wrote: > > http://marc.info/?l=linux-omap=144422416621373=2 > > http://marc.info/?l=linux-omap=144422416921375=2 > > Russell, may I add your tested by tag for these? You may - Tested-by: Russell King Thanks.

Re: All OMAP platforms: MMC is broken

2015-10-06 Thread Russell King - ARM Linux
On Tue, Oct 06, 2015 at 04:06:09PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 06 October 2015 03:41 PM, Ulf Hansson wrote: > > On 6 October 2015 at 11:44, Tony Lindgren <t...@atomide.com> wrote: > >> * Russell King - ARM Linux <li...@arm.linux.org

Re: All OMAP platforms: MMC is broken

2015-10-06 Thread Russell King - ARM Linux
On Tue, Oct 06, 2015 at 02:44:25AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux <li...@arm.linux.org.uk> [151006 02:04]: > > On Mon, Oct 05, 2015 at 07:38:13PM +0100, Russell King - ARM Linux wrote: > > > On Mon, Oct 05, 2015 at 10:11:56AM -0700, Tony Lindgr

Re: All OMAP platforms: MMC is broken

2015-10-06 Thread Russell King - ARM Linux
On Wed, Oct 07, 2015 at 12:59:29AM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 06 October 2015 08:37 PM, Russell King - ARM Linux wrote: > > On Tue, Oct 06, 2015 at 04:06:09PM +0530, Kishon Vijay Abraham I wrote: > >> Hi, > >> > >> On Tue

Re: All OMAP platforms: MMC is broken

2015-10-06 Thread Russell King - ARM Linux
On Mon, Oct 05, 2015 at 07:38:13PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 05, 2015 at 10:11:56AM -0700, Tony Lindgren wrote: > > * Tony Lindgren <t...@atomide.com> [151005 07:57]: > > > * Tony Lindgren <t...@atomide.com> [151005 07:44]: > > &

Re: All OMAP platforms: MMC is broken

2015-10-05 Thread Russell King - ARM Linux
On Mon, Oct 05, 2015 at 10:11:56AM -0700, Tony Lindgren wrote: > * Tony Lindgren [151005 07:57]: > > * Tony Lindgren [151005 07:44]: > > > * Tony Lindgren [151005 04:28]: > > > > > > Based on some tests it seems that the duovero unpaired

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-28 Thread Russell King - ARM Linux
On Mon, Sep 28, 2015 at 11:01:34AM +0200, Arnaud Pouliquen wrote: > few questions/remarks > BR, > Arnaud > > >+static void hdmi_codec_abort(struct device *dev) > >+{ > >+struct hdmi_codec_priv *hcp = dev_get_drvdata(dev); > >+ > >+dev_dbg(dev, "%s()\n", __func__); > >+ > >+

Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-09-25 Thread Russell King - ARM Linux
On Fri, Sep 25, 2015 at 12:01:13PM +0200, Bastian Stender wrote: > Signed-off-by: Bastian Stender > --- > arch/arm/mach-omap2/omap4-common.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap4-common.c >

Re: [PATCH] clk: ti: Fix FAPLL udelay in clk_enable with clk_prepare

2015-09-22 Thread Russell King - ARM Linux
the PLL drivers, > and similar fixes should be applied to other PLL drivers after > testing. > > Cc: Brian Hutchinson <b.hutch...@gmail.com> > Cc: Felipe Balbi <ba...@ti.com> > Cc: Grygorii Strashko <grygorii.stras...@ti.com> > Cc: Nishanth Menon <n...@ti.co

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-21 Thread Russell King - ARM Linux
On Sat, Sep 19, 2015 at 10:54:51AM -0700, Mark Brown wrote: > On Fri, Sep 18, 2015 at 02:06:40PM +0300, Jyri Sarha wrote: > > +#define SPDIF_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | > > SNDRV_PCM_FMTBIT_S16_BE |\ > > +SNDRV_PCM_FMTBIT_S20_3LE | SNDRV_PCM_FMTBIT_S20_3BE |\ > > +

Re: [PATCH RFC v4 2/8] ALSA: pcm: add IEC958 channel status helper for hw_params

2015-09-21 Thread Russell King - ARM Linux
On Fri, Sep 18, 2015 at 02:06:39PM +0300, Jyri Sarha wrote: > Add IEC958 channel status helper that gets the audio properties from > snd_pcm_hw_params instead of snd_pcm_runtime. This is needed to > produce the channel status bits already in audio stream configuration > phase. What is the reason

Re: mysterious crashes on OMAP5 uevm

2015-09-16 Thread Russell King - ARM Linux
On Tue, Sep 15, 2015 at 08:31:44PM +0300, Grazvydas Ignotas wrote: > On Mon, Sep 14, 2015 at 10:35 PM, Dr. H. Nikolaus Schaller > <h...@goldelico.com> wrote: > > > > Am 14.09.2015 um 21:02 schrieb Tony Lindgren <t...@atomide.com>: > > > >> * Rus

Re: mysterious crashes on OMAP5 uevm

2015-09-14 Thread Russell King - ARM Linux
On Fri, Sep 11, 2015 at 03:03:07PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 11, 2015 at 03:27:13PM +0200, Grazvydas Ignotas wrote: > > On Thu, Sep 10, 2015 at 10:30 AM, Russell King - ARM Linux > > <li...@arm.linux.org.uk> wrote: > > > On Thu, Sep 10, 2

Re: mysterious crashes on OMAP5 uevm

2015-09-11 Thread Russell King - ARM Linux
On Fri, Sep 11, 2015 at 04:12:21PM +, Woodruff, Richard wrote: > > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > > ow...@vger.kernel.org] On Behalf Of Russell King - ARM Linux > > Sent: Friday, September 11, 2015 9:03 AM > > To: Grazvydas Ignotas >

Re: mysterious crashes on OMAP5 uevm

2015-09-11 Thread Russell King - ARM Linux
On Fri, Sep 11, 2015 at 03:27:13PM +0200, Grazvydas Ignotas wrote: > On Thu, Sep 10, 2015 at 10:30 AM, Russell King - ARM Linux > <li...@arm.linux.org.uk> wrote: > > On Thu, Sep 10, 2015 at 08:42:57AM +0200, Dr. H. Nikolaus Schaller wrote: > >> ... > >> >

Re: mysterious crashes on OMAP5 uevm

2015-09-10 Thread Russell King - ARM Linux
On Thu, Sep 10, 2015 at 08:42:57AM +0200, Dr. H. Nikolaus Schaller wrote: > > Am 08.09.2015 um 23:07 schrieb Tony Lindgren : > > > * Grazvydas Ignotas [150908 13:44]: > >> On Tue, Sep 8, 2015 at 4:38 PM, Tony Lindgren wrote: > >>> *

Re: [RFT PATCH] ARM: OMAP: Change all cpu_is_* occurences to soc_is_*

2015-08-24 Thread Russell King - ARM Linux
On Tue, Aug 18, 2015 at 03:40:01PM +0530, Keerthy wrote: Currently apart from dra7, omap5 and amx3 all the other SoCs are identified using cpu_is_* functions which is not right since they are all SoCs(System on Chips). Hence changing the SoC identificätion code to use soc_is instead of cpu_is

Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-14 Thread Russell King - ARM Linux
On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote: +static int hdmi_codec_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params, + struct snd_soc_dai *dai) +{ + struct hdmi_codec_priv *hcp =

Re: [PATCH RFC v3 6/7] drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality

2015-08-14 Thread Russell King - ARM Linux
On Fri, Aug 14, 2015 at 12:30:44PM +0300, Jyri Sarha wrote: +static int tda998x_write_aif(struct tda998x_priv *priv, + struct hdmi_audio_infoframe *cea) +{ + uint8_t buf[HDMI_INFOFRAME_SIZE(AUDIO)]; + int len; + + len = hdmi_audio_infoframe_pack(cea,

Re: [PATCH-next 1/4] Revert ARM: 7655/1: smp_twd: make twd_local_timer_of_register() no-op for nosmp

2015-08-13 Thread Russell King - ARM Linux
On Wed, Aug 12, 2015 at 02:56:53PM -0500, Felipe Balbi wrote: This reverts commit 904464b91eca8c665acea033489225af02eeb75a. The problem pointed out by commit 904464b91eca (ARM: 7655/1: smp_twd: make twd_local_timer_of_register() no-op for nosmp) doesn't exist anymore. We can safely boot

Re: [PATCH 2/3] dma: add __must_check annotation for dmaengine_pause()

2015-08-11 Thread Russell King - ARM Linux
On Tue, Aug 11, 2015 at 03:28:52PM +0530, Vinod Koul wrote: On Fri, Aug 07, 2015 at 10:00:18PM +0200, Sebastian Andrzej Siewior wrote: In 8250-omap I learned it the hard way that ignoring the return code of dmaengine_pause() might be bad because the underlying DMA driver might not support

Re: [PATCH v3 3/3] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-11 Thread Russell King - ARM Linux
On Tue, Aug 11, 2015 at 03:02:44PM +0300, Peter Ujfalusi wrote: On 08/07/2015 11:00 PM, Sebastian Andrzej Siewior wrote: + /* +* We do not allow DMA_MEM_TO_DEV transfers to be paused. +* From the AM572x TRM, 16.1.4.18 Disabling a Channel During Transfer: +* When a channel is

Re: [PATCH 1/3] tty: serial: 8250_omap: do not use RX DMA if pause is not supported

2015-08-10 Thread Russell King - ARM Linux
On Mon, Aug 10, 2015 at 09:00:29AM -0400, Peter Hurley wrote: Russell seemed to think that the current dma operation was necessary information to differentiate types of pause support, but I don't think that's required. As Sebastian's omap-dma driver patch shows, partial pause support has more

Re: [PATCH 1/3] tty: serial: 8250_omap: do not use RX DMA if pause is not supported

2015-08-08 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 08:28:57PM -0400, Peter Hurley wrote: Even dma_get_slave_caps() returns _true_ for cmd_pause support; ok, that interface is pointless. How about reporting that as a bug then, because if you look back in the git history, as you are fully capable of, you will find that the

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-08 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 09:41:19PM -0400, Peter Hurley wrote: That's your assertion; I've seen no documentation to back that up (other than the de facto commit). So, you can't be bothered to read the thread where I quoted bits from the manual, including paraphrasing emails I had discussing this

Re: [PATCH 1/3] tty: serial: 8250_omap: do not use RX DMA if pause is not supported

2015-08-08 Thread Russell King - ARM Linux
On Sat, Aug 08, 2015 at 11:32:05AM +0200, Sebastian Andrzej Siewior wrote: This might not happen at all. At 115200 I *never* encouraged this. Once the FIFO is filled with less than RX-trigger size than the UART sends the time-out interrupt and the DMA *never* completes. Careful with statements

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 03:42:06PM +0200, Sebastian Andrzej Siewior wrote: On 08/07/2015 03:22 PM, Russell King - ARM Linux wrote: On Fri, Aug 07, 2015 at 12:36:14PM +0200, Sebastian Andrzej Siewior wrote: On 08/07/2015 11:44 AM, Peter Ujfalusi wrote: with a short testing audio did

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 02:35:45PM +0200, Sebastian Andrzej Siewior wrote: On 08/07/2015 12:55 PM, Russell King - ARM Linux wrote: On Fri, Aug 07, 2015 at 10:41:57AM +0200, Sebastian Andrzej Siewior wrote: This DMA driver is used by 8250-omap on DRA7-evm. There is one requirement

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 12:36:14PM +0200, Sebastian Andrzej Siewior wrote: On 08/07/2015 11:44 AM, Peter Ujfalusi wrote: with a short testing audio did not broke (the only user of pause/resume) Some comments embedded. Cc: sta...@vger.kernel.org Why stable? This is not fixing any

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 03:22:56PM +0200, Sebastian Andrzej Siewior wrote: On 08/07/2015 03:17 PM, Russell King - ARM Linux wrote: On Fri, Aug 07, 2015 at 02:35:45PM +0200, Sebastian Andrzej Siewior wrote: On 08/07/2015 12:55 PM, Russell King - ARM Linux wrote: On Fri, Aug 07, 2015 at 10:41

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 10:41:57AM +0200, Sebastian Andrzej Siewior wrote: This DMA driver is used by 8250-omap on DRA7-evm. There is one requirement that is to pause a transfer. This is currently used on the RX side. It is possible that the UART HW aborted the RX (UART's RX-timeout) but the

Re: [PATCH v2] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 05:36:05PM +0200, Sebastian Andrzej Siewior wrote: + /* + * We do not allow DMA_MEM_TO_DEV transfers to be paused. + * According to RMK the OMAP hardware might prefetch bytes from + * memory into its FIFO and not send

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 06:20:44PM +0200, Sebastian Andrzej Siewior wrote: On 08/07/2015 06:07 PM, Peter Hurley wrote: If we look at what 8250-dma.c is doing: if (dma-rx_running) { dmaengine_pause(dma-rxchan); It's 8250-dma.c which is silently

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 11:08:48AM -0400, Peter Hurley wrote: [ + Greg KH ] On 08/07/2015 09:57 AM, Russell King - ARM Linux wrote: As it is something that the driver has _not_ supported, you are clearly adding a feature to an existing driver. It's not a bug fix. If something else

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 05:44:03PM +0200, Sebastian Andrzej Siewior wrote: On 08/07/2015 05:29 PM, Russell King - ARM Linux wrote: On Fri, Aug 07, 2015 at 11:08:48AM -0400, Peter Hurley wrote: [ + Greg KH ] On 08/07/2015 09:57 AM, Russell King - ARM Linux wrote: As it is something

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 02:21:59PM -0400, Peter Hurley wrote: [ + Heikki ] On 08/07/2015 12:33 PM, Russell King - ARM Linux wrote: What you have is a race condition in the code you a responsible for maintaining, caused by poorly implemented code. Fix it, rather than whinging about

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 01:23:20PM -0400, Peter Hurley wrote: The omap-serial driver which doesn't use dma is still the preferred stable driver for omap, for the moment. One of the main features of the 8250_omap integration was the addition of dma support. Without it, 8250_omap is ttyO in

Re: [PATCH v2] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 07:55:48PM +0200, Sebastian Andrzej Siewior wrote: /* * We do not allow DMA_MEM_TO_DEV transfers to be paused. * From the AM572x TRM, 16.1.4.18 Disabling a Channel During Transfer: * When a channel is disabled during a transfer, the channel undergoes * an abort,

Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers

2015-08-07 Thread Russell King - ARM Linux
On Fri, Aug 07, 2015 at 12:07:11PM -0400, Peter Hurley wrote: On 08/07/2015 11:29 AM, Russell King - ARM Linux wrote: On Fri, Aug 07, 2015 at 11:08:48AM -0400, Peter Hurley wrote: [ + Greg KH ] On 08/07/2015 09:57 AM, Russell King - ARM Linux wrote: As it is something that the driver

Re: [RFC PATCH 1/5] spi: introduce flag for memory mapped read

2015-08-06 Thread Russell King - ARM Linux
On Thu, Aug 06, 2015 at 06:14:00PM +0200, Geert Uytterhoeven wrote: On Thu, Aug 6, 2015 at 3:51 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Aug 06, 2015 at 05:55:23PM +0530, Vignesh R wrote: On the whole following are my requirements: 1. to be able to communicate

Re: [RFC PATCH 1/5] spi: introduce flag for memory mapped read

2015-08-06 Thread Russell King - ARM Linux
On Thu, Aug 06, 2015 at 12:01:37PM +0200, Michal Suchanek wrote: Disclaimer: I am not familiar with the hardware for which this patch adds support. However, I am familiar m25p80.c and as I understand it the controller is basically supposed to implement m25p80.c in hardware when this flag is

Re: [RFC PATCH 1/5] spi: introduce flag for memory mapped read

2015-08-06 Thread Russell King - ARM Linux
On Thu, Aug 06, 2015 at 05:55:23PM +0530, Vignesh R wrote: On the whole following are my requirements: 1. to be able to communicate with non -flash SPI devices via config port ( this functionality is supported by current driver, I dont want to break it). Or pump any spi_message on to SPI bus

Re: [PATCH 4/4] ARM: omap2: restore OMAP4 barrier behaviour

2015-07-28 Thread Russell King - ARM Linux
On Mon, Jul 27, 2015 at 04:23:45PM -0500, Dan Murphy wrote: Russell On 07/15/2015 12:47 PM, Russell King wrote: +#ifdef CONFIG_OMAP_INTERCONNECT_BARRIER + /* Used to implement memory barrier on DRAM path */ #define OMAP4_DRAM_BARRIER_VA 0xfe60 -void

Re: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig

2015-07-27 Thread Russell King - ARM Linux
On Mon, Jul 27, 2015 at 10:59:56AM +0100, Ben Dooks wrote: This isn't the only place ARM_ERRATA_430973 is used, and if you make it configurable on !ARCH_MULTIPLATFORM then it makes it impossible to use a ARCH_MULTIPLATFORM kernel on something that is an Cortex-A8. See

Re: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig

2015-07-26 Thread Russell King - ARM Linux
On Fri, Jul 24, 2015 at 02:16:06AM +0200, Sebastian Reichel wrote: Hi Russel, On Thu, Jul 23, 2015 at 01:35:53PM +0100, Russell King - ARM Linux wrote: On Thu, Jul 23, 2015 at 02:48:03AM +0200, Sebastian Reichel wrote: Having the !ARCH_MULTIPLATFORM dependency in the Kconfig file results

Re: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig

2015-07-23 Thread Russell King - ARM Linux
On Thu, Jul 23, 2015 at 02:48:03AM +0200, Sebastian Reichel wrote: Having the !ARCH_MULTIPLATFORM dependency in the Kconfig file results in one option less to think about when configuring the kernel. -#if defined(CONFIG_ARM_ERRATA_430973) !defined(CONFIG_ARCH_MULTIPLATFORM) +#ifdef

Re: [PATCH 4/4] ARM: omap2: restore OMAP4 barrier behaviour

2015-07-16 Thread Russell King - ARM Linux
On Wed, Jul 15, 2015 at 11:48:54PM -0700, Tony Lindgren wrote: Hi, * Russell King rmk+ker...@arm.linux.org.uk [150715 10:50]: Restore the OMAP4 barrier behaviour using the new implementation which allows multiplatform systems to hook into the mb() and wmb() ARM implementations to perform

[PATCH 0/4] Fix OMAP4 barrier support

2015-07-15 Thread Russell King - ARM Linux
OMAP4 (and other TI CPUs) allow for weak ordering of writes through different buses in their interconnects. In order to ensure that accesses are performed in the correct order, we need to extend some of the kernel barriers to ensure that the bus interconnects are correctly ordered. As an

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT /chosen/linux,atags entry

2015-07-07 Thread Russell King - ARM Linux
On Mon, Jul 06, 2015 at 10:26:13PM +0200, Pali Rohár wrote: Legacy bootloaders can pass additional information for kernel or legacy userspace applications. When booting DT kernel then ATAGs structure is not more visible after running kernel uncompress code. This patch stores full ATAGs

Re: [PATCH 0/2] ARM: /proc/atags: Export also for DT

2015-06-25 Thread Russell King - ARM Linux
On Fri, May 15, 2015 at 09:50:05PM +0200, Pali Rohár wrote: This patch adds support for DT /atags and stores ATAG structure to DT. It depends on ARM: /proc/cpuinfo: DT: Add support for Revision patches. Pali Rohár (2): arm: devtree: Save atags if are in DT atags field arm: boot: store

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Russell King - ARM Linux
On Wed, May 06, 2015 at 01:44:17PM +0200, Pali Rohár wrote: On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: What I mean is which code accesses this variable that early? ATAG code is doing it at same early stage, so I added it to same early stage... ATAG code does it early because

Re: ARM errata 430973 on multi platform kernels

2015-04-28 Thread Russell King - ARM Linux
On Thu, Apr 23, 2015 at 07:17:28AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [150423 03:26]: However, I don't think anyone is willing to say that they have a solution to this problem - obviously, you can't build OMAP as a non-multiplatform kernel anymore

Re: ARM errata 430973 on multi platform kernels

2015-04-28 Thread Russell King - ARM Linux
On Fri, Apr 24, 2015 at 10:54:29AM +0200, Matthijs van Duin wrote: On 23 April 2015 at 12:25, Russell King - ARM Linux li...@arm.linux.org.uk wrote: And you can't detect whether you're running in secure mode or not. If not, you get an undefined instruction exception, which you could trap

Re: ARM errata 430973 on multi platform kernels

2015-04-23 Thread Russell King - ARM Linux
, Russell King - ARM Linux wrote: On Thu, Apr 09, 2015 at 12:06:58AM +0100, Russell King - ARM Linux wrote: On Tue, Apr 07, 2015 at 08:22:08AM -0700, Tony Lindgren wrote: Works for me. The above needs the following fix folded in to build: --- a/arch/arm

Re: Fscking OMAP

2015-04-20 Thread Russell King - ARM Linux
On Mon, Apr 20, 2015 at 04:49:13PM +0100, Russell King - ARM Linux wrote: Guys, If you're going to introduce a dependency on some infrastructure which you absolutely require for booting, then _please_ ensure that the configuration system is updated such that pre-existing kernel

Re: Fscking OMAP

2015-04-20 Thread Russell King - ARM Linux
On Mon, Apr 20, 2015 at 09:25:16AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [150420 08:50]: Guys, If you're going to introduce a dependency on some infrastructure which you absolutely require for booting, then _please_ ensure that the configuration

Fscking OMAP

2015-04-20 Thread Russell King - ARM Linux
Guys, If you're going to introduce a dependency on some infrastructure which you absolutely require for booting, then _please_ ensure that the configuration system is updated such that pre-existing kernel configurations continue to work. Don't leave it such that the infrastructure ends up

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-17 Thread Russell King - ARM Linux
On Fri, Apr 17, 2015 at 11:12:03AM +0200, Sebastian Hesselbarth wrote: On 17.04.2015 04:00, Michael Welling wrote: On Fri, Apr 17, 2015 at 01:23:50AM +0200, Sebastian Hesselbarth wrote: On 17.04.2015 00:09, Michael Welling wrote: On Thu, Apr 16, 2015 at 10:37:19PM +0200, Sebastian Hesselbarth

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-17 Thread Russell King - ARM Linux
On Fri, Apr 17, 2015 at 02:06:23PM -0500, Michael Welling wrote: On Fri, Apr 17, 2015 at 11:18:33AM +0100, Russell King - ARM Linux wrote: On Fri, Apr 17, 2015 at 11:12:03AM +0200, Sebastian Hesselbarth wrote: On 17.04.2015 04:00, Michael Welling wrote: On Fri, Apr 17, 2015 at 01:23:50AM

Re: [RESEND][PATCH] ARM errata, 430973: update the affected revisions

2015-04-13 Thread Russell King - ARM Linux
On Mon, Apr 13, 2015 at 09:28:09AM -0700, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [150413 07:46]: If what Russell and I are saying is correct, with the above two patches your system should behave properly with 430973 even if bit 6 in the aux ctrl register is set (or unset) by

Re: ARM errata 430973 on multi platform kernels

2015-04-09 Thread Russell King - ARM Linux
On Thu, Apr 09, 2015 at 08:09:19AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [150409 06:49]: On Thu, Apr 09, 2015 at 12:06:58AM +0100, Russell King - ARM Linux wrote: On Tue, Apr 07, 2015 at 08:22:08AM -0700, Tony Lindgren wrote: Works for me

Re: ARM errata 430973 on multi platform kernels

2015-04-09 Thread Russell King - ARM Linux
On Thu, Apr 09, 2015 at 12:06:58AM +0100, Russell King - ARM Linux wrote: On Tue, Apr 07, 2015 at 08:22:08AM -0700, Tony Lindgren wrote: Works for me. The above needs the following fix folded in to build: --- a/arch/arm/mm/proc-v7.S +++ b/arch/arm/mm/proc-v7.S @@ -532,7 +532,7

Re: ARM errata 430973 on multi platform kernels

2015-04-08 Thread Russell King - ARM Linux
On Tue, Apr 07, 2015 at 08:22:08AM -0700, Tony Lindgren wrote: Works for me. The above needs the following fix folded in to build: --- a/arch/arm/mm/proc-v7.S +++ b/arch/arm/mm/proc-v7.S @@ -532,7 +532,7 @@ __v7_ca9mp_proc_info: __v7_ca8_proc_info: .long 0x410fc080 .long

Re: ARM errata 430973 on multi platform kernels

2015-04-08 Thread Russell King - ARM Linux
On Tue, Apr 07, 2015 at 08:44:05AM -0700, Tony Lindgren wrote: And then on top of that patch, we can fix the sefaulting issues with the following, what do you guys think? Has this change been tested on OMAP secure parts? 8 From: Tony Lindgren t...@atomide.com Date: Tue,

Re: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h

2015-04-07 Thread Russell King - ARM Linux
On Mon, Apr 06, 2015 at 12:04:21PM -0700, Stephen Boyd wrote: On 04/04/15 05:43, Robert Jarzmik wrote: Russell King rmk+ker...@arm.linux.org.uk writes: clk_add_alias() is provided by clkdev, and is not part of the clk API. Howver, it is prototyped in two locations: linux/clkdev.h and

Re: [PATCH 06/14] clkdev: add clkdev_create() helper

2015-04-07 Thread Russell King - ARM Linux
On Mon, Apr 06, 2015 at 01:19:33PM -0700, Stephen Boyd wrote: On 04/03/15 10:12, Russell King wrote: @@ -316,6 +329,29 @@ clkdev_alloc(struct clk *clk, const char *con_id, const char *dev_fmt, ...) } EXPORT_SYMBOL(clkdev_alloc); +/** + * clkdev_create - allocate and add a

Re: [PATCH 07/14] media: omap3isp: remove unused clkdev

2015-04-07 Thread Russell King - ARM Linux
On Tue, Apr 07, 2015 at 12:42:52PM +0300, Laurent Pinchart wrote: Hello Russell, On Sunday 05 April 2015 15:20:34 Russell King - ARM Linux wrote: On Sat, Apr 04, 2015 at 12:44:35AM +0300, Laurent Pinchart wrote: Hi Russell, Thank you for the patch; On Friday 03 April 2015 18

Re: [PATCH 10/14] ARM: orion: use clkdev_create()

2015-04-07 Thread Russell King - ARM Linux
On Tue, Apr 07, 2015 at 03:20:05PM +0200, Gregory CLEMENT wrote: Hi Andrew, Russell, On 04/04/2015 02:17, Andrew Lunn wrote: On Fri, Apr 03, 2015 at 06:13:13PM +0100, Russell King wrote: clkdev_create() is a shorter way to write clkdev_alloc() followed by clkdev_add(). Use this instead.

Re: ARM errata 430973 on multi platform kernels

2015-04-07 Thread Russell King - ARM Linux
On Mon, Apr 06, 2015 at 10:42:45AM -0700, Tony Lindgren wrote: * Ivaylo Dimitrov ivo.g.dimitrov...@gmail.com [150406 10:15]: On 6.04.2015 18:40, Tony Lindgren wrote: Oops sorry, wrong numbers for errata above.. s/458693/430973/, here's a better version: 1. For cortex-a8 revisions

Re: ARM errata 430973 on multi platform kernels

2015-04-07 Thread Russell King - ARM Linux
On Mon, Apr 06, 2015 at 08:14:30PM +0200, Matthijs van Duin wrote: * Ivaylo Dimitrov ivo.g.dimitrov...@gmail.com [150406 10:15]: Why custom function, if IBE bit is zero, BTB invalidate instruction is a NOP. Do you think that mcr p15, 0, r2, c7, c5, 6 executed as a NOP will put so much

Re: LDP: next-20150402: twl4030 regression?

2015-04-06 Thread Russell King - ARM Linux
On Mon, Apr 06, 2015 at 08:53:36AM -0500, Nishanth Menon wrote: On 04/06/2015 08:45 AM, Mark Brown wrote: On Mon, Apr 06, 2015 at 08:21:49AM -0500, Nishanth Menon wrote: https://github.com/nmenon/kernel-test-logs/blob/next-20150401/omap2plus_defconfig/ldp.txt looks clean, but

  1   2   3   4   5   6   7   8   9   10   >