Re: [PATCH 2/2] mfd: twl6030: Disable IRQ during suspend

2011-10-04 Thread Samuel Ortiz
Hi Todd, On Mon, Sep 26, 2011 at 04:44:24PM -0700, Todd Poynor wrote: Module IRQs may still be disabled by DPM at the time the TWL6030 ISR runs, causing handle_simple_irq() to silently do nothing. This may result in missing TWL RTC alarm wakeups, for example, since the RTC child module ISR is

Re: [PATCH v2 0/4] Fixes to twl4030-madc and add BeagleBoard support

2011-10-04 Thread Samuel Ortiz
Hi Tony, On Wed, Sep 28, 2011 at 11:32:31AM -0700, Tony Lindgren wrote: * Samuel Ortiz sa...@linux.intel.com [110822 06:20]: Hi Kyle, On Thu, Aug 11, 2011 at 10:33:11PM -0500, Kyle Manna wrote: These patches add basic functionality to the twl4030-madc driver to make it work

Re: [PATCH 22/30] mfd: build twl6030 only on omap2

2011-10-04 Thread Samuel Ortiz
below looks like a hack to me, trying to work around the current lack of such subsystem. Cheers, Samuel. so make sure that this one is only available on omap2 to avoid conflicts with pwm drivers of other platforms. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Samuel Ortiz sa

Re: [PATCH 18/30] omap-usb: automatically select MFD_OMAP_USB_HOST

2011-10-04 Thread Samuel Ortiz
Hi Arnd, On Sun, Oct 02, 2011 at 04:45:48PM +0200, Arnd Bergmann wrote: The ehci-omap and ohci-omap3 drivers both depend on the omap-usb-host MFD support driver. By default, this is automatically turned on, but it is possible to disable the driver, which results in a link error. I don't see

Re: [PATCH] mfd: twl6030: Setup irq_wake infrastructure.

2011-09-26 Thread Samuel Ortiz
detect, USB cable detect, RTC interrupt, etc. that must wake up the application processor. With this change, TWL6030 client drivers can make use of irq_wake() if the wakeup is desirable on it's irq events. Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com cc: Samuel Ortiz sa

Re: [PATCH v3 3/3] OMAP3: Remove auto-selection of PMICs

2011-09-26 Thread Samuel Ortiz
--- arch/arm/configs/omap2plus_defconfig |3 +++ arch/arm/mach-omap2/Kconfig |3 --- drivers/mfd/Kconfig |2 +- Acked-by: Samuel Ortiz sa...@linux.intel.com for the MFD part. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com

Re: [PATCH 0/5 v9] mfd: omap: usb: Runtime PM support for EHCI and OHCI drivers

2011-09-19 Thread Samuel Ortiz
Hi Keshava, On Thu, Sep 15, 2011 at 06:52:45PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The Hwmod structures and Runtime PM features are implemented For EHCI and OHCI drivers of OMAP3 and OMAP4. The global suspend/resume of EHCI and OHCI is validated on

Re: [PATCH 2/2] mfd: remove CONFIG_MFD_SUPPORT

2011-09-15 Thread Samuel Ortiz
Hi Arnd, On Fri, Sep 02, 2011 at 04:43:36PM +0200, Arnd Bergmann wrote: We currently have two symbols to control compilation the MFD subsystem, MFD_SUPPORT and MFD_CORE. The MFD_SUPPORT is actually not required at all, it only hides the submenu when not set, with the effect that Kconfig warns

Re: [PATCH] mfd: Add PWM1 and PWM2 support to twl6030-pwm

2011-09-15 Thread Samuel Ortiz
Hi Hemanth, On Tue, Aug 30, 2011 at 12:27:17PM +0530, Hemanth V wrote: From: Hemanth V heman...@ti.com Date: Fri, 26 Aug 2011 10:49:29 +0530 Subject: [PATCH] Add PWM1 and PWM2 support to twl6030-pwm driver This patch adds support for PWM1/PWM2. TWL6030 PWM driver also supports Indicator

Re: [PATCH] ASoC/MFD: twl4030: Fix dependencies for audio codec

2011-09-15 Thread Samuel Ortiz
Hi THomas, On Mon, Sep 05, 2011 at 11:26:33AM +0200, Thomas Weber wrote: The codec for Devkit8000 (TWL4030) was not detected except when build with CONFIG_SND_SOC_ALL_CODECS. twl-core.c still uses the CONFIG_TWL4030_CODEC for twl_has_codec(). In commit

Re: [PATCH] mfd: twl6030: Setup irq_wake infrastructure.

2011-09-15 Thread Samuel Ortiz
Hi Santosh, On Tue, Sep 06, 2011 at 09:29:30PM +0530, Santosh Shilimkar wrote: TWL6030 devices have an interrupt line which is connected to application processor like OMAP. These devices support multiple features such as MMC card detect, USB cable detect, RTC interrupt, etc. that must wake up

Re: [PATCH v2 0/4] Fixes to twl4030-madc and add BeagleBoard support

2011-08-22 Thread Samuel Ortiz
Hi Kyle, On Thu, Aug 11, 2011 at 10:33:11PM -0500, Kyle Manna wrote: These patches add basic functionality to the twl4030-madc driver to make it work on the BeagleBoard xM. Version 2 adds fixes per Grazvydas Ignotas and the check for NULL pointer patch. Kyle Manna (4): mfd:

Re: [PATCH] mfd: omap-usb-host: Make TLL mode work again

2011-08-22 Thread Samuel Ortiz
Hi Anand, On Thu, Aug 18, 2011 at 04:14:31PM +0530, Anand Gadiyar wrote: This code section seems to have been accidentally copy pasted. It causes incorrect bits to be set up in the TLL_CHANNEL_CONF register and prevents the TLL mode from working correctly. Patch applied, with Felipe's ACK and

Re: [PATCH 0/7] twl4030: finish threaded IRQ conversion

2011-08-22 Thread Samuel Ortiz
Hi Felipe, On Fri, Aug 19, 2011 at 12:36:15AM +0300, Felipe Balbi wrote: Hi, On Sat, Jul 09, 2011 at 05:09:00AM +0100, Mark Brown wrote: On Thu, Jun 30, 2011 at 12:51:03PM +0300, Felipe Balbi wrote: the following patches where boot-tested on beagle xM and everything seems fine. MMC

Re: [PATCH] mfd: omap-usb-host: fix build failure

2011-08-22 Thread Samuel Ortiz
Hi Tom, On Fri, Aug 19, 2011 at 04:57:54PM +0800, tom.leim...@gmail.com wrote: From: Ming Lei tom.leim...@gmail.com The patch fixes the build failure: Patch applied, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send

Re: [PATCH 3/3] OMAP3: Remove auto-selection of PMICs

2011-08-22 Thread Samuel Ortiz
Hi Anhilash, On Fri, Aug 19, 2011 at 05:19:33PM +0530, Abhilash K V wrote: The current implementation almost assumes that only TWL4030/TWL5030/TWl6030 are (or can be) used with the OMAP processors. This is, however, not true. I don't like the mfd/Kconfig change. Why would those drivers be

Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()

2011-07-27 Thread Samuel Ortiz
Hi Keshava, On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com usbhs_disable function was invoking clk_enable() instead of clk_disable(), thus only increasing the clock usage counter and preventing this particular clock from

Re: [PATCHv2] mfd: twl4030: Fix mismatch in mutex lock-unlock

2011-07-27 Thread Samuel Ortiz
Hi Premi, On Mon, Jul 11, 2011 at 08:50:31PM +0530, Sanjeev Premi wrote: A mutex is locked on entry into twl4030_madc_conversion(). Immediate return on some error conditions leaves the mutex locked. This patch ensures that mutex is always unlocked before leaving the function. Patch

Re: [PATCH v6 08/18] mfd: twl6040: Add initial support

2011-07-04 Thread Samuel Ortiz
Hi Peter, On Tue, Jun 21, 2011 at 04:39:06PM +0300, Peter Ujfalusi wrote: +int twl6040_is_powered(struct twl6040 *twl6040) +{ + return twl6040-power_count; +} +EXPORT_SYMBOL(twl6040_is_powered); Do we really need to export this one ? +static inline int twl6040_get_rev(struct twl6040

Re: Re: [PATCH v6 00/18] MFD/ASoC/Input: TWL4030/TWL60X0 changes

2011-07-04 Thread Samuel Ortiz
. If there are no conflicts, then Samuel can queue it. I suppose this should then go through l-o... OK. Assuming Samuel is fine with the patches, I am fine with them. I just had some minor comments about patch #10, but you can go ahead and add my: Acked-by: Samuel Ortiz sa...@linux.intel.com

Re: [PATCH 0/6 V2] arm: omap: usb: Runtime PM support for EHCI and OHCI drivers

2011-07-04 Thread Samuel Ortiz
Hi Keshava, On Sat, Jul 02, 2011 at 12:24:28AM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The Hwmod structures and Runtime PM features are implemented For EHCI and OHCI drivers of OMAP3 and OMAP4. The global suspend/resume of EHCI and OHCI is validated on

Re: Re: [PATCH v6 08/18] mfd: twl6040: Add initial support

2011-07-04 Thread Samuel Ortiz
Hi Peter, On Mon, Jul 04, 2011 at 05:08:17PM +0300, Péter Ujfalusi wrote: Hi Samuel, On Monday 04 July 2011 13:48:44 Samuel Ortiz wrote: I don't see the value of those 3 inline functions. Removing them would make the code actually more understandable (especially for the 2nd one

Re: [PATCH 2/3] Add tps65921 chip

2011-07-01 Thread Samuel Ortiz
Hi Tony, On Fri, Jul 01, 2011 at 12:35:58AM -0700, Tony Lindgren wrote: Samuel, * gr...@linuxhacker.ru gr...@linuxhacker.ru [110614 08:42]: From: Oleg Drokin gr...@linuxhacker.ru Very similar to TPS65920 List of differences: http://www.ti.com/litv/pdf/swcu066b CC:

Re: Re: [alsa-devel] [PATCH v6 00/18] MFD/ASoC/Input: TWL4030/TWL60X0 changes

2011-06-30 Thread Samuel Ortiz
Hi Péter, On Thu, Jun 30, 2011 at 09:15:08AM +0300, Péter Ujfalusi wrote: Hi Samuel, Would you be able to take a look at this series? I already have the rebased version on top of linux-omap/devel-cleanup branch as Tony requested, and I'm now waiting for your comments. I will do that very

Re: [PATCH] mfd: omap: fix the crash during omap ehci or ohci driver initialization

2011-06-21 Thread Samuel Ortiz
Hi Kevin, On Mon, Jun 20, 2011 at 03:06:01PM -0700, Kevin Hilman wrote: Samuel Ortiz sa...@linux.intel.com writes: Hi Felipe, On Mon, Jun 20, 2011 at 04:28:52PM +0300, Felipe Balbi wrote: Hi, On Mon, Jun 20, 2011 at 03:26:26PM +0200, Samuel Ortiz wrote: On Mon, Jun 06, 2011

Re: [PATCH] mfd: omap: fix the crash during omap ehci or ohci driver initialization

2011-06-20 Thread Samuel Ortiz
Hi Keshava, On Mon, Jun 06, 2011 at 07:12:19PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com Oops are produced during initialization of ehci and ohci drivers. This is because the run time pm apis are used by the driver but the corresponding hwmod structures

Re: [PATCH] mfd: omap: fix the crash during omap ehci or ohci driver initialization

2011-06-20 Thread Samuel Ortiz
Hi Felipe, On Mon, Jun 20, 2011 at 04:28:52PM +0300, Felipe Balbi wrote: Hi, On Mon, Jun 20, 2011 at 03:26:26PM +0200, Samuel Ortiz wrote: On Mon, Jun 06, 2011 at 07:12:19PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com Oops are produced during

Re: [PATCH v1] omap: usbhs: Fixed the crash during rmmod of ehci and ohci

2011-05-22 Thread Samuel Ortiz
Hi Felipe, On Wed, May 18, 2011 at 01:53:15PM +0300, Felipe Balbi wrote: On Mon, May 16, 2011 at 02:24:58PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The disabling of clocks and freeing GPIO are changed to fix the occurrence of the crash of rmmod of

Re: [RESEND][PATCH 4/5] arm: omap: usb: Runtime PM support

2011-05-22 Thread Samuel Ortiz
Hi Felipe, On Wed, May 18, 2011 at 01:48:09PM +0300, Felipe Balbi wrote: On Mon, May 16, 2011 at 03:08:52PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The usbhs core driver does not enable/disable the intefrace and fucntional clocks; These clocks are

Re: [PATCH v10 4/7] MFD: TWL4030: power scripts for OMAP3 boards

2011-05-22 Thread Samuel Ortiz
Hi Lesly, On Tue, May 17, 2011 at 07:10:03PM +0530, Manuel, Lesly Arackal wrote: Hi Samuel, On Sat, May 14, 2011 at 12:09 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Lesly, On Fri, May 06, 2011 at 06:47:10PM +0530, Lesly A M wrote: Power bus message sequence for TWL4030 to enter

Re: [PATCH v2 1/4] MFD: TWL6025: add phoenix lite support to twl6030

2011-05-13 Thread Samuel Ortiz
Hi Graeme, On Thu, May 12, 2011 at 02:27:55PM +0100, Graeme Gregory wrote: Phoenix Lite is based on the twl6030 family of PMICs. It has mostly the same feature set of twl6030 but with small changes. The codec block has also been removed. It also has a new charger block and new features in its

Re: [PATCH v2 2/4] MFD: TWL6030: fix irq definitions

2011-05-13 Thread Samuel Ortiz
Hi Graeme On Thu, May 12, 2011 at 02:27:56PM +0100, Graeme Gregory wrote: The charger fault IRQs from the twl will in future patches be handled by a seperate IRQ handler in the charger driver than the general charger IRQ. Give them different IRQ numbers now to allow the charger driver to be

Re: [PATCH 1/1] OMAP: twl4030-power: In remove script check the error condition after i2cwrite

2011-05-13 Thread Samuel Ortiz
Hi Lesly, On Wed, May 04, 2011 at 05:38:53PM +0530, Lesly Arackal Manuel wrote: From: Lesly A M lesl...@ti.com Fixing the error condition check in twl4030 remove script function. Due to some typo in commit ID: 11a441ce82d6ffecfd39b324024de0cd630b36c1 Thanks, patch applied. Cheers, Samuel

Re: [PATCH v10 1/7] MFD: TWL4030: Fix for the TWL4030 sleep/wakeup sequence

2011-05-13 Thread Samuel Ortiz
Hi Lesly, On Fri, May 06, 2011 at 06:47:07PM +0530, Lesly A M wrote: Only configure sleep script when the flag is TWL4030_SLEEP_SCRIPT. Adding the missing brackets for fixing the issue. This is already upstream. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/

Re: [PATCH v10 2/7] MFD: TWL4030: Correct the warning print during script loading

2011-05-13 Thread Samuel Ortiz
Hi Lesly, On Fri, May 06, 2011 at 06:47:08PM +0530, Lesly A M wrote: Correcting the if condition check for printing the warning, if wakeup script is not updated before updating the sleep script. Since the flag 'order' is set to '1' while updating the wakeup script for P1P2, the condition

Re: [PATCH v10 3/7] MFD: TWL4030: Modifying the macro name Main_Ref to all caps

2011-05-13 Thread Samuel Ortiz
Hi Lesly, On Fri, May 06, 2011 at 06:47:09PM +0530, Lesly A M wrote: Modifying the macro name Main_Ref to all caps(MAIN_REF). This one is already on my for-next branch. I'll update the Changelog accordingly. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To

Re: [PATCH v10 5/7] MFD: TWL4030: TWL version checking

2011-05-13 Thread Samuel Ortiz
Hi Lesly, On Fri, May 06, 2011 at 06:47:11PM +0530, Lesly A M wrote: Added API to get the TWL5030 Si version from the IDCODE register. It is used for enabling the workaround for TWL erratum 27. This one is also already applied. Cheers, Samuel. -- Intel Open Source Technology Centre

Re: [PATCH v2] MFD: twl4030-codec: Update e-mail address

2011-05-13 Thread Samuel Ortiz
Hi Peter, On Tue, May 10, 2011 at 08:59:23AM +0300, Peter Ujfalusi wrote: Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Patch applied, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v10 4/7] MFD: TWL4030: power scripts for OMAP3 boards

2011-05-13 Thread Samuel Ortiz
Hi Lesly, On Fri, May 06, 2011 at 06:47:10PM +0530, Lesly A M wrote: Power bus message sequence for TWL4030 to enter sleep/wakeup/warm_reset. TWL4030 power scripts which can be used by different OMAP3 boards with the power companion chip (TWL4030 series). The twl4030 generic script can be

Re: [PATCH v9 1/9] OMAP3: PM: Fix for the TWL4030 sleep/wakeup sequence

2011-04-26 Thread Samuel Ortiz
Hi Lesly, On Thu, Apr 14, 2011 at 05:57:49PM +0530, Lesly A M wrote: Only configure sleep script when the flag is TWL4030_SLEEP_SCRIPT. Adding the missing brackets for fixing the issue. Patch applied to my for-linus branch. Cheers, Samuel. -- Intel Open Source Technology Centre

Re: [PATCH v9 2/9] OMAP3: PM: Correct the warning print during script loading

2011-04-26 Thread Samuel Ortiz
Hi Lesly, On Thu, Apr 14, 2011 at 05:57:50PM +0530, Lesly A M wrote: Correcting the if condition check for printing the warning, if wakeup script is not updated before updating the sleep script. Since the flag 'order' is set to '1' while updating the wakeup script for P1P2, the condition

Re: [PATCH v9 5/9] OMAP3: PM: TWL5030 version checking

2011-04-26 Thread Samuel Ortiz
Hi Lesly, On Thu, Apr 14, 2011 at 05:57:53PM +0530, Lesly A M wrote: Added API to get the TWL5030 Si version from the IDCODE register. It is used for enabling the workaround for TWL erratum 27. Patch applied to my for-next branch, thanks. Cheers, Samuel. -- Intel Open Source Technology

Re: [PATCH v9 6/9] MFD: TWL4030: workaround changes for TWL4030 Erratum 27

2011-04-26 Thread Samuel Ortiz
Hi Lesly, On Thu, Apr 14, 2011 at 05:57:54PM +0530, Lesly A M wrote: Workaround for TWL5030 Silicon Errata 27 28: 27 - VDD1, VDD2, may have glitches when their output value is updated. 28 - VDD1 and / or VDD2 DCDC clock may stop working when internal clock is

Re: [PATCH] Fixed gpio polarity of gpio USB-phy reset.

2011-04-18 Thread Samuel Ortiz
Hi Juergen, On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote: With commit 19403165 a main part of ehci-omap.c moved to drivers/mfd/omap-usb-host.c created by commit 17cdd29d. Due to this reorganisation the polarity used to reset the external USB phy changed and USB host doesn't

Re: [PATCH] Fixed gpio polarity of gpio USB-phy reset.

2011-04-14 Thread Samuel Ortiz
Hi Juergen, On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote: With commit 19403165 a main part of ehci-omap.c moved to drivers/mfd/omap-usb-host.c created by commit 17cdd29d. Due to this reorganisation the polarity used to reset the external USB phy changed and USB host doesn't

Re: [PATCH 0/2 v5] twl4030-madc driver

2011-03-02 Thread Samuel Ortiz
Hi Keerthy, On Tue, Mar 01, 2011 at 07:12:06PM +0530, Keerthy wrote: MADC(Monitoring ADC) driver enables monitoring analog signals using analog-to-digital conversion (ADC) on the input source. The previous discussion concluded in keeping the generic ADC functionality and the hwmon separate.

Re: [PATCH 0/2] twl4030_codec cleanup

2011-03-02 Thread Samuel Ortiz
Hi Ilkka, On Wed, Mar 02, 2011 at 03:24:04PM +0200, Ilkka Koskinen wrote: This series of patches removes duplicate audio_mclk fields from twl4030_codec driver. The patches have been compiled on sound-2.6/for-2.6.39 branch. I haven't tested them on any target board though. I'm fine with the

Re: [PATCH 2/2] mfd: twl4030_codec: Remove unused and duplicate audio_mclk fields

2011-03-02 Thread Samuel Ortiz
Hi Ilkka, On Wed, Mar 02, 2011 at 03:24:06PM +0200, Ilkka Koskinen wrote: audio_mclk can be queried from mfd driver. Therefore, it is not needed in twl4030_codec_audio_data or in twl4030_codec_vibra_data anymore. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com Acked-by: Samuel Ortiz

Re: [PATCH 1/2 v2] mfd: twl4030: Driver for twl4030 madc module

2011-02-27 Thread Samuel Ortiz
Hi Keerthy, On Thu, Feb 24, 2011 at 08:48:33PM +0530, Keerthy wrote: Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring ADC. This driver monitors the real time conversion of analog signals like battery temperature, battery cuurent etc. Looks mostly good to me, one

Re: [PATCH 2/2 v2] hwmon: twl4030: Hwmon Driver for TWL4030 MADC

2011-02-27 Thread Samuel Ortiz
Hi Keerthy, On Thu, Feb 24, 2011 at 08:48:50PM +0530, Keerthy wrote: This driver exposes the sysfs nodes of the TWL4030 MADC module. All the voltage channel values are expressed in terms of mV. Channel 13 and channel 14 are reserved. There are channels which represent temperature and current

Re: [PATCH] mfd: twl4030: Enabling twl4030_wdt and pwrbutton only for Triton

2011-02-27 Thread Samuel Ortiz
Hi Keerthy, On Wed, Feb 23, 2011 at 04:26:54PM +0530, Keerthy wrote: Enabling twl4030_wdt and twl4030_pwrbutton only for Triton i.e for TWL4030 and TWL5030. This is to be excluded for Phoenix TWL6030. Tested OMAP4 blaze, OMAP2430, OMAP3630 boot up. Patch applied, thanks. Cheers, Samuel. --

Re: [PATCH v2 1/2] regulator: twl: add clk32kg to twl-regulator

2011-02-21 Thread Samuel Ortiz
Hi Tony, On Mon, Feb 14, 2011 at 04:01:43PM -0800, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [110214 13:14]: * Mark Brown broo...@opensource.wolfsonmicro.com [110211 03:17]: On Thu, Feb 10, 2011 at 06:44:50PM +0530, Balaji T K wrote: In OMAP4 Blaze and Panda, 32KHz clock to

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-31 Thread Samuel Ortiz
Hi Keerthy, On Sat, Jan 22, 2011 at 10:19:33PM +0530, J, KEERTHY wrote: On Fri, Jan 7, 2011 at 5:42 PM, J, KEERTHY j-keer...@ti.com wrote: On Fri, Jan 7, 2011 at 3:25 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, 2011-01-06 at 15:21 -0500, Mark Brown wrote: On Thu, Jan 06,

Re: [PATCH] MFD: TWL/TPS: fix twl_probe section mismatch warning in mfd/twl-core.c

2010-12-09 Thread Samuel Ortiz
Hi Bryan, On Wed, Dec 08, 2010 at 10:42:04AM +0800, Bryan Wu wrote: Fix the following section mismatch warning when building omap2plus_defconfig: WARNING: vmlinux.o(.data+0x47d7c): Section mismatch in reference from the variable twl_driver to the function .init.text:twl_probe() Patch

Re: [PATCH] MFD: TWL/TPS: fix twl_probe section mismatch warning in mfd/twl-core.c

2010-12-07 Thread Samuel Ortiz
(.data+0x47d7c): Section mismatch in reference from the variable twl_driver to the function .init.text:twl_probe() Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Samuel Ortiz sa...@linux.intel.com ---  drivers/mfd/twl-core.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions

Re: [PATCH v3] TWL IRQ: Fix fucntion declaration warnings

2010-10-19 Thread Samuel Ortiz
Hi Manjunath, On Wed, Oct 06, 2010 at 03:26:59AM +0530, G, Manjunath Kondaiah wrote: Fixes following sparse warnings for twl4030 and twl6030 irq files. drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not declared. Should it be static?

Re: [PATCH v3] TWL IRQ: Fix fucntion declaration warnings

2010-10-19 Thread Samuel Ortiz
Hi Uwe, On Tue, Oct 19, 2010 at 11:28:16AM +0200, Uwe Kleine-König wrote: On Tue, Oct 19, 2010 at 11:06:14AM +0200, Samuel Ortiz wrote: Hi Manjunath, On Wed, Oct 06, 2010 at 03:26:59AM +0530, G, Manjunath Kondaiah wrote: Fixes following sparse warnings for twl4030 and twl6030 irq files

Re: [PATCH v2] omap4: pandaboard: fix up mmc card detect logic

2010-10-19 Thread Samuel Ortiz
register present on twl6030. This functionality was introduced in mfd tree on track to kernel.org Sync pandaboard to the same and make mmc work. Cc: Tony Lindgren t...@atomide.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Adrian Hunter adrian.hun...@nokia.com Cc: Samuel Ortiz sa

Re: [PATCH] mfd: twl4030: add twl4030_bci platform_data back

2010-10-18 Thread Samuel Ortiz
Hi Grazvydas, On Fri, Oct 01, 2010 at 01:17:50PM +0300, Grazvydas Ignotas wrote: Now that we have twl4030 charger driver, add back it's platform_data (which was removed by f7ea2dc59ed46dcd0f1cfaccda02211f4507207b as unused). Patch applied, many thanks. Cheers, Samuel. Signed-off-by:

Re: [PATCH] mfd: fix TWL4030 COR bit polarity for BCI SIH block

2010-10-18 Thread Samuel Ortiz
Hi Grazvydas, On Tue, Sep 28, 2010 at 04:22:19PM +0300, Grazvydas Ignotas wrote: The chip TRM documentation contradicts itself about this bit, page 174 of swcu050e says bit should be 0 for clear-on-read behavior, while page 487 says it should be 1. Testing shows it should be 1, so set the

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread Samuel Ortiz
. Regards, Kishore On Mon, Sep 27, 2010 at 1:25 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Cc: Samuel Ortiz sa...@linux.intel.com On Fri, Sep 24, 2010 at 10:43 PM, kishore kadiyala kishore.kadiy...@ti.com wrote: Adding card detect callback function and card detect

Re: [PATCH 1/7] pwm: Add pwm core driver

2010-09-28 Thread Samuel Ortiz
On Tue, Sep 28, 2010 at 06:23:24PM +0530, Hemanth V wrote: - Original Message - From: Arun Murthy arun.mur...@stericsson.com The existing pwm based led and backlight driver makes use of the pwm(include/linux/pwm.h). So all the board specific pwm drivers will be exposing the same

Re: [PATCH v2 07/10] TWL CORE: Fix sparse warning

2010-09-27 Thread Samuel Ortiz
manj...@ti.com Cc: linux-arm-ker...@lists.infradead.org Cc: Samuel Ortiz sa...@linux.intel.com Cc: Tony Lindgren t...@atomide.com Cc: Nishanth Menon n...@ti.com --- drivers/mfd/twl-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/twl-core.c b

Re: [PATCH v2 08/10] TWL IRQ: Fix fucntion declaration warnings

2010-09-27 Thread Samuel Ortiz
it be static? drivers/mfd/twl6030-irq.c:290:5: warning: symbol 'twl6030_exit_irq' was not declared. Should it be static? Signed-off-by: G, Manjunath Kondaiah manj...@ti.com Cc: linux-arm-ker...@lists.infradead.org Cc: Samuel Ortiz sa...@linux.intel.com Cc: Tony Lindgren t...@atomide.com Cc

Re: [PATCH v2 08/10] TWL IRQ: Fix fucntion declaration warnings

2010-09-27 Thread Samuel Ortiz
Hi Manjunath, On Mon, Sep 27, 2010 at 07:19:33PM +0530, G, Manjunath Kondaiah wrote: No, we don't want to export those. Try defining them as extern from twl*-irq.c. Having extern in .c file will generate checkpatch warning as: WARNING: externs should be avoided in .c files As an

Re: [PATCH] mfd: speedup twl4030 irq response time and decrease irq disable time

2010-09-27 Thread Samuel Ortiz
TRM). Could you explain how is that related to the patch below ? Cheers, Samuel. Signed-off-by: Ming Lei tom.leim...@gmail.com Cc: Samuel Ortiz sa...@linux.intel.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Cc: Balaji T K balaj...@ti.com Cc: Rajendra Nayak rna...@ti.com Cc: Kevin

Re: [PATCH 1/4] i2c: twl: add register defines for pm master module

2010-09-10 Thread Samuel Ortiz
Hi Felipe, On Wed, Aug 18, 2010 at 10:19:16AM +0300, Felipe Balbi wrote: hi, On Wed, Aug 18, 2010 at 08:19:34AM +0200, Balbi Felipe (Nokia-MS/Helsinki) wrote: From: Felipe Balbi felipe.ba...@nokia.com Some modules already need to talk to at least PROTECT_KEY register, while at that,

Re: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-20 Thread Samuel Ortiz
Hi Felipe, On Wed, Aug 18, 2010 at 10:16:19AM +0300, Felipe Balbi wrote: Hi, On Wed, Aug 18, 2010 at 09:10:22AM +0200, Balbi Felipe (Nokia-MS/Helsinki) wrote: On Wed, Aug 18, 2010 at 09:03:44AM +0200, ext Gopinath, Thara wrote: No I am not talking about the key values. I was talking about

Re: [PATCH 1/2] mfd: menelaus: Fix mmc slot 2 misconfiguration

2010-08-08 Thread Samuel Ortiz
Hi Jarkko, On Sun, Aug 08, 2010 at 08:05:23PM +0300, Jarkko Nikula wrote: We are modifying register value instead of return value. Patch applied, kiitos. This fix is originally done by Carlos Eduardo Aguiar. Original fix is commit bb4e91722e29efe31587d2cc664b6def645aecd9 in

Re: [PATCH 2/2] mfd: menelaus: Use macros instead of some constant magic numbers

2010-08-08 Thread Samuel Ortiz
On Sun, Aug 08, 2010 at 08:05:24PM +0300, Jarkko Nikula wrote: This patch is originally done by Carlos Eduardo Aguiar. Original fix is commit 3305829b2816072b9c8ed01374b205ae4de74027 in git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git Author modified the fix for mainline

Re: [RFC] [PATCH] mfd: Support for TWL6030 PWM

2010-07-14 Thread Samuel Ortiz
Hi Hemanth, On Thu, Jul 08, 2010 at 05:40:51PM +0530, Hemanth V wrote: From 2c6efcebf2790a4c968309360cfc3559b6d9c110 Mon Sep 17 00:00:00 2001 From: Hemanth V heman...@ti.com Date: Thu, 8 Jul 2010 17:04:06 +0530 Subject: [PATCH] Add support for TWL6030 PWM TWL6030 supports PWM (Pulse Width

Re: [PATCH] mfd: twl5031: Rename sih modules

2010-05-20 Thread Samuel Ortiz
Hi Ilkka, On Thu, May 20, 2010 at 01:04:20PM +0300, Ilkka Koskinen wrote: Fix the names of twl5031 specific sih modules to match the documentation. Patch applied, thanks. Cheers, Samuel. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com --- drivers/mfd/twl4030-irq.c | 11

Re: [PATCH] [PATCH v4 1/5] omap3: pm: fix for twl4030 script load

2010-04-02 Thread Samuel Ortiz
through the linux-omap tree. If you agree, please add my: Acked-by: Samuel Ortiz sa...@linux.intel.com to the patch below. Cheers, Samuel. Signed-off-by: Lesly A M x0080...@ti.com Cc: Nishanth Menon n...@ti.com Cc: David Derrick dderr...@ti.com Cc: Samuel Ortiz sa...@linux.intel.com --- drivers

Re: [PATCHv2 1/2] OMAP4: PMIC: Rename twl6030_codec as twl6040_codec

2010-03-18 Thread Samuel Ortiz
with doing this via the ASoC tree? If that's more convenient to you, then go for it, with my: Acked-by: Samuel Ortiz sa...@linux.intel.com Cheers, Samuel. --- drivers/mfd/twl-core.c |4 ++-- include/linux/i2c/twl.h |6 +++--- 2 files changed, 5 insertions(+), 5 deletions

Re: [PATCH] MFD: TWL4030: introduce remove_script function

2010-02-28 Thread Samuel Ortiz
Hi Mike, On Mon, Feb 22, 2010 at 11:16:30AM -0600, mturque...@gmail.com wrote: From: Mike Turquette mturque...@ti.com New function twl4030_remove_script(u8 flags) takes a script type as defined in twl.h and prevents any script already loaded in that position from running. This is

Re: [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec

2010-02-24 Thread Samuel Ortiz
-by: Misael Lopez Cruz x0052...@ti.com Signed-off-by: Margarita Olaya Cabrera magi.ol...@ti.com Signed-off-by: Jorge Eduardo Candelaria jorge.candela...@ti.com It would be good to get Samuel's Ack on this as it touches MFD. Samuel are you OK with this ? That seems fine, yes. Acked-by: Samuel Ortiz

Re: [PATCH 1/2] omap: Disable TWL4030/5030 I2C1/I2C4 internal pull-ups

2010-02-19 Thread Samuel Ortiz
Hi Moiz, On Tue, Feb 16, 2010 at 06:57:21PM -0600, Moiz Sonasath wrote: This patch disables TWL4030/5030 I2C1 adn I2C4(SR) internal pull-up, to use only the external HW resistor =470 Ohm for the assured functionality in HS mode. While testing the I2C in High Speed mode, it was discovered

Re: [PATCH 20/24] twl6030: add base addr for ID0, ID1, ID2

2010-02-19 Thread Samuel Ortiz
prefer it to go through your tree. Cheers, Samuel. Cc: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mfd/twl-core.c |7 +-- include/linux/i2c/twl.h |5 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/mfd

Re: [PATCH] twl6030: add base addr for ID0, ID1, ID2

2010-02-19 Thread Samuel Ortiz
On Thu, Feb 18, 2010 at 10:35:11PM +0530, Krishnamoorthy, Balaji T wrote: Sending this as a separate patch which was earlier combined with the series http://marc.info/?l=linux-omapm=126633460408606w=2 And it's been applied to my for-next branch, thanks. Cheers, Samuel. -Original

Re: [RFC][PATCH] mfd: twl4030: Check for i2c error code in protect_pm_master function

2010-01-05 Thread Samuel Ortiz
Hi Balaji, On Fri, Dec 11, 2009 at 09:59:18PM +0530, balaj...@ti.com wrote: From: Balaji T K balaj...@ti.com Warn about error messages immediately after i2c write to R_PROTECT_KEY in functions protect_pm_master/unprotect_pm_master Signed-off-by: Balaji T K balaj...@ti.com

Re: mfd: twl4030-irq: irq_desc-lock converted to raw_spinlock_t

2010-01-05 Thread Samuel Ortiz
Hi Tony, On Mon, Dec 28, 2009 at 12:01:45PM -0800, Tony Lindgren wrote: * Felipe Balbi felipe.ba...@nokia.com [091228 03:04]: commit 239007b8440abff689632f50cdf0f2b9e895b534 converted the spinlock_t to raw_spinlock_t. Unfortunately twl4030-irq was left aside on the conversion. Cc:

Re: linux-next: origin tree build failure

2009-12-16 Thread Samuel Ortiz
Hi Stephen, On Wed, Dec 16, 2009 at 09:45:41AM +1100, Stephen Rothwell wrote: Hi Tony, On Tue, 15 Dec 2009 09:27:17 -0800 Tony Lindgren t...@atomide.com wrote: * Mark Brown broo...@opensource.wolfsonmicro.com [091215 06:52]: On Tue, Dec 15, 2009 at 04:41:08PM +1100, Stephen Rothwell

Re: [PATCH v3 03/04] ARM: OMAP: Rename twl4030_ in rtc-twl.c to make it generic rtc

2009-12-13 Thread Samuel Ortiz
Hi Alessandro, On Wed, Nov 18, 2009 at 03:42:52PM +0100, Alessandro Zummo wrote: On Thu, 1 Oct 2009 17:50:33 +0530 balaj...@ti.com wrote: From: Balaji T K balaj...@ti.com This patch renames all twl4030_ functions to twl_ so that RTC driver can be shared between Triton and Phoenix.

Re: [PATCH v4 0/8] TWL6030 patch series

2009-12-13 Thread Samuel Ortiz
Hi Balaji, On Fri, Dec 11, 2009 at 09:25:09PM +0530, Krishnamoorthy, Balaji T wrote: The TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. [PATCH v4 01/08] ARM:

Re: [PATCH 1/1] mfd: twl4030: clarify the return value for read and write

2009-12-11 Thread Samuel Ortiz
the i2c core error code. Currently we return success (0) even if none of messages were transferred successfully. Signed-off-by: Amit Kucheria amit.kuche...@verdurent.com Signed-off-by: Samuel Ortiz sa...@linux.intel.com diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd

Re: [PATCH v3 0/4] TWL patch series

2009-12-09 Thread Samuel Ortiz
Hi Balaji, On Wed, Dec 09, 2009 at 11:09:33AM +0530, Krishnamoorthy, Balaji T wrote: Hi Samuel, This patch is not merged. Please let me know if I am missing something so that i can post the patches rebased on the latest 2.6.32. I'd appreciate if you could rebase your patches, and also

Re: [PATCH] mfd: twl4030: Driver for twl4030 madc module

2009-12-01 Thread Samuel Ortiz
Hi Amit, On Mon, Nov 30, 2009 at 03:58:39PM +0200, Amit Kucheria wrote: + * drivers/i2c/chips/twl4030-madc.c drivers/mfd/twl4030-madc.c By the way, have you considered moving this one to drivers/hwmon ? I haven't. I moved it from i2c/chips/ to the most obvious place I could think of -

Re: [PATCH] mfd: twl4030: Driver for twl4030 madc module

2009-11-27 Thread Samuel Ortiz
Hi Amit, On Wed, Nov 25, 2009 at 12:47:51PM +0200, Amit Kucheria wrote: diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index af0fc90..df1897b 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -25,8 +25,9 @@ obj-$(CONFIG_TPS65010) += tps65010.o

Re: [PATCH v3] mfd: Initial support for twl5031

2009-11-15 Thread Samuel Ortiz
Hi Ilkka, On Tue, Nov 10, 2009 at 05:26:15PM +0200, Ilkka Koskinen wrote: TWL5031 introduces two new interrupts in PIH. Moreover, BCI has changed remarkably and, thus, it's disabled when TWL5031 is in use. Applied to my for-next branch, thanks. Cheers, Samuel. Signed-off-by: Ilkka Koskinen

Re: [PATCH v2] TWL4030: Initial support for TWL5031

2009-11-04 Thread Samuel Ortiz
Hi Ilkka, Some comments below: On Fri, Oct 16, 2009 at 05:12:40PM +0300, Ilkka Koskinen wrote: TWL5031 introduces two new interrupts in PIH. Moreover, BCI has changed remarkably and, thus, it's disabled when TWL5031 is in use. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com ---

Re: [PATCH 1/4 v2] MFD: twl4030: add twl4030_codec MFD as a new child to the core

2009-10-23 Thread Samuel Ortiz
and vibra. The platform specific configuration data is passed along to the child drivers (audio, vibra). Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com As agreed, Mark is taking this one. So: Acked-by: Samuel Ortiz sa...@linux.intel.com Cheers, Samuel. --- drivers/mfd/Kconfig

Re: [PATCH v2] twl4030: Enable low-power mode to 32kHz oscillator

2009-10-23 Thread Samuel Ortiz
Hi Ilkka, On Thu, Oct 22, 2009 at 02:14:09PM +0300, Ilkka Koskinen wrote: Allows TWL's 32kHz oscillator to go in low-power mode when main battery voltage is running low. Patch applied, thanks a lot. Cheers, Samuel. Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com ---

Re: [PATCH 1/4] MFD: twl4030: add twl4030_codec MFD as a new child to the core

2009-10-22 Thread Samuel Ortiz
On Thu, Oct 22, 2009 at 09:04:32AM +0300, Peter Ujfalusi wrote: I'll check, if the MFD patch applies to mfd-2.6:for-next also, but to have the soc codec changes the MFD patch should go to the sound-2.6 tree as well to make sure it is not braking things. All-in-all, how these things can

Re: [Resend PATCH 2/2] twl4030: Enable low-power mode to 32kHz oscillator

2009-10-21 Thread Samuel Ortiz
Hi Ilkka, On Tue, Oct 20, 2009 at 04:22:53PM +0300, Ilkka Koskinen wrote: +struct twl4030_clock_init_data { + int ck32k_lowpwr_enable; I guess you could use a bool here ? Cheers, Samuel. +}; + struct twl4030_bci_platform_data { int *battery_tmp_tbl; unsigned int

Re: [Resend PATCH 1/2] twl4030: Do not dereference null pointer in error path

2009-10-21 Thread Samuel Ortiz
Hi Ilkka, On Tue, Oct 20, 2009 at 04:22:52PM +0300, Ilkka Koskinen wrote: Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com Patch applied to my for-linus and for-next branches. I'll try to get that one merged for 2.6.32. Cheers, Samuel. --- drivers/mfd/twl4030-core.c |2 +- 1

Re: [PATCH 1/4] MFD: twl4030: add twl4030_codec MFD as a new child to the core

2009-10-21 Thread Samuel Ortiz
Hi Peter, On Mon, Oct 19, 2009 at 03:42:17PM +0300, Peter Ujfalusi wrote: New MFD child to twl4030 MFD device. This MFD device will be used by the drivers, which needs resources from the twl4030 codec like audio and vibra. The platform specific configuration data is passed along to the

Re: [PATCH 5/5] mfd: twl4030-power: Optimised power scripts for the rx51

2009-10-20 Thread Samuel Ortiz
On Mon, Oct 19, 2009 at 04:22:39PM -0700, Tony Lindgren wrote: * Samuel Ortiz sa...@linux.intel.com [091019 12:15]: Hi Amit, On Mon, Oct 19, 2009 at 03:11:08PM +0300, Amit Kucheria wrote: The power scripts optimisation was mainly done by: Tero Kristo tero.kri...@nokia.com

Re: [PATCH 1/5] mfd: twl4030-power: Rename DEVGROUP to DEV_GRP

2009-10-20 Thread Samuel Ortiz
Hi Amit, On Tue, Oct 20, 2009 at 09:07:13AM +0300, Amit Kucheria wrote: On 09 Oct 19, Samuel Ortiz wrote: Hi Amit, I've applied patches 1,2 and 3 to my for-next branch. I dont think patch 4 is really useful, and I'll wait for an ACK from Tony or Nokia before pushing patch 5

Re: [PATCH 1/2] twl4030: Do not dereference null pointer in error path

2009-10-19 Thread Samuel Ortiz
Hi Ilkka, On Fri, Oct 16, 2009 at 04:21:41PM +0200, ilkka.koski...@nokia.com wrote: Hi Samuel, What is the status of this patch and the other one: [PATCH 2/2] twl4030: Enable low-power mode to 32KHz oscillator I'm sorry but it seems I havent received those 2 patches. Could you please

Re: [PATCH 3/5] mfd: twl4030-power: Move power-related data closer together in the header file

2009-10-19 Thread Samuel Ortiz
Hi Amit, On Mon, Oct 19, 2009 at 03:10:52PM +0300, Amit Kucheria wrote: Bring together all the TWL power-related data in the header file I dont really see the point of doing this, as you're not really gathering scattered structures but rather moving a group of definitions up in the header file.

<    1   2   3   >