On 12/14/12 19:26, Felipe Balbi wrote:
Hi,
On Fri, Dec 14, 2012 at 09:28:09AM -0800, Tony Lindgren wrote:
* Tony Lindgren t...@atomide.com [121120 12:00]:
Hi,
* Timo Kokkonen timo.t.kokko...@iki.fi [121118 07:15]:
--- a/drivers/media/rc/ir-rx51.c
+++ b/drivers/media/rc/ir-rx51.c
load
keeping the CPU from sleeping.
The signal handling fixup patches did raise all sorts of discussion
last time, but my conclusion was that the patch itself should be fine
for now.
Please provide feedback and consider accepting them in. Thank you.
Timo Kokkonen (7):
ir-rx51: Handle signals
Remove a redundant macro definition. This is unneeded and becomes more
readable once the actual timer code is refactored a little.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git
Add missing __user annotation to all of the user space memory
accesses. Otherwise sparse is complainign about address space
difference in types.
Also struct lirc_rx51_platform_driver is missing static keyword even
though it should have it.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
the process from getting stuck in kernel for too long.
Also, from now on we will force the TX to stop before we return from
write call. If the TX happened to time out for some reason, we should
not leave the HW transmitting anything.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers
As clearly visible from the patch, this variable has no useful purpose
what so ever. Thus, it can be removed altogether without any side
effects.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff
This driver is useless without proper platform data. If data is not
available, we should not register the driver at all. Once this check
is done, the BUG_ON check during device open is no longer needed.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 4
no means
to wake up the MPU once it has gone into sleep. The side effect is
that from now on the driver actually works even if there is no
background load keeping the MPU awake.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
Acked-by: Tony Lindgren t...@atomide.com
Acked-by: Jean Pihet j-pi
No reason to avoid using the existing helpers.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c
index 16b3c1f..6e1ffa6 100644
On 09/03/12 15:36, Sean Young wrote:
On Sun, Sep 02, 2012 at 11:08:20PM +0300, Timo Kokkonen wrote:
On 09/02/12 22:41, Sakari Ailus wrote:
On Sun, Sep 02, 2012 at 06:20:27PM +0300, Timo Kokkonen wrote:
On 09.02 2012 18:06:34, Sakari Ailus wrote:
Heippa,
Timo Kokkonen wrote:
Terve,
On 09
Terve,
On 09/01/12 20:14, Sakari Ailus wrote:
Moi,
On Thu, Aug 30, 2012 at 08:54:24PM +0300, Timo Kokkonen wrote:
@@ -273,9 +281,18 @@ static ssize_t lirc_rx51_write(struct file *file, const
char *buf,
/*
* Don't return back to the userspace until the transfer has
On 09/01/12 20:16, Sakari Ailus wrote:
Moi,
On Thu, Aug 30, 2012 at 08:54:31PM +0300, Timo Kokkonen wrote:
This trivial fix cures the following warning message:
drivers/media/rc/Kconfig:275:warning: multi-line strings not supported
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
On 09.02 2012 18:06:34, Sakari Ailus wrote:
Heippa,
Timo Kokkonen wrote:
Terve,
On 09/01/12 20:14, Sakari Ailus wrote:
Moi,
On Thu, Aug 30, 2012 at 08:54:24PM +0300, Timo Kokkonen wrote:
@@ -273,9 +281,18 @@ static ssize_t lirc_rx51_write(struct file *file,
const char *buf
On 09/02/12 22:41, Sakari Ailus wrote:
On Sun, Sep 02, 2012 at 06:20:27PM +0300, Timo Kokkonen wrote:
On 09.02 2012 18:06:34, Sakari Ailus wrote:
Heippa,
Timo Kokkonen wrote:
Terve,
On 09/01/12 20:14, Sakari Ailus wrote:
Moi,
On Thu, Aug 30, 2012 at 08:54:24PM +0300, Timo Kokkonen wrote
-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index ffef8b4..093982b 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -273,7 +273,7
As clearly visible from the patch, this variable has no useful purpose
what so ever. Thus, it can be removed altogether without any side
effects.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff
no means
to wake up the MPU once it has gone into sleep. The side effect is
that from now on the driver actually works even if there is no
background load keeping the MPU awake.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
Acked-by: Tony Lindgren t...@atomide.com
Acked-by: Jean Pihet j-pi
the process from getting stuck in kernel for too long.
Also, from now on we will force the TX to stop before we return from
write call. If the TX happened to time out for some reason, we should
not leave the HW transmitting anything.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers
This trivial fix cures the following warning message:
drivers/media/rc/Kconfig:275:warning: multi-line strings not supported
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc
No reason to avoid using the existing helpers.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c
index 16b3c1f..6e1ffa6 100644
-Fix typo
-Change pwm_timer_num type to match type in platform data
-Remove extra parenthesis
-Replace magic constant with proper bit defintions
-Remove duplicate exit pointer
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/Kconfig | 2 +-
drivers/media/rc/ir-rx51
This driver is useless without proper platform data. If data is not
available, we should not register the driver at all. Once this check
is done, the BUG_ON check during device open is no longer needed.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 4
Remove a redundant macro definition. This is unneeded and becomes more
readable once the actual timer code is refactored a little.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git
- A missing quote mark is added into the Kconfig text
Changes since v1:
- Replace wake_up_interruptible with wake_up, as the driver is having
non-interruptible sleeps
- Instead of just removing the set_max_mpu_wakeup_lat calls, replace
them with QoS API calls
Timo Kokkonen (9):
ir-rx51: Adjust
On 08/27/12 12:25, Jean Pihet wrote:
Hi Timo,
On Fri, Aug 24, 2012 at 10:39 PM, Tony Lindgren t...@atomide.com wrote:
* Timo Kokkonen timo.t.kokko...@iki.fi [120824 08:11]:
Convert the driver from the obsolete omap_pm_set_max_mpu_wakeup_lat
API to the new PM QoS API. This allows
Hi Jean,
On 08/23/12 14:58, Jean Pihet wrote:
Hi Timo,
On Wed, Aug 22, 2012 at 9:50 PM, Timo Kokkonen timo.t.kokko...@iki.fi wrote:
That is correct. The API to use is the PM QoS API which cpuidle uses
to determine the next MPU state based on the allowed latency.
A more appropriate fix
On 08/24/12 13:03, Sean Young wrote:
On Wed, Aug 22, 2012 at 10:50:35PM +0300, Timo Kokkonen wrote:
The lirc-dev expects the ir-code to be transmitted when the write call
returns back to the user space. We should not leave TX ongoing no
matter what is the reason we return to the user space
On 08/24/12 12:04, Jean Pihet wrote:
Hi Timo,
On Fri, Aug 24, 2012 at 10:14 AM, Timo Kokkonen timo.t.kokko...@iki.fi
wrote:
Hi Jean,
On 08/23/12 14:58, Jean Pihet wrote:
Hi Timo,
On Wed, Aug 22, 2012 at 9:50 PM, Timo Kokkonen timo.t.kokko...@iki.fi
wrote:
That is correct. The API
non-interruptible sleeps
- Instead of just removing the set_max_mpu_wakeup_lat calls, replace
them with QoS API calls
Timo Kokkonen (8):
ir-rx51: Adjust dependencies
ir-rx51: Handle signals properly
ir-rx51: Trivial fixes
ir-rx51: Clean up timer initialization code
ir-rx51: Move
-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index ffef8b4..093982b 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -273,7 +273,7
-Fix typo
-Change pwm_timer_num type to match type in platform data
-Remove extra parenthesis
-Replace magic constant with proper bit defintions
-Remove duplicate exit pointer
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/Kconfig | 2 +-
drivers/media/rc/ir-rx51
the process from getting stuck in kernel for too long.
Also, from now on we will force the TX to stop before we return from
write call. If the TX happened to time out for some reason, we should
not leave the HW transmitting anything.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers
Remove a redundant macro definition. This is unneeded and becomes more
readable once the actual timer code is refactored a little.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git
As clearly visible from the patch, this variable has no useful purpose
what so ever. Thus, it can be removed altogether without any side
effects.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff
no means
to wake up the MPU once it has gone into sleep. The side effect is
that from now on the driver actually works even if there is no
background load keeping the MPU awake.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 --
drivers
No reason to avoid using the existing helpers.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c
index 16b3c1f..6e1ffa6 100644
This driver is useless without proper platform data. If data is not
available, we should not register the driver at all. Once this check
is done, the BUG_ON check during device open is no longer needed.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 4
-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index ffef8b4..093982b 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -273,7 +273,7
is still as badly mangled as before, unless there
is some background load preventing the MPU from going into
sleep. Otherwise the patches are mostly clean ups and rather trivial
stuff.
All comments are welcome. Thanks!
Timo Kokkonen (8):
ir-rx51: Adjust dependencies
ir-rx51: Handle signals properly
As clearly visible from the patch, this variable has no useful purpose
what so ever. Thus, it can be removed altogether without any side
effects.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff
No reason to avoid using the existing helpers.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c
index 46628c0..7eed541 100644
This driver is useless without proper platform data. If data is not
available, we should not register the driver at all. Once this check
is done, the BUG_ON check during device open is no longer needed.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 4
-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 --
drivers/media/rc/ir-rx51.c | 9 -
include/media/ir-rx51.h | 2 --
3 files changed, 13 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rx51
-Fix typo
-Change pwm_timer_num type to match type in platform data
-Remove extra parenthesis
-Replace magic constant with proper bit defintions
-Remove duplicate exit pointer
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
trivial
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
the process from getting stuck in kernel for too long.
Also, from now on we will force the TX to stop before we return from
write call. If the TX happened to time out for some reason, we should
not leave the HW transmitting anything.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers
Remove a redundant macro definition. This is unneeded and becomes more
readable once the actual timer code is refactored a little.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/ir-rx51.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git
On 08/16/12 19:34, Sakari Ailus wrote:
Hi Sebastian,
On Thu, Aug 16, 2012 at 01:21:04PM +0200, Sebastian Reichel wrote:
Hi,
It was an requirement back then that this driver needs to be a module as
99% of the N900 owners still don't even know they have this kind of
capability on their
know that the following
patch were queued at the
http://git.linuxtv.org/media_tree.git tree:
Subject: [media] media: rc: Introduce RX51 IR transmitter driver
Author: Timo Kokkonen timo.t.kokko...@iki.fi
Date:Fri Aug 10 06:16:36 2012 -0300
This is the driver for the IR transmitter
Hi,
On 08/10/12 13:16, Timo Kokkonen wrote:
These patches add the support for sending IR remote controller codes
on the Nokia N900 phone. The code is taken from the public N900 kernel
release and modified to work with today's kernel.
The code has been tested with a real Nokia N900 device
On 08/13/12 21:36, Sean Young wrote:
On Fri, Aug 10, 2012 at 01:16:36PM +0300, Timo Kokkonen wrote:
+static ssize_t lirc_rx51_write(struct file *file, const char *buf,
+ size_t n, loff_t *ppos)
+{
+int count, i;
+struct lirc_rx51 *lirc_rx51 = file-private_data
needed and should be freed.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
Cc: Tony Lindgren t...@atomide.com
Cc: Tarun Kanti DebBarma tarun.ka...@ti.com
---
arch/arm/plat-omap/dmtimer.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-omap/dmtimer.c b/arch
.
---
Changes since v1:
- Move ir-rx51.h into include/media directory
Timo Kokkonen (2):
media: rc: Introduce RX51 IR transmitter driver
ARM: mach-omap2: board-rx51-peripherals: Add lirc-rx51 data
arch/arm/mach-omap2/board-rx51-peripherals.c | 30 ++
drivers/media/rc/Kconfig
The IR diode on the RX51 is connected to the GPT9. This data is needed
for the IR driver to function.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 30 ++
1 files changed, 30 insertions(+), 0 deletions(-)
diff
them or otherwise the timer
cannot be requested again.
The code has been tested with sending IR codes with N900 device
running Debian userland. The device receiving the codes was Anysee
DVB-C USB receiver.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/Kconfig | 10
I should have probably tried this before, but when I enabled lock
debugging with this driver, I got this:
[ 663.848083] BUG: sleeping function called from invalid context at
kernel/mutex.c:269
[ 663.856262] in_atomic(): 1, irqs_disabled(): 128, pid: 889, name: lircd
[ 663.863220] 1 lock
On 08.10 2012 14:06:38, Timo Kokkonen wrote:
I should have probably tried this before, but when I enabled lock
debugging with this driver, I got this:
[ 663.848083] BUG: sleeping function called from invalid context at
kernel/mutex.c:269
[ 663.856262] in_atomic(): 1, irqs_disabled
.
Timo Kokkonen (2):
media: rc: Introduce RX51 IR transmitter driver
ARM: mach-omap2: board-rx51-peripherals: Add lirc-rx51 data
arch/arm/mach-omap2/board-rx51-peripherals.c | 27 ++
drivers/media/rc/Kconfig | 10 +
drivers/media/rc/Makefile|1
The IR diode on the RX51 is connected to the GPT9. This data is needed
for the IR driver to function.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 30 ++
1 files changed, 30 insertions(+), 0 deletions(-)
diff
them or otherwise the timer
cannot be requested again.
The code has been tested with sending IR codes with N900 device
running Debian userland. The device receiving the codes was Anysee
DVB-C USB receiver.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
drivers/media/rc/Kconfig | 10
On 08/09/12 16:19, Igor Grinberg wrote:
Hi Timo,
On 08/09/12 15:41, Timo Kokkonen wrote:
The IR diode on the RX51 is connected to the GPT9. This data is needed
for the IR driver to function.
Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi
---
arch/arm/mach-omap2/board-rx51
parameters that override this default behavior, so I have no further
objections for this patch.
Acked-By: Timo Kokkonen timo.t.kokko...@nokia.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info
Hi,
On Mon, 2010-05-17 at 13:12 +0200, Palande Ameya (Nokia-D/Helsinki)
wrote:
If we are not able to register then it is better to have watchdog in disabled
state than noticing a system reboot.
Signed-off-by: Ameya Palande ameya.pala...@nokia.com
---
drivers/watchdog/twl4030_wdt.c |2
Make the dmtimer function symbols available so modules can take use of
them.
Signed-off-by: Timo Kokkonen timo.t.kokko...@nokia.com
---
arch/arm/plat-omap/dmtimer.c | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/dmtimer.c b
63 matches
Mail list logo
