Re: [PATCH 2/5] OMAPFB: simplify locking

2012-12-07 Thread Ville Syrjälä
and omapfb_setup_mem/store_size. -- Ville Syrjälä Intel OTC -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] OMAPFB: simplify locking

2012-12-07 Thread Ville Syrjälä
On Fri, Dec 07, 2012 at 03:42:10PM +0200, Tomi Valkeinen wrote: On 2012-12-07 14:53, Ville Syrjälä wrote: On Fri, Dec 07, 2012 at 01:55:06PM +0200, Tomi Valkeinen wrote: Kernel lock verification code has lately detected possible circular locking in omapfb. The exact problem is unclear

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-19 Thread Ville Syrjälä
I never noticed the problem. I see there was a patch [1] posted a long time ago to implement 64bit get_user() on x86-32. I wonder what happened to it? [1] https://lkml.org/lkml/2004/4/20/96 -- Ville Syrjälä Intel OTC -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-19 Thread Ville Syrjälä
On Mon, Nov 19, 2012 at 02:48:06PM +, Russell King - ARM Linux wrote: On Mon, Nov 19, 2012 at 04:32:36PM +0200, Ville Syrjälä wrote: On Thu, Nov 15, 2012 at 02:39:41PM +, Arnd Bergmann wrote: On Thursday 15 November 2012, Rob Clark wrote: I still haven't heard a conclusive

Re: [PATCH 1/2] drm: support for rotated scanout

2012-09-17 Thread Ville Syrjälä
...@ti.com Sorry for the delay Rob, I somehow missed this. In any case, the patch looks OK to me. Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com -- Ville Syrjälä Intel OTC -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 2/2] Expose the OMAP Z-Order property through DRM

2012-08-16 Thread Ville Syrjälä
. That way user space couldn't even try to use an unsupported configuration. The downside is that user space would need to parse those strings if it wants to do some automagic stacking order changes, which means the string format would need some though. -- Ville Syrjälä Intel OTC -- To unsubscribe from

Re: [PATCH] drm: refcnt drm_framebuffer

2012-08-01 Thread Ville Syrjälä
seem acceptable. -- Ville Syrjälä Intel OTC -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: drm/omap: add rotation properties

2012-07-02 Thread Ville Syrjälä
of the rotation was also opposite to xrandr (cw in dss, ccw in xrandr). So FWIW, my vote goes to reflect if we want to match xrandr semantics. Also I agree on the number of bits, six is better than three since it allows you to describe the hw capabilities. -- Ville Syrjälä Intel OTC -- To unsubscribe from

Re: [PATCH 1/2] OMAPDSS: DISPC: Enable predecimation

2012-03-15 Thread Ville Syrjälä
managed to push that stuff upstream... -- Ville Syrjälä syrj...@sci.fi http://www.sci.fi/~syrjala/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] OMAPDSS: DISPC: Handle synclost errors in OMAP3

2012-03-15 Thread Ville Syrjälä
become frequent. Checks have been implemented to see that DISPC driver rejects configuration exceeding above limitations. This code was successfully tested on OMAP3. This code is written based on code written by Ville Syrjälä ville.syrj...@nokia.com in Linux OMAP kernel. Ville Syrjälä

Re: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

2010-11-26 Thread Ville Syrjälä
...@ti.com writes: -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@nokia.com] Sent: Wednesday, November 24, 2010 10:01 PM To: Hiremath, Vaibhav Cc: Tomi Valkeinen; linux-omap@vger.kernel.org Subject: Re: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

Re: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

2010-11-24 Thread Ville Syrjälä
vblank in many cases). That's it. I don't see any point in trying to shoehorn other functionality into it. If you want to standardise WAITFORGO type of stuff then just add another standard ioctl for it. -- Ville Syrjälä -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check

2010-11-12 Thread Ville Syrjälä
= kmalloc(strlen(def_mode) + 1, GFP_KERNEL); + if (str == NULL) + return -EINVAL; strcpy(str, def_mode); While you're at it you could change the code to use kstrdup(). -- Ville Syrjälä -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH] OMAP:DSS:Add support for Additional color modes supported by OMAP4

2010-08-11 Thread Ville Syrjälä
*/ + OMAP_DSS_COLOR_XRGB12 = 1 16, /* xRGB12, 16-bit container */ Isn't this the same as RGB12U? -- Ville Syrjälä -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] OMAP: DSS2: OMAPFB: add support for FBIO_WAITFORVSYNC

2010-07-06 Thread Ville Syrjälä
] I don't see any reason why we should still keep old custom IOCTL support here. It can already be used so it should not be removed. -- Ville Syrjälä -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] OMAP: DSS2: OMAPFB: add support for FBIO_WAITFORVSYNC

2010-07-06 Thread Ville Syrjälä
On Tue, Jul 06, 2010 at 01:26:28PM +0200, ext Hiremath, Vaibhav wrote: -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@nokia.com] Sent: Tuesday, July 06, 2010 3:36 PM To: Hiremath, Vaibhav Cc: Grazvydas Ignotas; linux-fb...@vger.kernel.org; linux- o

Re: OMAP3 display patches

2010-06-29 Thread Ville Syrjälä
any of my comments so asking Tomi to pull this seems rather premature. -- Ville Syrjälä -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP: DSS2: DMA optimization using scaler line buffers

2010-06-23 Thread Ville Syrjälä
://vger.kernel.org/majordomo-info.html -- Ville Syrjälä -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] fbdev: add a MIPI DSI header

2010-05-19 Thread Ville Syrjälä
driver does. If you have better ideas, please share =). I find enums easier on the eye than defines. Less irrelevant junk on each line. There's no reason you can't pass enum values as u8. But in that case giving the enum a name doesn't really make sense. -- Ville Syrjälä -- To unsubscribe from

Re: [PATCH] OMAP: DSS2: GFX FIFO UNDERFLOW issue fixed

2010-05-04 Thread Ville Syrjälä
is a bit broken since AFAICS it will leave the old angle still mapped when you rotate to another angle. -- Ville Syrjälä -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v3 1/4] DSS2: OMAPFB: Add support for switching memory regions

2010-03-19 Thread Ville Syrjälä
down_read(0) Right. I didn't actually consider the case with so many threads. It's good that lockdep was smarter than me :) -- Ville Syrjälä -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 1/4] DSS2: OMAPFB: Add support for switching memory regions

2010-03-18 Thread Ville Syrjälä
, and mmap_sem which in mmap() is taken before the region lock. I'm hoping there are no mmap_sem users lurking in the driver that already hold the region rwsem. -- Ville Syrjälä -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v3 1/4] DSS2: OMAPFB: Add support for switching memory regions

2010-03-17 Thread Ville Syrjälä
On Wed, Mar 17, 2010 at 06:34:07PM +0100, Deak Imre (Nokia-D/Helsinki) wrote: Hi, couple of minor comments inlined. On Fri, Mar 05, 2010 at 02:26:19PM +0100, Syrjala Ville (Nokia-D/Helsinki) wrote: From: Ville Syrjälä ville.syrj...@nokia.com Separate the memory region from

Re: [PATCH v2] DSS2: OMAPFB: Add support for switching memory regions

2010-03-04 Thread Ville Syrjälä
On Tue, Mar 02, 2010 at 07:36:59PM +0100, Syrjala Ville (Nokia-D/Helsinki) wrote: From: Ville Syrjälä ville.syrj...@nokia.com Separate the memory region from the framebuffer device a little bit. It's now possible to select the memory region used by the framebuffer device using the new

Re: [PATCH 2/2] OMAP: DSS2: OMAPFB: implement OMAPFB_GET_DISPLAY_INFO

2010-02-04 Thread Ville Syrjälä
omapfb_display_info { + __u16 width; + __u16 height; How about adding the physical display size here as well? I suppose mm is the standard unit for such things but for small displays more accuracy might be nice. -- Ville Syrjälä syrj...@sci.fi http://www.sci.fi/~syrjala