Re: [PATCH] omap: cleanup NAND platform data

2011-06-03 Thread Vimal Singh
dynamically when a frequency change is done. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Self modifying code in ARM 11 architectures

2011-05-25 Thread Vimal Singh
of a message to majord...@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] omap : nand : fix subpage ecc issue with prefetch

2011-05-06 Thread Vimal Singh
reading/writing a subpage with a non divisible by 4 ecc number of bytes, the mis-aligned bytes gets handled first before enabling the Prefetch engine, then it reads/writes rest of the bytes. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Signed-off-by: Vimal Singh vimal.neww...@gmail.com

Re: [PATCH] omap : nand : fix subpage ecc issue with prefetch

2011-05-05 Thread Vimal Singh
-by: Kishore Kadiyala kishore.kadiy...@ti.com Signed-off-by: Vimal Singh vimal.neww...@gmail.com Reported-by: Bryan DE FARIA bdefa...@adeneo-embedded.com ---  drivers/mtd/nand/omap2.c |   12 +---  1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b

Re: [PATCH 2/3] omap : nand : fix omap2 module reinsertion

2011-04-29 Thread Vimal Singh
);        return 0; -- -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] omap : nand : fix subpage ecc issue with prefetch

2011-04-29 Thread Vimal Singh
(they are overwritten), which makes the software ecc fail. Its not only read, write too is broken for the same reason. More ever, it is broken for other path too (failing to enable prefetch engine path). -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH v2] ARM: omap2: mtd split nand_scan in ident and tail

2011-04-18 Thread Vimal Singh
message Move above two lines to below (as there are not part of commit log): Signed-off-by: Jan Weitzel j.weit...@phytec.de --- here. Feel free to add: Reviewed-by: Vimal Singh vimal.neww...@gmail.com Regards, Vimal -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH] omap3: nand: bch ecc support added

2011-01-20 Thread Vimal Singh
); + +       return no_of_err; +} +EXPORT_SYMBOL(decode_bch); + -- 1.7.0.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html -- Regards, Vimal

Re: [PATCH] omap3: nand: bch ecc support added

2011-01-20 Thread Vimal Singh
On Fri, Jan 21, 2011 at 9:37 AM, Ghorai, Sukumar s-gho...@ti.com wrote: -Original Message- From: Vimal Singh [mailto:vimal.neww...@gmail.com] Sent: Thursday, January 20, 2011 8:47 PM To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org; linux-...@lists.infradead.org; linux-arm- ker

Re: Issue : jffs2 and ecc layout

2010-10-07 Thread Vimal Singh
T32) and verify if commands issued were written correctly to appropriate registers. [1]: http://marc.info/?l=linux-omapm=128302624528822w=2 [2] commit: http://git.infradead.org/mtd-2.6.git/commitdiff/2c01946c6b9ebaa5a89710bc42ca224a7f52f227 -- Regards, Vimal Singh -- To unsubscribe from

Re: [PATCH v3] OMAP: NAND: Fix static declaration warning

2010-10-07 Thread Vimal Singh
, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 09/10] OMAP2/3: Convert write/read functions to raw read/write

2010-10-07 Thread Vimal Singh
++ != cpu_to_le16(__raw_readw(info-nand.IO_ADDR_R))) There was an old comment to remove use of 'cpu_to_le16' from driver, I just missed it. Can you rather use 'ioread16_rep' for reading data. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: NAND ECC in linux-omap

2010-08-27 Thread Vimal Singh
Adding LO and MTD list too for more comments. On Sat, Aug 28, 2010 at 1:40 AM, Vimal Singh vimal.neww...@gmail.com wrote: On Sat, Aug 28, 2010 at 12:00 AM, Cliff Brake cliff.br...@gmail.com wrote: On Fri, Aug 27, 2010 at 2:29 PM, Cliff Brake cliff.br...@gmail.com wrote: On Fri, Aug 27, 2010

Re: NAND ECC in linux-omap

2010-08-24 Thread Vimal Singh
On Tue, Aug 24, 2010 at 8:04 PM, Cliff Brake cliff.br...@gmail.com wrote: flash_erasall -j /dev/mtd4 Give a try without using '-j' option... If ECC layout is the suspect.. this may help. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH v5 0/3] omap3 nand: cleanup exiting platform related code

2010-06-08 Thread Vimal Singh
Reviewed-by: Vimal Singh vimal.neww...@gmail.com On Fri, Jun 4, 2010 at 1:10 PM, Sukumar Ghorai s-gho...@ti.com wrote:   The following set of patches applies on top of for-next branch.        http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git   Patches verified on: omap3430

Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-28 Thread Vimal Singh
On Fri, May 28, 2010 at 12:03 PM, Ghorai, Sukumar s-gho...@ti.com wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Vimal Singh Sent: Thursday, May 27, 2010 11:56 PM To: Ghorai, Sukumar Cc: linux-omap

Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-28 Thread Vimal Singh
On Fri, May 28, 2010 at 11:50 PM, Ghorai, Sukumar s-gho...@ti.com wrote: -Original Message- From: Vimal Singh [mailto:vimal.neww...@gmail.com] Sent: Friday, May 28, 2010 9:14 PM To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH v4 1/3] omap3 gpmc: functionality

Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-27 Thread Vimal Singh
. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/3] omap3 gpmc: functionality enhancement

2010-05-25 Thread Vimal Singh
value yet (omap_calculate_ecc). So how to protect following omap_enable_hwecc() before omap_calculate_ecc()   without additional flag? Any input is welcome. Oh yes, that's is a problem. Perhaps in that case you have to protect it in very much same way you already did. -- Regards, Vimal Singh

Re: [PATCH v3 1/3] omap3 gpmc: functionality enhancement

2010-05-20 Thread Vimal Singh
On Thu, May 20, 2010 at 11:08 AM, Ghorai, Sukumar s-gho...@ti.com wrote: Vimal, -Original Message- From: Vimal Singh [mailto:vimal.neww...@gmail.com] Sent: 2010-05-20 00:01 To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org; linux-...@lists.infradead.org; t...@atomide.com; sako

Re: [PATCH] OMAP: Fix Memory leak

2010-05-20 Thread Vimal Singh
, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP2/3: Keypad: Fix memory leak

2010-05-20 Thread Vimal Singh
. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP2/3: Keypad: Fix memory leak

2010-05-20 Thread Vimal Singh
On Thu, May 20, 2010 at 8:41 PM, Vimal Singh vimal.neww...@gmail.com wrote: On Thu, May 20, 2010 at 7:59 PM, Manjunatha GK manj...@ti.com wrote: From: Damodar x0132...@ti.com This patch corrects Possible memory leak of 'input' allocated through input_allocate_device and Suspicious dereference

Re: [PATCH v3 1/3] omap3 gpmc: functionality enhancement

2010-05-19 Thread Vimal Singh
this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v3 2/3] omap3 nand: cleanup virtual address usages

2010-05-19 Thread Vimal Singh
commit: http://git.infradead.org/mtd-2.6.git/commitdiff/bdaefc41627b6f2815ef7aa476dfa4ebb3ad499f Rest, patches looks good. It is a good clean-up all together. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v3 2/3] omap3 nand: cleanup virtual address usages

2010-05-19 Thread Vimal Singh
understand. I tried to review it fully, but can not say if still something left and gets attention later on. Even sometimes they will become visible when you fix current one. As of now this is all what I had. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v2 1/2] omap3 nand: cleanup for not to use GPMC virtual address

2010-05-17 Thread Vimal Singh
. That's why your code is going into infinite loop -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] omap3 nand: cleanup for not to use GPMC virtual address

2010-05-14 Thread Vimal Singh
)) +               iowrite16(*p++, nand-IO_ADDR_W); +               gpmc_hwcontrol(0, 0, GPMC_GET_SET_STATUS, 0, status); +               while (GPMC_BUF_EMPTY == (status GPMC_BUF_FULL)) same as above. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: Upcoming merge window and omap NAND patches

2010-05-05 Thread Vimal Singh
to be the TI mr. NAND, right? :-) Hi All, Sorry again. I am no more with TI and I don't have any board with me too. So, I'm unable to fix these. :( I hope someone else from TI can take care of it. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH 2/2] omap: gpmc-nand: add ability to keep timings defined by the bootloader

2010-04-30 Thread Vimal Singh
On Thu, Apr 29, 2010 at 12:23 PM, Mike Rapoport m...@compulab.co.il wrote: Vimal Singh wrote: On Wed, Apr 28, 2010 at 9:36 PM, Mike Rapoport m...@compulab.co.il wrote: Signed-off-by: Mike Rapoport m...@compulab.co.il +       if (gpmc_nand_data-keep_timings

Re: [PATCH 2/2] omap: gpmc-nand: add ability to keep timings defined by the bootloader

2010-04-30 Thread Vimal Singh
; +       } + I guess moving this part to omap2_nand_gpmc_retime will be a good idea. As there, once we get old/default timings we can simply skip the rounding part and directly jump to setting the timings. Rest looks fine to me. -- Regards, Vimal Singh -- To unsubscribe from this list: send

Re: Bug in omap2_nand_gpmc_retime? (was: Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied)

2010-04-28 Thread Vimal Singh
converts the timings to ticks. Is it a bug or am I missing something? No, 'omap2_nand_gpmc_retime' does not convert timings supplied by the platform to tick. Rather it rounds the timings passed by the platform to timings in units of 'tick' period. -- Regards, Vimal Singh -- To unsubscribe from

Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-26 Thread Vimal Singh
frequency without breaking your GPMC timings. BTW, there is a patch from Stanley.Miao already in LO: https://patchwork.kernel.org/patch/93613/ But it is still advisable to implement the retime function as stated by Tony. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line

Re: [PATCH 3/6] OMAP NAND: configurable fifo threshold to gain the throughput

2010-04-16 Thread Vimal Singh
Hi Ghorai, On Fri, Apr 16, 2010 at 5:05 PM, Sukumar Ghorai s-gho...@ti.com wrote: [...] - ret = gpmc_prefetch_enable(info-gpmc_cs, 0x0, len, 0x0); + ret = gpmc_prefetch_enable(info-gpmc_cs, 0x40, 0x0, len, 0x0); Use macros here too then. if (ret) { /* PFPW

Re: [PATCH] nand support on omap3 boards

2010-04-13 Thread Vimal Singh
. -- Regards, Vimal Singh On Tue, Apr 13, 2010 at 11:07 PM, Sukumar Ghorai s-gho...@ti.com wrote:   The following set of patches applies on top of the Tony's master branch.   And dependency on following series of patch - Sukumar Ghorai (3):  omap3: GPMC register definition at common location

Re: [PATCH] nand support on omap3 boards

2010-04-13 Thread Vimal Singh
On Wed, Apr 14, 2010 at 10:05 AM, Vimal Singh vimal.neww...@gmail.com wrote: You post this mail in previous thread. Do not do that. ($SUBJECT is same as last one). Post it in different thread. And why this is not posted as a series? In fact these patches should be posted in two set

Re: [RFC] [PATCH 2/3] OMAP4: Keyboard Board Support

2010-04-13 Thread Vimal Singh
, KEY_CAPSLOCK),        KEY(7, 3, KEY_SPACE), @@ -119,31 +116,23 @@ static int omap_keymap[] = {        0,  }; Are you aware of that interpretation of 'row' and 'col' get reversed in matrix keymap framework. Also last element '0' should be removed. -- Regards, Vimal Singh -- To unsubscribe from this list

Re: [PATCH 1/2] OMAP3630SDP: Add support for Flash

2010-04-06 Thread Vimal Singh
On Tue, Apr 6, 2010 at 5:59 PM, Sukumar Ghorai s-gho...@ti.com wrote: Add support for NAND, OneNAND, NOR on OMAP 3630-sdp board. Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- Feel free to add my acked-by: Acked-by: Vimal Singh vimal.neww...@gmail.com Regards, Vimal -- To unsubscribe from

Re: [ASK] OMAP 3430 LDP Trouble

2010-04-06 Thread Vimal Singh
, once you get booted up by any other method. for example serial boot as mentioned by Anand) and use NFS filesystem to work with. NAND driver support is missing in kernel, so, you will not be able to see/mount NAND partitions from kernel. -- Regards, Vimal Singh snip If I understand you correctly

Re: [ASK] OMAP 3430 LDP Trouble

2010-04-04 Thread Vimal Singh
AFAIK, NAND support is currently missing for OMAP3430 LDP boards in LO. -Vimal On Sun, Apr 4, 2010 at 9:34 PM, Ghorai, Sukumar s-gho...@ti.com wrote: Aldyth, 1. Do you mean that NAND boot is not working? 2. Does MMC/SD boot working? If yes, boot the platform from MMC/SD using the latest

Re: [PATCH-V2] OMAP: Fix for bus width which improves SD card's peformance.

2010-03-31 Thread Vimal Singh
 drivers/mmc/host/omap_hsmmc.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 83f0aff..8c97c22 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -2092,7 +2092,7 @@

Re: probe of omap2-nand failed with -16

2010-03-08 Thread Vimal Singh
=88c8460ac32283e2a25e36e4670ff5ab02f3b521 -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] OMAP: ZOOM: Introducing 'board-zoom-flash.c'

2010-02-13 Thread Vimal Singh
On Fri, Feb 12, 2010 at 2:49 AM, Tony Lindgren t...@atomide.com wrote: * Tony Lindgren t...@atomide.com [100211 12:43]: * Vimal Singh vimal.neww...@gmail.com [100210 21:16]: From: Vimal Singh vimalsi...@ti.com This patch adds 'board-zoom-flash.c', which could be utilized by boards

Re: [PATCH 0/3] nand support on zoom boards

2010-02-10 Thread Vimal Singh
Re-posting this patch series once again after re-basing on latest LO master. - vimal On Wed, Jan 13, 2010 at 12:31 PM, Vimal Singh vimal.neww...@gmail.com wrote: From 345704a79f15b0481b14d5d504b0bcdf55f2a9a6 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 12 Jan 2010

[PATCH v2 1/3] OMAP: ZOOM: Introducing 'board-zoom-flash.c'

2010-02-10 Thread Vimal Singh
From: Vimal Singh vimalsi...@ti.com This patch adds 'board-zoom-flash.c', which could be utilized by boards similar to ZOOM2. (For ex: LDP, ZOOM2, ZOOM3). This does initialization for NAND device based on the 'cs' number and partition information passed from board file (ex: board-zoom2.c

[PATCH v2 2/3] OMAP3: Add support for NAND on ZOOM2 board

2010-02-10 Thread Vimal Singh
From: Vimal Singh vimalsi...@ti.com This patch adds NAND support to ZOOM2 board. This uses 'board-zoom-flash.c' for NAND initialization. Signed-off-by: Vimal Singh vimalsi...@ti.com --- arch/arm/mach-omap2/Makefile |1 + arch/arm/mach-omap2/board-zoom2.c | 49

[PATCH v2 3/3] OMAP3: Add support for NAND on ZOOM3 board

2010-02-10 Thread Vimal Singh
From: Vimal Singh vimalsi...@ti.com This patch adds NAND support to ZOOM3 board. Signed-off-by: Vimal Singh vimalsi...@ti.com --- arch/arm/mach-omap2/Makefile |1 + arch/arm/mach-omap2/board-zoom3.c | 49 + 2 files changed, 50 insertions(+), 0

[PATCH v2 0/3] OMAP: NAND: support flashes on sdp boards

2010-02-08 Thread Vimal Singh
On Wed, Jan 13, 2010 at 12:16 PM, Vimal Singh vimal.neww...@gmail.com wrote: From 4fbddd880c7a0da61fb66ae1d2c2553e3fbc82cb Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 12 Jan 2010 18:14:14 +0530 Subject: [PATCH] OMAP: NAND: support flashes on sdp boards Reposting

[PATCH v2 1/3] Introducing 'gpmc-nand.c' for GPMC specific NAND init

2010-02-08 Thread Vimal Singh
From 35da04834f4b0363e90a628bdb369318d80b7a6c Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Fri, 5 Feb 2010 05:56:18 +0530 Subject: [PATCH 1/3] Introducing 'gpmc-nand.c' for GPMC specific NAND init Introducing 'gpmc-nand.c' for GPMC specific NAND init. For example: GPMC

[PATCH v2 2/3] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2010-02-08 Thread Vimal Singh
From e586d2fbbecc60bc66687c4e6d4798913bb33b7a Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Mon, 8 Feb 2010 05:02:45 +0530 Subject: [PATCH 2/3] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init This patch adds 'board-sdp-flash.c', which could be utilized by boards

[PATCH v2 3/3] OMAP3: Add support for flash on 3430SDP board

2010-02-08 Thread Vimal Singh
From d3e5ee6d8a6449aee01fbc93313201a4674f5577 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Mon, 8 Feb 2010 05:06:33 +0530 Subject: [PATCH 3/3] OMAP3: Add support for flash on 3430SDP board This patch adds support for flashes on 3430SDP boards. All three NAND, NOR and OneNAND

Re: [PATCH v2 2/3] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2010-02-08 Thread Vimal Singh
sdp_nor_data = { +     .width          = 2, +     .set_vpp        = omap_set_vpp, +}; ... and in case there is not, just leave set_vpp set to NULL and delete this incarnation of omap_set_vpp. My bad. I just did not look into that. I'll fix it as per your suggestion. -- Regards, Vimal Singh

[PATCH v3 2/3] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2010-02-08 Thread Vimal Singh
In this version: (as per comments recieved for 2nd version) - remove 'omap_set_vpp' function - set 'set_vpp' to null These changes do not have any impact on rest of the patches in series. -vimal From 6199d9c4db83dfd006f7cc2e74089ca1e9fdf8dc Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi

Re: [PATCH v3 2/3] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2010-02-08 Thread Vimal Singh
On Mon, Feb 8, 2010 at 9:02 PM, Ladislav Michl ladislav.mi...@seznam.cz wrote: On Mon, Feb 08, 2010 at 06:38:57PM +0530, Vimal Singh wrote: In this version: (as per comments recieved for 2nd version) - remove 'omap_set_vpp' function - set 'set_vpp' to null Ah, I'm sorry for not being quite

[PATCH v3 2/3] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2010-02-08 Thread Vimal Singh
Sorry, mailer corrupted the last patch (line wrapped). Here is the correct patch. - vimal From f931fb85b774f97db3b0a25cde4a8154bb8d6dba Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Mon, 8 Feb 2010 05:02:45 +0530 Subject: [PATCH] OMAP: SDP: Introducing 'board-sdp-flash.c

Re: [PATCH 1/3] Introducing 'gpmc-nand.c' for GPMC specific NAND init

2010-02-04 Thread Vimal Singh
On Fri, Feb 5, 2010 at 5:17 AM, Tony Lindgren t...@atomide.com wrote: Hi, Almost there.. Few more comments below. * Vimal Singh vimal.neww...@gmail.com [100112 22:48]: From 89eaa5d55e04f65e76ad49ed8b010cba578d91ca Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Mon, 11

Re: NAND misreads on omap beagle and overo

2010-01-29 Thread Vimal Singh
? -- Jeff DeFouw je...@i2k.com __ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH v3]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2010-01-12 Thread Vimal Singh
On Tue, Jan 12, 2010 at 6:31 AM, Tony Lindgren t...@atomide.com wrote: Hi, Few more comments below. * Vimal Singh vimal.neww...@gmail.com [100111 02:47]: On Mon, Jan 11, 2010 at 4:10 PM, Vimal Singh vimal.neww...@gmail.com wrote: Re-summiting this patch. After re-basing on LO master

[PATCH 1/3] Introducing 'gpmc-nand.c' for GPMC specific NAND init

2010-01-12 Thread Vimal Singh
From 89eaa5d55e04f65e76ad49ed8b010cba578d91ca Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Mon, 11 Jan 2010 16:01:29 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific NAND init Introducing 'gpmc-nand.c' for GPMC specific NAND init. For example: GPMC timing

[PATCH 2/3] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2010-01-12 Thread Vimal Singh
From 994785b066a9bd4fbaf7753cb6ab7317440afd36 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 12 Jan 2010 17:22:42 +0530 Subject: [PATCH] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init This patch adds 'board-sdp-flash.c', which could be utilized by boards

[PATCH 3/3] OMAP3: Add support for flash on 3430SDP board

2010-01-12 Thread Vimal Singh
From 4fbddd880c7a0da61fb66ae1d2c2553e3fbc82cb Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 12 Jan 2010 17:23:57 +0530 Subject: [PATCH] OMAP3: Add support for flash on 3430SDP board This patch adds support for flashes on 3430SDP boards. All three NAND, NOR and OneNAND

[PATCH 0/3] nand support on zoom boards

2010-01-12 Thread Vimal Singh
From 345704a79f15b0481b14d5d504b0bcdf55f2a9a6 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 12 Jan 2010 18:12:53 +0530 Subject: [PATCH] nand support on zoom boards I have verified it on zoom2/3 support on zoom boards. I still have not tried it on LDP (zoom1) board. So

[PATCH 1/3] OMAP: ZOOM: Introducing 'board-zoom-flash.c'

2010-01-12 Thread Vimal Singh
From c97a9126f713fa7577ea555a555dc9f22513c154 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 12 Jan 2010 17:26:07 +0530 Subject: [PATCH] OMAP: ZOOM: Introducing 'board-zoom-flash.c' This patch adds 'board-zoom-flash.c', which could be utilized by boards similar to ZOOM2

[PATCH 3/3] OMAP3: Add support for NAND on ZOOM3 board

2010-01-12 Thread Vimal Singh
From 345704a79f15b0481b14d5d504b0bcdf55f2a9a6 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 12 Jan 2010 17:56:44 +0530 Subject: [PATCH] OMAP3: Add support for NAND on ZOOM3 board This patch adds NAND support to ZOOM3 board. Signed-off-by: Vimal Singh vimalsi...@ti.com

[PATCH v3]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2010-01-11 Thread Vimal Singh
Re-summiting this patch. After re-basing on LO master. -vimal From a7ea8851fe96690c9322393eb35a344853992166 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Mon, 11 Jan 2010 16:01:29 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific NAND init Introducing

Re: [PATCH v3]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2010-01-11 Thread Vimal Singh
On Mon, Jan 11, 2010 at 4:10 PM, Vimal Singh vimal.neww...@gmail.com wrote: Re-summiting this patch. After re-basing on LO master. -vimal From a7ea8851fe96690c9322393eb35a344853992166 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Mon, 11 Jan 2010 16:01:29 +0530

Re: Issue in oamp nand driver with 32-bit reads in prefetch mode

2010-01-10 Thread Vimal Singh
On Sun, Jan 10, 2010 at 2:16 PM, Artem Bityutskiy dedeki...@gmail.com wrote: On Thu, 2009-12-31 at 17:50 +0530, Vimal Singh wrote: There is a bug in nand prefetch read routine, which comes into effect only if nand device is a 16-bit device (as we have in zoom boards). This bug is effective

Re: [PATCH 1/3][NAND][OMAP]: Fixing compilation warning for 'nand/omap2.c'

2010-01-08 Thread Vimal Singh
On Fri, Jan 8, 2010 at 8:31 PM, Premi, Sanjeev pr...@ti.com wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Vimal Singh Sent: Wednesday, January 06, 2010 7:30 PM To: Linux MTD Cc: linux-omap@vger.kernel.org

[PATCH 0/3][NAND][OMAP]: fixing omap nand driver issues

2010-01-06 Thread Vimal Singh
From 3700088e8da8c890d9e4c6eb626e18287d149b97 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 5 Jan 2010 16:43:08 +0530 Subject: [PATCH] fixing omap nand driver issues fixing omap nand driver issues. Vimal Singh (3): Fixing compilation warning for 'nand/omap2.c' NAND

[PATCH 1/3][NAND][OMAP]: Fixing compilation warning for 'nand/omap2.c'

2010-01-06 Thread Vimal Singh
From 3e856346f93afaf3f519dffe7987e4bbf56a136d Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 5 Jan 2010 12:49:24 +0530 Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c' Fixing below warning in compilation: drivers/mtd/nand/omap2.c: In function

[PATCH 2/3][NAND][OMAP]: correct 'info' pointer in 'omap_nand_remove'

2010-01-06 Thread Vimal Singh
From bf5256c8c29100c3a55e29a8a5d6718ba5817519 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 5 Jan 2010 16:01:08 +0530 Subject: [PATCH] NAND: OMAP: correct 'info' pointer in 'omap_nand_remove' Removing OMAP NAND driver, when loaded as a module, gives error and does

[PATCH 3/3][NAND][OMAP]: Fixing issue in oamp nand driver in prefetch mode read

2010-01-06 Thread Vimal Singh
From 3700088e8da8c890d9e4c6eb626e18287d149b97 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 5 Jan 2010 16:37:03 +0530 Subject: [PATCH] NAND: OMAP: Fixing issue in oamp nand driver in prefetch mode read There is a bug in nand prefetch read routine, which comes into effect

Re: [PATCH v2 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2010-01-06 Thread Vimal Singh
On Wed, Jan 6, 2010 at 8:04 PM, Artem Bityutskiy dedeki...@gmail.com wrote: On Mon, 2009-12-14 at 15:17 +0530, Vimal Singh wrote: From 6170aa1c63c49a3f09e76258f400230b742fdd6f Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Wed, 25 Nov 2009 18:23:15 +0530 Subject: [PATCH

Re: [PATCH 3/3][NAND][OMAP]: Fixing issue in oamp nand driver in prefetch mode read

2010-01-06 Thread Vimal Singh
On Wed, Jan 6, 2010 at 7:36 PM, Vimal Singh vimal.neww...@gmail.com wrote: From 3700088e8da8c890d9e4c6eb626e18287d149b97 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 5 Jan 2010 16:37:03 +0530 Subject: [PATCH] NAND: OMAP: Fixing issue in oamp nand driver in prefetch

Re: [PATCH 1/2]: OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2010-01-04 Thread Vimal Singh
Tony, On Tue, Dec 22, 2009 at 2:21 PM, Vimal Singh vimal.neww...@gmail.com wrote: On Tue, Dec 15, 2009 at 1:01 AM, Tony Lindgren t...@atomide.com wrote: * Vimal Singh vimal.neww...@gmail.com [091214 01:58]: On Tue, Dec 8, 2009 at 12:06 AM, Tony Lindgren t...@atomide.com wrote: * Vimal Singh

Re: Issue in oamp nand driver with 32-bit reads in prefetch mode

2009-12-31 Thread Vimal Singh
On Wed, Dec 30, 2009 at 3:17 AM, Steve Sakoman sako...@gmail.com wrote: On Tue, Dec 29, 2009 at 12:38 PM, Steve Sakoman sako...@gmail.com wrote: I can confirm that this issue exists on Overo too.  Sadly, switching to 16 bit reads does not fix the issue for me.  I'll start digging to see if I

Issue in oamp nand driver with 32-bit reads in prefetch mode

2009-12-23 Thread Vimal Singh
'ioread16_rep' i.e.: __raw_readwl) makes it working fine. (A patch to do this is listed below at the bottom of this mail.) I have not seen any change in routine '__raw_readsl'. So, could someone help me find out the root cause the issue? Thanks for any input. -- Regards, Vimal Singh diff --git

Re: [PATCH 1/2]: OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2009-12-22 Thread Vimal Singh
On Tue, Dec 15, 2009 at 1:01 AM, Tony Lindgren t...@atomide.com wrote: * Vimal Singh vimal.neww...@gmail.com [091214 01:58]: On Tue, Dec 8, 2009 at 12:06 AM, Tony Lindgren t...@atomide.com wrote: * Vimal Singh vimal.neww...@gmail.com [091206 22:39]: On Sat, Dec 5, 2009 at 3:47 AM, Tony

[PATCH] OMAP: ZOOM2: Correcting key mapping for few keys

2009-12-17 Thread Vimal Singh
From ab3239189c25a19d7764042cc3f05cce8a91f291 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Fri, 18 Dec 2009 12:09:10 +0530 Subject: [PATCH] OMAP: ZOOM2: Correcting key mapping for few keys Keys: 'right arrow', 'up arrow' and 'select' were mapped wrongly. This patch corrects

[PATCH] OMAP: NAND: Adding config option to enable/disable HW ECC mode

2009-12-15 Thread Vimal Singh
OMAP NAND driver got HW ECC implemented. From d5e28c9fdbc6b0a95c1259fac7add207f9c294d7 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 15 Dec 2009 21:10:54 +0530 Subject: [PATCH] OMAP: NAND: Adding config option to enable/disable HW ECC mode This patch adds config option

Re: [PATCH] OMAP: NAND: Adding config option to enable/disable HW ECC mode

2009-12-15 Thread Vimal Singh
On Tue, Dec 15, 2009 at 11:05 PM, Tony Lindgren t...@atomide.com wrote: * Vimal Singh vimal.neww...@gmail.com [091215 07:45]: OMAP NAND driver got HW ECC implemented. From d5e28c9fdbc6b0a95c1259fac7add207f9c294d7 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 15 Dec

[PATCH v2 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-14 Thread Vimal Singh
From 6170aa1c63c49a3f09e76258f400230b742fdd6f Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Wed, 25 Nov 2009 18:23:15 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific NAND init Introducing 'gpmc-nand.c' for GPMC specific NAND init. For example: GPMC timing

Re: [PATCH 1/2]: OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2009-12-14 Thread Vimal Singh
On Tue, Dec 8, 2009 at 12:06 AM, Tony Lindgren t...@atomide.com wrote: * Vimal Singh vimal.neww...@gmail.com [091206 22:39]: On Sat, Dec 5, 2009 at 3:47 AM, Tony Lindgren t...@atomide.com wrote: Hi, * Vimal Singh vimal.neww...@gmail.com [091203 06:09]: From

Re: [PATCH v2 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-14 Thread Vimal Singh
Last time I forgot to cc linux-arm-ker...@lists.infradead.org. Looping now. -vimal On Mon, Dec 14, 2009 at 3:17 PM, Vimal Singh vimal.neww...@gmail.com wrote: From 6170aa1c63c49a3f09e76258f400230b742fdd6f Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Wed, 25 Nov 2009 18

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-13 Thread Vimal Singh
for replying late. Last week I was on vacation. I will drop new version of this patch today. -- Regards, Vimal Singh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-07 Thread Vimal Singh
On Mon, Dec 7, 2009 at 11:59 AM, Vimal Singh vimal.neww...@gmail.com wrote: On Sat, Dec 5, 2009 at 3:31 AM, Tony Lindgren t...@atomide.com wrote: Hi, Looks good, just one comment below. * Govindraj.R govindraj.r...@ti.com [091204 05:37]: From: Vimal Singh vimalsi...@ti.com Date: Wed, 25

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-06 Thread Vimal Singh
On Sat, Dec 5, 2009 at 3:31 AM, Tony Lindgren t...@atomide.com wrote: Hi, Looks good, just one comment below. * Govindraj.R govindraj.r...@ti.com [091204 05:37]: From: Vimal Singh vimalsi...@ti.com Date: Wed, 25 Nov 2009 18:23:15 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC

Re: [PATCH 1/2]: OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2009-12-06 Thread Vimal Singh
On Sat, Dec 5, 2009 at 3:47 AM, Tony Lindgren t...@atomide.com wrote: Hi, * Vimal Singh vimal.neww...@gmail.com [091203 06:09]: From 13d52884956a26f93826c443e2b8bd78615f74d6 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Thu, 26 Nov 2009 16:10:24 +0530 Subject: [PATCH

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-04 Thread Vimal Singh
Hi all, Please ignore previous patch, it has a compilation error. Correct patch is present below. -vimal From e024a2e6aa2051259ad904daff13bdac73b3b1b8 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Wed, 25 Nov 2009 18:23:15 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-04 Thread Vimal Singh
e024a2e6aa2051259ad904daff13bdac73b3b1b8 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Wed, 25 Nov 2009 18:23:15 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific NAND init Introducing 'gpmc-nand.c' for GPMC specific NAND init. For example: GPMC timing parameters and all. This patch also

[PATCH 0/2]OMAP: Introducing gpmc-nand.c

2009-12-03 Thread Vimal Singh
From fadc45cca4026d26d00a759efdc681303b0d3097 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Thu, 3 Dec 2009 18:35:23 +0530 Subject: [PATCH] OMAP: Introducing gpmc-nand.c This patch series introduces generic gpmc-nand.c for nand device related gpmc init. Vimal Singh (2

[PATCH 1/2]: Correcting GPMC_CONFIG1_DEVICETYPE_NAND

2009-12-03 Thread Vimal Singh
From efeeb1cfc592c827424b4c76b18150e801bdfbab Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Wed, 25 Nov 2009 17:47:46 +0530 Subject: [PATCH] Correcting GPMC_CONFIG1_DEVICETYPE_NAND For NAND devices '2' should be used with GPMC_CONFIG1_DEVICETYPE instead of '1'. Signed-off

[PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-03 Thread Vimal Singh
From fadc45cca4026d26d00a759efdc681303b0d3097 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Wed, 25 Nov 2009 18:23:15 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific NAND init Introducing 'gpmc-nand.c' for GPMC specific NAND init. For example: GPMC timing

[PATCH 1/2]: OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init

2009-12-03 Thread Vimal Singh
From 13d52884956a26f93826c443e2b8bd78615f74d6 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Thu, 26 Nov 2009 16:10:24 +0530 Subject: [PATCH] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init This patch adds 'board-sdp-flash.c', which could be utilized by boards

[PATCH 2/2]: OMAP3: Add support for flash on 3430SDP board

2009-12-03 Thread Vimal Singh
From f48199dc44e1bf5f56aa981d20f35dc8ce1113bf Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 1 Dec 2009 11:24:46 +0530 Subject: [PATCH] OMAP3: Add support for flash on 3430SDP board This patch adds support for flashes on 3430SDP boards. All three NAND, NOR and OneNAND

[PATCH 0/4]: Adding NAND support for LDP/ZOOM boards

2009-12-03 Thread Vimal Singh
From 1786a05d3331850ff5c49e4edafe68a411597173 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Thu, 3 Dec 2009 18:36:11 +0530 Subject: [PATCH] Adding NAND support for LDP/ZOOM boards '1st' patch in this series introduces 'board-zoom-flash.c' for NAND init in ZOOM boards. Other

[PATCH 1/4]: OMAP: ZOOM: Introducing 'board-zoom-flash.c' for NAND init in ZOOM boards

2009-12-03 Thread Vimal Singh
From 948584f4157a9eb99ba085968d23add28cbfd160 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Tue, 1 Dec 2009 11:36:56 +0530 Subject: [PATCH] OMAP: ZOOM: Introducing 'board-zoom-flash.c' This patch adds 'board-zoom-flash.c', which could be utilized by boards similar to ZOOM2

[PATCH 2/4]: OMAP3: Add support for NAND on ZOOM2 board

2009-12-03 Thread Vimal Singh
From 06890a29ed85068787d2bc3af3c38d29b4e0e421 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Thu, 3 Dec 2009 18:21:44 +0530 Subject: [PATCH] OMAP3: Add support for NAND on ZOOM2 board This patch adds NAND support to ZOOM2 board. This uses 'board-zoom-flash.c' for NAND

[PATCH 3/4]: OMAP3: Add support for NAND on ZOOM3 board

2009-12-03 Thread Vimal Singh
From 4259c6ae2e6d9b5e316fa8289a9fca729fc6bc83 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Thu, 3 Dec 2009 18:23:37 +0530 Subject: [PATCH] OMAP3: Add support for NAND on ZOOM3 board This patch adds NAND support to ZOOM3 board. Signed-off-by: Vimal Singh vimalsi...@ti.com

[PATCH 4/4]: OMAP3: Add support for NAND on LDP board

2009-12-03 Thread Vimal Singh
From 1786a05d3331850ff5c49e4edafe68a411597173 Mon Sep 17 00:00:00 2001 From: Vimal Singh vimalsi...@ti.com Date: Thu, 3 Dec 2009 18:26:45 +0530 Subject: [PATCH] OMAP3: Add support for NAND on LDP board This patch adds NAND support to LDP board. Signed-off-by: Vimal Singh vimalsi...@ti.com

  1   2   >