Re: [PATCH] ARM: OMAP: Clean-up MMC device init (Was: [PATCH]Enable 4-bit in HSMMC1 and HSMMC2 platform data)

2008-09-24 Thread Tony Lindgren
* Russell King - ARM Linux [EMAIL PROTECTED] [080917 10:58]: On Tue, Sep 16, 2008 at 04:13:57PM -0700, Tony Lindgren wrote: OK Here's the patch updated. If necessary, the patch could be broken into several parts. I've already got a patch doing what I've outlined (and some other

Re: [PATCH] ARM: OMAP: Clean-up MMC device init (Was: [PATCH]Enable 4-bit in HSMMC1 and HSMMC2 platform data)

2008-09-17 Thread Russell King - ARM Linux
On Tue, Sep 16, 2008 at 04:13:57PM -0700, Tony Lindgren wrote: OK Here's the patch updated. If necessary, the patch could be broken into several parts. I've already got a patch doing what I've outlined (and some other stuff) I just haven't had time to finish it off to email out yet. -- To

Re: [PATCH] ARM: OMAP: Clean-up MMC device init (Was: [PATCH]Enable 4-bit in HSMMC1 and HSMMC2 platform data)

2008-09-16 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080913 10:12]: * Russell King - ARM Linux [EMAIL PROTECTED] [080913 03:00]: On Thu, Sep 11, 2008 at 05:48:49PM -0700, Tony Lindgren wrote: snip Maybe these functions should also be taking note of info-nr_slots? Though I don't particularly like the way

Re: [PATCH] ARM: OMAP: Clean-up MMC device init (Was: [PATCH]Enable 4-bit in HSMMC1 and HSMMC2 platform data)

2008-09-16 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080916 16:14]: * Tony Lindgren [EMAIL PROTECTED] [080913 10:12]: * Russell King - ARM Linux [EMAIL PROTECTED] [080913 03:00]: On Thu, Sep 11, 2008 at 05:48:49PM -0700, Tony Lindgren wrote: snip Maybe these functions should also be taking note of

Re: [PATCH] ARM: OMAP: Clean-up MMC device init (Was: [PATCH]Enable 4-bit in HSMMC1 and HSMMC2 platform data)

2008-09-13 Thread Russell King - ARM Linux
On Thu, Sep 11, 2008 at 05:48:49PM -0700, Tony Lindgren wrote: +static inline void omap1_mmc_mux(struct omap_mmc_platform_data *info) +{ + if (info-slots[0].enabled) { + omap_cfg_reg(MMC_CMD); + omap_cfg_reg(MMC_CLK); + omap_cfg_reg(MMC_DAT0); +

Re: [PATCH] ARM: OMAP: Clean-up MMC device init (Was: [PATCH]Enable 4-bit in HSMMC1 and HSMMC2 platform data)

2008-09-13 Thread Tony Lindgren
* Russell King - ARM Linux [EMAIL PROTECTED] [080913 03:00]: On Thu, Sep 11, 2008 at 05:48:49PM -0700, Tony Lindgren wrote: +static inline void omap1_mmc_mux(struct omap_mmc_platform_data *info) +{ + if (info-slots[0].enabled) { + omap_cfg_reg(MMC_CMD); +

[PATCH] ARM: OMAP: Clean-up MMC device init (Was: [PATCH]Enable 4-bit in HSMMC1 and HSMMC2 platform data)

2008-09-11 Thread Tony Lindgren
* Russell King - ARM Linux [EMAIL PROTECTED] [080911 11:13]: On Thu, Sep 11, 2008 at 10:33:33AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux [EMAIL PROTECTED] [080911 02:13]: New version of the MMC updates for mainline pushed out - with additional cleanups in place (and since