Re: Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-06-14 Thread Péter Ujfalusi
Hi Tony, On Monday 13 June 2011 15:35:43 Tony Lindgren wrote: Sure we can merge fixes Can you take this patch forward? but let's get the move done before adding new features. What is considered a new feature here? Is it a new feature, if I fix the McBSP for OMAP4 (FIFO usage, and small

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-06-14 Thread Jarkko Nikula
On Tue, 14 Jun 2011 14:19:34 +0300 Péter Ujfalusi peter.ujfal...@ti.com wrote: We have discussion ongoing about the mcbsp code move, and so far the current understanding/plan is (Jarkko/Liam correct me if I'm wrong): - Fix the OMAP4 support - move the code under sound/soc/omap/ - the

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-06-14 Thread Tony Lindgren
* Jarkko Nikula jhnik...@gmail.com [110614 04:59]: On Tue, 14 Jun 2011 14:19:34 +0300 Péter Ujfalusi peter.ujfal...@ti.com wrote: We have discussion ongoing about the mcbsp code move, and so far the current understanding/plan is (Jarkko/Liam correct me if I'm wrong): - Fix the OMAP4

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-06-13 Thread Tony Lindgren
* Peter Ujfalusi peter.ujfal...@ti.com [110608 00:46]: Hi Tony, On Tuesday 31 May 2011 10:57:02 Tony Lindgren wrote: Sure, but that's the only option we have to merge any new code. So this patch will be not taken (even if without this patch OMAP4 McBSP is broken), unless we move the

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-06-08 Thread Peter Ujfalusi
Hi Tony, On Tuesday 31 May 2011 10:57:02 Tony Lindgren wrote: Sure, but that's the only option we have to merge any new code. So this patch will be not taken (even if without this patch OMAP4 McBSP is broken), unless we move the McBSP code out from plat-omap? I have discussed with Jarkko, and

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-31 Thread Tony Lindgren
* Jarkko Nikula jhnik...@gmail.com [110518 00:54]: On Wed, 18 May 2011 08:52:07 +0300 Peter Ujfalusi peter.ujfal...@ti.com wrote: On Tuesday 17 May 2011 15:57:00 Tony Lindgren wrote: This file should be under drivers/ somewhere, can you guys please take care of that? Yeah, this

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-31 Thread Tony Lindgren
* Peter Ujfalusi peter.ujfal...@ti.com [110518 05:36]: Hi Tony, On Tuesday 17 May 2011 15:57:00 Tony Lindgren wrote: This file should be under drivers/ somewhere, can you guys please take care of that? Do you have a place in mind? How about drivers/mcbsp? We have several things under

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-18 Thread Jarkko Nikula
On Wed, 18 May 2011 08:52:07 +0300 Peter Ujfalusi peter.ujfal...@ti.com wrote: On Tuesday 17 May 2011 15:57:00 Tony Lindgren wrote: This file should be under drivers/ somewhere, can you guys please take care of that? Yeah, this has been discussed several times, and we have not reached

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-18 Thread Peter Ujfalusi
Hi Tony, On Tuesday 17 May 2011 15:57:00 Tony Lindgren wrote: This file should be under drivers/ somewhere, can you guys please take care of that? Do you have a place in mind? We have several things under arch/arm/plat-omap, like i2c, dma, fb, gpio, mcbsp, usb... Should we create a directory

[PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-17 Thread Peter Ujfalusi
On OMAP4 we have one interrupt line per McBSP port. At proble time tx, and rx irq value will be -ENXIO, and only the tx irq will get corrected. In omap_mcbsp_request if the rx_irq is not 0 we proceed, and try to request the interrupt, which will fail on OMAP4 (rx_irq == -6). To avoid this error,

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-17 Thread Jarkko Nikula
On Tue, 17 May 2011 13:33:40 +0300 Peter Ujfalusi peter.ujfal...@ti.com wrote: On OMAP4 we have one interrupt line per McBSP port. At proble time tx, and rx irq value will be -ENXIO, and only the tx irq will get corrected. In omap_mcbsp_request if the rx_irq is not 0 we proceed, and try to

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-17 Thread Tony Lindgren
* Jarkko Nikula jhnik...@gmail.com [110517 15:24]: On Tue, 17 May 2011 13:33:40 +0300 Peter Ujfalusi peter.ujfal...@ti.com wrote: On OMAP4 we have one interrupt line per McBSP port. At proble time tx, and rx irq value will be -ENXIO, and only the tx irq will get corrected. In

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-17 Thread Peter Ujfalusi
On Tuesday 17 May 2011 15:57:00 Tony Lindgren wrote: This file should be under drivers/ somewhere, can you guys please take care of that? Yeah, this has been discussed several times, and we have not reached agreement where to move this very OMAP specific code. One option was to move it under